[PATCH] ASoC: rt5514: Fix event generation for "DSP Voice Wake Up" control

[PATCH] ASoC: rt5514: Fix event generation for "DSP Voice Wake Up" control

[Mark Brown]

The driver has a custom put function for "DSP Voice Wake Up" which does
not generate event notifications on change, instead returning 0. Since we
already exit early in the case that there is no change this can be fixed
by unconditionally returning 1 at the end of the function.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/rt5514.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/rt5514.c b/sound/soc/codecs/rt5514.c
index 1b9263460142..be8ece4630df 100644
--- a/sound/soc/codecs/rt5514.c
+++ b/sound/soc/codecs/rt5514.c
@@ -419,7 +419,7 @@ static int rt5514_dsp_voice_wake_up_put(struct snd_kcontrol *kcontrol,
 		}
 	}
 
-	return 0;
+	return 1;
 }
 
 static const struct snd_kcontrol_new rt5514_snd_controls[] = {
-- 
2.30.2

Re: [PATCH] ASoC: rt5514: Fix event generation for "DSP Voice Wake Up" control

[Mark Brown]

On Thu, 28 Apr 2022 17:24:44 +0100, Mark Brown wrote:
> The driver has a custom put function for "DSP Voice Wake Up" which does
> not generate event notifications on change, instead returning 0. Since we
> already exit early in the case that there is no change this can be fixed
> by unconditionally returning 1 at the end of the function.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rt5514: Fix event generation for "DSP Voice Wake Up" control
      commit: 4213ff556740bb45e2d9ff0f50d056c4e7dd0921

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark