* [PATCH 0/2] Add pinctrl support adsp based platforms
@ 2022-05-04 13:56 Srinivasa Rao Mandadapu
2022-05-04 13:56 ` Srinivasa Rao Mandadapu
2022-05-04 13:56 ` Srinivasa Rao Mandadapu
0 siblings, 2 replies; 11+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-05-04 13:56 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, quic_rohkumar,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, Linus Walleij, linux-gpio
Cc: Srinivasa Rao Mandadapu
This patch set is to add pinctrl support adsp enabled sc7280 platforms.
Srinivasa Rao Mandadapu (2):
dt-bindings: pinctrl: qcom: sc7280: Add compatible string for adsp
based platforms
pinctrl: qcom: sc7280: Add lpi pinctrl variant data structure for adsp
based targets
.../bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 4 +++-
drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 14 ++++++++++++++
2 files changed, 17 insertions(+), 1 deletion(-)
--
2.7.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/2] dt-bindings: pinctrl: qcom: sc7280: Add compatible string for adsp based platforms
2022-05-04 13:56 [PATCH 0/2] Add pinctrl support adsp based platforms Srinivasa Rao Mandadapu
@ 2022-05-04 13:56 ` Srinivasa Rao Mandadapu
2022-05-04 13:56 ` Srinivasa Rao Mandadapu
1 sibling, 0 replies; 11+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-05-04 13:56 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, quic_rohkumar,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, Linus Walleij, linux-gpio
Cc: Srinivasa Rao Mandadapu, Venkata Prasad Potturu
Add compatible string to support adsp enabled sc7280 platforms.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
.../devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
index d32ee32..53c2c59 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
@@ -17,7 +17,9 @@ description: |
properties:
compatible:
- const: qcom,sc7280-lpass-lpi-pinctrl
+ enum:
+ - qcom,sc7280-lpass-lpi-pinctrl
+ - qcom,sc7280-lpass-adsp-lpi-pinctrl
reg:
minItems: 2
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 1/2] dt-bindings: pinctrl: qcom: sc7280: Add compatible string for adsp based platforms
@ 2022-05-04 13:56 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 11+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-05-04 13:56 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, quic_rohkumar,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, Linus Walleij, linux-gpio
Cc: Venkata Prasad Potturu, Srinivasa Rao Mandadapu
Add compatible string to support adsp enabled sc7280 platforms.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
.../devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
index d32ee32..53c2c59 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
@@ -17,7 +17,9 @@ description: |
properties:
compatible:
- const: qcom,sc7280-lpass-lpi-pinctrl
+ enum:
+ - qcom,sc7280-lpass-lpi-pinctrl
+ - qcom,sc7280-lpass-adsp-lpi-pinctrl
reg:
minItems: 2
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/2] pinctrl: qcom: sc7280: Add lpi pinctrl variant data structure for adsp based targets
2022-05-04 13:56 [PATCH 0/2] Add pinctrl support adsp based platforms Srinivasa Rao Mandadapu
@ 2022-05-04 13:56 ` Srinivasa Rao Mandadapu
2022-05-04 13:56 ` Srinivasa Rao Mandadapu
1 sibling, 0 replies; 11+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-05-04 13:56 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, quic_rohkumar,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, Linus Walleij, linux-gpio
Cc: Srinivasa Rao Mandadapu, Venkata Prasad Potturu
Add compatible string and lpi pinctrl variant data structure for adsp enabled
sc7280 platforms.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
index 2add9a4..c9e85d9 100644
--- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
+++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
@@ -134,6 +134,16 @@ static const struct lpi_function sc7280_functions[] = {
LPI_FUNCTION(wsa_swr_data),
};
+static const struct lpi_pinctrl_variant_data sc7280_adsp_lpi_data = {
+ .pins = sc7280_lpi_pins,
+ .npins = ARRAY_SIZE(sc7280_lpi_pins),
+ .groups = sc7280_groups,
+ .ngroups = ARRAY_SIZE(sc7280_groups),
+ .functions = sc7280_functions,
+ .nfunctions = ARRAY_SIZE(sc7280_functions),
+ .is_clk_optional = false,
+};
+
static const struct lpi_pinctrl_variant_data sc7280_lpi_data = {
.pins = sc7280_lpi_pins,
.npins = ARRAY_SIZE(sc7280_lpi_pins),
@@ -149,6 +159,10 @@ static const struct of_device_id lpi_pinctrl_of_match[] = {
.compatible = "qcom,sc7280-lpass-lpi-pinctrl",
.data = &sc7280_lpi_data,
},
+ {
+ .compatible = "qcom,sc7280-lpass-adsp-lpi-pinctrl",
+ .data = &sc7280_adsp_lpi_data,
+ },
{ }
};
MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match);
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/2] pinctrl: qcom: sc7280: Add lpi pinctrl variant data structure for adsp based targets
@ 2022-05-04 13:56 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 11+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-05-04 13:56 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, quic_rohkumar,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao, Linus Walleij, linux-gpio
Cc: Venkata Prasad Potturu, Srinivasa Rao Mandadapu
Add compatible string and lpi pinctrl variant data structure for adsp enabled
sc7280 platforms.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
---
drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
index 2add9a4..c9e85d9 100644
--- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
+++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
@@ -134,6 +134,16 @@ static const struct lpi_function sc7280_functions[] = {
LPI_FUNCTION(wsa_swr_data),
};
+static const struct lpi_pinctrl_variant_data sc7280_adsp_lpi_data = {
+ .pins = sc7280_lpi_pins,
+ .npins = ARRAY_SIZE(sc7280_lpi_pins),
+ .groups = sc7280_groups,
+ .ngroups = ARRAY_SIZE(sc7280_groups),
+ .functions = sc7280_functions,
+ .nfunctions = ARRAY_SIZE(sc7280_functions),
+ .is_clk_optional = false,
+};
+
static const struct lpi_pinctrl_variant_data sc7280_lpi_data = {
.pins = sc7280_lpi_pins,
.npins = ARRAY_SIZE(sc7280_lpi_pins),
@@ -149,6 +159,10 @@ static const struct of_device_id lpi_pinctrl_of_match[] = {
.compatible = "qcom,sc7280-lpass-lpi-pinctrl",
.data = &sc7280_lpi_data,
},
+ {
+ .compatible = "qcom,sc7280-lpass-adsp-lpi-pinctrl",
+ .data = &sc7280_adsp_lpi_data,
+ },
{ }
};
MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match);
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: sc7280: Add compatible string for adsp based platforms
2022-05-04 13:56 ` Srinivasa Rao Mandadapu
@ 2022-05-05 17:28 ` Rob Herring
-1 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2022-05-05 17:28 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: judyhsiao, broonie, perex, quic_plai, alsa-devel, tiwai, swboyd,
linux-arm-msm, linux-kernel, lgirdwood, bgoswami,
srinivas.kandagatla, devicetree, quic_rohkumar, robh+dt, agross,
Linus Walleij, Venkata Prasad Potturu, linux-gpio,
bjorn.andersson
On Wed, 04 May 2022 19:26:19 +0530, Srinivasa Rao Mandadapu wrote:
> Add compatible string to support adsp enabled sc7280 platforms.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
> .../devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: sc7280: Add compatible string for adsp based platforms
@ 2022-05-05 17:28 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2022-05-05 17:28 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: devicetree, alsa-devel, quic_rohkumar, Venkata Prasad Potturu,
lgirdwood, linux-arm-msm, Linus Walleij, bjorn.andersson, tiwai,
robh+dt, linux-gpio, broonie, srinivas.kandagatla, agross,
bgoswami, quic_plai, swboyd, judyhsiao, linux-kernel
On Wed, 04 May 2022 19:26:19 +0530, Srinivasa Rao Mandadapu wrote:
> Add compatible string to support adsp enabled sc7280 platforms.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
> .../devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] pinctrl: qcom: sc7280: Add lpi pinctrl variant data structure for adsp based targets
2022-05-04 13:56 ` Srinivasa Rao Mandadapu
@ 2022-05-16 15:17 ` Bjorn Andersson
-1 siblings, 0 replies; 11+ messages in thread
From: Bjorn Andersson @ 2022-05-16 15:17 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: agross, lgirdwood, broonie, robh+dt, quic_plai, bgoswami, perex,
tiwai, srinivas.kandagatla, quic_rohkumar, linux-arm-msm,
alsa-devel, devicetree, linux-kernel, swboyd, judyhsiao,
Linus Walleij, linux-gpio, Venkata Prasad Potturu
On Wed 04 May 06:56 PDT 2022, Srinivasa Rao Mandadapu wrote:
> Add compatible string and lpi pinctrl variant data structure for adsp enabled
> sc7280 platforms.
This says what the change does, but gives no clue to what this
compatible represents and why the clock is not optional.
Could you please describe here what scenario this compatible is to be
used for etc, so that when someone else adds support for the next
platform they can use the git history to understand which case to
follow.
Thanks,
Bjorn
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
> drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
> index 2add9a4..c9e85d9 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
> @@ -134,6 +134,16 @@ static const struct lpi_function sc7280_functions[] = {
> LPI_FUNCTION(wsa_swr_data),
> };
>
> +static const struct lpi_pinctrl_variant_data sc7280_adsp_lpi_data = {
> + .pins = sc7280_lpi_pins,
> + .npins = ARRAY_SIZE(sc7280_lpi_pins),
> + .groups = sc7280_groups,
> + .ngroups = ARRAY_SIZE(sc7280_groups),
> + .functions = sc7280_functions,
> + .nfunctions = ARRAY_SIZE(sc7280_functions),
> + .is_clk_optional = false,
> +};
> +
> static const struct lpi_pinctrl_variant_data sc7280_lpi_data = {
> .pins = sc7280_lpi_pins,
> .npins = ARRAY_SIZE(sc7280_lpi_pins),
> @@ -149,6 +159,10 @@ static const struct of_device_id lpi_pinctrl_of_match[] = {
> .compatible = "qcom,sc7280-lpass-lpi-pinctrl",
> .data = &sc7280_lpi_data,
> },
> + {
> + .compatible = "qcom,sc7280-lpass-adsp-lpi-pinctrl",
> + .data = &sc7280_adsp_lpi_data,
> + },
> { }
> };
> MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] pinctrl: qcom: sc7280: Add lpi pinctrl variant data structure for adsp based targets
@ 2022-05-16 15:17 ` Bjorn Andersson
0 siblings, 0 replies; 11+ messages in thread
From: Bjorn Andersson @ 2022-05-16 15:17 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: devicetree, alsa-devel, quic_rohkumar, Venkata Prasad Potturu,
linux-arm-msm, swboyd, tiwai, agross, robh+dt, lgirdwood,
linux-gpio, broonie, srinivas.kandagatla, bgoswami, quic_plai,
judyhsiao, Linus Walleij, linux-kernel
On Wed 04 May 06:56 PDT 2022, Srinivasa Rao Mandadapu wrote:
> Add compatible string and lpi pinctrl variant data structure for adsp enabled
> sc7280 platforms.
This says what the change does, but gives no clue to what this
compatible represents and why the clock is not optional.
Could you please describe here what scenario this compatible is to be
used for etc, so that when someone else adds support for the next
platform they can use the git history to understand which case to
follow.
Thanks,
Bjorn
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
> ---
> drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
> index 2add9a4..c9e85d9 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
> @@ -134,6 +134,16 @@ static const struct lpi_function sc7280_functions[] = {
> LPI_FUNCTION(wsa_swr_data),
> };
>
> +static const struct lpi_pinctrl_variant_data sc7280_adsp_lpi_data = {
> + .pins = sc7280_lpi_pins,
> + .npins = ARRAY_SIZE(sc7280_lpi_pins),
> + .groups = sc7280_groups,
> + .ngroups = ARRAY_SIZE(sc7280_groups),
> + .functions = sc7280_functions,
> + .nfunctions = ARRAY_SIZE(sc7280_functions),
> + .is_clk_optional = false,
> +};
> +
> static const struct lpi_pinctrl_variant_data sc7280_lpi_data = {
> .pins = sc7280_lpi_pins,
> .npins = ARRAY_SIZE(sc7280_lpi_pins),
> @@ -149,6 +159,10 @@ static const struct of_device_id lpi_pinctrl_of_match[] = {
> .compatible = "qcom,sc7280-lpass-lpi-pinctrl",
> .data = &sc7280_lpi_data,
> },
> + {
> + .compatible = "qcom,sc7280-lpass-adsp-lpi-pinctrl",
> + .data = &sc7280_adsp_lpi_data,
> + },
> { }
> };
> MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match);
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] pinctrl: qcom: sc7280: Add lpi pinctrl variant data structure for adsp based targets
2022-05-16 15:17 ` Bjorn Andersson
@ 2022-06-01 9:56 ` Srinivasa Rao Mandadapu
-1 siblings, 0 replies; 11+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-06-01 9:56 UTC (permalink / raw)
To: Bjorn Andersson
Cc: agross, lgirdwood, broonie, robh+dt, quic_plai, bgoswami, perex,
tiwai, srinivas.kandagatla, quic_rohkumar, linux-arm-msm,
alsa-devel, devicetree, linux-kernel, swboyd, judyhsiao,
Linus Walleij, linux-gpio, Venkata Prasad Potturu
On 5/16/2022 8:47 PM, Bjorn Andersson wrote:
Thanks for Your time Bjorn!!!
> On Wed 04 May 06:56 PDT 2022, Srinivasa Rao Mandadapu wrote:
>
>> Add compatible string and lpi pinctrl variant data structure for adsp enabled
>> sc7280 platforms.
> This says what the change does, but gives no clue to what this
> compatible represents and why the clock is not optional.
>
> Could you please describe here what scenario this compatible is to be
> used for etc, so that when someone else adds support for the next
> platform they can use the git history to understand which case to
> follow.
>
> Thanks,
> Bjorn
Okay. Will update the commit message.
>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> ---
>> drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
>> index 2add9a4..c9e85d9 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
>> @@ -134,6 +134,16 @@ static const struct lpi_function sc7280_functions[] = {
>> LPI_FUNCTION(wsa_swr_data),
>> };
>>
>> +static const struct lpi_pinctrl_variant_data sc7280_adsp_lpi_data = {
>> + .pins = sc7280_lpi_pins,
>> + .npins = ARRAY_SIZE(sc7280_lpi_pins),
>> + .groups = sc7280_groups,
>> + .ngroups = ARRAY_SIZE(sc7280_groups),
>> + .functions = sc7280_functions,
>> + .nfunctions = ARRAY_SIZE(sc7280_functions),
>> + .is_clk_optional = false,
>> +};
>> +
>> static const struct lpi_pinctrl_variant_data sc7280_lpi_data = {
>> .pins = sc7280_lpi_pins,
>> .npins = ARRAY_SIZE(sc7280_lpi_pins),
>> @@ -149,6 +159,10 @@ static const struct of_device_id lpi_pinctrl_of_match[] = {
>> .compatible = "qcom,sc7280-lpass-lpi-pinctrl",
>> .data = &sc7280_lpi_data,
>> },
>> + {
>> + .compatible = "qcom,sc7280-lpass-adsp-lpi-pinctrl",
>> + .data = &sc7280_adsp_lpi_data,
>> + },
>> { }
>> };
>> MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match);
>> --
>> 2.7.4
>>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] pinctrl: qcom: sc7280: Add lpi pinctrl variant data structure for adsp based targets
@ 2022-06-01 9:56 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 11+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-06-01 9:56 UTC (permalink / raw)
To: Bjorn Andersson
Cc: devicetree, alsa-devel, quic_rohkumar, Venkata Prasad Potturu,
linux-arm-msm, swboyd, tiwai, agross, robh+dt, lgirdwood,
linux-gpio, broonie, srinivas.kandagatla, bgoswami, quic_plai,
judyhsiao, Linus Walleij, linux-kernel
On 5/16/2022 8:47 PM, Bjorn Andersson wrote:
Thanks for Your time Bjorn!!!
> On Wed 04 May 06:56 PDT 2022, Srinivasa Rao Mandadapu wrote:
>
>> Add compatible string and lpi pinctrl variant data structure for adsp enabled
>> sc7280 platforms.
> This says what the change does, but gives no clue to what this
> compatible represents and why the clock is not optional.
>
> Could you please describe here what scenario this compatible is to be
> used for etc, so that when someone else adds support for the next
> platform they can use the git history to understand which case to
> follow.
>
> Thanks,
> Bjorn
Okay. Will update the commit message.
>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
>> Co-developed-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> Signed-off-by: Venkata Prasad Potturu <quic_potturu@quicinc.com>
>> ---
>> drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
>> index 2add9a4..c9e85d9 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
>> @@ -134,6 +134,16 @@ static const struct lpi_function sc7280_functions[] = {
>> LPI_FUNCTION(wsa_swr_data),
>> };
>>
>> +static const struct lpi_pinctrl_variant_data sc7280_adsp_lpi_data = {
>> + .pins = sc7280_lpi_pins,
>> + .npins = ARRAY_SIZE(sc7280_lpi_pins),
>> + .groups = sc7280_groups,
>> + .ngroups = ARRAY_SIZE(sc7280_groups),
>> + .functions = sc7280_functions,
>> + .nfunctions = ARRAY_SIZE(sc7280_functions),
>> + .is_clk_optional = false,
>> +};
>> +
>> static const struct lpi_pinctrl_variant_data sc7280_lpi_data = {
>> .pins = sc7280_lpi_pins,
>> .npins = ARRAY_SIZE(sc7280_lpi_pins),
>> @@ -149,6 +159,10 @@ static const struct of_device_id lpi_pinctrl_of_match[] = {
>> .compatible = "qcom,sc7280-lpass-lpi-pinctrl",
>> .data = &sc7280_lpi_data,
>> },
>> + {
>> + .compatible = "qcom,sc7280-lpass-adsp-lpi-pinctrl",
>> + .data = &sc7280_adsp_lpi_data,
>> + },
>> { }
>> };
>> MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match);
>> --
>> 2.7.4
>>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-06-01 9:57 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-04 13:56 [PATCH 0/2] Add pinctrl support adsp based platforms Srinivasa Rao Mandadapu
2022-05-04 13:56 ` [PATCH 1/2] dt-bindings: pinctrl: qcom: sc7280: Add compatible string for " Srinivasa Rao Mandadapu
2022-05-04 13:56 ` Srinivasa Rao Mandadapu
2022-05-05 17:28 ` Rob Herring
2022-05-05 17:28 ` Rob Herring
2022-05-04 13:56 ` [PATCH 2/2] pinctrl: qcom: sc7280: Add lpi pinctrl variant data structure for adsp based targets Srinivasa Rao Mandadapu
2022-05-04 13:56 ` Srinivasa Rao Mandadapu
2022-05-16 15:17 ` Bjorn Andersson
2022-05-16 15:17 ` Bjorn Andersson
2022-06-01 9:56 ` Srinivasa Rao Mandadapu
2022-06-01 9:56 ` Srinivasa Rao Mandadapu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.