[Buildroot] [PATCH 1/1] package/busybox: add -O staticroutes options to udhcpc udhcpc default script can handle staticroutes but it missing from ifupdown options

[Buildroot] [PATCH 1/1] package/busybox: add -O staticroutes options to udhcpc udhcpc default script can handle staticroutes but it missing from ifupdown options

[Remi Jouannet]

Signed-off-by: Rémi Jouannet <remi.jouannet@outscale.com>
---
 package/busybox/busybox.config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/busybox/busybox.config b/package/busybox/busybox.config
index 52cb8ff..a614662 100644
--- a/package/busybox/busybox.config
+++ b/package/busybox/busybox.config
@@ -1022,7 +1022,7 @@ CONFIG_UDHCP_DEBUG=0
 CONFIG_UDHCPC_SLACK_FOR_BUGGY_SERVERS=80
 CONFIG_FEATURE_UDHCP_RFC3397=y
 CONFIG_FEATURE_UDHCP_8021Q=y
-CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS="-b -R -O search"
+CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS="-b -R -O search -O staticroutes"
 
 #
 # Print Utilities
-- 
1.8.3.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/busybox: add -O staticroutes options to udhcpc udhcpc default script can handle staticroutes but it missing from ifupdown options

[Alexander Dahl]

[-- Attachment #1.1: Type: text/plain, Size: 1351 bytes --]

Hei hei,

took me a while to find the reasoning for this patch. Didn't expect it
in that very long subject line. ;-)

Greets
Alex

On Fri, May 06, 2022 at 02:54:23PM +0000, Remi Jouannet wrote:
> Signed-off-by: Rémi Jouannet <remi.jouannet@outscale.com>
> ---
>  package/busybox/busybox.config | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/busybox/busybox.config b/package/busybox/busybox.config
> index 52cb8ff..a614662 100644
> --- a/package/busybox/busybox.config
> +++ b/package/busybox/busybox.config
> @@ -1022,7 +1022,7 @@ CONFIG_UDHCP_DEBUG=0
>  CONFIG_UDHCPC_SLACK_FOR_BUGGY_SERVERS=80
>  CONFIG_FEATURE_UDHCP_RFC3397=y
>  CONFIG_FEATURE_UDHCP_8021Q=y
> -CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS="-b -R -O search"
> +CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS="-b -R -O search -O staticroutes"
>  
>  #
>  # Print Utilities
> -- 
> 1.8.3.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/busybox: add -O staticroutes options to udhcpc udhcpc default script can handle staticroutes but it missing from ifupdown options

[Rémi Jouannet]

Hello,

yeah sorry about that, i'm not used to send patch by email

I wanted to do a simple subject and write a few lines to explain the 
patch in the body

do you want me to send a another patch with a a better subject/body ?

Le 06/05/2022 à 17:31, Alexander Dahl a écrit :
> Hei hei,
>
> took me a while to find the reasoning for this patch. Didn't expect it
> in that very long subject line. ;-)
>
> Greets
> Alex
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/busybox: add -O staticroutes options to udhcpc udhcpc default script can handle staticroutes but it missing from ifupdown options

[Rémi Jouannet]

[-- Attachment #1.1: Type: text/plain, Size: 1355 bytes --]

Hello,

yeah sorry about that, i'm not used to send patch by email

I wanted to do a simple subject and write a few lines to explain the
patch in the body

do you want me to send a another patch with a a better subject/body ?

Le 06/05/2022 à 17:31, Alexander Dahl a écrit :
> Hei hei,
>
> took me a while to find the reasoning for this patch. Didn't expect it
> in that very long subject line. ;-)
>
> Greets
> Alex
>
> On Fri, May 06, 2022 at 02:54:23PM +0000, Remi Jouannet wrote:
>> Signed-off-by: Rémi Jouannet<remi.jouannet@outscale.com>
>> ---
>>   package/busybox/busybox.config | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/busybox/busybox.config b/package/busybox/busybox.config
>> index 52cb8ff..a614662 100644
>> --- a/package/busybox/busybox.config
>> +++ b/package/busybox/busybox.config
>> @@ -1022,7 +1022,7 @@ CONFIG_UDHCP_DEBUG=0
>>   CONFIG_UDHCPC_SLACK_FOR_BUGGY_SERVERS=80
>>   CONFIG_FEATURE_UDHCP_RFC3397=y
>>   CONFIG_FEATURE_UDHCP_8021Q=y
>> -CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS="-b -R -O search"
>> +CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS="-b -R -O search -O staticroutes"
>>   
>>   #
>>   # Print Utilities
>> -- 
>> 1.8.3.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot

[-- Attachment #1.2: Type: text/html, Size: 2051 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/busybox: add -O staticroutes options to udhcpc udhcpc default script can handle staticroutes but it missing from ifupdown options

[Alexander Dahl]

[-- Attachment #1.1: Type: text/plain, Size: 2469 bytes --]

Hello Rémi,

On Fri, May 06, 2022 at 07:07:06PM +0200, Rémi Jouannet wrote:
> Hello,
> 
> yeah sorry about that, i'm not used to send patch by email

There is a section in the buildroot manual explaining the process
quite well, in short: use `git format-patch` and `git send-email` …

https://buildroot.org/downloads/manual/manual.html#submitting-patches

> I wanted to do a simple subject and write a few lines to explain the
> patch in the body

That's right. Short subject, one line empty, explanation below.

> do you want me to send a another patch with a a better subject/body ?

I'm not in the position to request that. I can just say patches in the
right format have a much higher chance of being accepted.

Greets
Alex

> 
> Le 06/05/2022 à 17:31, Alexander Dahl a écrit :
> > Hei hei,
> > 
> > took me a while to find the reasoning for this patch. Didn't expect it
> > in that very long subject line. ;-)
> > 
> > Greets
> > Alex
> > 
> > On Fri, May 06, 2022 at 02:54:23PM +0000, Remi Jouannet wrote:
> > > Signed-off-by: Rémi Jouannet<remi.jouannet@outscale.com>
> > > ---
> > >   package/busybox/busybox.config | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/package/busybox/busybox.config b/package/busybox/busybox.config
> > > index 52cb8ff..a614662 100644
> > > --- a/package/busybox/busybox.config
> > > +++ b/package/busybox/busybox.config
> > > @@ -1022,7 +1022,7 @@ CONFIG_UDHCP_DEBUG=0
> > >   CONFIG_UDHCPC_SLACK_FOR_BUGGY_SERVERS=80
> > >   CONFIG_FEATURE_UDHCP_RFC3397=y
> > >   CONFIG_FEATURE_UDHCP_8021Q=y
> > > -CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS="-b -R -O search"
> > > +CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS="-b -R -O search -O staticroutes"
> > >   #
> > >   # Print Utilities
> > > -- 
> > > 1.8.3.1
> > > 
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot@buildroot.org
> > > https://lists.buildroot.org/mailman/listinfo/buildroot

> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot


-- 
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot