[igt-dev] [PATCH] tests/i915/gem_exec_balancer: Add busy subtest description

[igt-dev] [PATCH] tests/i915/gem_exec_balancer: Add busy subtest description

[sinjan.kumar]

From: Sinjan Kumar <sinjan.kumar@intel.com>

Add busy subtest description

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Sinjan Kumar <sinjan.kumar@intel.com>
---
 tests/i915/gem_exec_balancer.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
index 857d0085..c68a50e7 100644
--- a/tests/i915/gem_exec_balancer.c
+++ b/tests/i915/gem_exec_balancer.c
@@ -3301,6 +3301,9 @@ igt_main
 	igt_subtest("indices")
 		indices(i915);
 
+	igt_describe("Test for validating engine busyness by checking"
+		     " read-write event through GEM_BUSY IOCTL");
+
 	igt_subtest("busy")
 		busy(i915);
 
-- 
2.25.1

[igt-dev] ✓ Fi.CI.BAT: success for tests/i915/gem_exec_balancer: Add busy subtest description (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 3748 bytes --]

== Series Details ==

Series: tests/i915/gem_exec_balancer: Add busy subtest description (rev2)
URL   : https://patchwork.freedesktop.org/series/103674/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11617 -> IGTPW_7054
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/index.html

Participating hosts (45 -> 42)
------------------------------

  Additional (2): bat-rpls-1 fi-snb-2520m 
  Missing    (5): bat-adlm-1 fi-bsw-cyan fi-icl-u2 bat-rpls-2 bat-jsl-2 

Known issues
------------

  Here are the changes found in IGTPW_7054 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_lmem_swapping@basic:
    - fi-snb-2520m:       NOTRUN -> [SKIP][1] ([fdo#109271]) +24 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/fi-snb-2520m/igt@gem_lmem_swapping@basic.html

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-snb-2600:        NOTRUN -> [SKIP][2] ([fdo#109271] / [fdo#111827])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/fi-snb-2600/igt@kms_chamelium@common-hpd-after-suspend.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-snb-2520m:       NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827]) +8 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/fi-snb-2520m/igt@kms_chamelium@hdmi-hpd-fast.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gem_contexts:
    - {bat-dg2-8}:        [DMESG-FAIL][4] ([i915#5885]) -> [PASS][5]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11617/bat-dg2-8/igt@i915_selftest@live@gem_contexts.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/bat-dg2-8/igt@i915_selftest@live@gem_contexts.html

  * igt@i915_selftest@live@hangcheck:
    - fi-snb-2600:        [INCOMPLETE][6] ([i915#3921]) -> [PASS][7]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11617/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/fi-snb-2600/igt@i915_selftest@live@hangcheck.html

  
#### Warnings ####

  * igt@runner@aborted:
    - bat-dg1-6:          [FAIL][8] ([i915#4312] / [i915#5257]) -> [FAIL][9] ([i915#5616])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11617/bat-dg1-6/igt@runner@aborted.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/bat-dg1-6/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
  [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
  [i915#4897]: https://gitlab.freedesktop.org/drm/intel/issues/4897
  [i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
  [i915#5616]: https://gitlab.freedesktop.org/drm/intel/issues/5616
  [i915#5879]: https://gitlab.freedesktop.org/drm/intel/issues/5879
  [i915#5885]: https://gitlab.freedesktop.org/drm/intel/issues/5885


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6468 -> IGTPW_7054

  CI-20190529: 20190529
  CI_DRM_11617: d96cea3d7ffb524248fcc8db433c579cf262eaea @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_7054: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/index.html
  IGT_6468: cffa5fffe9acddf49565b4caeeb5e3355ff2ea44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/index.html

[-- Attachment #2: Type: text/html, Size: 4555 bytes --]

[igt-dev] ✓ Fi.CI.IGT: success for tests/i915/gem_exec_balancer: Add busy subtest description (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 2955 bytes --]

== Series Details ==

Series: tests/i915/gem_exec_balancer: Add busy subtest description (rev2)
URL   : https://patchwork.freedesktop.org/series/103674/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11617_full -> IGTPW_7054_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/index.html

Participating hosts (11 -> 7)
------------------------------

  Missing    (4): pig-skl-6260u pig-kbl-iris shard-tglu pig-glk-j5005 

Known issues
------------

  Here are the changes found in IGTPW_7054_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_persistence@engines-cleanup:
    - shard-snb:          NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/shard-snb4/igt@gem_ctx_persistence@engines-cleanup.html

  * igt@i915_hangman@engine-engine-hang:
    - shard-snb:          NOTRUN -> [SKIP][2] ([fdo#109271]) +108 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/shard-snb5/igt@i915_hangman@engine-engine-hang.html

  * igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
    - shard-snb:          NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827]) +3 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/shard-snb2/igt@kms_chamelium@hdmi-hpd-enable-disable-mode.html

  * igt@syncobj_timeline@transfer-timeline-point:
    - shard-snb:          NOTRUN -> [DMESG-FAIL][4] ([i915#5098])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/shard-snb7/igt@syncobj_timeline@transfer-timeline-point.html

  
#### Possible fixes ####

  * igt@gem_mmap_gtt@coherency:
    - shard-snb:          [SKIP][5] ([fdo#109271]) -> [PASS][6] +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11617/shard-snb6/igt@gem_mmap_gtt@coherency.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/shard-snb2/igt@gem_mmap_gtt@coherency.html

  
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
  [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
  [i915#5098]: https://gitlab.freedesktop.org/drm/intel/issues/5098


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6468 -> IGTPW_7054
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_11617: d96cea3d7ffb524248fcc8db433c579cf262eaea @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_7054: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/index.html
  IGT_6468: cffa5fffe9acddf49565b4caeeb5e3355ff2ea44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7054/index.html

[-- Attachment #2: Type: text/html, Size: 3866 bytes --]

Re: [igt-dev] [PATCH] tests/i915/gem_exec_balancer: Add busy subtest description

[Kamil Konieczny]

Hi Sinjan,

On 2022-05-06 at 19:54:45 +0530, sinjan.kumar@intel.com wrote:
> From: Sinjan Kumar <sinjan.kumar@intel.com>
> 
> Add busy subtest description
> 
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>

If you sended this mail to other developers, please put more
addresses here.

> Signed-off-by: Sinjan Kumar <sinjan.kumar@intel.com>
> ---
>  tests/i915/gem_exec_balancer.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
> index 857d0085..c68a50e7 100644
> --- a/tests/i915/gem_exec_balancer.c
> +++ b/tests/i915/gem_exec_balancer.c
> @@ -3301,6 +3301,9 @@ igt_main
>  	igt_subtest("indices")
>  		indices(i915);
>  
> +	igt_describe("Test for validating engine busyness by checking"
> +		     " read-write event through GEM_BUSY IOCTL");
> +

Please remove this empty line. Please try to avoid starting
desciption with "Test" word (well, sometimes you can use it).
Here you could start with "Validate" word:

	igt_describe("Validate engine busyness by checking read-write"
		     " event through GEM_BUSY IOCTL.");

For future versions of this and other description patches please
send them as HAX series, e.g. add second patch with file
tests/intel-ci/fast-feedback.testlist
containing only one line:

igt@meta_test@fail-result

and with subject "HAX: do not run tests", also in cover letter
subject put "HAX add description to [put name of test here]"

See e-mail from Zbigniew on 3 Mar 2022,
"Use HAX for series which add igt_describe"

or https://patchwork.freedesktop.org/series/101198/
as an example.

>  	igt_subtest("busy")
>  		busy(i915);

May you add more descriptions for other subtests ? Check them
with --describe option.

Regards,
Kamil

>  
> -- 
> 2.25.1
>