All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] perf/x86/amd: Remove unused variable 'hwc'
@ 2022-04-21 11:10 Zucheng Zheng
  2022-05-09  3:07 ` zhengzucheng
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Zucheng Zheng @ 2022-04-21 11:10 UTC (permalink / raw)
  To: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
	namhyung, tglx, bp, dave.hansen, hpa
  Cc: linux-perf-users, linux-kernel

'hwc' is never used in amd_pmu_enable_all(), so remove it.

-------------------------------

Signed-off-by: Zucheng Zheng <zhengzucheng@huawei.com>
---
 arch/x86/events/amd/core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
index 8e1e818f8195..d7f9500b876d 100644
--- a/arch/x86/events/amd/core.c
+++ b/arch/x86/events/amd/core.c
@@ -714,14 +714,11 @@ static void amd_pmu_enable_event(struct perf_event *event)
 static void amd_pmu_enable_all(int added)
 {
 	struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
-	struct hw_perf_event *hwc;
 	int idx;
 
 	amd_brs_enable_all();
 
 	for (idx = 0; idx < x86_pmu.num_counters; idx++) {
-		hwc = &cpuc->events[idx]->hw;
-
 		/* only activate events which are marked as active */
 		if (!test_bit(idx, cpuc->active_mask))
 			continue;
-- 
2.18.0.huawei.25


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH -next] perf/x86/amd: Remove unused variable 'hwc'
  2022-04-21 11:10 [PATCH -next] perf/x86/amd: Remove unused variable 'hwc' Zucheng Zheng
@ 2022-05-09  3:07 ` zhengzucheng
  2022-05-11 19:46 ` [tip: perf/core] " tip-bot2 for Zucheng Zheng
  2022-05-12 14:33 ` tip-bot2 for Zucheng Zheng
  2 siblings, 0 replies; 4+ messages in thread
From: zhengzucheng @ 2022-05-09  3:07 UTC (permalink / raw)
  To: peterz, mingo, acme, mark.rutland, alexander.shishkin, jolsa,
	namhyung, tglx, bp, dave.hansen, hpa
  Cc: linux-perf-users, linux-kernel

ping...

Any suggestions for this problem？

在 2022/4/21 19:10, Zucheng Zheng 写道:
> 'hwc' is never used in amd_pmu_enable_all(), so remove it.
>
> -------------------------------
>
> Signed-off-by: Zucheng Zheng <zhengzucheng@huawei.com>
> ---
>   arch/x86/events/amd/core.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
> index 8e1e818f8195..d7f9500b876d 100644
> --- a/arch/x86/events/amd/core.c
> +++ b/arch/x86/events/amd/core.c
> @@ -714,14 +714,11 @@ static void amd_pmu_enable_event(struct perf_event *event)
>   static void amd_pmu_enable_all(int added)
>   {
>   	struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
> -	struct hw_perf_event *hwc;
>   	int idx;
>   
>   	amd_brs_enable_all();
>   
>   	for (idx = 0; idx < x86_pmu.num_counters; idx++) {
> -		hwc = &cpuc->events[idx]->hw;
> -
>   		/* only activate events which are marked as active */
>   		if (!test_bit(idx, cpuc->active_mask))
>   			continue;

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [tip: perf/core] perf/x86/amd: Remove unused variable 'hwc'
  2022-04-21 11:10 [PATCH -next] perf/x86/amd: Remove unused variable 'hwc' Zucheng Zheng
  2022-05-09  3:07 ` zhengzucheng
@ 2022-05-11 19:46 ` tip-bot2 for Zucheng Zheng
  2022-05-12 14:33 ` tip-bot2 for Zucheng Zheng
  2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for Zucheng Zheng @ 2022-05-11 19:46 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: Peter Zijlstra (Intel), x86, linux-kernel

The following commit has been merged into the perf/core branch of tip:

Commit-ID:     2cc6edea3673e38fa96df5cf8a62ddc8b27c7217
Gitweb:        https://git.kernel.org/tip/2cc6edea3673e38fa96df5cf8a62ddc8b27c7217
Author:        Zucheng Zheng <zhengzucheng@huawei.com>
AuthorDate:    Thu, 21 Apr 2022 19:10:31 +08:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Wed, 11 May 2022 16:27:11 +02:00

perf/x86/amd: Remove unused variable 'hwc'

'hwc' is never used in amd_pmu_enable_all(), so remove it.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20220421111031.174698-1-zhengzucheng@huawei.com
---
 arch/x86/events/amd/core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
index 262e39a..d81eac2 100644
--- a/arch/x86/events/amd/core.c
+++ b/arch/x86/events/amd/core.c
@@ -771,14 +771,11 @@ static void amd_pmu_enable_event(struct perf_event *event)
 static void amd_pmu_enable_all(int added)
 {
 	struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
-	struct hw_perf_event *hwc;
 	int idx;
 
 	amd_brs_enable_all();
 
 	for (idx = 0; idx < x86_pmu.num_counters; idx++) {
-		hwc = &cpuc->events[idx]->hw;
-
 		/* only activate events which are marked as active */
 		if (!test_bit(idx, cpuc->active_mask))
 			continue;

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [tip: perf/core] perf/x86/amd: Remove unused variable 'hwc'
  2022-04-21 11:10 [PATCH -next] perf/x86/amd: Remove unused variable 'hwc' Zucheng Zheng
  2022-05-09  3:07 ` zhengzucheng
  2022-05-11 19:46 ` [tip: perf/core] " tip-bot2 for Zucheng Zheng
@ 2022-05-12 14:33 ` tip-bot2 for Zucheng Zheng
  2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for Zucheng Zheng @ 2022-05-12 14:33 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Zucheng Zheng, Peter Zijlstra (Intel), x86, linux-kernel

The following commit has been merged into the perf/core branch of tip:

Commit-ID:     bc469ddf67154a4840267132e87ce0d8b72d4952
Gitweb:        https://git.kernel.org/tip/bc469ddf67154a4840267132e87ce0d8b72d4952
Author:        Zucheng Zheng <zhengzucheng@huawei.com>
AuthorDate:    Thu, 21 Apr 2022 19:10:31 +08:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Thu, 12 May 2022 16:28:46 +02:00

perf/x86/amd: Remove unused variable 'hwc'

'hwc' is never used in amd_pmu_enable_all(), so remove it.

Signed-off-by: Zucheng Zheng <zhengzucheng@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20220421111031.174698-1-zhengzucheng@huawei.com
---
 arch/x86/events/amd/core.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
index 262e39a..d81eac2 100644
--- a/arch/x86/events/amd/core.c
+++ b/arch/x86/events/amd/core.c
@@ -771,14 +771,11 @@ static void amd_pmu_enable_event(struct perf_event *event)
 static void amd_pmu_enable_all(int added)
 {
 	struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
-	struct hw_perf_event *hwc;
 	int idx;
 
 	amd_brs_enable_all();
 
 	for (idx = 0; idx < x86_pmu.num_counters; idx++) {
-		hwc = &cpuc->events[idx]->hw;
-
 		/* only activate events which are marked as active */
 		if (!test_bit(idx, cpuc->active_mask))
 			continue;

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-12 14:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 11:10 [PATCH -next] perf/x86/amd: Remove unused variable 'hwc' Zucheng Zheng
2022-05-09  3:07 ` zhengzucheng
2022-05-11 19:46 ` [tip: perf/core] " tip-bot2 for Zucheng Zheng
2022-05-12 14:33 ` tip-bot2 for Zucheng Zheng

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.