[PATCH v2] block: reorder the REQ_ flags

[PATCH v2] block: reorder the REQ_ flags

[Christoph Hellwig]

Keep the op-specific flag last so that they are clearly separate from
the generic flags.  Various recent commits just kept adding new flags
at the end.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/blk_types.h | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index c62274466e726..9601164ff1caa 100644
--- a/include/linux/blk_types.h
+++ b/include/linux/blk_types.h
@@ -408,16 +408,17 @@ enum req_flag_bits {
 	 * work item to avoid such priority inversions.
 	 */
 	__REQ_CGROUP_PUNT,
-
-	/* command specific flags for REQ_OP_WRITE_ZEROES: */
-	__REQ_NOUNMAP,		/* do not free blocks when zeroing */
-
 	__REQ_POLLED,		/* caller polls for completion using bio_poll */
 	__REQ_ALLOC_CACHE,	/* allocate IO from cache if available */
+	__REQ_SWAP,		/* swap I/O */
+	__REQ_DRV,		/* for driver use */
+
+	/*
+	 * Command specific flags, keep last:
+	 */
+	/* for REQ_OP_WRITE_ZEROES: */
+	__REQ_NOUNMAP,		/* do not free blocks when zeroing */
 
-	/* for driver use */
-	__REQ_DRV,
-	__REQ_SWAP,		/* swapping request. */
 	__REQ_NR_BITS,		/* stops here */
 };
 
-- 
2.30.2

Re: [PATCH v2] block: reorder the REQ_ flags

[Jens Axboe]

On Thu, 12 May 2022 08:14:08 +0200, Christoph Hellwig wrote:
> Keep the op-specific flag last so that they are clearly separate from
> the generic flags.  Various recent commits just kept adding new flags
> at the end.
> 
> 

Applied, thanks!

[1/1] block: reorder the REQ_ flags
      commit: 5ce7729f25c16d5045deff4c9577e6d565da2d8d

Best regards,
-- 
Jens Axboe