* [PATCH v2] net: rtlwifi: Use pr_warn instead of WARN_ONCE
@ 2022-05-11 1:44 Dongliang Mu
2022-05-13 6:20 ` [v2] " Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Dongliang Mu @ 2022-05-11 1:44 UTC (permalink / raw)
To: Ping-Ke Shih, Kalle Valo, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: Dongliang Mu, syzkaller, linux-wireless, netdev, linux-kernel
From: Dongliang Mu <mudongliangabcd@gmail.com>
This memory allocation failure can be triggered by fault injection or
high pressure testing, resulting a WARN.
Fix this by replacing WARN with pr_warn.
Reported-by: syzkaller <syzkaller@googlegroups.com>
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
---
v1->v2: change to pr_warn as suggested by Kalle Valo
drivers/net/wireless/realtek/rtlwifi/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c
index 86a236873254..a8eebafb9a7e 100644
--- a/drivers/net/wireless/realtek/rtlwifi/usb.c
+++ b/drivers/net/wireless/realtek/rtlwifi/usb.c
@@ -1014,7 +1014,7 @@ int rtl_usb_probe(struct usb_interface *intf,
hw = ieee80211_alloc_hw(sizeof(struct rtl_priv) +
sizeof(struct rtl_usb_priv), &rtl_ops);
if (!hw) {
- WARN_ONCE(true, "rtl_usb: ieee80211 alloc failed\n");
+ pr_warn("rtl_usb: ieee80211 alloc failed\n");
return -ENOMEM;
}
rtlpriv = hw->priv;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [v2] rtlwifi: Use pr_warn instead of WARN_ONCE
2022-05-11 1:44 [PATCH v2] net: rtlwifi: Use pr_warn instead of WARN_ONCE Dongliang Mu
@ 2022-05-13 6:20 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-05-13 6:20 UTC (permalink / raw)
To: Dongliang Mu
Cc: Ping-Ke Shih, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Dongliang Mu, syzkaller, linux-wireless, netdev,
linux-kernel
Dongliang Mu <dzm91@hust.edu.cn> wrote:
> From: Dongliang Mu <mudongliangabcd@gmail.com>
>
> This memory allocation failure can be triggered by fault injection or
> high pressure testing, resulting a WARN.
>
> Fix this by replacing WARN with pr_warn.
>
> Reported-by: syzkaller <syzkaller@googlegroups.com>
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Patch applied to wireless-next.git, thanks.
ad732da434a2 rtlwifi: Use pr_warn instead of WARN_ONCE
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220511014453.1621366-1-dzm91@hust.edu.cn/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-13 6:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-11 1:44 [PATCH v2] net: rtlwifi: Use pr_warn instead of WARN_ONCE Dongliang Mu
2022-05-13 6:20 ` [v2] " Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.