All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Robert Hancock <robert.hancock@calian.com>
Cc: netdev@vger.kernel.org, radhey.shyam.pandey@xilinx.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, michal.simek@xilinx.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v7 1/2] net: axienet: Be more careful about updating tx_bd_tail
Date: Fri, 13 May 2022 11:30:13 +0000	[thread overview]
Message-ID: <165244141304.14739.6534983406795564149.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220512171853.4100193-2-robert.hancock@calian.com>

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Thu, 12 May 2022 11:18:52 -0600 you wrote:
> The axienet_start_xmit function was updating the tx_bd_tail variable
> multiple times, with potential rollbacks on error or invalid
> intermediate positions, even though this variable is also used in the
> TX completion path. Use READ_ONCE where this variable is read and
> WRITE_ONCE where it is written to make this update more atomic, and
> move the write before the MMIO write to start the transfer, so it is
> protected by that implicit write barrier.
> 
> [...]

Here is the summary with links:
  - [net-next,v7,1/2] net: axienet: Be more careful about updating tx_bd_tail
    https://git.kernel.org/netdev/net-next/c/f0cf4000f586
  - [net-next,v7,2/2] net: axienet: Use NAPI for TX completion path
    https://git.kernel.org/netdev/net-next/c/9e2bc267e780

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Robert Hancock <robert.hancock@calian.com>
Cc: netdev@vger.kernel.org, radhey.shyam.pandey@xilinx.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com,  michal.simek@xilinx.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v7 1/2] net: axienet: Be more careful about updating tx_bd_tail
Date: Fri, 13 May 2022 11:30:13 +0000	[thread overview]
Message-ID: <165244141304.14739.6534983406795564149.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220512171853.4100193-2-robert.hancock@calian.com>

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Thu, 12 May 2022 11:18:52 -0600 you wrote:
> The axienet_start_xmit function was updating the tx_bd_tail variable
> multiple times, with potential rollbacks on error or invalid
> intermediate positions, even though this variable is also used in the
> TX completion path. Use READ_ONCE where this variable is read and
> WRITE_ONCE where it is written to make this update more atomic, and
> move the write before the MMIO write to start the transfer, so it is
> protected by that implicit write barrier.
> 
> [...]

Here is the summary with links:
  - [net-next,v7,1/2] net: axienet: Be more careful about updating tx_bd_tail
    https://git.kernel.org/netdev/net-next/c/f0cf4000f586
  - [net-next,v7,2/2] net: axienet: Use NAPI for TX completion path
    https://git.kernel.org/netdev/net-next/c/9e2bc267e780

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-13 11:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220512171853.4100193-1-robert.hancock@calian.com>
2022-05-12 17:18 ` [PATCH net-next v7 1/2] net: axienet: Be more careful about updating tx_bd_tail Robert Hancock
2022-05-12 17:18   ` Robert Hancock
2022-05-13 11:30   ` patchwork-bot+netdevbpf [this message]
2022-05-13 11:30     ` patchwork-bot+netdevbpf
2022-05-12 17:18 ` [PATCH net-next v7 2/2] net: axienet: Use NAPI for TX completion path Robert Hancock
2022-05-12 17:18   ` Robert Hancock
2022-05-12 23:00 ` [PATCH net-next v7 0/2] axienet NAPI improvements Robert Hancock
2022-05-12 23:00   ` Robert Hancock
2022-05-13  0:04   ` Jakub Kicinski
2022-05-13  0:04     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165244141304.14739.6534983406795564149.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=michal.simek@xilinx.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=radhey.shyam.pandey@xilinx.com \
    --cc=robert.hancock@calian.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.