* [PATCH v2] powerpc/4xx: cpm: fix return value of __setup handler
@ 2022-05-02 19:29 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2022-05-02 19:29 UTC (permalink / raw)
To: linuxppc-dev
Cc: patches, Randy Dunlap, Igor Zhbanov, Michael Ellerman,
Benjamin Herrenschmidt, Paul Mackerras
__setup() handlers should return 1 to obsolete_checksetup() in
init/main.c to indicate that the boot option has been handled.
A return of 0 causes the boot option/value to be listed as an Unknown
kernel parameter and added to init's (limited) argument or environment
strings. Also, error return codes don't mean anything to
obsolete_checksetup() -- only non-zero (usually 1) or zero.
So return 1 from cpm_powersave_off().
Fixes: d164f6d4f910 ("powerpc/4xx: Add suspend and idle support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Igor Zhbanov <izh1979@gmail.com>
Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
---
v2: drop some email addresses that bounced;
change From: Igor to Reported-by: Igor
update Igor's email address
arch/powerpc/platforms/4xx/cpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/powerpc/platforms/4xx/cpm.c
+++ b/arch/powerpc/platforms/4xx/cpm.c
@@ -327,6 +327,6 @@ late_initcall(cpm_init);
static int __init cpm_powersave_off(char *arg)
{
cpm.powersave_off = 1;
- return 0;
+ return 1;
}
__setup("powersave=off", cpm_powersave_off);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] powerpc/4xx: cpm: fix return value of __setup handler
@ 2022-05-02 19:29 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2022-05-02 19:29 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Igor Zhbanov, Randy Dunlap, patches, Paul Mackerras
__setup() handlers should return 1 to obsolete_checksetup() in
init/main.c to indicate that the boot option has been handled.
A return of 0 causes the boot option/value to be listed as an Unknown
kernel parameter and added to init's (limited) argument or environment
strings. Also, error return codes don't mean anything to
obsolete_checksetup() -- only non-zero (usually 1) or zero.
So return 1 from cpm_powersave_off().
Fixes: d164f6d4f910 ("powerpc/4xx: Add suspend and idle support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Igor Zhbanov <izh1979@gmail.com>
Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
---
v2: drop some email addresses that bounced;
change From: Igor to Reported-by: Igor
update Igor's email address
arch/powerpc/platforms/4xx/cpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/powerpc/platforms/4xx/cpm.c
+++ b/arch/powerpc/platforms/4xx/cpm.c
@@ -327,6 +327,6 @@ late_initcall(cpm_init);
static int __init cpm_powersave_off(char *arg)
{
cpm.powersave_off = 1;
- return 0;
+ return 1;
}
__setup("powersave=off", cpm_powersave_off);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] powerpc/4xx: cpm: fix return value of __setup handler
2022-05-02 19:29 ` Randy Dunlap
@ 2022-05-15 10:12 ` Michael Ellerman
-1 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2022-05-15 10:12 UTC (permalink / raw)
To: linuxppc-dev, Randy Dunlap
Cc: Igor Zhbanov, patches, Michael Ellerman, Benjamin Herrenschmidt,
Paul Mackerras
On Mon, 2 May 2022 12:29:41 -0700, Randy Dunlap wrote:
> __setup() handlers should return 1 to obsolete_checksetup() in
> init/main.c to indicate that the boot option has been handled.
> A return of 0 causes the boot option/value to be listed as an Unknown
> kernel parameter and added to init's (limited) argument or environment
> strings. Also, error return codes don't mean anything to
> obsolete_checksetup() -- only non-zero (usually 1) or zero.
> So return 1 from cpm_powersave_off().
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/4xx: cpm: fix return value of __setup handler
https://git.kernel.org/powerpc/c/5bb99fd4090fe1acfdb90a97993fcda7f8f5a3d6
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] powerpc/4xx: cpm: fix return value of __setup handler
@ 2022-05-15 10:12 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2022-05-15 10:12 UTC (permalink / raw)
To: linuxppc-dev, Randy Dunlap; +Cc: patches, Paul Mackerras, Igor Zhbanov
On Mon, 2 May 2022 12:29:41 -0700, Randy Dunlap wrote:
> __setup() handlers should return 1 to obsolete_checksetup() in
> init/main.c to indicate that the boot option has been handled.
> A return of 0 causes the boot option/value to be listed as an Unknown
> kernel parameter and added to init's (limited) argument or environment
> strings. Also, error return codes don't mean anything to
> obsolete_checksetup() -- only non-zero (usually 1) or zero.
> So return 1 from cpm_powersave_off().
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/4xx: cpm: fix return value of __setup handler
https://git.kernel.org/powerpc/c/5bb99fd4090fe1acfdb90a97993fcda7f8f5a3d6
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-15 10:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-02 19:29 [PATCH v2] powerpc/4xx: cpm: fix return value of __setup handler Randy Dunlap
2022-05-02 19:29 ` Randy Dunlap
2022-05-15 10:12 ` Michael Ellerman
2022-05-15 10:12 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.