* [PATCH] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
@ 2022-05-09 9:05 ` Dan Carpenter
0 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2022-05-09 9:05 UTC (permalink / raw)
To: Sandy Huang
Cc: Heiko Stübner, David Airlie, Daniel Vetter, Sascha Hauer,
Rob Herring, Andy Yan, dri-devel, linux-arm-kernel,
linux-rockchip, kernel-janitors
This error path needs an unlock before returning.
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 0b49fed16535..b68922943825 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -1524,6 +1524,7 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc,
if (ret < 0) {
drm_err(vop2->drm, "failed to enable dclk for video port%d - %d\n",
vp->id, ret);
+ vop2_unlock(vop2);
return;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
@ 2022-05-09 9:05 ` Dan Carpenter
0 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2022-05-09 9:05 UTC (permalink / raw)
To: Sandy Huang
Cc: Heiko Stübner, David Airlie, Daniel Vetter, Sascha Hauer,
Rob Herring, Andy Yan, dri-devel, linux-arm-kernel,
linux-rockchip, kernel-janitors
This error path needs an unlock before returning.
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 0b49fed16535..b68922943825 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -1524,6 +1524,7 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc,
if (ret < 0) {
drm_err(vop2->drm, "failed to enable dclk for video port%d - %d\n",
vp->id, ret);
+ vop2_unlock(vop2);
return;
}
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
@ 2022-05-09 9:05 ` Dan Carpenter
0 siblings, 0 replies; 12+ messages in thread
From: Dan Carpenter @ 2022-05-09 9:05 UTC (permalink / raw)
To: Sandy Huang
Cc: David Airlie, Sascha Hauer, kernel-janitors, dri-devel,
linux-rockchip, Andy Yan, linux-arm-kernel
This error path needs an unlock before returning.
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 0b49fed16535..b68922943825 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -1524,6 +1524,7 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc,
if (ret < 0) {
drm_err(vop2->drm, "failed to enable dclk for video port%d - %d\n",
vp->id, ret);
+ vop2_unlock(vop2);
return;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
2022-05-09 9:05 ` Dan Carpenter
(?)
(?)
@ 2022-05-09 9:51 ` Sascha Hauer
-1 siblings, 0 replies; 12+ messages in thread
From: Sascha Hauer @ 2022-05-09 9:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, kernel-janitors, Sandy Huang, dri-devel,
linux-rockchip, Andy Yan, linux-arm-kernel
On Mon, May 09, 2022 at 12:05:05PM +0300, Dan Carpenter wrote:
> This error path needs an unlock before returning.
Indeed.
>
> Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> index 0b49fed16535..b68922943825 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> @@ -1524,6 +1524,7 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc,
> if (ret < 0) {
> drm_err(vop2->drm, "failed to enable dclk for video port%d - %d\n",
> vp->id, ret);
> + vop2_unlock(vop2);
> return;
> }
>
> --
> 2.35.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
@ 2022-05-09 9:51 ` Sascha Hauer
0 siblings, 0 replies; 12+ messages in thread
From: Sascha Hauer @ 2022-05-09 9:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter,
Rob Herring, Andy Yan, dri-devel, linux-arm-kernel,
linux-rockchip, kernel-janitors
On Mon, May 09, 2022 at 12:05:05PM +0300, Dan Carpenter wrote:
> This error path needs an unlock before returning.
Indeed.
>
> Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> index 0b49fed16535..b68922943825 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> @@ -1524,6 +1524,7 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc,
> if (ret < 0) {
> drm_err(vop2->drm, "failed to enable dclk for video port%d - %d\n",
> vp->id, ret);
> + vop2_unlock(vop2);
> return;
> }
>
> --
> 2.35.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
@ 2022-05-09 9:51 ` Sascha Hauer
0 siblings, 0 replies; 12+ messages in thread
From: Sascha Hauer @ 2022-05-09 9:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter,
Rob Herring, Andy Yan, dri-devel, linux-arm-kernel,
linux-rockchip, kernel-janitors
On Mon, May 09, 2022 at 12:05:05PM +0300, Dan Carpenter wrote:
> This error path needs an unlock before returning.
Indeed.
>
> Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> index 0b49fed16535..b68922943825 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> @@ -1524,6 +1524,7 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc,
> if (ret < 0) {
> drm_err(vop2->drm, "failed to enable dclk for video port%d - %d\n",
> vp->id, ret);
> + vop2_unlock(vop2);
> return;
> }
>
> --
> 2.35.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
@ 2022-05-09 9:51 ` Sascha Hauer
0 siblings, 0 replies; 12+ messages in thread
From: Sascha Hauer @ 2022-05-09 9:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter,
Rob Herring, Andy Yan, dri-devel, linux-arm-kernel,
linux-rockchip, kernel-janitors
On Mon, May 09, 2022 at 12:05:05PM +0300, Dan Carpenter wrote:
> This error path needs an unlock before returning.
Indeed.
>
> Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> index 0b49fed16535..b68922943825 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> @@ -1524,6 +1524,7 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc,
> if (ret < 0) {
> drm_err(vop2->drm, "failed to enable dclk for video port%d - %d\n",
> vp->id, ret);
> + vop2_unlock(vop2);
> return;
> }
>
> --
> 2.35.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
2022-05-09 9:05 ` Dan Carpenter
(?)
(?)
@ 2022-05-15 20:07 ` Heiko Stuebner
-1 siblings, 0 replies; 12+ messages in thread
From: Heiko Stuebner @ 2022-05-15 20:07 UTC (permalink / raw)
To: Sandy Huang, Dan Carpenter
Cc: Heiko Stuebner, linux-rockchip, dri-devel, Andy Yan,
kernel-janitors, David Airlie, linux-arm-kernel, Sascha Hauer
On Mon, 9 May 2022 12:05:05 +0300, Dan Carpenter wrote:
> This error path needs an unlock before returning.
Applied, thanks!
[1/1] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
commit: 98526c5bbe3267d447ddd076b685439e3e1396c6
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
@ 2022-05-15 20:07 ` Heiko Stuebner
0 siblings, 0 replies; 12+ messages in thread
From: Heiko Stuebner @ 2022-05-15 20:07 UTC (permalink / raw)
To: Sandy Huang, Dan Carpenter
Cc: Heiko Stuebner, linux-rockchip, dri-devel, Andy Yan,
kernel-janitors, David Airlie, linux-arm-kernel, Sascha Hauer
On Mon, 9 May 2022 12:05:05 +0300, Dan Carpenter wrote:
> This error path needs an unlock before returning.
Applied, thanks!
[1/1] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
commit: 98526c5bbe3267d447ddd076b685439e3e1396c6
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
@ 2022-05-15 20:07 ` Heiko Stuebner
0 siblings, 0 replies; 12+ messages in thread
From: Heiko Stuebner @ 2022-05-15 20:07 UTC (permalink / raw)
To: Sandy Huang, Dan Carpenter
Cc: David Airlie, Sascha Hauer, kernel-janitors, dri-devel,
linux-rockchip, Andy Yan, linux-arm-kernel
On Mon, 9 May 2022 12:05:05 +0300, Dan Carpenter wrote:
> This error path needs an unlock before returning.
Applied, thanks!
[1/1] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
commit: 98526c5bbe3267d447ddd076b685439e3e1396c6
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
@ 2022-05-15 20:07 ` Heiko Stuebner
0 siblings, 0 replies; 12+ messages in thread
From: Heiko Stuebner @ 2022-05-15 20:07 UTC (permalink / raw)
To: Sandy Huang, Dan Carpenter
Cc: Heiko Stuebner, linux-rockchip, dri-devel, Andy Yan,
kernel-janitors, David Airlie, linux-arm-kernel, Sascha Hauer
On Mon, 9 May 2022 12:05:05 +0300, Dan Carpenter wrote:
> This error path needs an unlock before returning.
Applied, thanks!
[1/1] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()
commit: 98526c5bbe3267d447ddd076b685439e3e1396c6
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 12+ messages in thread