* [Intel-gfx] [PATCH 1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant
@ 2022-05-18 11:33 Jani Nikula
2022-05-18 11:33 ` [Intel-gfx] [PATCH 2/2] drm/i915/uc: Fix " Jani Nikula
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Jani Nikula @ 2022-05-18 11:33 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, Borislav Petkov, Randy Dunlap, Ruiqi GONG
Use REG_GENMASK() and REG_FIELD_PREP() to avoid errors due to
-fsanitize=shift.
References: https://lore.kernel.org/r/20220405151517.29753-12-bp@alien8.de
Reported-by: Borislav Petkov <bp@suse.de>
Reported-by: Ruiqi GONG <gongruiqi1@huawei.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 321a08281a3f..dff3f88d8090 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -7607,25 +7607,25 @@ enum skl_power_gate {
#define _PORT_CLK_SEL_A 0x46100
#define _PORT_CLK_SEL_B 0x46104
#define PORT_CLK_SEL(port) _MMIO_PORT(port, _PORT_CLK_SEL_A, _PORT_CLK_SEL_B)
-#define PORT_CLK_SEL_LCPLL_2700 (0 << 29)
-#define PORT_CLK_SEL_LCPLL_1350 (1 << 29)
-#define PORT_CLK_SEL_LCPLL_810 (2 << 29)
-#define PORT_CLK_SEL_SPLL (3 << 29)
-#define PORT_CLK_SEL_WRPLL(pll) (((pll) + 4) << 29)
-#define PORT_CLK_SEL_WRPLL1 (4 << 29)
-#define PORT_CLK_SEL_WRPLL2 (5 << 29)
-#define PORT_CLK_SEL_NONE (7 << 29)
-#define PORT_CLK_SEL_MASK (7 << 29)
+#define PORT_CLK_SEL_MASK REG_GENMASK(31, 29)
+#define PORT_CLK_SEL_LCPLL_2700 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 0)
+#define PORT_CLK_SEL_LCPLL_1350 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 1)
+#define PORT_CLK_SEL_LCPLL_810 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 2)
+#define PORT_CLK_SEL_SPLL REG_FIELD_PREP(PORT_CLK_SEL_MASK, 3)
+#define PORT_CLK_SEL_WRPLL(pll) REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4 + (pll))
+#define PORT_CLK_SEL_WRPLL1 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4)
+#define PORT_CLK_SEL_WRPLL2 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 5)
+#define PORT_CLK_SEL_NONE REG_FIELD_PREP(PORT_CLK_SEL_MASK, 7)
/* On ICL+ this is the same as PORT_CLK_SEL, but all bits change. */
#define DDI_CLK_SEL(port) PORT_CLK_SEL(port)
-#define DDI_CLK_SEL_NONE (0x0 << 28)
-#define DDI_CLK_SEL_MG (0x8 << 28)
-#define DDI_CLK_SEL_TBT_162 (0xC << 28)
-#define DDI_CLK_SEL_TBT_270 (0xD << 28)
-#define DDI_CLK_SEL_TBT_540 (0xE << 28)
-#define DDI_CLK_SEL_TBT_810 (0xF << 28)
-#define DDI_CLK_SEL_MASK (0xF << 28)
+#define DDI_CLK_SEL_MASK REG_GENMASK(31, 28)
+#define DDI_CLK_SEL_NONE REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x0)
+#define DDI_CLK_SEL_MG REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x8)
+#define DDI_CLK_SEL_TBT_162 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xC)
+#define DDI_CLK_SEL_TBT_270 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xD)
+#define DDI_CLK_SEL_TBT_540 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xE)
+#define DDI_CLK_SEL_TBT_810 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xF)
/* Transcoder clock selection */
#define _TRANS_CLK_SEL_A 0x46140
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915/uc: Fix undefined behavior due to shift overflowing the constant
2022-05-18 11:33 [Intel-gfx] [PATCH 1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant Jani Nikula
@ 2022-05-18 11:33 ` Jani Nikula
2022-05-18 14:08 ` Michal Wajdeczko
2022-05-18 12:53 ` [Intel-gfx] [PATCH 1/2] drm/i915/reg: fix " Ville Syrjälä
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Jani Nikula @ 2022-05-18 11:33 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, Randy Dunlap, Ruiqi GONG, Borislav Petkov
From: Borislav Petkov <bp@suse.de>
Fix:
In file included from <command-line>:0:0:
drivers/gpu/drm/i915/gt/uc/intel_guc.c: In function ‘intel_guc_send_mmio’:
././include/linux/compiler_types.h:352:38: error: call to ‘__compiletime_assert_1047’ \
declared with attribute error: FIELD_PREP: mask is not constant
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
and other build errors due to shift overflowing values.
See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
details as to why it triggers with older gccs only.
v2 by Jani:
- Drop the i915_reg.h changes
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Ruiqi GONG <gongruiqi1@huawei.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 2 +-
drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h | 2 +-
drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h | 2 +-
drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
index be9ac47fa9d0..4ef9990ed7f8 100644
--- a/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
+++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
@@ -50,7 +50,7 @@
#define HOST2GUC_SELF_CFG_REQUEST_MSG_LEN (GUC_HXG_REQUEST_MSG_MIN_LEN + 3u)
#define HOST2GUC_SELF_CFG_REQUEST_MSG_0_MBZ GUC_HXG_REQUEST_MSG_0_DATA0
-#define HOST2GUC_SELF_CFG_REQUEST_MSG_1_KLV_KEY (0xffff << 16)
+#define HOST2GUC_SELF_CFG_REQUEST_MSG_1_KLV_KEY (0xffffU << 16)
#define HOST2GUC_SELF_CFG_REQUEST_MSG_1_KLV_LEN (0xffff << 0)
#define HOST2GUC_SELF_CFG_REQUEST_MSG_2_VALUE32 GUC_HXG_REQUEST_MSG_n_DATAn
#define HOST2GUC_SELF_CFG_REQUEST_MSG_3_VALUE64 GUC_HXG_REQUEST_MSG_n_DATAn
diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
index c9086a600bce..df83c1cc7c7a 100644
--- a/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
+++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
@@ -82,7 +82,7 @@ static_assert(sizeof(struct guc_ct_buffer_desc) == 64);
#define GUC_CTB_HDR_LEN 1u
#define GUC_CTB_MSG_MIN_LEN GUC_CTB_HDR_LEN
#define GUC_CTB_MSG_MAX_LEN 256u
-#define GUC_CTB_MSG_0_FENCE (0xffff << 16)
+#define GUC_CTB_MSG_0_FENCE (0xffffU << 16)
#define GUC_CTB_MSG_0_FORMAT (0xf << 12)
#define GUC_CTB_FORMAT_HXG 0u
#define GUC_CTB_MSG_0_RESERVED (0xf << 8)
diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
index 29ac823acd4c..7d5ba4d97d70 100644
--- a/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
+++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
@@ -40,7 +40,7 @@
*/
#define GUC_HXG_MSG_MIN_LEN 1u
-#define GUC_HXG_MSG_0_ORIGIN (0x1 << 31)
+#define GUC_HXG_MSG_0_ORIGIN (0x1U << 31)
#define GUC_HXG_ORIGIN_HOST 0u
#define GUC_HXG_ORIGIN_GUC 1u
#define GUC_HXG_MSG_0_TYPE (0x7 << 28)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h b/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h
index 2516705b9f36..8dc063f087eb 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h
@@ -28,7 +28,7 @@
#define GS_MIA_HALT_REQUESTED (0x02 << GS_MIA_SHIFT)
#define GS_MIA_ISR_ENTRY (0x04 << GS_MIA_SHIFT)
#define GS_AUTH_STATUS_SHIFT 30
-#define GS_AUTH_STATUS_MASK (0x03 << GS_AUTH_STATUS_SHIFT)
+#define GS_AUTH_STATUS_MASK (0x03U << GS_AUTH_STATUS_SHIFT)
#define GS_AUTH_STATUS_BAD (0x01 << GS_AUTH_STATUS_SHIFT)
#define GS_AUTH_STATUS_GOOD (0x02 << GS_AUTH_STATUS_SHIFT)
--
2.30.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant
2022-05-18 11:33 [Intel-gfx] [PATCH 1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant Jani Nikula
2022-05-18 11:33 ` [Intel-gfx] [PATCH 2/2] drm/i915/uc: Fix " Jani Nikula
@ 2022-05-18 12:53 ` Ville Syrjälä
2022-05-18 13:52 ` Jani Nikula
2022-05-18 13:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] " Patchwork
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Ville Syrjälä @ 2022-05-18 12:53 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, Borislav Petkov, Randy Dunlap, Ruiqi GONG
On Wed, May 18, 2022 at 02:33:14PM +0300, Jani Nikula wrote:
> Use REG_GENMASK() and REG_FIELD_PREP() to avoid errors due to
> -fsanitize=shift.
I presume it's just unhappy about shifting into the sign bit?
Changes look correct:
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> References: https://lore.kernel.org/r/20220405151517.29753-12-bp@alien8.de
> Reported-by: Borislav Petkov <bp@suse.de>
> Reported-by: Ruiqi GONG <gongruiqi1@huawei.com>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 321a08281a3f..dff3f88d8090 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -7607,25 +7607,25 @@ enum skl_power_gate {
> #define _PORT_CLK_SEL_A 0x46100
> #define _PORT_CLK_SEL_B 0x46104
> #define PORT_CLK_SEL(port) _MMIO_PORT(port, _PORT_CLK_SEL_A, _PORT_CLK_SEL_B)
> -#define PORT_CLK_SEL_LCPLL_2700 (0 << 29)
> -#define PORT_CLK_SEL_LCPLL_1350 (1 << 29)
> -#define PORT_CLK_SEL_LCPLL_810 (2 << 29)
> -#define PORT_CLK_SEL_SPLL (3 << 29)
> -#define PORT_CLK_SEL_WRPLL(pll) (((pll) + 4) << 29)
> -#define PORT_CLK_SEL_WRPLL1 (4 << 29)
> -#define PORT_CLK_SEL_WRPLL2 (5 << 29)
> -#define PORT_CLK_SEL_NONE (7 << 29)
> -#define PORT_CLK_SEL_MASK (7 << 29)
> +#define PORT_CLK_SEL_MASK REG_GENMASK(31, 29)
> +#define PORT_CLK_SEL_LCPLL_2700 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 0)
> +#define PORT_CLK_SEL_LCPLL_1350 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 1)
> +#define PORT_CLK_SEL_LCPLL_810 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 2)
> +#define PORT_CLK_SEL_SPLL REG_FIELD_PREP(PORT_CLK_SEL_MASK, 3)
> +#define PORT_CLK_SEL_WRPLL(pll) REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4 + (pll))
> +#define PORT_CLK_SEL_WRPLL1 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4)
> +#define PORT_CLK_SEL_WRPLL2 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 5)
> +#define PORT_CLK_SEL_NONE REG_FIELD_PREP(PORT_CLK_SEL_MASK, 7)
>
> /* On ICL+ this is the same as PORT_CLK_SEL, but all bits change. */
> #define DDI_CLK_SEL(port) PORT_CLK_SEL(port)
> -#define DDI_CLK_SEL_NONE (0x0 << 28)
> -#define DDI_CLK_SEL_MG (0x8 << 28)
> -#define DDI_CLK_SEL_TBT_162 (0xC << 28)
> -#define DDI_CLK_SEL_TBT_270 (0xD << 28)
> -#define DDI_CLK_SEL_TBT_540 (0xE << 28)
> -#define DDI_CLK_SEL_TBT_810 (0xF << 28)
> -#define DDI_CLK_SEL_MASK (0xF << 28)
> +#define DDI_CLK_SEL_MASK REG_GENMASK(31, 28)
> +#define DDI_CLK_SEL_NONE REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x0)
> +#define DDI_CLK_SEL_MG REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x8)
> +#define DDI_CLK_SEL_TBT_162 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xC)
> +#define DDI_CLK_SEL_TBT_270 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xD)
> +#define DDI_CLK_SEL_TBT_540 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xE)
> +#define DDI_CLK_SEL_TBT_810 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xF)
>
> /* Transcoder clock selection */
> #define _TRANS_CLK_SEL_A 0x46140
> --
> 2.30.2
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant
2022-05-18 12:53 ` [Intel-gfx] [PATCH 1/2] drm/i915/reg: fix " Ville Syrjälä
@ 2022-05-18 13:52 ` Jani Nikula
2022-05-19 8:25 ` Jani Nikula
0 siblings, 1 reply; 11+ messages in thread
From: Jani Nikula @ 2022-05-18 13:52 UTC (permalink / raw)
To: Ville Syrjälä
Cc: intel-gfx, Borislav Petkov, Randy Dunlap, Ruiqi GONG
On Wed, 18 May 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, May 18, 2022 at 02:33:14PM +0300, Jani Nikula wrote:
>> Use REG_GENMASK() and REG_FIELD_PREP() to avoid errors due to
>> -fsanitize=shift.
>
> I presume it's just unhappy about shifting into the sign bit?
Yeah, and apparently it also only happens on some GCC versions. *shrug*.
>
> Changes look correct:
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks,
Jani.
>
>>
>> References: https://lore.kernel.org/r/20220405151517.29753-12-bp@alien8.de
>> Reported-by: Borislav Petkov <bp@suse.de>
>> Reported-by: Ruiqi GONG <gongruiqi1@huawei.com>
>> Cc: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/i915_reg.h | 32 ++++++++++++++++----------------
>> 1 file changed, 16 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>> index 321a08281a3f..dff3f88d8090 100644
>> --- a/drivers/gpu/drm/i915/i915_reg.h
>> +++ b/drivers/gpu/drm/i915/i915_reg.h
>> @@ -7607,25 +7607,25 @@ enum skl_power_gate {
>> #define _PORT_CLK_SEL_A 0x46100
>> #define _PORT_CLK_SEL_B 0x46104
>> #define PORT_CLK_SEL(port) _MMIO_PORT(port, _PORT_CLK_SEL_A, _PORT_CLK_SEL_B)
>> -#define PORT_CLK_SEL_LCPLL_2700 (0 << 29)
>> -#define PORT_CLK_SEL_LCPLL_1350 (1 << 29)
>> -#define PORT_CLK_SEL_LCPLL_810 (2 << 29)
>> -#define PORT_CLK_SEL_SPLL (3 << 29)
>> -#define PORT_CLK_SEL_WRPLL(pll) (((pll) + 4) << 29)
>> -#define PORT_CLK_SEL_WRPLL1 (4 << 29)
>> -#define PORT_CLK_SEL_WRPLL2 (5 << 29)
>> -#define PORT_CLK_SEL_NONE (7 << 29)
>> -#define PORT_CLK_SEL_MASK (7 << 29)
>> +#define PORT_CLK_SEL_MASK REG_GENMASK(31, 29)
>> +#define PORT_CLK_SEL_LCPLL_2700 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 0)
>> +#define PORT_CLK_SEL_LCPLL_1350 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 1)
>> +#define PORT_CLK_SEL_LCPLL_810 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 2)
>> +#define PORT_CLK_SEL_SPLL REG_FIELD_PREP(PORT_CLK_SEL_MASK, 3)
>> +#define PORT_CLK_SEL_WRPLL(pll) REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4 + (pll))
>> +#define PORT_CLK_SEL_WRPLL1 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4)
>> +#define PORT_CLK_SEL_WRPLL2 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 5)
>> +#define PORT_CLK_SEL_NONE REG_FIELD_PREP(PORT_CLK_SEL_MASK, 7)
>>
>> /* On ICL+ this is the same as PORT_CLK_SEL, but all bits change. */
>> #define DDI_CLK_SEL(port) PORT_CLK_SEL(port)
>> -#define DDI_CLK_SEL_NONE (0x0 << 28)
>> -#define DDI_CLK_SEL_MG (0x8 << 28)
>> -#define DDI_CLK_SEL_TBT_162 (0xC << 28)
>> -#define DDI_CLK_SEL_TBT_270 (0xD << 28)
>> -#define DDI_CLK_SEL_TBT_540 (0xE << 28)
>> -#define DDI_CLK_SEL_TBT_810 (0xF << 28)
>> -#define DDI_CLK_SEL_MASK (0xF << 28)
>> +#define DDI_CLK_SEL_MASK REG_GENMASK(31, 28)
>> +#define DDI_CLK_SEL_NONE REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x0)
>> +#define DDI_CLK_SEL_MG REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x8)
>> +#define DDI_CLK_SEL_TBT_162 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xC)
>> +#define DDI_CLK_SEL_TBT_270 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xD)
>> +#define DDI_CLK_SEL_TBT_540 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xE)
>> +#define DDI_CLK_SEL_TBT_810 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xF)
>>
>> /* Transcoder clock selection */
>> #define _TRANS_CLK_SEL_A 0x46140
>> --
>> 2.30.2
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant
2022-05-18 11:33 [Intel-gfx] [PATCH 1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant Jani Nikula
2022-05-18 11:33 ` [Intel-gfx] [PATCH 2/2] drm/i915/uc: Fix " Jani Nikula
2022-05-18 12:53 ` [Intel-gfx] [PATCH 1/2] drm/i915/reg: fix " Ville Syrjälä
@ 2022-05-18 13:59 ` Patchwork
2022-05-18 14:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-18 17:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2022-05-18 13:59 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant
URL : https://patchwork.freedesktop.org/series/104122/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/uc: Fix undefined behavior due to shift overflowing the constant
2022-05-18 11:33 ` [Intel-gfx] [PATCH 2/2] drm/i915/uc: Fix " Jani Nikula
@ 2022-05-18 14:08 ` Michal Wajdeczko
2022-05-18 14:15 ` Jani Nikula
0 siblings, 1 reply; 11+ messages in thread
From: Michal Wajdeczko @ 2022-05-18 14:08 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Randy Dunlap, Borislav Petkov, Ruiqi GONG
On 18.05.2022 13:33, Jani Nikula wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Fix:
>
> In file included from <command-line>:0:0:
> drivers/gpu/drm/i915/gt/uc/intel_guc.c: In function ‘intel_guc_send_mmio’:
> ././include/linux/compiler_types.h:352:38: error: call to ‘__compiletime_assert_1047’ \
> declared with attribute error: FIELD_PREP: mask is not constant
> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>
> and other build errors due to shift overflowing values.
>
> See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
> details as to why it triggers with older gccs only.
>
> v2 by Jani:
> - Drop the i915_reg.h changes
>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Cc: Ruiqi GONG <gongruiqi1@huawei.com>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 2 +-
> drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h | 2 +-
> drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h | 2 +-
> drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
> index be9ac47fa9d0..4ef9990ed7f8 100644
> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
> @@ -50,7 +50,7 @@
>
> #define HOST2GUC_SELF_CFG_REQUEST_MSG_LEN (GUC_HXG_REQUEST_MSG_MIN_LEN + 3u)
> #define HOST2GUC_SELF_CFG_REQUEST_MSG_0_MBZ GUC_HXG_REQUEST_MSG_0_DATA0
> -#define HOST2GUC_SELF_CFG_REQUEST_MSG_1_KLV_KEY (0xffff << 16)
> +#define HOST2GUC_SELF_CFG_REQUEST_MSG_1_KLV_KEY (0xffffU << 16)
nit: maybe for consistency we should update all these hex constants to
be explicitly marked as "unsigned" (as that was the intention) and also
maybe we should use lowercase "u" - but both that can be done later,
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> #define HOST2GUC_SELF_CFG_REQUEST_MSG_1_KLV_LEN (0xffff << 0)
> #define HOST2GUC_SELF_CFG_REQUEST_MSG_2_VALUE32 GUC_HXG_REQUEST_MSG_n_DATAn
> #define HOST2GUC_SELF_CFG_REQUEST_MSG_3_VALUE64 GUC_HXG_REQUEST_MSG_n_DATAn
> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
> index c9086a600bce..df83c1cc7c7a 100644
> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
> @@ -82,7 +82,7 @@ static_assert(sizeof(struct guc_ct_buffer_desc) == 64);
> #define GUC_CTB_HDR_LEN 1u
> #define GUC_CTB_MSG_MIN_LEN GUC_CTB_HDR_LEN
> #define GUC_CTB_MSG_MAX_LEN 256u
> -#define GUC_CTB_MSG_0_FENCE (0xffff << 16)
> +#define GUC_CTB_MSG_0_FENCE (0xffffU << 16)
> #define GUC_CTB_MSG_0_FORMAT (0xf << 12)
> #define GUC_CTB_FORMAT_HXG 0u
> #define GUC_CTB_MSG_0_RESERVED (0xf << 8)
> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
> index 29ac823acd4c..7d5ba4d97d70 100644
> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
> @@ -40,7 +40,7 @@
> */
>
> #define GUC_HXG_MSG_MIN_LEN 1u
> -#define GUC_HXG_MSG_0_ORIGIN (0x1 << 31)
> +#define GUC_HXG_MSG_0_ORIGIN (0x1U << 31)
> #define GUC_HXG_ORIGIN_HOST 0u
> #define GUC_HXG_ORIGIN_GUC 1u
> #define GUC_HXG_MSG_0_TYPE (0x7 << 28)
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h b/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h
> index 2516705b9f36..8dc063f087eb 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h
> @@ -28,7 +28,7 @@
> #define GS_MIA_HALT_REQUESTED (0x02 << GS_MIA_SHIFT)
> #define GS_MIA_ISR_ENTRY (0x04 << GS_MIA_SHIFT)
> #define GS_AUTH_STATUS_SHIFT 30
> -#define GS_AUTH_STATUS_MASK (0x03 << GS_AUTH_STATUS_SHIFT)
> +#define GS_AUTH_STATUS_MASK (0x03U << GS_AUTH_STATUS_SHIFT)
> #define GS_AUTH_STATUS_BAD (0x01 << GS_AUTH_STATUS_SHIFT)
> #define GS_AUTH_STATUS_GOOD (0x02 << GS_AUTH_STATUS_SHIFT)
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/uc: Fix undefined behavior due to shift overflowing the constant
2022-05-18 14:08 ` Michal Wajdeczko
@ 2022-05-18 14:15 ` Jani Nikula
2022-05-19 8:38 ` Jani Nikula
0 siblings, 1 reply; 11+ messages in thread
From: Jani Nikula @ 2022-05-18 14:15 UTC (permalink / raw)
To: Michal Wajdeczko, intel-gfx; +Cc: Randy Dunlap, Borislav Petkov, Ruiqi GONG
On Wed, 18 May 2022, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> On 18.05.2022 13:33, Jani Nikula wrote:
>> From: Borislav Petkov <bp@suse.de>
>>
>> Fix:
>>
>> In file included from <command-line>:0:0:
>> drivers/gpu/drm/i915/gt/uc/intel_guc.c: In function ‘intel_guc_send_mmio’:
>> ././include/linux/compiler_types.h:352:38: error: call to ‘__compiletime_assert_1047’ \
>> declared with attribute error: FIELD_PREP: mask is not constant
>> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>
>> and other build errors due to shift overflowing values.
>>
>> See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
>> details as to why it triggers with older gccs only.
>>
>> v2 by Jani:
>> - Drop the i915_reg.h changes
>>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>> Cc: Ruiqi GONG <gongruiqi1@huawei.com>
>> Cc: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Borislav Petkov <bp@suse.de>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 2 +-
>> drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h | 2 +-
>> drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h | 2 +-
>> drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h | 2 +-
>> 4 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
>> index be9ac47fa9d0..4ef9990ed7f8 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
>> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
>> @@ -50,7 +50,7 @@
>>
>> #define HOST2GUC_SELF_CFG_REQUEST_MSG_LEN (GUC_HXG_REQUEST_MSG_MIN_LEN + 3u)
>> #define HOST2GUC_SELF_CFG_REQUEST_MSG_0_MBZ GUC_HXG_REQUEST_MSG_0_DATA0
>> -#define HOST2GUC_SELF_CFG_REQUEST_MSG_1_KLV_KEY (0xffff << 16)
>> +#define HOST2GUC_SELF_CFG_REQUEST_MSG_1_KLV_KEY (0xffffU << 16)
>
> nit: maybe for consistency we should update all these hex constants to
> be explicitly marked as "unsigned" (as that was the intention) and also
> maybe we should use lowercase "u" - but both that can be done later,
For the guc reg stuff we should probably use REG_GENMASK() and
REG_FIELD_PREP() instead, like I did for i915_reg.h. I just don't know
about the plethora of other uc headers though...
> Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Thanks,
Jani.
>
>> #define HOST2GUC_SELF_CFG_REQUEST_MSG_1_KLV_LEN (0xffff << 0)
>> #define HOST2GUC_SELF_CFG_REQUEST_MSG_2_VALUE32 GUC_HXG_REQUEST_MSG_n_DATAn
>> #define HOST2GUC_SELF_CFG_REQUEST_MSG_3_VALUE64 GUC_HXG_REQUEST_MSG_n_DATAn
>> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
>> index c9086a600bce..df83c1cc7c7a 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
>> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
>> @@ -82,7 +82,7 @@ static_assert(sizeof(struct guc_ct_buffer_desc) == 64);
>> #define GUC_CTB_HDR_LEN 1u
>> #define GUC_CTB_MSG_MIN_LEN GUC_CTB_HDR_LEN
>> #define GUC_CTB_MSG_MAX_LEN 256u
>> -#define GUC_CTB_MSG_0_FENCE (0xffff << 16)
>> +#define GUC_CTB_MSG_0_FENCE (0xffffU << 16)
>> #define GUC_CTB_MSG_0_FORMAT (0xf << 12)
>> #define GUC_CTB_FORMAT_HXG 0u
>> #define GUC_CTB_MSG_0_RESERVED (0xf << 8)
>> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
>> index 29ac823acd4c..7d5ba4d97d70 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
>> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
>> @@ -40,7 +40,7 @@
>> */
>>
>> #define GUC_HXG_MSG_MIN_LEN 1u
>> -#define GUC_HXG_MSG_0_ORIGIN (0x1 << 31)
>> +#define GUC_HXG_MSG_0_ORIGIN (0x1U << 31)
>> #define GUC_HXG_ORIGIN_HOST 0u
>> #define GUC_HXG_ORIGIN_GUC 1u
>> #define GUC_HXG_MSG_0_TYPE (0x7 << 28)
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h b/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h
>> index 2516705b9f36..8dc063f087eb 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h
>> @@ -28,7 +28,7 @@
>> #define GS_MIA_HALT_REQUESTED (0x02 << GS_MIA_SHIFT)
>> #define GS_MIA_ISR_ENTRY (0x04 << GS_MIA_SHIFT)
>> #define GS_AUTH_STATUS_SHIFT 30
>> -#define GS_AUTH_STATUS_MASK (0x03 << GS_AUTH_STATUS_SHIFT)
>> +#define GS_AUTH_STATUS_MASK (0x03U << GS_AUTH_STATUS_SHIFT)
>> #define GS_AUTH_STATUS_BAD (0x01 << GS_AUTH_STATUS_SHIFT)
>> #define GS_AUTH_STATUS_GOOD (0x02 << GS_AUTH_STATUS_SHIFT)
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant
2022-05-18 11:33 [Intel-gfx] [PATCH 1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant Jani Nikula
` (2 preceding siblings ...)
2022-05-18 13:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] " Patchwork
@ 2022-05-18 14:23 ` Patchwork
2022-05-18 17:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2022-05-18 14:23 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9736 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant
URL : https://patchwork.freedesktop.org/series/104122/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11673 -> Patchwork_104122v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/index.html
Participating hosts (47 -> 47)
------------------------------
Additional (3): bat-adlm-1 fi-icl-u2 fi-pnv-d510
Missing (3): bat-rpls-1 bat-dg2-9 fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_104122v1:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@gt_contexts:
- {bat-adlm-1}: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/bat-adlm-1/igt@i915_selftest@live@gt_contexts.html
Known issues
------------
Here are the changes found in Patchwork_104122v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-pnv-d510: NOTRUN -> [SKIP][2] ([fdo#109271]) +39 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-pnv-d510/igt@gem_huc_copy@huc-copy.html
- fi-icl-u2: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-icl-u2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][4] ([i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-icl-u2/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@i915_selftest@live@gem_contexts:
- fi-bdw-5557u: [PASS][5] -> [INCOMPLETE][6] ([i915#5502] / [i915#5801])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/fi-bdw-5557u/igt@i915_selftest@live@gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-bdw-5557u/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-g3258: [PASS][7] -> [INCOMPLETE][8] ([i915#3303] / [i915#4785])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-blb-e6850: [PASS][9] -> [DMESG-FAIL][10] ([i915#4528])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/fi-blb-e6850/igt@i915_selftest@live@requests.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-blb-e6850/igt@i915_selftest@live@requests.html
- fi-pnv-d510: NOTRUN -> [DMESG-FAIL][11] ([i915#4528])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-icl-u2: NOTRUN -> [SKIP][12] ([i915#5903])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-icl-u2/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-snb-2600: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-snb-2600/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][14] ([fdo#111827]) +8 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-icl-u2: NOTRUN -> [SKIP][15] ([fdo#109278]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][16] ([fdo#109285])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-icl-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-icl-u2: NOTRUN -> [SKIP][17] ([i915#3555])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-icl-u2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][18] ([i915#3301])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-icl-u2/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-pnv-d510: NOTRUN -> [FAIL][19] ([fdo#109271] / [i915#2403] / [i915#4312])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-pnv-d510/igt@runner@aborted.html
- fi-blb-e6850: NOTRUN -> [FAIL][20] ([fdo#109271] / [i915#2403] / [i915#4312])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-blb-e6850/igt@runner@aborted.html
- fi-hsw-g3258: NOTRUN -> [FAIL][21] ([fdo#109271] / [i915#4312])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-hsw-g3258/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-8809g: [DMESG-FAIL][22] ([i915#5334]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/fi-kbl-8809g/igt@i915_selftest@live@gt_heartbeat.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-kbl-8809g/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [DMESG-FAIL][24] ([i915#4494] / [i915#4957]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
- fi-snb-2600: [INCOMPLETE][26] ([i915#3921]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_flip@basic-flip-vs-modeset@b-edp1:
- {bat-adlp-6}: [DMESG-WARN][28] ([i915#3576]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5502]: https://gitlab.freedesktop.org/drm/intel/issues/5502
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#5801]: https://gitlab.freedesktop.org/drm/intel/issues/5801
[i915#5879]: https://gitlab.freedesktop.org/drm/intel/issues/5879
[i915#5885]: https://gitlab.freedesktop.org/drm/intel/issues/5885
[i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903
Build changes
-------------
* Linux: CI_DRM_11673 -> Patchwork_104122v1
CI-20190529: 20190529
CI_DRM_11673: 487728f8fae298d04767aa6cf8afea7a41b3e40b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6479: 78115aa8c8bcfc7784c7fc8dcaefcc2bce970b99 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_104122v1: 487728f8fae298d04767aa6cf8afea7a41b3e40b @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
f61eb396d9f6 drm/i915/uc: Fix undefined behavior due to shift overflowing the constant
736848a7afd2 drm/i915/reg: fix undefined behavior due to shift overflowing the constant
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/index.html
[-- Attachment #2: Type: text/html, Size: 10917 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant
2022-05-18 11:33 [Intel-gfx] [PATCH 1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant Jani Nikula
` (3 preceding siblings ...)
2022-05-18 14:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-05-18 17:10 ` Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2022-05-18 17:10 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 44197 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant
URL : https://patchwork.freedesktop.org/series/104122/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11673_full -> Patchwork_104122v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_104122v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_104122v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 12)
------------------------------
Missing (1): shard-rkl
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_104122v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_eio@in-flight-contexts-10ms:
- shard-glk: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-glk4/igt@gem_eio@in-flight-contexts-10ms.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk5/igt@gem_eio@in-flight-contexts-10ms.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@perf_pmu@module-unload:
- {shard-tglu}: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-tglu-4/igt@perf_pmu@module-unload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-tglu-6/igt@perf_pmu@module-unload.html
New tests
---------
New tests have been introduced between CI_DRM_11673_full and Patchwork_104122v1_full:
### New IGT tests (1) ###
* igt@kms_flip@basic-flip-vs-modeset@d-hdmi-a3:
- Statuses : 1 pass(s)
- Exec time: [0.66] s
Known issues
------------
Here are the changes found in Patchwork_104122v1_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-skl: ([PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25]) -> ([PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [FAIL][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50]) ([i915#5032])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl9/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl9/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl9/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl8/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl8/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl8/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl7/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl7/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl7/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl4/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl4/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl3/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl1/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl1/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl1/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl10/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl10/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl10/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl9/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl9/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl9/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl8/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl8/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl8/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl7/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl7/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl7/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl6/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl6/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl6/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl4/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl4/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl4/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl3/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl3/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl3/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl3/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl1/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl1/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl1/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl10/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl10/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl10/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][51] -> [FAIL][52] ([i915#5784]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-tglb7/igt@gem_eio@unwedge-stress.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-tglb8/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [PASS][53] -> [FAIL][54] ([i915#2842])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-glk5/igt@gem_exec_fair@basic-none-share@rcs0.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk7/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][55] -> [FAIL][56] ([i915#2842]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl6/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][57] -> [FAIL][58] ([i915#2842]) +3 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-kbl4/igt@gem_exec_fair@basic-pace@vecs0.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_flush@basic-batch-kernel-default-wb:
- shard-snb: [PASS][59] -> [SKIP][60] ([fdo#109271]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-snb5/igt@gem_exec_flush@basic-batch-kernel-default-wb.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-snb6/igt@gem_exec_flush@basic-batch-kernel-default-wb.html
* igt@gem_exec_whisper@basic-queues-all:
- shard-glk: [PASS][61] -> [DMESG-WARN][62] ([i915#118])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-glk1/igt@gem_exec_whisper@basic-queues-all.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk1/igt@gem_exec_whisper@basic-queues-all.html
* igt@gem_huc_copy@huc-copy:
- shard-skl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#2190])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl7/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- shard-glk: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#4613])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk9/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-verify:
- shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#4613])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl4/igt@gem_lmem_swapping@parallel-random-verify.html
* igt@gem_lmem_swapping@verify:
- shard-iclb: NOTRUN -> [SKIP][66] ([i915#4613])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@gem_lmem_swapping@verify.html
* igt@gem_lmem_swapping@verify-ccs:
- shard-skl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#4613])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl4/igt@gem_lmem_swapping@verify-ccs.html
* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][68] ([i915#768])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][69] -> [DMESG-WARN][70] ([i915#180]) +3 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl8/igt@gem_workarounds@suspend-resume-context.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][71] -> [DMESG-WARN][72] ([i915#5566] / [i915#716])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-apl8/igt@gen9_exec_parse@allowed-single.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl4/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@bb-large:
- shard-iclb: NOTRUN -> [SKIP][73] ([i915#2856])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@gen9_exec_parse@bb-large.html
* igt@i915_pm_lpsp@screens-disabled:
- shard-iclb: NOTRUN -> [SKIP][74] ([i915#1902])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@i915_pm_lpsp@screens-disabled.html
* igt@kms_async_flips@crc:
- shard-skl: NOTRUN -> [FAIL][75] ([i915#4272])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl4/igt@kms_async_flips@crc.html
* igt@kms_big_fb@4-tiled-16bpp-rotate-270:
- shard-glk: NOTRUN -> [SKIP][76] ([fdo#109271]) +6 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk9/igt@kms_big_fb@4-tiled-16bpp-rotate-270.html
* igt@kms_big_fb@4-tiled-16bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][77] ([i915#5286])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@kms_big_fb@4-tiled-16bpp-rotate-90.html
* igt@kms_big_fb@linear-32bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][78] ([fdo#110725] / [fdo#111614])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@kms_big_fb@linear-32bpp-rotate-270.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][79] ([i915#3763])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl4/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-180:
- shard-apl: NOTRUN -> [SKIP][80] ([fdo#109271]) +8 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl4/igt@kms_big_fb@yf-tiled-8bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][81] ([fdo#111615])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-tglb5/igt@kms_big_fb@yf-tiled-8bpp-rotate-270.html
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#3886]) +5 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl9/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#3886])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk9/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][84] ([fdo#109278] / [i915#3886]) +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-skl: NOTRUN -> [SKIP][85] ([fdo#109271] / [fdo#111827]) +17 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl9/igt@kms_chamelium@hdmi-aspect-ratio.html
* igt@kms_chamelium@hdmi-crc-fast:
- shard-tglb: NOTRUN -> [SKIP][86] ([fdo#109284] / [fdo#111827]) +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-tglb5/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_color_chamelium@pipe-b-ctm-blue-to-red:
- shard-iclb: NOTRUN -> [SKIP][87] ([fdo#109284] / [fdo#111827]) +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@kms_color_chamelium@pipe-b-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-d-ctm-limited-range:
- shard-glk: NOTRUN -> [SKIP][88] ([fdo#109271] / [fdo#111827])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk9/igt@kms_color_chamelium@pipe-d-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-d-gamma:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@kms_color_chamelium@pipe-d-gamma.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][90] ([fdo#109279] / [i915#3359])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-tglb5/igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement.html
* igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen:
- shard-skl: NOTRUN -> [SKIP][91] ([fdo#109271]) +235 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding:
- shard-iclb: NOTRUN -> [SKIP][92] ([fdo#109278] / [fdo#109279])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding.html
* igt@kms_cursor_crc@pipe-c-cursor-512x170-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#3359])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-tglb5/igt@kms_cursor_crc@pipe-c-cursor-512x170-rapid-movement.html
* igt@kms_cursor_crc@pipe-c-cursor-512x170-sliding:
- shard-skl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#5691])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl7/igt@kms_cursor_crc@pipe-c-cursor-512x170-sliding.html
* igt@kms_cursor_crc@pipe-d-cursor-128x128-sliding:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109278]) +11 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@kms_cursor_crc@pipe-d-cursor-128x128-sliding.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [PASS][96] -> [FAIL][97] ([i915#72])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk1/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [PASS][98] -> [FAIL][99] ([i915#2346])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: [PASS][100] -> [FAIL][101] ([i915#2346] / [i915#533])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-apl: NOTRUN -> [SKIP][102] ([fdo#109271] / [i915#533])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl4/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-iclb: [PASS][103] -> [DMESG-WARN][104] ([i915#2867])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-iclb7/igt@kms_fbcon_fbt@psr-suspend.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb3/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_flip@2x-blocking-wf_vblank:
- shard-tglb: NOTRUN -> [SKIP][105] ([fdo#109274] / [fdo#111825])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-tglb5/igt@kms_flip@2x-blocking-wf_vblank.html
* igt@kms_flip@2x-plain-flip-ts-check:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109274]) +2 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@kms_flip@2x-plain-flip-ts-check.html
* igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-edp1:
- shard-skl: [PASS][107] -> [FAIL][108] ([i915#2122])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl9/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-edp1.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl3/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][109] -> [FAIL][110] ([i915#79]) +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling:
- shard-skl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#3701]) +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html
* igt@kms_frontbuffer_tracking@fbc-2p-rte:
- shard-tglb: NOTRUN -> [SKIP][112] ([fdo#109280] / [fdo#111825]) +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-2p-rte.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render:
- shard-iclb: [PASS][113] -> [FAIL][114] ([i915#1888] / [i915#2546])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][115] ([fdo#109280]) +4 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#533])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][117] ([fdo#108145] / [i915#265]) +1 similar issue
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_plane_scaling@downscale-with-modifier-factor-0-25@pipe-a-edp-1-downscale-with-modifier:
- shard-skl: NOTRUN -> [SKIP][118] ([fdo#109271] / [i915#5176]) +2 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl9/igt@kms_plane_scaling@downscale-with-modifier-factor-0-25@pipe-a-edp-1-downscale-with-modifier.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][119] ([fdo#109271] / [i915#658]) +2 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
* igt@kms_psr@psr2_sprite_blt:
- shard-tglb: NOTRUN -> [FAIL][120] ([i915#132] / [i915#3467])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-tglb5/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][121] -> [SKIP][122] ([fdo#109441]) +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb1/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: NOTRUN -> [SKIP][123] ([fdo#109441])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@kms_psr@psr2_suspend.html
* igt@kms_setmode@clone-exclusive-crtc:
- shard-iclb: NOTRUN -> [SKIP][124] ([i915#3555])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@kms_setmode@clone-exclusive-crtc.html
* igt@kms_sysfs_edid_timing:
- shard-skl: NOTRUN -> [FAIL][125] ([IGT#2])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl4/igt@kms_sysfs_edid_timing.html
* igt@kms_tv_load_detect@load-detect:
- shard-iclb: NOTRUN -> [SKIP][126] ([fdo#109309])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@kms_tv_load_detect@load-detect.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-glk: NOTRUN -> [SKIP][127] ([fdo#109271] / [i915#2437])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk9/igt@kms_writeback@writeback-pixel-formats.html
- shard-skl: NOTRUN -> [SKIP][128] ([fdo#109271] / [i915#2437])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl8/igt@kms_writeback@writeback-pixel-formats.html
* igt@nouveau_crc@pipe-b-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][129] ([i915#2530])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@nouveau_crc@pipe-b-source-outp-complete.html
* igt@sysfs_clients@sema-25:
- shard-skl: NOTRUN -> [SKIP][130] ([fdo#109271] / [i915#2994]) +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl7/igt@sysfs_clients@sema-25.html
#### Possible fixes ####
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [SKIP][131] ([i915#4525]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-iclb3/igt@gem_exec_balancer@parallel-balancer.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb2/igt@gem_exec_balancer@parallel-balancer.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [FAIL][133] ([i915#2842]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-apl8/igt@gem_exec_fair@basic-none@vecs0.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl1/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [FAIL][135] ([i915#2842]) -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_flush@basic-batch-kernel-default-uc:
- shard-snb: [SKIP][137] ([fdo#109271]) -> [PASS][138] +3 similar issues
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-snb6/igt@gem_exec_flush@basic-batch-kernel-default-uc.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-snb4/igt@gem_exec_flush@basic-batch-kernel-default-uc.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][139] ([i915#2190]) -> [PASS][140]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-tglb7/igt@gem_huc_copy@huc-copy.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-tglb1/igt@gem_huc_copy@huc-copy.html
* igt@gem_softpin@evict-single-offset:
- shard-tglb: [FAIL][141] ([i915#4171]) -> [PASS][142]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-tglb6/igt@gem_softpin@evict-single-offset.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-tglb5/igt@gem_softpin@evict-single-offset.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [DMESG-WARN][143] ([i915#5566] / [i915#716]) -> [PASS][144]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-glk6/igt@gen9_exec_parse@allowed-single.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk9/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][145] ([i915#454]) -> [PASS][146] +1 similar issue
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb6/igt@i915_pm_dc@dc6-dpms.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-iclb: [FAIL][147] ([i915#5072]) -> [PASS][148]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-iclb7/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb3/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [INCOMPLETE][149] ([i915#180] / [i915#1982]) -> [PASS][150]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-apl7/igt@kms_fbcon_fbt@fbc-suspend.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl4/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][151] ([i915#2122]) -> [PASS][152] +1 similar issue
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-glk5/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk7/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2:
- shard-glk: [FAIL][153] ([i915#79]) -> [PASS][154]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-glk1/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk3/igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-edp1:
- shard-skl: [INCOMPLETE][155] ([i915#4939]) -> [PASS][156]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl4/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl8/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html
* igt@kms_flip@modeset-vs-vblank-race@d-edp1:
- shard-tglb: [INCOMPLETE][157] -> [PASS][158]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-tglb6/igt@kms_flip@modeset-vs-vblank-race@d-edp1.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-tglb5/igt@kms_flip@modeset-vs-vblank-race@d-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling:
- shard-glk: [FAIL][159] ([i915#4911]) -> [PASS][160]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][161] ([fdo#109441]) -> [PASS][162]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-iclb4/igt@kms_psr@psr2_primary_mmap_cpu.html
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
#### Warnings ####
* igt@gem_exec_balancer@parallel:
- shard-iclb: [DMESG-WARN][163] ([i915#5614]) -> [SKIP][164] ([i915#4525])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-iclb4/igt@gem_exec_balancer@parallel.html
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb7/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][165] ([i915#4525]) -> [DMESG-WARN][166] ([i915#5614]) +2 similar issues
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-iclb7/igt@gem_exec_balancer@parallel-keep-submit-fence.html
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb1/igt@gem_exec_balancer@parallel-keep-submit-fence.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][167] ([i915#2852]) -> [FAIL][168] ([i915#2842])
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-iclb2/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb1/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@kms_big_fb@4-tiled-16bpp-rotate-0:
- shard-skl: [SKIP][169] ([fdo#109271] / [i915#1888]) -> [SKIP][170] ([fdo#109271])
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl4/igt@kms_big_fb@4-tiled-16bpp-rotate-0.html
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl9/igt@kms_big_fb@4-tiled-16bpp-rotate-0.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: [FAIL][171] ([i915#1888] / [i915#3743]) -> [FAIL][172] ([i915#3743])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl4/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl8/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-skl: [SKIP][173] ([fdo#109271] / [fdo#111827] / [i915#1888]) -> [SKIP][174] ([fdo#109271] / [fdo#111827])
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-skl4/igt@kms_chamelium@vga-hpd-for-each-pipe.html
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-skl9/igt@kms_chamelium@vga-hpd-for-each-pipe.html
* igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes:
- shard-glk: [SKIP][175] ([fdo#109271]) -> [SKIP][176] ([fdo#109271] / [i915#1888])
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-glk8/igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes.html
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-glk2/igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][177] ([i915#2920]) -> [SKIP][178] ([fdo#111068] / [i915#658])
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb1/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][179] ([fdo#111068] / [i915#658]) -> [SKIP][180] ([i915#2920])
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-iclb4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@runner@aborted:
- shard-apl: ([FAIL][181], [FAIL][182], [FAIL][183], [FAIL][184], [FAIL][185], [FAIL][186], [FAIL][187]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][188], [FAIL][189], [FAIL][190], [FAIL][191], [FAIL][192], [FAIL][193], [FAIL][194]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257])
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-apl7/igt@runner@aborted.html
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-apl4/igt@runner@aborted.html
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-apl4/igt@runner@aborted.html
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-apl8/igt@runner@aborted.html
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-apl6/igt@runner@aborted.html
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-apl2/igt@runner@aborted.html
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11673/shard-apl1/igt@runner@aborted.html
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl1/igt@runner@aborted.html
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl4/igt@runner@aborted.html
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl8/igt@runner@aborted.html
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl1/igt@runner@aborted.html
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl6/igt@runner@aborted.html
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl4/igt@runner@aborted.html
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/shard-apl7/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2852]: https://gitlab.freedesktop.org/drm/intel/issues/2852
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3763]: https://gitlab.freedesktop.org/drm/intel/issues/3763
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4272]: https://gitlab.freedesktop.org/drm/intel/issues/4272
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4842]: https://gitlab.freedesktop.org/drm/intel/issues/4842
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4853]: https://gitlab.freedesktop.org/drm/intel/issues/4853
[i915#4855]: https://gitlab.freedesktop.org/drm/intel/issues/4855
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4911]: https://gitlab.freedesktop.org/drm/intel/issues/4911
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#5032]: https://gitlab.freedesktop.org/drm/intel/issues/5032
[i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5303]: https://gitlab.freedesktop.org/drm/intel/issues/5303
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5614]: https://gitlab.freedesktop.org/drm/intel/issues/5614
[i915#5691]: https://gitlab.freedesktop.org/drm/intel/issues/5691
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6029]: https://gitlab.freedesktop.org/drm/intel/issues/6029
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_11673 -> Patchwork_104122v1
CI-20190529: 20190529
CI_DRM_11673: 487728f8fae298d04767aa6cf8afea7a41b3e40b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6479: 78115aa8c8bcfc7784c7fc8dcaefcc2bce970b99 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_104122v1: 487728f8fae298d04767aa6cf8afea7a41b3e40b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104122v1/index.html
[-- Attachment #2: Type: text/html, Size: 50710 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant
2022-05-18 13:52 ` Jani Nikula
@ 2022-05-19 8:25 ` Jani Nikula
0 siblings, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2022-05-19 8:25 UTC (permalink / raw)
To: Ville Syrjälä
Cc: intel-gfx, Borislav Petkov, Randy Dunlap, Ruiqi GONG
On Wed, 18 May 2022, Jani Nikula <jani.nikula@intel.com> wrote:
> On Wed, 18 May 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>> On Wed, May 18, 2022 at 02:33:14PM +0300, Jani Nikula wrote:
>>> Use REG_GENMASK() and REG_FIELD_PREP() to avoid errors due to
>>> -fsanitize=shift.
>>
>> I presume it's just unhappy about shifting into the sign bit?
>
> Yeah, and apparently it also only happens on some GCC versions. *shrug*.
>
>>
>> Changes look correct:
>> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Thanks,
> Jani.
And pushed 1/2 to drm-intel-next.
BR,
Jani.
>
>>
>>>
>>> References: https://lore.kernel.org/r/20220405151517.29753-12-bp@alien8.de
>>> Reported-by: Borislav Petkov <bp@suse.de>
>>> Reported-by: Ruiqi GONG <gongruiqi1@huawei.com>
>>> Cc: Randy Dunlap <rdunlap@infradead.org>
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/i915_reg.h | 32 ++++++++++++++++----------------
>>> 1 file changed, 16 insertions(+), 16 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>>> index 321a08281a3f..dff3f88d8090 100644
>>> --- a/drivers/gpu/drm/i915/i915_reg.h
>>> +++ b/drivers/gpu/drm/i915/i915_reg.h
>>> @@ -7607,25 +7607,25 @@ enum skl_power_gate {
>>> #define _PORT_CLK_SEL_A 0x46100
>>> #define _PORT_CLK_SEL_B 0x46104
>>> #define PORT_CLK_SEL(port) _MMIO_PORT(port, _PORT_CLK_SEL_A, _PORT_CLK_SEL_B)
>>> -#define PORT_CLK_SEL_LCPLL_2700 (0 << 29)
>>> -#define PORT_CLK_SEL_LCPLL_1350 (1 << 29)
>>> -#define PORT_CLK_SEL_LCPLL_810 (2 << 29)
>>> -#define PORT_CLK_SEL_SPLL (3 << 29)
>>> -#define PORT_CLK_SEL_WRPLL(pll) (((pll) + 4) << 29)
>>> -#define PORT_CLK_SEL_WRPLL1 (4 << 29)
>>> -#define PORT_CLK_SEL_WRPLL2 (5 << 29)
>>> -#define PORT_CLK_SEL_NONE (7 << 29)
>>> -#define PORT_CLK_SEL_MASK (7 << 29)
>>> +#define PORT_CLK_SEL_MASK REG_GENMASK(31, 29)
>>> +#define PORT_CLK_SEL_LCPLL_2700 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 0)
>>> +#define PORT_CLK_SEL_LCPLL_1350 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 1)
>>> +#define PORT_CLK_SEL_LCPLL_810 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 2)
>>> +#define PORT_CLK_SEL_SPLL REG_FIELD_PREP(PORT_CLK_SEL_MASK, 3)
>>> +#define PORT_CLK_SEL_WRPLL(pll) REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4 + (pll))
>>> +#define PORT_CLK_SEL_WRPLL1 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 4)
>>> +#define PORT_CLK_SEL_WRPLL2 REG_FIELD_PREP(PORT_CLK_SEL_MASK, 5)
>>> +#define PORT_CLK_SEL_NONE REG_FIELD_PREP(PORT_CLK_SEL_MASK, 7)
>>>
>>> /* On ICL+ this is the same as PORT_CLK_SEL, but all bits change. */
>>> #define DDI_CLK_SEL(port) PORT_CLK_SEL(port)
>>> -#define DDI_CLK_SEL_NONE (0x0 << 28)
>>> -#define DDI_CLK_SEL_MG (0x8 << 28)
>>> -#define DDI_CLK_SEL_TBT_162 (0xC << 28)
>>> -#define DDI_CLK_SEL_TBT_270 (0xD << 28)
>>> -#define DDI_CLK_SEL_TBT_540 (0xE << 28)
>>> -#define DDI_CLK_SEL_TBT_810 (0xF << 28)
>>> -#define DDI_CLK_SEL_MASK (0xF << 28)
>>> +#define DDI_CLK_SEL_MASK REG_GENMASK(31, 28)
>>> +#define DDI_CLK_SEL_NONE REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x0)
>>> +#define DDI_CLK_SEL_MG REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0x8)
>>> +#define DDI_CLK_SEL_TBT_162 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xC)
>>> +#define DDI_CLK_SEL_TBT_270 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xD)
>>> +#define DDI_CLK_SEL_TBT_540 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xE)
>>> +#define DDI_CLK_SEL_TBT_810 REG_FIELD_PREP(DDI_CLK_SEL_MASK, 0xF)
>>>
>>> /* Transcoder clock selection */
>>> #define _TRANS_CLK_SEL_A 0x46140
>>> --
>>> 2.30.2
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/uc: Fix undefined behavior due to shift overflowing the constant
2022-05-18 14:15 ` Jani Nikula
@ 2022-05-19 8:38 ` Jani Nikula
0 siblings, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2022-05-19 8:38 UTC (permalink / raw)
To: Michal Wajdeczko, intel-gfx; +Cc: Randy Dunlap, Borislav Petkov, Ruiqi GONG
On Wed, 18 May 2022, Jani Nikula <jani.nikula@intel.com> wrote:
> On Wed, 18 May 2022, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
>> On 18.05.2022 13:33, Jani Nikula wrote:
>>> From: Borislav Petkov <bp@suse.de>
>>>
>>> Fix:
>>>
>>> In file included from <command-line>:0:0:
>>> drivers/gpu/drm/i915/gt/uc/intel_guc.c: In function ‘intel_guc_send_mmio’:
>>> ././include/linux/compiler_types.h:352:38: error: call to ‘__compiletime_assert_1047’ \
>>> declared with attribute error: FIELD_PREP: mask is not constant
>>> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>>>
>>> and other build errors due to shift overflowing values.
>>>
>>> See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
>>> details as to why it triggers with older gccs only.
>>>
>>> v2 by Jani:
>>> - Drop the i915_reg.h changes
>>>
>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>>> Cc: Ruiqi GONG <gongruiqi1@huawei.com>
>>> Cc: Randy Dunlap <rdunlap@infradead.org>
>>> Signed-off-by: Borislav Petkov <bp@suse.de>
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 2 +-
>>> drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h | 2 +-
>>> drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h | 2 +-
>>> drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h | 2 +-
>>> 4 files changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
>>> index be9ac47fa9d0..4ef9990ed7f8 100644
>>> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
>>> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
>>> @@ -50,7 +50,7 @@
>>>
>>> #define HOST2GUC_SELF_CFG_REQUEST_MSG_LEN (GUC_HXG_REQUEST_MSG_MIN_LEN + 3u)
>>> #define HOST2GUC_SELF_CFG_REQUEST_MSG_0_MBZ GUC_HXG_REQUEST_MSG_0_DATA0
>>> -#define HOST2GUC_SELF_CFG_REQUEST_MSG_1_KLV_KEY (0xffff << 16)
>>> +#define HOST2GUC_SELF_CFG_REQUEST_MSG_1_KLV_KEY (0xffffU << 16)
>>
>> nit: maybe for consistency we should update all these hex constants to
>> be explicitly marked as "unsigned" (as that was the intention) and also
>> maybe we should use lowercase "u" - but both that can be done later,
>
> For the guc reg stuff we should probably use REG_GENMASK() and
> REG_FIELD_PREP() instead, like I did for i915_reg.h. I just don't know
> about the plethora of other uc headers though...
>
>> Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>
> Thanks,
> Jani.
And pushed to drm-intel-gt-next.
BR,
Jani.
>
>>
>>> #define HOST2GUC_SELF_CFG_REQUEST_MSG_1_KLV_LEN (0xffff << 0)
>>> #define HOST2GUC_SELF_CFG_REQUEST_MSG_2_VALUE32 GUC_HXG_REQUEST_MSG_n_DATAn
>>> #define HOST2GUC_SELF_CFG_REQUEST_MSG_3_VALUE64 GUC_HXG_REQUEST_MSG_n_DATAn
>>> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
>>> index c9086a600bce..df83c1cc7c7a 100644
>>> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
>>> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
>>> @@ -82,7 +82,7 @@ static_assert(sizeof(struct guc_ct_buffer_desc) == 64);
>>> #define GUC_CTB_HDR_LEN 1u
>>> #define GUC_CTB_MSG_MIN_LEN GUC_CTB_HDR_LEN
>>> #define GUC_CTB_MSG_MAX_LEN 256u
>>> -#define GUC_CTB_MSG_0_FENCE (0xffff << 16)
>>> +#define GUC_CTB_MSG_0_FENCE (0xffffU << 16)
>>> #define GUC_CTB_MSG_0_FORMAT (0xf << 12)
>>> #define GUC_CTB_FORMAT_HXG 0u
>>> #define GUC_CTB_MSG_0_RESERVED (0xf << 8)
>>> diff --git a/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h b/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
>>> index 29ac823acd4c..7d5ba4d97d70 100644
>>> --- a/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
>>> +++ b/drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
>>> @@ -40,7 +40,7 @@
>>> */
>>>
>>> #define GUC_HXG_MSG_MIN_LEN 1u
>>> -#define GUC_HXG_MSG_0_ORIGIN (0x1 << 31)
>>> +#define GUC_HXG_MSG_0_ORIGIN (0x1U << 31)
>>> #define GUC_HXG_ORIGIN_HOST 0u
>>> #define GUC_HXG_ORIGIN_GUC 1u
>>> #define GUC_HXG_MSG_0_TYPE (0x7 << 28)
>>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h b/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h
>>> index 2516705b9f36..8dc063f087eb 100644
>>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h
>>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_reg.h
>>> @@ -28,7 +28,7 @@
>>> #define GS_MIA_HALT_REQUESTED (0x02 << GS_MIA_SHIFT)
>>> #define GS_MIA_ISR_ENTRY (0x04 << GS_MIA_SHIFT)
>>> #define GS_AUTH_STATUS_SHIFT 30
>>> -#define GS_AUTH_STATUS_MASK (0x03 << GS_AUTH_STATUS_SHIFT)
>>> +#define GS_AUTH_STATUS_MASK (0x03U << GS_AUTH_STATUS_SHIFT)
>>> #define GS_AUTH_STATUS_BAD (0x01 << GS_AUTH_STATUS_SHIFT)
>>> #define GS_AUTH_STATUS_GOOD (0x02 << GS_AUTH_STATUS_SHIFT)
>>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-05-19 8:38 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-18 11:33 [Intel-gfx] [PATCH 1/2] drm/i915/reg: fix undefined behavior due to shift overflowing the constant Jani Nikula
2022-05-18 11:33 ` [Intel-gfx] [PATCH 2/2] drm/i915/uc: Fix " Jani Nikula
2022-05-18 14:08 ` Michal Wajdeczko
2022-05-18 14:15 ` Jani Nikula
2022-05-19 8:38 ` Jani Nikula
2022-05-18 12:53 ` [Intel-gfx] [PATCH 1/2] drm/i915/reg: fix " Ville Syrjälä
2022-05-18 13:52 ` Jani Nikula
2022-05-19 8:25 ` Jani Nikula
2022-05-18 13:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] " Patchwork
2022-05-18 14:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-18 17:10 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.