* [V1,0/2] Enable hardware jpeg encoder for MT8186
@ 2022-05-19 8:16 ` kyrie.wu
0 siblings, 0 replies; 8+ messages in thread
From: kyrie.wu @ 2022-05-19 8:16 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, kyrie wu, srv_heupstream
From: kyrie wu <kyrie.wu@mediatek.com>
This series adds support for MT8186 hardware jpeg encoding.
This series has been tested with both MT8186.
Encoding worked for this chip.
Patches 1 Adds jpeg encoder dt-bindings for mt8186
Patches 2 set bit mask for jpegenc.
kyrie wu (2):
media: media: jpegenc: add mediatek,mt8186-jpgenc compatible
media: media: jpegenc: set bit mask for jpegenc
.../devicetree/bindings/media/mediatek-jpeg-encoder.yaml | 1 +
drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 3 +++
2 files changed, 4 insertions(+)
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [V1, 1/2] media: media: jpegenc: add mediatek, mt8186-jpgenc compatible
2022-05-19 8:16 ` kyrie.wu
@ 2022-05-19 8:16 ` kyrie.wu
-1 siblings, 0 replies; 8+ messages in thread
From: kyrie.wu @ 2022-05-19 8:16 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, kyrie wu, srv_heupstream
From: kyrie wu <kyrie.wu@mediatek.com>
Add mediatek,mt8186-jpgenc compatible to binding document.
Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
---
.../devicetree/bindings/media/mediatek-jpeg-encoder.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
index 8bfdfdfaba59..a696bfde785d 100644
--- a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
@@ -18,6 +18,7 @@ properties:
- enum:
- mediatek,mt2701-jpgenc
- mediatek,mt8183-jpgenc
+ - mediatek,mt8186-jpgenc
- const: mediatek,mtk-jpgenc
reg:
maxItems: 1
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 8+ messages in thread* [V1, 1/2] media: media: jpegenc: add mediatek, mt8186-jpgenc compatible
@ 2022-05-19 8:16 ` kyrie.wu
0 siblings, 0 replies; 8+ messages in thread
From: kyrie.wu @ 2022-05-19 8:16 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, kyrie wu, srv_heupstream
From: kyrie wu <kyrie.wu@mediatek.com>
Add mediatek,mt8186-jpgenc compatible to binding document.
Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
---
.../devicetree/bindings/media/mediatek-jpeg-encoder.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
index 8bfdfdfaba59..a696bfde785d 100644
--- a/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.yaml
@@ -18,6 +18,7 @@ properties:
- enum:
- mediatek,mt2701-jpgenc
- mediatek,mt8183-jpgenc
+ - mediatek,mt8186-jpgenc
- const: mediatek,mtk-jpgenc
reg:
maxItems: 1
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [V1,2/2] media: media: jpegenc: set bit mask for jpegenc
2022-05-19 8:16 ` kyrie.wu
@ 2022-05-19 8:16 ` kyrie.wu
-1 siblings, 0 replies; 8+ messages in thread
From: kyrie.wu @ 2022-05-19 8:16 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, kyrie wu, srv_heupstream
From: kyrie wu <kyrie.wu@mediatek.com>
set bit mask for jpeg encode
Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
---
drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
index bc5b0a0168ec..87685a62a5c2 100644
--- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
@@ -1369,6 +1369,9 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
jpeg->vdev->device_caps = V4L2_CAP_STREAMING |
V4L2_CAP_VIDEO_M2M_MPLANE;
+ if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL))
+ dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34));
+
ret = video_register_device(jpeg->vdev, VFL_TYPE_VIDEO, -1);
if (ret) {
v4l2_err(&jpeg->v4l2_dev, "Failed to register video device\n");
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 8+ messages in thread* [V1,2/2] media: media: jpegenc: set bit mask for jpegenc
@ 2022-05-19 8:16 ` kyrie.wu
0 siblings, 0 replies; 8+ messages in thread
From: kyrie.wu @ 2022-05-19 8:16 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, kyrie wu, srv_heupstream
From: kyrie wu <kyrie.wu@mediatek.com>
set bit mask for jpeg encode
Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
---
drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
index bc5b0a0168ec..87685a62a5c2 100644
--- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
@@ -1369,6 +1369,9 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
jpeg->vdev->device_caps = V4L2_CAP_STREAMING |
V4L2_CAP_VIDEO_M2M_MPLANE;
+ if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL))
+ dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34));
+
ret = video_register_device(jpeg->vdev, VFL_TYPE_VIDEO, -1);
if (ret) {
v4l2_err(&jpeg->v4l2_dev, "Failed to register video device\n");
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [V1,2/2] media: media: jpegenc: set bit mask for jpegenc
2022-05-19 8:16 ` kyrie.wu
@ 2022-05-19 8:43 ` Rex-BC Chen
-1 siblings, 0 replies; 8+ messages in thread
From: Rex-BC Chen @ 2022-05-19 8:43 UTC (permalink / raw)
To: kyrie.wu, Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
On Thu, 2022-05-19 at 16:16 +0800, kyrie.wu wrote:
> From: kyrie wu <kyrie.wu@mediatek.com>
>
> set bit mask for jpeg encode
>
> Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> ---
> drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> index bc5b0a0168ec..87685a62a5c2 100644
> --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> @@ -1369,6 +1369,9 @@ static int mtk_jpeg_probe(struct
> platform_device *pdev)
> jpeg->vdev->device_caps = V4L2_CAP_STREAMING |
> V4L2_CAP_VIDEO_M2M_MPLANE;
>
> + if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL))
> + dma_set_mask_and_coherent(&pdev->dev,
> DMA_BIT_MASK(34));
> +
> ret = video_register_device(jpeg->vdev, VFL_TYPE_VIDEO, -1);
> if (ret) {
> v4l2_err(&jpeg->v4l2_dev, "Failed to register video
> device\n");
Hello Kyrie,
if you want to add this property in dts, you need to add a new property
description to descript this.
BRs,
Rex
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [V1,2/2] media: media: jpegenc: set bit mask for jpegenc
@ 2022-05-19 8:43 ` Rex-BC Chen
0 siblings, 0 replies; 8+ messages in thread
From: Rex-BC Chen @ 2022-05-19 8:43 UTC (permalink / raw)
To: kyrie.wu, Hans Verkuil, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tzung-Bi Shih
Cc: Project_Global_Chrome_Upstream_Group, linux-media, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Tomasz Figa,
xia.jiang, maoguang.meng, srv_heupstream
On Thu, 2022-05-19 at 16:16 +0800, kyrie.wu wrote:
> From: kyrie wu <kyrie.wu@mediatek.com>
>
> set bit mask for jpeg encode
>
> Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> ---
> drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> index bc5b0a0168ec..87685a62a5c2 100644
> --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
> @@ -1369,6 +1369,9 @@ static int mtk_jpeg_probe(struct
> platform_device *pdev)
> jpeg->vdev->device_caps = V4L2_CAP_STREAMING |
> V4L2_CAP_VIDEO_M2M_MPLANE;
>
> + if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL))
> + dma_set_mask_and_coherent(&pdev->dev,
> DMA_BIT_MASK(34));
> +
> ret = video_register_device(jpeg->vdev, VFL_TYPE_VIDEO, -1);
> if (ret) {
> v4l2_err(&jpeg->v4l2_dev, "Failed to register video
> device\n");
Hello Kyrie,
if you want to add this property in dts, you need to add a new property
description to descript this.
BRs,
Rex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread