[PATCH] ASoC: rt1308-sdw: add the default value of register 0xc320

[PATCH] ASoC: rt1308-sdw: add the default value of register 0xc320

[shumingf]

From: Shuming Fan <shumingf@realtek.com>

The driver missed the default value of register 0xc320.
This patch adds that default value to avoid the error messages
when the driver went to suspend mode already.

BugLink: https://github.com/thesofproject/linux/issues/3651
Signed-off-by: Shuming Fan <shumingf@realtek.com>
---
 sound/soc/codecs/rt1308-sdw.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/rt1308-sdw.h b/sound/soc/codecs/rt1308-sdw.h
index c5ce75666dcc..6668e19d85d4 100644
--- a/sound/soc/codecs/rt1308-sdw.h
+++ b/sound/soc/codecs/rt1308-sdw.h
@@ -140,6 +140,7 @@ static const struct reg_default rt1308_reg_defaults[] = {
 	{ 0x3008, 0x02 },
 	{ 0x300a, 0x00 },
 	{ 0xc003 | (RT1308_DAC_SET << 4), 0x00 },
+	{ 0xc000 | (RT1308_POWER << 4), 0x00 },
 	{ 0xc001 | (RT1308_POWER << 4), 0x00 },
 	{ 0xc002 | (RT1308_POWER << 4), 0x00 },
 };
-- 
2.35.3

Re: [PATCH] ASoC: rt1308-sdw: add the default value of register 0xc320

[Pierre-Louis Bossart]

On 5/20/22 04:02, shumingf@realtek.com wrote:
> From: Shuming Fan <shumingf@realtek.com>
> 
> The driver missed the default value of register 0xc320.
> This patch adds that default value to avoid the error messages
> when the driver went to suspend mode already.
> 
> BugLink: https://github.com/thesofproject/linux/issues/3651
> Signed-off-by: Shuming Fan <shumingf@realtek.com>

Tested-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> ---
>  sound/soc/codecs/rt1308-sdw.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/codecs/rt1308-sdw.h b/sound/soc/codecs/rt1308-sdw.h
> index c5ce75666dcc..6668e19d85d4 100644
> --- a/sound/soc/codecs/rt1308-sdw.h
> +++ b/sound/soc/codecs/rt1308-sdw.h
> @@ -140,6 +140,7 @@ static const struct reg_default rt1308_reg_defaults[] = {
>  	{ 0x3008, 0x02 },
>  	{ 0x300a, 0x00 },
>  	{ 0xc003 | (RT1308_DAC_SET << 4), 0x00 },
> +	{ 0xc000 | (RT1308_POWER << 4), 0x00 },
>  	{ 0xc001 | (RT1308_POWER << 4), 0x00 },
>  	{ 0xc002 | (RT1308_POWER << 4), 0x00 },
>  };

Re: [PATCH] ASoC: rt1308-sdw: add the default value of register 0xc320

[Mark Brown]

On Fri, 20 May 2022 17:02:05 +0800, shumingf@realtek.com wrote:
> From: Shuming Fan <shumingf@realtek.com>
> 
> The driver missed the default value of register 0xc320.
> This patch adds that default value to avoid the error messages
> when the driver went to suspend mode already.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rt1308-sdw: add the default value of register 0xc320
      commit: affa9983e7cbac8cbe2596975efacdbdf0eb18e9

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark