All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] powerpc/book3e: Fix build error
@ 2022-05-17  9:48 ` YueHaibing
  0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2022-05-17  9:48 UTC (permalink / raw)
  To: mpe, benh, paulus, christophe.leroy
  Cc: linuxppc-dev, linux-kernel, YueHaibing

arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
  early_get_first_memblock_info(__va(dt_ptr), &size);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Add missing include file linux/of_fdt.h to fix this.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 arch/powerpc/mm/nohash/fsl_book3e.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/mm/nohash/fsl_book3e.c b/arch/powerpc/mm/nohash/fsl_book3e.c
index 08a984e29433..093da4dbdee1 100644
--- a/arch/powerpc/mm/nohash/fsl_book3e.c
+++ b/arch/powerpc/mm/nohash/fsl_book3e.c
@@ -36,6 +36,7 @@
 #include <linux/delay.h>
 #include <linux/highmem.h>
 #include <linux/memblock.h>
+#include <linux/of_fdt.h>
 
 #include <asm/io.h>
 #include <asm/mmu_context.h>
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH -next] powerpc/book3e: Fix build error
@ 2022-05-17  9:48 ` YueHaibing
  0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2022-05-17  9:48 UTC (permalink / raw)
  To: mpe, benh, paulus, christophe.leroy
  Cc: YueHaibing, linuxppc-dev, linux-kernel

arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
  early_get_first_memblock_info(__va(dt_ptr), &size);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Add missing include file linux/of_fdt.h to fix this.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 arch/powerpc/mm/nohash/fsl_book3e.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/mm/nohash/fsl_book3e.c b/arch/powerpc/mm/nohash/fsl_book3e.c
index 08a984e29433..093da4dbdee1 100644
--- a/arch/powerpc/mm/nohash/fsl_book3e.c
+++ b/arch/powerpc/mm/nohash/fsl_book3e.c
@@ -36,6 +36,7 @@
 #include <linux/delay.h>
 #include <linux/highmem.h>
 #include <linux/memblock.h>
+#include <linux/of_fdt.h>
 
 #include <asm/io.h>
 #include <asm/mmu_context.h>
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] powerpc/book3e: Fix build error
  2022-05-17  9:48 ` YueHaibing
  (?)
@ 2022-05-17 10:45 ` Christophe Leroy
  2022-05-17 11:31   ` YueHaibing
  -1 siblings, 1 reply; 6+ messages in thread
From: Christophe Leroy @ 2022-05-17 10:45 UTC (permalink / raw)
  To: YueHaibing, mpe, benh, paulus; +Cc: linuxppc-dev, linux-kernel



Le 17/05/2022 à 11:48, YueHaibing a écrit :
> arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
> arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
>    early_get_first_memblock_info(__va(dt_ptr), &size);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Add missing include file linux/of_fdt.h to fix this.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Thats for fixing that.

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

It means we don't have any defconfig for 32 bits booke with 
CONFIG_RELOCATABLE ?

> ---
>   arch/powerpc/mm/nohash/fsl_book3e.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/mm/nohash/fsl_book3e.c b/arch/powerpc/mm/nohash/fsl_book3e.c
> index 08a984e29433..093da4dbdee1 100644
> --- a/arch/powerpc/mm/nohash/fsl_book3e.c
> +++ b/arch/powerpc/mm/nohash/fsl_book3e.c
> @@ -36,6 +36,7 @@
>   #include <linux/delay.h>
>   #include <linux/highmem.h>
>   #include <linux/memblock.h>
> +#include <linux/of_fdt.h>
>   
>   #include <asm/io.h>
>   #include <asm/mmu_context.h>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] powerpc/book3e: Fix build error
  2022-05-17 10:45 ` Christophe Leroy
@ 2022-05-17 11:31   ` YueHaibing
  2022-05-18  4:50     ` Michael Ellerman
  0 siblings, 1 reply; 6+ messages in thread
From: YueHaibing @ 2022-05-17 11:31 UTC (permalink / raw)
  To: Christophe Leroy, mpe, benh, paulus; +Cc: linuxppc-dev, linux-kernel

On 2022/5/17 18:45, Christophe Leroy wrote:
> 
> 
> Le 17/05/2022 à 11:48, YueHaibing a écrit :
>> arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
>> arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
>>    early_get_first_memblock_info(__va(dt_ptr), &size);
>>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Add missing include file linux/of_fdt.h to fix this.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> 
> Thats for fixing that.
> 
> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> 
> It means we don't have any defconfig for 32 bits booke with 
> CONFIG_RELOCATABLE ?

Indeed, there is no defconfig with CONFIG_RELOCATABLE under arch/powerpc/configs
> 
>> ---
>>   arch/powerpc/mm/nohash/fsl_book3e.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/mm/nohash/fsl_book3e.c b/arch/powerpc/mm/nohash/fsl_book3e.c
>> index 08a984e29433..093da4dbdee1 100644
>> --- a/arch/powerpc/mm/nohash/fsl_book3e.c
>> +++ b/arch/powerpc/mm/nohash/fsl_book3e.c
>> @@ -36,6 +36,7 @@
>>   #include <linux/delay.h>
>>   #include <linux/highmem.h>
>>   #include <linux/memblock.h>
>> +#include <linux/of_fdt.h>
>>   
>>   #include <asm/io.h>
>>   #include <asm/mmu_context.h>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] powerpc/book3e: Fix build error
  2022-05-17 11:31   ` YueHaibing
@ 2022-05-18  4:50     ` Michael Ellerman
  0 siblings, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2022-05-18  4:50 UTC (permalink / raw)
  To: YueHaibing, Christophe Leroy, benh, paulus; +Cc: linuxppc-dev, linux-kernel

YueHaibing <yuehaibing@huawei.com> writes:
> On 2022/5/17 18:45, Christophe Leroy wrote:
>> Le 17/05/2022 à 11:48, YueHaibing a écrit :
>>> arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
>>> arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
>>>    early_get_first_memblock_info(__va(dt_ptr), &size);
>>>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> Add missing include file linux/of_fdt.h to fix this.
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> 
>> Thats for fixing that.
>> 
>> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>> 
>> It means we don't have any defconfig for 32 bits booke with 
>> CONFIG_RELOCATABLE ?
>
> Indeed, there is no defconfig with CONFIG_RELOCATABLE under arch/powerpc/configs

It's selected by CRASH_DUMP, which is in ppc64_defconfig.

But it's not enabled in corenet32_smp_defconfig which is what I build,
or any of the other 85xx configs.

I guess it should be, I think it's true that RELOCATABLE=y exercises
more interesting code paths?

cheers

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] powerpc/book3e: Fix build error
  2022-05-17  9:48 ` YueHaibing
  (?)
  (?)
@ 2022-05-24 11:09 ` Michael Ellerman
  -1 siblings, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2022-05-24 11:09 UTC (permalink / raw)
  To: paulus, benh, YueHaibing, christophe.leroy, mpe
  Cc: linuxppc-dev, linux-kernel

On Tue, 17 May 2022 17:48:30 +0800, YueHaibing wrote:
> arch/powerpc/mm/nohash/fsl_book3e.c: In function ‘relocate_init’:
> arch/powerpc/mm/nohash/fsl_book3e.c:348:2: error: implicit declaration of function ‘early_get_first_memblock_info’ [-Werror=implicit-function-declaration]
>   early_get_first_memblock_info(__va(dt_ptr), &size);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Add missing include file linux/of_fdt.h to fix this.
> 
> [...]

Applied to powerpc/next.

[1/1] powerpc/book3e: Fix build error
      https://git.kernel.org/powerpc/c/7574dd080ee0a1e8a9c6312dc7c8fe97f73415ff

cheers

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-24 11:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-17  9:48 [PATCH -next] powerpc/book3e: Fix build error YueHaibing
2022-05-17  9:48 ` YueHaibing
2022-05-17 10:45 ` Christophe Leroy
2022-05-17 11:31   ` YueHaibing
2022-05-18  4:50     ` Michael Ellerman
2022-05-24 11:09 ` Michael Ellerman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.