All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
	Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Subject: Re: [PATCH] ath11k: Avoid REO CMD failed prints during firmware recovery
Date: Mon,  6 Jun 2022 14:09:32 +0000 (UTC)	[thread overview]
Message-ID: <165452456971.15301.3255857087699251778.kvalo@kernel.org> (raw)
In-Reply-To: <20220602122929.18896-1-quic_mpubbise@quicinc.com>

Manikanta Pubbisetty <quic_mpubbise@quicinc.com> wrote:

> Currently when firmware recovery is in progress, we do not queue REO
> commands to the firmware, instead -ESHUTDOWN will be returned to the
> caller leading to a failure print on the console. The REO command in
> the problem scenario is sent for all tids of a peer in which case we
> will have 16 failure prints on the console for a single peer. For an
> AP usecase, this count would be even higher in a worst case scenario.
> Since these commands are bound to fail during firmware recovery, it
> is better to avoid printing these failures and thereby avoid message
> flooding on the console.
> 
> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
> 
> Fixes: 8ee8d38ca472 ("ath11k: Fix crash during firmware recovery on reo cmd ring access")
> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

0ab52b2bd7be ath11k: Avoid REO CMD failed prints during firmware recovery

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220602122929.18896-1-quic_mpubbise@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
	Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Subject: Re: [PATCH] ath11k: Avoid REO CMD failed prints during firmware recovery
Date: Mon,  6 Jun 2022 14:09:32 +0000 (UTC)	[thread overview]
Message-ID: <165452456971.15301.3255857087699251778.kvalo@kernel.org> (raw)
In-Reply-To: <20220602122929.18896-1-quic_mpubbise@quicinc.com>

Manikanta Pubbisetty <quic_mpubbise@quicinc.com> wrote:

> Currently when firmware recovery is in progress, we do not queue REO
> commands to the firmware, instead -ESHUTDOWN will be returned to the
> caller leading to a failure print on the console. The REO command in
> the problem scenario is sent for all tids of a peer in which case we
> will have 16 failure prints on the console for a single peer. For an
> AP usecase, this count would be even higher in a worst case scenario.
> Since these commands are bound to fail during firmware recovery, it
> is better to avoid printing these failures and thereby avoid message
> flooding on the console.
> 
> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
> 
> Fixes: 8ee8d38ca472 ("ath11k: Fix crash during firmware recovery on reo cmd ring access")
> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

0ab52b2bd7be ath11k: Avoid REO CMD failed prints during firmware recovery

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220602122929.18896-1-quic_mpubbise@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2022-06-06 14:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02 12:29 [PATCH] ath11k: Avoid REO CMD failed prints during firmware recovery Manikanta Pubbisetty
2022-06-02 12:29 ` Manikanta Pubbisetty
2022-06-06 14:09 ` Kalle Valo [this message]
2022-06-06 14:09   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165452456971.15301.3255857087699251778.kvalo@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_mpubbise@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.