All of lore.kernel.org
 help / color / mirror / Atom feed
From: Satya Priya <quic_c_skakit@quicinc.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<swboyd@chromium.org>, <quic_collinsd@quicinc.com>,
	<quic_subbaram@quicinc.com>, <quic_jprakash@quicinc.com>,
	Satya Priya <quic_c_skakit@quicinc.com>
Subject: [PATCH V15 2/9] dt-bindings: mfd: pm8008: Change the address cells
Date: Tue, 14 Jun 2022 15:18:24 +0530	[thread overview]
Message-ID: <1655200111-18357-3-git-send-email-quic_c_skakit@quicinc.com> (raw)
In-Reply-To: <1655200111-18357-1-git-send-email-quic_c_skakit@quicinc.com>

Change the address cells as '2' so that the first cell
describes the i2c address offset of the clients.
This helps us to define the child nodes of all
clients under the same parent mfd node, instead of
adding separate mfd DT nodes.

Change the gpios reg value accordingly.

Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Changes in V15:
 - None.

Changes in V14:
 - None.

Changes in V13:
 - Fixed nit.

 Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
index a89649c..a54d1ce0 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
@@ -39,7 +39,7 @@ properties:
   interrupt-controller: true
 
   "#address-cells":
-    const: 1
+    const: 2
 
   "#size-cells":
     const: 0
@@ -48,7 +48,7 @@ properties:
     maxItems: 1
 
 patternProperties:
-  "^gpio@[0-9a-f]+$":
+  "^gpio@0,[0-9a-f]+$":
     type: object
 
     description: |
@@ -61,7 +61,7 @@ patternProperties:
           - const: qcom,spmi-gpio
 
       reg:
-        description: Peripheral address of one of the two GPIO peripherals.
+        description: Peripheral offset and address of one of the two GPIO peripherals.
         maxItems: 1
 
       gpio-controller: true
@@ -110,7 +110,7 @@ examples:
       pm8008i@8 {
         compatible = "qcom,pm8008";
         reg = <0x8>;
-        #address-cells = <1>;
+        #address-cells = <2>;
         #size-cells = <0>;
         interrupt-controller;
         #interrupt-cells = <2>;
@@ -120,9 +120,9 @@ examples:
 
         reset-gpios = <&pm8350c_gpios 4 GPIO_ACTIVE_LOW>;
 
-        pm8008_gpios: gpio@c000 {
+        pm8008_gpios: gpio@0,c000 {
           compatible = "qcom,pm8008-gpio", "qcom,spmi-gpio";
-          reg = <0xc000>;
+          reg = <0x0 0xc000>;
           gpio-controller;
           gpio-ranges = <&pm8008_gpios 0 0 2>;
           #gpio-cells = <2>;
-- 
2.7.4


  parent reply	other threads:[~2022-06-14  9:49 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  9:48 [PATCH V15 0/9] Add Qualcomm Technologies, Inc. PM8008 regulator driver Satya Priya
2022-06-14  9:48 ` [PATCH V15 1/9] dt-bindings: mfd: pm8008: Add reset-gpios Satya Priya
2022-06-16 20:58   ` Lee Jones
2022-06-14  9:48 ` Satya Priya [this message]
2022-06-16 20:59   ` [PATCH V15 2/9] dt-bindings: mfd: pm8008: Change the address cells Lee Jones
2022-06-17 16:34     ` Lee Jones
2022-06-14  9:48 ` [PATCH V15 3/9] dt-bindings: mfd: pm8008: Add regulators for pm8008 Satya Priya
2022-06-16 20:58   ` Lee Jones
2022-06-14  9:48 ` [PATCH V15 4/9] mfd: pm8008: Add reset-gpios Satya Priya
2022-06-16 20:58   ` Lee Jones
2022-06-17 16:34     ` Lee Jones
2022-06-29 18:36   ` Guru Das Srinagesh
2022-06-14  9:48 ` [PATCH V15 5/9] mfd: pm8008: Remove the regmap member from pm8008_data struct Satya Priya
2022-06-16 20:58   ` Lee Jones
2022-06-29 18:35   ` Guru Das Srinagesh
2022-06-14  9:48 ` [PATCH V15 6/9] mfd: pm8008: Use i2c_new_dummy_device() API Satya Priya
2022-06-16 20:57   ` Lee Jones
2022-06-20  5:28     ` Satya Priya Kakitapalli (Temp)
2022-06-20  8:20       ` Lee Jones
2022-06-20 11:07         ` Satya Priya Kakitapalli (Temp)
2022-06-27  5:07           ` Satya Priya Kakitapalli (Temp)
2022-06-27  7:41             ` Lee Jones
2022-06-28  4:53               ` Satya Priya Kakitapalli (Temp)
2022-06-28  7:42                 ` Lee Jones
2022-06-29 10:36                   ` Satya Priya Kakitapalli (Temp)
2022-06-29 15:18                     ` Lee Jones
2022-06-30  9:37                       ` Satya Priya Kakitapalli (Temp)
2022-06-30 10:34                         ` Lee Jones
2022-07-01  6:46                           ` Satya Priya Kakitapalli (Temp)
2022-07-01  7:54                             ` Lee Jones
2022-07-01  8:47                               ` Satya Priya Kakitapalli (Temp)
2022-07-01  9:12                                 ` Lee Jones
     [not found]                                   ` <0481d3cc-4bb9-4969-0232-76ba57ff260d@quicinc.com>
2022-07-04 12:49                                     ` Lee Jones
2022-07-04 12:59                                       ` Satya Priya Kakitapalli (Temp)
2022-07-11 10:31                                       ` Satya Priya Kakitapalli (Temp)
2022-07-12 12:47                                         ` Lee Jones
2022-07-13  5:50                                           ` Satya Priya Kakitapalli (Temp)
2022-07-13 13:14                                             ` Mark Brown
2022-07-22  6:31                                           ` Satya Priya Kakitapalli (Temp)
2022-07-27  1:19                                             ` Stephen Boyd
     [not found]                                               ` <52039cd1-4390-7abb-d296-0eb7ac0c3b15@quicinc.com>
2022-08-05 10:51                                                 ` Lee Jones
2022-08-08 19:09                                                   ` Stephen Boyd
2022-08-16  3:41                                                     ` Satya Priya Kakitapalli (Temp)
2022-09-28 10:20                                                     ` Lee Jones
2022-09-29  1:20                                                       ` Stephen Boyd
2022-09-29 18:01                                                         ` Lee Jones
2022-10-03 18:47                                                           ` Stephen Boyd
2022-10-04 11:41                                                             ` Lee Jones
2022-06-14  9:48 ` [PATCH V15 7/9] regulator: Add a regulator driver for the PM8008 PMIC Satya Priya
2022-06-14 20:36   ` Stephen Boyd
2022-06-14  9:48 ` [PATCH V15 8/9] arm64: dts: qcom: pm8008: Add base dts file Satya Priya
2022-06-14  9:48 ` [PATCH V15 9/9] arm64: dts: qcom: sc7280: Add pm8008 support for sc7280-idp Satya Priya
2023-03-17  8:06 ` [PATCH V15 0/9] Add Qualcomm Technologies, Inc. PM8008 regulator driver Luca Weiss
2023-07-07  8:54   ` Luca Weiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1655200111-18357-3-git-send-email-quic_c_skakit@quicinc.com \
    --to=quic_c_skakit@quicinc.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_collinsd@quicinc.com \
    --cc=quic_jprakash@quicinc.com \
    --cc=quic_subbaram@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.