From: "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@quicinc.com>
To: Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
Stephen Boyd <swboyd@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_collinsd@quicinc.com>,
<quic_subbaram@quicinc.com>, <quic_jprakash@quicinc.com>
Subject: Re: [PATCH V15 6/9] mfd: pm8008: Use i2c_new_dummy_device() API
Date: Fri, 22 Jul 2022 12:01:16 +0530 [thread overview]
Message-ID: <dc737abb-041b-491a-14f1-a584f9e64a3d@quicinc.com> (raw)
In-Reply-To: <Ys1tYAO39LKzEAOE@google.com>
Hi Lee,
> Okay, so I've taken some time to read through your previous
> submissions to see how we ended up down this rabbit hole.
>
> Essentially, it looks to me like the 2 I2C devices should be kept
> separate and the Regulator driver should be registered/probed without
> requiring this I2C dummy device hoop jumping exercise.
>
> As Stephen asked in v9 [0], why can't the regulator driver be I2C?
>
> Then it can manage its own resources and all of this craziness can be
> avoided.
>
> That's not to say that the v9 submission was the right way to go
> either. Everything in relation to:
>
> i2c_add_driver(&pm8008_regulators_driver);
>
> ... should be moved into the Regulator driver itself.
So, IIUC, we need to register the regulator driver as an i2c_driver and
do all the regmap init stuff in its probe, and not touch the mfd
driver(apart from adding reset-gpios).
Then the DT would be simply:
&pm8008_bus {
pm8008: pm8008@8 {
compatible = "qcom,pm8008";
reg = <0x8>;
#address-cells = <1>;
#size-cells = <0>;
#interrupt-cells = <2>;
};
pm8008_regulators: pm8008@9 {
compatible = "qcom,pm8008-regulators";
reg = <0x9>;
#address-cells = <0>;
#size-cells = <0>;
pm8008_l1: ldo1@4000 {
reg = <0x4000>;
regulator-name = "pm8008_l1";
};
pm8008_l2: ldo2@4100 {
reg = <0x4100>;
regulator-name = "pm8008_l2";
};
pm8008_l3: ldo3@4200 {
reg = <0x4200>;
regulator-name = "pm8008_l3";
};
pm8008_l4: ldo4@4300 {
reg = <0x4300>;
regulator-name = "pm8008_l4";
};
pm8008_l5: ldo5@4400 {
reg = <0x4400>;
regulator-name = "pm8008_l5";
};
pm8008_l6: ldo6@4500 {
reg = <0x4500>;
regulator-name = "pm8008_l6";
};
pm8008_l7: ldo7@4600 {
reg = <0x4600>;
regulator-name = "pm8008_l7";
};
};
};
Stephen/Mark, Please do let me know if you are OK with this design.
next prev parent reply other threads:[~2022-07-22 6:31 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 9:48 [PATCH V15 0/9] Add Qualcomm Technologies, Inc. PM8008 regulator driver Satya Priya
2022-06-14 9:48 ` [PATCH V15 1/9] dt-bindings: mfd: pm8008: Add reset-gpios Satya Priya
2022-06-16 20:58 ` Lee Jones
2022-06-14 9:48 ` [PATCH V15 2/9] dt-bindings: mfd: pm8008: Change the address cells Satya Priya
2022-06-16 20:59 ` Lee Jones
2022-06-17 16:34 ` Lee Jones
2022-06-14 9:48 ` [PATCH V15 3/9] dt-bindings: mfd: pm8008: Add regulators for pm8008 Satya Priya
2022-06-16 20:58 ` Lee Jones
2022-06-14 9:48 ` [PATCH V15 4/9] mfd: pm8008: Add reset-gpios Satya Priya
2022-06-16 20:58 ` Lee Jones
2022-06-17 16:34 ` Lee Jones
2022-06-29 18:36 ` Guru Das Srinagesh
2022-06-14 9:48 ` [PATCH V15 5/9] mfd: pm8008: Remove the regmap member from pm8008_data struct Satya Priya
2022-06-16 20:58 ` Lee Jones
2022-06-29 18:35 ` Guru Das Srinagesh
2022-06-14 9:48 ` [PATCH V15 6/9] mfd: pm8008: Use i2c_new_dummy_device() API Satya Priya
2022-06-16 20:57 ` Lee Jones
2022-06-20 5:28 ` Satya Priya Kakitapalli (Temp)
2022-06-20 8:20 ` Lee Jones
2022-06-20 11:07 ` Satya Priya Kakitapalli (Temp)
2022-06-27 5:07 ` Satya Priya Kakitapalli (Temp)
2022-06-27 7:41 ` Lee Jones
2022-06-28 4:53 ` Satya Priya Kakitapalli (Temp)
2022-06-28 7:42 ` Lee Jones
2022-06-29 10:36 ` Satya Priya Kakitapalli (Temp)
2022-06-29 15:18 ` Lee Jones
2022-06-30 9:37 ` Satya Priya Kakitapalli (Temp)
2022-06-30 10:34 ` Lee Jones
2022-07-01 6:46 ` Satya Priya Kakitapalli (Temp)
2022-07-01 7:54 ` Lee Jones
2022-07-01 8:47 ` Satya Priya Kakitapalli (Temp)
2022-07-01 9:12 ` Lee Jones
[not found] ` <0481d3cc-4bb9-4969-0232-76ba57ff260d@quicinc.com>
2022-07-04 12:49 ` Lee Jones
2022-07-04 12:59 ` Satya Priya Kakitapalli (Temp)
2022-07-11 10:31 ` Satya Priya Kakitapalli (Temp)
2022-07-12 12:47 ` Lee Jones
2022-07-13 5:50 ` Satya Priya Kakitapalli (Temp)
2022-07-13 13:14 ` Mark Brown
2022-07-22 6:31 ` Satya Priya Kakitapalli (Temp) [this message]
2022-07-27 1:19 ` Stephen Boyd
[not found] ` <52039cd1-4390-7abb-d296-0eb7ac0c3b15@quicinc.com>
2022-08-05 10:51 ` Lee Jones
2022-08-08 19:09 ` Stephen Boyd
2022-08-16 3:41 ` Satya Priya Kakitapalli (Temp)
2022-09-28 10:20 ` Lee Jones
2022-09-29 1:20 ` Stephen Boyd
2022-09-29 18:01 ` Lee Jones
2022-10-03 18:47 ` Stephen Boyd
2022-10-04 11:41 ` Lee Jones
2022-06-14 9:48 ` [PATCH V15 7/9] regulator: Add a regulator driver for the PM8008 PMIC Satya Priya
2022-06-14 20:36 ` Stephen Boyd
2022-06-14 9:48 ` [PATCH V15 8/9] arm64: dts: qcom: pm8008: Add base dts file Satya Priya
2022-06-14 9:48 ` [PATCH V15 9/9] arm64: dts: qcom: sc7280: Add pm8008 support for sc7280-idp Satya Priya
2023-03-17 8:06 ` [PATCH V15 0/9] Add Qualcomm Technologies, Inc. PM8008 regulator driver Luca Weiss
2023-07-07 8:54 ` Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc737abb-041b-491a-14f1-a584f9e64a3d@quicinc.com \
--to=quic_c_skakit@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_collinsd@quicinc.com \
--cc=quic_jprakash@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.