* [PATCH][ACPI-next] ACPI: battery: make function __battery_hook_unregister static
@ 2018-02-23 16:32 Colin King
2018-03-14 11:44 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2018-02-23 16:32 UTC (permalink / raw)
To: Rafael J . Wysock, Len Brown, linux-acpi; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function __battery_hook_unregister is local to the source and does
not need to be in global scope, so make it static.
Cleans up sparse warning:
drivers/acpi/battery.c:654:6: warning: symbol '__battery_hook_unregister'
was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/acpi/battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
index cfdef4c1d097..b4580b2e8706 100644
--- a/drivers/acpi/battery.c
+++ b/drivers/acpi/battery.c
@@ -651,7 +651,7 @@ static LIST_HEAD(acpi_battery_list);
static LIST_HEAD(battery_hook_list);
static DEFINE_MUTEX(hook_mutex);
-void __battery_hook_unregister(struct acpi_battery_hook *hook, int lock)
+static void __battery_hook_unregister(struct acpi_battery_hook *hook, int lock)
{
struct acpi_battery *battery;
/*
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][ACPI-next] ACPI: battery: make function __battery_hook_unregister static
2018-02-23 16:32 [PATCH][ACPI-next] ACPI: battery: make function __battery_hook_unregister static Colin King
@ 2018-03-14 11:44 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-03-14 11:44 UTC (permalink / raw)
To: Colin King; +Cc: Len Brown, linux-acpi, kernel-janitors, linux-kernel
On Friday, February 23, 2018 5:32:55 PM CET Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function __battery_hook_unregister is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/acpi/battery.c:654:6: warning: symbol '__battery_hook_unregister'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/acpi/battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index cfdef4c1d097..b4580b2e8706 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -651,7 +651,7 @@ static LIST_HEAD(acpi_battery_list);
> static LIST_HEAD(battery_hook_list);
> static DEFINE_MUTEX(hook_mutex);
>
> -void __battery_hook_unregister(struct acpi_battery_hook *hook, int lock)
> +static void __battery_hook_unregister(struct acpi_battery_hook *hook, int lock)
> {
> struct acpi_battery *battery;
> /*
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][ACPI-next] ACPI: battery: make function __battery_hook_unregister static
@ 2018-03-14 11:44 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-03-14 11:44 UTC (permalink / raw)
To: Colin King; +Cc: Len Brown, linux-acpi, kernel-janitors, linux-kernel
On Friday, February 23, 2018 5:32:55 PM CET Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function __battery_hook_unregister is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/acpi/battery.c:654:6: warning: symbol '__battery_hook_unregister'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/acpi/battery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index cfdef4c1d097..b4580b2e8706 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -651,7 +651,7 @@ static LIST_HEAD(acpi_battery_list);
> static LIST_HEAD(battery_hook_list);
> static DEFINE_MUTEX(hook_mutex);
>
> -void __battery_hook_unregister(struct acpi_battery_hook *hook, int lock)
> +static void __battery_hook_unregister(struct acpi_battery_hook *hook, int lock)
> {
> struct acpi_battery *battery;
> /*
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-14 11:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-23 16:32 [PATCH][ACPI-next] ACPI: battery: make function __battery_hook_unregister static Colin King
2018-03-14 11:44 ` Rafael J. Wysocki
2018-03-14 11:44 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.