All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH i-g-t] tests/i915/kms_big_fb: trigger async flip with a dummy flip
@ 2022-06-28 11:04 ` Arun R Murthy
  0 siblings, 0 replies; 22+ messages in thread
From: Arun R Murthy @ 2022-06-28 11:04 UTC (permalink / raw)
  To: igt-dev; +Cc: intel-gfx

In oder to trigger the async flip, a dummy flip is required after sync
flip so as to update the watermarks for async in KMD which happens as
part of this dummy flip. Thereafter async memory update will act as a
trigger register.
Capturing the CRC is done after the async flip as async flip at some
times can consume fairly a vblank period time.

Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
 tests/i915/kms_big_fb.c | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)

diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
index d50fde45..6caf3c31 100644
--- a/tests/i915/kms_big_fb.c
+++ b/tests/i915/kms_big_fb.c
@@ -465,7 +465,7 @@ static bool test_pipe(data_t *data)
 static bool
 max_hw_stride_async_flip_test(data_t *data)
 {
-	uint32_t ret, startframe;
+	uint32_t ret, frame;
 	const uint32_t w = data->output->config.default_mode.hdisplay,
 		       h = data->output->config.default_mode.vdisplay;
 	igt_plane_t *primary;
@@ -519,7 +519,19 @@ max_hw_stride_async_flip_test(data_t *data)
 					  DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
 
 		igt_wait_for_vblank(data->drm_fd, data->display.pipes[primary->pipe->pipe].crtc_offset);
-		startframe = kmstest_get_vblank(data->drm_fd, data->pipe, 0) + 1;
+		/*
+		 * In older platforms (<= Gen10), async address update bit is double buffered.
+		 * So flip timestamp can be verified only from the second flip.
+		 * The first async flip just enables the async address update.
+		 * In platforms greater than DISPLAY13 the first async flip will be discarded
+		 * in order to change the watermark levels as per the optimization. Hence the
+		 * subsequent async flips will actually do the asynchronous flips.
+		 */
+		ret = drmModePageFlip(data->drm_fd, data->output->config.crtc->crtc_id,
+						      data->big_fb_flip[i].fb_id,
+						      DRM_MODE_PAGE_FLIP_ASYNC, NULL);
+		igt_wait_for_vblank(data->drm_fd, data->display.pipes[primary->pipe->pipe].crtc_offset);
+		frame = kmstest_get_vblank(data->drm_fd, data->pipe, 0) + 1;
 
 		for (int j = 0; j < 2; j++) {
 			do {
@@ -528,23 +540,20 @@ max_hw_stride_async_flip_test(data_t *data)
 						      DRM_MODE_PAGE_FLIP_ASYNC, NULL);
 			} while (ret == -EBUSY);
 			igt_assert(ret == 0);
+			igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc,
+					   frame, &compare_crc);
 
+			frame = kmstest_get_vblank(data->drm_fd, data->pipe, 0) + 1;
 			do {
 				ret = drmModePageFlip(data->drm_fd, data->output->config.crtc->crtc_id,
 						      data->big_fb.fb_id,
 						      DRM_MODE_PAGE_FLIP_ASYNC, NULL);
 			} while (ret == -EBUSY);
 			igt_assert(ret == 0);
+			igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc,
+					   frame, &async_crc);
 		}
 
-		igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc,
-					   startframe, &compare_crc);
-		igt_pipe_crc_get_for_frame(data->drm_fd, data->pipe_crc,
-					   startframe + 1, &async_crc);
-
-		igt_assert_f(kmstest_get_vblank(data->drm_fd, data->pipe, 0) -
-			     startframe == 1, "lost frames\n");
-
 		igt_assert_f(igt_check_crc_equal(&compare_crc, &async_crc)^(i^1),
 			     "CRC failure with async flip, crc %s match for checked round\n",
 			     i?"should":"shouldn't");
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
end of thread, other threads:[~2022-07-05 13:07 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-28 11:04 [Intel-gfx] [PATCH i-g-t] tests/i915/kms_big_fb: trigger async flip with a dummy flip Arun R Murthy
2022-06-28 11:04 ` [igt-dev] " Arun R Murthy
2022-06-28 13:11 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2022-06-28 13:37 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-06-29  5:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-04  8:29 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/kms_big_fb: trigger async flip with a dummy flip (rev2) Patchwork
2022-07-04 10:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-07-05  9:27 ` [Intel-gfx] [PATCH i-g-t] tests/i915/kms_big_fb: trigger async flip with a dummy flip Karthik B S
2022-07-05  9:27   ` [igt-dev] " Karthik B S
2022-07-05  9:38   ` [Intel-gfx] " Murthy, Arun R
2022-07-05  9:38     ` [igt-dev] " Murthy, Arun R
2022-07-05  9:49     ` [Intel-gfx] " Karthik B S
2022-07-05  9:49       ` [igt-dev] " Karthik B S
2022-07-05 10:16       ` [Intel-gfx] " Murthy, Arun R
2022-07-05 10:16         ` [igt-dev] " Murthy, Arun R
2022-07-05 10:22       ` [Intel-gfx] " Juha-Pekka Heikkilä
2022-07-05 10:22         ` [igt-dev] " Juha-Pekka Heikkilä
2022-07-05 10:28         ` [Intel-gfx] " Murthy, Arun R
2022-07-05 10:28           ` [igt-dev] " Murthy, Arun R
2022-07-05 10:58           ` [Intel-gfx] " Juha-Pekka Heikkila
2022-07-05 10:58             ` [igt-dev] " Juha-Pekka Heikkila
2022-07-05 13:07 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/i915/kms_big_fb: trigger async flip with a dummy flip (rev3) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.