[PATCH 0/4] dt-bindings/pinctrl/arm: qcom: second round of minor cleanups of QCOM PMIC pinctrl

[PATCH 0/4] dt-bindings/pinctrl/arm: qcom: second round of minor cleanups of QCOM PMIC pinctrl

[Krzysztof Kozlowski]

Hi,

Dependencies
============
This is on top of:
dt-bindings/pinctrl/arm: qcom: minor cleanups of QCOM PMIC pinctrl
https://lore.kernel.org/linux-arm-msm/20220507194913.261121-1-krzysztof.kozlowski@linaro.org/T/#t

Not really tested on hardware (except SDM845).

Best regards,
Krzysztof

Krzysztof Kozlowski (4):
  dt-bindings: pinctrl: qcom,pmic-gpio: add 'gpio-reserved-ranges'
  arm64: dts: qcom: add missing gpio-ranges in PMIC GPIOs
  arm64: dts: qcom: correct interrupt controller on PM8916 and PMS405
  ARM: dts: qcom: add missing gpio-ranges in PMIC GPIOs

 .../bindings/pinctrl/qcom,pmic-gpio.yaml      | 53 +++++++++++++++++++
 arch/arm/boot/dts/qcom-pmx55.dtsi             |  1 +
 arch/arm/boot/dts/qcom-pmx65.dtsi             |  1 +
 arch/arm64/boot/dts/qcom/pm6350.dtsi          |  1 +
 arch/arm64/boot/dts/qcom/pm8009.dtsi          |  1 +
 arch/arm64/boot/dts/qcom/pm8150.dtsi          |  1 +
 arch/arm64/boot/dts/qcom/pm8150b.dtsi         |  1 +
 arch/arm64/boot/dts/qcom/pm8150l.dtsi         |  1 +
 arch/arm64/boot/dts/qcom/pm8350.dtsi          |  1 +
 arch/arm64/boot/dts/qcom/pm8350b.dtsi         |  1 +
 arch/arm64/boot/dts/qcom/pm8916.dtsi          |  7 ++-
 arch/arm64/boot/dts/qcom/pmr735b.dtsi         |  1 +
 arch/arm64/boot/dts/qcom/pms405.dtsi          | 15 ++----
 13 files changed, 69 insertions(+), 16 deletions(-)

-- 
2.32.0

[PATCH 1/4] dt-bindings: pinctrl: qcom,pmic-gpio: add 'gpio-reserved-ranges'

[Krzysztof Kozlowski]

'gpio-reserved-ranges' property is already used and supported by common pinctrl
bindings, so add it also here to fix warnings like:

  qrb5165-rb5.dtb: gpio@c000: 'gpio-reserved-ranges' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../bindings/pinctrl/qcom,pmic-gpio.yaml      | 53 +++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index 7e74a87ccc39..69195660ee2a 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -78,6 +78,12 @@ properties:
     minItems: 2
     maxItems: 44
 
+  gpio-reserved-ranges:
+    minItems: 1
+    # maxItems as half of total number of GPIOs, as there has to be at
+    # least one usable GPIO between each reserved range.
+    maxItems: 22
+
   '#gpio-cells':
     const: 2
     description:
@@ -107,6 +113,8 @@ allOf:
         gpio-line-names:
           minItems: 2
           maxItems: 2
+        gpio-reserved-ranges:
+          maxItems: 1
 
   - if:
       properties:
@@ -124,6 +132,9 @@ allOf:
         gpio-line-names:
           minItems: 4
           maxItems: 4
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 2
 
   - if:
       properties:
@@ -137,6 +148,9 @@ allOf:
         gpio-line-names:
           minItems: 6
           maxItems: 6
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 3
 
   - if:
       properties:
@@ -150,6 +164,9 @@ allOf:
         gpio-line-names:
           minItems: 8
           maxItems: 8
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 4
 
   - if:
       properties:
@@ -163,6 +180,9 @@ allOf:
         gpio-line-names:
           minItems: 9
           maxItems: 9
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 5
 
   - if:
       properties:
@@ -182,6 +202,9 @@ allOf:
         gpio-line-names:
           minItems: 10
           maxItems: 10
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 5
 
   - if:
       properties:
@@ -194,6 +217,9 @@ allOf:
         gpio-line-names:
           minItems: 11
           maxItems: 11
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 6
 
   - if:
       properties:
@@ -212,6 +238,9 @@ allOf:
         gpio-line-names:
           minItems: 12
           maxItems: 12
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 6
 
   - if:
       properties:
@@ -224,6 +253,9 @@ allOf:
         gpio-line-names:
           minItems: 13
           maxItems: 13
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 7
 
   - if:
       properties:
@@ -236,6 +268,9 @@ allOf:
         gpio-line-names:
           minItems: 14
           maxItems: 14
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 7
 
   - if:
       properties:
@@ -248,6 +283,9 @@ allOf:
         gpio-line-names:
           minItems: 16
           maxItems: 16
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 8
 
   - if:
       properties:
@@ -261,6 +299,9 @@ allOf:
         gpio-line-names:
           minItems: 22
           maxItems: 22
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 11
 
   - if:
       properties:
@@ -273,6 +314,9 @@ allOf:
         gpio-line-names:
           minItems: 26
           maxItems: 26
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 13
 
   - if:
       properties:
@@ -285,6 +329,9 @@ allOf:
         gpio-line-names:
           minItems: 36
           maxItems: 36
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 18
 
   - if:
       properties:
@@ -297,6 +344,9 @@ allOf:
         gpio-line-names:
           minItems: 38
           maxItems: 38
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 19
 
   - if:
       properties:
@@ -310,6 +360,9 @@ allOf:
         gpio-line-names:
           minItems: 44
           maxItems: 44
+        gpio-reserved-ranges:
+          minItems: 1
+          maxItems: 22
 
 patternProperties:
   '-state$':
-- 
2.32.0

Re: [PATCH 1/4] dt-bindings: pinctrl: qcom,pmic-gpio: add 'gpio-reserved-ranges'

[Rob Herring]

On Sun, 08 May 2022 15:59:29 +0200, Krzysztof Kozlowski wrote:
> 'gpio-reserved-ranges' property is already used and supported by common pinctrl
> bindings, so add it also here to fix warnings like:
> 
>   qrb5165-rb5.dtb: gpio@c000: 'gpio-reserved-ranges' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../bindings/pinctrl/qcom,pmic-gpio.yaml      | 53 +++++++++++++++++++
>  1 file changed, 53 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/4] dt-bindings: pinctrl: qcom,pmic-gpio: add 'gpio-reserved-ranges'

[Linus Walleij]

On Sun, May 8, 2022 at 3:59 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:

> 'gpio-reserved-ranges' property is already used and supported by common pinctrl
> bindings, so add it also here to fix warnings like:
>
>   qrb5165-rb5.dtb: gpio@c000: 'gpio-reserved-ranges' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

This does not apply on top of pinctrl's devel branch, am I doing
something wrong?

Yours,
Linus Walleij

Re: [PATCH 1/4] dt-bindings: pinctrl: qcom,pmic-gpio: add 'gpio-reserved-ranges'

[Krzysztof Kozlowski]

On 14/05/2022 01:18, Linus Walleij wrote:
> On Sun, May 8, 2022 at 3:59 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> 
>> 'gpio-reserved-ranges' property is already used and supported by common pinctrl
>> bindings, so add it also here to fix warnings like:
>>
>>   qrb5165-rb5.dtb: gpio@c000: 'gpio-reserved-ranges' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> This does not apply on top of pinctrl's devel branch, am I doing
> something wrong?

Hi Linus,

Sorry for any confusion. This is on top of my previous patchset:
https://lore.kernel.org/all/20220508135932.132378-1-krzysztof.kozlowski@linaro.org/

Best regards,
Krzysztof

Re: [PATCH 1/4] dt-bindings: pinctrl: qcom,pmic-gpio: add 'gpio-reserved-ranges'

[Bjorn Andersson]

On Sun 08 May 06:59 PDT 2022, Krzysztof Kozlowski wrote:

> 'gpio-reserved-ranges' property is already used and supported by common pinctrl
> bindings, so add it also here to fix warnings like:
> 
>   qrb5165-rb5.dtb: gpio@c000: 'gpio-reserved-ranges' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
>  .../bindings/pinctrl/qcom,pmic-gpio.yaml      | 53 +++++++++++++++++++
>  1 file changed, 53 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> index 7e74a87ccc39..69195660ee2a 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
> @@ -78,6 +78,12 @@ properties:
>      minItems: 2
>      maxItems: 44
>  
> +  gpio-reserved-ranges:
> +    minItems: 1
> +    # maxItems as half of total number of GPIOs, as there has to be at
> +    # least one usable GPIO between each reserved range.
> +    maxItems: 22
> +
>    '#gpio-cells':
>      const: 2
>      description:
> @@ -107,6 +113,8 @@ allOf:
>          gpio-line-names:
>            minItems: 2
>            maxItems: 2
> +        gpio-reserved-ranges:
> +          maxItems: 1
>  
>    - if:
>        properties:
> @@ -124,6 +132,9 @@ allOf:
>          gpio-line-names:
>            minItems: 4
>            maxItems: 4
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 2
>  
>    - if:
>        properties:
> @@ -137,6 +148,9 @@ allOf:
>          gpio-line-names:
>            minItems: 6
>            maxItems: 6
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 3
>  
>    - if:
>        properties:
> @@ -150,6 +164,9 @@ allOf:
>          gpio-line-names:
>            minItems: 8
>            maxItems: 8
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 4
>  
>    - if:
>        properties:
> @@ -163,6 +180,9 @@ allOf:
>          gpio-line-names:
>            minItems: 9
>            maxItems: 9
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 5
>  
>    - if:
>        properties:
> @@ -182,6 +202,9 @@ allOf:
>          gpio-line-names:
>            minItems: 10
>            maxItems: 10
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 5
>  
>    - if:
>        properties:
> @@ -194,6 +217,9 @@ allOf:
>          gpio-line-names:
>            minItems: 11
>            maxItems: 11
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 6
>  
>    - if:
>        properties:
> @@ -212,6 +238,9 @@ allOf:
>          gpio-line-names:
>            minItems: 12
>            maxItems: 12
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 6
>  
>    - if:
>        properties:
> @@ -224,6 +253,9 @@ allOf:
>          gpio-line-names:
>            minItems: 13
>            maxItems: 13
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 7
>  
>    - if:
>        properties:
> @@ -236,6 +268,9 @@ allOf:
>          gpio-line-names:
>            minItems: 14
>            maxItems: 14
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 7
>  
>    - if:
>        properties:
> @@ -248,6 +283,9 @@ allOf:
>          gpio-line-names:
>            minItems: 16
>            maxItems: 16
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 8
>  
>    - if:
>        properties:
> @@ -261,6 +299,9 @@ allOf:
>          gpio-line-names:
>            minItems: 22
>            maxItems: 22
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 11
>  
>    - if:
>        properties:
> @@ -273,6 +314,9 @@ allOf:
>          gpio-line-names:
>            minItems: 26
>            maxItems: 26
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 13
>  
>    - if:
>        properties:
> @@ -285,6 +329,9 @@ allOf:
>          gpio-line-names:
>            minItems: 36
>            maxItems: 36
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 18
>  
>    - if:
>        properties:
> @@ -297,6 +344,9 @@ allOf:
>          gpio-line-names:
>            minItems: 38
>            maxItems: 38
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 19
>  
>    - if:
>        properties:
> @@ -310,6 +360,9 @@ allOf:
>          gpio-line-names:
>            minItems: 44
>            maxItems: 44
> +        gpio-reserved-ranges:
> +          minItems: 1
> +          maxItems: 22
>  
>  patternProperties:
>    '-state$':
> -- 
> 2.32.0
> 

[PATCH 2/4] arm64: dts: qcom: add missing gpio-ranges in PMIC GPIOs

[Krzysztof Kozlowski]

The new Qualcomm PMIC GPIO bindings require gpio-ranges property:

  sm8250-sony-xperia-edo-pdx203.dtb: gpio@c000: 'gpio-ranges' is a required property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/pm6350.dtsi  | 1 +
 arch/arm64/boot/dts/qcom/pm8009.dtsi  | 1 +
 arch/arm64/boot/dts/qcom/pm8150.dtsi  | 1 +
 arch/arm64/boot/dts/qcom/pm8150b.dtsi | 1 +
 arch/arm64/boot/dts/qcom/pm8150l.dtsi | 1 +
 arch/arm64/boot/dts/qcom/pm8350.dtsi  | 1 +
 arch/arm64/boot/dts/qcom/pm8350b.dtsi | 1 +
 arch/arm64/boot/dts/qcom/pm8916.dtsi  | 1 +
 arch/arm64/boot/dts/qcom/pmr735b.dtsi | 1 +
 arch/arm64/boot/dts/qcom/pms405.dtsi  | 1 +
 10 files changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pm6350.dtsi b/arch/arm64/boot/dts/qcom/pm6350.dtsi
index f3056845e65f..ecf9b9919182 100644
--- a/arch/arm64/boot/dts/qcom/pm6350.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm6350.dtsi
@@ -39,6 +39,7 @@ pm6350_gpios: gpios@c000 {
 			compatible = "qcom,pm6350-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
+			gpio-ranges = <&pm6350_gpios 0 0 9>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
diff --git a/arch/arm64/boot/dts/qcom/pm8009.dtsi b/arch/arm64/boot/dts/qcom/pm8009.dtsi
index d451922d2b95..0c2c424be0ea 100644
--- a/arch/arm64/boot/dts/qcom/pm8009.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8009.dtsi
@@ -22,6 +22,7 @@ pm8009_gpios: gpio@c000 {
 			compatible = "qcom,pm8005-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
+			gpio-ranges = <&pm8009_gpios 0 0 4>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
diff --git a/arch/arm64/boot/dts/qcom/pm8150.dtsi b/arch/arm64/boot/dts/qcom/pm8150.dtsi
index 72cd93ced4c5..fd8434215924 100644
--- a/arch/arm64/boot/dts/qcom/pm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8150.dtsi
@@ -130,6 +130,7 @@ pm8150_gpios: gpio@c000 {
 			compatible = "qcom,pm8150-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
+			gpio-ranges = <&pm8150_gpios 0 0 10>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
index 28162f6fb61d..d0d8890f087c 100644
--- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
@@ -115,6 +115,7 @@ pm8150b_gpios: gpio@c000 {
 			compatible = "qcom,pm8150b-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
+			gpio-ranges = <&pm8150b_gpios 0 0 12>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
diff --git a/arch/arm64/boot/dts/qcom/pm8150l.dtsi b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
index 0642e7d5be35..2b273c219fd8 100644
--- a/arch/arm64/boot/dts/qcom/pm8150l.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
@@ -103,6 +103,7 @@ pm8150l_gpios: gpio@c000 {
 			compatible = "qcom,pm8150l-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
+			gpio-ranges = <&pm8150l_gpios 0 0 12>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
diff --git a/arch/arm64/boot/dts/qcom/pm8350.dtsi b/arch/arm64/boot/dts/qcom/pm8350.dtsi
index 6e91dd7a48b3..2dfeb99300d7 100644
--- a/arch/arm64/boot/dts/qcom/pm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8350.dtsi
@@ -48,6 +48,7 @@ pm8350_gpios: gpio@8800 {
 			compatible = "qcom,pm8350-gpio", "qcom,spmi-gpio";
 			reg = <0x8800>;
 			gpio-controller;
+			gpio-ranges = <&pm8350_gpios 0 0 10>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
diff --git a/arch/arm64/boot/dts/qcom/pm8350b.dtsi b/arch/arm64/boot/dts/qcom/pm8350b.dtsi
index d9512f01ed1e..f1c7bd9d079c 100644
--- a/arch/arm64/boot/dts/qcom/pm8350b.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8350b.dtsi
@@ -48,6 +48,7 @@ pm8350b_gpios: gpio@8800 {
 			compatible = "qcom,pm8350b-gpio", "qcom,spmi-gpio";
 			reg = <0x8800>;
 			gpio-controller;
+			gpio-ranges = <&pm8350b_gpios 0 0 8>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi
index aedc0aa5602f..d52919a8c0b0 100644
--- a/arch/arm64/boot/dts/qcom/pm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi
@@ -111,6 +111,7 @@ pm8916_gpios: gpios@c000 {
 			compatible = "qcom,pm8916-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
+			gpio-ranges = <&pm8916_gpios 0 0 4>;
 			#gpio-cells = <2>;
 			interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
 				     <0 0xc1 0 IRQ_TYPE_NONE>,
diff --git a/arch/arm64/boot/dts/qcom/pmr735b.dtsi b/arch/arm64/boot/dts/qcom/pmr735b.dtsi
index 93a658eb4cdd..ec24c4478005 100644
--- a/arch/arm64/boot/dts/qcom/pmr735b.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmr735b.dtsi
@@ -48,6 +48,7 @@ pmr735b_gpios: gpio@8800 {
 			compatible = "qcom,pmr735b-gpio", "qcom,spmi-gpio";
 			reg = <0x8800>;
 			gpio-controller;
+			gpio-ranges = <&pmr735b_gpios 0 0 4>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi b/arch/arm64/boot/dts/qcom/pms405.dtsi
index 43190a5cfe33..26f1e8cc9c6c 100644
--- a/arch/arm64/boot/dts/qcom/pms405.dtsi
+++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
@@ -41,6 +41,7 @@ pms405_gpios: gpio@c000 {
 			compatible = "qcom,pms405-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
+			gpio-ranges = <&pms405_gpios 0 0 12>;
 			#gpio-cells = <2>;
 			interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
 				<0 0xc1 0 IRQ_TYPE_NONE>,
-- 
2.32.0

[RFT 3/4] arm64: dts: qcom: correct interrupt controller on PM8916 and PMS405

[Krzysztof Kozlowski]

The PM8916 and PMS405 PMIC GPIOs are interrupt controllers, as described
in the bindings and used by the driver.  Drop the interrupts (apparently
copied from downstream tree), just like in commit 61d2ca503d0b ("arm64:
dts: qcom: fix pm8150 gpio interrupts"):

  qcs404-evb-4000.dtb: gpio@c000: 'interrupts' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
  qcs404-evb-4000.dtb: gpio@c000: 'interrupt-controller' is a required property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/pm8916.dtsi |  6 ++----
 arch/arm64/boot/dts/qcom/pms405.dtsi | 14 ++------------
 2 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi
index d52919a8c0b0..0b6e8ad7fa50 100644
--- a/arch/arm64/boot/dts/qcom/pm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi
@@ -113,10 +113,8 @@ pm8916_gpios: gpios@c000 {
 			gpio-controller;
 			gpio-ranges = <&pm8916_gpios 0 0 4>;
 			#gpio-cells = <2>;
-			interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
-				     <0 0xc1 0 IRQ_TYPE_NONE>,
-				     <0 0xc2 0 IRQ_TYPE_NONE>,
-				     <0 0xc3 0 IRQ_TYPE_NONE>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
 		};
 	};
 
diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi b/arch/arm64/boot/dts/qcom/pms405.dtsi
index 26f1e8cc9c6c..634b0681d04c 100644
--- a/arch/arm64/boot/dts/qcom/pms405.dtsi
+++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
@@ -43,18 +43,8 @@ pms405_gpios: gpio@c000 {
 			gpio-controller;
 			gpio-ranges = <&pms405_gpios 0 0 12>;
 			#gpio-cells = <2>;
-			interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
-				<0 0xc1 0 IRQ_TYPE_NONE>,
-				<0 0xc2 0 IRQ_TYPE_NONE>,
-				<0 0xc3 0 IRQ_TYPE_NONE>,
-				<0 0xc4 0 IRQ_TYPE_NONE>,
-				<0 0xc5 0 IRQ_TYPE_NONE>,
-				<0 0xc6 0 IRQ_TYPE_NONE>,
-				<0 0xc7 0 IRQ_TYPE_NONE>,
-				<0 0xc8 0 IRQ_TYPE_NONE>,
-				<0 0xc9 0 IRQ_TYPE_NONE>,
-				<0 0xca 0 IRQ_TYPE_NONE>,
-				<0 0xcb 0 IRQ_TYPE_NONE>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
 		};
 
 		pon@800 {
-- 
2.32.0

[PATCH 4/4] ARM: dts: qcom: add missing gpio-ranges in PMIC GPIOs

[Krzysztof Kozlowski]

The new Qualcomm PMIC GPIO bindings require gpio-ranges property:

  qcom-sdx55-telit-fn980-tlb.dtb: gpio@c000: 'gpio-ranges' is a required property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom-pmx55.dtsi | 1 +
 arch/arm/boot/dts/qcom-pmx65.dtsi | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/qcom-pmx55.dtsi b/arch/arm/boot/dts/qcom-pmx55.dtsi
index 6571b88d018a..9de7578a4c5f 100644
--- a/arch/arm/boot/dts/qcom-pmx55.dtsi
+++ b/arch/arm/boot/dts/qcom-pmx55.dtsi
@@ -69,6 +69,7 @@ pmx55_gpios: gpio@c000 {
 			compatible = "qcom,pmx55-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
+			gpio-ranges = <&pmx55_gpios 0 0 11>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
diff --git a/arch/arm/boot/dts/qcom-pmx65.dtsi b/arch/arm/boot/dts/qcom-pmx65.dtsi
index 8701396fe1f2..abf229a8b75a 100644
--- a/arch/arm/boot/dts/qcom-pmx65.dtsi
+++ b/arch/arm/boot/dts/qcom-pmx65.dtsi
@@ -24,6 +24,7 @@ pmx65_gpios: pinctrl@8800 {
 			compatible = "qcom,pmx65-gpio", "qcom,spmi-gpio";
 			reg = <0x8800>;
 			gpio-controller;
+			gpio-ranges = <&pmx65_gpios 0 0 16>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
-- 
2.32.0

Re: (subset) [PATCH 4/4] ARM: dts: qcom: add missing gpio-ranges in PMIC GPIOs

[Bjorn Andersson]

On Sun, 8 May 2022 15:59:32 +0200, Krzysztof Kozlowski wrote:
> The new Qualcomm PMIC GPIO bindings require gpio-ranges property:
> 
>   qcom-sdx55-telit-fn980-tlb.dtb: gpio@c000: 'gpio-ranges' is a required property
> 
> 

Applied, thanks!

[4/4] ARM: dts: qcom: add missing gpio-ranges in PMIC GPIOs
      commit: eea939a0da869e00f40e41182edbcd911ee11fd4

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

Re: [PATCH 0/4] dt-bindings/pinctrl/arm: qcom: second round of minor cleanups of QCOM PMIC pinctrl

[Linus Walleij]

On Sun, May 8, 2022 at 3:59 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:

> Krzysztof Kozlowski (4):
>   dt-bindings: pinctrl: qcom,pmic-gpio: add 'gpio-reserved-ranges'

This patch applied to the pinctrl tree on top of the other 4 patches
concerning bindings from the previous patch set.

Yours,
Linus Walleij

Re: (subset) [PATCH 0/4] dt-bindings/pinctrl/arm: qcom: second round of minor cleanups of QCOM PMIC pinctrl

[Bjorn Andersson]

On Sun, 8 May 2022 15:59:28 +0200, Krzysztof Kozlowski wrote:
> Dependencies
> ============
> This is on top of:
> dt-bindings/pinctrl/arm: qcom: minor cleanups of QCOM PMIC pinctrl
> https://lore.kernel.org/linux-arm-msm/20220507194913.261121-1-krzysztof.kozlowski@linaro.org/T/#t
> 
> Not really tested on hardware (except SDM845).
> 
> [...]

Applied, thanks!

[2/4] arm64: dts: qcom: add missing gpio-ranges in PMIC GPIOs
      commit: b07bfd8ebe31b0a39184cba522fdae433b6cd0ad
[3/4] arm64: dts: qcom: correct interrupt controller on PM8916 and PMS405
      commit: a984d5d191527108a934cb9da2a15b07ea05a8ea

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>