* [PATCH] drm/fb-helper: Remove helpers to change frame buffer config @ 2022-06-29 10:56 ` Geert Uytterhoeven 0 siblings, 0 replies; 14+ messages in thread From: Geert Uytterhoeven @ 2022-06-29 10:56 UTC (permalink / raw) To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Tomi Valkeinen Cc: Helge Deller, Greg Kroah-Hartman, dri-devel, intel-gfx, linux-fbdev, linux-kernel, Geert Uytterhoeven The DRM fbdev emulation layer does not support pushing back changes to fb_var_screeninfo to KMS. However, drm_fb_helper still implements the fb_ops.fb_check_var() and fb_ops.fb_set_par() callbacks, but the former fails to validate various parameters passed from userspace. Hence unsanitized and possible invaled values are passed up through the fbdev, fbcon, and console stack, which has become an endless source of security issues reported against fbdev. Fix this by not populating the fb_ops.fb_check_var() and fb_ops.fb_set_par() callbacks, as there is no point in providing them if the frame buffer config cannot be changed anyway. This makes the fbdev core aware that making changes to the frame buffer config is not supported, so it will always return the current config. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- The only remaining DRM driver that implements fb_ops.fb_check_var() is also broken, as it fails to validate various parameters passed from userspace. So vmw_fb_check_var() should either be fixed, or removed. --- drivers/gpu/drm/drm_fb_helper.c | 180 ++------------------- drivers/gpu/drm/i915/display/intel_fbdev.c | 15 -- drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 - include/drm/drm_fb_helper.h | 16 -- 4 files changed, 13 insertions(+), 200 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 2d4cee6a10ffffe7..1041a11c410d7967 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -228,9 +228,18 @@ int drm_fb_helper_debug_leave(struct fb_info *info) } EXPORT_SYMBOL(drm_fb_helper_debug_leave); -static int -__drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, - bool force) +/** + * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration + * @fb_helper: driver-allocated fbdev helper, can be NULL + * + * This should be called from driver's drm &drm_driver.lastclose callback + * when implementing an fbcon on top of kms using this helper. This ensures that + * the user isn't greeted with a black screen when e.g. X dies. + * + * RETURNS: + * Zero if everything went ok, negative error code otherwise. + */ +int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) { bool do_delayed; int ret; @@ -242,16 +251,7 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, return 0; mutex_lock(&fb_helper->lock); - if (force) { - /* - * Yes this is the _locked version which expects the master lock - * to be held. But for forced restores we're intentionally - * racing here, see drm_fb_helper_set_par(). - */ - ret = drm_client_modeset_commit_locked(&fb_helper->client); - } else { - ret = drm_client_modeset_commit(&fb_helper->client); - } + ret = drm_client_modeset_commit(&fb_helper->client); do_delayed = fb_helper->delayed_hotplug; if (do_delayed) @@ -263,22 +263,6 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, return ret; } - -/** - * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration - * @fb_helper: driver-allocated fbdev helper, can be NULL - * - * This should be called from driver's drm &drm_driver.lastclose callback - * when implementing an fbcon on top of kms using this helper. This ensures that - * the user isn't greeted with a black screen when e.g. X dies. - * - * RETURNS: - * Zero if everything went ok, negative error code otherwise. - */ -int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) -{ - return __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, false); -} EXPORT_SYMBOL(drm_fb_helper_restore_fbdev_mode_unlocked); #ifdef CONFIG_MAGIC_SYSRQ @@ -1254,25 +1238,6 @@ int drm_fb_helper_ioctl(struct fb_info *info, unsigned int cmd, } EXPORT_SYMBOL(drm_fb_helper_ioctl); -static bool drm_fb_pixel_format_equal(const struct fb_var_screeninfo *var_1, - const struct fb_var_screeninfo *var_2) -{ - return var_1->bits_per_pixel == var_2->bits_per_pixel && - var_1->grayscale == var_2->grayscale && - var_1->red.offset == var_2->red.offset && - var_1->red.length == var_2->red.length && - var_1->red.msb_right == var_2->red.msb_right && - var_1->green.offset == var_2->green.offset && - var_1->green.length == var_2->green.length && - var_1->green.msb_right == var_2->green.msb_right && - var_1->blue.offset == var_2->blue.offset && - var_1->blue.length == var_2->blue.length && - var_1->blue.msb_right == var_2->blue.msb_right && - var_1->transp.offset == var_2->transp.offset && - var_1->transp.length == var_2->transp.length && - var_1->transp.msb_right == var_2->transp.msb_right; -} - static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, u8 depth) { @@ -1331,123 +1296,6 @@ static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, } } -/** - * drm_fb_helper_check_var - implementation for &fb_ops.fb_check_var - * @var: screeninfo to check - * @info: fbdev registered by the helper - */ -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, - struct fb_info *info) -{ - struct drm_fb_helper *fb_helper = info->par; - struct drm_framebuffer *fb = fb_helper->fb; - struct drm_device *dev = fb_helper->dev; - - if (in_dbg_master()) - return -EINVAL; - - if (var->pixclock != 0) { - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel clock, value of pixclock is ignored\n"); - var->pixclock = 0; - } - - if ((drm_format_info_block_width(fb->format, 0) > 1) || - (drm_format_info_block_height(fb->format, 0) > 1)) - return -EINVAL; - - /* - * Changes struct fb_var_screeninfo are currently not pushed back - * to KMS, hence fail if different settings are requested. - */ - if (var->bits_per_pixel > fb->format->cpp[0] * 8 || - var->xres > fb->width || var->yres > fb->height || - var->xres_virtual > fb->width || var->yres_virtual > fb->height) { - drm_dbg_kms(dev, "fb requested width/height/bpp can't fit in current fb " - "request %dx%d-%d (virtual %dx%d) > %dx%d-%d\n", - var->xres, var->yres, var->bits_per_pixel, - var->xres_virtual, var->yres_virtual, - fb->width, fb->height, fb->format->cpp[0] * 8); - return -EINVAL; - } - - /* - * Workaround for SDL 1.2, which is known to be setting all pixel format - * fields values to zero in some cases. We treat this situation as a - * kind of "use some reasonable autodetected values". - */ - if (!var->red.offset && !var->green.offset && - !var->blue.offset && !var->transp.offset && - !var->red.length && !var->green.length && - !var->blue.length && !var->transp.length && - !var->red.msb_right && !var->green.msb_right && - !var->blue.msb_right && !var->transp.msb_right) { - drm_fb_helper_fill_pixel_fmt(var, fb->format->depth); - } - - /* - * Likewise, bits_per_pixel should be rounded up to a supported value. - */ - var->bits_per_pixel = fb->format->cpp[0] * 8; - - /* - * drm fbdev emulation doesn't support changing the pixel format at all, - * so reject all pixel format changing requests. - */ - if (!drm_fb_pixel_format_equal(var, &info->var)) { - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel format\n"); - return -EINVAL; - } - - return 0; -} -EXPORT_SYMBOL(drm_fb_helper_check_var); - -/** - * drm_fb_helper_set_par - implementation for &fb_ops.fb_set_par - * @info: fbdev registered by the helper - * - * This will let fbcon do the mode init and is called at initialization time by - * the fbdev core when registering the driver, and later on through the hotplug - * callback. - */ -int drm_fb_helper_set_par(struct fb_info *info) -{ - struct drm_fb_helper *fb_helper = info->par; - struct fb_var_screeninfo *var = &info->var; - bool force; - - if (oops_in_progress) - return -EBUSY; - - if (var->pixclock != 0) { - drm_err(fb_helper->dev, "PIXEL CLOCK SET\n"); - return -EINVAL; - } - - /* - * Normally we want to make sure that a kms master takes precedence over - * fbdev, to avoid fbdev flickering and occasionally stealing the - * display status. But Xorg first sets the vt back to text mode using - * the KDSET IOCTL with KD_TEXT, and only after that drops the master - * status when exiting. - * - * In the past this was caught by drm_fb_helper_lastclose(), but on - * modern systems where logind always keeps a drm fd open to orchestrate - * the vt switching, this doesn't work. - * - * To not break the userspace ABI we have this special case here, which - * is only used for the above case. Everything else uses the normal - * commit function, which ensures that we never steal the display from - * an active drm master. - */ - force = var->activate & FB_ACTIVATE_KD_TEXT; - - __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, force); - - return 0; -} -EXPORT_SYMBOL(drm_fb_helper_set_par); - static void pan_set(struct drm_fb_helper *fb_helper, int x, int y) { struct drm_mode_set *mode_set; @@ -2028,8 +1876,6 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper) drm_setup_crtcs_fb(fb_helper); mutex_unlock(&fb_helper->lock); - drm_fb_helper_set_par(fb_helper->fbdev); - return 0; } EXPORT_SYMBOL(drm_fb_helper_hotplug_event); diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c index 221336178991f04f..26dbe9487c79ae1b 100644 --- a/drivers/gpu/drm/i915/display/intel_fbdev.c +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c @@ -77,20 +77,6 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev) intel_frontbuffer_invalidate(to_frontbuffer(ifbdev), ORIGIN_CPU); } -static int intel_fbdev_set_par(struct fb_info *info) -{ - struct drm_fb_helper *fb_helper = info->par; - struct intel_fbdev *ifbdev = - container_of(fb_helper, struct intel_fbdev, helper); - int ret; - - ret = drm_fb_helper_set_par(info); - if (ret == 0) - intel_fbdev_invalidate(ifbdev); - - return ret; -} - static int intel_fbdev_blank(int blank, struct fb_info *info) { struct drm_fb_helper *fb_helper = info->par; @@ -123,7 +109,6 @@ static int intel_fbdev_pan_display(struct fb_var_screeninfo *var, static const struct fb_ops intelfb_ops = { .owner = THIS_MODULE, DRM_FB_HELPER_DEFAULT_OPS, - .fb_set_par = intel_fbdev_set_par, .fb_fillrect = drm_fb_helper_cfb_fillrect, .fb_copyarea = drm_fb_helper_cfb_copyarea, .fb_imageblit = drm_fb_helper_cfb_imageblit, diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c index 40706c5aad7b5c9b..2df8875baaca10b6 100644 --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c @@ -74,8 +74,6 @@ static int omap_fbdev_pan_display(struct fb_var_screeninfo *var, static const struct fb_ops omap_fb_ops = { .owner = THIS_MODULE, - .fb_check_var = drm_fb_helper_check_var, - .fb_set_par = drm_fb_helper_set_par, .fb_setcmap = drm_fb_helper_setcmap, .fb_blank = drm_fb_helper_blank, .fb_pan_display = omap_fbdev_pan_display, diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 329607ca65c06684..19b40adc156295a1 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -200,8 +200,6 @@ drm_fb_helper_from_client(struct drm_client_dev *client) * functions. To be used in struct fb_ops of drm drivers. */ #define DRM_FB_HELPER_DEFAULT_OPS \ - .fb_check_var = drm_fb_helper_check_var, \ - .fb_set_par = drm_fb_helper_set_par, \ .fb_setcmap = drm_fb_helper_setcmap, \ .fb_blank = drm_fb_helper_blank, \ .fb_pan_display = drm_fb_helper_pan_display, \ @@ -217,9 +215,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *helper); int drm_fb_helper_blank(int blank, struct fb_info *info); int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, struct fb_info *info); -int drm_fb_helper_set_par(struct fb_info *info); -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, - struct fb_info *info); int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper); @@ -303,17 +298,6 @@ static inline int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, return 0; } -static inline int drm_fb_helper_set_par(struct fb_info *info) -{ - return 0; -} - -static inline int drm_fb_helper_check_var(struct fb_var_screeninfo *var, - struct fb_info *info) -{ - return 0; -} - static inline int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) { -- 2.25.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [PATCH] drm/fb-helper: Remove helpers to change frame buffer config @ 2022-06-29 10:56 ` Geert Uytterhoeven 0 siblings, 0 replies; 14+ messages in thread From: Geert Uytterhoeven @ 2022-06-29 10:56 UTC (permalink / raw) To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Tomi Valkeinen Cc: linux-fbdev, Greg Kroah-Hartman, Helge Deller, linux-kernel, dri-devel, Geert Uytterhoeven, intel-gfx The DRM fbdev emulation layer does not support pushing back changes to fb_var_screeninfo to KMS. However, drm_fb_helper still implements the fb_ops.fb_check_var() and fb_ops.fb_set_par() callbacks, but the former fails to validate various parameters passed from userspace. Hence unsanitized and possible invaled values are passed up through the fbdev, fbcon, and console stack, which has become an endless source of security issues reported against fbdev. Fix this by not populating the fb_ops.fb_check_var() and fb_ops.fb_set_par() callbacks, as there is no point in providing them if the frame buffer config cannot be changed anyway. This makes the fbdev core aware that making changes to the frame buffer config is not supported, so it will always return the current config. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- The only remaining DRM driver that implements fb_ops.fb_check_var() is also broken, as it fails to validate various parameters passed from userspace. So vmw_fb_check_var() should either be fixed, or removed. --- drivers/gpu/drm/drm_fb_helper.c | 180 ++------------------- drivers/gpu/drm/i915/display/intel_fbdev.c | 15 -- drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 - include/drm/drm_fb_helper.h | 16 -- 4 files changed, 13 insertions(+), 200 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 2d4cee6a10ffffe7..1041a11c410d7967 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -228,9 +228,18 @@ int drm_fb_helper_debug_leave(struct fb_info *info) } EXPORT_SYMBOL(drm_fb_helper_debug_leave); -static int -__drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, - bool force) +/** + * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration + * @fb_helper: driver-allocated fbdev helper, can be NULL + * + * This should be called from driver's drm &drm_driver.lastclose callback + * when implementing an fbcon on top of kms using this helper. This ensures that + * the user isn't greeted with a black screen when e.g. X dies. + * + * RETURNS: + * Zero if everything went ok, negative error code otherwise. + */ +int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) { bool do_delayed; int ret; @@ -242,16 +251,7 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, return 0; mutex_lock(&fb_helper->lock); - if (force) { - /* - * Yes this is the _locked version which expects the master lock - * to be held. But for forced restores we're intentionally - * racing here, see drm_fb_helper_set_par(). - */ - ret = drm_client_modeset_commit_locked(&fb_helper->client); - } else { - ret = drm_client_modeset_commit(&fb_helper->client); - } + ret = drm_client_modeset_commit(&fb_helper->client); do_delayed = fb_helper->delayed_hotplug; if (do_delayed) @@ -263,22 +263,6 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, return ret; } - -/** - * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration - * @fb_helper: driver-allocated fbdev helper, can be NULL - * - * This should be called from driver's drm &drm_driver.lastclose callback - * when implementing an fbcon on top of kms using this helper. This ensures that - * the user isn't greeted with a black screen when e.g. X dies. - * - * RETURNS: - * Zero if everything went ok, negative error code otherwise. - */ -int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) -{ - return __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, false); -} EXPORT_SYMBOL(drm_fb_helper_restore_fbdev_mode_unlocked); #ifdef CONFIG_MAGIC_SYSRQ @@ -1254,25 +1238,6 @@ int drm_fb_helper_ioctl(struct fb_info *info, unsigned int cmd, } EXPORT_SYMBOL(drm_fb_helper_ioctl); -static bool drm_fb_pixel_format_equal(const struct fb_var_screeninfo *var_1, - const struct fb_var_screeninfo *var_2) -{ - return var_1->bits_per_pixel == var_2->bits_per_pixel && - var_1->grayscale == var_2->grayscale && - var_1->red.offset == var_2->red.offset && - var_1->red.length == var_2->red.length && - var_1->red.msb_right == var_2->red.msb_right && - var_1->green.offset == var_2->green.offset && - var_1->green.length == var_2->green.length && - var_1->green.msb_right == var_2->green.msb_right && - var_1->blue.offset == var_2->blue.offset && - var_1->blue.length == var_2->blue.length && - var_1->blue.msb_right == var_2->blue.msb_right && - var_1->transp.offset == var_2->transp.offset && - var_1->transp.length == var_2->transp.length && - var_1->transp.msb_right == var_2->transp.msb_right; -} - static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, u8 depth) { @@ -1331,123 +1296,6 @@ static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, } } -/** - * drm_fb_helper_check_var - implementation for &fb_ops.fb_check_var - * @var: screeninfo to check - * @info: fbdev registered by the helper - */ -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, - struct fb_info *info) -{ - struct drm_fb_helper *fb_helper = info->par; - struct drm_framebuffer *fb = fb_helper->fb; - struct drm_device *dev = fb_helper->dev; - - if (in_dbg_master()) - return -EINVAL; - - if (var->pixclock != 0) { - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel clock, value of pixclock is ignored\n"); - var->pixclock = 0; - } - - if ((drm_format_info_block_width(fb->format, 0) > 1) || - (drm_format_info_block_height(fb->format, 0) > 1)) - return -EINVAL; - - /* - * Changes struct fb_var_screeninfo are currently not pushed back - * to KMS, hence fail if different settings are requested. - */ - if (var->bits_per_pixel > fb->format->cpp[0] * 8 || - var->xres > fb->width || var->yres > fb->height || - var->xres_virtual > fb->width || var->yres_virtual > fb->height) { - drm_dbg_kms(dev, "fb requested width/height/bpp can't fit in current fb " - "request %dx%d-%d (virtual %dx%d) > %dx%d-%d\n", - var->xres, var->yres, var->bits_per_pixel, - var->xres_virtual, var->yres_virtual, - fb->width, fb->height, fb->format->cpp[0] * 8); - return -EINVAL; - } - - /* - * Workaround for SDL 1.2, which is known to be setting all pixel format - * fields values to zero in some cases. We treat this situation as a - * kind of "use some reasonable autodetected values". - */ - if (!var->red.offset && !var->green.offset && - !var->blue.offset && !var->transp.offset && - !var->red.length && !var->green.length && - !var->blue.length && !var->transp.length && - !var->red.msb_right && !var->green.msb_right && - !var->blue.msb_right && !var->transp.msb_right) { - drm_fb_helper_fill_pixel_fmt(var, fb->format->depth); - } - - /* - * Likewise, bits_per_pixel should be rounded up to a supported value. - */ - var->bits_per_pixel = fb->format->cpp[0] * 8; - - /* - * drm fbdev emulation doesn't support changing the pixel format at all, - * so reject all pixel format changing requests. - */ - if (!drm_fb_pixel_format_equal(var, &info->var)) { - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel format\n"); - return -EINVAL; - } - - return 0; -} -EXPORT_SYMBOL(drm_fb_helper_check_var); - -/** - * drm_fb_helper_set_par - implementation for &fb_ops.fb_set_par - * @info: fbdev registered by the helper - * - * This will let fbcon do the mode init and is called at initialization time by - * the fbdev core when registering the driver, and later on through the hotplug - * callback. - */ -int drm_fb_helper_set_par(struct fb_info *info) -{ - struct drm_fb_helper *fb_helper = info->par; - struct fb_var_screeninfo *var = &info->var; - bool force; - - if (oops_in_progress) - return -EBUSY; - - if (var->pixclock != 0) { - drm_err(fb_helper->dev, "PIXEL CLOCK SET\n"); - return -EINVAL; - } - - /* - * Normally we want to make sure that a kms master takes precedence over - * fbdev, to avoid fbdev flickering and occasionally stealing the - * display status. But Xorg first sets the vt back to text mode using - * the KDSET IOCTL with KD_TEXT, and only after that drops the master - * status when exiting. - * - * In the past this was caught by drm_fb_helper_lastclose(), but on - * modern systems where logind always keeps a drm fd open to orchestrate - * the vt switching, this doesn't work. - * - * To not break the userspace ABI we have this special case here, which - * is only used for the above case. Everything else uses the normal - * commit function, which ensures that we never steal the display from - * an active drm master. - */ - force = var->activate & FB_ACTIVATE_KD_TEXT; - - __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, force); - - return 0; -} -EXPORT_SYMBOL(drm_fb_helper_set_par); - static void pan_set(struct drm_fb_helper *fb_helper, int x, int y) { struct drm_mode_set *mode_set; @@ -2028,8 +1876,6 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper) drm_setup_crtcs_fb(fb_helper); mutex_unlock(&fb_helper->lock); - drm_fb_helper_set_par(fb_helper->fbdev); - return 0; } EXPORT_SYMBOL(drm_fb_helper_hotplug_event); diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c index 221336178991f04f..26dbe9487c79ae1b 100644 --- a/drivers/gpu/drm/i915/display/intel_fbdev.c +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c @@ -77,20 +77,6 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev) intel_frontbuffer_invalidate(to_frontbuffer(ifbdev), ORIGIN_CPU); } -static int intel_fbdev_set_par(struct fb_info *info) -{ - struct drm_fb_helper *fb_helper = info->par; - struct intel_fbdev *ifbdev = - container_of(fb_helper, struct intel_fbdev, helper); - int ret; - - ret = drm_fb_helper_set_par(info); - if (ret == 0) - intel_fbdev_invalidate(ifbdev); - - return ret; -} - static int intel_fbdev_blank(int blank, struct fb_info *info) { struct drm_fb_helper *fb_helper = info->par; @@ -123,7 +109,6 @@ static int intel_fbdev_pan_display(struct fb_var_screeninfo *var, static const struct fb_ops intelfb_ops = { .owner = THIS_MODULE, DRM_FB_HELPER_DEFAULT_OPS, - .fb_set_par = intel_fbdev_set_par, .fb_fillrect = drm_fb_helper_cfb_fillrect, .fb_copyarea = drm_fb_helper_cfb_copyarea, .fb_imageblit = drm_fb_helper_cfb_imageblit, diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c index 40706c5aad7b5c9b..2df8875baaca10b6 100644 --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c @@ -74,8 +74,6 @@ static int omap_fbdev_pan_display(struct fb_var_screeninfo *var, static const struct fb_ops omap_fb_ops = { .owner = THIS_MODULE, - .fb_check_var = drm_fb_helper_check_var, - .fb_set_par = drm_fb_helper_set_par, .fb_setcmap = drm_fb_helper_setcmap, .fb_blank = drm_fb_helper_blank, .fb_pan_display = omap_fbdev_pan_display, diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 329607ca65c06684..19b40adc156295a1 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -200,8 +200,6 @@ drm_fb_helper_from_client(struct drm_client_dev *client) * functions. To be used in struct fb_ops of drm drivers. */ #define DRM_FB_HELPER_DEFAULT_OPS \ - .fb_check_var = drm_fb_helper_check_var, \ - .fb_set_par = drm_fb_helper_set_par, \ .fb_setcmap = drm_fb_helper_setcmap, \ .fb_blank = drm_fb_helper_blank, \ .fb_pan_display = drm_fb_helper_pan_display, \ @@ -217,9 +215,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *helper); int drm_fb_helper_blank(int blank, struct fb_info *info); int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, struct fb_info *info); -int drm_fb_helper_set_par(struct fb_info *info); -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, - struct fb_info *info); int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper); @@ -303,17 +298,6 @@ static inline int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, return 0; } -static inline int drm_fb_helper_set_par(struct fb_info *info) -{ - return 0; -} - -static inline int drm_fb_helper_check_var(struct fb_var_screeninfo *var, - struct fb_info *info) -{ - return 0; -} - static inline int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) { -- 2.25.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] drm/fb-helper: Remove helpers to change frame buffer config @ 2022-06-29 10:56 ` Geert Uytterhoeven 0 siblings, 0 replies; 14+ messages in thread From: Geert Uytterhoeven @ 2022-06-29 10:56 UTC (permalink / raw) To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Tomi Valkeinen Cc: linux-fbdev, Greg Kroah-Hartman, Helge Deller, linux-kernel, dri-devel, Geert Uytterhoeven, intel-gfx The DRM fbdev emulation layer does not support pushing back changes to fb_var_screeninfo to KMS. However, drm_fb_helper still implements the fb_ops.fb_check_var() and fb_ops.fb_set_par() callbacks, but the former fails to validate various parameters passed from userspace. Hence unsanitized and possible invaled values are passed up through the fbdev, fbcon, and console stack, which has become an endless source of security issues reported against fbdev. Fix this by not populating the fb_ops.fb_check_var() and fb_ops.fb_set_par() callbacks, as there is no point in providing them if the frame buffer config cannot be changed anyway. This makes the fbdev core aware that making changes to the frame buffer config is not supported, so it will always return the current config. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- The only remaining DRM driver that implements fb_ops.fb_check_var() is also broken, as it fails to validate various parameters passed from userspace. So vmw_fb_check_var() should either be fixed, or removed. --- drivers/gpu/drm/drm_fb_helper.c | 180 ++------------------- drivers/gpu/drm/i915/display/intel_fbdev.c | 15 -- drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 - include/drm/drm_fb_helper.h | 16 -- 4 files changed, 13 insertions(+), 200 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 2d4cee6a10ffffe7..1041a11c410d7967 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -228,9 +228,18 @@ int drm_fb_helper_debug_leave(struct fb_info *info) } EXPORT_SYMBOL(drm_fb_helper_debug_leave); -static int -__drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, - bool force) +/** + * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration + * @fb_helper: driver-allocated fbdev helper, can be NULL + * + * This should be called from driver's drm &drm_driver.lastclose callback + * when implementing an fbcon on top of kms using this helper. This ensures that + * the user isn't greeted with a black screen when e.g. X dies. + * + * RETURNS: + * Zero if everything went ok, negative error code otherwise. + */ +int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) { bool do_delayed; int ret; @@ -242,16 +251,7 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, return 0; mutex_lock(&fb_helper->lock); - if (force) { - /* - * Yes this is the _locked version which expects the master lock - * to be held. But for forced restores we're intentionally - * racing here, see drm_fb_helper_set_par(). - */ - ret = drm_client_modeset_commit_locked(&fb_helper->client); - } else { - ret = drm_client_modeset_commit(&fb_helper->client); - } + ret = drm_client_modeset_commit(&fb_helper->client); do_delayed = fb_helper->delayed_hotplug; if (do_delayed) @@ -263,22 +263,6 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, return ret; } - -/** - * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration - * @fb_helper: driver-allocated fbdev helper, can be NULL - * - * This should be called from driver's drm &drm_driver.lastclose callback - * when implementing an fbcon on top of kms using this helper. This ensures that - * the user isn't greeted with a black screen when e.g. X dies. - * - * RETURNS: - * Zero if everything went ok, negative error code otherwise. - */ -int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) -{ - return __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, false); -} EXPORT_SYMBOL(drm_fb_helper_restore_fbdev_mode_unlocked); #ifdef CONFIG_MAGIC_SYSRQ @@ -1254,25 +1238,6 @@ int drm_fb_helper_ioctl(struct fb_info *info, unsigned int cmd, } EXPORT_SYMBOL(drm_fb_helper_ioctl); -static bool drm_fb_pixel_format_equal(const struct fb_var_screeninfo *var_1, - const struct fb_var_screeninfo *var_2) -{ - return var_1->bits_per_pixel == var_2->bits_per_pixel && - var_1->grayscale == var_2->grayscale && - var_1->red.offset == var_2->red.offset && - var_1->red.length == var_2->red.length && - var_1->red.msb_right == var_2->red.msb_right && - var_1->green.offset == var_2->green.offset && - var_1->green.length == var_2->green.length && - var_1->green.msb_right == var_2->green.msb_right && - var_1->blue.offset == var_2->blue.offset && - var_1->blue.length == var_2->blue.length && - var_1->blue.msb_right == var_2->blue.msb_right && - var_1->transp.offset == var_2->transp.offset && - var_1->transp.length == var_2->transp.length && - var_1->transp.msb_right == var_2->transp.msb_right; -} - static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, u8 depth) { @@ -1331,123 +1296,6 @@ static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, } } -/** - * drm_fb_helper_check_var - implementation for &fb_ops.fb_check_var - * @var: screeninfo to check - * @info: fbdev registered by the helper - */ -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, - struct fb_info *info) -{ - struct drm_fb_helper *fb_helper = info->par; - struct drm_framebuffer *fb = fb_helper->fb; - struct drm_device *dev = fb_helper->dev; - - if (in_dbg_master()) - return -EINVAL; - - if (var->pixclock != 0) { - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel clock, value of pixclock is ignored\n"); - var->pixclock = 0; - } - - if ((drm_format_info_block_width(fb->format, 0) > 1) || - (drm_format_info_block_height(fb->format, 0) > 1)) - return -EINVAL; - - /* - * Changes struct fb_var_screeninfo are currently not pushed back - * to KMS, hence fail if different settings are requested. - */ - if (var->bits_per_pixel > fb->format->cpp[0] * 8 || - var->xres > fb->width || var->yres > fb->height || - var->xres_virtual > fb->width || var->yres_virtual > fb->height) { - drm_dbg_kms(dev, "fb requested width/height/bpp can't fit in current fb " - "request %dx%d-%d (virtual %dx%d) > %dx%d-%d\n", - var->xres, var->yres, var->bits_per_pixel, - var->xres_virtual, var->yres_virtual, - fb->width, fb->height, fb->format->cpp[0] * 8); - return -EINVAL; - } - - /* - * Workaround for SDL 1.2, which is known to be setting all pixel format - * fields values to zero in some cases. We treat this situation as a - * kind of "use some reasonable autodetected values". - */ - if (!var->red.offset && !var->green.offset && - !var->blue.offset && !var->transp.offset && - !var->red.length && !var->green.length && - !var->blue.length && !var->transp.length && - !var->red.msb_right && !var->green.msb_right && - !var->blue.msb_right && !var->transp.msb_right) { - drm_fb_helper_fill_pixel_fmt(var, fb->format->depth); - } - - /* - * Likewise, bits_per_pixel should be rounded up to a supported value. - */ - var->bits_per_pixel = fb->format->cpp[0] * 8; - - /* - * drm fbdev emulation doesn't support changing the pixel format at all, - * so reject all pixel format changing requests. - */ - if (!drm_fb_pixel_format_equal(var, &info->var)) { - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel format\n"); - return -EINVAL; - } - - return 0; -} -EXPORT_SYMBOL(drm_fb_helper_check_var); - -/** - * drm_fb_helper_set_par - implementation for &fb_ops.fb_set_par - * @info: fbdev registered by the helper - * - * This will let fbcon do the mode init and is called at initialization time by - * the fbdev core when registering the driver, and later on through the hotplug - * callback. - */ -int drm_fb_helper_set_par(struct fb_info *info) -{ - struct drm_fb_helper *fb_helper = info->par; - struct fb_var_screeninfo *var = &info->var; - bool force; - - if (oops_in_progress) - return -EBUSY; - - if (var->pixclock != 0) { - drm_err(fb_helper->dev, "PIXEL CLOCK SET\n"); - return -EINVAL; - } - - /* - * Normally we want to make sure that a kms master takes precedence over - * fbdev, to avoid fbdev flickering and occasionally stealing the - * display status. But Xorg first sets the vt back to text mode using - * the KDSET IOCTL with KD_TEXT, and only after that drops the master - * status when exiting. - * - * In the past this was caught by drm_fb_helper_lastclose(), but on - * modern systems where logind always keeps a drm fd open to orchestrate - * the vt switching, this doesn't work. - * - * To not break the userspace ABI we have this special case here, which - * is only used for the above case. Everything else uses the normal - * commit function, which ensures that we never steal the display from - * an active drm master. - */ - force = var->activate & FB_ACTIVATE_KD_TEXT; - - __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, force); - - return 0; -} -EXPORT_SYMBOL(drm_fb_helper_set_par); - static void pan_set(struct drm_fb_helper *fb_helper, int x, int y) { struct drm_mode_set *mode_set; @@ -2028,8 +1876,6 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper) drm_setup_crtcs_fb(fb_helper); mutex_unlock(&fb_helper->lock); - drm_fb_helper_set_par(fb_helper->fbdev); - return 0; } EXPORT_SYMBOL(drm_fb_helper_hotplug_event); diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c index 221336178991f04f..26dbe9487c79ae1b 100644 --- a/drivers/gpu/drm/i915/display/intel_fbdev.c +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c @@ -77,20 +77,6 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev) intel_frontbuffer_invalidate(to_frontbuffer(ifbdev), ORIGIN_CPU); } -static int intel_fbdev_set_par(struct fb_info *info) -{ - struct drm_fb_helper *fb_helper = info->par; - struct intel_fbdev *ifbdev = - container_of(fb_helper, struct intel_fbdev, helper); - int ret; - - ret = drm_fb_helper_set_par(info); - if (ret == 0) - intel_fbdev_invalidate(ifbdev); - - return ret; -} - static int intel_fbdev_blank(int blank, struct fb_info *info) { struct drm_fb_helper *fb_helper = info->par; @@ -123,7 +109,6 @@ static int intel_fbdev_pan_display(struct fb_var_screeninfo *var, static const struct fb_ops intelfb_ops = { .owner = THIS_MODULE, DRM_FB_HELPER_DEFAULT_OPS, - .fb_set_par = intel_fbdev_set_par, .fb_fillrect = drm_fb_helper_cfb_fillrect, .fb_copyarea = drm_fb_helper_cfb_copyarea, .fb_imageblit = drm_fb_helper_cfb_imageblit, diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c index 40706c5aad7b5c9b..2df8875baaca10b6 100644 --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c @@ -74,8 +74,6 @@ static int omap_fbdev_pan_display(struct fb_var_screeninfo *var, static const struct fb_ops omap_fb_ops = { .owner = THIS_MODULE, - .fb_check_var = drm_fb_helper_check_var, - .fb_set_par = drm_fb_helper_set_par, .fb_setcmap = drm_fb_helper_setcmap, .fb_blank = drm_fb_helper_blank, .fb_pan_display = omap_fbdev_pan_display, diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 329607ca65c06684..19b40adc156295a1 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -200,8 +200,6 @@ drm_fb_helper_from_client(struct drm_client_dev *client) * functions. To be used in struct fb_ops of drm drivers. */ #define DRM_FB_HELPER_DEFAULT_OPS \ - .fb_check_var = drm_fb_helper_check_var, \ - .fb_set_par = drm_fb_helper_set_par, \ .fb_setcmap = drm_fb_helper_setcmap, \ .fb_blank = drm_fb_helper_blank, \ .fb_pan_display = drm_fb_helper_pan_display, \ @@ -217,9 +215,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *helper); int drm_fb_helper_blank(int blank, struct fb_info *info); int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, struct fb_info *info); -int drm_fb_helper_set_par(struct fb_info *info); -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, - struct fb_info *info); int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper); @@ -303,17 +298,6 @@ static inline int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, return 0; } -static inline int drm_fb_helper_set_par(struct fb_info *info) -{ - return 0; -} - -static inline int drm_fb_helper_check_var(struct fb_var_screeninfo *var, - struct fb_info *info) -{ - return 0; -} - static inline int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) { -- 2.25.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/fb-helper: Remove helpers to change frame buffer config 2022-06-29 10:56 ` Geert Uytterhoeven (?) (?) @ 2022-06-29 12:20 ` Patchwork -1 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2022-06-29 12:20 UTC (permalink / raw) To: Geert Uytterhoeven; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 12951 bytes --] == Series Details == Series: drm/fb-helper: Remove helpers to change frame buffer config URL : https://patchwork.freedesktop.org/series/105773/ State : success == Summary == CI Bug Log - changes from CI_DRM_11825 -> Patchwork_105773v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/index.html Participating hosts (39 -> 37) ------------------------------ Additional (2): bat-dg2-9 fi-bsw-n3050 Missing (4): fi-tgl-u2 bat-adlm-1 fi-icl-u2 fi-pnv-d510 Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_105773v1: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@gem_exec_parallel@engines@fds: - {bat-jsl-1}: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/bat-jsl-1/igt@gem_exec_parallel@engines@fds.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/bat-jsl-1/igt@gem_exec_parallel@engines@fds.html Known issues ------------ Here are the changes found in Patchwork_105773v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_lmem_swapping@basic: - fi-apl-guc: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-apl-guc/igt@gem_lmem_swapping@basic.html * igt@i915_pm_rpm@module-reload: - fi-bsw-n3050: NOTRUN -> [FAIL][4] ([i915#6042]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-bsw-n3050/igt@i915_pm_rpm@module-reload.html * igt@i915_selftest@live@gt_heartbeat: - fi-kbl-7567u: [PASS][5] -> [DMESG-FAIL][6] ([i915#5334]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/fi-kbl-7567u/igt@i915_selftest@live@gt_heartbeat.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-kbl-7567u/igt@i915_selftest@live@gt_heartbeat.html * igt@i915_selftest@live@requests: - fi-blb-e6850: [PASS][7] -> [DMESG-FAIL][8] ([i915#4528]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/fi-blb-e6850/igt@i915_selftest@live@requests.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-blb-e6850/igt@i915_selftest@live@requests.html * igt@i915_suspend@basic-s2idle-without-i915: - bat-dg1-5: NOTRUN -> [INCOMPLETE][9] ([i915#6011]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/bat-dg1-5/igt@i915_suspend@basic-s2idle-without-i915.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-hsw-g3258: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-hsw-g3258/igt@kms_chamelium@common-hpd-after-suspend.html * igt@kms_chamelium@dp-edid-read: - fi-bsw-n3050: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827]) +8 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-bsw-n3050/igt@kms_chamelium@dp-edid-read.html * igt@kms_chamelium@hdmi-crc-fast: - fi-apl-guc: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +8 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-apl-guc/igt@kms_chamelium@hdmi-crc-fast.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions: - fi-bsw-kefka: [PASS][13] -> [FAIL][14] ([i915#6298]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html * igt@kms_flip@basic-flip-vs-modeset@b-edp1: - bat-adlp-4: [PASS][15] -> [DMESG-WARN][16] ([i915#3576]) +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/bat-adlp-4/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/bat-adlp-4/igt@kms_flip@basic-flip-vs-modeset@b-edp1.html * igt@kms_force_connector_basic@force-connector-state: - fi-apl-guc: NOTRUN -> [SKIP][17] ([fdo#109271]) +11 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-apl-guc/igt@kms_force_connector_basic@force-connector-state.html * igt@kms_frontbuffer_tracking@basic: - fi-kbl-guc: NOTRUN -> [SKIP][18] ([fdo#109271]) +1 similar issue [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-kbl-guc/igt@kms_frontbuffer_tracking@basic.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck: - fi-bsw-n3050: NOTRUN -> [SKIP][19] ([fdo#109271]) +26 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-bsw-n3050/igt@kms_pipe_crc_basic@compare-crc-sanitycheck.html #### Possible fixes #### * igt@gem_render_tiled_blits@basic: - fi-apl-guc: [INCOMPLETE][20] ([i915#6274]) -> [PASS][21] [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/fi-apl-guc/igt@gem_render_tiled_blits@basic.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-apl-guc/igt@gem_render_tiled_blits@basic.html * igt@i915_pm_rpm@module-reload: - fi-cfl-8109u: [DMESG-FAIL][22] ([i915#62]) -> [PASS][23] [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html * igt@i915_selftest@live@gt_engines: - bat-dg1-5: [INCOMPLETE][24] ([i915#4418]) -> [PASS][25] [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/bat-dg1-5/igt@i915_selftest@live@gt_engines.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/bat-dg1-5/igt@i915_selftest@live@gt_engines.html * igt@i915_selftest@live@hangcheck: - fi-hsw-g3258: [INCOMPLETE][26] ([i915#4785]) -> [PASS][27] [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html - bat-dg1-6: [DMESG-FAIL][28] ([i915#4494] / [i915#4957]) -> [PASS][29] [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/bat-dg1-6/igt@i915_selftest@live@hangcheck.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/bat-dg1-6/igt@i915_selftest@live@hangcheck.html * igt@i915_selftest@live@reset: - {bat-adlp-6}: [DMESG-FAIL][30] ([i915#4983]) -> [PASS][31] [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/bat-adlp-6/igt@i915_selftest@live@reset.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/bat-adlp-6/igt@i915_selftest@live@reset.html * igt@i915_selftest@live@ring_submission: - fi-cfl-8109u: [DMESG-WARN][32] ([i915#5904]) -> [PASS][33] +11 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html * igt@i915_suspend@basic-s2idle-without-i915: - fi-cfl-8109u: [DMESG-WARN][34] ([i915#5904] / [i915#62]) -> [PASS][35] [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size: - fi-bsw-kefka: [FAIL][36] ([i915#6298]) -> [PASS][37] [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html * igt@kms_flip@basic-flip-vs-modeset@a-edp1: - {bat-adlp-6}: [DMESG-WARN][38] ([i915#3576]) -> [PASS][39] [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html - {bat-adln-1}: [DMESG-WARN][40] ([i915#3576]) -> [PASS][41] [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/bat-adln-1/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/bat-adln-1/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html * igt@kms_frontbuffer_tracking@basic: - fi-cfl-8109u: [DMESG-WARN][42] ([i915#62]) -> [PASS][43] +12 similar issues [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576 [i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418 [i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494 [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528 [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785 [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873 [i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5174]: https://gitlab.freedesktop.org/drm/intel/issues/5174 [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190 [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274 [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 [i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763 [i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903 [i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904 [i915#6011]: https://gitlab.freedesktop.org/drm/intel/issues/6011 [i915#6042]: https://gitlab.freedesktop.org/drm/intel/issues/6042 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#6274]: https://gitlab.freedesktop.org/drm/intel/issues/6274 [i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298 Build changes ------------- * Linux: CI_DRM_11825 -> Patchwork_105773v1 CI-20190529: 20190529 CI_DRM_11825: 3d881054a2b8614e37db0453c662ead2c0fafe8d @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6551: a01ebaef40f1fa653e9d6a59b719f2d69af2b458 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_105773v1: 3d881054a2b8614e37db0453c662ead2c0fafe8d @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits aef91cde357a drm/fb-helper: Remove helpers to change frame buffer config == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/index.html [-- Attachment #2: Type: text/html, Size: 13573 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/fb-helper: Remove helpers to change frame buffer config 2022-06-29 10:56 ` Geert Uytterhoeven ` (2 preceding siblings ...) (?) @ 2022-06-30 4:51 ` Patchwork -1 siblings, 0 replies; 14+ messages in thread From: Patchwork @ 2022-06-30 4:51 UTC (permalink / raw) To: Geert Uytterhoeven; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 56571 bytes --] == Series Details == Series: drm/fb-helper: Remove helpers to change frame buffer config URL : https://patchwork.freedesktop.org/series/105773/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11825_full -> Patchwork_105773v1_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_105773v1_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_105773v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Participating hosts (13 -> 13) ------------------------------ No changes in participating hosts Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_105773v1_full: ### IGT changes ### #### Possible regressions #### * igt@kms_cursor_legacy@cursor-vs-flip@atomic: - shard-skl: NOTRUN -> [INCOMPLETE][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl1/igt@kms_cursor_legacy@cursor-vs-flip@atomic.html #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@i915_pm_rpm@gem-execbuf@lmem0: - {shard-dg1}: NOTRUN -> [FAIL][2] [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-dg1-17/igt@i915_pm_rpm@gem-execbuf@lmem0.html ### Piglit changes ### #### Possible regressions #### * spec@glsl-1.30@execution@texelfetchoffset@vs-texelfetch-usampler1d: - pig-glk-j5005: NOTRUN -> [CRASH][3] +7 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/pig-glk-j5005/spec@glsl-1.30@execution@texelfetchoffset@vs-texelfetch-usampler1d.html * spec@glsl-4.00@execution@built-in-functions@fs-outerproduct-dvec3-dvec4: - pig-skl-6260u: NOTRUN -> [CRASH][4] [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/pig-skl-6260u/spec@glsl-4.00@execution@built-in-functions@fs-outerproduct-dvec3-dvec4.html Known issues ------------ Here are the changes found in Patchwork_105773v1_full that come from known issues: ### CI changes ### #### Possible fixes #### * boot: - shard-apl: ([PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [FAIL][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29]) ([i915#4386]) -> ([PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl8/boot.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl4/boot.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl4/boot.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl6/boot.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl6/boot.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl6/boot.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl7/boot.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl7/boot.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl8/boot.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl7/boot.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl8/boot.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl7/boot.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl1/boot.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl1/boot.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl1/boot.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl2/boot.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl2/boot.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl2/boot.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl2/boot.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl2/boot.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl3/boot.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl3/boot.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl3/boot.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl4/boot.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl4/boot.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl8/boot.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl8/boot.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl8/boot.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl8/boot.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl7/boot.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl7/boot.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl7/boot.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl6/boot.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl6/boot.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl6/boot.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl6/boot.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl4/boot.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl4/boot.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl4/boot.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl3/boot.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl3/boot.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl3/boot.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl2/boot.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl2/boot.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl2/boot.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl2/boot.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl2/boot.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl1/boot.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl1/boot.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl1/boot.html ### IGT changes ### #### Issues hit #### * igt@gem_create@create-massive: - shard-skl: NOTRUN -> [DMESG-WARN][55] ([i915#4991]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl9/igt@gem_create@create-massive.html * igt@gem_ctx_persistence@smoketest: - shard-skl: NOTRUN -> [INCOMPLETE][56] ([i915#6310]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl10/igt@gem_ctx_persistence@smoketest.html * igt@gem_exec_balancer@parallel-ordering: - shard-kbl: NOTRUN -> [FAIL][57] ([i915#6117]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl1/igt@gem_exec_balancer@parallel-ordering.html * igt@gem_exec_fair@basic-none@vecs0: - shard-apl: [PASS][58] -> [FAIL][59] ([i915#2842]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl8/igt@gem_exec_fair@basic-none@vecs0.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl3/igt@gem_exec_fair@basic-none@vecs0.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-kbl: [PASS][60] -> [FAIL][61] ([i915#2842]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-kbl1/igt@gem_exec_fair@basic-pace@rcs0.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl7/igt@gem_exec_fair@basic-pace@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-glk: NOTRUN -> [FAIL][62] ([i915#2842]) +1 similar issue [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk7/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_schedule@reorder-wide@vecs0: - shard-glk: [PASS][63] -> [INCOMPLETE][64] ([i915#6310]) +1 similar issue [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-glk3/igt@gem_exec_schedule@reorder-wide@vecs0.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk7/igt@gem_exec_schedule@reorder-wide@vecs0.html * igt@gem_lmem_swapping@heavy-random: - shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#4613]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl7/igt@gem_lmem_swapping@heavy-random.html * igt@gem_lmem_swapping@heavy-verify-random-ccs: - shard-skl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#4613]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl6/igt@gem_lmem_swapping@heavy-verify-random-ccs.html * igt@gem_lmem_swapping@parallel-random: - shard-kbl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#4613]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl3/igt@gem_lmem_swapping@parallel-random.html * igt@gem_lmem_swapping@random-engines: - shard-glk: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#4613]) +2 similar issues [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk6/igt@gem_lmem_swapping@random-engines.html * igt@gem_workarounds@suspend-resume-fd: - shard-kbl: [PASS][69] -> [DMESG-WARN][70] ([i915#180]) +4 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-kbl4/igt@gem_workarounds@suspend-resume-fd.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl6/igt@gem_workarounds@suspend-resume-fd.html * igt@gen9_exec_parse@allowed-single: - shard-skl: [PASS][71] -> [DMESG-WARN][72] ([i915#5566] / [i915#716]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-skl1/igt@gen9_exec_parse@allowed-single.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl7/igt@gen9_exec_parse@allowed-single.html * igt@i915_module_load@reload-with-fault-injection: - shard-snb: [PASS][73] -> [DMESG-WARN][74] ([i915#6201]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-snb7/igt@i915_module_load@reload-with-fault-injection.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-snb5/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [PASS][75] -> [FAIL][76] ([i915#454]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-iclb1/igt@i915_pm_dc@dc6-psr.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-iclb3/igt@i915_pm_dc@dc6-psr.html * igt@i915_pm_dc@dc9-dpms: - shard-iclb: [PASS][77] -> [SKIP][78] ([i915#4281]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-iclb8/igt@i915_pm_dc@dc9-dpms.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html * igt@i915_pm_rpm@gem-execbuf-stress-pc8: - shard-glk: NOTRUN -> [SKIP][79] ([fdo#109271]) +127 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk7/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html * igt@i915_selftest@live@hangcheck: - shard-tglb: [PASS][80] -> [DMESG-WARN][81] ([i915#5591]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-tglb2/igt@i915_selftest@live@hangcheck.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-tglb3/igt@i915_selftest@live@hangcheck.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [PASS][82] -> [DMESG-WARN][83] ([i915#180]) +2 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@i915_suspend@forcewake: - shard-glk: [PASS][84] -> [SKIP][85] ([fdo#109271]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-glk9/igt@i915_suspend@forcewake.html [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk3/igt@i915_suspend@forcewake.html * igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs: - shard-skl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#3886]) +3 similar issues [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl1/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs: - shard-kbl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#3886]) +1 similar issue [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl3/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs: - shard-glk: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#3886]) +3 similar issues [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk6/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc: - shard-apl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#3886]) +1 similar issue [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl7/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html * igt@kms_chamelium@dp-hpd-enable-disable-mode: - shard-glk: NOTRUN -> [SKIP][90] ([fdo#109271] / [fdo#111827]) +11 similar issues [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk3/igt@kms_chamelium@dp-hpd-enable-disable-mode.html * igt@kms_chamelium@dp-hpd-for-each-pipe: - shard-kbl: NOTRUN -> [SKIP][91] ([fdo#109271] / [fdo#111827]) +3 similar issues [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl3/igt@kms_chamelium@dp-hpd-for-each-pipe.html - shard-snb: NOTRUN -> [SKIP][92] ([fdo#109271] / [fdo#111827]) +1 similar issue [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-snb2/igt@kms_chamelium@dp-hpd-for-each-pipe.html * igt@kms_chamelium@hdmi-crc-multiple: - shard-skl: NOTRUN -> [SKIP][93] ([fdo#109271] / [fdo#111827]) +9 similar issues [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl1/igt@kms_chamelium@hdmi-crc-multiple.html * igt@kms_color_chamelium@pipe-d-ctm-red-to-blue: - shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271] / [fdo#111827]) +2 similar issues [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl7/igt@kms_color_chamelium@pipe-d-ctm-red-to-blue.html * igt@kms_content_protection@atomic: - shard-apl: NOTRUN -> [TIMEOUT][95] ([i915#1319]) [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl7/igt@kms_content_protection@atomic.html * igt@kms_content_protection@legacy: - shard-kbl: NOTRUN -> [TIMEOUT][96] ([i915#1319]) [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl3/igt@kms_content_protection@legacy.html * igt@kms_draw_crc@draw-method-xrgb8888-pwrite-4tiled: - shard-skl: NOTRUN -> [SKIP][97] ([fdo#109271]) +110 similar issues [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl10/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-4tiled.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-apl: [PASS][98] -> [FAIL][99] ([i915#4767]) [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl7/igt@kms_fbcon_fbt@fbc-suspend.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl3/igt@kms_fbcon_fbt@fbc-suspend.html - shard-glk: NOTRUN -> [FAIL][100] ([i915#4767]) [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk7/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-apl: [PASS][101] -> [DMESG-WARN][102] ([i915#180] / [i915#1982]) [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@plain-flip-fb-recreate@c-edp1: - shard-skl: [PASS][103] -> [FAIL][104] ([i915#2122]) [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-skl6/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl6/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen: - shard-skl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#1888]) +3 similar issues [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-blt: - shard-apl: NOTRUN -> [SKIP][106] ([fdo#109271]) +47 similar issues [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff: - shard-kbl: NOTRUN -> [SKIP][107] ([fdo#109271]) +92 similar issues [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff.html * igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-blt: - shard-snb: NOTRUN -> [SKIP][108] ([fdo#109271]) +37 similar issues [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-snb2/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-blt.html * igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1: - shard-kbl: [PASS][109] -> [FAIL][110] ([i915#1188]) [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-kbl7/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl7/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html * igt@kms_plane_alpha_blend@pipe-a-alpha-basic: - shard-skl: NOTRUN -> [FAIL][111] ([fdo#108145] / [i915#265]) +2 similar issues [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-b-alpha-basic: - shard-glk: NOTRUN -> [FAIL][112] ([fdo#108145] / [i915#265]) [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk3/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb: - shard-glk: NOTRUN -> [FAIL][113] ([i915#265]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk6/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1: - shard-iclb: [PASS][114] -> [SKIP][115] ([i915#5235]) +2 similar issues [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-iclb5/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area: - shard-kbl: NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#658]) [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area: - shard-skl: NOTRUN -> [SKIP][117] ([fdo#109271] / [i915#658]) [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl9/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html * igt@kms_psr2_su@page_flip-nv12: - shard-glk: NOTRUN -> [SKIP][118] ([fdo#109271] / [i915#658]) +3 similar issues [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk3/igt@kms_psr2_su@page_flip-nv12.html * igt@kms_psr@psr2_suspend: - shard-iclb: [PASS][119] -> [SKIP][120] ([fdo#109441]) +1 similar issue [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-iclb2/igt@kms_psr@psr2_suspend.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-iclb1/igt@kms_psr@psr2_suspend.html * igt@kms_psr_stress_test@flip-primary-invalidate-overlay: - shard-iclb: [PASS][121] -> [SKIP][122] ([i915#5519]) [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-iclb3/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-iclb6/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html * igt@kms_writeback@writeback-check-output: - shard-kbl: NOTRUN -> [SKIP][123] ([fdo#109271] / [i915#2437]) [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl1/igt@kms_writeback@writeback-check-output.html * igt@perf_pmu@rc6-suspend: - shard-skl: [PASS][124] -> [INCOMPLETE][125] ([i915#4939]) +2 similar issues [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-skl6/igt@perf_pmu@rc6-suspend.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl3/igt@perf_pmu@rc6-suspend.html * igt@sysfs_clients@fair-3: - shard-glk: NOTRUN -> [SKIP][126] ([fdo#109271] / [i915#2994]) [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk6/igt@sysfs_clients@fair-3.html * igt@sysfs_clients@recycle-many: - shard-kbl: NOTRUN -> [SKIP][127] ([fdo#109271] / [i915#2994]) +1 similar issue [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl4/igt@sysfs_clients@recycle-many.html - shard-skl: NOTRUN -> [SKIP][128] ([fdo#109271] / [i915#2994]) [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl6/igt@sysfs_clients@recycle-many.html #### Possible fixes #### * igt@fbdev@unaligned-write: - {shard-rkl}: [SKIP][129] ([i915#2582]) -> [PASS][130] [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@fbdev@unaligned-write.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@fbdev@unaligned-write.html * igt@gem_ctx_exec@basic-nohangcheck: - shard-tglb: [FAIL][131] ([i915#6268]) -> [PASS][132] [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-tglb2/igt@gem_ctx_exec@basic-nohangcheck.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-tglb3/igt@gem_ctx_exec@basic-nohangcheck.html - {shard-rkl}: [FAIL][133] ([i915#6268]) -> [PASS][134] [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-2/igt@gem_ctx_exec@basic-nohangcheck.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-5/igt@gem_ctx_exec@basic-nohangcheck.html * igt@gem_ctx_persistence@hostile: - {shard-rkl}: [FAIL][135] ([i915#2410]) -> [PASS][136] [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@gem_ctx_persistence@hostile.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-5/igt@gem_ctx_persistence@hostile.html * igt@gem_eio@unwedge-stress: - {shard-tglu}: [TIMEOUT][137] ([i915#3063]) -> [PASS][138] [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-tglu-1/igt@gem_eio@unwedge-stress.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-tglu-3/igt@gem_eio@unwedge-stress.html * igt@gem_exec_balancer@parallel-keep-submit-fence: - shard-iclb: [SKIP][139] ([i915#4525]) -> [PASS][140] +1 similar issue [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-iclb6/igt@gem_exec_balancer@parallel-keep-submit-fence.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-iclb1/igt@gem_exec_balancer@parallel-keep-submit-fence.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-tglb: [FAIL][141] ([i915#2842]) -> [PASS][142] [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-tglb3/igt@gem_exec_fair@basic-none-share@rcs0.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-tglb5/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none@vcs0: - shard-apl: [FAIL][143] ([i915#2842]) -> [PASS][144] [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-apl8/igt@gem_exec_fair@basic-none@vcs0.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-apl3/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-kbl: [FAIL][145] ([i915#2842]) -> [PASS][146] [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs0.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_reloc@basic-wc: - {shard-rkl}: [SKIP][147] ([i915#3281]) -> [PASS][148] +11 similar issues [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-2/igt@gem_exec_reloc@basic-wc.html [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-5/igt@gem_exec_reloc@basic-wc.html * igt@gem_exec_schedule@semaphore-power: - {shard-rkl}: [SKIP][149] ([fdo#110254]) -> [PASS][150] [149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-6/igt@gem_exec_schedule@semaphore-power.html [150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-5/igt@gem_exec_schedule@semaphore-power.html * igt@gem_exec_whisper@basic-contexts-priority-all: - shard-glk: [DMESG-WARN][151] ([i915#118]) -> [PASS][152] [151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-glk8/igt@gem_exec_whisper@basic-contexts-priority-all.html [152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk2/igt@gem_exec_whisper@basic-contexts-priority-all.html * igt@gem_exec_whisper@basic-fds-priority-all: - shard-glk: [INCOMPLETE][153] ([i915#6310]) -> [PASS][154] +1 similar issue [153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-glk6/igt@gem_exec_whisper@basic-fds-priority-all.html [154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk7/igt@gem_exec_whisper@basic-fds-priority-all.html * igt@gem_partial_pwrite_pread@writes-after-reads-display: - {shard-rkl}: [SKIP][155] ([i915#3282]) -> [PASS][156] +3 similar issues [155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-6/igt@gem_partial_pwrite_pread@writes-after-reads-display.html [156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads-display.html * igt@gen9_exec_parse@shadow-peek: - {shard-rkl}: [SKIP][157] ([i915#2527]) -> [PASS][158] +5 similar issues [157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-2/igt@gen9_exec_parse@shadow-peek.html [158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-5/igt@gen9_exec_parse@shadow-peek.html * igt@i915_module_load@reload-no-display: - {shard-tglu}: [FAIL][159] -> [PASS][160] [159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-tglu-8/igt@i915_module_load@reload-no-display.html [160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-tglu-8/igt@i915_module_load@reload-no-display.html * igt@i915_pm_backlight@fade_with_dpms: - {shard-rkl}: [SKIP][161] ([i915#3012]) -> [PASS][162] [161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@i915_pm_backlight@fade_with_dpms.html [162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@i915_pm_backlight@fade_with_dpms.html * igt@i915_pm_rpm@dpms-lpsp: - {shard-rkl}: [SKIP][163] ([i915#1397]) -> [PASS][164] +1 similar issue [163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@i915_pm_rpm@dpms-lpsp.html [164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@i915_pm_rpm@dpms-lpsp.html * igt@i915_pm_rpm@system-suspend-modeset: - shard-skl: [INCOMPLETE][165] ([i915#5420]) -> [PASS][166] [165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-skl7/igt@i915_pm_rpm@system-suspend-modeset.html [166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl1/igt@i915_pm_rpm@system-suspend-modeset.html * igt@i915_pm_sseu@full-enable: - {shard-rkl}: [SKIP][167] ([i915#4387]) -> [PASS][168] [167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-2/igt@i915_pm_sseu@full-enable.html [168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-5/igt@i915_pm_sseu@full-enable.html * igt@i915_selftest@live@hangcheck: - shard-snb: [INCOMPLETE][169] ([i915#3921]) -> [PASS][170] [169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-snb4/igt@i915_selftest@live@hangcheck.html [170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-snb2/igt@i915_selftest@live@hangcheck.html * igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1: - shard-skl: [FAIL][171] ([i915#2521]) -> [PASS][172] [171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-skl4/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1.html [172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl10/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1.html * igt@kms_atomic@atomic_plane_damage: - {shard-rkl}: [SKIP][173] ([i915#4098]) -> [PASS][174] [173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@kms_atomic@atomic_plane_damage.html [174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@kms_atomic@atomic_plane_damage.html * igt@kms_color@pipe-b-ctm-green-to-red: - {shard-rkl}: [SKIP][175] ([i915#1149] / [i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][176] [175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@kms_color@pipe-b-ctm-green-to-red.html [176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@kms_color@pipe-b-ctm-green-to-red.html * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size: - shard-glk: [FAIL][177] ([i915#2346]) -> [PASS][178] [177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html [178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html * igt@kms_cursor_legacy@flip-vs-cursor@toggle: - shard-iclb: [FAIL][179] -> [PASS][180] +2 similar issues [179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor@toggle.html [180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-iclb8/igt@kms_cursor_legacy@flip-vs-cursor@toggle.html * igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled: - {shard-rkl}: [SKIP][181] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][182] +1 similar issue [181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled.html [182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1: - shard-skl: [FAIL][183] ([i915#79]) -> [PASS][184] [183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html [184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-edp1: - shard-skl: [INCOMPLETE][185] ([i915#1982] / [i915#5864]) -> [PASS][186] [185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-skl1/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html [186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl6/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1: - shard-kbl: [DMESG-WARN][187] ([i915#180]) -> [PASS][188] +6 similar issues [187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html [188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1: - shard-tglb: [FAIL][189] -> [PASS][190] [189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-tglb7/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html [190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-tglb7/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html * igt@kms_flip@plain-flip-ts-check@a-edp1: - shard-skl: [FAIL][191] ([i915#2122]) -> [PASS][192] [191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-skl10/igt@kms_flip@plain-flip-ts-check@a-edp1.html [192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl9/igt@kms_flip@plain-flip-ts-check@a-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling: - shard-iclb: [SKIP][193] ([i915#3701]) -> [PASS][194] [193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html [194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-upscaling: - {shard-rkl}: [SKIP][195] ([i915#3701]) -> [PASS][196] [195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-upscaling.html [196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-upscaling.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-msflip-blt: - {shard-rkl}: [SKIP][197] ([i915#1849] / [i915#4098]) -> [PASS][198] +18 similar issues [197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-msflip-blt.html [198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-msflip-blt.html * igt@kms_invalid_mode@bad-vsync-end: - {shard-rkl}: [SKIP][199] ([i915#4278]) -> [PASS][200] [199]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@kms_invalid_mode@bad-vsync-end.html [200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@kms_invalid_mode@bad-vsync-end.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid: - {shard-rkl}: [SKIP][201] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][202] +1 similar issue [201]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid.html [202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid.html * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1: - shard-iclb: [SKIP][203] ([i915#5235]) -> [PASS][204] +2 similar issues [203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-iclb2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html [204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-iclb3/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1.html * igt@kms_psr@psr2_cursor_blt: - shard-iclb: [SKIP][205] ([fdo#109441]) -> [PASS][206] +1 similar issue [205]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-iclb5/igt@kms_psr@psr2_cursor_blt.html [206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html * igt@kms_psr@sprite_blt: - {shard-rkl}: [SKIP][207] ([i915#1072]) -> [PASS][208] +1 similar issue [207]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@kms_psr@sprite_blt.html [208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@kms_psr@sprite_blt.html * igt@kms_psr_stress_test@flip-primary-invalidate-overlay: - {shard-rkl}: [SKIP][209] ([i915#5461]) -> [PASS][210] [209]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html [210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html * igt@kms_universal_plane@disable-primary-vs-flip-pipe-b: - {shard-rkl}: [SKIP][211] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][212] [211]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@kms_universal_plane@disable-primary-vs-flip-pipe-b.html [212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@kms_universal_plane@disable-primary-vs-flip-pipe-b.html * igt@kms_vblank@pipe-b-query-forked: - {shard-rkl}: [SKIP][213] ([i915#1845] / [i915#4098]) -> [PASS][214] +21 similar issues [213]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@kms_vblank@pipe-b-query-forked.html [214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@kms_vblank@pipe-b-query-forked.html * igt@kms_vblank@pipe-d-ts-continuation-modeset-rpm: - {shard-tglu}: [SKIP][215] -> [PASS][216] +2 similar issues [215]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-tglu-8/igt@kms_vblank@pipe-d-ts-continuation-modeset-rpm.html [216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-tglu-8/igt@kms_vblank@pipe-d-ts-continuation-modeset-rpm.html * igt@perf@gen12-unprivileged-single-ctx-counters: - {shard-rkl}: [SKIP][217] ([fdo#109289]) -> [PASS][218] [217]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-5/igt@perf@gen12-unprivileged-single-ctx-counters.html [218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-1/igt@perf@gen12-unprivileged-single-ctx-counters.html * igt@perf@gen8-unprivileged-single-ctx-counters: - {shard-rkl}: [SKIP][219] ([i915#2436]) -> [PASS][220] [219]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-2/igt@perf@gen8-unprivileged-single-ctx-counters.html [220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-5/igt@perf@gen8-unprivileged-single-ctx-counters.html * igt@prime_vgem@basic-fence-flip: - {shard-rkl}: [SKIP][221] ([fdo#109295] / [i915#3708] / [i915#4098]) -> [PASS][222] [221]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-1/igt@prime_vgem@basic-fence-flip.html [222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-6/igt@prime_vgem@basic-fence-flip.html * igt@prime_vgem@basic-read: - {shard-rkl}: [SKIP][223] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][224] [223]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-rkl-6/igt@prime_vgem@basic-read.html [224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-rkl-5/igt@prime_vgem@basic-read.html * igt@sysfs_heartbeat_interval@precise@vecs0: - shard-kbl: [FAIL][225] ([i915#1755]) -> [PASS][226] [225]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-kbl4/igt@sysfs_heartbeat_interval@precise@vecs0.html [226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl1/igt@sysfs_heartbeat_interval@precise@vecs0.html #### Warnings #### * igt@gem_eio@kms: - shard-tglb: [TIMEOUT][227] ([i915#3063]) -> [FAIL][228] ([i915#5784]) [227]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-tglb5/igt@gem_eio@kms.html [228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-tglb2/igt@gem_eio@kms.html * igt@gem_exec_balancer@parallel-ordering: - shard-iclb: [SKIP][229] ([i915#4525]) -> [FAIL][230] ([i915#6117]) [229]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-iclb6/igt@gem_exec_balancer@parallel-ordering.html [230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-iclb1/igt@gem_exec_balancer@parallel-ordering.html * igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf: - shard-iclb: [SKIP][231] ([i915#658]) -> [SKIP][232] ([i915#2920]) [231]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-iclb5/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html [232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html * igt@kms_psr2_sf@cursor-plane-update-sf: - shard-iclb: [SKIP][233] ([i915#2920]) -> [SKIP][234] ([fdo#111068] / [i915#658]) [233]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html [234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-iclb3/igt@kms_psr2_sf@cursor-plane-update-sf.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area: - shard-iclb: [SKIP][235] ([fdo#111068] / [i915#658]) -> [SKIP][236] ([i915#2920]) [235]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-iclb5/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html [236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html * igt@kms_vblank@pipe-c-ts-continuation-suspend: - shard-kbl: [DMESG-WARN][237] ([i915#180]) -> [INCOMPLETE][238] ([i915#4939] / [i915#794]) [237]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-kbl6/igt@kms_vblank@pipe-c-ts-continuation-suspend.html [238]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-kbl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html * igt@runner@aborted: - shard-skl: ([FAIL][239], [FAIL][240]) ([i915#2029] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][241], [FAIL][242], [FAIL][243], [FAIL][244]) ([i915#3002] / [i915#4312] / [i915#5257]) [239]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-skl4/igt@runner@aborted.html [240]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11825/shard-skl3/igt@runner@aborted.html [241]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl7/igt@runner@aborted.html [242]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl9/igt@runner@aborted.html [243]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl1/igt@runner@aborted.html [244]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/shard-skl10/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312 [fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 [i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755 [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410 [i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002 [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012 [i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921 [i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936 [i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938 [i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278 [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369 [i915#4386]: https://gitlab.freedesktop.org/drm/intel/issues/4386 [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387 [i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418 [i915#4462]: https://gitlab.freedesktop.org/drm/intel/issues/4462 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767 [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4853]: https://gitlab.freedesktop.org/drm/intel/issues/4853 [i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854 [i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859 [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860 [i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883 [i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884 [i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885 [i915#4893]: https://gitlab.freedesktop.org/drm/intel/issues/4893 [i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939 [i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991 [i915#5030]: https://gitlab.freedesktop.org/drm/intel/issues/5030 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287 [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5420]: https://gitlab.freedesktop.org/drm/intel/issues/5420 [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461 [i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519 [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591 [i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#5864]: https://gitlab.freedesktop.org/drm/intel/issues/5864 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117 [i915#6140]: https://gitlab.freedesktop.org/drm/intel/issues/6140 [i915#6201]: https://gitlab.freedesktop.org/drm/intel/issues/6201 [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248 [i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251 [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268 [i915#6310]: https://gitlab.freedesktop.org/drm/intel/issues/6310 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#794]: https://gitlab.freedesktop.org/drm/intel/issues/794 Build changes ------------- * Linux: CI_DRM_11825 -> Patchwork_105773v1 CI-20190529: 20190529 CI_DRM_11825: 3d881054a2b8614e37db0453c662ead2c0fafe8d @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6551: a01ebaef40f1fa653e9d6a59b719f2d69af2b458 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_105773v1: 3d881054a2b8614e37db0453c662ead2c0fafe8d @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_105773v1/index.html [-- Attachment #2: Type: text/html, Size: 61098 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/fb-helper: Remove helpers to change frame buffer config 2022-06-29 10:56 ` Geert Uytterhoeven (?) @ 2022-07-02 18:05 ` Helge Deller -1 siblings, 0 replies; 14+ messages in thread From: Helge Deller @ 2022-07-02 18:05 UTC (permalink / raw) To: Geert Uytterhoeven, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Tomi Valkeinen Cc: Greg Kroah-Hartman, dri-devel, intel-gfx, linux-fbdev, linux-kernel On 6/29/22 12:56, Geert Uytterhoeven wrote: > The DRM fbdev emulation layer does not support pushing back > changes to fb_var_screeninfo to KMS. > > However, drm_fb_helper still implements the fb_ops.fb_check_var() and > fb_ops.fb_set_par() callbacks, but the former fails to validate various > parameters passed from userspace. Hence unsanitized and possible > invaled values are passed up through the fbdev, fbcon, and console > stack, which has become an endless source of security issues reported > against fbdev. > > Fix this by not populating the fb_ops.fb_check_var() and > fb_ops.fb_set_par() callbacks, as there is no point in providing them if > the frame buffer config cannot be changed anyway. This makes the fbdev > core aware that making changes to the frame buffer config is not > supported, so it will always return the current config. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> It's unfortunate that DRM currently isn't able to switch resolutions at runtime. With that in mind I agree with Geert that it's probably better to disable (or drop) that code until DRM can cope with fbdev's interface to switch resolutions. Furthermore, with the upcoming patches to fbcon (which prevents crashes on invalid userspace input), you will face a kernel WARNING if you call fbset to switch screen resolutions with DRM drivers. So, from my side (although I'd prefer a better fix for DRM): Acked-by: Helge Deller <deller@gmx.de> Helge > --- > The only remaining DRM driver that implements fb_ops.fb_check_var() is > also broken, as it fails to validate various parameters passed from > userspace. So vmw_fb_check_var() should either be fixed, or removed. > --- > drivers/gpu/drm/drm_fb_helper.c | 180 ++------------------- > drivers/gpu/drm/i915/display/intel_fbdev.c | 15 -- > drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 - > include/drm/drm_fb_helper.h | 16 -- > 4 files changed, 13 insertions(+), 200 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 2d4cee6a10ffffe7..1041a11c410d7967 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -228,9 +228,18 @@ int drm_fb_helper_debug_leave(struct fb_info *info) > } > EXPORT_SYMBOL(drm_fb_helper_debug_leave); > > -static int > -__drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > - bool force) > +/** > + * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration > + * @fb_helper: driver-allocated fbdev helper, can be NULL > + * > + * This should be called from driver's drm &drm_driver.lastclose callback > + * when implementing an fbcon on top of kms using this helper. This ensures that > + * the user isn't greeted with a black screen when e.g. X dies. > + * > + * RETURNS: > + * Zero if everything went ok, negative error code otherwise. > + */ > +int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > { > bool do_delayed; > int ret; > @@ -242,16 +251,7 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > return 0; > > mutex_lock(&fb_helper->lock); > - if (force) { > - /* > - * Yes this is the _locked version which expects the master lock > - * to be held. But for forced restores we're intentionally > - * racing here, see drm_fb_helper_set_par(). > - */ > - ret = drm_client_modeset_commit_locked(&fb_helper->client); > - } else { > - ret = drm_client_modeset_commit(&fb_helper->client); > - } > + ret = drm_client_modeset_commit(&fb_helper->client); > > do_delayed = fb_helper->delayed_hotplug; > if (do_delayed) > @@ -263,22 +263,6 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > > return ret; > } > - > -/** > - * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration > - * @fb_helper: driver-allocated fbdev helper, can be NULL > - * > - * This should be called from driver's drm &drm_driver.lastclose callback > - * when implementing an fbcon on top of kms using this helper. This ensures that > - * the user isn't greeted with a black screen when e.g. X dies. > - * > - * RETURNS: > - * Zero if everything went ok, negative error code otherwise. > - */ > -int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > -{ > - return __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, false); > -} > EXPORT_SYMBOL(drm_fb_helper_restore_fbdev_mode_unlocked); > > #ifdef CONFIG_MAGIC_SYSRQ > @@ -1254,25 +1238,6 @@ int drm_fb_helper_ioctl(struct fb_info *info, unsigned int cmd, > } > EXPORT_SYMBOL(drm_fb_helper_ioctl); > > -static bool drm_fb_pixel_format_equal(const struct fb_var_screeninfo *var_1, > - const struct fb_var_screeninfo *var_2) > -{ > - return var_1->bits_per_pixel == var_2->bits_per_pixel && > - var_1->grayscale == var_2->grayscale && > - var_1->red.offset == var_2->red.offset && > - var_1->red.length == var_2->red.length && > - var_1->red.msb_right == var_2->red.msb_right && > - var_1->green.offset == var_2->green.offset && > - var_1->green.length == var_2->green.length && > - var_1->green.msb_right == var_2->green.msb_right && > - var_1->blue.offset == var_2->blue.offset && > - var_1->blue.length == var_2->blue.length && > - var_1->blue.msb_right == var_2->blue.msb_right && > - var_1->transp.offset == var_2->transp.offset && > - var_1->transp.length == var_2->transp.length && > - var_1->transp.msb_right == var_2->transp.msb_right; > -} > - > static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, > u8 depth) > { > @@ -1331,123 +1296,6 @@ static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, > } > } > > -/** > - * drm_fb_helper_check_var - implementation for &fb_ops.fb_check_var > - * @var: screeninfo to check > - * @info: fbdev registered by the helper > - */ > -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > - struct fb_info *info) > -{ > - struct drm_fb_helper *fb_helper = info->par; > - struct drm_framebuffer *fb = fb_helper->fb; > - struct drm_device *dev = fb_helper->dev; > - > - if (in_dbg_master()) > - return -EINVAL; > - > - if (var->pixclock != 0) { > - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel clock, value of pixclock is ignored\n"); > - var->pixclock = 0; > - } > - > - if ((drm_format_info_block_width(fb->format, 0) > 1) || > - (drm_format_info_block_height(fb->format, 0) > 1)) > - return -EINVAL; > - > - /* > - * Changes struct fb_var_screeninfo are currently not pushed back > - * to KMS, hence fail if different settings are requested. > - */ > - if (var->bits_per_pixel > fb->format->cpp[0] * 8 || > - var->xres > fb->width || var->yres > fb->height || > - var->xres_virtual > fb->width || var->yres_virtual > fb->height) { > - drm_dbg_kms(dev, "fb requested width/height/bpp can't fit in current fb " > - "request %dx%d-%d (virtual %dx%d) > %dx%d-%d\n", > - var->xres, var->yres, var->bits_per_pixel, > - var->xres_virtual, var->yres_virtual, > - fb->width, fb->height, fb->format->cpp[0] * 8); > - return -EINVAL; > - } > - > - /* > - * Workaround for SDL 1.2, which is known to be setting all pixel format > - * fields values to zero in some cases. We treat this situation as a > - * kind of "use some reasonable autodetected values". > - */ > - if (!var->red.offset && !var->green.offset && > - !var->blue.offset && !var->transp.offset && > - !var->red.length && !var->green.length && > - !var->blue.length && !var->transp.length && > - !var->red.msb_right && !var->green.msb_right && > - !var->blue.msb_right && !var->transp.msb_right) { > - drm_fb_helper_fill_pixel_fmt(var, fb->format->depth); > - } > - > - /* > - * Likewise, bits_per_pixel should be rounded up to a supported value. > - */ > - var->bits_per_pixel = fb->format->cpp[0] * 8; > - > - /* > - * drm fbdev emulation doesn't support changing the pixel format at all, > - * so reject all pixel format changing requests. > - */ > - if (!drm_fb_pixel_format_equal(var, &info->var)) { > - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel format\n"); > - return -EINVAL; > - } > - > - return 0; > -} > -EXPORT_SYMBOL(drm_fb_helper_check_var); > - > -/** > - * drm_fb_helper_set_par - implementation for &fb_ops.fb_set_par > - * @info: fbdev registered by the helper > - * > - * This will let fbcon do the mode init and is called at initialization time by > - * the fbdev core when registering the driver, and later on through the hotplug > - * callback. > - */ > -int drm_fb_helper_set_par(struct fb_info *info) > -{ > - struct drm_fb_helper *fb_helper = info->par; > - struct fb_var_screeninfo *var = &info->var; > - bool force; > - > - if (oops_in_progress) > - return -EBUSY; > - > - if (var->pixclock != 0) { > - drm_err(fb_helper->dev, "PIXEL CLOCK SET\n"); > - return -EINVAL; > - } > - > - /* > - * Normally we want to make sure that a kms master takes precedence over > - * fbdev, to avoid fbdev flickering and occasionally stealing the > - * display status. But Xorg first sets the vt back to text mode using > - * the KDSET IOCTL with KD_TEXT, and only after that drops the master > - * status when exiting. > - * > - * In the past this was caught by drm_fb_helper_lastclose(), but on > - * modern systems where logind always keeps a drm fd open to orchestrate > - * the vt switching, this doesn't work. > - * > - * To not break the userspace ABI we have this special case here, which > - * is only used for the above case. Everything else uses the normal > - * commit function, which ensures that we never steal the display from > - * an active drm master. > - */ > - force = var->activate & FB_ACTIVATE_KD_TEXT; > - > - __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, force); > - > - return 0; > -} > -EXPORT_SYMBOL(drm_fb_helper_set_par); > - > static void pan_set(struct drm_fb_helper *fb_helper, int x, int y) > { > struct drm_mode_set *mode_set; > @@ -2028,8 +1876,6 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper) > drm_setup_crtcs_fb(fb_helper); > mutex_unlock(&fb_helper->lock); > > - drm_fb_helper_set_par(fb_helper->fbdev); > - > return 0; > } > EXPORT_SYMBOL(drm_fb_helper_hotplug_event); > diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c > index 221336178991f04f..26dbe9487c79ae1b 100644 > --- a/drivers/gpu/drm/i915/display/intel_fbdev.c > +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c > @@ -77,20 +77,6 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev) > intel_frontbuffer_invalidate(to_frontbuffer(ifbdev), ORIGIN_CPU); > } > > -static int intel_fbdev_set_par(struct fb_info *info) > -{ > - struct drm_fb_helper *fb_helper = info->par; > - struct intel_fbdev *ifbdev = > - container_of(fb_helper, struct intel_fbdev, helper); > - int ret; > - > - ret = drm_fb_helper_set_par(info); > - if (ret == 0) > - intel_fbdev_invalidate(ifbdev); > - > - return ret; > -} > - > static int intel_fbdev_blank(int blank, struct fb_info *info) > { > struct drm_fb_helper *fb_helper = info->par; > @@ -123,7 +109,6 @@ static int intel_fbdev_pan_display(struct fb_var_screeninfo *var, > static const struct fb_ops intelfb_ops = { > .owner = THIS_MODULE, > DRM_FB_HELPER_DEFAULT_OPS, > - .fb_set_par = intel_fbdev_set_par, > .fb_fillrect = drm_fb_helper_cfb_fillrect, > .fb_copyarea = drm_fb_helper_cfb_copyarea, > .fb_imageblit = drm_fb_helper_cfb_imageblit, > diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c > index 40706c5aad7b5c9b..2df8875baaca10b6 100644 > --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c > +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c > @@ -74,8 +74,6 @@ static int omap_fbdev_pan_display(struct fb_var_screeninfo *var, > static const struct fb_ops omap_fb_ops = { > .owner = THIS_MODULE, > > - .fb_check_var = drm_fb_helper_check_var, > - .fb_set_par = drm_fb_helper_set_par, > .fb_setcmap = drm_fb_helper_setcmap, > .fb_blank = drm_fb_helper_blank, > .fb_pan_display = omap_fbdev_pan_display, > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h > index 329607ca65c06684..19b40adc156295a1 100644 > --- a/include/drm/drm_fb_helper.h > +++ b/include/drm/drm_fb_helper.h > @@ -200,8 +200,6 @@ drm_fb_helper_from_client(struct drm_client_dev *client) > * functions. To be used in struct fb_ops of drm drivers. > */ > #define DRM_FB_HELPER_DEFAULT_OPS \ > - .fb_check_var = drm_fb_helper_check_var, \ > - .fb_set_par = drm_fb_helper_set_par, \ > .fb_setcmap = drm_fb_helper_setcmap, \ > .fb_blank = drm_fb_helper_blank, \ > .fb_pan_display = drm_fb_helper_pan_display, \ > @@ -217,9 +215,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *helper); > int drm_fb_helper_blank(int blank, struct fb_info *info); > int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, > struct fb_info *info); > -int drm_fb_helper_set_par(struct fb_info *info); > -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > - struct fb_info *info); > > int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper); > > @@ -303,17 +298,6 @@ static inline int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, > return 0; > } > > -static inline int drm_fb_helper_set_par(struct fb_info *info) > -{ > - return 0; > -} > - > -static inline int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > - struct fb_info *info) > -{ > - return 0; > -} > - > static inline int > drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > { ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/fb-helper: Remove helpers to change frame buffer config @ 2022-07-02 18:05 ` Helge Deller 0 siblings, 0 replies; 14+ messages in thread From: Helge Deller @ 2022-07-02 18:05 UTC (permalink / raw) To: Geert Uytterhoeven, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Tomi Valkeinen Cc: Greg Kroah-Hartman, intel-gfx, linux-fbdev, dri-devel, linux-kernel On 6/29/22 12:56, Geert Uytterhoeven wrote: > The DRM fbdev emulation layer does not support pushing back > changes to fb_var_screeninfo to KMS. > > However, drm_fb_helper still implements the fb_ops.fb_check_var() and > fb_ops.fb_set_par() callbacks, but the former fails to validate various > parameters passed from userspace. Hence unsanitized and possible > invaled values are passed up through the fbdev, fbcon, and console > stack, which has become an endless source of security issues reported > against fbdev. > > Fix this by not populating the fb_ops.fb_check_var() and > fb_ops.fb_set_par() callbacks, as there is no point in providing them if > the frame buffer config cannot be changed anyway. This makes the fbdev > core aware that making changes to the frame buffer config is not > supported, so it will always return the current config. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> It's unfortunate that DRM currently isn't able to switch resolutions at runtime. With that in mind I agree with Geert that it's probably better to disable (or drop) that code until DRM can cope with fbdev's interface to switch resolutions. Furthermore, with the upcoming patches to fbcon (which prevents crashes on invalid userspace input), you will face a kernel WARNING if you call fbset to switch screen resolutions with DRM drivers. So, from my side (although I'd prefer a better fix for DRM): Acked-by: Helge Deller <deller@gmx.de> Helge > --- > The only remaining DRM driver that implements fb_ops.fb_check_var() is > also broken, as it fails to validate various parameters passed from > userspace. So vmw_fb_check_var() should either be fixed, or removed. > --- > drivers/gpu/drm/drm_fb_helper.c | 180 ++------------------- > drivers/gpu/drm/i915/display/intel_fbdev.c | 15 -- > drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 - > include/drm/drm_fb_helper.h | 16 -- > 4 files changed, 13 insertions(+), 200 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 2d4cee6a10ffffe7..1041a11c410d7967 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -228,9 +228,18 @@ int drm_fb_helper_debug_leave(struct fb_info *info) > } > EXPORT_SYMBOL(drm_fb_helper_debug_leave); > > -static int > -__drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > - bool force) > +/** > + * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration > + * @fb_helper: driver-allocated fbdev helper, can be NULL > + * > + * This should be called from driver's drm &drm_driver.lastclose callback > + * when implementing an fbcon on top of kms using this helper. This ensures that > + * the user isn't greeted with a black screen when e.g. X dies. > + * > + * RETURNS: > + * Zero if everything went ok, negative error code otherwise. > + */ > +int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > { > bool do_delayed; > int ret; > @@ -242,16 +251,7 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > return 0; > > mutex_lock(&fb_helper->lock); > - if (force) { > - /* > - * Yes this is the _locked version which expects the master lock > - * to be held. But for forced restores we're intentionally > - * racing here, see drm_fb_helper_set_par(). > - */ > - ret = drm_client_modeset_commit_locked(&fb_helper->client); > - } else { > - ret = drm_client_modeset_commit(&fb_helper->client); > - } > + ret = drm_client_modeset_commit(&fb_helper->client); > > do_delayed = fb_helper->delayed_hotplug; > if (do_delayed) > @@ -263,22 +263,6 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > > return ret; > } > - > -/** > - * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration > - * @fb_helper: driver-allocated fbdev helper, can be NULL > - * > - * This should be called from driver's drm &drm_driver.lastclose callback > - * when implementing an fbcon on top of kms using this helper. This ensures that > - * the user isn't greeted with a black screen when e.g. X dies. > - * > - * RETURNS: > - * Zero if everything went ok, negative error code otherwise. > - */ > -int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > -{ > - return __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, false); > -} > EXPORT_SYMBOL(drm_fb_helper_restore_fbdev_mode_unlocked); > > #ifdef CONFIG_MAGIC_SYSRQ > @@ -1254,25 +1238,6 @@ int drm_fb_helper_ioctl(struct fb_info *info, unsigned int cmd, > } > EXPORT_SYMBOL(drm_fb_helper_ioctl); > > -static bool drm_fb_pixel_format_equal(const struct fb_var_screeninfo *var_1, > - const struct fb_var_screeninfo *var_2) > -{ > - return var_1->bits_per_pixel == var_2->bits_per_pixel && > - var_1->grayscale == var_2->grayscale && > - var_1->red.offset == var_2->red.offset && > - var_1->red.length == var_2->red.length && > - var_1->red.msb_right == var_2->red.msb_right && > - var_1->green.offset == var_2->green.offset && > - var_1->green.length == var_2->green.length && > - var_1->green.msb_right == var_2->green.msb_right && > - var_1->blue.offset == var_2->blue.offset && > - var_1->blue.length == var_2->blue.length && > - var_1->blue.msb_right == var_2->blue.msb_right && > - var_1->transp.offset == var_2->transp.offset && > - var_1->transp.length == var_2->transp.length && > - var_1->transp.msb_right == var_2->transp.msb_right; > -} > - > static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, > u8 depth) > { > @@ -1331,123 +1296,6 @@ static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, > } > } > > -/** > - * drm_fb_helper_check_var - implementation for &fb_ops.fb_check_var > - * @var: screeninfo to check > - * @info: fbdev registered by the helper > - */ > -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > - struct fb_info *info) > -{ > - struct drm_fb_helper *fb_helper = info->par; > - struct drm_framebuffer *fb = fb_helper->fb; > - struct drm_device *dev = fb_helper->dev; > - > - if (in_dbg_master()) > - return -EINVAL; > - > - if (var->pixclock != 0) { > - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel clock, value of pixclock is ignored\n"); > - var->pixclock = 0; > - } > - > - if ((drm_format_info_block_width(fb->format, 0) > 1) || > - (drm_format_info_block_height(fb->format, 0) > 1)) > - return -EINVAL; > - > - /* > - * Changes struct fb_var_screeninfo are currently not pushed back > - * to KMS, hence fail if different settings are requested. > - */ > - if (var->bits_per_pixel > fb->format->cpp[0] * 8 || > - var->xres > fb->width || var->yres > fb->height || > - var->xres_virtual > fb->width || var->yres_virtual > fb->height) { > - drm_dbg_kms(dev, "fb requested width/height/bpp can't fit in current fb " > - "request %dx%d-%d (virtual %dx%d) > %dx%d-%d\n", > - var->xres, var->yres, var->bits_per_pixel, > - var->xres_virtual, var->yres_virtual, > - fb->width, fb->height, fb->format->cpp[0] * 8); > - return -EINVAL; > - } > - > - /* > - * Workaround for SDL 1.2, which is known to be setting all pixel format > - * fields values to zero in some cases. We treat this situation as a > - * kind of "use some reasonable autodetected values". > - */ > - if (!var->red.offset && !var->green.offset && > - !var->blue.offset && !var->transp.offset && > - !var->red.length && !var->green.length && > - !var->blue.length && !var->transp.length && > - !var->red.msb_right && !var->green.msb_right && > - !var->blue.msb_right && !var->transp.msb_right) { > - drm_fb_helper_fill_pixel_fmt(var, fb->format->depth); > - } > - > - /* > - * Likewise, bits_per_pixel should be rounded up to a supported value. > - */ > - var->bits_per_pixel = fb->format->cpp[0] * 8; > - > - /* > - * drm fbdev emulation doesn't support changing the pixel format at all, > - * so reject all pixel format changing requests. > - */ > - if (!drm_fb_pixel_format_equal(var, &info->var)) { > - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel format\n"); > - return -EINVAL; > - } > - > - return 0; > -} > -EXPORT_SYMBOL(drm_fb_helper_check_var); > - > -/** > - * drm_fb_helper_set_par - implementation for &fb_ops.fb_set_par > - * @info: fbdev registered by the helper > - * > - * This will let fbcon do the mode init and is called at initialization time by > - * the fbdev core when registering the driver, and later on through the hotplug > - * callback. > - */ > -int drm_fb_helper_set_par(struct fb_info *info) > -{ > - struct drm_fb_helper *fb_helper = info->par; > - struct fb_var_screeninfo *var = &info->var; > - bool force; > - > - if (oops_in_progress) > - return -EBUSY; > - > - if (var->pixclock != 0) { > - drm_err(fb_helper->dev, "PIXEL CLOCK SET\n"); > - return -EINVAL; > - } > - > - /* > - * Normally we want to make sure that a kms master takes precedence over > - * fbdev, to avoid fbdev flickering and occasionally stealing the > - * display status. But Xorg first sets the vt back to text mode using > - * the KDSET IOCTL with KD_TEXT, and only after that drops the master > - * status when exiting. > - * > - * In the past this was caught by drm_fb_helper_lastclose(), but on > - * modern systems where logind always keeps a drm fd open to orchestrate > - * the vt switching, this doesn't work. > - * > - * To not break the userspace ABI we have this special case here, which > - * is only used for the above case. Everything else uses the normal > - * commit function, which ensures that we never steal the display from > - * an active drm master. > - */ > - force = var->activate & FB_ACTIVATE_KD_TEXT; > - > - __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, force); > - > - return 0; > -} > -EXPORT_SYMBOL(drm_fb_helper_set_par); > - > static void pan_set(struct drm_fb_helper *fb_helper, int x, int y) > { > struct drm_mode_set *mode_set; > @@ -2028,8 +1876,6 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper) > drm_setup_crtcs_fb(fb_helper); > mutex_unlock(&fb_helper->lock); > > - drm_fb_helper_set_par(fb_helper->fbdev); > - > return 0; > } > EXPORT_SYMBOL(drm_fb_helper_hotplug_event); > diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c > index 221336178991f04f..26dbe9487c79ae1b 100644 > --- a/drivers/gpu/drm/i915/display/intel_fbdev.c > +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c > @@ -77,20 +77,6 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev) > intel_frontbuffer_invalidate(to_frontbuffer(ifbdev), ORIGIN_CPU); > } > > -static int intel_fbdev_set_par(struct fb_info *info) > -{ > - struct drm_fb_helper *fb_helper = info->par; > - struct intel_fbdev *ifbdev = > - container_of(fb_helper, struct intel_fbdev, helper); > - int ret; > - > - ret = drm_fb_helper_set_par(info); > - if (ret == 0) > - intel_fbdev_invalidate(ifbdev); > - > - return ret; > -} > - > static int intel_fbdev_blank(int blank, struct fb_info *info) > { > struct drm_fb_helper *fb_helper = info->par; > @@ -123,7 +109,6 @@ static int intel_fbdev_pan_display(struct fb_var_screeninfo *var, > static const struct fb_ops intelfb_ops = { > .owner = THIS_MODULE, > DRM_FB_HELPER_DEFAULT_OPS, > - .fb_set_par = intel_fbdev_set_par, > .fb_fillrect = drm_fb_helper_cfb_fillrect, > .fb_copyarea = drm_fb_helper_cfb_copyarea, > .fb_imageblit = drm_fb_helper_cfb_imageblit, > diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c > index 40706c5aad7b5c9b..2df8875baaca10b6 100644 > --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c > +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c > @@ -74,8 +74,6 @@ static int omap_fbdev_pan_display(struct fb_var_screeninfo *var, > static const struct fb_ops omap_fb_ops = { > .owner = THIS_MODULE, > > - .fb_check_var = drm_fb_helper_check_var, > - .fb_set_par = drm_fb_helper_set_par, > .fb_setcmap = drm_fb_helper_setcmap, > .fb_blank = drm_fb_helper_blank, > .fb_pan_display = omap_fbdev_pan_display, > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h > index 329607ca65c06684..19b40adc156295a1 100644 > --- a/include/drm/drm_fb_helper.h > +++ b/include/drm/drm_fb_helper.h > @@ -200,8 +200,6 @@ drm_fb_helper_from_client(struct drm_client_dev *client) > * functions. To be used in struct fb_ops of drm drivers. > */ > #define DRM_FB_HELPER_DEFAULT_OPS \ > - .fb_check_var = drm_fb_helper_check_var, \ > - .fb_set_par = drm_fb_helper_set_par, \ > .fb_setcmap = drm_fb_helper_setcmap, \ > .fb_blank = drm_fb_helper_blank, \ > .fb_pan_display = drm_fb_helper_pan_display, \ > @@ -217,9 +215,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *helper); > int drm_fb_helper_blank(int blank, struct fb_info *info); > int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, > struct fb_info *info); > -int drm_fb_helper_set_par(struct fb_info *info); > -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > - struct fb_info *info); > > int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper); > > @@ -303,17 +298,6 @@ static inline int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, > return 0; > } > > -static inline int drm_fb_helper_set_par(struct fb_info *info) > -{ > - return 0; > -} > - > -static inline int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > - struct fb_info *info) > -{ > - return 0; > -} > - > static inline int > drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > { ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/fb-helper: Remove helpers to change frame buffer config @ 2022-07-02 18:05 ` Helge Deller 0 siblings, 0 replies; 14+ messages in thread From: Helge Deller @ 2022-07-02 18:05 UTC (permalink / raw) To: Geert Uytterhoeven, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Tomi Valkeinen Cc: Greg Kroah-Hartman, intel-gfx, linux-fbdev, dri-devel, linux-kernel On 6/29/22 12:56, Geert Uytterhoeven wrote: > The DRM fbdev emulation layer does not support pushing back > changes to fb_var_screeninfo to KMS. > > However, drm_fb_helper still implements the fb_ops.fb_check_var() and > fb_ops.fb_set_par() callbacks, but the former fails to validate various > parameters passed from userspace. Hence unsanitized and possible > invaled values are passed up through the fbdev, fbcon, and console > stack, which has become an endless source of security issues reported > against fbdev. > > Fix this by not populating the fb_ops.fb_check_var() and > fb_ops.fb_set_par() callbacks, as there is no point in providing them if > the frame buffer config cannot be changed anyway. This makes the fbdev > core aware that making changes to the frame buffer config is not > supported, so it will always return the current config. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> It's unfortunate that DRM currently isn't able to switch resolutions at runtime. With that in mind I agree with Geert that it's probably better to disable (or drop) that code until DRM can cope with fbdev's interface to switch resolutions. Furthermore, with the upcoming patches to fbcon (which prevents crashes on invalid userspace input), you will face a kernel WARNING if you call fbset to switch screen resolutions with DRM drivers. So, from my side (although I'd prefer a better fix for DRM): Acked-by: Helge Deller <deller@gmx.de> Helge > --- > The only remaining DRM driver that implements fb_ops.fb_check_var() is > also broken, as it fails to validate various parameters passed from > userspace. So vmw_fb_check_var() should either be fixed, or removed. > --- > drivers/gpu/drm/drm_fb_helper.c | 180 ++------------------- > drivers/gpu/drm/i915/display/intel_fbdev.c | 15 -- > drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 - > include/drm/drm_fb_helper.h | 16 -- > 4 files changed, 13 insertions(+), 200 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 2d4cee6a10ffffe7..1041a11c410d7967 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -228,9 +228,18 @@ int drm_fb_helper_debug_leave(struct fb_info *info) > } > EXPORT_SYMBOL(drm_fb_helper_debug_leave); > > -static int > -__drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > - bool force) > +/** > + * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration > + * @fb_helper: driver-allocated fbdev helper, can be NULL > + * > + * This should be called from driver's drm &drm_driver.lastclose callback > + * when implementing an fbcon on top of kms using this helper. This ensures that > + * the user isn't greeted with a black screen when e.g. X dies. > + * > + * RETURNS: > + * Zero if everything went ok, negative error code otherwise. > + */ > +int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > { > bool do_delayed; > int ret; > @@ -242,16 +251,7 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > return 0; > > mutex_lock(&fb_helper->lock); > - if (force) { > - /* > - * Yes this is the _locked version which expects the master lock > - * to be held. But for forced restores we're intentionally > - * racing here, see drm_fb_helper_set_par(). > - */ > - ret = drm_client_modeset_commit_locked(&fb_helper->client); > - } else { > - ret = drm_client_modeset_commit(&fb_helper->client); > - } > + ret = drm_client_modeset_commit(&fb_helper->client); > > do_delayed = fb_helper->delayed_hotplug; > if (do_delayed) > @@ -263,22 +263,6 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > > return ret; > } > - > -/** > - * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration > - * @fb_helper: driver-allocated fbdev helper, can be NULL > - * > - * This should be called from driver's drm &drm_driver.lastclose callback > - * when implementing an fbcon on top of kms using this helper. This ensures that > - * the user isn't greeted with a black screen when e.g. X dies. > - * > - * RETURNS: > - * Zero if everything went ok, negative error code otherwise. > - */ > -int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > -{ > - return __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, false); > -} > EXPORT_SYMBOL(drm_fb_helper_restore_fbdev_mode_unlocked); > > #ifdef CONFIG_MAGIC_SYSRQ > @@ -1254,25 +1238,6 @@ int drm_fb_helper_ioctl(struct fb_info *info, unsigned int cmd, > } > EXPORT_SYMBOL(drm_fb_helper_ioctl); > > -static bool drm_fb_pixel_format_equal(const struct fb_var_screeninfo *var_1, > - const struct fb_var_screeninfo *var_2) > -{ > - return var_1->bits_per_pixel == var_2->bits_per_pixel && > - var_1->grayscale == var_2->grayscale && > - var_1->red.offset == var_2->red.offset && > - var_1->red.length == var_2->red.length && > - var_1->red.msb_right == var_2->red.msb_right && > - var_1->green.offset == var_2->green.offset && > - var_1->green.length == var_2->green.length && > - var_1->green.msb_right == var_2->green.msb_right && > - var_1->blue.offset == var_2->blue.offset && > - var_1->blue.length == var_2->blue.length && > - var_1->blue.msb_right == var_2->blue.msb_right && > - var_1->transp.offset == var_2->transp.offset && > - var_1->transp.length == var_2->transp.length && > - var_1->transp.msb_right == var_2->transp.msb_right; > -} > - > static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, > u8 depth) > { > @@ -1331,123 +1296,6 @@ static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, > } > } > > -/** > - * drm_fb_helper_check_var - implementation for &fb_ops.fb_check_var > - * @var: screeninfo to check > - * @info: fbdev registered by the helper > - */ > -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > - struct fb_info *info) > -{ > - struct drm_fb_helper *fb_helper = info->par; > - struct drm_framebuffer *fb = fb_helper->fb; > - struct drm_device *dev = fb_helper->dev; > - > - if (in_dbg_master()) > - return -EINVAL; > - > - if (var->pixclock != 0) { > - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel clock, value of pixclock is ignored\n"); > - var->pixclock = 0; > - } > - > - if ((drm_format_info_block_width(fb->format, 0) > 1) || > - (drm_format_info_block_height(fb->format, 0) > 1)) > - return -EINVAL; > - > - /* > - * Changes struct fb_var_screeninfo are currently not pushed back > - * to KMS, hence fail if different settings are requested. > - */ > - if (var->bits_per_pixel > fb->format->cpp[0] * 8 || > - var->xres > fb->width || var->yres > fb->height || > - var->xres_virtual > fb->width || var->yres_virtual > fb->height) { > - drm_dbg_kms(dev, "fb requested width/height/bpp can't fit in current fb " > - "request %dx%d-%d (virtual %dx%d) > %dx%d-%d\n", > - var->xres, var->yres, var->bits_per_pixel, > - var->xres_virtual, var->yres_virtual, > - fb->width, fb->height, fb->format->cpp[0] * 8); > - return -EINVAL; > - } > - > - /* > - * Workaround for SDL 1.2, which is known to be setting all pixel format > - * fields values to zero in some cases. We treat this situation as a > - * kind of "use some reasonable autodetected values". > - */ > - if (!var->red.offset && !var->green.offset && > - !var->blue.offset && !var->transp.offset && > - !var->red.length && !var->green.length && > - !var->blue.length && !var->transp.length && > - !var->red.msb_right && !var->green.msb_right && > - !var->blue.msb_right && !var->transp.msb_right) { > - drm_fb_helper_fill_pixel_fmt(var, fb->format->depth); > - } > - > - /* > - * Likewise, bits_per_pixel should be rounded up to a supported value. > - */ > - var->bits_per_pixel = fb->format->cpp[0] * 8; > - > - /* > - * drm fbdev emulation doesn't support changing the pixel format at all, > - * so reject all pixel format changing requests. > - */ > - if (!drm_fb_pixel_format_equal(var, &info->var)) { > - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel format\n"); > - return -EINVAL; > - } > - > - return 0; > -} > -EXPORT_SYMBOL(drm_fb_helper_check_var); > - > -/** > - * drm_fb_helper_set_par - implementation for &fb_ops.fb_set_par > - * @info: fbdev registered by the helper > - * > - * This will let fbcon do the mode init and is called at initialization time by > - * the fbdev core when registering the driver, and later on through the hotplug > - * callback. > - */ > -int drm_fb_helper_set_par(struct fb_info *info) > -{ > - struct drm_fb_helper *fb_helper = info->par; > - struct fb_var_screeninfo *var = &info->var; > - bool force; > - > - if (oops_in_progress) > - return -EBUSY; > - > - if (var->pixclock != 0) { > - drm_err(fb_helper->dev, "PIXEL CLOCK SET\n"); > - return -EINVAL; > - } > - > - /* > - * Normally we want to make sure that a kms master takes precedence over > - * fbdev, to avoid fbdev flickering and occasionally stealing the > - * display status. But Xorg first sets the vt back to text mode using > - * the KDSET IOCTL with KD_TEXT, and only after that drops the master > - * status when exiting. > - * > - * In the past this was caught by drm_fb_helper_lastclose(), but on > - * modern systems where logind always keeps a drm fd open to orchestrate > - * the vt switching, this doesn't work. > - * > - * To not break the userspace ABI we have this special case here, which > - * is only used for the above case. Everything else uses the normal > - * commit function, which ensures that we never steal the display from > - * an active drm master. > - */ > - force = var->activate & FB_ACTIVATE_KD_TEXT; > - > - __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, force); > - > - return 0; > -} > -EXPORT_SYMBOL(drm_fb_helper_set_par); > - > static void pan_set(struct drm_fb_helper *fb_helper, int x, int y) > { > struct drm_mode_set *mode_set; > @@ -2028,8 +1876,6 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper) > drm_setup_crtcs_fb(fb_helper); > mutex_unlock(&fb_helper->lock); > > - drm_fb_helper_set_par(fb_helper->fbdev); > - > return 0; > } > EXPORT_SYMBOL(drm_fb_helper_hotplug_event); > diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c > index 221336178991f04f..26dbe9487c79ae1b 100644 > --- a/drivers/gpu/drm/i915/display/intel_fbdev.c > +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c > @@ -77,20 +77,6 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev) > intel_frontbuffer_invalidate(to_frontbuffer(ifbdev), ORIGIN_CPU); > } > > -static int intel_fbdev_set_par(struct fb_info *info) > -{ > - struct drm_fb_helper *fb_helper = info->par; > - struct intel_fbdev *ifbdev = > - container_of(fb_helper, struct intel_fbdev, helper); > - int ret; > - > - ret = drm_fb_helper_set_par(info); > - if (ret == 0) > - intel_fbdev_invalidate(ifbdev); > - > - return ret; > -} > - > static int intel_fbdev_blank(int blank, struct fb_info *info) > { > struct drm_fb_helper *fb_helper = info->par; > @@ -123,7 +109,6 @@ static int intel_fbdev_pan_display(struct fb_var_screeninfo *var, > static const struct fb_ops intelfb_ops = { > .owner = THIS_MODULE, > DRM_FB_HELPER_DEFAULT_OPS, > - .fb_set_par = intel_fbdev_set_par, > .fb_fillrect = drm_fb_helper_cfb_fillrect, > .fb_copyarea = drm_fb_helper_cfb_copyarea, > .fb_imageblit = drm_fb_helper_cfb_imageblit, > diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c > index 40706c5aad7b5c9b..2df8875baaca10b6 100644 > --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c > +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c > @@ -74,8 +74,6 @@ static int omap_fbdev_pan_display(struct fb_var_screeninfo *var, > static const struct fb_ops omap_fb_ops = { > .owner = THIS_MODULE, > > - .fb_check_var = drm_fb_helper_check_var, > - .fb_set_par = drm_fb_helper_set_par, > .fb_setcmap = drm_fb_helper_setcmap, > .fb_blank = drm_fb_helper_blank, > .fb_pan_display = omap_fbdev_pan_display, > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h > index 329607ca65c06684..19b40adc156295a1 100644 > --- a/include/drm/drm_fb_helper.h > +++ b/include/drm/drm_fb_helper.h > @@ -200,8 +200,6 @@ drm_fb_helper_from_client(struct drm_client_dev *client) > * functions. To be used in struct fb_ops of drm drivers. > */ > #define DRM_FB_HELPER_DEFAULT_OPS \ > - .fb_check_var = drm_fb_helper_check_var, \ > - .fb_set_par = drm_fb_helper_set_par, \ > .fb_setcmap = drm_fb_helper_setcmap, \ > .fb_blank = drm_fb_helper_blank, \ > .fb_pan_display = drm_fb_helper_pan_display, \ > @@ -217,9 +215,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *helper); > int drm_fb_helper_blank(int blank, struct fb_info *info); > int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, > struct fb_info *info); > -int drm_fb_helper_set_par(struct fb_info *info); > -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > - struct fb_info *info); > > int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper); > > @@ -303,17 +298,6 @@ static inline int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, > return 0; > } > > -static inline int drm_fb_helper_set_par(struct fb_info *info) > -{ > - return 0; > -} > - > -static inline int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > - struct fb_info *info) > -{ > - return 0; > -} > - > static inline int > drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > { ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/fb-helper: Remove helpers to change frame buffer config 2022-07-02 18:05 ` Helge Deller (?) @ 2022-08-09 15:03 ` Daniel Vetter -1 siblings, 0 replies; 14+ messages in thread From: Daniel Vetter @ 2022-08-09 15:03 UTC (permalink / raw) To: Helge Deller Cc: Geert Uytterhoeven, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Tomi Valkeinen, Greg Kroah-Hartman, dri-devel, intel-gfx, linux-fbdev, linux-kernel On Sat, Jul 02, 2022 at 08:05:54PM +0200, Helge Deller wrote: > On 6/29/22 12:56, Geert Uytterhoeven wrote: > > The DRM fbdev emulation layer does not support pushing back > > changes to fb_var_screeninfo to KMS. > > > > However, drm_fb_helper still implements the fb_ops.fb_check_var() and > > fb_ops.fb_set_par() callbacks, but the former fails to validate various > > parameters passed from userspace. Hence unsanitized and possible > > invaled values are passed up through the fbdev, fbcon, and console > > stack, which has become an endless source of security issues reported > > against fbdev. > > > > Fix this by not populating the fb_ops.fb_check_var() and > > fb_ops.fb_set_par() callbacks, as there is no point in providing them if > > the frame buffer config cannot be changed anyway. This makes the fbdev > > core aware that making changes to the frame buffer config is not > > supported, so it will always return the current config. > > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > It's unfortunate that DRM currently isn't able to switch resolutions > at runtime. > > With that in mind I agree with Geert that it's probably better to > disable (or drop) that code until DRM can cope with fbdev's > interface to switch resolutions. > > Furthermore, with the upcoming patches to fbcon (which prevents crashes on > invalid userspace input), you will face a kernel WARNING if you call fbset > to switch screen resolutions with DRM drivers. > > So, from my side (although I'd prefer a better fix for DRM): > > Acked-by: Helge Deller <deller@gmx.de> So maybe I'm missing something, but I think this breaks a lot of stuff. The issue is that fbdev is only a subordinate owner of the kms device, if there's a real drm kms owner around that wins. Which means when you switch back then set_par needs to restore the fbdev framebuffer. So that might break some recovery/use-cases. The other thing is that I think this also breaks the scanout offset, and people do use that for double-buffering on top of fbdev on top of drm drivers. So we can't just nuke it completely. For better or worse I think we need to keep playing the whack-a-mole game. Or do I miss something here? -Daniel > > Helge > > > --- > > The only remaining DRM driver that implements fb_ops.fb_check_var() is > > also broken, as it fails to validate various parameters passed from > > userspace. So vmw_fb_check_var() should either be fixed, or removed. > > --- > > drivers/gpu/drm/drm_fb_helper.c | 180 ++------------------- > > drivers/gpu/drm/i915/display/intel_fbdev.c | 15 -- > > drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 - > > include/drm/drm_fb_helper.h | 16 -- > > 4 files changed, 13 insertions(+), 200 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > > index 2d4cee6a10ffffe7..1041a11c410d7967 100644 > > --- a/drivers/gpu/drm/drm_fb_helper.c > > +++ b/drivers/gpu/drm/drm_fb_helper.c > > @@ -228,9 +228,18 @@ int drm_fb_helper_debug_leave(struct fb_info *info) > > } > > EXPORT_SYMBOL(drm_fb_helper_debug_leave); > > > > -static int > > -__drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > > - bool force) > > +/** > > + * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration > > + * @fb_helper: driver-allocated fbdev helper, can be NULL > > + * > > + * This should be called from driver's drm &drm_driver.lastclose callback > > + * when implementing an fbcon on top of kms using this helper. This ensures that > > + * the user isn't greeted with a black screen when e.g. X dies. > > + * > > + * RETURNS: > > + * Zero if everything went ok, negative error code otherwise. > > + */ > > +int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > > { > > bool do_delayed; > > int ret; > > @@ -242,16 +251,7 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > > return 0; > > > > mutex_lock(&fb_helper->lock); > > - if (force) { > > - /* > > - * Yes this is the _locked version which expects the master lock > > - * to be held. But for forced restores we're intentionally > > - * racing here, see drm_fb_helper_set_par(). > > - */ > > - ret = drm_client_modeset_commit_locked(&fb_helper->client); > > - } else { > > - ret = drm_client_modeset_commit(&fb_helper->client); > > - } > > + ret = drm_client_modeset_commit(&fb_helper->client); > > > > do_delayed = fb_helper->delayed_hotplug; > > if (do_delayed) > > @@ -263,22 +263,6 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > > > > return ret; > > } > > - > > -/** > > - * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration > > - * @fb_helper: driver-allocated fbdev helper, can be NULL > > - * > > - * This should be called from driver's drm &drm_driver.lastclose callback > > - * when implementing an fbcon on top of kms using this helper. This ensures that > > - * the user isn't greeted with a black screen when e.g. X dies. > > - * > > - * RETURNS: > > - * Zero if everything went ok, negative error code otherwise. > > - */ > > -int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > > -{ > > - return __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, false); > > -} > > EXPORT_SYMBOL(drm_fb_helper_restore_fbdev_mode_unlocked); > > > > #ifdef CONFIG_MAGIC_SYSRQ > > @@ -1254,25 +1238,6 @@ int drm_fb_helper_ioctl(struct fb_info *info, unsigned int cmd, > > } > > EXPORT_SYMBOL(drm_fb_helper_ioctl); > > > > -static bool drm_fb_pixel_format_equal(const struct fb_var_screeninfo *var_1, > > - const struct fb_var_screeninfo *var_2) > > -{ > > - return var_1->bits_per_pixel == var_2->bits_per_pixel && > > - var_1->grayscale == var_2->grayscale && > > - var_1->red.offset == var_2->red.offset && > > - var_1->red.length == var_2->red.length && > > - var_1->red.msb_right == var_2->red.msb_right && > > - var_1->green.offset == var_2->green.offset && > > - var_1->green.length == var_2->green.length && > > - var_1->green.msb_right == var_2->green.msb_right && > > - var_1->blue.offset == var_2->blue.offset && > > - var_1->blue.length == var_2->blue.length && > > - var_1->blue.msb_right == var_2->blue.msb_right && > > - var_1->transp.offset == var_2->transp.offset && > > - var_1->transp.length == var_2->transp.length && > > - var_1->transp.msb_right == var_2->transp.msb_right; > > -} > > - > > static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, > > u8 depth) > > { > > @@ -1331,123 +1296,6 @@ static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, > > } > > } > > > > -/** > > - * drm_fb_helper_check_var - implementation for &fb_ops.fb_check_var > > - * @var: screeninfo to check > > - * @info: fbdev registered by the helper > > - */ > > -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > > - struct fb_info *info) > > -{ > > - struct drm_fb_helper *fb_helper = info->par; > > - struct drm_framebuffer *fb = fb_helper->fb; > > - struct drm_device *dev = fb_helper->dev; > > - > > - if (in_dbg_master()) > > - return -EINVAL; > > - > > - if (var->pixclock != 0) { > > - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel clock, value of pixclock is ignored\n"); > > - var->pixclock = 0; > > - } > > - > > - if ((drm_format_info_block_width(fb->format, 0) > 1) || > > - (drm_format_info_block_height(fb->format, 0) > 1)) > > - return -EINVAL; > > - > > - /* > > - * Changes struct fb_var_screeninfo are currently not pushed back > > - * to KMS, hence fail if different settings are requested. > > - */ > > - if (var->bits_per_pixel > fb->format->cpp[0] * 8 || > > - var->xres > fb->width || var->yres > fb->height || > > - var->xres_virtual > fb->width || var->yres_virtual > fb->height) { > > - drm_dbg_kms(dev, "fb requested width/height/bpp can't fit in current fb " > > - "request %dx%d-%d (virtual %dx%d) > %dx%d-%d\n", > > - var->xres, var->yres, var->bits_per_pixel, > > - var->xres_virtual, var->yres_virtual, > > - fb->width, fb->height, fb->format->cpp[0] * 8); > > - return -EINVAL; > > - } > > - > > - /* > > - * Workaround for SDL 1.2, which is known to be setting all pixel format > > - * fields values to zero in some cases. We treat this situation as a > > - * kind of "use some reasonable autodetected values". > > - */ > > - if (!var->red.offset && !var->green.offset && > > - !var->blue.offset && !var->transp.offset && > > - !var->red.length && !var->green.length && > > - !var->blue.length && !var->transp.length && > > - !var->red.msb_right && !var->green.msb_right && > > - !var->blue.msb_right && !var->transp.msb_right) { > > - drm_fb_helper_fill_pixel_fmt(var, fb->format->depth); > > - } > > - > > - /* > > - * Likewise, bits_per_pixel should be rounded up to a supported value. > > - */ > > - var->bits_per_pixel = fb->format->cpp[0] * 8; > > - > > - /* > > - * drm fbdev emulation doesn't support changing the pixel format at all, > > - * so reject all pixel format changing requests. > > - */ > > - if (!drm_fb_pixel_format_equal(var, &info->var)) { > > - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel format\n"); > > - return -EINVAL; > > - } > > - > > - return 0; > > -} > > -EXPORT_SYMBOL(drm_fb_helper_check_var); > > - > > -/** > > - * drm_fb_helper_set_par - implementation for &fb_ops.fb_set_par > > - * @info: fbdev registered by the helper > > - * > > - * This will let fbcon do the mode init and is called at initialization time by > > - * the fbdev core when registering the driver, and later on through the hotplug > > - * callback. > > - */ > > -int drm_fb_helper_set_par(struct fb_info *info) > > -{ > > - struct drm_fb_helper *fb_helper = info->par; > > - struct fb_var_screeninfo *var = &info->var; > > - bool force; > > - > > - if (oops_in_progress) > > - return -EBUSY; > > - > > - if (var->pixclock != 0) { > > - drm_err(fb_helper->dev, "PIXEL CLOCK SET\n"); > > - return -EINVAL; > > - } > > - > > - /* > > - * Normally we want to make sure that a kms master takes precedence over > > - * fbdev, to avoid fbdev flickering and occasionally stealing the > > - * display status. But Xorg first sets the vt back to text mode using > > - * the KDSET IOCTL with KD_TEXT, and only after that drops the master > > - * status when exiting. > > - * > > - * In the past this was caught by drm_fb_helper_lastclose(), but on > > - * modern systems where logind always keeps a drm fd open to orchestrate > > - * the vt switching, this doesn't work. > > - * > > - * To not break the userspace ABI we have this special case here, which > > - * is only used for the above case. Everything else uses the normal > > - * commit function, which ensures that we never steal the display from > > - * an active drm master. > > - */ > > - force = var->activate & FB_ACTIVATE_KD_TEXT; > > - > > - __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, force); > > - > > - return 0; > > -} > > -EXPORT_SYMBOL(drm_fb_helper_set_par); > > - > > static void pan_set(struct drm_fb_helper *fb_helper, int x, int y) > > { > > struct drm_mode_set *mode_set; > > @@ -2028,8 +1876,6 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper) > > drm_setup_crtcs_fb(fb_helper); > > mutex_unlock(&fb_helper->lock); > > > > - drm_fb_helper_set_par(fb_helper->fbdev); > > - > > return 0; > > } > > EXPORT_SYMBOL(drm_fb_helper_hotplug_event); > > diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c > > index 221336178991f04f..26dbe9487c79ae1b 100644 > > --- a/drivers/gpu/drm/i915/display/intel_fbdev.c > > +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c > > @@ -77,20 +77,6 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev) > > intel_frontbuffer_invalidate(to_frontbuffer(ifbdev), ORIGIN_CPU); > > } > > > > -static int intel_fbdev_set_par(struct fb_info *info) > > -{ > > - struct drm_fb_helper *fb_helper = info->par; > > - struct intel_fbdev *ifbdev = > > - container_of(fb_helper, struct intel_fbdev, helper); > > - int ret; > > - > > - ret = drm_fb_helper_set_par(info); > > - if (ret == 0) > > - intel_fbdev_invalidate(ifbdev); > > - > > - return ret; > > -} > > - > > static int intel_fbdev_blank(int blank, struct fb_info *info) > > { > > struct drm_fb_helper *fb_helper = info->par; > > @@ -123,7 +109,6 @@ static int intel_fbdev_pan_display(struct fb_var_screeninfo *var, > > static const struct fb_ops intelfb_ops = { > > .owner = THIS_MODULE, > > DRM_FB_HELPER_DEFAULT_OPS, > > - .fb_set_par = intel_fbdev_set_par, > > .fb_fillrect = drm_fb_helper_cfb_fillrect, > > .fb_copyarea = drm_fb_helper_cfb_copyarea, > > .fb_imageblit = drm_fb_helper_cfb_imageblit, > > diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c > > index 40706c5aad7b5c9b..2df8875baaca10b6 100644 > > --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c > > +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c > > @@ -74,8 +74,6 @@ static int omap_fbdev_pan_display(struct fb_var_screeninfo *var, > > static const struct fb_ops omap_fb_ops = { > > .owner = THIS_MODULE, > > > > - .fb_check_var = drm_fb_helper_check_var, > > - .fb_set_par = drm_fb_helper_set_par, > > .fb_setcmap = drm_fb_helper_setcmap, > > .fb_blank = drm_fb_helper_blank, > > .fb_pan_display = omap_fbdev_pan_display, > > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h > > index 329607ca65c06684..19b40adc156295a1 100644 > > --- a/include/drm/drm_fb_helper.h > > +++ b/include/drm/drm_fb_helper.h > > @@ -200,8 +200,6 @@ drm_fb_helper_from_client(struct drm_client_dev *client) > > * functions. To be used in struct fb_ops of drm drivers. > > */ > > #define DRM_FB_HELPER_DEFAULT_OPS \ > > - .fb_check_var = drm_fb_helper_check_var, \ > > - .fb_set_par = drm_fb_helper_set_par, \ > > .fb_setcmap = drm_fb_helper_setcmap, \ > > .fb_blank = drm_fb_helper_blank, \ > > .fb_pan_display = drm_fb_helper_pan_display, \ > > @@ -217,9 +215,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *helper); > > int drm_fb_helper_blank(int blank, struct fb_info *info); > > int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, > > struct fb_info *info); > > -int drm_fb_helper_set_par(struct fb_info *info); > > -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > > - struct fb_info *info); > > > > int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper); > > > > @@ -303,17 +298,6 @@ static inline int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, > > return 0; > > } > > > > -static inline int drm_fb_helper_set_par(struct fb_info *info) > > -{ > > - return 0; > > -} > > - > > -static inline int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > > - struct fb_info *info) > > -{ > > - return 0; > > -} > > - > > static inline int > > drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > > { > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/fb-helper: Remove helpers to change frame buffer config @ 2022-08-09 15:03 ` Daniel Vetter 0 siblings, 0 replies; 14+ messages in thread From: Daniel Vetter @ 2022-08-09 15:03 UTC (permalink / raw) To: Helge Deller Cc: linux-fbdev, Thomas Zimmermann, Tomi Valkeinen, David Airlie, Greg Kroah-Hartman, dri-devel, linux-kernel, Maxime Ripard, Geert Uytterhoeven, Daniel Vetter, Rodrigo Vivi, intel-gfx On Sat, Jul 02, 2022 at 08:05:54PM +0200, Helge Deller wrote: > On 6/29/22 12:56, Geert Uytterhoeven wrote: > > The DRM fbdev emulation layer does not support pushing back > > changes to fb_var_screeninfo to KMS. > > > > However, drm_fb_helper still implements the fb_ops.fb_check_var() and > > fb_ops.fb_set_par() callbacks, but the former fails to validate various > > parameters passed from userspace. Hence unsanitized and possible > > invaled values are passed up through the fbdev, fbcon, and console > > stack, which has become an endless source of security issues reported > > against fbdev. > > > > Fix this by not populating the fb_ops.fb_check_var() and > > fb_ops.fb_set_par() callbacks, as there is no point in providing them if > > the frame buffer config cannot be changed anyway. This makes the fbdev > > core aware that making changes to the frame buffer config is not > > supported, so it will always return the current config. > > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > It's unfortunate that DRM currently isn't able to switch resolutions > at runtime. > > With that in mind I agree with Geert that it's probably better to > disable (or drop) that code until DRM can cope with fbdev's > interface to switch resolutions. > > Furthermore, with the upcoming patches to fbcon (which prevents crashes on > invalid userspace input), you will face a kernel WARNING if you call fbset > to switch screen resolutions with DRM drivers. > > So, from my side (although I'd prefer a better fix for DRM): > > Acked-by: Helge Deller <deller@gmx.de> So maybe I'm missing something, but I think this breaks a lot of stuff. The issue is that fbdev is only a subordinate owner of the kms device, if there's a real drm kms owner around that wins. Which means when you switch back then set_par needs to restore the fbdev framebuffer. So that might break some recovery/use-cases. The other thing is that I think this also breaks the scanout offset, and people do use that for double-buffering on top of fbdev on top of drm drivers. So we can't just nuke it completely. For better or worse I think we need to keep playing the whack-a-mole game. Or do I miss something here? -Daniel > > Helge > > > --- > > The only remaining DRM driver that implements fb_ops.fb_check_var() is > > also broken, as it fails to validate various parameters passed from > > userspace. So vmw_fb_check_var() should either be fixed, or removed. > > --- > > drivers/gpu/drm/drm_fb_helper.c | 180 ++------------------- > > drivers/gpu/drm/i915/display/intel_fbdev.c | 15 -- > > drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 - > > include/drm/drm_fb_helper.h | 16 -- > > 4 files changed, 13 insertions(+), 200 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > > index 2d4cee6a10ffffe7..1041a11c410d7967 100644 > > --- a/drivers/gpu/drm/drm_fb_helper.c > > +++ b/drivers/gpu/drm/drm_fb_helper.c > > @@ -228,9 +228,18 @@ int drm_fb_helper_debug_leave(struct fb_info *info) > > } > > EXPORT_SYMBOL(drm_fb_helper_debug_leave); > > > > -static int > > -__drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > > - bool force) > > +/** > > + * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration > > + * @fb_helper: driver-allocated fbdev helper, can be NULL > > + * > > + * This should be called from driver's drm &drm_driver.lastclose callback > > + * when implementing an fbcon on top of kms using this helper. This ensures that > > + * the user isn't greeted with a black screen when e.g. X dies. > > + * > > + * RETURNS: > > + * Zero if everything went ok, negative error code otherwise. > > + */ > > +int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > > { > > bool do_delayed; > > int ret; > > @@ -242,16 +251,7 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > > return 0; > > > > mutex_lock(&fb_helper->lock); > > - if (force) { > > - /* > > - * Yes this is the _locked version which expects the master lock > > - * to be held. But for forced restores we're intentionally > > - * racing here, see drm_fb_helper_set_par(). > > - */ > > - ret = drm_client_modeset_commit_locked(&fb_helper->client); > > - } else { > > - ret = drm_client_modeset_commit(&fb_helper->client); > > - } > > + ret = drm_client_modeset_commit(&fb_helper->client); > > > > do_delayed = fb_helper->delayed_hotplug; > > if (do_delayed) > > @@ -263,22 +263,6 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > > > > return ret; > > } > > - > > -/** > > - * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration > > - * @fb_helper: driver-allocated fbdev helper, can be NULL > > - * > > - * This should be called from driver's drm &drm_driver.lastclose callback > > - * when implementing an fbcon on top of kms using this helper. This ensures that > > - * the user isn't greeted with a black screen when e.g. X dies. > > - * > > - * RETURNS: > > - * Zero if everything went ok, negative error code otherwise. > > - */ > > -int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > > -{ > > - return __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, false); > > -} > > EXPORT_SYMBOL(drm_fb_helper_restore_fbdev_mode_unlocked); > > > > #ifdef CONFIG_MAGIC_SYSRQ > > @@ -1254,25 +1238,6 @@ int drm_fb_helper_ioctl(struct fb_info *info, unsigned int cmd, > > } > > EXPORT_SYMBOL(drm_fb_helper_ioctl); > > > > -static bool drm_fb_pixel_format_equal(const struct fb_var_screeninfo *var_1, > > - const struct fb_var_screeninfo *var_2) > > -{ > > - return var_1->bits_per_pixel == var_2->bits_per_pixel && > > - var_1->grayscale == var_2->grayscale && > > - var_1->red.offset == var_2->red.offset && > > - var_1->red.length == var_2->red.length && > > - var_1->red.msb_right == var_2->red.msb_right && > > - var_1->green.offset == var_2->green.offset && > > - var_1->green.length == var_2->green.length && > > - var_1->green.msb_right == var_2->green.msb_right && > > - var_1->blue.offset == var_2->blue.offset && > > - var_1->blue.length == var_2->blue.length && > > - var_1->blue.msb_right == var_2->blue.msb_right && > > - var_1->transp.offset == var_2->transp.offset && > > - var_1->transp.length == var_2->transp.length && > > - var_1->transp.msb_right == var_2->transp.msb_right; > > -} > > - > > static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, > > u8 depth) > > { > > @@ -1331,123 +1296,6 @@ static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, > > } > > } > > > > -/** > > - * drm_fb_helper_check_var - implementation for &fb_ops.fb_check_var > > - * @var: screeninfo to check > > - * @info: fbdev registered by the helper > > - */ > > -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > > - struct fb_info *info) > > -{ > > - struct drm_fb_helper *fb_helper = info->par; > > - struct drm_framebuffer *fb = fb_helper->fb; > > - struct drm_device *dev = fb_helper->dev; > > - > > - if (in_dbg_master()) > > - return -EINVAL; > > - > > - if (var->pixclock != 0) { > > - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel clock, value of pixclock is ignored\n"); > > - var->pixclock = 0; > > - } > > - > > - if ((drm_format_info_block_width(fb->format, 0) > 1) || > > - (drm_format_info_block_height(fb->format, 0) > 1)) > > - return -EINVAL; > > - > > - /* > > - * Changes struct fb_var_screeninfo are currently not pushed back > > - * to KMS, hence fail if different settings are requested. > > - */ > > - if (var->bits_per_pixel > fb->format->cpp[0] * 8 || > > - var->xres > fb->width || var->yres > fb->height || > > - var->xres_virtual > fb->width || var->yres_virtual > fb->height) { > > - drm_dbg_kms(dev, "fb requested width/height/bpp can't fit in current fb " > > - "request %dx%d-%d (virtual %dx%d) > %dx%d-%d\n", > > - var->xres, var->yres, var->bits_per_pixel, > > - var->xres_virtual, var->yres_virtual, > > - fb->width, fb->height, fb->format->cpp[0] * 8); > > - return -EINVAL; > > - } > > - > > - /* > > - * Workaround for SDL 1.2, which is known to be setting all pixel format > > - * fields values to zero in some cases. We treat this situation as a > > - * kind of "use some reasonable autodetected values". > > - */ > > - if (!var->red.offset && !var->green.offset && > > - !var->blue.offset && !var->transp.offset && > > - !var->red.length && !var->green.length && > > - !var->blue.length && !var->transp.length && > > - !var->red.msb_right && !var->green.msb_right && > > - !var->blue.msb_right && !var->transp.msb_right) { > > - drm_fb_helper_fill_pixel_fmt(var, fb->format->depth); > > - } > > - > > - /* > > - * Likewise, bits_per_pixel should be rounded up to a supported value. > > - */ > > - var->bits_per_pixel = fb->format->cpp[0] * 8; > > - > > - /* > > - * drm fbdev emulation doesn't support changing the pixel format at all, > > - * so reject all pixel format changing requests. > > - */ > > - if (!drm_fb_pixel_format_equal(var, &info->var)) { > > - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel format\n"); > > - return -EINVAL; > > - } > > - > > - return 0; > > -} > > -EXPORT_SYMBOL(drm_fb_helper_check_var); > > - > > -/** > > - * drm_fb_helper_set_par - implementation for &fb_ops.fb_set_par > > - * @info: fbdev registered by the helper > > - * > > - * This will let fbcon do the mode init and is called at initialization time by > > - * the fbdev core when registering the driver, and later on through the hotplug > > - * callback. > > - */ > > -int drm_fb_helper_set_par(struct fb_info *info) > > -{ > > - struct drm_fb_helper *fb_helper = info->par; > > - struct fb_var_screeninfo *var = &info->var; > > - bool force; > > - > > - if (oops_in_progress) > > - return -EBUSY; > > - > > - if (var->pixclock != 0) { > > - drm_err(fb_helper->dev, "PIXEL CLOCK SET\n"); > > - return -EINVAL; > > - } > > - > > - /* > > - * Normally we want to make sure that a kms master takes precedence over > > - * fbdev, to avoid fbdev flickering and occasionally stealing the > > - * display status. But Xorg first sets the vt back to text mode using > > - * the KDSET IOCTL with KD_TEXT, and only after that drops the master > > - * status when exiting. > > - * > > - * In the past this was caught by drm_fb_helper_lastclose(), but on > > - * modern systems where logind always keeps a drm fd open to orchestrate > > - * the vt switching, this doesn't work. > > - * > > - * To not break the userspace ABI we have this special case here, which > > - * is only used for the above case. Everything else uses the normal > > - * commit function, which ensures that we never steal the display from > > - * an active drm master. > > - */ > > - force = var->activate & FB_ACTIVATE_KD_TEXT; > > - > > - __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, force); > > - > > - return 0; > > -} > > -EXPORT_SYMBOL(drm_fb_helper_set_par); > > - > > static void pan_set(struct drm_fb_helper *fb_helper, int x, int y) > > { > > struct drm_mode_set *mode_set; > > @@ -2028,8 +1876,6 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper) > > drm_setup_crtcs_fb(fb_helper); > > mutex_unlock(&fb_helper->lock); > > > > - drm_fb_helper_set_par(fb_helper->fbdev); > > - > > return 0; > > } > > EXPORT_SYMBOL(drm_fb_helper_hotplug_event); > > diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c > > index 221336178991f04f..26dbe9487c79ae1b 100644 > > --- a/drivers/gpu/drm/i915/display/intel_fbdev.c > > +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c > > @@ -77,20 +77,6 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev) > > intel_frontbuffer_invalidate(to_frontbuffer(ifbdev), ORIGIN_CPU); > > } > > > > -static int intel_fbdev_set_par(struct fb_info *info) > > -{ > > - struct drm_fb_helper *fb_helper = info->par; > > - struct intel_fbdev *ifbdev = > > - container_of(fb_helper, struct intel_fbdev, helper); > > - int ret; > > - > > - ret = drm_fb_helper_set_par(info); > > - if (ret == 0) > > - intel_fbdev_invalidate(ifbdev); > > - > > - return ret; > > -} > > - > > static int intel_fbdev_blank(int blank, struct fb_info *info) > > { > > struct drm_fb_helper *fb_helper = info->par; > > @@ -123,7 +109,6 @@ static int intel_fbdev_pan_display(struct fb_var_screeninfo *var, > > static const struct fb_ops intelfb_ops = { > > .owner = THIS_MODULE, > > DRM_FB_HELPER_DEFAULT_OPS, > > - .fb_set_par = intel_fbdev_set_par, > > .fb_fillrect = drm_fb_helper_cfb_fillrect, > > .fb_copyarea = drm_fb_helper_cfb_copyarea, > > .fb_imageblit = drm_fb_helper_cfb_imageblit, > > diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c > > index 40706c5aad7b5c9b..2df8875baaca10b6 100644 > > --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c > > +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c > > @@ -74,8 +74,6 @@ static int omap_fbdev_pan_display(struct fb_var_screeninfo *var, > > static const struct fb_ops omap_fb_ops = { > > .owner = THIS_MODULE, > > > > - .fb_check_var = drm_fb_helper_check_var, > > - .fb_set_par = drm_fb_helper_set_par, > > .fb_setcmap = drm_fb_helper_setcmap, > > .fb_blank = drm_fb_helper_blank, > > .fb_pan_display = omap_fbdev_pan_display, > > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h > > index 329607ca65c06684..19b40adc156295a1 100644 > > --- a/include/drm/drm_fb_helper.h > > +++ b/include/drm/drm_fb_helper.h > > @@ -200,8 +200,6 @@ drm_fb_helper_from_client(struct drm_client_dev *client) > > * functions. To be used in struct fb_ops of drm drivers. > > */ > > #define DRM_FB_HELPER_DEFAULT_OPS \ > > - .fb_check_var = drm_fb_helper_check_var, \ > > - .fb_set_par = drm_fb_helper_set_par, \ > > .fb_setcmap = drm_fb_helper_setcmap, \ > > .fb_blank = drm_fb_helper_blank, \ > > .fb_pan_display = drm_fb_helper_pan_display, \ > > @@ -217,9 +215,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *helper); > > int drm_fb_helper_blank(int blank, struct fb_info *info); > > int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, > > struct fb_info *info); > > -int drm_fb_helper_set_par(struct fb_info *info); > > -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > > - struct fb_info *info); > > > > int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper); > > > > @@ -303,17 +298,6 @@ static inline int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, > > return 0; > > } > > > > -static inline int drm_fb_helper_set_par(struct fb_info *info) > > -{ > > - return 0; > > -} > > - > > -static inline int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > > - struct fb_info *info) > > -{ > > - return 0; > > -} > > - > > static inline int > > drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > > { > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/fb-helper: Remove helpers to change frame buffer config @ 2022-08-09 15:03 ` Daniel Vetter 0 siblings, 0 replies; 14+ messages in thread From: Daniel Vetter @ 2022-08-09 15:03 UTC (permalink / raw) To: Helge Deller Cc: Tvrtko Ursulin, linux-fbdev, Thomas Zimmermann, Tomi Valkeinen, David Airlie, Greg Kroah-Hartman, dri-devel, linux-kernel, Geert Uytterhoeven, Rodrigo Vivi, intel-gfx On Sat, Jul 02, 2022 at 08:05:54PM +0200, Helge Deller wrote: > On 6/29/22 12:56, Geert Uytterhoeven wrote: > > The DRM fbdev emulation layer does not support pushing back > > changes to fb_var_screeninfo to KMS. > > > > However, drm_fb_helper still implements the fb_ops.fb_check_var() and > > fb_ops.fb_set_par() callbacks, but the former fails to validate various > > parameters passed from userspace. Hence unsanitized and possible > > invaled values are passed up through the fbdev, fbcon, and console > > stack, which has become an endless source of security issues reported > > against fbdev. > > > > Fix this by not populating the fb_ops.fb_check_var() and > > fb_ops.fb_set_par() callbacks, as there is no point in providing them if > > the frame buffer config cannot be changed anyway. This makes the fbdev > > core aware that making changes to the frame buffer config is not > > supported, so it will always return the current config. > > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > It's unfortunate that DRM currently isn't able to switch resolutions > at runtime. > > With that in mind I agree with Geert that it's probably better to > disable (or drop) that code until DRM can cope with fbdev's > interface to switch resolutions. > > Furthermore, with the upcoming patches to fbcon (which prevents crashes on > invalid userspace input), you will face a kernel WARNING if you call fbset > to switch screen resolutions with DRM drivers. > > So, from my side (although I'd prefer a better fix for DRM): > > Acked-by: Helge Deller <deller@gmx.de> So maybe I'm missing something, but I think this breaks a lot of stuff. The issue is that fbdev is only a subordinate owner of the kms device, if there's a real drm kms owner around that wins. Which means when you switch back then set_par needs to restore the fbdev framebuffer. So that might break some recovery/use-cases. The other thing is that I think this also breaks the scanout offset, and people do use that for double-buffering on top of fbdev on top of drm drivers. So we can't just nuke it completely. For better or worse I think we need to keep playing the whack-a-mole game. Or do I miss something here? -Daniel > > Helge > > > --- > > The only remaining DRM driver that implements fb_ops.fb_check_var() is > > also broken, as it fails to validate various parameters passed from > > userspace. So vmw_fb_check_var() should either be fixed, or removed. > > --- > > drivers/gpu/drm/drm_fb_helper.c | 180 ++------------------- > > drivers/gpu/drm/i915/display/intel_fbdev.c | 15 -- > > drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 - > > include/drm/drm_fb_helper.h | 16 -- > > 4 files changed, 13 insertions(+), 200 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > > index 2d4cee6a10ffffe7..1041a11c410d7967 100644 > > --- a/drivers/gpu/drm/drm_fb_helper.c > > +++ b/drivers/gpu/drm/drm_fb_helper.c > > @@ -228,9 +228,18 @@ int drm_fb_helper_debug_leave(struct fb_info *info) > > } > > EXPORT_SYMBOL(drm_fb_helper_debug_leave); > > > > -static int > > -__drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > > - bool force) > > +/** > > + * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration > > + * @fb_helper: driver-allocated fbdev helper, can be NULL > > + * > > + * This should be called from driver's drm &drm_driver.lastclose callback > > + * when implementing an fbcon on top of kms using this helper. This ensures that > > + * the user isn't greeted with a black screen when e.g. X dies. > > + * > > + * RETURNS: > > + * Zero if everything went ok, negative error code otherwise. > > + */ > > +int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > > { > > bool do_delayed; > > int ret; > > @@ -242,16 +251,7 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > > return 0; > > > > mutex_lock(&fb_helper->lock); > > - if (force) { > > - /* > > - * Yes this is the _locked version which expects the master lock > > - * to be held. But for forced restores we're intentionally > > - * racing here, see drm_fb_helper_set_par(). > > - */ > > - ret = drm_client_modeset_commit_locked(&fb_helper->client); > > - } else { > > - ret = drm_client_modeset_commit(&fb_helper->client); > > - } > > + ret = drm_client_modeset_commit(&fb_helper->client); > > > > do_delayed = fb_helper->delayed_hotplug; > > if (do_delayed) > > @@ -263,22 +263,6 @@ __drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper, > > > > return ret; > > } > > - > > -/** > > - * drm_fb_helper_restore_fbdev_mode_unlocked - restore fbdev configuration > > - * @fb_helper: driver-allocated fbdev helper, can be NULL > > - * > > - * This should be called from driver's drm &drm_driver.lastclose callback > > - * when implementing an fbcon on top of kms using this helper. This ensures that > > - * the user isn't greeted with a black screen when e.g. X dies. > > - * > > - * RETURNS: > > - * Zero if everything went ok, negative error code otherwise. > > - */ > > -int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > > -{ > > - return __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, false); > > -} > > EXPORT_SYMBOL(drm_fb_helper_restore_fbdev_mode_unlocked); > > > > #ifdef CONFIG_MAGIC_SYSRQ > > @@ -1254,25 +1238,6 @@ int drm_fb_helper_ioctl(struct fb_info *info, unsigned int cmd, > > } > > EXPORT_SYMBOL(drm_fb_helper_ioctl); > > > > -static bool drm_fb_pixel_format_equal(const struct fb_var_screeninfo *var_1, > > - const struct fb_var_screeninfo *var_2) > > -{ > > - return var_1->bits_per_pixel == var_2->bits_per_pixel && > > - var_1->grayscale == var_2->grayscale && > > - var_1->red.offset == var_2->red.offset && > > - var_1->red.length == var_2->red.length && > > - var_1->red.msb_right == var_2->red.msb_right && > > - var_1->green.offset == var_2->green.offset && > > - var_1->green.length == var_2->green.length && > > - var_1->green.msb_right == var_2->green.msb_right && > > - var_1->blue.offset == var_2->blue.offset && > > - var_1->blue.length == var_2->blue.length && > > - var_1->blue.msb_right == var_2->blue.msb_right && > > - var_1->transp.offset == var_2->transp.offset && > > - var_1->transp.length == var_2->transp.length && > > - var_1->transp.msb_right == var_2->transp.msb_right; > > -} > > - > > static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, > > u8 depth) > > { > > @@ -1331,123 +1296,6 @@ static void drm_fb_helper_fill_pixel_fmt(struct fb_var_screeninfo *var, > > } > > } > > > > -/** > > - * drm_fb_helper_check_var - implementation for &fb_ops.fb_check_var > > - * @var: screeninfo to check > > - * @info: fbdev registered by the helper > > - */ > > -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > > - struct fb_info *info) > > -{ > > - struct drm_fb_helper *fb_helper = info->par; > > - struct drm_framebuffer *fb = fb_helper->fb; > > - struct drm_device *dev = fb_helper->dev; > > - > > - if (in_dbg_master()) > > - return -EINVAL; > > - > > - if (var->pixclock != 0) { > > - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel clock, value of pixclock is ignored\n"); > > - var->pixclock = 0; > > - } > > - > > - if ((drm_format_info_block_width(fb->format, 0) > 1) || > > - (drm_format_info_block_height(fb->format, 0) > 1)) > > - return -EINVAL; > > - > > - /* > > - * Changes struct fb_var_screeninfo are currently not pushed back > > - * to KMS, hence fail if different settings are requested. > > - */ > > - if (var->bits_per_pixel > fb->format->cpp[0] * 8 || > > - var->xres > fb->width || var->yres > fb->height || > > - var->xres_virtual > fb->width || var->yres_virtual > fb->height) { > > - drm_dbg_kms(dev, "fb requested width/height/bpp can't fit in current fb " > > - "request %dx%d-%d (virtual %dx%d) > %dx%d-%d\n", > > - var->xres, var->yres, var->bits_per_pixel, > > - var->xres_virtual, var->yres_virtual, > > - fb->width, fb->height, fb->format->cpp[0] * 8); > > - return -EINVAL; > > - } > > - > > - /* > > - * Workaround for SDL 1.2, which is known to be setting all pixel format > > - * fields values to zero in some cases. We treat this situation as a > > - * kind of "use some reasonable autodetected values". > > - */ > > - if (!var->red.offset && !var->green.offset && > > - !var->blue.offset && !var->transp.offset && > > - !var->red.length && !var->green.length && > > - !var->blue.length && !var->transp.length && > > - !var->red.msb_right && !var->green.msb_right && > > - !var->blue.msb_right && !var->transp.msb_right) { > > - drm_fb_helper_fill_pixel_fmt(var, fb->format->depth); > > - } > > - > > - /* > > - * Likewise, bits_per_pixel should be rounded up to a supported value. > > - */ > > - var->bits_per_pixel = fb->format->cpp[0] * 8; > > - > > - /* > > - * drm fbdev emulation doesn't support changing the pixel format at all, > > - * so reject all pixel format changing requests. > > - */ > > - if (!drm_fb_pixel_format_equal(var, &info->var)) { > > - drm_dbg_kms(dev, "fbdev emulation doesn't support changing the pixel format\n"); > > - return -EINVAL; > > - } > > - > > - return 0; > > -} > > -EXPORT_SYMBOL(drm_fb_helper_check_var); > > - > > -/** > > - * drm_fb_helper_set_par - implementation for &fb_ops.fb_set_par > > - * @info: fbdev registered by the helper > > - * > > - * This will let fbcon do the mode init and is called at initialization time by > > - * the fbdev core when registering the driver, and later on through the hotplug > > - * callback. > > - */ > > -int drm_fb_helper_set_par(struct fb_info *info) > > -{ > > - struct drm_fb_helper *fb_helper = info->par; > > - struct fb_var_screeninfo *var = &info->var; > > - bool force; > > - > > - if (oops_in_progress) > > - return -EBUSY; > > - > > - if (var->pixclock != 0) { > > - drm_err(fb_helper->dev, "PIXEL CLOCK SET\n"); > > - return -EINVAL; > > - } > > - > > - /* > > - * Normally we want to make sure that a kms master takes precedence over > > - * fbdev, to avoid fbdev flickering and occasionally stealing the > > - * display status. But Xorg first sets the vt back to text mode using > > - * the KDSET IOCTL with KD_TEXT, and only after that drops the master > > - * status when exiting. > > - * > > - * In the past this was caught by drm_fb_helper_lastclose(), but on > > - * modern systems where logind always keeps a drm fd open to orchestrate > > - * the vt switching, this doesn't work. > > - * > > - * To not break the userspace ABI we have this special case here, which > > - * is only used for the above case. Everything else uses the normal > > - * commit function, which ensures that we never steal the display from > > - * an active drm master. > > - */ > > - force = var->activate & FB_ACTIVATE_KD_TEXT; > > - > > - __drm_fb_helper_restore_fbdev_mode_unlocked(fb_helper, force); > > - > > - return 0; > > -} > > -EXPORT_SYMBOL(drm_fb_helper_set_par); > > - > > static void pan_set(struct drm_fb_helper *fb_helper, int x, int y) > > { > > struct drm_mode_set *mode_set; > > @@ -2028,8 +1876,6 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper) > > drm_setup_crtcs_fb(fb_helper); > > mutex_unlock(&fb_helper->lock); > > > > - drm_fb_helper_set_par(fb_helper->fbdev); > > - > > return 0; > > } > > EXPORT_SYMBOL(drm_fb_helper_hotplug_event); > > diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c > > index 221336178991f04f..26dbe9487c79ae1b 100644 > > --- a/drivers/gpu/drm/i915/display/intel_fbdev.c > > +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c > > @@ -77,20 +77,6 @@ static void intel_fbdev_invalidate(struct intel_fbdev *ifbdev) > > intel_frontbuffer_invalidate(to_frontbuffer(ifbdev), ORIGIN_CPU); > > } > > > > -static int intel_fbdev_set_par(struct fb_info *info) > > -{ > > - struct drm_fb_helper *fb_helper = info->par; > > - struct intel_fbdev *ifbdev = > > - container_of(fb_helper, struct intel_fbdev, helper); > > - int ret; > > - > > - ret = drm_fb_helper_set_par(info); > > - if (ret == 0) > > - intel_fbdev_invalidate(ifbdev); > > - > > - return ret; > > -} > > - > > static int intel_fbdev_blank(int blank, struct fb_info *info) > > { > > struct drm_fb_helper *fb_helper = info->par; > > @@ -123,7 +109,6 @@ static int intel_fbdev_pan_display(struct fb_var_screeninfo *var, > > static const struct fb_ops intelfb_ops = { > > .owner = THIS_MODULE, > > DRM_FB_HELPER_DEFAULT_OPS, > > - .fb_set_par = intel_fbdev_set_par, > > .fb_fillrect = drm_fb_helper_cfb_fillrect, > > .fb_copyarea = drm_fb_helper_cfb_copyarea, > > .fb_imageblit = drm_fb_helper_cfb_imageblit, > > diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c > > index 40706c5aad7b5c9b..2df8875baaca10b6 100644 > > --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c > > +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c > > @@ -74,8 +74,6 @@ static int omap_fbdev_pan_display(struct fb_var_screeninfo *var, > > static const struct fb_ops omap_fb_ops = { > > .owner = THIS_MODULE, > > > > - .fb_check_var = drm_fb_helper_check_var, > > - .fb_set_par = drm_fb_helper_set_par, > > .fb_setcmap = drm_fb_helper_setcmap, > > .fb_blank = drm_fb_helper_blank, > > .fb_pan_display = omap_fbdev_pan_display, > > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h > > index 329607ca65c06684..19b40adc156295a1 100644 > > --- a/include/drm/drm_fb_helper.h > > +++ b/include/drm/drm_fb_helper.h > > @@ -200,8 +200,6 @@ drm_fb_helper_from_client(struct drm_client_dev *client) > > * functions. To be used in struct fb_ops of drm drivers. > > */ > > #define DRM_FB_HELPER_DEFAULT_OPS \ > > - .fb_check_var = drm_fb_helper_check_var, \ > > - .fb_set_par = drm_fb_helper_set_par, \ > > .fb_setcmap = drm_fb_helper_setcmap, \ > > .fb_blank = drm_fb_helper_blank, \ > > .fb_pan_display = drm_fb_helper_pan_display, \ > > @@ -217,9 +215,6 @@ void drm_fb_helper_fini(struct drm_fb_helper *helper); > > int drm_fb_helper_blank(int blank, struct fb_info *info); > > int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, > > struct fb_info *info); > > -int drm_fb_helper_set_par(struct fb_info *info); > > -int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > > - struct fb_info *info); > > > > int drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper); > > > > @@ -303,17 +298,6 @@ static inline int drm_fb_helper_pan_display(struct fb_var_screeninfo *var, > > return 0; > > } > > > > -static inline int drm_fb_helper_set_par(struct fb_info *info) > > -{ > > - return 0; > > -} > > - > > -static inline int drm_fb_helper_check_var(struct fb_var_screeninfo *var, > > - struct fb_info *info) > > -{ > > - return 0; > > -} > > - > > static inline int > > drm_fb_helper_restore_fbdev_mode_unlocked(struct drm_fb_helper *fb_helper) > > { > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/fb-helper: Remove helpers to change frame buffer config 2022-08-09 15:03 ` Daniel Vetter (?) @ 2023-04-04 15:20 ` Geert Uytterhoeven -1 siblings, 0 replies; 14+ messages in thread From: Geert Uytterhoeven @ 2023-04-04 15:20 UTC (permalink / raw) To: Daniel Vetter Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Tomi Valkeinen, Greg Kroah-Hartman, dri-devel, intel-gfx, linux-fbdev, linux-kernel Hi Daniel, On Tue, Aug 9, 2022 at 5:03 PM Daniel Vetter <daniel@ffwll.ch> wrote: > On Sat, Jul 02, 2022 at 08:05:54PM +0200, Helge Deller wrote: > > On 6/29/22 12:56, Geert Uytterhoeven wrote: > > > The DRM fbdev emulation layer does not support pushing back > > > changes to fb_var_screeninfo to KMS. > > > > > > However, drm_fb_helper still implements the fb_ops.fb_check_var() and > > > fb_ops.fb_set_par() callbacks, but the former fails to validate various > > > parameters passed from userspace. Hence unsanitized and possible > > > invaled values are passed up through the fbdev, fbcon, and console > > > stack, which has become an endless source of security issues reported > > > against fbdev. > > > > > > Fix this by not populating the fb_ops.fb_check_var() and > > > fb_ops.fb_set_par() callbacks, as there is no point in providing them if > > > the frame buffer config cannot be changed anyway. This makes the fbdev > > > core aware that making changes to the frame buffer config is not > > > supported, so it will always return the current config. > > > > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > > > It's unfortunate that DRM currently isn't able to switch resolutions > > at runtime. > > > > With that in mind I agree with Geert that it's probably better to > > disable (or drop) that code until DRM can cope with fbdev's > > interface to switch resolutions. > > > > Furthermore, with the upcoming patches to fbcon (which prevents crashes on > > invalid userspace input), you will face a kernel WARNING if you call fbset > > to switch screen resolutions with DRM drivers. > > > > So, from my side (although I'd prefer a better fix for DRM): > > > > Acked-by: Helge Deller <deller@gmx.de> > > So maybe I'm missing something, but I think this breaks a lot of stuff. > The issue is that fbdev is only a subordinate owner of the kms device, if > there's a real drm kms owner around that wins. > > Which means when you switch back then set_par needs to restore the fbdev > framebuffer. So that might break some recovery/use-cases. Upon closer look, I think I was a bit too over-eager, and we can keep the implementation of fb_ops.fb_set_par(). > The other thing is that I think this also breaks the scanout offset, and > people do use that for double-buffering on top of fbdev on top of drm > drivers. So we can't just nuke it completely. You mean panning? That does not need fb_ops.fb_check_var(), as it should be done through fb_ops.fb_pan_display(). > For better or worse I think we need to keep playing the whack-a-mole game. > Or do I miss something here? With the above fixed, we can continue whacking the drm bugs in implementing the fbdev API? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/fb-helper: Remove helpers to change frame buffer config @ 2023-04-04 15:20 ` Geert Uytterhoeven 0 siblings, 0 replies; 14+ messages in thread From: Geert Uytterhoeven @ 2023-04-04 15:20 UTC (permalink / raw) To: Daniel Vetter Cc: linux-fbdev, Tomi Valkeinen, David Airlie, Greg Kroah-Hartman, dri-devel, linux-kernel, Maxime Ripard, Thomas Zimmermann, Rodrigo Vivi, intel-gfx Hi Daniel, On Tue, Aug 9, 2022 at 5:03 PM Daniel Vetter <daniel@ffwll.ch> wrote: > On Sat, Jul 02, 2022 at 08:05:54PM +0200, Helge Deller wrote: > > On 6/29/22 12:56, Geert Uytterhoeven wrote: > > > The DRM fbdev emulation layer does not support pushing back > > > changes to fb_var_screeninfo to KMS. > > > > > > However, drm_fb_helper still implements the fb_ops.fb_check_var() and > > > fb_ops.fb_set_par() callbacks, but the former fails to validate various > > > parameters passed from userspace. Hence unsanitized and possible > > > invaled values are passed up through the fbdev, fbcon, and console > > > stack, which has become an endless source of security issues reported > > > against fbdev. > > > > > > Fix this by not populating the fb_ops.fb_check_var() and > > > fb_ops.fb_set_par() callbacks, as there is no point in providing them if > > > the frame buffer config cannot be changed anyway. This makes the fbdev > > > core aware that making changes to the frame buffer config is not > > > supported, so it will always return the current config. > > > > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > > > It's unfortunate that DRM currently isn't able to switch resolutions > > at runtime. > > > > With that in mind I agree with Geert that it's probably better to > > disable (or drop) that code until DRM can cope with fbdev's > > interface to switch resolutions. > > > > Furthermore, with the upcoming patches to fbcon (which prevents crashes on > > invalid userspace input), you will face a kernel WARNING if you call fbset > > to switch screen resolutions with DRM drivers. > > > > So, from my side (although I'd prefer a better fix for DRM): > > > > Acked-by: Helge Deller <deller@gmx.de> > > So maybe I'm missing something, but I think this breaks a lot of stuff. > The issue is that fbdev is only a subordinate owner of the kms device, if > there's a real drm kms owner around that wins. > > Which means when you switch back then set_par needs to restore the fbdev > framebuffer. So that might break some recovery/use-cases. Upon closer look, I think I was a bit too over-eager, and we can keep the implementation of fb_ops.fb_set_par(). > The other thing is that I think this also breaks the scanout offset, and > people do use that for double-buffering on top of fbdev on top of drm > drivers. So we can't just nuke it completely. You mean panning? That does not need fb_ops.fb_check_var(), as it should be done through fb_ops.fb_pan_display(). > For better or worse I think we need to keep playing the whack-a-mole game. > Or do I miss something here? With the above fixed, we can continue whacking the drm bugs in implementing the fbdev API? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/fb-helper: Remove helpers to change frame buffer config @ 2023-04-04 15:20 ` Geert Uytterhoeven 0 siblings, 0 replies; 14+ messages in thread From: Geert Uytterhoeven @ 2023-04-04 15:20 UTC (permalink / raw) To: Daniel Vetter Cc: Tvrtko Ursulin, linux-fbdev, Tomi Valkeinen, David Airlie, Greg Kroah-Hartman, dri-devel, linux-kernel, Thomas Zimmermann, Rodrigo Vivi, intel-gfx Hi Daniel, On Tue, Aug 9, 2022 at 5:03 PM Daniel Vetter <daniel@ffwll.ch> wrote: > On Sat, Jul 02, 2022 at 08:05:54PM +0200, Helge Deller wrote: > > On 6/29/22 12:56, Geert Uytterhoeven wrote: > > > The DRM fbdev emulation layer does not support pushing back > > > changes to fb_var_screeninfo to KMS. > > > > > > However, drm_fb_helper still implements the fb_ops.fb_check_var() and > > > fb_ops.fb_set_par() callbacks, but the former fails to validate various > > > parameters passed from userspace. Hence unsanitized and possible > > > invaled values are passed up through the fbdev, fbcon, and console > > > stack, which has become an endless source of security issues reported > > > against fbdev. > > > > > > Fix this by not populating the fb_ops.fb_check_var() and > > > fb_ops.fb_set_par() callbacks, as there is no point in providing them if > > > the frame buffer config cannot be changed anyway. This makes the fbdev > > > core aware that making changes to the frame buffer config is not > > > supported, so it will always return the current config. > > > > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > > > It's unfortunate that DRM currently isn't able to switch resolutions > > at runtime. > > > > With that in mind I agree with Geert that it's probably better to > > disable (or drop) that code until DRM can cope with fbdev's > > interface to switch resolutions. > > > > Furthermore, with the upcoming patches to fbcon (which prevents crashes on > > invalid userspace input), you will face a kernel WARNING if you call fbset > > to switch screen resolutions with DRM drivers. > > > > So, from my side (although I'd prefer a better fix for DRM): > > > > Acked-by: Helge Deller <deller@gmx.de> > > So maybe I'm missing something, but I think this breaks a lot of stuff. > The issue is that fbdev is only a subordinate owner of the kms device, if > there's a real drm kms owner around that wins. > > Which means when you switch back then set_par needs to restore the fbdev > framebuffer. So that might break some recovery/use-cases. Upon closer look, I think I was a bit too over-eager, and we can keep the implementation of fb_ops.fb_set_par(). > The other thing is that I think this also breaks the scanout offset, and > people do use that for double-buffering on top of fbdev on top of drm > drivers. So we can't just nuke it completely. You mean panning? That does not need fb_ops.fb_check_var(), as it should be done through fb_ops.fb_pan_display(). > For better or worse I think we need to keep playing the whack-a-mole game. > Or do I miss something here? With the above fixed, we can continue whacking the drm bugs in implementing the fbdev API? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-04-04 15:20 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-06-29 10:56 [PATCH] drm/fb-helper: Remove helpers to change frame buffer config Geert Uytterhoeven 2022-06-29 10:56 ` [Intel-gfx] " Geert Uytterhoeven 2022-06-29 10:56 ` Geert Uytterhoeven 2022-06-29 12:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2022-06-30 4:51 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2022-07-02 18:05 ` [PATCH] " Helge Deller 2022-07-02 18:05 ` [Intel-gfx] " Helge Deller 2022-07-02 18:05 ` Helge Deller 2022-08-09 15:03 ` Daniel Vetter 2022-08-09 15:03 ` [Intel-gfx] " Daniel Vetter 2022-08-09 15:03 ` Daniel Vetter 2023-04-04 15:20 ` Geert Uytterhoeven 2023-04-04 15:20 ` [Intel-gfx] " Geert Uytterhoeven 2023-04-04 15:20 ` Geert Uytterhoeven
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.