All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Viorel Suman (OSS)" <viorel.suman@oss.nxp.com>
Cc: linux-clk@vger.kernel.org, Abel Vesa <abelvesa@kernel.org>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Liu Ying <victor.liu@nxp.com>,
	linux-arm-kernel@lists.infradead.org, Peng Fan <peng.fan@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Mirela Rabulea <mirela.rabulea@nxp.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Viorel Suman <viorel.suman@nxp.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Amit Kucheria <amitk@kernel.org>,
	linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Dong Aisheng <aisheng.dong@nxp.com>,
	linux-watchdog@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-gpio@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Abel Vesa <abel.vesa@nxp.com>, Stefan Agner <stefan@agner.ch>,
	devicetree@vger.kernel.org,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Ming Qian <ming.qian@nxp.com>, Zhang Rui <rui.zhang@intel.com>,
	Fabio Estevam <festevam@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-input@vger.kernel.org,
	Oliver Graute <oliver.graute@kococonnector.com>
Subject: Re: [PATCH v7 02/15] dt-bindings: pinctrl: imx: Add fsl,scu-iomux yaml file
Date: Mon, 04 Jul 2022 18:50:55 -0600	[thread overview]
Message-ID: <1656982255.094130.640439.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220704161541.943696-3-viorel.suman@oss.nxp.com>

On Mon, 04 Jul 2022 19:15:28 +0300, Viorel Suman (OSS) wrote:
> From: Abel Vesa <abel.vesa@nxp.com>
> 
> In order to replace the fsl,scu txt file from bindings/arm/freescale,
> we need to split it between the right subsystems. This patch documents
> separately the 'iomux/pinctrl' child node of the SCU main node.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> ---
>  .../bindings/arm/freescale/fsl,scu.txt        | 40 ----------
>  .../bindings/pinctrl/fsl,scu-pinctrl.yaml     | 74 +++++++++++++++++++
>  2 files changed, 74 insertions(+), 40 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.example.dtb: iomuxc@400e8000: lpuart1grp:fsl,pins:0: [364, 944, 1568, 0, 0, 241, 368, 948, 1564, 0, 0, 241] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.example.dtb: pinctrl: lpuart0grp:fsl,pins:0: [111, 0, 100663328, 112, 0, 100663328] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx93-pinctrl.example.dtb: pinctrl@443c0000: uart3grp:fsl,pins:0: [72, 504, 1052, 1, 0, 73, 76, 508, 1048, 1, 0, 73] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx93-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.example.dtb: pinctrl@30330000: uart5grp:fsl,pins:0: [352, 976, 1812, 1, 0, 126, 356, 980, 0, 1, 0, 118] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.example.dtb: pinctrl@302c0000: gpio1-grp:fsl,pins:0: [8, 56, 0, 0, 0, 89, 12, 60, 0, 0, 0, 89] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1050.example.dtb: iomuxc@401f8000: lpuart1grp:fsl,pins:0: [236, 732, 0, 2, 0, 241, 240, 736, 0, 2, 0, 241] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1050.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mn-pinctrl.example.dtb: pinctrl@30330000: uart2grp:fsl,pins:0: [572, 1188, 1276, 0, 0, 320, 576, 1192, 0, 0, 0, 320] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mn-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.example.dtb: pinctrl@30330000: uart1grp:fsl,pins:0: [564, 1180, 1268, 0, 0, 73, 568, 1184, 1268, 0, 0, 73] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.example.dtb: pinctrl@30330000: uart2grp:fsl,pins:0: [572, 1188, 1276, 0, 0, 320, 576, 1192, 0, 0, 0, 320] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp-pinctrl.example.dtb: pinctrl@30330000: uart2grp:fsl,pins:0: [552, 1160, 1520, 0, 6, 73, 552, 1160, 0, 0, 0, 73] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp-pinctrl.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Viorel Suman (OSS)" <viorel.suman@oss.nxp.com>
Cc: linux-clk@vger.kernel.org, Abel Vesa <abelvesa@kernel.org>,
	 linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	 "Rafael J. Wysocki" <rafael@kernel.org>,
	Liu Ying <victor.liu@nxp.com>,
	 linux-arm-kernel@lists.infradead.org,
	Peng Fan <peng.fan@nxp.com>,  Shawn Guo <shawnguo@kernel.org>,
	Mirela Rabulea <mirela.rabulea@nxp.com>,
	 Linus Walleij <linus.walleij@linaro.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	 Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Viorel Suman <viorel.suman@nxp.com>,
	 Michael Turquette <mturquette@baylibre.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	 Amit Kucheria <amitk@kernel.org>,
	linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org,
	 Wim Van Sebroeck <wim@linux-watchdog.org>,
	 Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Dong Aisheng <aisheng.dong@nxp.com>,
	 linux-watchdog@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
	 NXP Linux Team <linux-imx@nxp.com>,
	linux-gpio@vger.kernel.org,
	 Alessandro Zummo <a.zummo@towertech.it>,
	Abel Vesa <abel.vesa@nxp.com>, Stefan Agner <stefan@agner.ch>,
	 devicetree@vger.kernel.org,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	 Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Ming Qian <ming.qian@nxp.com>,  Zhang Rui <rui.zhang@intel.com>,
	Fabio Estevam <festevam@gmail.com>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Guenter Roeck <linux@roeck-us.net>,
	 linux-input@vger.kernel.org,
	Oliver Graute <oliver.graute@kococonnector.com>
Subject: Re: [PATCH v7 02/15] dt-bindings: pinctrl: imx: Add fsl,scu-iomux yaml file
Date: Mon, 04 Jul 2022 18:50:55 -0600	[thread overview]
Message-ID: <1656982255.094130.640439.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220704161541.943696-3-viorel.suman@oss.nxp.com>

On Mon, 04 Jul 2022 19:15:28 +0300, Viorel Suman (OSS) wrote:
> From: Abel Vesa <abel.vesa@nxp.com>
> 
> In order to replace the fsl,scu txt file from bindings/arm/freescale,
> we need to split it between the right subsystems. This patch documents
> separately the 'iomux/pinctrl' child node of the SCU main node.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> ---
>  .../bindings/arm/freescale/fsl,scu.txt        | 40 ----------
>  .../bindings/pinctrl/fsl,scu-pinctrl.yaml     | 74 +++++++++++++++++++
>  2 files changed, 74 insertions(+), 40 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.example.dtb: iomuxc@400e8000: lpuart1grp:fsl,pins:0: [364, 944, 1568, 0, 0, 241, 368, 948, 1564, 0, 0, 241] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1170.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.example.dtb: pinctrl: lpuart0grp:fsl,pins:0: [111, 0, 100663328, 112, 0, 100663328] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx93-pinctrl.example.dtb: pinctrl@443c0000: uart3grp:fsl,pins:0: [72, 504, 1052, 1, 0, 73, 76, 508, 1048, 1, 0, 73] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx93-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.example.dtb: pinctrl@30330000: uart5grp:fsl,pins:0: [352, 976, 1812, 1, 0, 126, 356, 980, 0, 1, 0, 118] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.example.dtb: pinctrl@302c0000: gpio1-grp:fsl,pins:0: [8, 56, 0, 0, 0, 89, 12, 60, 0, 0, 0, 89] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1050.example.dtb: iomuxc@401f8000: lpuart1grp:fsl,pins:0: [236, 732, 0, 2, 0, 241, 240, 736, 0, 2, 0, 241] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imxrt1050.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mn-pinctrl.example.dtb: pinctrl@30330000: uart2grp:fsl,pins:0: [572, 1188, 1276, 0, 0, 320, 576, 1192, 0, 0, 0, 320] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mn-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.example.dtb: pinctrl@30330000: uart1grp:fsl,pins:0: [564, 1180, 1268, 0, 0, 73, 568, 1184, 1268, 0, 0, 73] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.example.dtb: pinctrl@30330000: uart2grp:fsl,pins:0: [572, 1188, 1276, 0, 0, 320, 576, 1192, 0, 0, 0, 320] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mm-pinctrl.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp-pinctrl.example.dtb: pinctrl@30330000: uart2grp:fsl,pins:0: [552, 1160, 1520, 0, 6, 73, 552, 1160, 0, 0, 0, 73] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/fsl,imx8mp-pinctrl.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-07-05  0:51 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-04 16:15 [PATCH v7 00/15] dt-bindings: arm: freescale: Switch fsl,scu from txt to yaml Viorel Suman (OSS)
2022-07-04 16:15 ` Viorel Suman (OSS)
2022-07-04 16:15 ` [PATCH v7 01/15] dt-bindings: clk: imx: Add fsl,scu-clk yaml file Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)
2022-07-06  8:27   ` Krzysztof Kozlowski
2022-07-06  8:27     ` Krzysztof Kozlowski
2022-07-06  8:44     ` Viorel Suman
2022-07-06  8:44       ` Viorel Suman
2022-07-04 16:15 ` [PATCH v7 02/15] dt-bindings: pinctrl: imx: Add fsl,scu-iomux " Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)
2022-07-05  0:50   ` Rob Herring [this message]
2022-07-05  0:50     ` Rob Herring
2022-07-06  8:31   ` Krzysztof Kozlowski
2022-07-06  8:31     ` Krzysztof Kozlowski
2022-07-04 16:15 ` [PATCH v7 03/15] dt-bindings: input: Add fsl,scu-key " Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)
2022-07-04 16:15 ` [PATCH v7 04/15] dt-bindings: nvmem: Add fsl,scu-ocotp " Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)
2022-07-04 16:15 ` [PATCH v7 05/15] dt-bindings: power: Add fsl,scu-pd " Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)
2022-07-04 16:15 ` [PATCH v7 06/15] dt-bindings: rtc: Add fsl,scu-rtc " Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)
2022-07-04 18:10   ` Alexandre Belloni
2022-07-04 18:10     ` Alexandre Belloni
2022-07-04 16:15 ` [PATCH v7 07/15] dt-bindings: thermal: Add fsl,scu-thermal " Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)
2022-07-04 16:15 ` [PATCH v7 08/15] dt-bindings: watchdog: Add fsl,scu-wdt " Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)
2022-07-04 16:15 ` [PATCH v7 09/15] dt-bindings: firmware: Add fsl,scu " Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)
2022-07-06 14:36   ` Rob Herring
2022-07-06 14:36     ` Rob Herring
2022-07-06 17:16     ` Viorel Suman
2022-07-06 17:16       ` Viorel Suman
2022-07-04 16:15 ` [PATCH v7 10/15] arm64: dts: freescale: imx8qxp: Remove unnecessary clock related entries Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)
2022-07-04 16:15 ` [PATCH v7 11/15] arm64: dts: freescale: imx8: Fix power controller name Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)
2022-07-04 16:15 ` [PATCH v7 12/15] arm64: dts: freescale: imx8qxp: Add fallback compatible for clock controller Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)
2022-07-04 16:15 ` [PATCH v7 13/15] arm64: dts: freescale: imx8qxp: Fix the ocotp node name Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)
2022-07-04 16:15 ` [PATCH v7 14/15] arm64: dts: freescale: imx8: Fix the system-controller " Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)
2022-07-04 16:15 ` [PATCH v7 15/15] arm64: dts: freescale: imx8qxp: Fix the keys " Viorel Suman (OSS)
2022-07-04 16:15   ` Viorel Suman (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1656982255.094130.640439.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=a.zummo@towertech.it \
    --cc=abel.vesa@nxp.com \
    --cc=abelvesa@kernel.org \
    --cc=aisheng.dong@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=ming.qian@nxp.com \
    --cc=mirela.rabulea@nxp.com \
    --cc=mturquette@baylibre.com \
    --cc=oliver.graute@kococonnector.com \
    --cc=peng.fan@nxp.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=stefan@agner.ch \
    --cc=victor.liu@nxp.com \
    --cc=viorel.suman@nxp.com \
    --cc=viorel.suman@oss.nxp.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.