* [PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property
@ 2022-07-07 11:07 Jayesh Choudhary
2022-07-08 21:32 ` Rob Herring
2022-07-11 11:11 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Jayesh Choudhary @ 2022-07-07 11:07 UTC (permalink / raw)
To: herbert, davem
Cc: robh+dt, krzysztof.kozlowski+dt, j-keerthy, linux-crypto,
devicetree, linux-kernel, vigneshr, j-choudhary
crypto driver itself is not dma-coherent. It is the dmaengine
that moves data and the buffers are to be mapped to the
dmaengine provider. So this property should be dropped.
Fixes: 2ce9a7299bf6 ('dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation')
Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---
.../devicetree/bindings/crypto/ti,sa2ul.yaml | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
index 02f47c2e7998..0c15fefb6671 100644
--- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
+++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
@@ -35,8 +35,6 @@ properties:
- const: rx1
- const: rx2
- dma-coherent: true
-
"#address-cells":
const: 2
@@ -72,16 +70,6 @@ required:
- dmas
- dma-names
-if:
- properties:
- compatible:
- enum:
- - ti,j721e-sa2ul
- - ti,am654-sa2ul
-then:
- required:
- - dma-coherent
-
additionalProperties: false
examples:
@@ -95,5 +83,4 @@ examples:
dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
<&main_udmap 0x4001>;
dma-names = "tx", "rx1", "rx2";
- dma-coherent;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property
2022-07-07 11:07 [PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property Jayesh Choudhary
@ 2022-07-08 21:32 ` Rob Herring
2022-07-11 9:06 ` Jayesh Choudhary
2022-07-11 11:11 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2022-07-08 21:32 UTC (permalink / raw)
To: Jayesh Choudhary
Cc: linux-kernel, linux-crypto, krzysztof.kozlowski+dt, devicetree,
vigneshr, davem, robh+dt, herbert, j-keerthy
On Thu, 07 Jul 2022 16:37:56 +0530, Jayesh Choudhary wrote:
> crypto driver itself is not dma-coherent. It is the dmaengine
> that moves data and the buffers are to be mapped to the
> dmaengine provider. So this property should be dropped.
>
> Fixes: 2ce9a7299bf6 ('dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation')
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
> .../devicetree/bindings/crypto/ti,sa2ul.yaml | 13 -------------
> 1 file changed, 13 deletions(-)
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/
crypto@4e00000: 'dma-coherent' does not match any of the regexes: '^rng@[a-f0-9]+$', 'pinctrl-[0-9]+'
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dtb
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dtb
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dtb
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dtb
arch/arm64/boot/dts/ti/k3-am654-base-board.dtb
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb
arch/arm64/boot/dts/ti/k3-j721e-sk.dtb
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property
2022-07-08 21:32 ` Rob Herring
@ 2022-07-11 9:06 ` Jayesh Choudhary
2022-08-01 4:50 ` Jayesh Choudhary
0 siblings, 1 reply; 5+ messages in thread
From: Jayesh Choudhary @ 2022-07-11 9:06 UTC (permalink / raw)
To: Rob Herring
Cc: linux-kernel, linux-crypto, krzysztof.kozlowski+dt, devicetree,
vigneshr, davem, robh+dt, herbert, j-keerthy
Hi Rob,
On 09/07/22 3:02 am, Rob Herring wrote:
> On Thu, 07 Jul 2022 16:37:56 +0530, Jayesh Choudhary wrote:
>> crypto driver itself is not dma-coherent. It is the dmaengine
>> that moves data and the buffers are to be mapped to the
>> dmaengine provider. So this property should be dropped.
>>
>> Fixes: 2ce9a7299bf6 ('dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation')
>> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
>> ---
>> .../devicetree/bindings/crypto/ti,sa2ul.yaml | 13 -------------
>> 1 file changed, 13 deletions(-)
>>
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/
>
>
> crypto@4e00000: 'dma-coherent' does not match any of the regexes: '^rng@[a-f0-9]+$', 'pinctrl-[0-9]+'
> arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dtb
> arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dtb
> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dtb
> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dtb
> arch/arm64/boot/dts/ti/k3-am654-base-board.dtb
> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb
> arch/arm64/boot/dts/ti/k3-j721e-sk.dtb
>
These warnings are expected. dt-node fixes need to be there.
I will send the dt-node fixes once this patch gets in due to
dependency. Or should I proceed any other way?
Thanks,
Jayesh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property
2022-07-11 9:06 ` Jayesh Choudhary
@ 2022-08-01 4:50 ` Jayesh Choudhary
0 siblings, 0 replies; 5+ messages in thread
From: Jayesh Choudhary @ 2022-08-01 4:50 UTC (permalink / raw)
To: Rob Herring, krzysztof.kozlowski+dt
Cc: linux-kernel, linux-crypto, devicetree, vigneshr, davem, robh+dt,
herbert, j-keerthy
Rob,
On 11/07/22 14:36, Jayesh Choudhary wrote:
> Hi Rob,
>
> On 09/07/22 3:02 am, Rob Herring wrote:
>> On Thu, 07 Jul 2022 16:37:56 +0530, Jayesh Choudhary wrote:
>>> crypto driver itself is not dma-coherent. It is the dmaengine
>>> that moves data and the buffers are to be mapped to the
>>> dmaengine provider. So this property should be dropped.
>>>
>>> Fixes: 2ce9a7299bf6 ('dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation')
>>> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
>>> ---
>>> .../devicetree/bindings/crypto/ti,sa2ul.yaml | 13 -------------
>>> 1 file changed, 13 deletions(-)
>>>
>>
>> Running 'make dtbs_check' with the schema in this patch gives the
>> following warnings. Consider if they are expected or the schema is
>> incorrect. These may not be new warnings.
>>
>> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
>> This will change in the future.
>>
>> Full log is available here: https://patchwork.ozlabs.org/patch/
>>
>>
>> crypto@4e00000: 'dma-coherent' does not match any of the regexes: '^rng@[a-f0-9]+$', 'pinctrl-[0-9]+'
>> arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dtb
>> arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dtb
>> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dtb
>> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dtb
>> arch/arm64/boot/dts/ti/k3-am654-base-board.dtb
>> arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb
>> arch/arm64/boot/dts/ti/k3-j721e-sk.dtb
>>
>
> These warnings are expected. dt-node fixes need to be there.
> I will send the dt-node fixes once this patch gets in due to
> dependency. Or should I proceed any other way?
>
> Thanks,
> Jayesh
This patch is ACKed and there are no other comments.
Can this patch be merged so that I can move forward with dt node
fixes or do you have any other comments on this?
Regards,
Jayesh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property
2022-07-07 11:07 [PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property Jayesh Choudhary
2022-07-08 21:32 ` Rob Herring
@ 2022-07-11 11:11 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-11 11:11 UTC (permalink / raw)
To: Jayesh Choudhary, herbert, davem
Cc: robh+dt, krzysztof.kozlowski+dt, j-keerthy, linux-crypto,
devicetree, linux-kernel, vigneshr
On 07/07/2022 13:07, Jayesh Choudhary wrote:
> crypto driver itself is not dma-coherent. It is the dmaengine
> that moves data and the buffers are to be mapped to the
> dmaengine provider. So this property should be dropped.
>
> Fixes: 2ce9a7299bf6 ('dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation')
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
> .../devicetree/bindings/crypto/ti,sa2ul.yaml | 13 -------------
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-01 4:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-07 11:07 [PATCH] dt-bindings: crypto: ti,sa2ul: drop dma-coherent property Jayesh Choudhary
2022-07-08 21:32 ` Rob Herring
2022-07-11 9:06 ` Jayesh Choudhary
2022-08-01 4:50 ` Jayesh Choudhary
2022-07-11 11:11 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.