All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] Bluetooth: hci_sync: Correct hci_set_event_mask_page_2_sync() event mask
@ 2022-07-13  6:53 Zijun Hu
  2022-07-13  7:56 ` [v1] " bluez.test.bot
  2022-07-20 16:50 ` [PATCH v1] " patchwork-bot+bluetooth
  0 siblings, 2 replies; 3+ messages in thread
From: Zijun Hu @ 2022-07-13  6:53 UTC (permalink / raw)
  To: marcel, johan.hedberg, luiz.dentz, davem, edumazet, kuba, pabeni,
	luiz.von.dentz, quic_zijuhu
  Cc: linux-kernel, linux-bluetooth, linux-arm-msm, netdev

Event HCI_Truncated_Page_Complete should belong to central
and HCI_Peripheral_Page_Response_Timeout should belong to
peripheral, but hci_set_event_mask_page_2_sync() take these
two events for wrong roles, so correct it by this change.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
 net/bluetooth/hci_sync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 7cb310051879..c72533bb9834 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -3602,7 +3602,7 @@ static int hci_set_event_mask_page_2_sync(struct hci_dev *hdev)
 	if (lmp_cpb_central_capable(hdev)) {
 		events[1] |= 0x40;	/* Triggered Clock Capture */
 		events[1] |= 0x80;	/* Synchronization Train Complete */
-		events[2] |= 0x10;	/* Peripheral Page Response Timeout */
+		events[2] |= 0x08;	/* Truncated Page Complete */
 		events[2] |= 0x20;	/* CPB Channel Map Change */
 		changed = true;
 	}
@@ -3614,7 +3614,7 @@ static int hci_set_event_mask_page_2_sync(struct hci_dev *hdev)
 		events[2] |= 0x01;	/* Synchronization Train Received */
 		events[2] |= 0x02;	/* CPB Receive */
 		events[2] |= 0x04;	/* CPB Timeout */
-		events[2] |= 0x08;	/* Truncated Page Complete */
+		events[2] |= 0x10;	/* Peripheral Page Response Timeout */
 		changed = true;
 	}
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [v1] Bluetooth: hci_sync: Correct hci_set_event_mask_page_2_sync() event mask
  2022-07-13  6:53 [PATCH v1] Bluetooth: hci_sync: Correct hci_set_event_mask_page_2_sync() event mask Zijun Hu
@ 2022-07-13  7:56 ` bluez.test.bot
  2022-07-20 16:50 ` [PATCH v1] " patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2022-07-13  7:56 UTC (permalink / raw)
  To: linux-bluetooth, quic_zijuhu

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=659174

---Test result---

Test Summary:
CheckPatch                    PASS      1.85 seconds
GitLint                       PASS      0.94 seconds
SubjectPrefix                 PASS      0.82 seconds
BuildKernel                   PASS      29.89 seconds
BuildKernel32                 PASS      25.76 seconds
Incremental Build with patchesPASS      35.02 seconds
TestRunner: Setup             PASS      429.54 seconds
TestRunner: l2cap-tester      PASS      16.44 seconds
TestRunner: bnep-tester       PASS      5.55 seconds
TestRunner: mgmt-tester       PASS      90.61 seconds
TestRunner: rfcomm-tester     PASS      8.67 seconds
TestRunner: sco-tester        PASS      8.44 seconds
TestRunner: smp-tester        PASS      8.60 seconds
TestRunner: userchan-tester   PASS      5.68 seconds



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] Bluetooth: hci_sync: Correct hci_set_event_mask_page_2_sync() event mask
  2022-07-13  6:53 [PATCH v1] Bluetooth: hci_sync: Correct hci_set_event_mask_page_2_sync() event mask Zijun Hu
  2022-07-13  7:56 ` [v1] " bluez.test.bot
@ 2022-07-20 16:50 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2022-07-20 16:50 UTC (permalink / raw)
  To: Zijun Hu
  Cc: marcel, johan.hedberg, luiz.dentz, davem, edumazet, kuba, pabeni,
	luiz.von.dentz, linux-kernel, linux-bluetooth, linux-arm-msm,
	netdev

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 13 Jul 2022 14:53:14 +0800 you wrote:
> Event HCI_Truncated_Page_Complete should belong to central
> and HCI_Peripheral_Page_Response_Timeout should belong to
> peripheral, but hci_set_event_mask_page_2_sync() take these
> two events for wrong roles, so correct it by this change.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> 
> [...]

Here is the summary with links:
  - [v1] Bluetooth: hci_sync: Correct hci_set_event_mask_page_2_sync() event mask
    https://git.kernel.org/bluetooth/bluetooth-next/c/f7913b8db3c4

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-07-20 16:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13  6:53 [PATCH v1] Bluetooth: hci_sync: Correct hci_set_event_mask_page_2_sync() event mask Zijun Hu
2022-07-13  7:56 ` [v1] " bluez.test.bot
2022-07-20 16:50 ` [PATCH v1] " patchwork-bot+bluetooth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.