All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH] lib/chamelium: Support MST connectors on reprobe by using connector name
@ 2022-07-20 15:19 Mark Yacoub
  2022-07-20 16:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 15+ messages in thread
From: Mark Yacoub @ 2022-07-20 15:19 UTC (permalink / raw)
  To: igt-dev
  Cc: robdclark, petri.latvala, ihf, amstan, seanpaul,
	khaled.almahallawy, markyacoub

[Why]
On unplug, a lone MST connector can become invalid and disappear from
the list of DRM connectors.
When this happens, we can't check for the connector ID as it's no longer
there to check.
Hence, a connector disappearance indicates a disconnect.

Furthermore, on a replug, the connector ID can change as well. The only
thing that remains unchageable is the connector name.

[How]
Do not check for connector connetion state using the connector ID.
Iterate through the current connectors and match with the name.
If a connector disappeared, this means it's now disconnected.
If it's there, return its connection status.
Update the port connector ID with the current connector ID in case it
changed on a replug.

Tested on Volteer with Chamelium V3 connected via a 2-DP-port CableMatters
hub.
Test: kms_chamelium --run-subtest dp-hpd

Signed-off-by: Mark Yacoub <markyacoub@chromium.org>
---
 lib/igt_chamelium.c | 52 +++++++++++++++++++++++++++++++++++++++------
 1 file changed, 45 insertions(+), 7 deletions(-)

diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index d78ddd61..b5e9bbfd 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -266,21 +266,59 @@ chamelium_reprobe_connector(igt_display_t *display,
 			    struct chamelium_port *port)
 {
 	drmModeConnector *connector;
-	drmModeConnection status;
+	drmModeConnection connection_status;
 	igt_output_t *output;
+	drmModeRes* res = drmModeGetResources(display->drm_fd);
+	bool is_connector_found = false;
+	int i;
 
 	igt_debug("Reprobing %s...\n", chamelium_port_get_name(port));
-	connector = chamelium_port_get_connector(chamelium, port, true);
+	for (i = 0; i < res->count_connectors; ++i) {
+		connector = drmModeGetConnector(display->drm_fd, res->connectors[i]);
+		/* If the connector is MST and is now unplugged, the spawned connectors will no
+		   longer be available but can still be counted as part of res->count_connectors */
+		if (!connector) {
+			drmModeFreeConnector(connector);
+			connector = NULL;
+			continue;
+		}
+
+		char connector_name[50];
+		snprintf(connector_name, 50, "%s-%u",
+			kmstest_connector_type_str(connector->connector_type),
+			connector->connector_type_id);
+		if (strcmp(connector_name, port->name) == 0) {
+			is_connector_found = true;
+			break;
+		}
+
+		drmModeFreeConnector(connector);
+		connector = NULL;
+	}
+	drmModeFreeResources(res);
+
+	if (!is_connector_found) {
+		igt_debug("Connector is not found. This indicates it's disconnected.\n");
+		igt_assert(!connector);
+		return DRM_MODE_DISCONNECTED;
+	}
+
 	igt_assert(connector);
-	status = connector->connection;
+	connection_status = connector->connection;
 
-	/* let's make sure that igt_display is up to date too */
+	/* If we still have a connector, let's make sure that igt_display and the port are up to date too */
 	output = igt_output_from_connector(display, connector);
-	output->force_reprobe = true;
-	igt_output_refresh(output);
+	if (output) {
+		output->force_reprobe = true;
+		igt_output_refresh(output);
+	}
+
+	/* If the topology of the connector is MST, the connector ID could have changed. Update the
+	   chamelium port to the current connector ID. */
+	port->connector_id = connector->connector_id;
 
 	drmModeFreeConnector(connector);
-	return status;
+	return connection_status;
 }
 
 /**
-- 
2.37.0.170.g444d1eabd0-goog

^ permalink raw reply related	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-08-22 21:45 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-20 15:19 [igt-dev] [PATCH] lib/chamelium: Support MST connectors on reprobe by using connector name Mark Yacoub
2022-07-20 16:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-07-21  0:43 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-21 15:22   ` Mark Yacoub
2022-07-21 18:01 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2022-07-26 23:26 ` [igt-dev] [PATCH] " Lyude Paul
2022-07-27 19:37   ` Mark Yacoub
2022-08-01 20:03     ` Lyude Paul
2022-08-15 19:54       ` Mark Yacoub
2022-08-01 11:49 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/chamelium: Support MST connectors on reprobe by using connector name (rev2) Patchwork
2022-08-01 14:52 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-08-15 19:47 ` [igt-dev] [PATCH v2] lib/chamelium: Use MST Path property to reprobe an MST connector Mark Yacoub
2022-08-22 21:45   ` Lyude Paul
2022-08-15 20:22 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/chamelium: Support MST connectors on reprobe by using connector name (rev3) Patchwork
2022-08-16  6:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.