From: "Heiko Stübner" <heiko@sntech.de> To: Meng Dongyang <daniel.meng@rock-chips.com> Cc: robh+dt@kernel.org, mark.rutland@arm.com, geert+renesas@glider.be, yoshihiro.shimoda.uh@renesas.com, martin.blumenstingl@googlemail.com, devicetree@vger.kernel.org, kishon@ti.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, huangtao@rock-chips.com, kever.yang@rock-chips.com, william.wu@rock-chips.com, frank.wang@rock-chips.com Subject: Re: [PATCH v3 3/3] phy: rockchip-inno-usb2: add support of usb2-phy for rk3328 Date: Mon, 06 Mar 2017 05:21:28 +0100 [thread overview] Message-ID: <1658444.PfTs9q7449@diego> (raw) In-Reply-To: <1488763778-27499-4-git-send-email-daniel.meng@rock-chips.com> Am Montag, 6. März 2017, 09:29:38 CET schrieb Meng Dongyang: > Add usb2-phy config information in the data of match table for > rk3328. > > Changes in v2: > - add support of otg port > Changes in v3: > - remove tuning function and id pin configs > > Signed-off-by: Meng Dongyang <daniel.meng@rock-chips.com> I didn't double check every individual register value, but overall this looks correct, so Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > drivers/phy/phy-rockchip-inno-usb2.c | 44 > ++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) > > diff --git a/drivers/phy/phy-rockchip-inno-usb2.c > b/drivers/phy/phy-rockchip-inno-usb2.c index 4ea95c2..257c5d9 100644 > --- a/drivers/phy/phy-rockchip-inno-usb2.c > +++ b/drivers/phy/phy-rockchip-inno-usb2.c > @@ -1141,6 +1141,49 @@ static int rockchip_usb2phy_probe(struct > platform_device *pdev) return ret; > } > > +static const struct rockchip_usb2phy_cfg rk3328_phy_cfgs[] = { > + { > + .reg = 0x100, > + .num_ports = 2, > + .clkout_ctl = { 0x108, 4, 4, 1, 0 }, > + .port_cfgs = { > + [USB2PHY_PORT_OTG] = { > + .phy_sus = { 0x0100, 15, 0, 0, 0x1d1 }, > + .bvalid_det_en = { 0x0110, 2, 2, 0, 1 }, > + .bvalid_det_st = { 0x0114, 2, 2, 0, 1 }, > + .bvalid_det_clr = { 0x0118, 2, 2, 0, 1 }, > + .ls_det_en = { 0x0110, 0, 0, 0, 1 }, > + .ls_det_st = { 0x0114, 0, 0, 0, 1 }, > + .ls_det_clr = { 0x0118, 0, 0, 0, 1 }, > + .utmi_avalid = { 0x0120, 10, 10, 0, 1 }, > + .utmi_bvalid = { 0x0120, 9, 9, 0, 1 }, > + .utmi_ls = { 0x0120, 5, 4, 0, 1 }, > + }, > + [USB2PHY_PORT_HOST] = { > + .phy_sus = { 0x104, 15, 0, 0, 0x1d1 }, > + .ls_det_en = { 0x110, 1, 1, 0, 1 }, > + .ls_det_st = { 0x114, 1, 1, 0, 1 }, > + .ls_det_clr = { 0x118, 1, 1, 0, 1 }, > + .utmi_ls = { 0x120, 17, 16, 0, 1 }, > + .utmi_hstdet = { 0x120, 19, 19, 0, 1 } > + } > + }, > + .chg_det = { > + .opmode = { 0x0100, 3, 0, 5, 1 }, > + .cp_det = { 0x0120, 24, 24, 0, 1 }, > + .dcp_det = { 0x0120, 23, 23, 0, 1 }, > + .dp_det = { 0x0120, 25, 25, 0, 1 }, > + .idm_sink_en = { 0x0108, 8, 8, 0, 1 }, > + .idp_sink_en = { 0x0108, 7, 7, 0, 1 }, > + .idp_src_en = { 0x0108, 9, 9, 0, 1 }, > + .rdm_pdwn_en = { 0x0108, 10, 10, 0, 1 }, > + .vdm_src_en = { 0x0108, 12, 12, 0, 1 }, > + .vdp_src_en = { 0x0108, 11, 11, 0, 1 }, > + }, > + }, > + { /* sentinel */ } > +}; > + > static const struct rockchip_usb2phy_cfg rk3366_phy_cfgs[] = { > { > .reg = 0x700, > @@ -1223,6 +1266,7 @@ static int rockchip_usb2phy_probe(struct > platform_device *pdev) }; > > static const struct of_device_id rockchip_usb2phy_dt_match[] = { > + { .compatible = "rockchip,rk3328-usb2phy", .data = &rk3328_phy_cfgs }, > { .compatible = "rockchip,rk3366-usb2phy", .data = &rk3366_phy_cfgs }, > { .compatible = "rockchip,rk3399-usb2phy", .data = &rk3399_phy_cfgs }, > {}
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> To: Meng Dongyang <daniel.meng-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org, martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org, yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kishon-l0cyMroinI0@public.gmane.org, kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org, william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org Subject: Re: [PATCH v3 3/3] phy: rockchip-inno-usb2: add support of usb2-phy for rk3328 Date: Mon, 06 Mar 2017 05:21:28 +0100 [thread overview] Message-ID: <1658444.PfTs9q7449@diego> (raw) In-Reply-To: <1488763778-27499-4-git-send-email-daniel.meng-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Am Montag, 6. März 2017, 09:29:38 CET schrieb Meng Dongyang: > Add usb2-phy config information in the data of match table for > rk3328. > > Changes in v2: > - add support of otg port > Changes in v3: > - remove tuning function and id pin configs > > Signed-off-by: Meng Dongyang <daniel.meng-TNX95d0MmH7DzftRWevZcw@public.gmane.org> I didn't double check every individual register value, but overall this looks correct, so Reviewed-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> > --- > drivers/phy/phy-rockchip-inno-usb2.c | 44 > ++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) > > diff --git a/drivers/phy/phy-rockchip-inno-usb2.c > b/drivers/phy/phy-rockchip-inno-usb2.c index 4ea95c2..257c5d9 100644 > --- a/drivers/phy/phy-rockchip-inno-usb2.c > +++ b/drivers/phy/phy-rockchip-inno-usb2.c > @@ -1141,6 +1141,49 @@ static int rockchip_usb2phy_probe(struct > platform_device *pdev) return ret; > } > > +static const struct rockchip_usb2phy_cfg rk3328_phy_cfgs[] = { > + { > + .reg = 0x100, > + .num_ports = 2, > + .clkout_ctl = { 0x108, 4, 4, 1, 0 }, > + .port_cfgs = { > + [USB2PHY_PORT_OTG] = { > + .phy_sus = { 0x0100, 15, 0, 0, 0x1d1 }, > + .bvalid_det_en = { 0x0110, 2, 2, 0, 1 }, > + .bvalid_det_st = { 0x0114, 2, 2, 0, 1 }, > + .bvalid_det_clr = { 0x0118, 2, 2, 0, 1 }, > + .ls_det_en = { 0x0110, 0, 0, 0, 1 }, > + .ls_det_st = { 0x0114, 0, 0, 0, 1 }, > + .ls_det_clr = { 0x0118, 0, 0, 0, 1 }, > + .utmi_avalid = { 0x0120, 10, 10, 0, 1 }, > + .utmi_bvalid = { 0x0120, 9, 9, 0, 1 }, > + .utmi_ls = { 0x0120, 5, 4, 0, 1 }, > + }, > + [USB2PHY_PORT_HOST] = { > + .phy_sus = { 0x104, 15, 0, 0, 0x1d1 }, > + .ls_det_en = { 0x110, 1, 1, 0, 1 }, > + .ls_det_st = { 0x114, 1, 1, 0, 1 }, > + .ls_det_clr = { 0x118, 1, 1, 0, 1 }, > + .utmi_ls = { 0x120, 17, 16, 0, 1 }, > + .utmi_hstdet = { 0x120, 19, 19, 0, 1 } > + } > + }, > + .chg_det = { > + .opmode = { 0x0100, 3, 0, 5, 1 }, > + .cp_det = { 0x0120, 24, 24, 0, 1 }, > + .dcp_det = { 0x0120, 23, 23, 0, 1 }, > + .dp_det = { 0x0120, 25, 25, 0, 1 }, > + .idm_sink_en = { 0x0108, 8, 8, 0, 1 }, > + .idp_sink_en = { 0x0108, 7, 7, 0, 1 }, > + .idp_src_en = { 0x0108, 9, 9, 0, 1 }, > + .rdm_pdwn_en = { 0x0108, 10, 10, 0, 1 }, > + .vdm_src_en = { 0x0108, 12, 12, 0, 1 }, > + .vdp_src_en = { 0x0108, 11, 11, 0, 1 }, > + }, > + }, > + { /* sentinel */ } > +}; > + > static const struct rockchip_usb2phy_cfg rk3366_phy_cfgs[] = { > { > .reg = 0x700, > @@ -1223,6 +1266,7 @@ static int rockchip_usb2phy_probe(struct > platform_device *pdev) }; > > static const struct of_device_id rockchip_usb2phy_dt_match[] = { > + { .compatible = "rockchip,rk3328-usb2phy", .data = &rk3328_phy_cfgs }, > { .compatible = "rockchip,rk3366-usb2phy", .data = &rk3366_phy_cfgs }, > { .compatible = "rockchip,rk3399-usb2phy", .data = &rk3399_phy_cfgs }, > {}
next prev parent reply other threads:[~2017-03-06 5:00 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-06 1:29 [PATCH v3 0/3] add support of usb2-phy for rk3328 Meng Dongyang 2017-03-06 1:29 ` Meng Dongyang 2017-03-06 1:29 ` [PATCH v3 1/3] dt-bindings: phy: add assign clock property in usb2-phy node Meng Dongyang 2017-03-06 1:29 ` Meng Dongyang 2017-03-06 3:57 ` Heiko Stübner 2017-03-06 3:57 ` Heiko Stübner 2017-03-06 1:29 ` [PATCH v3 2/3] dt-bindings: phy: add DT bindings for usb2-phy grf Meng Dongyang 2017-03-06 1:29 ` Meng Dongyang 2017-03-06 3:59 ` Heiko Stübner 2017-03-06 3:59 ` Heiko Stübner 2017-03-15 20:05 ` Rob Herring 2017-03-15 20:05 ` Rob Herring 2017-03-06 1:29 ` [PATCH v3 3/3] phy: rockchip-inno-usb2: add support of usb2-phy for rk3328 Meng Dongyang 2017-03-06 1:29 ` Meng Dongyang 2017-03-06 4:21 ` Heiko Stübner [this message] 2017-03-06 4:21 ` Heiko Stübner 2017-04-05 11:24 ` [PATCH v3 0/3] " Kishon Vijay Abraham I 2017-04-05 11:24 ` Kishon Vijay Abraham I
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1658444.PfTs9q7449@diego \ --to=heiko@sntech.de \ --cc=daniel.meng@rock-chips.com \ --cc=devicetree@vger.kernel.org \ --cc=frank.wang@rock-chips.com \ --cc=geert+renesas@glider.be \ --cc=huangtao@rock-chips.com \ --cc=kever.yang@rock-chips.com \ --cc=kishon@ti.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=martin.blumenstingl@googlemail.com \ --cc=robh+dt@kernel.org \ --cc=william.wu@rock-chips.com \ --cc=yoshihiro.shimoda.uh@renesas.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.