[PATCH v2 net-next] net: ipv6: avoid accepting values greater than 2 for accept_untracked_na

* [PATCH v2 net-next] net: ipv6: avoid accepting values greater than 2 for accept_untracked_na
@ 2022-07-20 18:36 Jaehee Park
  2022-07-21  7:09 ` Nicolas Dichtel
  2022-07-22  2:20 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Jaehee Park @ 2022-07-20 18:36 UTC (permalink / raw)
  To: netdev
  Cc: davem, yoshfuji, dsahern, dsahern, edumazet, kuba, pabeni, shuah,
	linux-kernel, aajith, roopa, roopa.prabhu, aroulin, sbrivio,
	jhpark1013, nicolas.dichtel

The accept_untracked_na sysctl changed from a boolean to an integer
when a new knob '2' was added. This patch provides a safeguard to avoid
accepting values that are not defined in the sysctl. When setting a
value greater than 2, the user will get an 'invalid argument' warning.

Signed-off-by: Jaehee Park <jhpark1013@gmail.com>
Suggested-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Suggested-by: Roopa Prabhu <roopa@nvidia.com>
---
v2
- got rid of unnecessary void cast in extra1 and extra2

 net/ipv6/addrconf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 6ed807b6c647..b624e3d8c5f0 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -7042,9 +7042,9 @@ static const struct ctl_table addrconf_sysctl[] = {
 		.data		= &ipv6_devconf.accept_untracked_na,
 		.maxlen		= sizeof(int),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec,
-		.extra1		= (void *)SYSCTL_ZERO,
-		.extra2		= (void *)SYSCTL_ONE,
+		.proc_handler	= proc_dointvec_minmax,
+		.extra1		= SYSCTL_ZERO,
+		.extra2		= SYSCTL_TWO,
 	},
 	{
 		/* sentinel */
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread