* [net PATCH v2] octeontx2-pf: Reduce minimum mtu size to 60
@ 2022-07-29 9:24 Naveen Mamindlapalli
2022-08-02 3:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Naveen Mamindlapalli @ 2022-07-29 9:24 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, richardcochran, netdev,
linux-kernel, sgoutham
Cc: Subbaraya Sundeep, Naveen Mamindlapalli
From: Subbaraya Sundeep <sbhatta@marvell.com>
PTP messages like SYNC, FOLLOW_UP, DELAY_REQ are of size 58 bytes.
Using a minimum packet length as 64 makes NIX to pad 6 bytes of
zeroes while transmission. This is causing latest ptp4l application to
emit errors since length in PTP header and received packet are not same.
Padding upto 3 bytes is fine but more than that makes ptp4l to assume
the pad bytes as a TLV. Hence reduce the size to 60 from 64.
Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>
Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
---
v2:
no code changes, added PTP maintainer also.
drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.h b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.h
index c88e8a436029..fbe62bbfb789 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.h
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.h
@@ -21,7 +21,7 @@
#define OTX2_HEAD_ROOM OTX2_ALIGN
#define OTX2_ETH_HLEN (VLAN_ETH_HLEN + VLAN_HLEN)
-#define OTX2_MIN_MTU 64
+#define OTX2_MIN_MTU 60
#define OTX2_MAX_GSO_SEGS 255
#define OTX2_MAX_FRAGS_IN_SQE 9
--
2.16.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net PATCH v2] octeontx2-pf: Reduce minimum mtu size to 60
2022-07-29 9:24 [net PATCH v2] octeontx2-pf: Reduce minimum mtu size to 60 Naveen Mamindlapalli
@ 2022-08-02 3:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-08-02 3:20 UTC (permalink / raw)
To: Naveen Mamindlapalli
Cc: davem, edumazet, kuba, pabeni, richardcochran, netdev,
linux-kernel, sgoutham, sbhatta
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 29 Jul 2022 14:54:57 +0530 you wrote:
> From: Subbaraya Sundeep <sbhatta@marvell.com>
>
> PTP messages like SYNC, FOLLOW_UP, DELAY_REQ are of size 58 bytes.
> Using a minimum packet length as 64 makes NIX to pad 6 bytes of
> zeroes while transmission. This is causing latest ptp4l application to
> emit errors since length in PTP header and received packet are not same.
> Padding upto 3 bytes is fine but more than that makes ptp4l to assume
> the pad bytes as a TLV. Hence reduce the size to 60 from 64.
>
> [...]
Here is the summary with links:
- [net,v2] octeontx2-pf: Reduce minimum mtu size to 60
https://git.kernel.org/netdev/net/c/53e99496abc1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-02 3:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-29 9:24 [net PATCH v2] octeontx2-pf: Reduce minimum mtu size to 60 Naveen Mamindlapalli
2022-08-02 3:20 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.