[GIT PULL] hwmon updates for v5.20

[GIT PULL] hwmon updates for v5.20

[Guenter Roeck]

Hi Linus,

I'll be traveling next week, so I am sending this pull request early,
in the hope that there won't be a v5.19-rc9.

Please pull hwmon updates for Linux v5.20 from signed tag:

    git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-for-v5.20

Thanks,
Guenter
------

The following changes since commit 88084a3df1672e131ddc1b4e39eeacfd39864acf:

  Linux 5.19-rc5 (2022-07-03 15:39:28 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git tags/hwmon-for-v5.20

for you to fetch changes up to cdbe34da01e32024e56fff5c6854a263a012d7ff:

  hwmon: (aquacomputer_d5next) Add support for Aquacomputer Quadro fan controller (2022-07-27 06:00:24 -0700)

----------------------------------------------------------------
hwmon updates for v5.20

- Substantial rewrite of lm90 driver to support several
  additional chips and improve support for existing chips.

- Add support of ROG ZENITH II EXTREME, Maximus XI Hero,
  Strix Z690-a D4 to asus-ec-sensors driver

- Add support of F71858AD to f71882fg driver

- Add support of Aquacomputer Quadro to aquacomputer_d5next
  driver

- Improved assembler code and add support for Dell G5 5590
  as well as XPS 13 7390 in dell-smm driver

- Add support for ASUS TUF GAMING B550-PLUS WIFI II to nct775 driver

- Add support for IEEE 754 half precision to PMBus core.
  Also support for Analog Devices LT7182S, improve
  regulator support, and report various MFR register
  values in debugfs.

- Various other minor improvements and fixes

----------------------------------------------------------------
Adam Wujek (2):
      hwmon: (pmbus) add a function to check the presence of a block register
      hwmon: (pmbus) add MFR_* registers to debugfs

Aleksa Savic (4):
      hwmon: (aquacomputer_d5next) Move device-specific data into struct aqc_data
      hwmon: (aquacomputer_d5next) Add D5 Next fan control support
      hwmon: (aquacomputer_d5next) Add support for reading the +12V voltage sensor on D5 Next
      hwmon: (aquacomputer_d5next) Add support for Aquacomputer Quadro fan controller

Aleksander Mazur (1):
      hwmon: (f71882fg) Add support for F71858AD (0x0903)

Alexandru Gagniuc (1):
      hwmon: (tps23861) fix byte order in current and voltage registers

Andy Shevchenko (2):
      hwmon: (nct6775) Drop duplicate NULL check in ->init() and ->exit()
      hwmon: (occ) Replace open-coded variant of %*phN specifier

Armin Wolf (5):
      hwmon: (sch56xx-common) Add DMI override table
      hwmon: (dell-smm) Add Dell XPS 13 7390 to fan control whitelist
      hwmon: (dell-smm) Add Dell G5 5590 to DMI table
      hwmon: (dell-smm) Improve assembly code
      hwmon: (dell-smm) Improve documentation

Christophe JAILLET (2):
      hwmon: (lm75) Replace kernel.h with the necessary inclusions
      hwmon: (asus_wmi_sensors) Save a few bytes of memory

Eugene Shalygin (1):
      hwmon: (asus-ec-sensors) add missing sensors for X570-I GAMING

Guenter Roeck (45):
      hwmon: (pmbus) Move pec attribute to I2C device
      hwmon: (lm90) Generate sysfs and udev events for all alarms
      hwmon: (lm90) Rework alarm/status handling
      hwmon: (lm90) Reorder include files in alphabetical order
      hwmon: (lm90) Reorder chip enumeration to be in alphabetical order
      hwmon: (lm90) Use BIT macro
      hwmon: (lm90) Move status register bit shifts to compile time
      hwmon: (lm90) Stop using R_/W_ register prefix
      hwmon: (lm90) Improve PEC support
      hwmon: (lm90) Add partial PEC support for ADT7461
      hwmon: (lm90) Enable full PEC support for ADT7461A
      hwmon: (lm90) Add support for unsigned and signed temperatures
      hwmon: (lm90) Only re-read registers if volatile
      hwmon: (lm90) Support multiple temperature resolutions
      hwmon: (lm90) Use single flag to indicate extended temperature support
      hwmon: (lm90) Rework detect function
      hwmon: (lm90) Add support for additional chip revision of NCT1008
      hwmon: (lm90) Fix/Add detection of G781-1
      hwmon: (lm90) Add flag to indicate 'alarms' attribute support
      hwmon: (lm90) Add explicit support for MAX6648/MAX6692
      hwmon: (lm90) Add support for ADT7481, ADT7482, and ADT7483
      hwmon: (lm90) Strengthen chip detection for ADM1032, ADT7461(A), and NCT1008
      hwmon: (lm90) Add support for MAX6690
      hwmon: (lm90) Add flag to indicate support for minimum temperature limits
      hwmon: (lm90) Add flag to indicate conversion rate support
      hwmon: (lm90) Add support for MAX6642
      hwmon: (lm90) Let lm90_read16() handle 8-bit read operations
      hwmon: (lm90) Introduce 16-bit register write function
      hwmon: (lm90) Support MAX1617 and LM84
      hwmon: (lm90) Add support for ADM1021, ADM1021A, and ADM1023
      hwmon: (lm90) Add remaining chips supported by adm1021 driver
      hwmon: (lm90) Combine lm86 and lm90 configuration
      hwmon: (lm90) Add explicit support for NCT210
      hwmon: (lm90) Add support for ON Semiconductor NCT214 and NCT72
      hwmon: (lm90) Add support for ON Semiconductor NCT218
      hwmon: (lm90) Add support for ADT7421
      hwmon: (lm90) Only disable alerts if not already disabled
      hwmon: (lm90) Add explicit support for ADM1020
      hwmon: (lm90) Add support and detection of Philips/NXP NE1618
      hwmon: (lm90) Add table with supported Analog/ONSEMI devices
      hwmon: (lm90) Support temp_samples attribute
      hwmon: (pmbus) Add IEEE 754 half precision support to PMBus core
      dt-bindings: trivial-devices: Add lt7182s
      hwmon: (pmbus) Add support for Analog Devices LT7182S
      hwmon: (lm90) Use worker for alarm notifications

Liang He (1):
      hwmon: (gsc-hwmon) Add missing of_node_put()

Linus Walleij (1):
      hwmon: (drivetemp) Add module alias

Marc Ferland (1):
      hwmon: (mcp3021) improve driver support for newer hwmon interface

Michael Carns (1):
      hwmon: (asus-ec-sensors) add support for Maximus XI Hero

Mårten Lindahl (3):
      hwmon: (pmbus) Introduce and use cached vout margins
      hwmon: (pmbus) Add list_voltage to pmbus ops
      hwmon: (pmbus/ltc2978) Set voltage resolution

Paul Fertser (1):
      hwmon: (aspeed-pwm-tacho) increase fan tach period (again)

Ren Zhijie (1):
      hwmon: (pmbus) fix build error unused-function

Robert Schmidt (1):
      hwmon: (nct6775) add ASUS TUF GAMING B550-PLUS WIFI II

Shady Nawara (1):
      hwmon: (asus-ec-sensors) add support for Strix Z690-a D4

Slawomir Stepien (7):
      dt-bindings: hwmon: Add compatible string for ADT7481 in lm90
      dt-bindings: hwmon: Allow specifying channels for lm90
      hwmon: (lm90) Add compatible entry for adt7481
      hwmon: (lm90) Define maximum number of channels that are supported
      hwmon: (lm90) Read the channel's label from device-tree
      hwmon: (lm90) Add support for 2nd remote channel's offset register
      hwmon: (lm90) Read the channel's temperature offset from device-tree

Urs Schroffenegger (1):
      hwmon: (asus-ec-sensors) add definitions for ROG ZENITH II EXTREME

Uwe Kleine-König (2):
      hwmon: Allow to compile ASB100 and FSCHMD on !X86
      hwmon: (sht15) Fix wrong assumptions in device remove callback

Ziyang Xuan (1):
      hwmon: (occ) Delete unnecessary NULL check

 Documentation/ABI/testing/sysfs-class-hwmon        |    9 +
 .../devicetree/bindings/hwmon/national,lm90.yaml   |  131 +
 .../devicetree/bindings/trivial-devices.yaml       |    2 +
 Documentation/hwmon/aquacomputer_d5next.rst        |   17 +-
 Documentation/hwmon/asus_ec_sensors.rst            |    4 +
 Documentation/hwmon/dell-smm-hwmon.rst             |    3 +
 Documentation/hwmon/index.rst                      |    1 +
 Documentation/hwmon/lm90.rst                       |  233 +-
 Documentation/hwmon/lt7182s.rst                    |   92 +
 Documentation/hwmon/pmbus-core.rst                 |    9 +
 drivers/hwmon/Kconfig                              |   27 +-
 drivers/hwmon/aquacomputer_d5next.c                |  316 +--
 drivers/hwmon/aspeed-pwm-tacho.c                   |    2 +-
 drivers/hwmon/asus-ec-sensors.c                    |  108 +-
 drivers/hwmon/asus_wmi_sensors.c                   |   12 +-
 drivers/hwmon/dell-smm-hwmon.c                     |   93 +-
 drivers/hwmon/drivetemp.c                          |    1 +
 drivers/hwmon/f71882fg.c                           |    2 +
 drivers/hwmon/gsc-hwmon.c                          |    3 +
 drivers/hwmon/lm75.h                               |    3 +-
 drivers/hwmon/lm90.c                               | 2556 +++++++++++++-------
 drivers/hwmon/mcp3021.c                            |   99 +-
 drivers/hwmon/nct6775-platform.c                   |   13 +-
 drivers/hwmon/occ/common.c                         |    8 +-
 drivers/hwmon/occ/p9_sbe.c                         |    6 +-
 drivers/hwmon/pmbus/Kconfig                        |    9 +
 drivers/hwmon/pmbus/Makefile                       |    1 +
 drivers/hwmon/pmbus/lt7182s.c                      |  195 ++
 drivers/hwmon/pmbus/ltc2978.c                      |   44 +-
 drivers/hwmon/pmbus/pmbus.h                        |   10 +-
 drivers/hwmon/pmbus/pmbus_core.c                   |  446 +++-
 drivers/hwmon/sch56xx-common.c                     |   44 +-
 drivers/hwmon/sht15.c                              |   17 +-
 drivers/hwmon/tps23861.c                           |   14 +-
 34 files changed, 3309 insertions(+), 1221 deletions(-)
 create mode 100644 Documentation/hwmon/lt7182s.rst
 create mode 100644 drivers/hwmon/pmbus/lt7182s.c

Re: [GIT PULL] hwmon updates for v5.20

[pr-tracker-bot]

The pull request you sent on Fri, 29 Jul 2022 19:25:29 -0700:

> git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-for-v5.20

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/64ae88ff48cb5b3cc7b7aea97241a3e940085bf7

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

Re: [GIT PULL] hwmon updates for v5.20

[Ingo Molnar]

* Guenter Roeck <linux@roeck-us.net> wrote:

> Hi Linus,
> 
> I'll be traveling next week, so I am sending this pull request early,
> in the hope that there won't be a v5.19-rc9.
> 
> Please pull hwmon updates for Linux v5.20 from signed tag:
> 
>     git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-for-v5.20
> 
> Thanks,
> Guenter
> ------
> 
> The following changes since commit 88084a3df1672e131ddc1b4e39eeacfd39864acf:
> 
>   Linux 5.19-rc5 (2022-07-03 15:39:28 -0700)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git tags/hwmon-for-v5.20
> 
> for you to fetch changes up to cdbe34da01e32024e56fff5c6854a263a012d7ff:
> 
>   hwmon: (aquacomputer_d5next) Add support for Aquacomputer Quadro fan controller (2022-07-27 06:00:24 -0700)

>  drivers/hwmon/lm90.c                               | 2556 +++++++++++++-------

Just a quick build regression report, i386 allmodconfig fails to build due 
to a 'string overread' compiler warning in drivers/hwmon/lm90.o:

  # make ARCH=i386 allmodconfig
  # make ARCH=i386 drivers/hwmon/lm90.o

  CALL    scripts/atomic/check-atomics.sh
  CALL    scripts/checksyscalls.sh
  CC [M]  drivers/hwmon/lm90.o
In file included from ./include/linux/string.h:253,
                 from ./arch/x86/include/asm/page_32.h:22,
                 from ./arch/x86/include/asm/page.h:14,
                 from ./arch/x86/include/asm/thread_info.h:12,
                 from ./include/linux/thread_info.h:60,
                 from ./arch/x86/include/asm/preempt.h:7,
                 from ./include/linux/preempt.h:78,
                 from ./include/linux/rcupdate.h:27,
                 from ./include/linux/rculist.h:11,
                 from ./include/linux/pid.h:5,
                 from ./include/linux/sched.h:14,
                 from ./include/linux/ratelimit.h:6,
                 from ./include/linux/dev_printk.h:16,
                 from ./include/linux/device.h:15,
                 from drivers/hwmon/lm90.c:99:
  In function ‘__fortify_strlen’,
      inlined from ‘strlcpy’ at ./include/linux/fortify-string.h:159:10,
      inlined from ‘lm90_detect’ at drivers/hwmon/lm90.c:2550:2:
  ./include/linux/fortify-string.h:50:33: error: ‘__builtin_strlen’ reading 1 or more bytes from a region of size 0 [-Werror=stringop-overread]
     50 | #define __underlying_strlen     __builtin_strlen
        |                                 ^
  ./include/linux/fortify-string.h:141:24: note: in expansion of macro ‘__underlying_strlen’
    141 |                 return __underlying_strlen(p);
        |                        ^~~~~~~~~~~~~~~~~~~
  cc1: all warnings being treated as errors
  make[2]: *** [scripts/Makefile.build:249: drivers/hwmon/lm90.o] Error 1

It's a build warning upgraded to a build error by CONFIG_WERROR=y, it 
normally looks like this:

                 from drivers/hwmon/lm90.c:99:
  In function ‘__fortify_strlen’,
      inlined from ‘strlcpy’ at ./include/linux/fortify-string.h:159:10,
      inlined from ‘lm90_detect’ at drivers/hwmon/lm90.c:2550:2:
  ./include/linux/fortify-string.h:50:33: warning: ‘__builtin_strlen’ reading 1 or more bytes from a region of size 0 [-Wstringop-overread]

Thanks,

	Ingo

Re: [GIT PULL] hwmon updates for v5.20

[Linus Torvalds]

Added Kees - this *looks* like it's a compiler bug.

On Sun, Aug 7, 2022 at 3:07 AM Ingo Molnar <mingo@kernel.org> wrote:
>
> Just a quick build regression report, i386 allmodconfig fails to build due
> to a 'string overread' compiler warning in drivers/hwmon/lm90.o:

I tried to see it here with gcc-12.1, but it's not triggering, so it's
presumably compiler-dependent.

Which compiler is it?

>       inlined from ‘lm90_detect’ at drivers/hwmon/lm90.c:2550:2:
> warning: ‘__builtin_strlen’ reading 1 or more bytes from a region of size 0 [-Wstringop-overread]

Normally it's easier to see what triggers it, but here it's just that

        strlcpy(info->type, name, I2C_NAME_SIZE);

so it's either just the compiler being confused (we've seen that
before), or it's one of the

                name = lm90_detect_xyz(client, chip_id, config1, convrate);

calls in the case statement above that returns something that gcc then
thinks is bad.

However, from an admittedly quick look, all those functions simply
seem to return either NULL or a simple constant string.

Which makes me think "oh, it's gcc being confused by the fortification
code again".

Kees? Do you see anything I don't?

I get the feeling that we should just disable
-Werror=stringop-overread and/or FORTIFY_SOURCE for that
compiler/architecture combination if it's just gcc causing bogus
errors.

              Linus

Re: [GIT PULL] hwmon updates for v5.20

[Guenter Roeck]

On Sun, Aug 07, 2022 at 09:45:08AM -0700, Linus Torvalds wrote:
> Added Kees - this *looks* like it's a compiler bug.
> 
> On Sun, Aug 7, 2022 at 3:07 AM Ingo Molnar <mingo@kernel.org> wrote:
> >
> > Just a quick build regression report, i386 allmodconfig fails to build due
> > to a 'string overread' compiler warning in drivers/hwmon/lm90.o:
> 
> I tried to see it here with gcc-12.1, but it's not triggering, so it's
> presumably compiler-dependent.
> 

I don't see it with gcc 11.3. either, but I do indeed see the problem
with gcc 11.2.

The problem is in lm90_detect_nuvoton() which returns ERR_PTR(-ENODEV)
instead of NULL on error. I'll send a patch.

Thanks, and sorry for the problem.

Guenter

Re: [GIT PULL] hwmon updates for v5.20

[Ingo Molnar]

* Guenter Roeck <linux@roeck-us.net> wrote:

> On Sun, Aug 07, 2022 at 09:45:08AM -0700, Linus Torvalds wrote:
> > Added Kees - this *looks* like it's a compiler bug.
> > 
> > On Sun, Aug 7, 2022 at 3:07 AM Ingo Molnar <mingo@kernel.org> wrote:
> > >
> > > Just a quick build regression report, i386 allmodconfig fails to build due
> > > to a 'string overread' compiler warning in drivers/hwmon/lm90.o:
> > 
> > I tried to see it here with gcc-12.1, but it's not triggering, so it's
> > presumably compiler-dependent.
> > 
> 
> I don't see it with gcc 11.3. either, but I do indeed see the problem
> with gcc 11.2.

Yeah, I'm seeing it with GCC 11.2:

   gcc version 11.2.0 (Ubuntu 11.2.0-19ubuntu1) 

> The problem is in lm90_detect_nuvoton() which returns ERR_PTR(-ENODEV)
> instead of NULL on error. I'll send a patch.

Thanks!

	Ingo