[PATCH V4 0/3] Add DT support for audio clock gating resets for SC7280

[PATCH V4 0/3] Add DT support for audio clock gating resets for SC7280

[Satya Priya]

This series depends on [1], which adds the dt-binding changes.

[1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=663372

Satya Priya (2):
  arm64: dts: qcom: sc7280: Cleanup the lpasscc node
  arm64: dts: qcom: sc7280: Update lpasscore node

Taniya Das (1):
  arm64: dts: qcom: sc7280: Update lpassaudio clock controller for
    resets

 arch/arm64/boot/dts/qcom/sc7280.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

-- 
2.7.4

[PATCH V4 1/3] arm64: dts: qcom: sc7280: Cleanup the lpasscc node

[Satya Priya]

Remove "cc" regmap from lpasscc node which is overlapping
with the lpass_aon regmap.

Fixes: 422a295221bb ("arm64: dts: qcom: sc7280: Add clock controller nodes")
Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
---
Changes since v3:
 - None.

Changes since v2:
 - Cleanup the lpasscc node to handle regmap overlap with lpass_aon
   instead of disabling the lpasscc node.
 - This patch is added in v3.

 arch/arm64/boot/dts/qcom/sc7280.dtsi | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 13d7f26..71735bb 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2168,9 +2168,8 @@
 		lpasscc: lpasscc@3000000 {
 			compatible = "qcom,sc7280-lpasscc";
 			reg = <0 0x03000000 0 0x40>,
-			      <0 0x03c04000 0 0x4>,
-			      <0 0x03389000 0 0x24>;
-			reg-names = "qdsp6ss", "top_cc", "cc";
+				  <0 0x03c04000 0 0x4>;
+			reg-names = "qdsp6ss", "top_cc";
 			clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>;
 			clock-names = "iface";
 			#clock-cells = <1>;
-- 
2.7.4

[PATCH V4 2/3] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets

[Satya Priya]

From: Taniya Das <quic_tdas@quicinc.com>

The lpass audio supports TX/RX/WSA block resets.

Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
---
Changes since v3:
 - Move the lpasscore node update to separate patch.

Changes since v2:
 - Remove the status="disabled" from lpasscc node.

 arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 71735bb..634f15e 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2184,6 +2184,7 @@
 			power-domains = <&lpass_aon LPASS_AON_CC_LPASS_AUDIO_HM_GDSC>;
 			#clock-cells = <1>;
 			#power-domain-cells = <1>;
+			#reset-cells = <1>;
 		};
 
 		lpass_aon: clock-controller@3380000 {
-- 
2.7.4

[PATCH V4 3/3] arm64: dts: qcom: sc7280: Update lpasscore node

[Satya Priya]

To maintain consistency with other lpass nodes(lpass_audiocc,
lpass_aon and lpass_hm), update lpasscore to lpass_core.

Fixes: 9499240d15f2 ("arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio clock controllers")
Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
---
Changes since v3:
 - This is newly added in v4, inorder to update the lpasscore node in a
   separate patch.

 arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 634f15e..c641f0b 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2192,13 +2192,13 @@
 			reg = <0 0x03380000 0 0x30000>;
 			clocks = <&rpmhcc RPMH_CXO_CLK>,
 			       <&rpmhcc RPMH_CXO_CLK_A>,
-			       <&lpasscore LPASS_CORE_CC_CORE_CLK>;
+			       <&lpass_core LPASS_CORE_CC_CORE_CLK>;
 			clock-names = "bi_tcxo", "bi_tcxo_ao", "iface";
 			#clock-cells = <1>;
 			#power-domain-cells = <1>;
 		};
 
-		lpasscore: clock-controller@3900000 {
+		lpass_core: clock-controller@3900000 {
 			compatible = "qcom,sc7280-lpasscorecc";
 			reg = <0 0x03900000 0 0x50000>;
 			clocks = <&rpmhcc RPMH_CXO_CLK>;
-- 
2.7.4

Re: [PATCH V4 1/3] arm64: dts: qcom: sc7280: Cleanup the lpasscc node

[Stephen Boyd]

Quoting Satya Priya (2022-08-08 23:35:07)
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 13d7f26..71735bb 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -2168,9 +2168,8 @@
>                 lpasscc: lpasscc@3000000 {
>                         compatible = "qcom,sc7280-lpasscc";
>                         reg = <0 0x03000000 0 0x40>,
> -                             <0 0x03c04000 0 0x4>,
> -                             <0 0x03389000 0 0x24>;
> -                       reg-names = "qdsp6ss", "top_cc", "cc";
> +                                 <0 0x03c04000 0 0x4>;

This looks oddly tabbed out? I'd expect it to align with the first reg
property, so be unchanged.

> +                       reg-names = "qdsp6ss", "top_cc";
>                         clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>;
>                         clock-names = "iface";

Re: [PATCH V4 2/3] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets

[Stephen Boyd]

Quoting Satya Priya (2022-08-08 23:35:08)
> From: Taniya Das <quic_tdas@quicinc.com>
>
> The lpass audio supports TX/RX/WSA block resets.
>
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Re: [PATCH V4 3/3] arm64: dts: qcom: sc7280: Update lpasscore node

[Stephen Boyd]

Quoting Satya Priya (2022-08-08 23:35:09)
> To maintain consistency with other lpass nodes(lpass_audiocc,
> lpass_aon and lpass_hm), update lpasscore to lpass_core.
>
> Fixes: 9499240d15f2 ("arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio clock controllers")
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Re: [PATCH V4 1/3] arm64: dts: qcom: sc7280: Cleanup the lpasscc node

[Satya Priya Kakitapalli (Temp)]

On 8/9/2022 10:04 PM, Stephen Boyd wrote:
> Quoting Satya Priya (2022-08-08 23:35:07)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 13d7f26..71735bb 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -2168,9 +2168,8 @@
>>                  lpasscc: lpasscc@3000000 {
>>                          compatible = "qcom,sc7280-lpasscc";
>>                          reg = <0 0x03000000 0 0x40>,
>> -                             <0 0x03c04000 0 0x4>,
>> -                             <0 0x03389000 0 0x24>;
>> -                       reg-names = "qdsp6ss", "top_cc", "cc";
>> +                                 <0 0x03c04000 0 0x4>;
> This looks oddly tabbed out? I'd expect it to align with the first reg
> property, so be unchanged.


Okay, I will correct the tabbing. But this wouldn't remain unchanged 
because the comma is being replaced by semi-colon.


>> +                       reg-names = "qdsp6ss", "top_cc";
>>                          clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>;
>>                          clock-names = "iface";