* [PATCH] drm/i915/guc: clear stalled request after a reset @ 2022-08-11 21:08 ` Daniele Ceraolo Spurio 0 siblings, 0 replies; 16+ messages in thread From: Daniele Ceraolo Spurio @ 2022-08-11 21:08 UTC (permalink / raw) To: intel-gfx Cc: Matthew Brost, stable, Daniele Ceraolo Spurio, John Harrison, dri-devel If the GuC CTs are full and we need to stall the request submission while waiting for space, we save the stalled request and where the stall occurred; when the CTs have space again we pick up the request submission from where we left off. If a full GT reset occurs, the state of all contexts is cleared and all non-guilty requests are unsubmitted, therefore we need to restart the stalled request submission from scratch. To make sure that we do so, clear the saved request after a reset. Fixes note: the patch that introduced the bug is in 5.15, but no officially supported platform had GuC submission enabled by default in that kernel, so the backport to that particular version (and only that one) can potentially be skipped. Fixes: 925dc1cf58ed ("drm/i915/guc: Implement GuC submission tasklet") Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Cc: Matthew Brost <matthew.brost@intel.com> Cc: John Harrison <john.c.harrison@intel.com> Cc: <stable@vger.kernel.org> # v5.15+ --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c index 0d17da77e787..0d56b615bf78 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c @@ -4002,6 +4002,13 @@ static inline void guc_init_lrc_mapping(struct intel_guc *guc) /* make sure all descriptors are clean... */ xa_destroy(&guc->context_lookup); + /* + * A reset might have occurred while we had a pending stalled request, + * so make sure we clean that up. + */ + guc->stalled_request = NULL; + guc->submission_stall_reason = STALL_NONE; + /* * Some contexts might have been pinned before we enabled GuC * submission, so we need to add them to the GuC bookeeping. -- 2.25.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] drm/i915/guc: clear stalled request after a reset @ 2022-08-11 21:08 ` Daniele Ceraolo Spurio 0 siblings, 0 replies; 16+ messages in thread From: Daniele Ceraolo Spurio @ 2022-08-11 21:08 UTC (permalink / raw) To: intel-gfx Cc: dri-devel, Daniele Ceraolo Spurio, Matthew Brost, John Harrison, stable If the GuC CTs are full and we need to stall the request submission while waiting for space, we save the stalled request and where the stall occurred; when the CTs have space again we pick up the request submission from where we left off. If a full GT reset occurs, the state of all contexts is cleared and all non-guilty requests are unsubmitted, therefore we need to restart the stalled request submission from scratch. To make sure that we do so, clear the saved request after a reset. Fixes note: the patch that introduced the bug is in 5.15, but no officially supported platform had GuC submission enabled by default in that kernel, so the backport to that particular version (and only that one) can potentially be skipped. Fixes: 925dc1cf58ed ("drm/i915/guc: Implement GuC submission tasklet") Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Cc: Matthew Brost <matthew.brost@intel.com> Cc: John Harrison <john.c.harrison@intel.com> Cc: <stable@vger.kernel.org> # v5.15+ --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c index 0d17da77e787..0d56b615bf78 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c @@ -4002,6 +4002,13 @@ static inline void guc_init_lrc_mapping(struct intel_guc *guc) /* make sure all descriptors are clean... */ xa_destroy(&guc->context_lookup); + /* + * A reset might have occurred while we had a pending stalled request, + * so make sure we clean that up. + */ + guc->stalled_request = NULL; + guc->submission_stall_reason = STALL_NONE; + /* * Some contexts might have been pinned before we enabled GuC * submission, so we need to add them to the GuC bookeeping. -- 2.25.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset @ 2022-08-11 21:08 ` Daniele Ceraolo Spurio 0 siblings, 0 replies; 16+ messages in thread From: Daniele Ceraolo Spurio @ 2022-08-11 21:08 UTC (permalink / raw) To: intel-gfx; +Cc: stable, dri-devel If the GuC CTs are full and we need to stall the request submission while waiting for space, we save the stalled request and where the stall occurred; when the CTs have space again we pick up the request submission from where we left off. If a full GT reset occurs, the state of all contexts is cleared and all non-guilty requests are unsubmitted, therefore we need to restart the stalled request submission from scratch. To make sure that we do so, clear the saved request after a reset. Fixes note: the patch that introduced the bug is in 5.15, but no officially supported platform had GuC submission enabled by default in that kernel, so the backport to that particular version (and only that one) can potentially be skipped. Fixes: 925dc1cf58ed ("drm/i915/guc: Implement GuC submission tasklet") Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Cc: Matthew Brost <matthew.brost@intel.com> Cc: John Harrison <john.c.harrison@intel.com> Cc: <stable@vger.kernel.org> # v5.15+ --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c index 0d17da77e787..0d56b615bf78 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c @@ -4002,6 +4002,13 @@ static inline void guc_init_lrc_mapping(struct intel_guc *guc) /* make sure all descriptors are clean... */ xa_destroy(&guc->context_lookup); + /* + * A reset might have occurred while we had a pending stalled request, + * so make sure we clean that up. + */ + guc->stalled_request = NULL; + guc->submission_stall_reason = STALL_NONE; + /* * Some contexts might have been pinned before we enabled GuC * submission, so we need to add them to the GuC bookeeping. -- 2.25.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: clear stalled request after a reset 2022-08-11 21:08 ` [Intel-gfx] " Daniele Ceraolo Spurio (?) (?) @ 2022-08-11 22:19 ` Patchwork -1 siblings, 0 replies; 16+ messages in thread From: Patchwork @ 2022-08-11 22:19 UTC (permalink / raw) To: Daniele Ceraolo Spurio; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 13089 bytes --] == Series Details == Series: drm/i915/guc: clear stalled request after a reset URL : https://patchwork.freedesktop.org/series/107181/ State : success == Summary == CI Bug Log - changes from CI_DRM_11985 -> Patchwork_107181v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/index.html Participating hosts (36 -> 39) ------------------------------ Additional (3): bat-dg2-8 bat-dg2-10 fi-rkl-11600 Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_107181v1: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@core_hotunplug@unbind-rebind: - {bat-dg2-10}: NOTRUN -> [DMESG-WARN][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/bat-dg2-10/igt@core_hotunplug@unbind-rebind.html * igt@i915_selftest@live@gt_lrc: - {bat-dg2-8}: NOTRUN -> [INCOMPLETE][2] [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/bat-dg2-8/igt@i915_selftest@live@gt_lrc.html * igt@i915_selftest@live@slpc: - {bat-rplp-1}: [PASS][3] -> [DMESG-FAIL][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/bat-rplp-1/igt@i915_selftest@live@slpc.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/bat-rplp-1/igt@i915_selftest@live@slpc.html Known issues ------------ Here are the changes found in Patchwork_107181v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_huc_copy@huc-copy: - fi-rkl-11600: NOTRUN -> [SKIP][5] ([i915#2190]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@parallel-random-engines: - fi-rkl-11600: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-rkl-11600/igt@gem_lmem_swapping@parallel-random-engines.html * igt@gem_tiled_pread_basic: - fi-rkl-11600: NOTRUN -> [SKIP][7] ([i915#3282]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-rkl-11600/igt@gem_tiled_pread_basic.html * igt@i915_pm_backlight@basic-brightness: - fi-rkl-11600: NOTRUN -> [SKIP][8] ([i915#3012]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html * igt@i915_pm_rpm@module-reload: - fi-cfl-8109u: [PASS][9] -> [DMESG-FAIL][10] ([i915#62]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html * igt@i915_selftest@live@ring_submission: - fi-cfl-8109u: [PASS][11] -> [DMESG-WARN][12] ([i915#5904]) +30 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html * igt@i915_suspend@basic-s2idle-without-i915: - fi-cfl-8109u: [PASS][13] -> [DMESG-WARN][14] ([i915#5904] / [i915#62]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html * igt@i915_suspend@basic-s3-without-i915: - fi-rkl-11600: NOTRUN -> [INCOMPLETE][15] ([i915#5982]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-bsw-nick: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-bsw-nick/igt@kms_chamelium@common-hpd-after-suspend.html - fi-hsw-4770: NOTRUN -> [SKIP][17] ([fdo#109271] / [fdo#111827]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html - fi-blb-e6850: NOTRUN -> [SKIP][18] ([fdo#109271]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-blb-e6850/igt@kms_chamelium@common-hpd-after-suspend.html - fi-pnv-d510: NOTRUN -> [SKIP][19] ([fdo#109271]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-pnv-d510/igt@kms_chamelium@common-hpd-after-suspend.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-rkl-11600: NOTRUN -> [SKIP][20] ([fdo#111827]) +7 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-rkl-11600/igt@kms_chamelium@hdmi-hpd-fast.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor: - fi-rkl-11600: NOTRUN -> [SKIP][21] ([i915#4103]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html * igt@kms_force_connector_basic@force-load-detect: - fi-rkl-11600: NOTRUN -> [SKIP][22] ([fdo#109285] / [i915#4098]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_frontbuffer_tracking@basic: - fi-cfl-8109u: [PASS][23] -> [DMESG-WARN][24] ([i915#62]) +12 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html * igt@kms_pipe_crc_basic@suspend-read-crc: - fi-bsw-nick: NOTRUN -> [SKIP][25] ([fdo#109271]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-bsw-nick/igt@kms_pipe_crc_basic@suspend-read-crc.html * igt@kms_psr@sprite_plane_onoff: - fi-rkl-11600: NOTRUN -> [SKIP][26] ([i915#1072]) +3 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-rkl-11600/igt@kms_psr@sprite_plane_onoff.html * igt@kms_setmode@basic-clone-single-crtc: - fi-rkl-11600: NOTRUN -> [SKIP][27] ([i915#3555] / [i915#4098]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-read: - fi-rkl-11600: NOTRUN -> [SKIP][28] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-rkl-11600/igt@prime_vgem@basic-read.html * igt@prime_vgem@basic-userptr: - fi-rkl-11600: NOTRUN -> [SKIP][29] ([fdo#109295] / [i915#3301] / [i915#3708]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-rkl-11600/igt@prime_vgem@basic-userptr.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s3@smem: - {bat-rplp-1}: [DMESG-WARN][30] ([i915#2867]) -> [PASS][31] [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/bat-rplp-1/igt@gem_exec_suspend@basic-s3@smem.html * igt@i915_selftest@live@execlists: - fi-bsw-nick: [INCOMPLETE][32] ([i915#5847]) -> [PASS][33] [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/fi-bsw-nick/igt@i915_selftest@live@execlists.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-bsw-nick/igt@i915_selftest@live@execlists.html * igt@i915_selftest@live@hangcheck: - fi-hsw-4770: [INCOMPLETE][34] ([i915#4785]) -> [PASS][35] [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html * igt@i915_selftest@live@requests: - fi-blb-e6850: [DMESG-FAIL][36] ([i915#4528]) -> [PASS][37] [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/fi-blb-e6850/igt@i915_selftest@live@requests.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-blb-e6850/igt@i915_selftest@live@requests.html - {bat-rpls-1}: [DMESG-FAIL][38] ([i915#5087] / [i915#6257]) -> [PASS][39] [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/bat-rpls-1/igt@i915_selftest@live@requests.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/bat-rpls-1/igt@i915_selftest@live@requests.html - fi-pnv-d510: [DMESG-FAIL][40] ([i915#4528]) -> [PASS][41] [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/fi-pnv-d510/igt@i915_selftest@live@requests.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/fi-pnv-d510/igt@i915_selftest@live@requests.html * igt@i915_selftest@live@reset: - {bat-rpls-1}: [DMESG-FAIL][42] ([i915#4983] / [i915#5828]) -> [PASS][43] [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/bat-rpls-1/igt@i915_selftest@live@reset.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/bat-rpls-1/igt@i915_selftest@live@reset.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867 [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528 [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785 [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5087]: https://gitlab.freedesktop.org/drm/intel/issues/5087 [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190 [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537 [i915#5828]: https://gitlab.freedesktop.org/drm/intel/issues/5828 [i915#5847]: https://gitlab.freedesktop.org/drm/intel/issues/5847 [i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904 [i915#5950]: https://gitlab.freedesktop.org/drm/intel/issues/5950 [i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257 Build changes ------------- * Linux: CI_DRM_11985 -> Patchwork_107181v1 CI-20190529: 20190529 CI_DRM_11985: 89445c6d81d47caa0c489a412dd92aa4e627207d @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6623: c8edfca649da71b296d882bb0319181d94e619eb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_107181v1: 89445c6d81d47caa0c489a412dd92aa4e627207d @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits f5981673d3aa drm/i915/guc: clear stalled request after a reset == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/index.html [-- Attachment #2: Type: text/html, Size: 14202 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset 2022-08-11 21:08 ` [Intel-gfx] " Daniele Ceraolo Spurio @ 2022-08-12 7:29 ` Tvrtko Ursulin -1 siblings, 0 replies; 16+ messages in thread From: Tvrtko Ursulin @ 2022-08-12 7:29 UTC (permalink / raw) To: Daniele Ceraolo Spurio, intel-gfx; +Cc: stable, dri-devel On 11/08/2022 22:08, Daniele Ceraolo Spurio wrote: > If the GuC CTs are full and we need to stall the request submission > while waiting for space, we save the stalled request and where the stall > occurred; when the CTs have space again we pick up the request submission > from where we left off. How serious is it? Statement always was CT buffers can never get full outside the pathological IGT test cases. So I am wondering if this is in the category of fix for correctness or actually the CT buffers can get full in normal use so it is imperative to fix. Regards, Tvrtko > If a full GT reset occurs, the state of all contexts is cleared and all > non-guilty requests are unsubmitted, therefore we need to restart the > stalled request submission from scratch. To make sure that we do so, > clear the saved request after a reset. > > Fixes note: the patch that introduced the bug is in 5.15, but no > officially supported platform had GuC submission enabled by default > in that kernel, so the backport to that particular version (and only > that one) can potentially be skipped. > > Fixes: 925dc1cf58ed ("drm/i915/guc: Implement GuC submission tasklet") > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > Cc: Matthew Brost <matthew.brost@intel.com> > Cc: John Harrison <john.c.harrison@intel.com> > Cc: <stable@vger.kernel.org> # v5.15+ > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > index 0d17da77e787..0d56b615bf78 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > @@ -4002,6 +4002,13 @@ static inline void guc_init_lrc_mapping(struct intel_guc *guc) > /* make sure all descriptors are clean... */ > xa_destroy(&guc->context_lookup); > > + /* > + * A reset might have occurred while we had a pending stalled request, > + * so make sure we clean that up. > + */ > + guc->stalled_request = NULL; > + guc->submission_stall_reason = STALL_NONE; > + > /* > * Some contexts might have been pinned before we enabled GuC > * submission, so we need to add them to the GuC bookeeping. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset @ 2022-08-12 7:29 ` Tvrtko Ursulin 0 siblings, 0 replies; 16+ messages in thread From: Tvrtko Ursulin @ 2022-08-12 7:29 UTC (permalink / raw) To: Daniele Ceraolo Spurio, intel-gfx; +Cc: dri-devel, stable On 11/08/2022 22:08, Daniele Ceraolo Spurio wrote: > If the GuC CTs are full and we need to stall the request submission > while waiting for space, we save the stalled request and where the stall > occurred; when the CTs have space again we pick up the request submission > from where we left off. How serious is it? Statement always was CT buffers can never get full outside the pathological IGT test cases. So I am wondering if this is in the category of fix for correctness or actually the CT buffers can get full in normal use so it is imperative to fix. Regards, Tvrtko > If a full GT reset occurs, the state of all contexts is cleared and all > non-guilty requests are unsubmitted, therefore we need to restart the > stalled request submission from scratch. To make sure that we do so, > clear the saved request after a reset. > > Fixes note: the patch that introduced the bug is in 5.15, but no > officially supported platform had GuC submission enabled by default > in that kernel, so the backport to that particular version (and only > that one) can potentially be skipped. > > Fixes: 925dc1cf58ed ("drm/i915/guc: Implement GuC submission tasklet") > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > Cc: Matthew Brost <matthew.brost@intel.com> > Cc: John Harrison <john.c.harrison@intel.com> > Cc: <stable@vger.kernel.org> # v5.15+ > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > index 0d17da77e787..0d56b615bf78 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > @@ -4002,6 +4002,13 @@ static inline void guc_init_lrc_mapping(struct intel_guc *guc) > /* make sure all descriptors are clean... */ > xa_destroy(&guc->context_lookup); > > + /* > + * A reset might have occurred while we had a pending stalled request, > + * so make sure we clean that up. > + */ > + guc->stalled_request = NULL; > + guc->submission_stall_reason = STALL_NONE; > + > /* > * Some contexts might have been pinned before we enabled GuC > * submission, so we need to add them to the GuC bookeeping. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset 2022-08-12 7:29 ` Tvrtko Ursulin (?) @ 2022-08-12 15:31 ` Ceraolo Spurio, Daniele -1 siblings, 0 replies; 16+ messages in thread From: Ceraolo Spurio, Daniele @ 2022-08-12 15:31 UTC (permalink / raw) To: Tvrtko Ursulin, intel-gfx; +Cc: stable, dri-devel, Matthew Brost On 8/12/2022 12:29 AM, Tvrtko Ursulin wrote: > > On 11/08/2022 22:08, Daniele Ceraolo Spurio wrote: >> If the GuC CTs are full and we need to stall the request submission >> while waiting for space, we save the stalled request and where the stall >> occurred; when the CTs have space again we pick up the request >> submission >> from where we left off. > > How serious is it? Statement always was CT buffers can never get full > outside the pathological IGT test cases. So I am wondering if this is > in the category of fix for correctness or actually the CT buffers can > get full in normal use so it is imperative to fix. The CT buffers being full is indeed something that is normally only observed with IGTs that hammer the submission path, but it is still something that a user can do so IMO we do have to fix it. However, the bug is still extremely unlikely to happen out in the wild as it needs 2 relatively rare things to happen: - We need to hit the pathological case of the GuC CTs being full and the stall kicking in - Something needs to go wrong and escalated to a full GT reset The bug report that triggered my investigation into this came from what look like faulty HW: the HW seems to suddenly just stop with no errors anywhere, which leads to the buffers filling up because the GuC is no longer processing them, followed by a GT reset as we try to recover the HW. To replicate this locally I had to add a debugfs to kill the GuC in the middle of the test to simulate this "HW silently dies" scenario. Daniele > > Regards, > > Tvrtko > >> If a full GT reset occurs, the state of all contexts is cleared and all >> non-guilty requests are unsubmitted, therefore we need to restart the >> stalled request submission from scratch. To make sure that we do so, >> clear the saved request after a reset. >> >> Fixes note: the patch that introduced the bug is in 5.15, but no >> officially supported platform had GuC submission enabled by default >> in that kernel, so the backport to that particular version (and only >> that one) can potentially be skipped. >> >> Fixes: 925dc1cf58ed ("drm/i915/guc: Implement GuC submission tasklet") >> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> >> Cc: Matthew Brost <matthew.brost@intel.com> >> Cc: John Harrison <john.c.harrison@intel.com> >> Cc: <stable@vger.kernel.org> # v5.15+ >> --- >> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> index 0d17da77e787..0d56b615bf78 100644 >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> @@ -4002,6 +4002,13 @@ static inline void guc_init_lrc_mapping(struct >> intel_guc *guc) >> /* make sure all descriptors are clean... */ >> xa_destroy(&guc->context_lookup); >> + /* >> + * A reset might have occurred while we had a pending stalled >> request, >> + * so make sure we clean that up. >> + */ >> + guc->stalled_request = NULL; >> + guc->submission_stall_reason = STALL_NONE; >> + >> /* >> * Some contexts might have been pinned before we enabled GuC >> * submission, so we need to add them to the GuC bookeeping. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset @ 2022-08-12 15:31 ` Ceraolo Spurio, Daniele 0 siblings, 0 replies; 16+ messages in thread From: Ceraolo Spurio, Daniele @ 2022-08-12 15:31 UTC (permalink / raw) To: Tvrtko Ursulin, intel-gfx; +Cc: dri-devel, stable On 8/12/2022 12:29 AM, Tvrtko Ursulin wrote: > > On 11/08/2022 22:08, Daniele Ceraolo Spurio wrote: >> If the GuC CTs are full and we need to stall the request submission >> while waiting for space, we save the stalled request and where the stall >> occurred; when the CTs have space again we pick up the request >> submission >> from where we left off. > > How serious is it? Statement always was CT buffers can never get full > outside the pathological IGT test cases. So I am wondering if this is > in the category of fix for correctness or actually the CT buffers can > get full in normal use so it is imperative to fix. The CT buffers being full is indeed something that is normally only observed with IGTs that hammer the submission path, but it is still something that a user can do so IMO we do have to fix it. However, the bug is still extremely unlikely to happen out in the wild as it needs 2 relatively rare things to happen: - We need to hit the pathological case of the GuC CTs being full and the stall kicking in - Something needs to go wrong and escalated to a full GT reset The bug report that triggered my investigation into this came from what look like faulty HW: the HW seems to suddenly just stop with no errors anywhere, which leads to the buffers filling up because the GuC is no longer processing them, followed by a GT reset as we try to recover the HW. To replicate this locally I had to add a debugfs to kill the GuC in the middle of the test to simulate this "HW silently dies" scenario. Daniele > > Regards, > > Tvrtko > >> If a full GT reset occurs, the state of all contexts is cleared and all >> non-guilty requests are unsubmitted, therefore we need to restart the >> stalled request submission from scratch. To make sure that we do so, >> clear the saved request after a reset. >> >> Fixes note: the patch that introduced the bug is in 5.15, but no >> officially supported platform had GuC submission enabled by default >> in that kernel, so the backport to that particular version (and only >> that one) can potentially be skipped. >> >> Fixes: 925dc1cf58ed ("drm/i915/guc: Implement GuC submission tasklet") >> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> >> Cc: Matthew Brost <matthew.brost@intel.com> >> Cc: John Harrison <john.c.harrison@intel.com> >> Cc: <stable@vger.kernel.org> # v5.15+ >> --- >> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> index 0d17da77e787..0d56b615bf78 100644 >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> @@ -4002,6 +4002,13 @@ static inline void guc_init_lrc_mapping(struct >> intel_guc *guc) >> /* make sure all descriptors are clean... */ >> xa_destroy(&guc->context_lookup); >> + /* >> + * A reset might have occurred while we had a pending stalled >> request, >> + * so make sure we clean that up. >> + */ >> + guc->stalled_request = NULL; >> + guc->submission_stall_reason = STALL_NONE; >> + >> /* >> * Some contexts might have been pinned before we enabled GuC >> * submission, so we need to add them to the GuC bookeeping. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset @ 2022-08-12 15:31 ` Ceraolo Spurio, Daniele 0 siblings, 0 replies; 16+ messages in thread From: Ceraolo Spurio, Daniele @ 2022-08-12 15:31 UTC (permalink / raw) To: Tvrtko Ursulin, intel-gfx; +Cc: Matthew Brost, dri-devel, stable On 8/12/2022 12:29 AM, Tvrtko Ursulin wrote: > > On 11/08/2022 22:08, Daniele Ceraolo Spurio wrote: >> If the GuC CTs are full and we need to stall the request submission >> while waiting for space, we save the stalled request and where the stall >> occurred; when the CTs have space again we pick up the request >> submission >> from where we left off. > > How serious is it? Statement always was CT buffers can never get full > outside the pathological IGT test cases. So I am wondering if this is > in the category of fix for correctness or actually the CT buffers can > get full in normal use so it is imperative to fix. The CT buffers being full is indeed something that is normally only observed with IGTs that hammer the submission path, but it is still something that a user can do so IMO we do have to fix it. However, the bug is still extremely unlikely to happen out in the wild as it needs 2 relatively rare things to happen: - We need to hit the pathological case of the GuC CTs being full and the stall kicking in - Something needs to go wrong and escalated to a full GT reset The bug report that triggered my investigation into this came from what look like faulty HW: the HW seems to suddenly just stop with no errors anywhere, which leads to the buffers filling up because the GuC is no longer processing them, followed by a GT reset as we try to recover the HW. To replicate this locally I had to add a debugfs to kill the GuC in the middle of the test to simulate this "HW silently dies" scenario. Daniele > > Regards, > > Tvrtko > >> If a full GT reset occurs, the state of all contexts is cleared and all >> non-guilty requests are unsubmitted, therefore we need to restart the >> stalled request submission from scratch. To make sure that we do so, >> clear the saved request after a reset. >> >> Fixes note: the patch that introduced the bug is in 5.15, but no >> officially supported platform had GuC submission enabled by default >> in that kernel, so the backport to that particular version (and only >> that one) can potentially be skipped. >> >> Fixes: 925dc1cf58ed ("drm/i915/guc: Implement GuC submission tasklet") >> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> >> Cc: Matthew Brost <matthew.brost@intel.com> >> Cc: John Harrison <john.c.harrison@intel.com> >> Cc: <stable@vger.kernel.org> # v5.15+ >> --- >> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> index 0d17da77e787..0d56b615bf78 100644 >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >> @@ -4002,6 +4002,13 @@ static inline void guc_init_lrc_mapping(struct >> intel_guc *guc) >> /* make sure all descriptors are clean... */ >> xa_destroy(&guc->context_lookup); >> + /* >> + * A reset might have occurred while we had a pending stalled >> request, >> + * so make sure we clean that up. >> + */ >> + guc->stalled_request = NULL; >> + guc->submission_stall_reason = STALL_NONE; >> + >> /* >> * Some contexts might have been pinned before we enabled GuC >> * submission, so we need to add them to the GuC bookeeping. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset 2022-08-12 15:31 ` Ceraolo Spurio, Daniele (?) @ 2022-08-30 14:13 ` Tvrtko Ursulin -1 siblings, 0 replies; 16+ messages in thread From: Tvrtko Ursulin @ 2022-08-30 14:13 UTC (permalink / raw) To: Ceraolo Spurio, Daniele, intel-gfx; +Cc: stable, dri-devel, Matthew Brost On 12/08/2022 16:31, Ceraolo Spurio, Daniele wrote: > On 8/12/2022 12:29 AM, Tvrtko Ursulin wrote: >> >> On 11/08/2022 22:08, Daniele Ceraolo Spurio wrote: >>> If the GuC CTs are full and we need to stall the request submission >>> while waiting for space, we save the stalled request and where the stall >>> occurred; when the CTs have space again we pick up the request >>> submission >>> from where we left off. >> >> How serious is it? Statement always was CT buffers can never get full >> outside the pathological IGT test cases. So I am wondering if this is >> in the category of fix for correctness or actually the CT buffers can >> get full in normal use so it is imperative to fix. > > The CT buffers being full is indeed something that is normally only > observed with IGTs that hammer the submission path, but it is still > something that a user can do so IMO we do have to fix it. However, the > bug is still extremely unlikely to happen out in the wild as it needs 2 > relatively rare things to happen: > > - We need to hit the pathological case of the GuC CTs being full and the > stall kicking in > - Something needs to go wrong and escalated to a full GT reset > > The bug report that triggered my investigation into this came from what > look like faulty HW: the HW seems to suddenly just stop with no errors > anywhere, which leads to the buffers filling up because the GuC is no > longer processing them, followed by a GT reset as we try to recover the > HW. To replicate this locally I had to add a debugfs to kill the GuC in > the middle of the test to simulate this "HW silently dies" scenario. Ack. Given the activity around pin/unpin performance issues I was briefly worried this is another one which was "upgraded" from only IGT to something in the real world after all. Thanks for confirming that is not the case. Regards, Tvrtko > > Daniele > >> >> Regards, >> >> Tvrtko >> >>> If a full GT reset occurs, the state of all contexts is cleared and all >>> non-guilty requests are unsubmitted, therefore we need to restart the >>> stalled request submission from scratch. To make sure that we do so, >>> clear the saved request after a reset. >>> >>> Fixes note: the patch that introduced the bug is in 5.15, but no >>> officially supported platform had GuC submission enabled by default >>> in that kernel, so the backport to that particular version (and only >>> that one) can potentially be skipped. >>> >>> Fixes: 925dc1cf58ed ("drm/i915/guc: Implement GuC submission tasklet") >>> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> >>> Cc: Matthew Brost <matthew.brost@intel.com> >>> Cc: John Harrison <john.c.harrison@intel.com> >>> Cc: <stable@vger.kernel.org> # v5.15+ >>> --- >>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> index 0d17da77e787..0d56b615bf78 100644 >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> @@ -4002,6 +4002,13 @@ static inline void guc_init_lrc_mapping(struct >>> intel_guc *guc) >>> /* make sure all descriptors are clean... */ >>> xa_destroy(&guc->context_lookup); >>> + /* >>> + * A reset might have occurred while we had a pending stalled >>> request, >>> + * so make sure we clean that up. >>> + */ >>> + guc->stalled_request = NULL; >>> + guc->submission_stall_reason = STALL_NONE; >>> + >>> /* >>> * Some contexts might have been pinned before we enabled GuC >>> * submission, so we need to add them to the GuC bookeeping. > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset @ 2022-08-30 14:13 ` Tvrtko Ursulin 0 siblings, 0 replies; 16+ messages in thread From: Tvrtko Ursulin @ 2022-08-30 14:13 UTC (permalink / raw) To: Ceraolo Spurio, Daniele, intel-gfx; +Cc: dri-devel, stable On 12/08/2022 16:31, Ceraolo Spurio, Daniele wrote: > On 8/12/2022 12:29 AM, Tvrtko Ursulin wrote: >> >> On 11/08/2022 22:08, Daniele Ceraolo Spurio wrote: >>> If the GuC CTs are full and we need to stall the request submission >>> while waiting for space, we save the stalled request and where the stall >>> occurred; when the CTs have space again we pick up the request >>> submission >>> from where we left off. >> >> How serious is it? Statement always was CT buffers can never get full >> outside the pathological IGT test cases. So I am wondering if this is >> in the category of fix for correctness or actually the CT buffers can >> get full in normal use so it is imperative to fix. > > The CT buffers being full is indeed something that is normally only > observed with IGTs that hammer the submission path, but it is still > something that a user can do so IMO we do have to fix it. However, the > bug is still extremely unlikely to happen out in the wild as it needs 2 > relatively rare things to happen: > > - We need to hit the pathological case of the GuC CTs being full and the > stall kicking in > - Something needs to go wrong and escalated to a full GT reset > > The bug report that triggered my investigation into this came from what > look like faulty HW: the HW seems to suddenly just stop with no errors > anywhere, which leads to the buffers filling up because the GuC is no > longer processing them, followed by a GT reset as we try to recover the > HW. To replicate this locally I had to add a debugfs to kill the GuC in > the middle of the test to simulate this "HW silently dies" scenario. Ack. Given the activity around pin/unpin performance issues I was briefly worried this is another one which was "upgraded" from only IGT to something in the real world after all. Thanks for confirming that is not the case. Regards, Tvrtko > > Daniele > >> >> Regards, >> >> Tvrtko >> >>> If a full GT reset occurs, the state of all contexts is cleared and all >>> non-guilty requests are unsubmitted, therefore we need to restart the >>> stalled request submission from scratch. To make sure that we do so, >>> clear the saved request after a reset. >>> >>> Fixes note: the patch that introduced the bug is in 5.15, but no >>> officially supported platform had GuC submission enabled by default >>> in that kernel, so the backport to that particular version (and only >>> that one) can potentially be skipped. >>> >>> Fixes: 925dc1cf58ed ("drm/i915/guc: Implement GuC submission tasklet") >>> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> >>> Cc: Matthew Brost <matthew.brost@intel.com> >>> Cc: John Harrison <john.c.harrison@intel.com> >>> Cc: <stable@vger.kernel.org> # v5.15+ >>> --- >>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> index 0d17da77e787..0d56b615bf78 100644 >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> @@ -4002,6 +4002,13 @@ static inline void guc_init_lrc_mapping(struct >>> intel_guc *guc) >>> /* make sure all descriptors are clean... */ >>> xa_destroy(&guc->context_lookup); >>> + /* >>> + * A reset might have occurred while we had a pending stalled >>> request, >>> + * so make sure we clean that up. >>> + */ >>> + guc->stalled_request = NULL; >>> + guc->submission_stall_reason = STALL_NONE; >>> + >>> /* >>> * Some contexts might have been pinned before we enabled GuC >>> * submission, so we need to add them to the GuC bookeeping. > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset @ 2022-08-30 14:13 ` Tvrtko Ursulin 0 siblings, 0 replies; 16+ messages in thread From: Tvrtko Ursulin @ 2022-08-30 14:13 UTC (permalink / raw) To: Ceraolo Spurio, Daniele, intel-gfx; +Cc: Matthew Brost, dri-devel, stable On 12/08/2022 16:31, Ceraolo Spurio, Daniele wrote: > On 8/12/2022 12:29 AM, Tvrtko Ursulin wrote: >> >> On 11/08/2022 22:08, Daniele Ceraolo Spurio wrote: >>> If the GuC CTs are full and we need to stall the request submission >>> while waiting for space, we save the stalled request and where the stall >>> occurred; when the CTs have space again we pick up the request >>> submission >>> from where we left off. >> >> How serious is it? Statement always was CT buffers can never get full >> outside the pathological IGT test cases. So I am wondering if this is >> in the category of fix for correctness or actually the CT buffers can >> get full in normal use so it is imperative to fix. > > The CT buffers being full is indeed something that is normally only > observed with IGTs that hammer the submission path, but it is still > something that a user can do so IMO we do have to fix it. However, the > bug is still extremely unlikely to happen out in the wild as it needs 2 > relatively rare things to happen: > > - We need to hit the pathological case of the GuC CTs being full and the > stall kicking in > - Something needs to go wrong and escalated to a full GT reset > > The bug report that triggered my investigation into this came from what > look like faulty HW: the HW seems to suddenly just stop with no errors > anywhere, which leads to the buffers filling up because the GuC is no > longer processing them, followed by a GT reset as we try to recover the > HW. To replicate this locally I had to add a debugfs to kill the GuC in > the middle of the test to simulate this "HW silently dies" scenario. Ack. Given the activity around pin/unpin performance issues I was briefly worried this is another one which was "upgraded" from only IGT to something in the real world after all. Thanks for confirming that is not the case. Regards, Tvrtko > > Daniele > >> >> Regards, >> >> Tvrtko >> >>> If a full GT reset occurs, the state of all contexts is cleared and all >>> non-guilty requests are unsubmitted, therefore we need to restart the >>> stalled request submission from scratch. To make sure that we do so, >>> clear the saved request after a reset. >>> >>> Fixes note: the patch that introduced the bug is in 5.15, but no >>> officially supported platform had GuC submission enabled by default >>> in that kernel, so the backport to that particular version (and only >>> that one) can potentially be skipped. >>> >>> Fixes: 925dc1cf58ed ("drm/i915/guc: Implement GuC submission tasklet") >>> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> >>> Cc: Matthew Brost <matthew.brost@intel.com> >>> Cc: John Harrison <john.c.harrison@intel.com> >>> Cc: <stable@vger.kernel.org> # v5.15+ >>> --- >>> drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> index 0d17da77e787..0d56b615bf78 100644 >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c >>> @@ -4002,6 +4002,13 @@ static inline void guc_init_lrc_mapping(struct >>> intel_guc *guc) >>> /* make sure all descriptors are clean... */ >>> xa_destroy(&guc->context_lookup); >>> + /* >>> + * A reset might have occurred while we had a pending stalled >>> request, >>> + * so make sure we clean that up. >>> + */ >>> + guc->stalled_request = NULL; >>> + guc->submission_stall_reason = STALL_NONE; >>> + >>> /* >>> * Some contexts might have been pinned before we enabled GuC >>> * submission, so we need to add them to the GuC bookeeping. > ^ permalink raw reply [flat|nested] 16+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: clear stalled request after a reset 2022-08-11 21:08 ` [Intel-gfx] " Daniele Ceraolo Spurio ` (3 preceding siblings ...) (?) @ 2022-08-12 8:19 ` Patchwork -1 siblings, 0 replies; 16+ messages in thread From: Patchwork @ 2022-08-12 8:19 UTC (permalink / raw) To: Daniele Ceraolo Spurio; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 45960 bytes --] == Series Details == Series: drm/i915/guc: clear stalled request after a reset URL : https://patchwork.freedesktop.org/series/107181/ State : success == Summary == CI Bug Log - changes from CI_DRM_11985_full -> Patchwork_107181v1_full ==================================================== Summary ------- **SUCCESS** No regressions found. Participating hosts (13 -> 13) ------------------------------ No changes in participating hosts Known issues ------------ Here are the changes found in Patchwork_107181v1_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_eio@in-flight-10ms: - shard-tglb: [PASS][1] -> [TIMEOUT][2] ([i915#3063]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-tglb2/igt@gem_eio@in-flight-10ms.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb3/igt@gem_eio@in-flight-10ms.html * igt@gem_eio@kms: - shard-tglb: [PASS][3] -> [FAIL][4] ([i915#5784]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-tglb7/igt@gem_eio@kms.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb2/igt@gem_eio@kms.html * igt@gem_exec_balancer@parallel-bb-first: - shard-iclb: [PASS][5] -> [SKIP][6] ([i915#4525]) +2 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-iclb2/igt@gem_exec_balancer@parallel-bb-first.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb7/igt@gem_exec_balancer@parallel-bb-first.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-kbl: [PASS][7] -> [SKIP][8] ([fdo#109271]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-kbl1/igt@gem_exec_fair@basic-flow@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-kbl1/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-none-rrul@rcs0: - shard-kbl: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-kbl4/igt@gem_exec_fair@basic-none-rrul@rcs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-kbl7/igt@gem_exec_fair@basic-none-rrul@rcs0.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [PASS][11] -> [FAIL][12] ([i915#2842]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-iclb1/igt@gem_exec_fair@basic-none-share@rcs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-iclb: NOTRUN -> [FAIL][13] ([i915#2842]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb2/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-kbl: NOTRUN -> [FAIL][14] ([i915#2842]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_suspend@basic-s3@smem: - shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-kbl4/igt@gem_exec_suspend@basic-s3@smem.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-kbl1/igt@gem_exec_suspend@basic-s3@smem.html * igt@gem_exec_whisper@basic-queues-priority: - shard-iclb: [PASS][17] -> [INCOMPLETE][18] ([i915#5498]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-iclb3/igt@gem_exec_whisper@basic-queues-priority.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb1/igt@gem_exec_whisper@basic-queues-priority.html * igt@gem_lmem_swapping@parallel-random: - shard-skl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#4613]) +1 similar issue [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl10/igt@gem_lmem_swapping@parallel-random.html * igt@gem_pxp@create-regular-context-1: - shard-iclb: NOTRUN -> [SKIP][20] ([i915#4270]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb2/igt@gem_pxp@create-regular-context-1.html * igt@gem_pxp@verify-pxp-stale-buf-optout-execution: - shard-skl: NOTRUN -> [SKIP][21] ([fdo#109271]) +74 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl10/igt@gem_pxp@verify-pxp-stale-buf-optout-execution.html * igt@gen9_exec_parse@allowed-single: - shard-apl: [PASS][22] -> [DMESG-WARN][23] ([i915#5566] / [i915#716]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-apl1/igt@gen9_exec_parse@allowed-single.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl4/igt@gen9_exec_parse@allowed-single.html * igt@gen9_exec_parse@valid-registers: - shard-iclb: NOTRUN -> [SKIP][24] ([i915#2856]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb2/igt@gen9_exec_parse@valid-registers.html * igt@i915_pm_rc6_residency@rc6-fence: - shard-tglb: NOTRUN -> [WARN][25] ([i915#2681]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@i915_pm_rc6_residency@rc6-fence.html * igt@i915_selftest@live@gt_pm: - shard-skl: NOTRUN -> [DMESG-FAIL][26] ([i915#1886]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl10/igt@i915_selftest@live@gt_pm.html - shard-tglb: NOTRUN -> [DMESG-FAIL][27] ([i915#1759]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@i915_selftest@live@gt_pm.html * igt@i915_suspend@forcewake: - shard-skl: [PASS][28] -> [INCOMPLETE][29] ([i915#4817]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-skl10/igt@i915_suspend@forcewake.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl10/igt@i915_suspend@forcewake.html * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip: - shard-apl: NOTRUN -> [SKIP][30] ([fdo#109271]) +39 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip: - shard-skl: NOTRUN -> [FAIL][31] ([i915#3743]) +1 similar issue [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl10/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html * igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs: - shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3886]) +1 similar issue [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl10/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs: - shard-tglb: NOTRUN -> [SKIP][33] ([i915#3689] / [i915#3886]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc: - shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3886]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-kbl1/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-b-bad-rotation-90-4_tiled_dg2_rc_ccs: - shard-tglb: NOTRUN -> [SKIP][35] ([i915#3689] / [i915#6095]) +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@kms_ccs@pipe-b-bad-rotation-90-4_tiled_dg2_rc_ccs.html * igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs: - shard-iclb: NOTRUN -> [SKIP][36] ([fdo#109278] / [i915#3886]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb2/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-b-crc-sprite-planes-basic-yf_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][37] ([fdo#111615] / [i915#3689]) +1 similar issue [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-yf_tiled_ccs.html * igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc: - shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#3886]) +2 similar issues [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl3/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][39] ([i915#3689]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_ccs.html * igt@kms_chamelium@dp-hpd-storm-disable: - shard-iclb: NOTRUN -> [SKIP][40] ([fdo#109284] / [fdo#111827]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb2/igt@kms_chamelium@dp-hpd-storm-disable.html * igt@kms_chamelium@hdmi-hpd-for-each-pipe: - shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +3 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl10/igt@kms_chamelium@hdmi-hpd-for-each-pipe.html * igt@kms_chamelium@hdmi-mode-timings: - shard-apl: NOTRUN -> [SKIP][42] ([fdo#109271] / [fdo#111827]) +1 similar issue [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl7/igt@kms_chamelium@hdmi-mode-timings.html * igt@kms_chamelium@vga-hpd-fast: - shard-kbl: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +1 similar issue [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-kbl1/igt@kms_chamelium@vga-hpd-fast.html * igt@kms_content_protection@atomic: - shard-kbl: NOTRUN -> [TIMEOUT][44] ([i915#1319]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-kbl1/igt@kms_content_protection@atomic.html * igt@kms_content_protection@dp-mst-lic-type-0: - shard-tglb: NOTRUN -> [SKIP][45] ([i915#3116] / [i915#3299]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@kms_content_protection@dp-mst-lic-type-0.html * igt@kms_content_protection@lic: - shard-tglb: NOTRUN -> [SKIP][46] ([i915#1063]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@kms_content_protection@lic.html * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy: - shard-tglb: NOTRUN -> [SKIP][47] ([fdo#109274] / [fdo#111825]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html * igt@kms_draw_crc@draw-method-rgb565-blt-4tiled: - shard-tglb: NOTRUN -> [SKIP][48] ([i915#5287]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@kms_draw_crc@draw-method-rgb565-blt-4tiled.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-apl: [PASS][49] -> [INCOMPLETE][50] ([i915#180] / [i915#1982] / [i915#4939]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-apl7/igt@kms_fbcon_fbt@fbc-suspend.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl2/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2: - shard-glk: [PASS][51] -> [FAIL][52] ([i915#79]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html * igt@kms_flip@2x-flip-vs-modeset: - shard-tglb: NOTRUN -> [SKIP][53] ([fdo#109274] / [fdo#111825] / [i915#3637]) +1 similar issue [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@kms_flip@2x-flip-vs-modeset.html * igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1: - shard-skl: [PASS][54] -> [FAIL][55] ([i915#2122]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-skl6/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl4/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1: - shard-skl: [PASS][56] -> [FAIL][57] ([i915#79]) +1 similar issue [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1: - shard-apl: [PASS][58] -> [FAIL][59] ([i915#79]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-apl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html * igt@kms_flip@flip-vs-suspend@a-dp1: - shard-apl: [PASS][60] -> [DMESG-WARN][61] ([i915#180]) +1 similar issue [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-apl8/igt@kms_flip@flip-vs-suspend@a-dp1.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl1/igt@kms_flip@flip-vs-suspend@a-dp1.html * igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode: - shard-tglb: NOTRUN -> [SKIP][62] ([i915#2672]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][63] ([i915#2672]) +7 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][64] ([i915#3555]) +1 similar issue [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt: - shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109280]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-wc: - shard-kbl: NOTRUN -> [SKIP][66] ([fdo#109271]) +53 similar issues [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-wc.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt: - shard-tglb: NOTRUN -> [SKIP][67] ([i915#6497]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-cpu: - shard-tglb: NOTRUN -> [SKIP][68] ([fdo#109280] / [fdo#111825]) +4 similar issues [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-cpu.html * igt@kms_hdr@bpc-switch@pipe-a-dp-1: - shard-kbl: [PASS][69] -> [FAIL][70] ([i915#1188]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-kbl4/igt@kms_hdr@bpc-switch@pipe-a-dp-1.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-kbl4/igt@kms_hdr@bpc-switch@pipe-a-dp-1.html * igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb: - shard-skl: NOTRUN -> [FAIL][71] ([fdo#108145] / [i915#265]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-c-alpha-basic: - shard-kbl: NOTRUN -> [FAIL][72] ([fdo#108145] / [i915#265]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-kbl1/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html * igt@kms_plane_cursor@pipe-d-viewport-size-256: - shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109278]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb2/igt@kms_plane_cursor@pipe-d-viewport-size-256.html * igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1: - shard-iclb: [PASS][74] -> [SKIP][75] ([i915#5235]) +2 similar issues [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-iclb8/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb2/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html * igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf: - shard-skl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#658]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl10/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html * igt@kms_psr@psr2_cursor_plane_move: - shard-tglb: NOTRUN -> [FAIL][77] ([i915#132] / [i915#3467]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@kms_psr@psr2_cursor_plane_move.html * igt@kms_psr@psr2_primary_render: - shard-iclb: [PASS][78] -> [SKIP][79] ([fdo#109441]) +1 similar issue [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-iclb2/igt@kms_psr@psr2_primary_render.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb7/igt@kms_psr@psr2_primary_render.html * igt@kms_setmode@basic-clone-single-crtc: - shard-tglb: NOTRUN -> [SKIP][80] ([i915#3555]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@kms_setmode@basic-clone-single-crtc.html * igt@perf@per-context-mode-unprivileged: - shard-tglb: NOTRUN -> [SKIP][81] ([fdo#109289]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@perf@per-context-mode-unprivileged.html * igt@prime_nv_api@i915_self_import: - shard-tglb: NOTRUN -> [SKIP][82] ([fdo#109291]) +1 similar issue [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@prime_nv_api@i915_self_import.html * igt@sysfs_clients@fair-7: - shard-tglb: NOTRUN -> [SKIP][83] ([i915#2994]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@sysfs_clients@fair-7.html - shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2994]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl10/igt@sysfs_clients@fair-7.html * igt@sysfs_clients@split-10: - shard-apl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#2994]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl3/igt@sysfs_clients@split-10.html #### Possible fixes #### * igt@drm_read@short-buffer-nonblock: - {shard-rkl}: [SKIP][86] ([i915#4098]) -> [PASS][87] [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-1/igt@drm_read@short-buffer-nonblock.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-6/igt@drm_read@short-buffer-nonblock.html * igt@fbdev@unaligned-read: - {shard-rkl}: [SKIP][88] ([i915#2582]) -> [PASS][89] [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-1/igt@fbdev@unaligned-read.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-6/igt@fbdev@unaligned-read.html * igt@feature_discovery@psr2: - shard-iclb: [SKIP][90] ([i915#658]) -> [PASS][91] [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-iclb4/igt@feature_discovery@psr2.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb2/igt@feature_discovery@psr2.html * igt@gem_ctx_exec@basic-nohangcheck: - shard-tglb: [FAIL][92] ([i915#6268]) -> [PASS][93] [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-tglb5/igt@gem_ctx_exec@basic-nohangcheck.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb2/igt@gem_ctx_exec@basic-nohangcheck.html - {shard-rkl}: [FAIL][94] ([i915#6268]) -> [PASS][95] [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-6/igt@gem_ctx_exec@basic-nohangcheck.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-5/igt@gem_ctx_exec@basic-nohangcheck.html * igt@gem_ctx_persistence@legacy-engines-hang@blt: - {shard-rkl}: [SKIP][96] ([i915#6252]) -> [PASS][97] [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-5/igt@gem_ctx_persistence@legacy-engines-hang@blt.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-2/igt@gem_ctx_persistence@legacy-engines-hang@blt.html * igt@gem_exec_balancer@fairslice: - {shard-rkl}: [SKIP][98] ([i915#6259]) -> [PASS][99] [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-5/igt@gem_exec_balancer@fairslice.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-2/igt@gem_exec_balancer@fairslice.html * igt@gem_exec_balancer@parallel-keep-submit-fence: - shard-iclb: [SKIP][100] ([i915#4525]) -> [PASS][101] [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-iclb3/igt@gem_exec_balancer@parallel-keep-submit-fence.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb4/igt@gem_exec_balancer@parallel-keep-submit-fence.html * igt@gem_exec_endless@dispatch@bcs0: - {shard-rkl}: [SKIP][102] ([i915#6247]) -> [PASS][103] [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-5/igt@gem_exec_endless@dispatch@bcs0.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-2/igt@gem_exec_endless@dispatch@bcs0.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-tglb: [FAIL][104] ([i915#2842]) -> [PASS][105] [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-tglb7/igt@gem_exec_fair@basic-none-share@rcs0.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb2/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none-solo@rcs0: - shard-apl: [FAIL][106] ([i915#2842]) -> [PASS][107] [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html * igt@gem_exec_schedule@semaphore-power: - {shard-rkl}: [SKIP][108] ([fdo#110254]) -> [PASS][109] [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-6/igt@gem_exec_schedule@semaphore-power.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-5/igt@gem_exec_schedule@semaphore-power.html * igt@gem_partial_pwrite_pread@writes-after-reads-display: - {shard-rkl}: [SKIP][110] ([i915#3282]) -> [PASS][111] +2 similar issues [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-6/igt@gem_partial_pwrite_pread@writes-after-reads-display.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads-display.html * igt@gem_set_tiling_vs_blt@tiled-to-untiled: - {shard-rkl}: [SKIP][112] ([i915#3281]) -> [PASS][113] +6 similar issues [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-2/igt@gem_set_tiling_vs_blt@tiled-to-untiled.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-5/igt@gem_set_tiling_vs_blt@tiled-to-untiled.html * igt@gem_workarounds@suspend-resume: - shard-kbl: [DMESG-WARN][114] ([i915#180]) -> [PASS][115] +1 similar issue [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-kbl1/igt@gem_workarounds@suspend-resume.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-kbl1/igt@gem_workarounds@suspend-resume.html * igt@gen9_exec_parse@secure-batches: - {shard-rkl}: [SKIP][116] ([i915#2527]) -> [PASS][117] +3 similar issues [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-2/igt@gen9_exec_parse@secure-batches.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-5/igt@gen9_exec_parse@secure-batches.html * igt@i915_pm_backlight@fade_with_suspend: - shard-skl: [INCOMPLETE][118] ([i915#4939]) -> [PASS][119] [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-skl9/igt@i915_pm_backlight@fade_with_suspend.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl10/igt@i915_pm_backlight@fade_with_suspend.html * igt@i915_pm_dc@dc5-psr: - {shard-rkl}: [SKIP][120] ([i915#658]) -> [PASS][121] [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-1/igt@i915_pm_dc@dc5-psr.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-6/igt@i915_pm_dc@dc5-psr.html * igt@i915_pm_dc@dc6-dpms: - shard-iclb: [FAIL][122] ([i915#454]) -> [PASS][123] [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb1/igt@i915_pm_dc@dc6-dpms.html * igt@i915_pm_rpm@dpms-non-lpsp: - {shard-dg1}: [SKIP][124] ([i915#1397]) -> [PASS][125] +2 similar issues [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-dg1-18/igt@i915_pm_rpm@dpms-non-lpsp.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-dg1-14/igt@i915_pm_rpm@dpms-non-lpsp.html * igt@i915_pm_rpm@modeset-lpsp: - {shard-rkl}: [SKIP][126] ([i915#1397]) -> [PASS][127] [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-1/igt@i915_pm_rpm@modeset-lpsp.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-6/igt@i915_pm_rpm@modeset-lpsp.html * igt@i915_pm_rpm@system-suspend: - shard-iclb: [INCOMPLETE][128] -> [PASS][129] [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-iclb4/igt@i915_pm_rpm@system-suspend.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb2/igt@i915_pm_rpm@system-suspend.html * igt@i915_pm_rps@waitboost: - {shard-rkl}: [FAIL][130] ([i915#4016]) -> [PASS][131] [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-2/igt@i915_pm_rps@waitboost.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-2/igt@i915_pm_rps@waitboost.html * igt@i915_selftest@live@gt_pm: - {shard-tglu}: [DMESG-FAIL][132] ([i915#3987]) -> [PASS][133] [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-tglu-4/igt@i915_selftest@live@gt_pm.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglu-2/igt@i915_selftest@live@gt_pm.html * igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1: - shard-skl: [FAIL][134] ([i915#2521]) -> [PASS][135] [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-skl6/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl9/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1.html * igt@kms_big_fb@x-tiled-32bpp-rotate-0: - {shard-rkl}: [SKIP][136] ([i915#1845] / [i915#4098]) -> [PASS][137] +11 similar issues [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-1/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-6/igt@kms_big_fb@x-tiled-32bpp-rotate-0.html * igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1: - shard-apl: [DMESG-WARN][138] ([i915#180]) -> [PASS][139] +3 similar issues [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-apl3/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl3/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html * igt@kms_cursor_legacy@cursor-vs-flip@legacy: - shard-iclb: [FAIL][140] ([i915#5072]) -> [PASS][141] [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-iclb7/igt@kms_cursor_legacy@cursor-vs-flip@legacy.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb5/igt@kms_cursor_legacy@cursor-vs-flip@legacy.html * igt@kms_draw_crc@draw-method-xrgb2101010-render-ytiled: - {shard-rkl}: [SKIP][142] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][143] [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-1/igt@kms_draw_crc@draw-method-xrgb2101010-render-ytiled.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-render-ytiled.html * igt@kms_frontbuffer_tracking@fbc-farfromfence-mmap-gtt: - {shard-rkl}: [SKIP][144] ([i915#1849] / [i915#4098]) -> [PASS][145] +3 similar issues [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-farfromfence-mmap-gtt.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-farfromfence-mmap-gtt.html * igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1: - shard-kbl: [FAIL][146] ([i915#1188]) -> [PASS][147] +1 similar issue [146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-kbl1/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-kbl1/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html * igt@kms_plane@plane-panning-bottom-right@pipe-b-planes: - {shard-rkl}: [SKIP][148] ([i915#3558]) -> [PASS][149] +1 similar issue [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-1/igt@kms_plane@plane-panning-bottom-right@pipe-b-planes.html [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-6/igt@kms_plane@plane-panning-bottom-right@pipe-b-planes.html * igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1: - shard-iclb: [SKIP][150] ([i915#5235]) -> [PASS][151] +2 similar issues [150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1.html [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb7/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-b-edp-1.html * igt@kms_psr@psr2_dpms: - shard-iclb: [SKIP][152] ([fdo#109441]) -> [PASS][153] [152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-iclb4/igt@kms_psr@psr2_dpms.html [153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb2/igt@kms_psr@psr2_dpms.html * igt@kms_psr@sprite_plane_onoff: - {shard-rkl}: [SKIP][154] ([i915#1072]) -> [PASS][155] [154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-1/igt@kms_psr@sprite_plane_onoff.html [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-6/igt@kms_psr@sprite_plane_onoff.html * igt@kms_universal_plane@cursor-fb-leak-pipe-b: - {shard-rkl}: [SKIP][156] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][157] [156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-1/igt@kms_universal_plane@cursor-fb-leak-pipe-b.html [157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-6/igt@kms_universal_plane@cursor-fb-leak-pipe-b.html * igt@perf@polling-parameterized: - {shard-rkl}: [FAIL][158] ([i915#5639]) -> [PASS][159] [158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-rkl-1/igt@perf@polling-parameterized.html [159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-rkl-6/igt@perf@polling-parameterized.html #### Warnings #### * igt@gem_pxp@fail-invalid-protected-context: - shard-skl: [SKIP][160] ([fdo#109271] / [i915#1888]) -> [SKIP][161] ([fdo#109271]) +1 similar issue [160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-skl9/igt@gem_pxp@fail-invalid-protected-context.html [161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl1/igt@gem_pxp@fail-invalid-protected-context.html * igt@i915_selftest@live@gt_lrc: - shard-tglb: [INCOMPLETE][162] ([i915#2373]) -> [DMESG-FAIL][163] ([i915#2373]) [162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-tglb3/igt@i915_selftest@live@gt_lrc.html [163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-tglb7/igt@i915_selftest@live@gt_lrc.html * igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc: - shard-skl: [SKIP][164] ([fdo#109271] / [i915#1888] / [i915#3886]) -> [SKIP][165] ([fdo#109271] / [i915#3886]) [164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-skl9/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html [165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl1/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html * igt@kms_flip@flip-vs-expired-vblank@a-edp1: - shard-skl: [FAIL][166] ([i915#2122]) -> [FAIL][167] ([i915#79]) [166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-skl1/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html [167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-skl10/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html * igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf: - shard-iclb: [SKIP][168] ([i915#2920]) -> [SKIP][169] ([i915#658]) +1 similar issue [168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html [169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb7/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html * igt@kms_psr2_su@page_flip-nv12: - shard-iclb: [SKIP][170] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][171] ([i915#5939]) [170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-iclb8/igt@kms_psr2_su@page_flip-nv12.html [171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html * igt@runner@aborted: - shard-apl: ([FAIL][172], [FAIL][173], [FAIL][174], [FAIL][175], [FAIL][176]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][177], [FAIL][178], [FAIL][179], [FAIL][180], [FAIL][181]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) [172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-apl4/igt@runner@aborted.html [173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-apl3/igt@runner@aborted.html [174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-apl1/igt@runner@aborted.html [175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-apl8/igt@runner@aborted.html [176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11985/shard-apl8/igt@runner@aborted.html [177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl4/igt@runner@aborted.html [178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl4/igt@runner@aborted.html [179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl2/igt@runner@aborted.html [180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl1/igt@runner@aborted.html [181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/shard-apl1/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759 [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232 [i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373 [i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410 [i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002 [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012 [i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743 [i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3987]: https://gitlab.freedesktop.org/drm/intel/issues/3987 [i915#4016]: https://gitlab.freedesktop.org/drm/intel/issues/4016 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817 [i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883 [i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939 [i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5498]: https://gitlab.freedesktop.org/drm/intel/issues/5498 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247 [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248 [i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251 [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252 [i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259 [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268 [i915#6448]: https://gitlab.freedesktop.org/drm/intel/issues/6448 [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 Build changes ------------- * Linux: CI_DRM_11985 -> Patchwork_107181v1 CI-20190529: 20190529 CI_DRM_11985: 89445c6d81d47caa0c489a412dd92aa4e627207d @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6623: c8edfca649da71b296d882bb0319181d94e619eb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_107181v1: 89445c6d81d47caa0c489a412dd92aa4e627207d @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107181v1/index.html [-- Attachment #2: Type: text/html, Size: 52536 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915/guc: clear stalled request after a reset 2022-08-11 21:08 ` [Intel-gfx] " Daniele Ceraolo Spurio (?) @ 2022-08-15 22:27 ` John Harrison -1 siblings, 0 replies; 16+ messages in thread From: John Harrison @ 2022-08-15 22:27 UTC (permalink / raw) To: Daniele Ceraolo Spurio, intel-gfx; +Cc: Matthew Brost, stable, dri-devel On 8/11/2022 14:08, Daniele Ceraolo Spurio wrote: > If the GuC CTs are full and we need to stall the request submission > while waiting for space, we save the stalled request and where the stall > occurred; when the CTs have space again we pick up the request submission > from where we left off. > > If a full GT reset occurs, the state of all contexts is cleared and all > non-guilty requests are unsubmitted, therefore we need to restart the > stalled request submission from scratch. To make sure that we do so, > clear the saved request after a reset. > > Fixes note: the patch that introduced the bug is in 5.15, but no > officially supported platform had GuC submission enabled by default > in that kernel, so the backport to that particular version (and only > that one) can potentially be skipped. > > Fixes: 925dc1cf58ed ("drm/i915/guc: Implement GuC submission tasklet") > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > Cc: Matthew Brost <matthew.brost@intel.com> > Cc: John Harrison <john.c.harrison@intel.com> > Cc: <stable@vger.kernel.org> # v5.15+ Seems like a good thing to do. Reviewed-by: John Harrison <John.C.Harrison@Intel.com> > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > index 0d17da77e787..0d56b615bf78 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > @@ -4002,6 +4002,13 @@ static inline void guc_init_lrc_mapping(struct intel_guc *guc) > /* make sure all descriptors are clean... */ > xa_destroy(&guc->context_lookup); > > + /* > + * A reset might have occurred while we had a pending stalled request, > + * so make sure we clean that up. > + */ > + guc->stalled_request = NULL; > + guc->submission_stall_reason = STALL_NONE; > + > /* > * Some contexts might have been pinned before we enabled GuC > * submission, so we need to add them to the GuC bookeeping. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: clear stalled request after a reset @ 2022-08-15 22:27 ` John Harrison 0 siblings, 0 replies; 16+ messages in thread From: John Harrison @ 2022-08-15 22:27 UTC (permalink / raw) To: Daniele Ceraolo Spurio, intel-gfx; +Cc: stable, dri-devel On 8/11/2022 14:08, Daniele Ceraolo Spurio wrote: > If the GuC CTs are full and we need to stall the request submission > while waiting for space, we save the stalled request and where the stall > occurred; when the CTs have space again we pick up the request submission > from where we left off. > > If a full GT reset occurs, the state of all contexts is cleared and all > non-guilty requests are unsubmitted, therefore we need to restart the > stalled request submission from scratch. To make sure that we do so, > clear the saved request after a reset. > > Fixes note: the patch that introduced the bug is in 5.15, but no > officially supported platform had GuC submission enabled by default > in that kernel, so the backport to that particular version (and only > that one) can potentially be skipped. > > Fixes: 925dc1cf58ed ("drm/i915/guc: Implement GuC submission tasklet") > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > Cc: Matthew Brost <matthew.brost@intel.com> > Cc: John Harrison <john.c.harrison@intel.com> > Cc: <stable@vger.kernel.org> # v5.15+ Seems like a good thing to do. Reviewed-by: John Harrison <John.C.Harrison@Intel.com> > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > index 0d17da77e787..0d56b615bf78 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > @@ -4002,6 +4002,13 @@ static inline void guc_init_lrc_mapping(struct intel_guc *guc) > /* make sure all descriptors are clean... */ > xa_destroy(&guc->context_lookup); > > + /* > + * A reset might have occurred while we had a pending stalled request, > + * so make sure we clean that up. > + */ > + guc->stalled_request = NULL; > + guc->submission_stall_reason = STALL_NONE; > + > /* > * Some contexts might have been pinned before we enabled GuC > * submission, so we need to add them to the GuC bookeeping. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] drm/i915/guc: clear stalled request after a reset @ 2022-08-15 22:27 ` John Harrison 0 siblings, 0 replies; 16+ messages in thread From: John Harrison @ 2022-08-15 22:27 UTC (permalink / raw) To: Daniele Ceraolo Spurio, intel-gfx; +Cc: dri-devel, Matthew Brost, stable On 8/11/2022 14:08, Daniele Ceraolo Spurio wrote: > If the GuC CTs are full and we need to stall the request submission > while waiting for space, we save the stalled request and where the stall > occurred; when the CTs have space again we pick up the request submission > from where we left off. > > If a full GT reset occurs, the state of all contexts is cleared and all > non-guilty requests are unsubmitted, therefore we need to restart the > stalled request submission from scratch. To make sure that we do so, > clear the saved request after a reset. > > Fixes note: the patch that introduced the bug is in 5.15, but no > officially supported platform had GuC submission enabled by default > in that kernel, so the backport to that particular version (and only > that one) can potentially be skipped. > > Fixes: 925dc1cf58ed ("drm/i915/guc: Implement GuC submission tasklet") > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > Cc: Matthew Brost <matthew.brost@intel.com> > Cc: John Harrison <john.c.harrison@intel.com> > Cc: <stable@vger.kernel.org> # v5.15+ Seems like a good thing to do. Reviewed-by: John Harrison <John.C.Harrison@Intel.com> > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > index 0d17da77e787..0d56b615bf78 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > @@ -4002,6 +4002,13 @@ static inline void guc_init_lrc_mapping(struct intel_guc *guc) > /* make sure all descriptors are clean... */ > xa_destroy(&guc->context_lookup); > > + /* > + * A reset might have occurred while we had a pending stalled request, > + * so make sure we clean that up. > + */ > + guc->stalled_request = NULL; > + guc->submission_stall_reason = STALL_NONE; > + > /* > * Some contexts might have been pinned before we enabled GuC > * submission, so we need to add them to the GuC bookeeping. ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2022-08-30 14:13 UTC | newest] Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-08-11 21:08 [PATCH] drm/i915/guc: clear stalled request after a reset Daniele Ceraolo Spurio 2022-08-11 21:08 ` Daniele Ceraolo Spurio 2022-08-11 21:08 ` [Intel-gfx] " Daniele Ceraolo Spurio 2022-08-11 22:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2022-08-12 7:29 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2022-08-12 7:29 ` Tvrtko Ursulin 2022-08-12 15:31 ` Ceraolo Spurio, Daniele 2022-08-12 15:31 ` Ceraolo Spurio, Daniele 2022-08-12 15:31 ` Ceraolo Spurio, Daniele 2022-08-30 14:13 ` Tvrtko Ursulin 2022-08-30 14:13 ` Tvrtko Ursulin 2022-08-30 14:13 ` Tvrtko Ursulin 2022-08-12 8:19 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork 2022-08-15 22:27 ` [PATCH] " John Harrison 2022-08-15 22:27 ` [Intel-gfx] " John Harrison 2022-08-15 22:27 ` John Harrison
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.