* [PATCH -next] blk-mq: remove unused function blk_mq_queue_stopped()
@ 2022-08-18 6:35 Yu Kuai
2022-08-18 13:38 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Yu Kuai @ 2022-08-18 6:35 UTC (permalink / raw)
To: axboe; +Cc: linux-block, linux-kernel, yukuai3, yukuai1, yi.zhang
From: Yu Kuai <yukuai3@huawei.com>
blk_mq_queue_stopped() doesn't have any caller, which was found by
code coverage test, thus remove it.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
block/blk-mq.c | 20 --------------------
include/linux/blk-mq.h | 1 -
2 files changed, 21 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 5ee62b95f3e5..5568c7d09114 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2229,26 +2229,6 @@ void blk_mq_delay_run_hw_queues(struct request_queue *q, unsigned long msecs)
}
EXPORT_SYMBOL(blk_mq_delay_run_hw_queues);
-/**
- * blk_mq_queue_stopped() - check whether one or more hctxs have been stopped
- * @q: request queue.
- *
- * The caller is responsible for serializing this function against
- * blk_mq_{start,stop}_hw_queue().
- */
-bool blk_mq_queue_stopped(struct request_queue *q)
-{
- struct blk_mq_hw_ctx *hctx;
- unsigned long i;
-
- queue_for_each_hw_ctx(q, hctx, i)
- if (blk_mq_hctx_stopped(hctx))
- return true;
-
- return false;
-}
-EXPORT_SYMBOL(blk_mq_queue_stopped);
-
/*
* This function is often used for pausing .queue_rq() by driver when
* there isn't enough resource or some conditions aren't satisfied, and
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index effee1dc715a..92294a5fb083 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -857,7 +857,6 @@ void blk_mq_kick_requeue_list(struct request_queue *q);
void blk_mq_delay_kick_requeue_list(struct request_queue *q, unsigned long msecs);
void blk_mq_complete_request(struct request *rq);
bool blk_mq_complete_request_remote(struct request *rq);
-bool blk_mq_queue_stopped(struct request_queue *q);
void blk_mq_stop_hw_queue(struct blk_mq_hw_ctx *hctx);
void blk_mq_start_hw_queue(struct blk_mq_hw_ctx *hctx);
void blk_mq_stop_hw_queues(struct request_queue *q);
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] blk-mq: remove unused function blk_mq_queue_stopped()
2022-08-18 6:35 [PATCH -next] blk-mq: remove unused function blk_mq_queue_stopped() Yu Kuai
@ 2022-08-18 13:38 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-08-18 13:38 UTC (permalink / raw)
To: yukuai1; +Cc: yukuai3, linux-kernel, yi.zhang, linux-block
On Thu, 18 Aug 2022 14:35:55 +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> blk_mq_queue_stopped() doesn't have any caller, which was found by
> code coverage test, thus remove it.
>
>
Applied, thanks!
[1/1] blk-mq: remove unused function blk_mq_queue_stopped()
commit: a8239f0342bae5a51acca967ba95b9a8ad56dd62
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-18 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-18 6:35 [PATCH -next] blk-mq: remove unused function blk_mq_queue_stopped() Yu Kuai
2022-08-18 13:38 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.