[PATCH] ASoC: SOF: ipc4-topology: fix alh_group_ida max value

[PATCH] ASoC: SOF: ipc4-topology: fix alh_group_ida max value

[Pierre-Louis Bossart]

From: Bard Liao <yung-chuan.liao@linux.intel.com>

group_id is from 0 ~ ALH_MULTI_GTW_COUNT - 1, not 0 ~
ALH_MULTI_GTW_COUNT.

Fixes: 0e357b5290532 ("ASoC: SOF: ipc4-topology: add SoundWire/ALH aggregation support"
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/sof/ipc4-topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c
index c6abfaf5d5326..64929dc9af397 100644
--- a/sound/soc/sof/ipc4-topology.c
+++ b/sound/soc/sof/ipc4-topology.c
@@ -1251,7 +1251,7 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget,
 			if (blob->alh_cfg.count > 1) {
 				int group_id;
 
-				group_id = ida_alloc_max(&alh_group_ida, ALH_MULTI_GTW_COUNT,
+				group_id = ida_alloc_max(&alh_group_ida, ALH_MULTI_GTW_COUNT - 1,
 							 GFP_KERNEL);
 
 				if (group_id < 0)
-- 
2.34.1

Re: [PATCH] ASoC: SOF: ipc4-topology: fix alh_group_ida max value

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

On Mon, Aug 22, 2022 at 09:02:11PM +0200, Pierre-Louis Bossart wrote:
> From: Bard Liao <yung-chuan.liao@linux.intel.com>
> 
> group_id is from 0 ~ ALH_MULTI_GTW_COUNT - 1, not 0 ~
> ALH_MULTI_GTW_COUNT.
> 
> Fixes: 0e357b5290532 ("ASoC: SOF: ipc4-topology: add SoundWire/ALH aggregation support"

This commit doesn't exist upstream, you probably meant
a150345aa758492e05d2934f318ce7c2566b1cfe.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] ASoC: SOF: ipc4-topology: fix alh_group_ida max value

[Mark Brown]

On Mon, 22 Aug 2022 21:02:11 +0200, Pierre-Louis Bossart wrote:
> From: Bard Liao <yung-chuan.liao@linux.intel.com>
> 
> group_id is from 0 ~ ALH_MULTI_GTW_COUNT - 1, not 0 ~
> ALH_MULTI_GTW_COUNT.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: ipc4-topology: fix alh_group_ida max value
      commit: 4ee6fc271b59e805301371ea3862f558a23d9c7b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark