* [Intel-gfx] [PATCH v2 0/3] Enable Pipewriteback
@ 2022-08-22 8:16 Kandpal, Suraj
2022-08-22 8:16 ` [Intel-gfx] [PATCH v2 1/3] drm/i915: Define WD trancoder for i915 Kandpal, Suraj
` (5 more replies)
0 siblings, 6 replies; 13+ messages in thread
From: Kandpal, Suraj @ 2022-08-22 8:16 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
A patch series was floated in the drm mailing list which aimed to change
the drm_connector and drm_encoder fields to pointer in the
drm_connector_writeback structure, this received a huge pushback from
the community but since i915 expects each connector present in the
drm_device list to be a intel_connector but drm_writeback framework
makes us have a connector which cannot be embedded in an intel_connector
structure.
[1] https://patchwork.kernel.org/project/dri-devel/patch/20220202081702.22119-1-suraj.kandpal@intel.com/
[2] https://patchwork.kernel.org/project/dri-devel/patch/20220202085429.22261-6-suraj.kandpal@intel.com/
Since no one had an issue with encoder field being changed into a
pointer it was decided to break the connector and encoder pointer
changes into two different series.The encoder field changes is
currently being worked upon by Abhinav Kumar and the changes have been
merged.
[3]https://patchwork.kernel.org/project/dri-devel/list/?series=633565
Going forward we use a drm_connector which is not embedded in
intel_connector.
We also create a intel_encoder to avoid changes to many
iterators but no intel_connector. We also changed all iterators that
go through connectors and add a check to only cast connectors which are
not writeback connectors.
I had also floated a previous series to Enable writeback but floating a
new one as i created an extra patch in this series as suggested by
Jani, Nikula for intel_connector iterator changes.
Please go check the below link if interested.
[4]https://patchwork.freedesktop.org/series/106902/
v2-------
solving BAT issues
Suraj Kandpal (3):
drm/i915: Define WD trancoder for i915
drm/i915 : Changing intel_connector iterators
drm/i915: Enabling WD Transcoder
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/intel_acpi.c | 1 +
drivers/gpu/drm/i915/display/intel_crtc.c | 6 +
.../drm/i915/display/intel_crtc_state_dump.c | 1 +
drivers/gpu/drm/i915/display/intel_ddi.c | 6 +
drivers/gpu/drm/i915/display/intel_display.c | 65 +-
drivers/gpu/drm/i915/display/intel_display.h | 18 +-
.../drm/i915/display/intel_display_debugfs.c | 13 +-
.../drm/i915/display/intel_display_types.h | 33 +-
drivers/gpu/drm/i915/display/intel_dpll.c | 6 +
.../drm/i915/display/intel_modeset_setup.c | 119 ++-
.../drm/i915/display/intel_modeset_verify.c | 17 +-
drivers/gpu/drm/i915/display/intel_opregion.c | 3 +
.../gpu/drm/i915/display/intel_wb_connector.h | 20 +
drivers/gpu/drm/i915/display/intel_wd.c | 699 ++++++++++++++++++
drivers/gpu/drm/i915/display/intel_wd.h | 48 ++
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 8 +-
drivers/gpu/drm/i915/i915_pci.c | 7 +-
drivers/gpu/drm/i915/i915_reg.h | 139 ++++
20 files changed, 1156 insertions(+), 55 deletions(-)
create mode 100644 drivers/gpu/drm/i915/display/intel_wb_connector.h
create mode 100644 drivers/gpu/drm/i915/display/intel_wd.c
create mode 100644 drivers/gpu/drm/i915/display/intel_wd.h
--
2.25.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH v2 1/3] drm/i915: Define WD trancoder for i915
2022-08-22 8:16 [Intel-gfx] [PATCH v2 0/3] Enable Pipewriteback Kandpal, Suraj
@ 2022-08-22 8:16 ` Kandpal, Suraj
2022-09-09 8:57 ` Murthy, Arun R
2022-08-22 8:16 ` [Intel-gfx] [PATCH v2 2/3] drm/i915 : Changing intel_connector iterators Kandpal, Suraj
` (4 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Kandpal, Suraj @ 2022-08-22 8:16 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
From: Suraj Kandpal <suraj.kandpal@intel.com>
Adding WD Types, WD transcoder to enum list and WD Transcoder offsets.
Adding i915 register definitions related to WD transcoder
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.h | 6 +
.../drm/i915/display/intel_display_types.h | 1 +
drivers/gpu/drm/i915/i915_reg.h | 139 ++++++++++++++++++
3 files changed, 146 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
index fa5371036239..4e9f22954a41 100644
--- a/drivers/gpu/drm/i915/display/intel_display.h
+++ b/drivers/gpu/drm/i915/display/intel_display.h
@@ -120,6 +120,8 @@ enum transcoder {
TRANSCODER_DSI_1,
TRANSCODER_DSI_A = TRANSCODER_DSI_0, /* legacy DSI */
TRANSCODER_DSI_C = TRANSCODER_DSI_1, /* legacy DSI */
+ TRANSCODER_WD_0,
+ TRANSCODER_WD_1,
I915_MAX_TRANSCODERS
};
@@ -141,6 +143,10 @@ static inline const char *transcoder_name(enum transcoder transcoder)
return "DSI A";
case TRANSCODER_DSI_C:
return "DSI C";
+ case TRANSCODER_WD_0:
+ return "WD 0";
+ case TRANSCODER_WD_1:
+ return "WD 1";
default:
return "<invalid>";
}
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 0da9b208d56e..0e94bd430bcb 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -79,6 +79,7 @@ enum intel_output_type {
INTEL_OUTPUT_DSI = 9,
INTEL_OUTPUT_DDI = 10,
INTEL_OUTPUT_DP_MST = 11,
+ INTEL_OUTPUT_WD = 12,
};
enum hdmi_force_audio {
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index bf5c39d9f953..e3fced4b9980 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -2059,6 +2059,8 @@
#define TRANSCODER_EDP_OFFSET 0x6f000
#define TRANSCODER_DSI0_OFFSET 0x6b000
#define TRANSCODER_DSI1_OFFSET 0x6b800
+#define TRANSCODER_WD0_OFFSET 0x6e000
+#define TRANSCODER_WD1_OFFSET 0x6e800
#define HTOTAL(trans) _MMIO_TRANS2(trans, _HTOTAL_A)
#define HBLANK(trans) _MMIO_TRANS2(trans, _HBLANK_A)
@@ -3831,6 +3833,11 @@
#define PIPE_DSI0_OFFSET 0x7b000
#define PIPE_DSI1_OFFSET 0x7b800
+/* WD 0 and 1 */
+#define PIPE_WD0_OFFSET 0x7e000
+#define PIPE_WD1_OFFSET 0x7d000
+
+
#define PIPECONF(pipe) _MMIO_PIPE2(pipe, _PIPEACONF)
#define PIPEDSL(pipe) _MMIO_PIPE2(pipe, _PIPEADSL)
#define PIPEFRAME(pipe) _MMIO_PIPE2(pipe, _PIPEAFRAMEHIGH)
@@ -4495,6 +4502,10 @@
#define _PIPEDSI0CONF 0x7b008
#define _PIPEDSI1CONF 0x7b808
+/* WD 0 and 1 */
+#define _PIPEWD0CONF 0x7e008
+#define _PIPEWD1CONF 0x7d008
+
/* Sprite A control */
#define _DVSACNTR 0x72180
#define DVS_ENABLE REG_BIT(31)
@@ -5720,6 +5731,7 @@
#define GEN8_DE_MISC_IER _MMIO(0x4446c)
#define GEN8_DE_MISC_GSE (1 << 27)
#define GEN8_DE_EDP_PSR (1 << 19)
+#define GEN8_DE_MISC_WD0 (1 << 23)
#define GEN8_PCU_ISR _MMIO(0x444e0)
#define GEN8_PCU_IMR _MMIO(0x444e4)
@@ -8714,6 +8726,133 @@ enum skl_power_gate {
#define DSB_ENABLE (1 << 31)
#define DSB_STATUS (1 << 0)
+#define TGL_ROOT_DEVICE_ID 0x9A00
+#define TGL_ROOT_DEVICE_MASK 0xFF00
+#define TGL_ROOT_DEVICE_SKU_MASK 0xF
+#define TGL_ROOT_DEVICE_SKU_ULX 0x2
+#define TGL_ROOT_DEVICE_SKU_ULT 0x4
+
+/* Gen12 WD */
+#define _MMIO_WD(tc, wd0, wd1) _MMIO_TRANS((tc) - TRANSCODER_WD_0, \
+ wd0, wd1)
+
+#define WD_TRANS_ENABLE (1 << 31)
+#define WD_TRANS_DISABLE 0
+#define WD_TRANS_ACTIVE (1 << 30)
+
+/* WD transcoder control */
+#define _WD_TRANS_FUNC_CTL_0 0x6e400
+#define _WD_TRANS_FUNC_CTL_1 0x6ec00
+#define WD_TRANS_FUNC_CTL(tc) _MMIO_WD(tc,\
+ _WD_TRANS_FUNC_CTL_0,\
+ _WD_TRANS_FUNC_CTL_1)
+
+#define TRANS_WD_FUNC_ENABLE (1 << 31)
+#define WD_TRIGGERED_CAP_MODE_ENABLE (1 << 30)
+#define START_TRIGGER_FRAME (1 << 29)
+#define STOP_TRIGGER_FRAME (1 << 28)
+#define WD_CTL_POINTER_ETEH (0 << 18)
+#define WD_CTL_POINTER_ETDH (1 << 18)
+#define WD_CTL_POINTER_DTDH (2 << 18)
+#define WD_INPUT_SELECT_MASK (7 << 12)
+#define WD_INPUT_PIPE_A (0 << 12)
+#define WD_INPUT_PIPE_B (5 << 12)
+#define WD_INPUT_PIPE_C (6 << 12)
+#define WD_INPUT_PIPE_D (7 << 12)
+
+#define WD_PIX_FMT_MASK (0x3 << 20)
+#define WD_PIX_FMT_YUYV (0x1 << 20)
+#define WD_PIX_FMT_XYUV8888 (0x2 << 20)
+#define WD_PIX_FMT_XBGR8888 (0x3 << 20)
+#define WD_PIX_FMT_Y410 (0x4 << 20)
+#define WD_PIX_FMT_YUV422 (0x5 << 20)
+#define WD_PIX_FMT_XBGR2101010 (0x6 << 20)
+#define WD_PIX_FMT_RGB565 (0x7 << 20)
+
+#define WD_FRAME_NUMBER_MASK 15
+
+#define _WD_STRIDE_0 0x6e510
+#define _WD_STRIDE_1 0x6ed10
+#define WD_STRIDE(tc) _MMIO_WD(tc,\
+ _WD_STRIDE_0,\
+ _WD_STRIDE_1)
+#define WD_STRIDE_SHIFT 6
+#define WD_STRIDE_MASK (0x3ff << WD_STRIDE_SHIFT)
+
+#define _WD_STREAMCAP_CTL0 0x6e590
+#define _WD_STREAMCAP_CTL1 0x6ed90
+#define WD_STREAMCAP_CTL(tc) _MMIO_WD(tc,\
+ _WD_STREAMCAP_CTL0,\
+ _WD_STREAMCAP_CTL1)
+
+#define WD_STREAM_CAP_MODE_EN (1 << 31)
+#define WD_STRAT_MASK (3 << 24)
+#define WD_SLICING_STRAT_1_1 (0 << 24)
+#define WD_SLICING_STRAT_2_1 (1 << 24)
+#define WD_SLICING_STRAT_4_1 (2 << 24)
+#define WD_SLICING_STRAT_8_1 (3 << 24)
+#define WD_STREAM_OVERRUN_STATUS 1
+
+#define _WD_SURF_0 0x6e514
+#define _WD_SURF_1 0x6ed14
+#define WD_SURF(tc) _MMIO_WD(tc,\
+ _WD_SURF_0,\
+ _WD_SURF_1)
+
+#define _WD_IMR_0 0x6e560
+#define _WD_IMR_1 0x6ed60
+#define WD_IMR(tc) _MMIO_WD(tc,\
+ _WD_IMR_0,\
+ _WD_IMR_1)
+#define WD_FRAME_COMPLETE_INT (1 << 7)
+#define WD_GTT_FAULT_INT (1 << 6)
+#define WD_VBLANK_INT (1 << 5)
+#define WD_OVERRUN_INT (1 << 4)
+#define WD_CAPTURING_INT (1 << 3)
+#define WD_WRITE_COMPLETE_INT (1 << 2)
+
+#define _WD_IIR_0 0x6e564
+#define _WD_IIR_1 0x6ed64
+#define WD_IIR(tc) _MMIO_WD(tc,\
+ _WD_IIR_0,\
+ _WD_IIR_1)
+
+#define _WD_FRAME_STATUS_0 0x6e56b
+#define _WD_FRAME_STATUS_1 0x6ed6b
+#define WD_FRAME_STATUS(tc) _MMIO_WD(tc,\
+ _WD_FRAME_STATUS_0,\
+ _WD_FRAME_STATUS_1)
+
+#define WD_FRAME_COMPLETE (1 << 31)
+#define WD_STATE_IDLE (0 << 24)
+#define WD_STATE_CAPSTART (1 << 24)
+#define WD_STATE_FRAME_START (2 << 24)
+#define WD_STATE_CAPACITIVE (3 << 24)
+#define WD_STATE_TG_DONE (4 << 24)
+#define WD_STATE_WDX_DONE (5 << 24)
+#define WD_STATE_QUICK_CAP (6 << 24)
+
+#define _WD_27_M_0 0x6e524
+#define _WD_27_M_1 0x6ed24
+#define WD_27_M(tc) _MMIO_WD(tc,\
+ _WD_27_M_0,\
+ _WD_27_M_1)
+
+#define _WD_27_N_0 0x6e528
+
+//Address looks wrong in bspec:
+#define _WD_27_N_1 0x6ec28
+#define WD_27_N(tc) _MMIO_WD(tc,\
+ _WD_27_N_0,\
+ _WD_27_N_1)
+
+#define _WD_TAIL_CFG_0 0x6e520
+#define _WD_TAIL_CFG_1 0x6ed20
+
+#define WD_TAIL_CFG(tc) _MMIO_WD(tc,\
+ _WD_TAIL_CFG_0,\
+ _WD_TAIL_CFG_1)
+
#define CLKREQ_POLICY _MMIO(0x101038)
#define CLKREQ_POLICY_MEM_UP_OVRD REG_BIT(1)
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH v2 2/3] drm/i915 : Changing intel_connector iterators
2022-08-22 8:16 [Intel-gfx] [PATCH v2 0/3] Enable Pipewriteback Kandpal, Suraj
2022-08-22 8:16 ` [Intel-gfx] [PATCH v2 1/3] drm/i915: Define WD trancoder for i915 Kandpal, Suraj
@ 2022-08-22 8:16 ` Kandpal, Suraj
2022-09-09 8:58 ` Murthy, Arun R
2022-08-22 8:16 ` [Intel-gfx] [PATCH v2 3/3] drm/i915: Enabling WD Transcoder Kandpal, Suraj
` (3 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Kandpal, Suraj @ 2022-08-22 8:16 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
From: Suraj Kandpal <suraj.kandpal@intel.com>
Changing intel_connector iterators as with writeback introduction
not all drm_connector will be embedded within intel_connector.
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.h | 7 ++---
.../drm/i915/display/intel_display_types.h | 26 ++++++++++++++++++-
.../drm/i915/display/intel_modeset_setup.c | 16 +++++++++---
3 files changed, 40 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
index 4e9f22954a41..3b9987b5f304 100644
--- a/drivers/gpu/drm/i915/display/intel_display.h
+++ b/drivers/gpu/drm/i915/display/intel_display.h
@@ -52,6 +52,7 @@ struct intel_crtc_state;
struct intel_digital_port;
struct intel_dp;
struct intel_encoder;
+struct intel_connector;
struct intel_initial_plane_config;
struct intel_load_detect_pipe;
struct intel_plane;
@@ -469,16 +470,12 @@ enum hpd_pin {
for_each_if(intel_encoder_can_psr(intel_encoder))
#define for_each_intel_connector_iter(intel_connector, iter) \
- while ((intel_connector = to_intel_connector(drm_connector_list_iter_next(iter))))
+ while ((intel_connector = intel_connector_list_iter_next(iter)))
#define for_each_encoder_on_crtc(dev, __crtc, intel_encoder) \
list_for_each_entry((intel_encoder), &(dev)->mode_config.encoder_list, base.head) \
for_each_if((intel_encoder)->base.crtc == (__crtc))
-#define for_each_connector_on_encoder(dev, __encoder, intel_connector) \
- list_for_each_entry((intel_connector), &(dev)->mode_config.connector_list, base.head) \
- for_each_if((intel_connector)->base.encoder == (__encoder))
-
#define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \
for ((__i) = 0; \
(__i) < (__state)->base.dev->mode_config.num_total_plane && \
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 0e94bd430bcb..7a82b7acbaf2 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1497,12 +1497,14 @@ struct cxsr_latency {
#define to_intel_atomic_state(x) container_of(x, struct intel_atomic_state, base)
#define to_intel_crtc(x) container_of(x, struct intel_crtc, base)
#define to_intel_crtc_state(x) container_of(x, struct intel_crtc_state, uapi)
-#define to_intel_connector(x) container_of(x, struct intel_connector, base)
+#define to_intel_wb_connector(x) container_of(x, struct intel_wb_connector, base)
#define to_intel_encoder(x) container_of(x, struct intel_encoder, base)
#define to_intel_framebuffer(x) container_of(x, struct intel_framebuffer, base)
#define to_intel_plane(x) container_of(x, struct intel_plane, base)
#define to_intel_plane_state(x) container_of(x, struct intel_plane_state, uapi)
#define intel_fb_obj(x) ((x) ? to_intel_bo((x)->obj[0]) : NULL)
+#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \
+ NULL : container_of(x, struct intel_connector, base))
struct intel_hdmi {
i915_reg_t hdmi_reg;
@@ -2068,4 +2070,26 @@ to_intel_frontbuffer(struct drm_framebuffer *fb)
return fb ? to_intel_framebuffer(fb)->frontbuffer : NULL;
}
+static inline struct intel_connector *
+intel_connector_list_iter_next(struct drm_connector_list_iter *iter)
+{
+ struct drm_connector *connector;
+ bool flag = true;
+ /*
+ * Skipping connector that are Writeback connector as they will
+ * not be embedded in intel connector
+ */
+ while (flag) {
+ connector = drm_connector_list_iter_next(iter);
+ if (connector && !to_intel_connector(connector))
+ continue;
+
+ flag = false;
+
+ if (connector)
+ return to_intel_connector(connector);
+
+ }
+ return NULL;
+}
#endif /* __INTEL_DISPLAY_TYPES_H__ */
diff --git a/drivers/gpu/drm/i915/display/intel_modeset_setup.c b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
index f0e04d3904c6..985dfa5f7aa1 100644
--- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
+++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
@@ -204,12 +204,22 @@ static bool intel_crtc_has_encoders(struct intel_crtc *crtc)
static struct intel_connector *intel_encoder_find_connector(struct intel_encoder *encoder)
{
- struct drm_device *dev = encoder->base.dev;
+ struct drm_i915_private *i915 = to_i915(encoder->base.dev);
struct intel_connector *connector;
+ struct drm_connector_list_iter conn_iter;
+ bool found_connector = false;
- for_each_connector_on_encoder(dev, &encoder->base, connector)
- return connector;
+ drm_connector_list_iter_begin(&i915->drm, &conn_iter);
+ for_each_intel_connector_iter(connector, &conn_iter) {
+ if (&encoder->base == connector->base.encoder) {
+ found_connector = true;
+ break;
+ }
+ }
+ drm_connector_list_iter_end(&conn_iter);
+ if (found_connector)
+ return connector;
return NULL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH v2 3/3] drm/i915: Enabling WD Transcoder
2022-08-22 8:16 [Intel-gfx] [PATCH v2 0/3] Enable Pipewriteback Kandpal, Suraj
2022-08-22 8:16 ` [Intel-gfx] [PATCH v2 1/3] drm/i915: Define WD trancoder for i915 Kandpal, Suraj
2022-08-22 8:16 ` [Intel-gfx] [PATCH v2 2/3] drm/i915 : Changing intel_connector iterators Kandpal, Suraj
@ 2022-08-22 8:16 ` Kandpal, Suraj
2022-09-12 8:07 ` Murthy, Arun R
2022-08-24 22:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev2) Patchwork
` (2 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Kandpal, Suraj @ 2022-08-22 8:16 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
From: Suraj Kandpal <suraj.kandpal@intel.com>
Adding support for writeback transcoder to start capturing frames using
interrupt mechanism
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/intel_acpi.c | 1 +
drivers/gpu/drm/i915/display/intel_crtc.c | 6 +
.../drm/i915/display/intel_crtc_state_dump.c | 1 +
drivers/gpu/drm/i915/display/intel_ddi.c | 6 +
drivers/gpu/drm/i915/display/intel_display.c | 65 +-
drivers/gpu/drm/i915/display/intel_display.h | 5 +
.../drm/i915/display/intel_display_debugfs.c | 13 +-
.../drm/i915/display/intel_display_types.h | 6 +
drivers/gpu/drm/i915/display/intel_dpll.c | 6 +
.../drm/i915/display/intel_modeset_setup.c | 103 ++-
.../drm/i915/display/intel_modeset_verify.c | 17 +-
drivers/gpu/drm/i915/display/intel_opregion.c | 3 +
.../gpu/drm/i915/display/intel_wb_connector.h | 20 +
drivers/gpu/drm/i915/display/intel_wd.c | 699 ++++++++++++++++++
drivers/gpu/drm/i915/display/intel_wd.h | 48 ++
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 8 +-
drivers/gpu/drm/i915/i915_pci.c | 7 +-
19 files changed, 970 insertions(+), 46 deletions(-)
create mode 100644 drivers/gpu/drm/i915/display/intel_wb_connector.h
create mode 100644 drivers/gpu/drm/i915/display/intel_wd.c
create mode 100644 drivers/gpu/drm/i915/display/intel_wd.h
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index 522ef9b4aff3..ec63ed16c250 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -302,6 +302,7 @@ i915-y += \
display/intel_tv.o \
display/intel_vdsc.o \
display/intel_vrr.o \
+ display/intel_wd.o \
display/vlv_dsi.o \
display/vlv_dsi_pll.o
diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
index e78430001f07..ae08db164f73 100644
--- a/drivers/gpu/drm/i915/display/intel_acpi.c
+++ b/drivers/gpu/drm/i915/display/intel_acpi.c
@@ -247,6 +247,7 @@ static u32 acpi_display_type(struct intel_connector *connector)
case DRM_MODE_CONNECTOR_LVDS:
case DRM_MODE_CONNECTOR_eDP:
case DRM_MODE_CONNECTOR_DSI:
+ case DRM_MODE_CONNECTOR_WRITEBACK:
display_type = ACPI_DISPLAY_TYPE_INTERNAL_DIGITAL;
break;
case DRM_MODE_CONNECTOR_Unknown:
diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c
index 6792a9056f46..66d552758720 100644
--- a/drivers/gpu/drm/i915/display/intel_crtc.c
+++ b/drivers/gpu/drm/i915/display/intel_crtc.c
@@ -491,6 +491,9 @@ void intel_pipe_update_start(struct intel_crtc_state *new_crtc_state)
if (new_crtc_state->do_async_flip)
return;
+ if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
+ return;
+
if (intel_crtc_needs_vblank_work(new_crtc_state))
intel_crtc_vblank_work_init(new_crtc_state);
@@ -638,6 +641,9 @@ void intel_pipe_update_end(struct intel_crtc_state *new_crtc_state)
if (new_crtc_state->do_async_flip)
return;
+ if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
+ return;
+
trace_intel_pipe_update_end(crtc, end_vbl_count, scanline_end);
/*
diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
index e9212f69c360..8435065f3b7d 100644
--- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
+++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
@@ -71,6 +71,7 @@ static const char * const output_type_str[] = {
OUTPUT_TYPE(DSI),
OUTPUT_TYPE(DDI),
OUTPUT_TYPE(DP_MST),
+ OUTPUT_TYPE(WD),
};
#undef OUTPUT_TYPE
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index a4c8493f3ce7..1360406ca531 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -1974,6 +1974,12 @@ void intel_ddi_sanitize_encoder_pll_mapping(struct intel_encoder *encoder)
*/
if (encoder->type == INTEL_OUTPUT_DP_MST)
return;
+ /*
+ * WD transcoder is a virtual encoder hence sanization
+ * is not required for it
+ */
+ if (encoder->type == INTEL_OUTPUT_WD)
+ return;
if (!encoder->base.crtc && intel_encoder_is_dp(encoder)) {
u8 pipe_mask;
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index f143adefdf38..52fb23846856 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -115,6 +115,7 @@
#include "intel_sprite.h"
#include "intel_tc.h"
#include "intel_vga.h"
+#include "intel_wd.h"
#include "i9xx_plane.h"
#include "skl_scaler.h"
#include "skl_universal_plane.h"
@@ -1510,6 +1511,9 @@ static void intel_encoders_update_prepare(struct intel_atomic_state *state)
continue;
intel_connector = to_intel_connector(connector);
+ if (!intel_connector)
+ continue;
+
encoder = intel_connector_primary_encoder(intel_connector);
if (!encoder->update_prepare)
continue;
@@ -1539,6 +1543,9 @@ static void intel_encoders_update_complete(struct intel_atomic_state *state)
continue;
intel_connector = to_intel_connector(connector);
+ if (!intel_connector)
+ continue;
+
encoder = intel_connector_primary_encoder(intel_connector);
if (!encoder->update_complete)
continue;
@@ -1549,6 +1556,39 @@ static void intel_encoders_update_complete(struct intel_atomic_state *state)
}
}
+static void intel_queue_writeback_job(struct intel_atomic_state *state,
+ struct intel_crtc *intel_crtc, struct intel_crtc_state *crtc_state)
+{
+ struct drm_connector_state *new_conn_state;
+ struct drm_connector *connector;
+ struct drm_writeback_connector *wb_conn;
+ int i;
+
+ for_each_new_connector_in_state(&state->base, connector, new_conn_state,
+ i) {
+ if (!new_conn_state->writeback_job)
+ continue;
+
+ wb_conn = drm_connector_to_writeback(connector);
+ drm_writeback_queue_job(wb_conn, new_conn_state);
+ }
+}
+
+static void intel_enable_writeback_capture(struct intel_atomic_state *state,
+ struct intel_crtc *intel_crtc, struct intel_crtc_state *crtc_state)
+{
+ struct drm_connector_state *new_conn_state;
+ struct drm_connector *connector;
+ int i;
+
+ for_each_new_connector_in_state(&state->base, connector, new_conn_state,
+ i) {
+ if (connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK)
+ continue;
+ intel_wd_enable_capture(crtc_state, new_conn_state);
+ }
+}
+
static void intel_encoders_pre_pll_enable(struct intel_atomic_state *state,
struct intel_crtc *crtc)
{
@@ -1649,8 +1689,12 @@ static void intel_encoders_post_disable(struct intel_atomic_state *state,
int i;
for_each_old_connector_in_state(&state->base, conn, old_conn_state, i) {
- struct intel_encoder *encoder =
- to_intel_encoder(old_conn_state->best_encoder);
+ struct intel_encoder *encoder;
+
+ if (conn->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)
+ continue;
+
+ encoder = to_intel_encoder(old_conn_state->best_encoder);
if (old_conn_state->crtc != &crtc->base)
continue;
@@ -1927,7 +1971,8 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
bdw_set_pipemisc(new_crtc_state);
if (!intel_crtc_is_bigjoiner_slave(new_crtc_state) &&
- !transcoder_is_dsi(cpu_transcoder))
+ !transcoder_is_dsi(cpu_transcoder) &&
+ !transcoder_is_wd(cpu_transcoder))
hsw_configure_cpu_transcoder(new_crtc_state);
crtc->active = true;
@@ -7575,6 +7620,12 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
}
}
+ for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
+ if (!(new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD)))
+ continue;
+ intel_wd_set_vblank_event(state, crtc, new_crtc_state);
+ }
+
intel_encoders_update_prepare(state);
intel_dbuf_pre_plane_update(state);
@@ -7585,6 +7636,13 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
intel_crtc_enable_flip_done(state, crtc);
}
+ for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
+ if (!(new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD)))
+ continue;
+ intel_queue_writeback_job(state, crtc, new_crtc_state);
+ intel_enable_writeback_capture(state, crtc, new_crtc_state);
+ }
+
/* Now enable the clocks, plane, pipe, and connectors that we set up. */
dev_priv->display->commit_modeset_enables(state);
@@ -7965,6 +8023,7 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
intel_ddi_init(dev_priv, PORT_TC1);
intel_ddi_init(dev_priv, PORT_TC2);
} else if (DISPLAY_VER(dev_priv) >= 12) {
+ intel_wd_init(dev_priv, TRANSCODER_WD_0);
intel_ddi_init(dev_priv, PORT_A);
intel_ddi_init(dev_priv, PORT_B);
intel_ddi_init(dev_priv, PORT_TC1);
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
index 3b9987b5f304..4879ca2e96f7 100644
--- a/drivers/gpu/drm/i915/display/intel_display.h
+++ b/drivers/gpu/drm/i915/display/intel_display.h
@@ -158,6 +158,11 @@ static inline bool transcoder_is_dsi(enum transcoder transcoder)
return transcoder == TRANSCODER_DSI_A || transcoder == TRANSCODER_DSI_C;
}
+static inline bool transcoder_is_wd(enum transcoder transcoder)
+{
+ return transcoder == TRANSCODER_WD_0 || transcoder == TRANSCODER_WD_1;
+}
+
/*
* Global legacy plane identifier. Valid only for primary/sprite
* planes on pre-g4x, and only for primary planes on g4x-bdw.
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index 225b6bfc783c..0dad54058762 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -547,7 +547,7 @@ static void intel_hdmi_info(struct seq_file *m,
static void intel_connector_info(struct seq_file *m,
struct drm_connector *connector)
{
- struct intel_connector *intel_connector = to_intel_connector(connector);
+ struct intel_connector *intel_connector;
const struct drm_connector_state *conn_state = connector->state;
struct intel_encoder *encoder =
to_intel_encoder(conn_state->best_encoder);
@@ -570,6 +570,8 @@ static void intel_connector_info(struct seq_file *m,
if (!encoder)
return;
+ intel_connector = to_intel_connector(connector);
+
switch (connector->connector_type) {
case DRM_MODE_CONNECTOR_DisplayPort:
case DRM_MODE_CONNECTOR_eDP:
@@ -587,12 +589,15 @@ static void intel_connector_info(struct seq_file *m,
break;
}
- seq_puts(m, "\tHDCP version: ");
- intel_hdcp_info(m, intel_connector);
+ if (intel_connector) {
+ seq_puts(m, "\tHDCP version: ");
+ intel_hdcp_info(m, intel_connector);
+ }
seq_printf(m, "\tmax bpc: %u\n", connector->display_info.bpc);
- intel_panel_info(m, intel_connector);
+ if (intel_connector)
+ intel_panel_info(m, intel_connector);
seq_printf(m, "\tmodes:\n");
list_for_each_entry(mode, &connector->modes, head)
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 7a82b7acbaf2..7b550c532dfb 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -44,6 +44,7 @@
#include <drm/drm_vblank.h>
#include <drm/drm_vblank_work.h>
#include <drm/i915_mei_hdcp_interface.h>
+#include <drm/drm_writeback.h>
#include <media/cec-notifier.h>
#include "i915_vma.h"
@@ -1370,6 +1371,11 @@ struct intel_crtc {
bool cpu_fifo_underrun_disabled;
bool pch_fifo_underrun_disabled;
+ struct {
+ struct drm_pending_vblank_event *e;
+ atomic_t work_busy;
+ wait_queue_head_t wd_wait;
+ } wd;
/* per-pipe watermark state */
struct {
/* watermarks currently being used */
diff --git a/drivers/gpu/drm/i915/display/intel_dpll.c b/drivers/gpu/drm/i915/display/intel_dpll.c
index 5262f16b45ac..82bb8e170197 100644
--- a/drivers/gpu/drm/i915/display/intel_dpll.c
+++ b/drivers/gpu/drm/i915/display/intel_dpll.c
@@ -939,6 +939,9 @@ static int hsw_crtc_compute_clock(struct intel_atomic_state *state,
struct intel_encoder *encoder =
intel_get_crtc_new_encoder(state, crtc_state);
+ if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_WD))
+ return 0;
+
if (DISPLAY_VER(dev_priv) < 11 &&
intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI))
return 0;
@@ -955,6 +958,9 @@ static int hsw_crtc_get_shared_dpll(struct intel_atomic_state *state,
struct intel_encoder *encoder =
intel_get_crtc_new_encoder(state, crtc_state);
+ if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_WD))
+ return 0;
+
if (DISPLAY_VER(dev_priv) < 11 &&
intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI))
return 0;
diff --git a/drivers/gpu/drm/i915/display/intel_modeset_setup.c b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
index 985dfa5f7aa1..0e48c1a31024 100644
--- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
+++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
@@ -23,6 +23,7 @@
#include "intel_modeset_setup.h"
#include "intel_pch_display.h"
#include "intel_pm.h"
+#include "intel_wd.h"
static void intel_crtc_disable_noatomic(struct intel_crtc *crtc,
struct drm_modeset_acquire_ctx *ctx)
@@ -110,17 +111,17 @@ static void intel_crtc_disable_noatomic(struct intel_crtc *crtc,
static void intel_modeset_update_connector_atomic_state(struct drm_i915_private *i915)
{
- struct intel_connector *connector;
+ struct drm_connector *connector;
struct drm_connector_list_iter conn_iter;
drm_connector_list_iter_begin(&i915->drm, &conn_iter);
- for_each_intel_connector_iter(connector, &conn_iter) {
- struct drm_connector_state *conn_state = connector->base.state;
+ drm_for_each_connector_iter(connector, &conn_iter) {
+ struct drm_connector_state *conn_state = connector->state;
struct intel_encoder *encoder =
- to_intel_encoder(connector->base.encoder);
+ to_intel_encoder(connector->encoder);
if (conn_state->crtc)
- drm_connector_put(&connector->base);
+ drm_connector_put(connector);
if (encoder) {
struct intel_crtc *crtc =
@@ -132,7 +133,7 @@ static void intel_modeset_update_connector_atomic_state(struct drm_i915_private
conn_state->crtc = &crtc->base;
conn_state->max_bpc = (crtc_state->pipe_bpp ?: 24) / 3;
- drm_connector_get(&connector->base);
+ drm_connector_get(connector);
} else {
conn_state->best_encoder = NULL;
conn_state->crtc = NULL;
@@ -432,6 +433,8 @@ static void intel_modeset_readout_hw_state(struct drm_i915_private *i915)
struct intel_crtc *crtc;
struct intel_encoder *encoder;
struct intel_connector *connector;
+ struct drm_connector *_connector;
+ struct drm_encoder *_encoder;
struct drm_connector_list_iter conn_iter;
u8 active_pipes = 0;
@@ -508,38 +511,70 @@ static void intel_modeset_readout_hw_state(struct drm_i915_private *i915)
intel_dpll_readout_hw_state(i915);
drm_connector_list_iter_begin(&i915->drm, &conn_iter);
- for_each_intel_connector_iter(connector, &conn_iter) {
- if (connector->get_hw_state(connector)) {
- struct intel_crtc_state *crtc_state;
- struct intel_crtc *crtc;
-
- connector->base.dpms = DRM_MODE_DPMS_ON;
-
- encoder = intel_attached_encoder(connector);
- connector->base.encoder = &encoder->base;
-
- crtc = to_intel_crtc(encoder->base.crtc);
- crtc_state = crtc ? to_intel_crtc_state(crtc->base.state) : NULL;
-
- if (crtc_state && crtc_state->hw.active) {
- /*
- * This has to be done during hardware readout
- * because anything calling .crtc_disable may
- * rely on the connector_mask being accurate.
- */
- crtc_state->uapi.connector_mask |=
- drm_connector_mask(&connector->base);
- crtc_state->uapi.encoder_mask |=
- drm_encoder_mask(&encoder->base);
+ drm_for_each_connector_iter(_connector, &conn_iter) {
+ struct intel_crtc_state *crtc_state;
+ struct intel_crtc *crtc;
+ struct drm_writeback_connector *wb_conn;
+ struct intel_wd *intel_wd;
+
+ connector = to_intel_connector(_connector);
+ if (!connector) {
+ wb_conn = drm_connector_to_writeback(_connector);
+ intel_wd = wb_conn_to_intel_wd(wb_conn);
+ _encoder = &intel_wd->base.base;
+ _connector->encoder = _encoder;
+ encoder = to_intel_encoder(_encoder);
+ pipe = 0;
+ if (encoder->get_hw_state(encoder, &pipe)) {
+ _connector->dpms = DRM_MODE_DPMS_ON;
+ crtc = to_intel_crtc(_encoder->crtc);
+ crtc_state = crtc ? to_intel_crtc_state(crtc->base.state) : NULL;
+
+ if (crtc_state && crtc_state->hw.active) {
+ /*
+ * This has to be done during hardware readout
+ * because anything calling .crtc_disable may
+ * rely on the connector_mask being accurate.
+ */
+ crtc_state->uapi.connector_mask |=
+ drm_connector_mask(&connector->base);
+ crtc_state->uapi.encoder_mask |=
+ drm_encoder_mask(&encoder->base);
+ }
+ } else {
+ _connector->dpms = DRM_MODE_DPMS_OFF;
+ _connector->encoder = NULL;
}
} else {
- connector->base.dpms = DRM_MODE_DPMS_OFF;
- connector->base.encoder = NULL;
+ if (connector->get_hw_state(connector)) {
+ connector->base.dpms = DRM_MODE_DPMS_OFF;
+ encoder = intel_attached_encoder(connector);
+ connector->base.encoder = &encoder->base;
+
+ crtc = to_intel_crtc(encoder->base.crtc);
+ crtc_state = crtc ? to_intel_crtc_state(crtc->base.state) : NULL;
+
+ if (crtc_state && crtc_state->hw.active) {
+ /*
+ * This has to be done during hardware readout
+ * because anything calling .crtc_disable may
+ * rely on the connector_mask being accurate.
+ */
+ crtc_state->uapi.connector_mask |=
+ drm_connector_mask(&connector->base);
+ crtc_state->uapi.encoder_mask |=
+ drm_encoder_mask(&encoder->base);
+ }
+ } else {
+ connector->base.dpms = DRM_MODE_DPMS_OFF;
+ connector->base.encoder = NULL;
+ }
}
drm_dbg_kms(&i915->drm,
- "[CONNECTOR:%d:%s] hw state readout: %s\n",
- connector->base.base.id, connector->base.name,
- str_enabled_disabled(connector->base.encoder));
+ "[CONNECTOR:%d:%s] hw state readout: %s\n",
+ _connector->base.id, _connector->name,
+ str_enabled_disabled(_connector->encoder));
+
}
drm_connector_list_iter_end(&conn_iter);
diff --git a/drivers/gpu/drm/i915/display/intel_modeset_verify.c b/drivers/gpu/drm/i915/display/intel_modeset_verify.c
index a91586d77cb6..0e06daac74c1 100644
--- a/drivers/gpu/drm/i915/display/intel_modeset_verify.c
+++ b/drivers/gpu/drm/i915/display/intel_modeset_verify.c
@@ -25,11 +25,16 @@
static void intel_connector_verify_state(struct intel_crtc_state *crtc_state,
struct drm_connector_state *conn_state)
{
- struct intel_connector *connector = to_intel_connector(conn_state->connector);
- struct drm_i915_private *i915 = to_i915(connector->base.dev);
+ struct drm_connector *_connector = conn_state->connector;
+ struct intel_connector *connector;
+ struct drm_i915_private *i915 = to_i915(_connector->dev);
drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s]\n",
- connector->base.base.id, connector->base.name);
+ _connector->base.id, _connector->name);
+
+ connector = to_intel_connector(_connector);
+ if (!connector)
+ return;
if (connector->get_hw_state(connector)) {
struct intel_encoder *encoder = intel_attached_encoder(connector);
@@ -119,6 +124,9 @@ verify_encoder_state(struct drm_i915_private *dev_priv, struct intel_atomic_stat
encoder->base.base.id,
encoder->base.name);
+ if (encoder->type == INTEL_OUTPUT_WD)
+ continue;
+
for_each_oldnew_connector_in_state(&state->base, connector, old_conn_state,
new_conn_state, i) {
if (old_conn_state->best_encoder == &encoder->base)
@@ -177,6 +185,9 @@ verify_crtc_state(struct intel_crtc *crtc,
intel_crtc_get_pipe_config(pipe_config);
+ if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
+ return;
+
/* we keep both pipes enabled on 830 */
if (IS_I830(dev_priv) && pipe_config->hw.active)
pipe_config->hw.active = new_crtc_state->hw.active;
diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c
index 1c0c745c142d..73a5a12e2c48 100644
--- a/drivers/gpu/drm/i915/display/intel_opregion.c
+++ b/drivers/gpu/drm/i915/display/intel_opregion.c
@@ -374,6 +374,9 @@ int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder,
if (ret)
return ret;
+ if (intel_encoder->type == INTEL_OUTPUT_WD)
+ return 0;
+
if (intel_encoder->type == INTEL_OUTPUT_DSI)
port = 0;
else
diff --git a/drivers/gpu/drm/i915/display/intel_wb_connector.h b/drivers/gpu/drm/i915/display/intel_wb_connector.h
new file mode 100644
index 000000000000..39dceddc7b4d
--- /dev/null
+++ b/drivers/gpu/drm/i915/display/intel_wb_connector.h
@@ -0,0 +1,20 @@
+/* SPDX-License-Identifier: MIT*/
+/*
+ * Copyright © 2022 Intel Corporation
+ */
+
+#ifndef __INTEL_WB_CONNECTOR_H__
+#define __INTEL_WB_CONNECTOR_H__
+
+#include "intel_display.h"
+
+struct intel_wb_connector *intel_wb_connector_alloc(void);
+void intel_wb_connector_free(struct intel_wb_connector *connector);
+void intel_wb_connector_destroy(struct drm_connector *connector);
+bool intel_wb_connector_get_hw_state(struct intel_wb_connector *connector);
+enum pipe intel_wb_connector_get_pipe(struct intel_wb_connector *connector);
+void intel_wb_connector_attach_encoder(struct intel_wb_connector *connector,
+ struct intel_encoder *encoder);
+
+#endif /* __INTEL_WB_CONNECTOR_H__ */
+
diff --git a/drivers/gpu/drm/i915/display/intel_wd.c b/drivers/gpu/drm/i915/display/intel_wd.c
new file mode 100644
index 000000000000..a30cf1055db4
--- /dev/null
+++ b/drivers/gpu/drm/i915/display/intel_wd.c
@@ -0,0 +1,699 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2022 Intel Corporation
+ */
+
+#include <drm/drm_atomic_helper.h>
+#include <drm/drm_fourcc.h>
+
+#include "intel_atomic.h"
+#include "intel_connector.h"
+#include "intel_wd.h"
+#include "intel_fb_pin.h"
+#include "intel_de.h"
+
+enum {
+ WD_CAPTURE_4_PIX,
+ WD_CAPTURE_2_PIX,
+} wd_capture_format;
+
+struct drm_writeback_job
+*intel_get_writeback_job_from_queue(struct intel_wd *intel_wd)
+{
+ struct drm_writeback_job *job;
+ struct drm_i915_private *i915 = to_i915(intel_wd->base.base.dev);
+ struct drm_writeback_connector *wb_conn =
+ &intel_wd->wb_conn;
+ unsigned long flags;
+
+ spin_lock_irqsave(&wb_conn->job_lock, flags);
+ job = list_first_entry_or_null(&wb_conn->job_queue,
+ struct drm_writeback_job,
+ list_entry);
+ spin_unlock_irqrestore(&wb_conn->job_lock, flags);
+ if (job == NULL) {
+ drm_dbg_kms(&i915->drm, "job queue is empty\n");
+ return NULL;
+ }
+
+ return job;
+}
+
+/*Check with Spec*/
+static const u32 wb_fmts[] = {
+ DRM_FORMAT_YUV444,
+ DRM_FORMAT_XYUV8888,
+ DRM_FORMAT_XBGR8888,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_Y410,
+ DRM_FORMAT_YUV422,
+ DRM_FORMAT_XBGR2101010,
+ DRM_FORMAT_RGB565,
+};
+
+static int intel_wd_get_format(int pixel_format)
+{
+ int wd_format = -EINVAL;
+
+ switch (pixel_format) {
+ case DRM_FORMAT_XBGR8888:
+ case DRM_FORMAT_XRGB8888:
+ case DRM_FORMAT_XBGR2101010:
+ case DRM_FORMAT_XYUV8888:
+ case DRM_FORMAT_YUV444:
+ wd_format = WD_CAPTURE_4_PIX;
+ break;
+ case DRM_FORMAT_YUV422:
+ case DRM_FORMAT_RGB565:
+ wd_format = WD_CAPTURE_2_PIX;
+ break;
+ default:
+ DRM_ERROR("unsupported pixel format %x!\n",
+ pixel_format);
+ }
+
+ return wd_format;
+}
+
+static int intel_wd_verify_pix_format(int format)
+{
+ const struct drm_format_info *info = drm_format_info(format);
+ int pix_format = info->format;
+ int i = 0;
+
+ for (i = 0; i < ARRAY_SIZE(wb_fmts); i++)
+ if (pix_format == wb_fmts[i])
+ return 0;
+
+ return 1;
+}
+
+static u32 intel_wd_get_stride(const struct intel_crtc_state *crtc_state,
+ int format)
+{
+ const struct drm_format_info *info = drm_format_info(format);
+ int wd_format;
+ int hactive, pixel_size;
+
+ wd_format = intel_wd_get_format(info->format);
+
+ switch (wd_format) {
+ case WD_CAPTURE_4_PIX:
+ pixel_size = 4;
+ break;
+ case WD_CAPTURE_2_PIX:
+ pixel_size = 2;
+ break;
+ default:
+ pixel_size = 1;
+ break;
+ }
+
+ hactive = crtc_state->hw.adjusted_mode.crtc_hdisplay;
+
+ return DIV_ROUND_UP(hactive * pixel_size, 64);
+}
+
+static int intel_wd_pin_fb(struct intel_wd *intel_wd,
+ struct drm_framebuffer *fb)
+{
+ const struct i915_ggtt_view view = {
+ .type = I915_GGTT_VIEW_NORMAL,
+ };
+ struct i915_vma *vma;
+
+ vma = intel_pin_and_fence_fb_obj(fb, false, &view, false,
+ &intel_wd->flags);
+
+ if (IS_ERR(vma))
+ return PTR_ERR(vma);
+
+ intel_wd->vma = vma;
+ return 0;
+}
+
+static void intel_configure_slicing_strategy(struct drm_i915_private *dev_priv,
+ struct intel_wd *intel_wd, u32 *tmp)
+{
+ *tmp &= ~WD_STRAT_MASK;
+ if (intel_wd->slicing_strategy == 1)
+ *tmp |= WD_SLICING_STRAT_1_1;
+ else if (intel_wd->slicing_strategy == 2)
+ *tmp |= WD_SLICING_STRAT_2_1;
+ else if (intel_wd->slicing_strategy == 3)
+ *tmp |= WD_SLICING_STRAT_4_1;
+ else if (intel_wd->slicing_strategy == 4)
+ *tmp |= WD_SLICING_STRAT_8_1;
+
+ intel_de_write(dev_priv, WD_STREAMCAP_CTL(intel_wd->trans),
+ *tmp);
+}
+
+static enum drm_mode_status
+intel_wd_mode_valid(struct drm_connector *connector,
+ struct drm_display_mode *mode)
+{
+ drm_dbg_kms(connector->dev, ":");
+ return MODE_OK;
+}
+
+static int intel_wd_get_modes(struct drm_connector *connector)
+{
+ return 0;
+}
+
+static void intel_wd_get_config(struct intel_encoder *encoder,
+ struct intel_crtc_state *pipe_config)
+{
+ struct intel_crtc *intel_crtc =
+ to_intel_crtc(pipe_config->uapi.crtc);
+
+ if (intel_crtc) {
+ memcpy(pipe_config, intel_crtc->config,
+ sizeof(*pipe_config));
+ pipe_config->output_types |= BIT(INTEL_OUTPUT_WD);
+ }
+}
+
+static int intel_wd_compute_config(struct intel_encoder *encoder,
+ struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state)
+{
+ struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
+ struct drm_writeback_job *job;
+
+ job = intel_get_writeback_job_from_queue(intel_wd);
+ if (job || conn_state->writeback_job) {
+ intel_wd->wd_crtc = to_intel_crtc(pipe_config->uapi.crtc);
+ return 0;
+ }
+
+ return 0;
+}
+
+static void intel_wd_get_power_domains(struct intel_encoder *encoder,
+ struct intel_crtc_state *crtc_state)
+{
+ struct drm_i915_private *i915 = to_i915(encoder->base.dev);
+ struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
+ intel_wakeref_t wakeref;
+
+ wakeref = intel_display_power_get(i915,
+ encoder->power_domain);
+
+ intel_wd->io_wakeref[0] = wakeref;
+}
+
+static bool intel_wd_get_hw_state(struct intel_encoder *encoder,
+ enum pipe *pipe)
+{
+ bool ret = false;
+ struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
+ struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
+ struct intel_crtc *wd_crtc = intel_wd->wd_crtc;
+ intel_wakeref_t wakeref;
+ u32 tmp;
+
+ if (wd_crtc)
+ return false;
+
+ wakeref = intel_display_power_get_if_enabled(dev_priv,
+ encoder->power_domain);
+
+ if (!wakeref)
+ goto out;
+
+ tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
+ ret = tmp & WD_TRANS_ACTIVE;
+ if (ret) {
+ *pipe = wd_crtc->pipe;
+ return true;
+ }
+
+out:
+ intel_display_power_put(dev_priv, encoder->power_domain, wakeref);
+ return false;
+}
+
+static int intel_wd_encoder_atomic_check(struct drm_encoder *encoder,
+ struct drm_crtc_state *crtc_st,
+ struct drm_connector_state *conn_st)
+{
+ /* Check for the format and buffers and property validity */
+ struct drm_framebuffer *fb;
+ struct drm_writeback_job *job = conn_st->writeback_job;
+ struct drm_i915_private *i915 = to_i915(encoder->dev);
+ const struct drm_display_mode *mode = &crtc_st->mode;
+ int ret;
+
+ if (!job) {
+ drm_dbg_kms(&i915->drm, "No writeback job created returning\n");
+ return -EINVAL;
+ }
+
+ fb = job->fb;
+ if (!fb) {
+ drm_dbg_kms(&i915->drm, "Invalid framebuffer\n");
+ return -EINVAL;
+ }
+
+ if (fb->width != mode->hdisplay || fb->height != mode->vdisplay) {
+ drm_dbg_kms(&i915->drm, "Invalid framebuffer size %ux%u\n",
+ fb->width, fb->height);
+ return -EINVAL;
+ }
+
+ ret = intel_wd_verify_pix_format(fb->format->format);
+ if (ret) {
+ drm_dbg_kms(&i915->drm, "Unsupported framebuffer format %08x\n",
+ fb->format->format);
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
+
+static const struct drm_encoder_helper_funcs wd_encoder_helper_funcs = {
+ .atomic_check = intel_wd_encoder_atomic_check,
+};
+
+static void intel_wd_connector_destroy(struct drm_connector *connector)
+{
+ drm_connector_cleanup(connector);
+ kfree(connector);
+}
+
+static enum drm_connector_status
+intel_wb_connector_detect(struct drm_connector *connector, bool force)
+{
+ return connector_status_connected;
+}
+
+static const struct drm_connector_funcs wd_connector_funcs = {
+ .detect = intel_wb_connector_detect,
+ .reset = drm_atomic_helper_connector_reset,
+ .destroy = intel_wd_connector_destroy,
+ .fill_modes = drm_helper_probe_single_connector_modes,
+ .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
+ .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
+};
+
+static const struct drm_connector_helper_funcs wd_connector_helper_funcs = {
+ .get_modes = intel_wd_get_modes,
+ .mode_valid = intel_wd_mode_valid,
+};
+
+static const struct drm_encoder_funcs drm_writeback_encoder_funcs = {
+ .destroy = drm_encoder_cleanup,
+};
+
+static bool intel_fastset_dis(struct intel_encoder *encoder,
+ struct intel_crtc_state *pipe_config)
+{
+ return false;
+}
+
+static void intel_wd_connector_init(struct intel_wd *intel_wd)
+{
+ drm_atomic_helper_connector_reset(&intel_wd->wb_conn.base);
+}
+
+static void intel_wd_disable_capture(struct intel_wd *intel_wd)
+{
+ struct drm_i915_private *dev_priv = to_i915(intel_wd->base.base.dev);
+ u32 tmp;
+
+ intel_de_write_fw(dev_priv, WD_IMR(intel_wd->trans), 0xFF);
+ tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
+ tmp &= WD_TRANS_DISABLE;
+ intel_de_write(dev_priv, PIPECONF(intel_wd->trans), tmp);
+ tmp = intel_de_read(dev_priv, WD_TRANS_FUNC_CTL(intel_wd->trans));
+ tmp |= ~TRANS_WD_FUNC_ENABLE;
+}
+
+void intel_wd_init(struct drm_i915_private *i915, enum transcoder trans)
+{
+ struct intel_wd *intel_wd;
+ struct intel_encoder *encoder;
+ struct drm_writeback_connector *wb_conn;
+ int n_formats = ARRAY_SIZE(wb_fmts);
+ struct drm_encoder *drm_enc;
+ int err, ret;
+
+ intel_wd = kzalloc(sizeof(*intel_wd), GFP_KERNEL);
+
+ if (!intel_wd)
+ return;
+
+ intel_wd_connector_init(intel_wd);
+ encoder = &intel_wd->base;
+ drm_enc = &encoder->base;
+ wb_conn = &intel_wd->wb_conn;
+ intel_wd->trans = trans;
+ intel_wd->triggered_cap_mode = 1;
+ intel_wd->frame_num = 1;
+ intel_wd->slicing_strategy = 1;
+ encoder->get_config = intel_wd_get_config;
+ encoder->compute_config = intel_wd_compute_config;
+ encoder->get_hw_state = intel_wd_get_hw_state;
+ encoder->type = INTEL_OUTPUT_WD;
+ encoder->cloneable = 0;
+ encoder->pipe_mask = ~0;
+ encoder->power_domain = POWER_DOMAIN_TRANSCODER_B;
+ encoder->get_power_domains = intel_wd_get_power_domains;
+ encoder->initial_fastset_check = intel_fastset_dis;
+
+ drm_encoder_helper_add(drm_enc,
+ &wd_encoder_helper_funcs);
+
+ drm_enc->possible_crtcs = ~0;
+ ret = drm_encoder_init(&i915->drm, drm_enc,
+ &drm_writeback_encoder_funcs,
+ DRM_MODE_ENCODER_VIRTUAL, NULL);
+
+ if (ret) {
+ drm_dbg_kms(&i915->drm,
+ "Writeback drm_encoder init Failed: %d\n",
+ ret);
+ goto cleanup;
+ }
+
+ err = drm_writeback_connector_init_with_encoder(&i915->drm,
+ wb_conn, drm_enc, &wd_connector_funcs,
+ wb_fmts, n_formats);
+
+ if (err != 0) {
+ drm_dbg_kms(&i915->drm,
+ "drm_writeback_connector_init: Failed: %d\n",
+ err);
+ goto cleanup;
+ }
+
+ wb_conn->base.encoder = drm_enc;
+ drm_connector_helper_add(&wb_conn->base, &wd_connector_helper_funcs);
+ wb_conn->base.status = connector_status_connected;
+ return;
+
+cleanup:
+ kfree(intel_wd);
+ return;
+}
+
+static void intel_wd_writeback_complete(struct intel_wd *intel_wd,
+ struct drm_writeback_job *job, int status)
+{
+ struct drm_writeback_connector *wb_conn =
+ &intel_wd->wb_conn;
+ drm_writeback_signal_completion(wb_conn, status);
+}
+
+static int intel_wd_setup_transcoder(struct intel_wd *intel_wd,
+ struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state,
+ struct drm_writeback_job *job)
+{
+ struct intel_crtc *intel_crtc = to_intel_crtc(pipe_config->uapi.crtc);
+ enum pipe pipe = intel_crtc->pipe;
+ struct drm_framebuffer *fb;
+ struct drm_i915_private *dev_priv = to_i915(intel_crtc->base.dev);
+ struct drm_gem_object *wd_fb_obj;
+ int ret;
+ u32 stride, tmp;
+ u16 hactive, vactive;
+
+ fb = job->fb;
+ wd_fb_obj = fb->obj[0];
+ if (!wd_fb_obj) {
+ drm_dbg_kms(&dev_priv->drm, "No framebuffer gem object created\n");
+ return -1;
+ }
+
+ ret = intel_wd_pin_fb(intel_wd, fb);
+ drm_WARN_ON(&dev_priv->drm, ret != 0);
+ /*Write stride and surface registers in that particular order*/
+ stride = intel_wd_get_stride(pipe_config, fb->format->format);
+
+ tmp = intel_de_read(dev_priv, WD_STRIDE(intel_wd->trans));
+ tmp &= ~WD_STRIDE_MASK;
+ tmp |= (stride << WD_STRIDE_SHIFT);
+
+ intel_de_write(dev_priv, WD_STRIDE(intel_wd->trans), tmp);
+
+ tmp = intel_de_read(dev_priv, WD_SURF(intel_wd->trans));
+
+ intel_de_write(dev_priv, WD_SURF(intel_wd->trans),
+ i915_ggtt_offset(intel_wd->vma));
+
+ tmp = intel_de_read_fw(dev_priv, WD_IIR(intel_wd->trans));
+ intel_de_write_fw(dev_priv, WD_IIR(intel_wd->trans), tmp);
+
+ tmp = ~(WD_GTT_FAULT_INT | WD_WRITE_COMPLETE_INT | WD_FRAME_COMPLETE_INT |
+ WD_VBLANK_INT | WD_OVERRUN_INT | WD_CAPTURING_INT);
+ intel_de_write_fw(dev_priv, WD_IMR(intel_wd->trans), tmp);
+
+ if (intel_wd->stream_cap) {
+ tmp = intel_de_read(dev_priv,
+ WD_STREAMCAP_CTL(intel_wd->trans));
+ tmp |= WD_STREAM_CAP_MODE_EN;
+ intel_configure_slicing_strategy(dev_priv, intel_wd, &tmp);
+ }
+
+ hactive = pipe_config->uapi.mode.hdisplay;
+ vactive = pipe_config->uapi.mode.vdisplay;
+ tmp = intel_de_read(dev_priv, HTOTAL(intel_wd->trans));
+ tmp = intel_de_read(dev_priv, VTOTAL(intel_wd->trans));
+
+ /* minimum hactive as per bspec: 64 pixels*/
+ if (hactive < 64)
+ drm_err(&dev_priv->drm, "hactive is less then 64 pixels\n");
+
+ intel_de_write(dev_priv, HTOTAL(intel_wd->trans), hactive - 1);
+ intel_de_write(dev_priv, VTOTAL(intel_wd->trans), vactive - 1);
+
+ tmp = intel_de_read(dev_priv, WD_TRANS_FUNC_CTL(intel_wd->trans));
+ /* select pixel format */
+ tmp &= ~WD_PIX_FMT_MASK;
+
+ switch (fb->format->format) {
+ default:
+ fallthrough;
+ case DRM_FORMAT_YUYV:
+ tmp |= WD_PIX_FMT_YUYV;
+ break;
+ case DRM_FORMAT_XYUV8888:
+ tmp |= WD_PIX_FMT_XYUV8888;
+ break;
+ case DRM_FORMAT_XBGR8888:
+ case DRM_FORMAT_XRGB8888:
+ tmp |= WD_PIX_FMT_XBGR8888;
+ break;
+ case DRM_FORMAT_Y410:
+ tmp |= WD_PIX_FMT_Y410;
+ break;
+ case DRM_FORMAT_YUV422:
+ tmp |= WD_PIX_FMT_YUV422;
+ break;
+ case DRM_FORMAT_XBGR2101010:
+ tmp |= WD_PIX_FMT_XBGR2101010;
+ break;
+ case DRM_FORMAT_RGB565:
+ tmp |= WD_PIX_FMT_RGB565;
+ break;
+ }
+
+ if (intel_wd->triggered_cap_mode)
+ tmp |= WD_TRIGGERED_CAP_MODE_ENABLE;
+
+ if (intel_wd->stream_cap)
+ tmp |= WD_CTL_POINTER_DTDH;
+
+ /*select input pipe*/
+ tmp &= ~WD_INPUT_SELECT_MASK;
+ switch (pipe) {
+ default:
+ fallthrough;
+ case PIPE_A:
+ tmp |= WD_INPUT_PIPE_A;
+ break;
+ case PIPE_B:
+ tmp |= WD_INPUT_PIPE_B;
+ break;
+ case PIPE_C:
+ tmp |= WD_INPUT_PIPE_C;
+ break;
+ case PIPE_D:
+ tmp |= WD_INPUT_PIPE_D;
+ break;
+ }
+
+ /* enable DDI buffer */
+ if (!(tmp & TRANS_WD_FUNC_ENABLE))
+ tmp |= TRANS_WD_FUNC_ENABLE;
+
+ intel_de_write(dev_priv, WD_TRANS_FUNC_CTL(intel_wd->trans), tmp);
+
+ tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
+ ret = tmp & WD_TRANS_ACTIVE;
+ if (!ret) {
+ /*enable the transcoder */
+ tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
+ tmp |= WD_TRANS_ENABLE;
+ intel_de_write(dev_priv, PIPECONF(intel_wd->trans), tmp);
+
+ /* wait for transcoder to be enabled */
+ if (intel_de_wait_for_set(dev_priv, PIPECONF(intel_wd->trans),
+ WD_TRANS_ACTIVE, 10))
+ drm_err(&dev_priv->drm, "WD transcoder could not be enabled\n");
+ }
+
+ return 0;
+}
+
+static int intel_wd_capture(struct intel_wd *intel_wd,
+ struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state,
+ struct drm_writeback_job *job)
+{
+ u32 tmp;
+ struct drm_i915_private *i915 = to_i915(intel_wd->base.base.dev);
+ int ret = 0, status = 0;
+ struct intel_crtc *wd_crtc = intel_wd->wd_crtc;
+ unsigned long flags;
+
+ if (!job->out_fence)
+ drm_dbg_kms(&i915->drm, "Not able to get out_fence for job\n");
+
+ ret = intel_wd_setup_transcoder(intel_wd, pipe_config,
+ conn_state, job);
+
+ if (ret < 0) {
+ drm_dbg_kms(&i915->drm,
+ "WD transcoder setup not completed aborting capture\n");
+ return -1;
+ }
+
+ if (!wd_crtc) {
+ drm_err(&i915->drm, "CRTC not attached\n");
+ return -1;
+ }
+
+ tmp = intel_de_read_fw(i915,
+ WD_TRANS_FUNC_CTL(intel_wd->trans));
+ tmp |= START_TRIGGER_FRAME;
+ tmp &= ~WD_FRAME_NUMBER_MASK;
+ tmp |= intel_wd->frame_num;
+ intel_de_write_fw(i915,
+ WD_TRANS_FUNC_CTL(intel_wd->trans), tmp);
+
+ if (!intel_de_wait_for_set(i915, WD_IIR(intel_wd->trans),
+ WD_FRAME_COMPLETE_INT, 100)){
+ drm_dbg_kms(&i915->drm, "frame captured\n");
+ status = 0;
+ } else {
+ drm_dbg_kms(&i915->drm, "frame not captured triggering stop frame\n");
+ tmp = intel_de_read(i915,
+ WD_TRANS_FUNC_CTL(intel_wd->trans));
+ tmp |= STOP_TRIGGER_FRAME;
+ intel_de_write(i915,
+ WD_TRANS_FUNC_CTL(intel_wd->trans), tmp);
+ status = -1;
+ }
+
+ intel_wd_writeback_complete(intel_wd, job, status);
+ if (wd_crtc->wd.e) {
+ spin_lock_irqsave(&i915->drm.event_lock, flags);
+ drm_dbg_kms(&i915->drm, "send %p\n", wd_crtc->wd.e);
+ drm_crtc_send_vblank_event(&wd_crtc->base,
+ wd_crtc->wd.e);
+ spin_unlock_irqrestore(&i915->drm.event_lock, flags);
+ wd_crtc->wd.e = NULL;
+ } else {
+ drm_err(&i915->drm, "Event NULL! %p, %p\n", &i915->drm,
+ wd_crtc);
+ }
+ if (!intel_get_writeback_job_from_queue(intel_wd))
+ intel_wd_disable_capture(intel_wd);
+ return 0;
+}
+
+void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state)
+{
+ struct drm_i915_private *i915 =
+ to_i915(conn_state->connector->dev);
+ struct drm_writeback_connector *wb_conn =
+ drm_connector_to_writeback(conn_state->connector);
+ struct intel_wd *intel_wd = wb_conn_to_intel_wd(wb_conn);
+ struct drm_writeback_job *job;
+
+ job = intel_get_writeback_job_from_queue(intel_wd);
+ if (!job) {
+ drm_dbg_kms(&i915->drm,
+ "job queue is empty not capturing any frame\n");
+ return;
+ }
+
+ intel_wd_capture(intel_wd, pipe_config,
+ conn_state, job);
+ intel_wd->frame_num += 1;
+}
+
+void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *intel_crtc,
+ struct intel_crtc_state *intel_crtc_state)
+{
+ struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+ struct drm_crtc_state *crtc_state = &intel_crtc_state->uapi;
+ struct intel_encoder *encoder;
+ struct intel_wd *intel_wd;
+ struct drm_connector_state *conn_state;
+ struct drm_connector *connector;
+ int i;
+
+ for_each_intel_encoder(&i915->drm, encoder) {
+ if (encoder->type != INTEL_OUTPUT_WD)
+ continue;
+
+ intel_wd = enc_to_intel_wd(encoder);
+ if (!intel_wd->wd_crtc)
+ return;
+ }
+
+ if (intel_wd && intel_crtc == intel_wd->wd_crtc) {
+ for_each_new_connector_in_state(&state->base, connector, conn_state,
+ i) {
+ if (!conn_state->writeback_job)
+ continue;
+
+ intel_crtc->wd.e = crtc_state->event;
+ crtc_state->event = NULL;
+ }
+ }
+}
+
+void intel_wd_handle_isr(struct drm_i915_private *i915)
+{
+ u32 iir_value = 0;
+ struct intel_encoder *encoder;
+ struct intel_wd *intel_wd;
+
+ iir_value = intel_de_read(i915, WD_IIR(TRANSCODER_WD_0));
+
+ for_each_intel_encoder(&i915->drm, encoder) {
+
+ if (encoder->type != INTEL_OUTPUT_WD)
+ continue;
+
+ intel_wd = enc_to_intel_wd(encoder);
+ if (!intel_wd->wd_crtc) {
+ drm_err(&i915->drm, "NO CRTC attached with WD\n");
+ goto clear_iir;
+ }
+ }
+
+ if (iir_value & WD_FRAME_COMPLETE_INT)
+ return;
+
+clear_iir:
+ intel_de_write(i915, WD_IIR(TRANSCODER_WD_0), iir_value);
+}
diff --git a/drivers/gpu/drm/i915/display/intel_wd.h b/drivers/gpu/drm/i915/display/intel_wd.h
new file mode 100644
index 000000000000..0fcd1a746593
--- /dev/null
+++ b/drivers/gpu/drm/i915/display/intel_wd.h
@@ -0,0 +1,48 @@
+/* SPDX-License-Identifier: MIT*/
+/*
+ * Copyright © 2022 Intel Corporation
+ */
+
+#ifndef _INTEL_WD_H
+#define _INTEL_WD_H
+
+#include <drm/drm_crtc.h>
+
+#include "intel_display_types.h"
+
+#define I915_MAX_WD_TANSCODERS 2
+
+struct intel_wd {
+ struct intel_encoder base;
+ struct drm_writeback_connector wb_conn;
+ struct intel_crtc *wd_crtc;
+ intel_wakeref_t io_wakeref[I915_MAX_WD_TANSCODERS];
+ enum transcoder trans;
+ struct i915_vma *vma;
+ unsigned long flags;
+ struct drm_writeback_job *job;
+ int triggered_cap_mode;
+ int frame_num;
+ bool stream_cap;
+ bool start_capture;
+ int slicing_strategy;
+};
+
+static inline struct intel_wd *enc_to_intel_wd(struct intel_encoder *encoder)
+{
+ return container_of(&encoder->base, struct intel_wd, base.base);
+}
+
+static inline struct intel_wd *wb_conn_to_intel_wd(struct drm_writeback_connector *wb_conn)
+{
+ return container_of(wb_conn, struct intel_wd, wb_conn);
+}
+
+void intel_wd_init(struct drm_i915_private *dev_priv, enum transcoder trans);
+void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state);
+void intel_wd_handle_isr(struct drm_i915_private *dev_priv);
+void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *crtc,
+ struct intel_crtc_state *crtc_state);
+struct drm_writeback_job *intel_get_writeback_job_from_queue(struct intel_wd *intel_wd);
+#endif/* _INTEL_WD_H */
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 086bbe8945d6..73ef94757fc8 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -35,6 +35,7 @@
#include <linux/pm_qos.h>
#include <drm/drm_connector.h>
+#include <drm/drm_writeback.h>
#include <drm/ttm/ttm_device.h>
#include "display/intel_cdclk.h"
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 0389f532d926..6504ef528d90 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -42,6 +42,7 @@
#include "display/intel_hotplug.h"
#include "display/intel_lpe_audio.h"
#include "display/intel_psr.h"
+#include "display/intel_wd.h"
#include "gt/intel_breadcrumbs.h"
#include "gt/intel_gt.h"
@@ -2342,6 +2343,11 @@ gen8_de_misc_irq_handler(struct drm_i915_private *dev_priv, u32 iir)
found = true;
}
+ if (iir & GEN8_DE_MISC_WD0) {
+ intel_wd_handle_isr(dev_priv);
+ found = true;
+ }
+
if (iir & GEN8_DE_EDP_PSR) {
struct intel_encoder *encoder;
u32 psr_iir;
@@ -3767,7 +3773,7 @@ static void gen8_de_irq_postinstall(struct drm_i915_private *dev_priv)
u32 de_pipe_enables;
u32 de_port_masked = gen8_de_port_aux_mask(dev_priv);
u32 de_port_enables;
- u32 de_misc_masked = GEN8_DE_EDP_PSR;
+ u32 de_misc_masked = GEN8_DE_EDP_PSR | GEN8_DE_MISC_WD0;
u32 trans_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
BIT(TRANSCODER_C) | BIT(TRANSCODER_D);
enum pipe pipe;
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index aacc10f2e73f..636ce7819021 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -864,7 +864,8 @@ static const struct intel_device_info jsl_info = {
.display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), \
.display.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | \
BIT(TRANSCODER_C) | BIT(TRANSCODER_D) | \
- BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1), \
+ BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1) | \
+ BIT(TRANSCODER_WD_0), \
.display.pipe_offsets = { \
[TRANSCODER_A] = PIPE_A_OFFSET, \
[TRANSCODER_B] = PIPE_B_OFFSET, \
@@ -872,6 +873,8 @@ static const struct intel_device_info jsl_info = {
[TRANSCODER_D] = PIPE_D_OFFSET, \
[TRANSCODER_DSI_0] = PIPE_DSI0_OFFSET, \
[TRANSCODER_DSI_1] = PIPE_DSI1_OFFSET, \
+ [TRANSCODER_WD_0] = PIPE_WD0_OFFSET, \
+ [TRANSCODER_WD_1] = PIPE_WD1_OFFSET, \
}, \
.display.trans_offsets = { \
[TRANSCODER_A] = TRANSCODER_A_OFFSET, \
@@ -880,6 +883,8 @@ static const struct intel_device_info jsl_info = {
[TRANSCODER_D] = TRANSCODER_D_OFFSET, \
[TRANSCODER_DSI_0] = TRANSCODER_DSI0_OFFSET, \
[TRANSCODER_DSI_1] = TRANSCODER_DSI1_OFFSET, \
+ [TRANSCODER_WD_0] = TRANSCODER_WD0_OFFSET, \
+ [TRANSCODER_WD_1] = TRANSCODER_WD1_OFFSET, \
}, \
TGL_CURSOR_OFFSETS, \
.has_global_mocs = 1, \
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev2)
2022-08-22 8:16 [Intel-gfx] [PATCH v2 0/3] Enable Pipewriteback Kandpal, Suraj
` (2 preceding siblings ...)
2022-08-22 8:16 ` [Intel-gfx] [PATCH v2 3/3] drm/i915: Enabling WD Transcoder Kandpal, Suraj
@ 2022-08-24 22:15 ` Patchwork
2022-08-24 22:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-26 17:51 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
5 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2022-08-24 22:15 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
== Series Details ==
Series: Enable Pipewriteback (rev2)
URL : https://patchwork.freedesktop.org/series/107440/
State : warning
== Summary ==
Error: dim checkpatch failed
ce0a8c1d6693 drm/i915: Define WD trancoder for i915
-:68: CHECK:LINE_SPACING: Please don't use multiple blank lines
#68: FILE: drivers/gpu/drm/i915/i915_reg.h:3728:
+
+
total: 0 errors, 0 warnings, 1 checks, 194 lines checked
82521d22ee7c drm/i915 : Changing intel_connector iterators
-:56: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#56: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1506:
+#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \
+ NULL : container_of(x, struct intel_connector, base))
-:56: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues
#56: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1506:
+#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \
+ NULL : container_of(x, struct intel_connector, base))
-:84: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#84: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2092:
+
+ }
total: 0 errors, 0 warnings, 3 checks, 90 lines checked
f2bc651b51d6 drm/i915: Enabling WD Transcoder
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:125: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#125: FILE: drivers/gpu/drm/i915/display/intel_display.c:1559:
+static void intel_queue_writeback_job(struct intel_atomic_state *state,
+ struct intel_crtc *intel_crtc, struct intel_crtc_state *crtc_state)
-:143: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#143: FILE: drivers/gpu/drm/i915/display/intel_display.c:1577:
+static void intel_enable_writeback_capture(struct intel_atomic_state *state,
+ struct intel_crtc *intel_crtc, struct intel_crtc_state *crtc_state)
-:536: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#536:
new file mode 100644
-:557: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#557: FILE: drivers/gpu/drm/i915/display/intel_wb_connector.h:17:
+void intel_wb_connector_attach_encoder(struct intel_wb_connector *connector,
+ struct intel_encoder *encoder);
-:597: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#597: FILE: drivers/gpu/drm/i915/display/intel_wd.c:31:
+ job = list_first_entry_or_null(&wb_conn->job_queue,
+ struct drm_writeback_job,
-:600: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!job"
#600: FILE: drivers/gpu/drm/i915/display/intel_wd.c:34:
+ if (job == NULL) {
-:638: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#638: FILE: drivers/gpu/drm/i915/display/intel_wd.c:72:
+ DRM_ERROR("unsupported pixel format %x!\n",
+ pixel_format);
-:658: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#658: FILE: drivers/gpu/drm/i915/display/intel_wd.c:92:
+static u32 intel_wd_get_stride(const struct intel_crtc_state *crtc_state,
+ int format)
-:684: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#684: FILE: drivers/gpu/drm/i915/display/intel_wd.c:118:
+static int intel_wd_pin_fb(struct intel_wd *intel_wd,
+ struct drm_framebuffer *fb)
-:692: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#692: FILE: drivers/gpu/drm/i915/display/intel_wd.c:126:
+ vma = intel_pin_and_fence_fb_obj(fb, false, &view, false,
+ &intel_wd->flags);
-:702: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#702: FILE: drivers/gpu/drm/i915/display/intel_wd.c:136:
+static void intel_configure_slicing_strategy(struct drm_i915_private *dev_priv,
+ struct intel_wd *intel_wd, u32 *tmp)
-:715: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#715: FILE: drivers/gpu/drm/i915/display/intel_wd.c:149:
+ intel_de_write(dev_priv, WD_STREAMCAP_CTL(intel_wd->trans),
+ *tmp);
-:720: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#720: FILE: drivers/gpu/drm/i915/display/intel_wd.c:154:
+intel_wd_mode_valid(struct drm_connector *connector,
+ struct drm_display_mode *mode)
-:732: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#732: FILE: drivers/gpu/drm/i915/display/intel_wd.c:166:
+static void intel_wd_get_config(struct intel_encoder *encoder,
+ struct intel_crtc_state *pipe_config)
-:739: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#739: FILE: drivers/gpu/drm/i915/display/intel_wd.c:173:
+ memcpy(pipe_config, intel_crtc->config,
+ sizeof(*pipe_config));
-:745: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#745: FILE: drivers/gpu/drm/i915/display/intel_wd.c:179:
+static int intel_wd_compute_config(struct intel_encoder *encoder,
+ struct intel_crtc_state *pipe_config,
-:761: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#761: FILE: drivers/gpu/drm/i915/display/intel_wd.c:195:
+static void intel_wd_get_power_domains(struct intel_encoder *encoder,
+ struct intel_crtc_state *crtc_state)
-:768: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#768: FILE: drivers/gpu/drm/i915/display/intel_wd.c:202:
+ wakeref = intel_display_power_get(i915,
+ encoder->power_domain);
-:774: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#774: FILE: drivers/gpu/drm/i915/display/intel_wd.c:208:
+static bool intel_wd_get_hw_state(struct intel_encoder *encoder,
+ enum pipe *pipe)
-:787: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#787: FILE: drivers/gpu/drm/i915/display/intel_wd.c:221:
+ wakeref = intel_display_power_get_if_enabled(dev_priv,
+ encoder->power_domain);
-:805: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#805: FILE: drivers/gpu/drm/i915/display/intel_wd.c:239:
+static int intel_wd_encoder_atomic_check(struct drm_encoder *encoder,
+ struct drm_crtc_state *crtc_st,
-:828: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#828: FILE: drivers/gpu/drm/i915/display/intel_wd.c:262:
+ drm_dbg_kms(&i915->drm, "Invalid framebuffer size %ux%u\n",
+ fb->width, fb->height);
-:835: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#835: FILE: drivers/gpu/drm/i915/display/intel_wd.c:269:
+ drm_dbg_kms(&i915->drm, "Unsupported framebuffer format %08x\n",
+ fb->format->format);
-:842: CHECK:LINE_SPACING: Please don't use multiple blank lines
#842: FILE: drivers/gpu/drm/i915/display/intel_wd.c:276:
+
+
-:878: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#878: FILE: drivers/gpu/drm/i915/display/intel_wd.c:312:
+static bool intel_fastset_dis(struct intel_encoder *encoder,
+ struct intel_crtc_state *pipe_config)
-:934: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#934: FILE: drivers/gpu/drm/i915/display/intel_wd.c:368:
+ drm_encoder_helper_add(drm_enc,
+ &wd_encoder_helper_funcs);
-:943: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#943: FILE: drivers/gpu/drm/i915/display/intel_wd.c:377:
+ drm_dbg_kms(&i915->drm,
+ "Writeback drm_encoder init Failed: %d\n",
-:949: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#949: FILE: drivers/gpu/drm/i915/display/intel_wd.c:383:
+ err = drm_writeback_connector_init_with_encoder(&i915->drm,
+ wb_conn, drm_enc, &wd_connector_funcs,
-:954: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#954: FILE: drivers/gpu/drm/i915/display/intel_wd.c:388:
+ drm_dbg_kms(&i915->drm,
+ "drm_writeback_connector_init: Failed: %d\n",
-:967: WARNING:RETURN_VOID: void function return statements are not generally useful
#967: FILE: drivers/gpu/drm/i915/display/intel_wd.c:401:
+ return;
+}
-:970: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#970: FILE: drivers/gpu/drm/i915/display/intel_wd.c:404:
+static void intel_wd_writeback_complete(struct intel_wd *intel_wd,
+ struct drm_writeback_job *job, int status)
-:978: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#978: FILE: drivers/gpu/drm/i915/display/intel_wd.c:412:
+static int intel_wd_setup_transcoder(struct intel_wd *intel_wd,
+ struct intel_crtc_state *pipe_config,
-:1012: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1012: FILE: drivers/gpu/drm/i915/display/intel_wd.c:446:
+ intel_de_write(dev_priv, WD_SURF(intel_wd->trans),
+ i915_ggtt_offset(intel_wd->vma));
-:1023: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1023: FILE: drivers/gpu/drm/i915/display/intel_wd.c:457:
+ tmp = intel_de_read(dev_priv,
+ WD_STREAMCAP_CTL(intel_wd->trans));
-:1112: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1112: FILE: drivers/gpu/drm/i915/display/intel_wd.c:546:
+ if (intel_de_wait_for_set(dev_priv, PIPECONF(intel_wd->trans),
+ WD_TRANS_ACTIVE, 10))
-:1120: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1120: FILE: drivers/gpu/drm/i915/display/intel_wd.c:554:
+static int intel_wd_capture(struct intel_wd *intel_wd,
+ struct intel_crtc_state *pipe_config,
-:1134: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1134: FILE: drivers/gpu/drm/i915/display/intel_wd.c:568:
+ ret = intel_wd_setup_transcoder(intel_wd, pipe_config,
+ conn_state, job);
-:1138: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1138: FILE: drivers/gpu/drm/i915/display/intel_wd.c:572:
+ drm_dbg_kms(&i915->drm,
+ "WD transcoder setup not completed aborting capture\n");
-:1148: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1148: FILE: drivers/gpu/drm/i915/display/intel_wd.c:582:
+ tmp = intel_de_read_fw(i915,
+ WD_TRANS_FUNC_CTL(intel_wd->trans));
-:1153: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1153: FILE: drivers/gpu/drm/i915/display/intel_wd.c:587:
+ intel_de_write_fw(i915,
+ WD_TRANS_FUNC_CTL(intel_wd->trans), tmp);
-:1156: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1156: FILE: drivers/gpu/drm/i915/display/intel_wd.c:590:
+ if (!intel_de_wait_for_set(i915, WD_IIR(intel_wd->trans),
+ WD_FRAME_COMPLETE_INT, 100)){
-:1162: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1162: FILE: drivers/gpu/drm/i915/display/intel_wd.c:596:
+ tmp = intel_de_read(i915,
+ WD_TRANS_FUNC_CTL(intel_wd->trans));
-:1165: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1165: FILE: drivers/gpu/drm/i915/display/intel_wd.c:599:
+ intel_de_write(i915,
+ WD_TRANS_FUNC_CTL(intel_wd->trans), tmp);
-:1174: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1174: FILE: drivers/gpu/drm/i915/display/intel_wd.c:608:
+ drm_crtc_send_vblank_event(&wd_crtc->base,
+ wd_crtc->wd.e);
-:1187: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1187: FILE: drivers/gpu/drm/i915/display/intel_wd.c:621:
+void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state)
-:1199: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1199: FILE: drivers/gpu/drm/i915/display/intel_wd.c:633:
+ drm_dbg_kms(&i915->drm,
+ "job queue is empty not capturing any frame\n");
-:1204: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1204: FILE: drivers/gpu/drm/i915/display/intel_wd.c:638:
+ intel_wd_capture(intel_wd, pipe_config,
+ conn_state, job);
-:1209: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1209: FILE: drivers/gpu/drm/i915/display/intel_wd.c:643:
+void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *intel_crtc,
+ struct intel_crtc_state *intel_crtc_state)
-:1249: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#1249: FILE: drivers/gpu/drm/i915/display/intel_wd.c:683:
+ for_each_intel_encoder(&i915->drm, encoder) {
+
-:1314: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1314: FILE: drivers/gpu/drm/i915/display/intel_wd.h:43:
+void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state);
-:1317: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1317: FILE: drivers/gpu/drm/i915/display/intel_wd.h:46:
+void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *crtc,
+ struct intel_crtc_state *crtc_state);
total: 0 errors, 2 warnings, 49 checks, 1265 lines checked
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Enable Pipewriteback (rev2)
2022-08-22 8:16 [Intel-gfx] [PATCH v2 0/3] Enable Pipewriteback Kandpal, Suraj
` (3 preceding siblings ...)
2022-08-24 22:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev2) Patchwork
@ 2022-08-24 22:29 ` Patchwork
2022-08-26 17:51 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
5 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2022-08-24 22:29 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6205 bytes --]
== Series Details ==
Series: Enable Pipewriteback (rev2)
URL : https://patchwork.freedesktop.org/series/107440/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12022 -> Patchwork_107440v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/index.html
Participating hosts (37 -> 36)
------------------------------
Additional (2): bat-dg2-8 fi-tgl-dsi
Missing (3): fi-hsw-4770 bat-dg2-9 bat-jsl-3
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107440v2:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@core_hotunplug@unbind-rebind:
- {bat-dg2-10}: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/bat-dg2-10/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/bat-dg2-10/igt@core_hotunplug@unbind-rebind.html
Known issues
------------
Here are the changes found in Patchwork_107440v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [PASS][3] -> [DMESG-FAIL][4] ([i915#4528])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/fi-pnv-d510/igt@i915_selftest@live@requests.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@runner@aborted:
- fi-pnv-d510: NOTRUN -> [FAIL][5] ([fdo#109271] / [i915#2403] / [i915#4312])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/fi-pnv-d510/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- {fi-jsl-1}: [INCOMPLETE][6] ([i915#5134]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/fi-jsl-1/igt@i915_selftest@live@hangcheck.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/fi-jsl-1/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- {bat-rpls-1}: [INCOMPLETE][8] ([i915#6257] / [i915#6380]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/bat-rpls-1/igt@i915_selftest@live@requests.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [FAIL][10] ([i915#6298]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#5134]: https://gitlab.freedesktop.org/drm/intel/issues/5134
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6380]: https://gitlab.freedesktop.org/drm/intel/issues/6380
[i915#6523]: https://gitlab.freedesktop.org/drm/intel/issues/6523
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6642]: https://gitlab.freedesktop.org/drm/intel/issues/6642
Build changes
-------------
* Linux: CI_DRM_12022 -> Patchwork_107440v2
CI-20190529: 20190529
CI_DRM_12022: 7d700aafd2532afd10b5bd0d1fd76eb3a0d6610a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6636: 1298b5f0e1b3e010657ffba41d2e775fab028e08 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107440v2: 7d700aafd2532afd10b5bd0d1fd76eb3a0d6610a @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
25377aa8565c drm/i915: Enabling WD Transcoder
75102ee116ce drm/i915 : Changing intel_connector iterators
2574f519f0eb drm/i915: Define WD trancoder for i915
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/index.html
[-- Attachment #2: Type: text/html, Size: 5207 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for Enable Pipewriteback (rev2)
2022-08-22 8:16 [Intel-gfx] [PATCH v2 0/3] Enable Pipewriteback Kandpal, Suraj
` (4 preceding siblings ...)
2022-08-24 22:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-08-26 17:51 ` Patchwork
5 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2022-08-26 17:51 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 38521 bytes --]
== Series Details ==
Series: Enable Pipewriteback (rev2)
URL : https://patchwork.freedesktop.org/series/107440/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12022_full -> Patchwork_107440v2_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_107440v2_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_107440v2_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (12 -> 12)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107440v2_full:
### IGT changes ###
#### Possible regressions ####
* igt@device_reset@unbind-reset-rebind:
- shard-tglb: [PASS][1] -> [DMESG-WARN][2] +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-tglb3/igt@device_reset@unbind-reset-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@device_reset@unbind-reset-rebind.html
* igt@kms_atomic_transition@modeset-transition-nonblocking@1x-outputs:
- shard-tglb: [PASS][3] -> [INCOMPLETE][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-tglb3/igt@kms_atomic_transition@modeset-transition-nonblocking@1x-outputs.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb8/igt@kms_atomic_transition@modeset-transition-nonblocking@1x-outputs.html
#### Warnings ####
* igt@kms_writeback@writeback-check-output:
- shard-tglb: [SKIP][5] ([i915#2437]) -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-tglb6/igt@kms_writeback@writeback-check-output.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb1/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-fb-id:
- shard-tglb: [SKIP][7] ([i915#2437]) -> [FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-tglb5/igt@kms_writeback@writeback-fb-id.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb7/igt@kms_writeback@writeback-fb-id.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@device_reset@unbind-reset-rebind:
- {shard-tglu}: NOTRUN -> [DMESG-WARN][9] +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglu-4/igt@device_reset@unbind-reset-rebind.html
* igt@kms_prime@basic-crc-vgem@second-to-first:
- {shard-tglu}: [PASS][10] -> [FAIL][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-tglu-4/igt@kms_prime@basic-crc-vgem@second-to-first.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglu-4/igt@kms_prime@basic-crc-vgem@second-to-first.html
* igt@kms_writeback@writeback-check-output:
- {shard-tglu}: NOTRUN -> [DMESG-FAIL][12]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglu-4/igt@kms_writeback@writeback-check-output.html
Known issues
------------
Here are the changes found in Patchwork_107440v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [PASS][13] -> [SKIP][14] ([i915#4525]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-iclb2/igt@gem_exec_balancer@parallel-bb-first.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb7/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][15] -> [FAIL][16] ([i915#2846])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-kbl1/igt@gem_exec_fair@basic-deadline.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl7/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][17] -> [FAIL][18] ([i915#2842]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-tglb5/igt@gem_exec_fair@basic-flow@rcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][19] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb2/igt@gem_exec_fair@basic-none@vcs1.html
* igt@gem_lmem_swapping@heavy-verify-random-ccs:
- shard-tglb: NOTRUN -> [SKIP][20] ([i915#4613]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@gem_lmem_swapping@heavy-verify-random-ccs.html
* igt@gem_lmem_swapping@parallel-random-verify:
- shard-glk: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-glk9/igt@gem_lmem_swapping@parallel-random-verify.html
* igt@gem_lmem_swapping@verify-ccs:
- shard-kbl: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#4613])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl1/igt@gem_lmem_swapping@verify-ccs.html
* igt@gem_pxp@reject-modify-context-protection-off-2:
- shard-tglb: NOTRUN -> [SKIP][23] ([i915#4270])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@gem_pxp@reject-modify-context-protection-off-2.html
* igt@gem_softpin@evict-single-offset:
- shard-iclb: [PASS][24] -> [FAIL][25] ([i915#4171])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-iclb6/igt@gem_softpin@evict-single-offset.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb6/igt@gem_softpin@evict-single-offset.html
* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][26] ([i915#454])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl1/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [PASS][27] -> [SKIP][28] ([i915#4281])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-iclb7/igt@i915_pm_dc@dc9-dpms.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_query@test-query-geometry-subslices:
- shard-tglb: NOTRUN -> [SKIP][29] ([i915#5723])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@i915_query@test-query-geometry-subslices.html
* igt@i915_selftest@mock@sanitycheck:
- shard-tglb: [PASS][30] -> [SKIP][31] ([i915#3555]) +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-tglb5/igt@i915_selftest@mock@sanitycheck.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb5/igt@i915_selftest@mock@sanitycheck.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-tglb: NOTRUN -> [SKIP][32] ([i915#5286]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-16bpp-rotate-0:
- shard-apl: [PASS][33] -> [DMESG-WARN][34] ([i915#5904] / [i915#62]) +11 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-apl6/igt@kms_big_fb@y-tiled-16bpp-rotate-0.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-apl2/igt@kms_big_fb@y-tiled-16bpp-rotate-0.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][35] ([fdo#111614])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_big_fb@y-tiled-64bpp-rotate-90.html
* igt@kms_big_fb@yf-tiled-addfb-size-offset-overflow:
- shard-tglb: NOTRUN -> [SKIP][36] ([fdo#111615]) +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_big_fb@yf-tiled-addfb-size-offset-overflow.html
* igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][37] ([i915#3689] / [i915#6095]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-basic-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][38] ([i915#6095])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_ccs@pipe-b-crc-primary-basic-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3886]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl4/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][40] ([i915#3689] / [i915#3886])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-rotation-90-4_tiled_dg2_rc_ccs_cc:
- shard-tglb: NOTRUN -> [SKIP][41] ([i915#3689])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_ccs@pipe-d-bad-rotation-90-4_tiled_dg2_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#111615] / [i915#3689])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs.html
* igt@kms_cdclk@mode-transition-all-outputs:
- shard-tglb: NOTRUN -> [SKIP][43] ([i915#3742])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_cdclk@mode-transition-all-outputs.html
* igt@kms_chamelium@dp-audio-edid:
- shard-snb: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-snb2/igt@kms_chamelium@dp-audio-edid.html
* igt@kms_chamelium@dp-hpd-enable-disable-mode:
- shard-kbl: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl4/igt@kms_chamelium@dp-hpd-enable-disable-mode.html
* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-tglb: NOTRUN -> [SKIP][46] ([fdo#109284] / [fdo#111827]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_chamelium@vga-hpd-after-suspend.html
* igt@kms_chamelium@vga-hpd-enable-disable-mode:
- shard-glk: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-glk9/igt@kms_chamelium@vga-hpd-enable-disable-mode.html
* igt@kms_content_protection@atomic:
- shard-kbl: NOTRUN -> [TIMEOUT][48] ([i915#1319] / [i915#6637])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl1/igt@kms_content_protection@atomic.html
* igt@kms_cursor_crc@cursor-random@pipe-b-dp-1-64x21:
- shard-apl: [PASS][49] -> [DMESG-WARN][50] ([i915#180] / [i915#5904] / [i915#62]) +38 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-apl6/igt@kms_cursor_crc@cursor-random@pipe-b-dp-1-64x21.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-apl2/igt@kms_cursor_crc@cursor-random@pipe-b-dp-1-64x21.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-kbl: NOTRUN -> [SKIP][51] ([fdo#109271]) +70 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled:
- shard-apl: [PASS][52] -> [DMESG-FAIL][53] ([i915#62]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-apl1/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-apl2/igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-xtiled.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-4tiled:
- shard-tglb: NOTRUN -> [SKIP][54] ([i915#5287])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-4tiled.html
* igt@kms_flip@2x-plain-flip-fb-recreate:
- shard-tglb: NOTRUN -> [SKIP][55] ([fdo#109274] / [fdo#111825] / [i915#3637])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_flip@2x-plain-flip-fb-recreate.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: [PASS][56] -> [FAIL][57] ([i915#2122])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-kbl: [PASS][58] -> [DMESG-WARN][59] ([i915#180]) +8 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-kbl4/igt@kms_flip@flip-vs-suspend@a-dp1.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl1/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][60] -> [SKIP][61] ([i915#3555])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][62] ([i915#2672]) +5 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][63] ([i915#2672] / [i915#3555])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff:
- shard-tglb: NOTRUN -> [SKIP][64] ([fdo#109280] / [fdo#111825]) +6 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- shard-apl: [PASS][65] -> [DMESG-WARN][66] ([i915#62]) +12 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-apl1/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-apl2/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][67] ([i915#6497]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt:
- shard-glk: NOTRUN -> [SKIP][68] ([fdo#109271]) +44 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-glk9/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render:
- shard-snb: NOTRUN -> [SKIP][69] ([fdo#109271]) +13 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-snb2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#3555])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][71] ([fdo#108145] / [i915#265])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl1/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_lowres@tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][72] ([fdo#112054])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_plane_lowres@tiling-yf.html
* igt@kms_plane_multiple@atomic-pipe-d-tiling-4:
- shard-tglb: NOTRUN -> [SKIP][73] ([i915#5288])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_plane_multiple@atomic-pipe-d-tiling-4.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1:
- shard-iclb: [PASS][74] -> [SKIP][75] ([i915#5235]) +2 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-iclb3/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#2920])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-kbl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#658])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl1/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [PASS][78] -> [SKIP][79] ([fdo#109441]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_psr@psr2_suspend:
- shard-tglb: NOTRUN -> [FAIL][80] ([i915#132] / [i915#3467]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@kms_psr@psr2_suspend.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglb: [PASS][81] -> [SKIP][82] ([i915#5519])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-tglb6/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb7/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
* igt@prime_nv_pcopy@test3_5:
- shard-tglb: NOTRUN -> [SKIP][83] ([fdo#109291])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@prime_nv_pcopy@test3_5.html
* igt@sysfs_clients@fair-7:
- shard-glk: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2994])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-glk9/igt@sysfs_clients@fair-7.html
* igt@sysfs_clients@split-10:
- shard-kbl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#2994])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl4/igt@sysfs_clients@split-10.html
* igt@sysfs_clients@split-50:
- shard-tglb: NOTRUN -> [SKIP][86] ([i915#2994])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@sysfs_clients@split-50.html
#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- shard-tglb: [FAIL][87] ([i915#5784]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-tglb8/igt@gem_eio@unwedge-stress.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][89] ([i915#4525]) -> [PASS][90] +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-iclb5/igt@gem_exec_balancer@parallel-keep-in-fence.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb1/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][91] ([i915#2842]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-apl8/igt@gem_exec_fair@basic-none-solo@rcs0.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-apl8/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: [FAIL][93] ([i915#2842]) -> [PASS][94] +3 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-kbl7/igt@gem_exec_fair@basic-none@vecs0.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl4/igt@gem_exec_fair@basic-none@vecs0.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][95] ([i915#3921]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-snb4/igt@i915_selftest@live@hangcheck.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-snb2/igt@i915_selftest@live@hangcheck.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [FAIL][97] ([i915#2346]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][99] ([i915#2122]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-glk6/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-glk2/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-kbl: [DMESG-WARN][101] ([i915#180]) -> [PASS][102] +4 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][103] ([fdo#109441]) -> [PASS][104] +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-iclb3/igt@kms_psr@psr2_cursor_blt.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-tglb: [SKIP][105] ([i915#2437]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-tglb2/igt@kms_writeback@writeback-pixel-formats.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb8/igt@kms_writeback@writeback-pixel-formats.html
- {shard-tglu}: [SKIP][107] ([i915#2437]) -> [PASS][108] +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-tglu-2/igt@kms_writeback@writeback-pixel-formats.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglu-2/igt@kms_writeback@writeback-pixel-formats.html
#### Warnings ####
* igt@kms_content_protection@uevent:
- shard-apl: [FAIL][109] ([i915#2105]) -> [SKIP][110] ([fdo#109271])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-apl1/igt@kms_content_protection@uevent.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-apl2/igt@kms_content_protection@uevent.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [FAIL][111] ([i915#4767]) -> [INCOMPLETE][112] ([i915#180] / [i915#4939] / [i915#6598])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-valid-mode:
- shard-glk: [SKIP][113] ([fdo#109271]) -> [SKIP][114] ([fdo#109271] / [i915#1888])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-glk5/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-valid-mode.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-valid-mode.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][115] ([i915#2920]) -> [SKIP][116] ([i915#658])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb5/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][117] ([i915#658]) -> [SKIP][118] ([i915#2920])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-iclb3/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][119] ([i915#2920]) -> [SKIP][120] ([fdo#111068] / [i915#658])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-p010:
- shard-iclb: [SKIP][121] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][122] ([i915#5939])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-iclb3/igt@kms_psr2_su@page_flip-p010.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-iclb2/igt@kms_psr2_su@page_flip-p010.html
* igt@runner@aborted:
- shard-tglb: ([FAIL][123], [FAIL][124]) ([i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132]) ([i915#1759] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-tglb6/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-tglb7/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb5/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb7/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb5/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb7/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb5/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb2/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-tglb6/igt@runner@aborted.html
- shard-kbl: ([FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-kbl7/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-kbl7/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-kbl7/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-kbl7/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-kbl7/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-kbl7/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-kbl1/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12022/shard-kbl1/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl7/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl7/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl7/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl7/igt@runner@aborted.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl7/igt@runner@aborted.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl1/igt@runner@aborted.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl1/igt@runner@aborted.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl1/igt@runner@aborted.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl1/igt@runner@aborted.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/shard-kbl1/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#6637]: https://gitlab.freedesktop.org/drm/intel/issues/6637
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* Linux: CI_DRM_12022 -> Patchwork_107440v2
CI-20190529: 20190529
CI_DRM_12022: 7d700aafd2532afd10b5bd0d1fd76eb3a0d6610a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6636: 1298b5f0e1b3e010657ffba41d2e775fab028e08 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107440v2: 7d700aafd2532afd10b5bd0d1fd76eb3a0d6610a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v2/index.html
[-- Attachment #2: Type: text/html, Size: 44252 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Define WD trancoder for i915
2022-08-22 8:16 ` [Intel-gfx] [PATCH v2 1/3] drm/i915: Define WD trancoder for i915 Kandpal, Suraj
@ 2022-09-09 8:57 ` Murthy, Arun R
2022-09-09 9:01 ` Jani Nikula
0 siblings, 1 reply; 13+ messages in thread
From: Murthy, Arun R @ 2022-09-09 8:57 UTC (permalink / raw)
To: Kandpal, Suraj, intel-gfx; +Cc: Nikula, Jani
> From: Suraj Kandpal <suraj.kandpal@intel.com>
>
> Adding WD Types, WD transcoder to enum list and WD Transcoder offsets.
> Adding i915 register definitions related to WD transcoder
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.h | 6 +
> .../drm/i915/display/intel_display_types.h | 1 +
> drivers/gpu/drm/i915/i915_reg.h | 139 ++++++++++++++++++
> 3 files changed, 146 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.h
> b/drivers/gpu/drm/i915/display/intel_display.h
> index fa5371036239..4e9f22954a41 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.h
> +++ b/drivers/gpu/drm/i915/display/intel_display.h
> @@ -120,6 +120,8 @@ enum transcoder {
> TRANSCODER_DSI_1,
> TRANSCODER_DSI_A = TRANSCODER_DSI_0, /* legacy DSI */
> TRANSCODER_DSI_C = TRANSCODER_DSI_1, /* legacy DSI */
> + TRANSCODER_WD_0,
> + TRANSCODER_WD_1,
>
> I915_MAX_TRANSCODERS
> };
> @@ -141,6 +143,10 @@ static inline const char *transcoder_name(enum
> transcoder transcoder)
> return "DSI A";
> case TRANSCODER_DSI_C:
> return "DSI C";
> + case TRANSCODER_WD_0:
> + return "WD 0";
> + case TRANSCODER_WD_1:
> + return "WD 1";
> default:
> return "<invalid>";
> }
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
> b/drivers/gpu/drm/i915/display/intel_display_types.h
> index 0da9b208d56e..0e94bd430bcb 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -79,6 +79,7 @@ enum intel_output_type {
> INTEL_OUTPUT_DSI = 9,
> INTEL_OUTPUT_DDI = 10,
> INTEL_OUTPUT_DP_MST = 11,
> + INTEL_OUTPUT_WD = 12,
> };
>
> enum hdmi_force_audio {
> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> b/drivers/gpu/drm/i915/i915_reg.h index bf5c39d9f953..e3fced4b9980
> 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -2059,6 +2059,8 @@
> #define TRANSCODER_EDP_OFFSET 0x6f000
> #define TRANSCODER_DSI0_OFFSET 0x6b000
> #define TRANSCODER_DSI1_OFFSET 0x6b800
> +#define TRANSCODER_WD0_OFFSET 0x6e000
> +#define TRANSCODER_WD1_OFFSET 0x6e800
>
> #define HTOTAL(trans) _MMIO_TRANS2(trans, _HTOTAL_A)
> #define HBLANK(trans) _MMIO_TRANS2(trans, _HBLANK_A)
> @@ -3831,6 +3833,11 @@
> #define PIPE_DSI0_OFFSET 0x7b000
> #define PIPE_DSI1_OFFSET 0x7b800
>
> +/* WD 0 and 1 */
Can this be changed to
/* WD offset */
> +#define PIPE_WD0_OFFSET 0x7e000
> +#define PIPE_WD1_OFFSET 0x7d000
> +
> +
> #define PIPECONF(pipe) _MMIO_PIPE2(pipe, _PIPEACONF)
> #define PIPEDSL(pipe) _MMIO_PIPE2(pipe, _PIPEADSL)
> #define PIPEFRAME(pipe) _MMIO_PIPE2(pipe,
> _PIPEAFRAMEHIGH)
> @@ -4495,6 +4502,10 @@
> #define _PIPEDSI0CONF 0x7b008
> #define _PIPEDSI1CONF 0x7b808
>
> +/* WD 0 and 1 */
Can this be changed to
/* WD config regs */
> +#define _PIPEWD0CONF 0x7e008
> +#define _PIPEWD1CONF 0x7d008
> +
> /* Sprite A control */
> #define _DVSACNTR 0x72180
> #define DVS_ENABLE REG_BIT(31)
> @@ -5720,6 +5731,7 @@
> #define GEN8_DE_MISC_IER _MMIO(0x4446c)
> #define GEN8_DE_MISC_GSE (1 << 27)
> #define GEN8_DE_EDP_PSR (1 << 19)
> +#define GEN8_DE_MISC_WD0 (1 << 23)
>
> #define GEN8_PCU_ISR _MMIO(0x444e0)
> #define GEN8_PCU_IMR _MMIO(0x444e4)
> @@ -8714,6 +8726,133 @@ enum skl_power_gate {
> #define DSB_ENABLE (1 << 31)
> #define DSB_STATUS (1 << 0)
>
> +#define TGL_ROOT_DEVICE_ID 0x9A00
> +#define TGL_ROOT_DEVICE_MASK 0xFF00
> +#define TGL_ROOT_DEVICE_SKU_MASK 0xF
> +#define TGL_ROOT_DEVICE_SKU_ULX 0x2
> +#define TGL_ROOT_DEVICE_SKU_ULT 0x4
> +
> +/* Gen12 WD */
> +#define _MMIO_WD(tc, wd0, wd1) _MMIO_TRANS((tc) -
> TRANSCODER_WD_0, \
> + wd0, wd1)
> +
> +#define WD_TRANS_ENABLE (1 << 31)
> +#define WD_TRANS_DISABLE 0
> +#define WD_TRANS_ACTIVE (1 << 30)
> +
> +/* WD transcoder control */
> +#define _WD_TRANS_FUNC_CTL_0 0x6e400
> +#define _WD_TRANS_FUNC_CTL_1 0x6ec00
> +#define WD_TRANS_FUNC_CTL(tc) _MMIO_WD(tc,\
> + _WD_TRANS_FUNC_CTL_0,\
> + _WD_TRANS_FUNC_CTL_1)
> +
> +#define TRANS_WD_FUNC_ENABLE (1 << 31)
> +#define WD_TRIGGERED_CAP_MODE_ENABLE (1 << 30)
> +#define START_TRIGGER_FRAME (1 << 29)
> +#define STOP_TRIGGER_FRAME (1 << 28)
> +#define WD_CTL_POINTER_ETEH (0 << 18)
> +#define WD_CTL_POINTER_ETDH (1 << 18)
> +#define WD_CTL_POINTER_DTDH (2 << 18)
> +#define WD_INPUT_SELECT_MASK (7 << 12)
> +#define WD_INPUT_PIPE_A (0 << 12)
> +#define WD_INPUT_PIPE_B (5 << 12)
> +#define WD_INPUT_PIPE_C (6 << 12)
> +#define WD_INPUT_PIPE_D (7 << 12)
> +
> +#define WD_PIX_FMT_MASK (0x3 << 20)
> +#define WD_PIX_FMT_YUYV (0x1 << 20)
> +#define WD_PIX_FMT_XYUV8888 (0x2 << 20)
> +#define WD_PIX_FMT_XBGR8888 (0x3 << 20)
> +#define WD_PIX_FMT_Y410 (0x4 << 20)
> +#define WD_PIX_FMT_YUV422 (0x5 << 20)
> +#define WD_PIX_FMT_XBGR2101010 (0x6 << 20)
> +#define WD_PIX_FMT_RGB565 (0x7 << 20)
> +
> +#define WD_FRAME_NUMBER_MASK 15
> +
> +#define _WD_STRIDE_0 0x6e510
> +#define _WD_STRIDE_1 0x6ed10
> +#define WD_STRIDE(tc) _MMIO_WD(tc,\
> + _WD_STRIDE_0,\
> + _WD_STRIDE_1)
> +#define WD_STRIDE_SHIFT 6
> +#define WD_STRIDE_MASK (0x3ff << WD_STRIDE_SHIFT)
> +
> +#define _WD_STREAMCAP_CTL0 0x6e590
> +#define _WD_STREAMCAP_CTL1 0x6ed90
> +#define WD_STREAMCAP_CTL(tc) _MMIO_WD(tc,\
> + _WD_STREAMCAP_CTL0,\
> + _WD_STREAMCAP_CTL1)
> +
> +#define WD_STREAM_CAP_MODE_EN (1 << 31)
> +#define WD_STRAT_MASK (3 << 24)
> +#define WD_SLICING_STRAT_1_1 (0 << 24)
> +#define WD_SLICING_STRAT_2_1 (1 << 24)
> +#define WD_SLICING_STRAT_4_1 (2 << 24)
> +#define WD_SLICING_STRAT_8_1 (3 << 24)
> +#define WD_STREAM_OVERRUN_STATUS 1
> +
> +#define _WD_SURF_0 0x6e514
> +#define _WD_SURF_1 0x6ed14
> +#define WD_SURF(tc) _MMIO_WD(tc,\
> + _WD_SURF_0,\
> + _WD_SURF_1)
> +
> +#define _WD_IMR_0 0x6e560
> +#define _WD_IMR_1 0x6ed60
> +#define WD_IMR(tc) _MMIO_WD(tc,\
> + _WD_IMR_0,\
> + _WD_IMR_1)
> +#define WD_FRAME_COMPLETE_INT (1 << 7)
> +#define WD_GTT_FAULT_INT (1 << 6)
> +#define WD_VBLANK_INT (1 << 5)
> +#define WD_OVERRUN_INT (1 << 4)
> +#define WD_CAPTURING_INT (1 << 3)
> +#define WD_WRITE_COMPLETE_INT (1 << 2)
> +
> +#define _WD_IIR_0 0x6e564
> +#define _WD_IIR_1 0x6ed64
> +#define WD_IIR(tc) _MMIO_WD(tc,\
> + _WD_IIR_0,\
> + _WD_IIR_1)
> +
> +#define _WD_FRAME_STATUS_0 0x6e56b
> +#define _WD_FRAME_STATUS_1 0x6ed6b
> +#define WD_FRAME_STATUS(tc) _MMIO_WD(tc,\
> + _WD_FRAME_STATUS_0,\
> + _WD_FRAME_STATUS_1)
> +
> +#define WD_FRAME_COMPLETE (1 << 31)
> +#define WD_STATE_IDLE (0 << 24)
> +#define WD_STATE_CAPSTART (1 << 24)
> +#define WD_STATE_FRAME_START (2 << 24)
> +#define WD_STATE_CAPACITIVE (3 << 24)
> +#define WD_STATE_TG_DONE (4 << 24)
> +#define WD_STATE_WDX_DONE (5 << 24)
> +#define WD_STATE_QUICK_CAP (6 << 24)
> +
> +#define _WD_27_M_0 0x6e524
> +#define _WD_27_M_1 0x6ed24
> +#define WD_27_M(tc) _MMIO_WD(tc,\
> + _WD_27_M_0,\
> + _WD_27_M_1)
> +
> +#define _WD_27_N_0 0x6e528
> +
> +//Address looks wrong in bspec:
> +#define _WD_27_N_1 0x6ec28
> +#define WD_27_N(tc) _MMIO_WD(tc,\
> + _WD_27_N_0,\
> + _WD_27_N_1)
> +
> +#define _WD_TAIL_CFG_0 0x6e520
> +#define _WD_TAIL_CFG_1 0x6ed20
> +
> +#define WD_TAIL_CFG(tc) _MMIO_WD(tc,\
> + _WD_TAIL_CFG_0,\
> + _WD_TAIL_CFG_1)
> +
> #define CLKREQ_POLICY _MMIO(0x101038)
> #define CLKREQ_POLICY_MEM_UP_OVRD REG_BIT(1)
>
With the above said changes
Reviewed-by: Arun R Murthy <arun.r.murthy>
Thanks and Regards,
Arun R Murthy
--------------------
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH v2 2/3] drm/i915 : Changing intel_connector iterators
2022-08-22 8:16 ` [Intel-gfx] [PATCH v2 2/3] drm/i915 : Changing intel_connector iterators Kandpal, Suraj
@ 2022-09-09 8:58 ` Murthy, Arun R
0 siblings, 0 replies; 13+ messages in thread
From: Murthy, Arun R @ 2022-09-09 8:58 UTC (permalink / raw)
To: Kandpal, Suraj, intel-gfx; +Cc: Nikula, Jani
> From: Suraj Kandpal <suraj.kandpal@intel.com>
>
> Changing intel_connector iterators as with writeback introduction not all
> drm_connector will be embedded within intel_connector.
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.h | 7 ++---
> .../drm/i915/display/intel_display_types.h | 26 ++++++++++++++++++-
> .../drm/i915/display/intel_modeset_setup.c | 16 +++++++++---
> 3 files changed, 40 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.h
> b/drivers/gpu/drm/i915/display/intel_display.h
> index 4e9f22954a41..3b9987b5f304 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.h
> +++ b/drivers/gpu/drm/i915/display/intel_display.h
> @@ -52,6 +52,7 @@ struct intel_crtc_state; struct intel_digital_port; struct
> intel_dp; struct intel_encoder;
> +struct intel_connector;
> struct intel_initial_plane_config;
> struct intel_load_detect_pipe;
> struct intel_plane;
> @@ -469,16 +470,12 @@ enum hpd_pin {
> for_each_if(intel_encoder_can_psr(intel_encoder))
>
> #define for_each_intel_connector_iter(intel_connector, iter) \
> - while ((intel_connector =
> to_intel_connector(drm_connector_list_iter_next(iter))))
> + while ((intel_connector = intel_connector_list_iter_next(iter)))
>
> #define for_each_encoder_on_crtc(dev, __crtc, intel_encoder) \
> list_for_each_entry((intel_encoder), &(dev)-
> >mode_config.encoder_list, base.head) \
> for_each_if((intel_encoder)->base.crtc == (__crtc))
>
> -#define for_each_connector_on_encoder(dev, __encoder, intel_connector)
> \
> - list_for_each_entry((intel_connector), &(dev)-
> >mode_config.connector_list, base.head) \
> - for_each_if((intel_connector)->base.encoder == (__encoder))
> -
> #define for_each_old_intel_plane_in_state(__state, plane, old_plane_state,
> __i) \
> for ((__i) = 0; \
> (__i) < (__state)->base.dev->mode_config.num_total_plane && \
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
> b/drivers/gpu/drm/i915/display/intel_display_types.h
> index 0e94bd430bcb..7a82b7acbaf2 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1497,12 +1497,14 @@ struct cxsr_latency { #define
> to_intel_atomic_state(x) container_of(x, struct intel_atomic_state, base)
> #define to_intel_crtc(x) container_of(x, struct intel_crtc, base) #define
> to_intel_crtc_state(x) container_of(x, struct intel_crtc_state, uapi) -#define
> to_intel_connector(x) container_of(x, struct intel_connector, base)
> +#define to_intel_wb_connector(x) container_of(x, struct
> +intel_wb_connector, base)
> #define to_intel_encoder(x) container_of(x, struct intel_encoder, base)
> #define to_intel_framebuffer(x) container_of(x, struct intel_framebuffer,
> base) #define to_intel_plane(x) container_of(x, struct intel_plane, base)
> #define to_intel_plane_state(x) container_of(x, struct intel_plane_state,
> uapi) #define intel_fb_obj(x) ((x) ? to_intel_bo((x)->obj[0]) : NULL)
> +#define to_intel_connector(x) (((x->connector_type ==
> DRM_MODE_CONNECTOR_WRITEBACK)) ? \
> + NULL : container_of(x, struct intel_connector,
> base))
>
> struct intel_hdmi {
> i915_reg_t hdmi_reg;
> @@ -2068,4 +2070,26 @@ to_intel_frontbuffer(struct drm_framebuffer *fb)
> return fb ? to_intel_framebuffer(fb)->frontbuffer : NULL; }
>
> +static inline struct intel_connector *
> +intel_connector_list_iter_next(struct drm_connector_list_iter *iter) {
> + struct drm_connector *connector;
> + bool flag = true;
> + /*
> + * Skipping connector that are Writeback connector as they will
> + * not be embedded in intel connector
> + */
Better to be more clear, "An intel_connector entity is not created for writeback, hence decoupling"
With the above changes
Reviewed-by: Arun R Murthy <arun.r.murthy>
> + while (flag) {
> + connector = drm_connector_list_iter_next(iter);
> + if (connector && !to_intel_connector(connector))
> + continue;
> +
> + flag = false;
> +
> + if (connector)
> + return to_intel_connector(connector);
> +
> + }
> + return NULL;
> +}
> #endif /* __INTEL_DISPLAY_TYPES_H__ */ diff --git
> a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> index f0e04d3904c6..985dfa5f7aa1 100644
> --- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> +++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> @@ -204,12 +204,22 @@ static bool intel_crtc_has_encoders(struct
> intel_crtc *crtc)
>
> static struct intel_connector *intel_encoder_find_connector(struct
> intel_encoder *encoder) {
> - struct drm_device *dev = encoder->base.dev;
> + struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> struct intel_connector *connector;
> + struct drm_connector_list_iter conn_iter;
> + bool found_connector = false;
>
> - for_each_connector_on_encoder(dev, &encoder->base, connector)
> - return connector;
> + drm_connector_list_iter_begin(&i915->drm, &conn_iter);
> + for_each_intel_connector_iter(connector, &conn_iter) {
> + if (&encoder->base == connector->base.encoder) {
> + found_connector = true;
> + break;
> + }
> + }
> + drm_connector_list_iter_end(&conn_iter);
>
> + if (found_connector)
> + return connector;
> return NULL;
> }
>
> --
> 2.25.1
Thanks and Regards,
Arun R Murthy
--------------------
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Define WD trancoder for i915
2022-09-09 8:57 ` Murthy, Arun R
@ 2022-09-09 9:01 ` Jani Nikula
2022-09-09 9:03 ` Murthy, Arun R
0 siblings, 1 reply; 13+ messages in thread
From: Jani Nikula @ 2022-09-09 9:01 UTC (permalink / raw)
To: Murthy, Arun R, Kandpal, Suraj, intel-gfx
On Fri, 09 Sep 2022, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
>> From: Suraj Kandpal <suraj.kandpal@intel.com>
>>
>> Adding WD Types, WD transcoder to enum list and WD Transcoder offsets.
>> Adding i915 register definitions related to WD transcoder
>>
>> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_display.h | 6 +
>> .../drm/i915/display/intel_display_types.h | 1 +
>> drivers/gpu/drm/i915/i915_reg.h | 139 ++++++++++++++++++
>> 3 files changed, 146 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display.h
>> b/drivers/gpu/drm/i915/display/intel_display.h
>> index fa5371036239..4e9f22954a41 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display.h
>> @@ -120,6 +120,8 @@ enum transcoder {
>> TRANSCODER_DSI_1,
>> TRANSCODER_DSI_A = TRANSCODER_DSI_0, /* legacy DSI */
>> TRANSCODER_DSI_C = TRANSCODER_DSI_1, /* legacy DSI */
>> + TRANSCODER_WD_0,
>> + TRANSCODER_WD_1,
>>
>> I915_MAX_TRANSCODERS
>> };
>> @@ -141,6 +143,10 @@ static inline const char *transcoder_name(enum
>> transcoder transcoder)
>> return "DSI A";
>> case TRANSCODER_DSI_C:
>> return "DSI C";
>> + case TRANSCODER_WD_0:
>> + return "WD 0";
>> + case TRANSCODER_WD_1:
>> + return "WD 1";
>> default:
>> return "<invalid>";
>> }
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
>> b/drivers/gpu/drm/i915/display/intel_display_types.h
>> index 0da9b208d56e..0e94bd430bcb 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
>> @@ -79,6 +79,7 @@ enum intel_output_type {
>> INTEL_OUTPUT_DSI = 9,
>> INTEL_OUTPUT_DDI = 10,
>> INTEL_OUTPUT_DP_MST = 11,
>> + INTEL_OUTPUT_WD = 12,
>> };
>>
>> enum hdmi_force_audio {
>> diff --git a/drivers/gpu/drm/i915/i915_reg.h
>> b/drivers/gpu/drm/i915/i915_reg.h index bf5c39d9f953..e3fced4b9980
>> 100644
>> --- a/drivers/gpu/drm/i915/i915_reg.h
>> +++ b/drivers/gpu/drm/i915/i915_reg.h
>> @@ -2059,6 +2059,8 @@
>> #define TRANSCODER_EDP_OFFSET 0x6f000
>> #define TRANSCODER_DSI0_OFFSET 0x6b000
>> #define TRANSCODER_DSI1_OFFSET 0x6b800
>> +#define TRANSCODER_WD0_OFFSET 0x6e000
>> +#define TRANSCODER_WD1_OFFSET 0x6e800
>>
>> #define HTOTAL(trans) _MMIO_TRANS2(trans, _HTOTAL_A)
>> #define HBLANK(trans) _MMIO_TRANS2(trans, _HBLANK_A)
>> @@ -3831,6 +3833,11 @@
>> #define PIPE_DSI0_OFFSET 0x7b000
>> #define PIPE_DSI1_OFFSET 0x7b800
>>
>> +/* WD 0 and 1 */
> Can this be changed to
> /* WD offset */
Nah, the comments should be removed altogether, they add zero
value. That's literally what the macro name says already.
BR,
Jani.
>
>> +#define PIPE_WD0_OFFSET 0x7e000
>> +#define PIPE_WD1_OFFSET 0x7d000
>> +
>> +
>> #define PIPECONF(pipe) _MMIO_PIPE2(pipe, _PIPEACONF)
>> #define PIPEDSL(pipe) _MMIO_PIPE2(pipe, _PIPEADSL)
>> #define PIPEFRAME(pipe) _MMIO_PIPE2(pipe,
>> _PIPEAFRAMEHIGH)
>> @@ -4495,6 +4502,10 @@
>> #define _PIPEDSI0CONF 0x7b008
>> #define _PIPEDSI1CONF 0x7b808
>>
>> +/* WD 0 and 1 */
> Can this be changed to
> /* WD config regs */
>
>> +#define _PIPEWD0CONF 0x7e008
>> +#define _PIPEWD1CONF 0x7d008
>> +
>> /* Sprite A control */
>> #define _DVSACNTR 0x72180
>> #define DVS_ENABLE REG_BIT(31)
>> @@ -5720,6 +5731,7 @@
>> #define GEN8_DE_MISC_IER _MMIO(0x4446c)
>> #define GEN8_DE_MISC_GSE (1 << 27)
>> #define GEN8_DE_EDP_PSR (1 << 19)
>> +#define GEN8_DE_MISC_WD0 (1 << 23)
>>
>> #define GEN8_PCU_ISR _MMIO(0x444e0)
>> #define GEN8_PCU_IMR _MMIO(0x444e4)
>> @@ -8714,6 +8726,133 @@ enum skl_power_gate {
>> #define DSB_ENABLE (1 << 31)
>> #define DSB_STATUS (1 << 0)
>>
>> +#define TGL_ROOT_DEVICE_ID 0x9A00
>> +#define TGL_ROOT_DEVICE_MASK 0xFF00
>> +#define TGL_ROOT_DEVICE_SKU_MASK 0xF
>> +#define TGL_ROOT_DEVICE_SKU_ULX 0x2
>> +#define TGL_ROOT_DEVICE_SKU_ULT 0x4
>> +
>> +/* Gen12 WD */
>> +#define _MMIO_WD(tc, wd0, wd1) _MMIO_TRANS((tc) -
>> TRANSCODER_WD_0, \
>> + wd0, wd1)
>> +
>> +#define WD_TRANS_ENABLE (1 << 31)
>> +#define WD_TRANS_DISABLE 0
>> +#define WD_TRANS_ACTIVE (1 << 30)
>> +
>> +/* WD transcoder control */
>> +#define _WD_TRANS_FUNC_CTL_0 0x6e400
>> +#define _WD_TRANS_FUNC_CTL_1 0x6ec00
>> +#define WD_TRANS_FUNC_CTL(tc) _MMIO_WD(tc,\
>> + _WD_TRANS_FUNC_CTL_0,\
>> + _WD_TRANS_FUNC_CTL_1)
>> +
>> +#define TRANS_WD_FUNC_ENABLE (1 << 31)
>> +#define WD_TRIGGERED_CAP_MODE_ENABLE (1 << 30)
>> +#define START_TRIGGER_FRAME (1 << 29)
>> +#define STOP_TRIGGER_FRAME (1 << 28)
>> +#define WD_CTL_POINTER_ETEH (0 << 18)
>> +#define WD_CTL_POINTER_ETDH (1 << 18)
>> +#define WD_CTL_POINTER_DTDH (2 << 18)
>> +#define WD_INPUT_SELECT_MASK (7 << 12)
>> +#define WD_INPUT_PIPE_A (0 << 12)
>> +#define WD_INPUT_PIPE_B (5 << 12)
>> +#define WD_INPUT_PIPE_C (6 << 12)
>> +#define WD_INPUT_PIPE_D (7 << 12)
>> +
>> +#define WD_PIX_FMT_MASK (0x3 << 20)
>> +#define WD_PIX_FMT_YUYV (0x1 << 20)
>> +#define WD_PIX_FMT_XYUV8888 (0x2 << 20)
>> +#define WD_PIX_FMT_XBGR8888 (0x3 << 20)
>> +#define WD_PIX_FMT_Y410 (0x4 << 20)
>> +#define WD_PIX_FMT_YUV422 (0x5 << 20)
>> +#define WD_PIX_FMT_XBGR2101010 (0x6 << 20)
>> +#define WD_PIX_FMT_RGB565 (0x7 << 20)
>> +
>> +#define WD_FRAME_NUMBER_MASK 15
>> +
>> +#define _WD_STRIDE_0 0x6e510
>> +#define _WD_STRIDE_1 0x6ed10
>> +#define WD_STRIDE(tc) _MMIO_WD(tc,\
>> + _WD_STRIDE_0,\
>> + _WD_STRIDE_1)
>> +#define WD_STRIDE_SHIFT 6
>> +#define WD_STRIDE_MASK (0x3ff << WD_STRIDE_SHIFT)
>> +
>> +#define _WD_STREAMCAP_CTL0 0x6e590
>> +#define _WD_STREAMCAP_CTL1 0x6ed90
>> +#define WD_STREAMCAP_CTL(tc) _MMIO_WD(tc,\
>> + _WD_STREAMCAP_CTL0,\
>> + _WD_STREAMCAP_CTL1)
>> +
>> +#define WD_STREAM_CAP_MODE_EN (1 << 31)
>> +#define WD_STRAT_MASK (3 << 24)
>> +#define WD_SLICING_STRAT_1_1 (0 << 24)
>> +#define WD_SLICING_STRAT_2_1 (1 << 24)
>> +#define WD_SLICING_STRAT_4_1 (2 << 24)
>> +#define WD_SLICING_STRAT_8_1 (3 << 24)
>> +#define WD_STREAM_OVERRUN_STATUS 1
>> +
>> +#define _WD_SURF_0 0x6e514
>> +#define _WD_SURF_1 0x6ed14
>> +#define WD_SURF(tc) _MMIO_WD(tc,\
>> + _WD_SURF_0,\
>> + _WD_SURF_1)
>> +
>> +#define _WD_IMR_0 0x6e560
>> +#define _WD_IMR_1 0x6ed60
>> +#define WD_IMR(tc) _MMIO_WD(tc,\
>> + _WD_IMR_0,\
>> + _WD_IMR_1)
>> +#define WD_FRAME_COMPLETE_INT (1 << 7)
>> +#define WD_GTT_FAULT_INT (1 << 6)
>> +#define WD_VBLANK_INT (1 << 5)
>> +#define WD_OVERRUN_INT (1 << 4)
>> +#define WD_CAPTURING_INT (1 << 3)
>> +#define WD_WRITE_COMPLETE_INT (1 << 2)
>> +
>> +#define _WD_IIR_0 0x6e564
>> +#define _WD_IIR_1 0x6ed64
>> +#define WD_IIR(tc) _MMIO_WD(tc,\
>> + _WD_IIR_0,\
>> + _WD_IIR_1)
>> +
>> +#define _WD_FRAME_STATUS_0 0x6e56b
>> +#define _WD_FRAME_STATUS_1 0x6ed6b
>> +#define WD_FRAME_STATUS(tc) _MMIO_WD(tc,\
>> + _WD_FRAME_STATUS_0,\
>> + _WD_FRAME_STATUS_1)
>> +
>> +#define WD_FRAME_COMPLETE (1 << 31)
>> +#define WD_STATE_IDLE (0 << 24)
>> +#define WD_STATE_CAPSTART (1 << 24)
>> +#define WD_STATE_FRAME_START (2 << 24)
>> +#define WD_STATE_CAPACITIVE (3 << 24)
>> +#define WD_STATE_TG_DONE (4 << 24)
>> +#define WD_STATE_WDX_DONE (5 << 24)
>> +#define WD_STATE_QUICK_CAP (6 << 24)
>> +
>> +#define _WD_27_M_0 0x6e524
>> +#define _WD_27_M_1 0x6ed24
>> +#define WD_27_M(tc) _MMIO_WD(tc,\
>> + _WD_27_M_0,\
>> + _WD_27_M_1)
>> +
>> +#define _WD_27_N_0 0x6e528
>> +
>> +//Address looks wrong in bspec:
>> +#define _WD_27_N_1 0x6ec28
>> +#define WD_27_N(tc) _MMIO_WD(tc,\
>> + _WD_27_N_0,\
>> + _WD_27_N_1)
>> +
>> +#define _WD_TAIL_CFG_0 0x6e520
>> +#define _WD_TAIL_CFG_1 0x6ed20
>> +
>> +#define WD_TAIL_CFG(tc) _MMIO_WD(tc,\
>> + _WD_TAIL_CFG_0,\
>> + _WD_TAIL_CFG_1)
>> +
>> #define CLKREQ_POLICY _MMIO(0x101038)
>> #define CLKREQ_POLICY_MEM_UP_OVRD REG_BIT(1)
>>
> With the above said changes
> Reviewed-by: Arun R Murthy <arun.r.murthy>
>
> Thanks and Regards,
> Arun R Murthy
> --------------------
>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Define WD trancoder for i915
2022-09-09 9:01 ` Jani Nikula
@ 2022-09-09 9:03 ` Murthy, Arun R
0 siblings, 0 replies; 13+ messages in thread
From: Murthy, Arun R @ 2022-09-09 9:03 UTC (permalink / raw)
To: Nikula, Jani, Kandpal, Suraj, intel-gfx
> On Fri, 09 Sep 2022, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
> >> From: Suraj Kandpal <suraj.kandpal@intel.com>
> >>
> >> Adding WD Types, WD transcoder to enum list and WD Transcoder
> offsets.
> >> Adding i915 register definitions related to WD transcoder
> >>
> >> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/display/intel_display.h | 6 +
> >> .../drm/i915/display/intel_display_types.h | 1 +
> >> drivers/gpu/drm/i915/i915_reg.h | 139 ++++++++++++++++++
> >> 3 files changed, 146 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_display.h
> >> b/drivers/gpu/drm/i915/display/intel_display.h
> >> index fa5371036239..4e9f22954a41 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_display.h
> >> +++ b/drivers/gpu/drm/i915/display/intel_display.h
> >> @@ -120,6 +120,8 @@ enum transcoder {
> >> TRANSCODER_DSI_1,
> >> TRANSCODER_DSI_A = TRANSCODER_DSI_0, /* legacy DSI */
> >> TRANSCODER_DSI_C = TRANSCODER_DSI_1, /* legacy DSI */
> >> + TRANSCODER_WD_0,
> >> + TRANSCODER_WD_1,
> >>
> >> I915_MAX_TRANSCODERS
> >> };
> >> @@ -141,6 +143,10 @@ static inline const char *transcoder_name(enum
> >> transcoder transcoder)
> >> return "DSI A";
> >> case TRANSCODER_DSI_C:
> >> return "DSI C";
> >> + case TRANSCODER_WD_0:
> >> + return "WD 0";
> >> + case TRANSCODER_WD_1:
> >> + return "WD 1";
> >> default:
> >> return "<invalid>";
> >> }
> >> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
> >> b/drivers/gpu/drm/i915/display/intel_display_types.h
> >> index 0da9b208d56e..0e94bd430bcb 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> >> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> >> @@ -79,6 +79,7 @@ enum intel_output_type {
> >> INTEL_OUTPUT_DSI = 9,
> >> INTEL_OUTPUT_DDI = 10,
> >> INTEL_OUTPUT_DP_MST = 11,
> >> + INTEL_OUTPUT_WD = 12,
> >> };
> >>
> >> enum hdmi_force_audio {
> >> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> >> b/drivers/gpu/drm/i915/i915_reg.h index bf5c39d9f953..e3fced4b9980
> >> 100644
> >> --- a/drivers/gpu/drm/i915/i915_reg.h
> >> +++ b/drivers/gpu/drm/i915/i915_reg.h
> >> @@ -2059,6 +2059,8 @@
> >> #define TRANSCODER_EDP_OFFSET 0x6f000
> >> #define TRANSCODER_DSI0_OFFSET 0x6b000
> >> #define TRANSCODER_DSI1_OFFSET 0x6b800
> >> +#define TRANSCODER_WD0_OFFSET 0x6e000
> >> +#define TRANSCODER_WD1_OFFSET 0x6e800
> >>
> >> #define HTOTAL(trans) _MMIO_TRANS2(trans, _HTOTAL_A)
> >> #define HBLANK(trans) _MMIO_TRANS2(trans, _HBLANK_A)
> >> @@ -3831,6 +3833,11 @@
> >> #define PIPE_DSI0_OFFSET 0x7b000
> >> #define PIPE_DSI1_OFFSET 0x7b800
> >>
> >> +/* WD 0 and 1 */
> > Can this be changed to
> > /* WD offset */
>
> Nah, the comments should be removed altogether, they add zero value.
> That's literally what the macro name says already.
>
That should be best!
Please remove this.
Thanks and Regards,
Arun R Murthy
-------------------
l Open Source Graphics Center
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Enabling WD Transcoder
2022-08-22 8:16 ` [Intel-gfx] [PATCH v2 3/3] drm/i915: Enabling WD Transcoder Kandpal, Suraj
@ 2022-09-12 8:07 ` Murthy, Arun R
2022-09-12 9:28 ` Kandpal, Suraj
0 siblings, 1 reply; 13+ messages in thread
From: Murthy, Arun R @ 2022-09-12 8:07 UTC (permalink / raw)
To: Kandpal, Suraj, intel-gfx; +Cc: Nikula, Jani
General: I think 'wd' has to be replaced with 'wb' which mean writeback
> From: Suraj Kandpal <suraj.kandpal@intel.com>
>
> Adding support for writeback transcoder to start capturing frames using
> interrupt mechanism
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
> drivers/gpu/drm/i915/Makefile | 1 +
> drivers/gpu/drm/i915/display/intel_acpi.c | 1 +
> drivers/gpu/drm/i915/display/intel_crtc.c | 6 +
> .../drm/i915/display/intel_crtc_state_dump.c | 1 +
> drivers/gpu/drm/i915/display/intel_ddi.c | 6 +
> drivers/gpu/drm/i915/display/intel_display.c | 65 +-
> drivers/gpu/drm/i915/display/intel_display.h | 5 +
> .../drm/i915/display/intel_display_debugfs.c | 13 +-
> .../drm/i915/display/intel_display_types.h | 6 +
> drivers/gpu/drm/i915/display/intel_dpll.c | 6 +
> .../drm/i915/display/intel_modeset_setup.c | 103 ++-
> .../drm/i915/display/intel_modeset_verify.c | 17 +-
> drivers/gpu/drm/i915/display/intel_opregion.c | 3 +
> .../gpu/drm/i915/display/intel_wb_connector.h | 20 +
> drivers/gpu/drm/i915/display/intel_wd.c | 699 ++++++++++++++++++
> drivers/gpu/drm/i915/display/intel_wd.h | 48 ++
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/i915_irq.c | 8 +-
> drivers/gpu/drm/i915/i915_pci.c | 7 +-
> 19 files changed, 970 insertions(+), 46 deletions(-) create mode 100644
> drivers/gpu/drm/i915/display/intel_wb_connector.h
> create mode 100644 drivers/gpu/drm/i915/display/intel_wd.c
> create mode 100644 drivers/gpu/drm/i915/display/intel_wd.h
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index 522ef9b4aff3..ec63ed16c250 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -302,6 +302,7 @@ i915-y += \
> display/intel_tv.o \
> display/intel_vdsc.o \
> display/intel_vrr.o \
> + display/intel_wd.o \
> display/vlv_dsi.o \
> display/vlv_dsi_pll.o
>
> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c
> b/drivers/gpu/drm/i915/display/intel_acpi.c
> index e78430001f07..ae08db164f73 100644
> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> @@ -247,6 +247,7 @@ static u32 acpi_display_type(struct intel_connector
> *connector)
> case DRM_MODE_CONNECTOR_LVDS:
> case DRM_MODE_CONNECTOR_eDP:
> case DRM_MODE_CONNECTOR_DSI:
> + case DRM_MODE_CONNECTOR_WRITEBACK:
> display_type = ACPI_DISPLAY_TYPE_INTERNAL_DIGITAL;
> break;
> case DRM_MODE_CONNECTOR_Unknown:
> diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c
> b/drivers/gpu/drm/i915/display/intel_crtc.c
> index 6792a9056f46..66d552758720 100644
> --- a/drivers/gpu/drm/i915/display/intel_crtc.c
> +++ b/drivers/gpu/drm/i915/display/intel_crtc.c
> @@ -491,6 +491,9 @@ void intel_pipe_update_start(struct intel_crtc_state
> *new_crtc_state)
> if (new_crtc_state->do_async_flip)
> return;
>
> + if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
> + return;
> +
> if (intel_crtc_needs_vblank_work(new_crtc_state))
> intel_crtc_vblank_work_init(new_crtc_state);
>
> @@ -638,6 +641,9 @@ void intel_pipe_update_end(struct intel_crtc_state
> *new_crtc_state)
> if (new_crtc_state->do_async_flip)
> return;
>
> + if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
> + return;
> +
> trace_intel_pipe_update_end(crtc, end_vbl_count, scanline_end);
>
> /*
> diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> index e9212f69c360..8435065f3b7d 100644
> --- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> +++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> @@ -71,6 +71,7 @@ static const char * const output_type_str[] = {
> OUTPUT_TYPE(DSI),
> OUTPUT_TYPE(DDI),
> OUTPUT_TYPE(DP_MST),
> + OUTPUT_TYPE(WD),
> };
>
> #undef OUTPUT_TYPE
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
> b/drivers/gpu/drm/i915/display/intel_ddi.c
> index a4c8493f3ce7..1360406ca531 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -1974,6 +1974,12 @@ void
> intel_ddi_sanitize_encoder_pll_mapping(struct intel_encoder *encoder)
> */
> if (encoder->type == INTEL_OUTPUT_DP_MST)
> return;
> + /*
> + * WD transcoder is a virtual encoder hence sanization
> + * is not required for it
> + */
WD transcoder doesn’t have any encoder, hence assigning a virtual encoder.
> + if (encoder->type == INTEL_OUTPUT_WD)
> + return;
>
> if (!encoder->base.crtc && intel_encoder_is_dp(encoder)) {
> u8 pipe_mask;
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/display/intel_display.c
> index f143adefdf38..52fb23846856 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -115,6 +115,7 @@
> #include "intel_sprite.h"
> #include "intel_tc.h"
> #include "intel_vga.h"
> +#include "intel_wd.h"
> #include "i9xx_plane.h"
> #include "skl_scaler.h"
> #include "skl_universal_plane.h"
> @@ -1510,6 +1511,9 @@ static void intel_encoders_update_prepare(struct
> intel_atomic_state *state)
> continue;
>
> intel_connector = to_intel_connector(connector);
Can you add a comment here saying for WD intel_connector is not created!
> + if (!intel_connector)
> + continue;
> +
> encoder =
> intel_connector_primary_encoder(intel_connector);
> if (!encoder->update_prepare)
> continue;
> @@ -1539,6 +1543,9 @@ static void intel_encoders_update_complete(struct
> intel_atomic_state *state)
> continue;
>
> intel_connector = to_intel_connector(connector);
Same here a comment!
> + if (!intel_connector)
> + continue;
> +
> encoder =
> intel_connector_primary_encoder(intel_connector);
> if (!encoder->update_complete)
> continue;
> @@ -1549,6 +1556,39 @@ static void
> intel_encoders_update_complete(struct intel_atomic_state *state)
> }
> }
>
> +static void intel_queue_writeback_job(struct intel_atomic_state *state,
> + struct intel_crtc *intel_crtc, struct intel_crtc_state *crtc_state)
Can this intel_crtc_state be eliminated, anyway later it the function it can be obtained from intel_atomic_state!
Moreover crtc_state and intel_crtc is not being used at all.
> {
> + struct drm_connector_state *new_conn_state;
> + struct drm_connector *connector;
> + struct drm_writeback_connector *wb_conn;
> + int i;
> +
> + for_each_new_connector_in_state(&state->base, connector,
> new_conn_state,
> + i) {
> + if (!new_conn_state->writeback_job)
> + continue;
> +
> + wb_conn = drm_connector_to_writeback(connector);
> + drm_writeback_queue_job(wb_conn, new_conn_state);
> + }
> +}
> +
> +static void intel_enable_writeback_capture(struct intel_atomic_state *state,
> + struct intel_crtc *intel_crtc, struct intel_crtc_state *crtc_state)
Same here, can crtc_state can be eliminated and later obtain it from intel_atomic_state.
Intel_crtc is not being used.
> {
> + struct drm_connector_state *new_conn_state;
> + struct drm_connector *connector;
> + int i;
> +
> + for_each_new_connector_in_state(&state->base, connector,
> new_conn_state,
> + i) {
> + if (connector->connector_type !=
> DRM_MODE_CONNECTOR_WRITEBACK)
> + continue;
> + intel_wd_enable_capture(crtc_state, new_conn_state);
> + }
> +}
> +
> static void intel_encoders_pre_pll_enable(struct intel_atomic_state *state,
> struct intel_crtc *crtc)
> {
> @@ -1649,8 +1689,12 @@ static void intel_encoders_post_disable(struct
> intel_atomic_state *state,
> int i;
>
> for_each_old_connector_in_state(&state->base, conn,
> old_conn_state, i) {
> - struct intel_encoder *encoder =
> - to_intel_encoder(old_conn_state->best_encoder);
> + struct intel_encoder *encoder;
> +
> + if (conn->connector_type ==
> DRM_MODE_CONNECTOR_WRITEBACK)
> + continue;
> +
> + encoder = to_intel_encoder(old_conn_state->best_encoder);
>
> if (old_conn_state->crtc != &crtc->base)
> continue;
> @@ -1927,7 +1971,8 @@ static void hsw_crtc_enable(struct
> intel_atomic_state *state,
> bdw_set_pipemisc(new_crtc_state);
>
> if (!intel_crtc_is_bigjoiner_slave(new_crtc_state) &&
> - !transcoder_is_dsi(cpu_transcoder))
> + !transcoder_is_dsi(cpu_transcoder) &&
> + !transcoder_is_wd(cpu_transcoder))
> hsw_configure_cpu_transcoder(new_crtc_state);
>
> crtc->active = true;
> @@ -7575,6 +7620,12 @@ static void intel_atomic_commit_tail(struct
> intel_atomic_state *state)
> }
> }
>
> + for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
> + if (!(new_crtc_state->output_types &
> BIT(INTEL_OUTPUT_WD)))
> + continue;
> + intel_wd_set_vblank_event(state, crtc, new_crtc_state);
For compiler optimization purpose can this be changed to
if ((new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD)))
intel_wd_set_vblank_event(state, crtc, new_crtc_state);
> + }
> +
> intel_encoders_update_prepare(state);
>
> intel_dbuf_pre_plane_update(state);
> @@ -7585,6 +7636,13 @@ static void intel_atomic_commit_tail(struct
> intel_atomic_state *state)
> intel_crtc_enable_flip_done(state, crtc);
> }
>
> + for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
> + if (!(new_crtc_state->output_types &
> BIT(INTEL_OUTPUT_WD)))
> + continue;
> + intel_queue_writeback_job(state, crtc, new_crtc_state);
> + intel_enable_writeback_capture(state, crtc, new_crtc_state);
> + }
Same here, since we are focusing on WD over here, so lets have a check for WD and avoid continue.
Other way would be to add kernel optimization unlikely for the if condition.
> +
> /* Now enable the clocks, plane, pipe, and connectors that we set
> up. */
> dev_priv->display->commit_modeset_enables(state);
>
> @@ -7965,6 +8023,7 @@ static void intel_setup_outputs(struct
> drm_i915_private *dev_priv)
> intel_ddi_init(dev_priv, PORT_TC1);
> intel_ddi_init(dev_priv, PORT_TC2);
> } else if (DISPLAY_VER(dev_priv) >= 12) {
> + intel_wd_init(dev_priv, TRANSCODER_WD_0);
Can this be moved outside of the if else condition. Since this is whole lot does the port initialization and the newly added does the WD transcoder initialization.
> intel_ddi_init(dev_priv, PORT_A);
> intel_ddi_init(dev_priv, PORT_B);
> intel_ddi_init(dev_priv, PORT_TC1);
> diff --git a/drivers/gpu/drm/i915/display/intel_display.h
> b/drivers/gpu/drm/i915/display/intel_display.h
> index 3b9987b5f304..4879ca2e96f7 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.h
> +++ b/drivers/gpu/drm/i915/display/intel_display.h
> @@ -158,6 +158,11 @@ static inline bool transcoder_is_dsi(enum
> transcoder transcoder)
> return transcoder == TRANSCODER_DSI_A || transcoder ==
> TRANSCODER_DSI_C; }
>
> +static inline bool transcoder_is_wd(enum transcoder transcoder) {
> + return transcoder == TRANSCODER_WD_0 || transcoder ==
> TRANSCODER_WD_1;
> +}
> +
> /*
> * Global legacy plane identifier. Valid only for primary/sprite
> * planes on pre-g4x, and only for primary planes on g4x-bdw.
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 225b6bfc783c..0dad54058762 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -547,7 +547,7 @@ static void intel_hdmi_info(struct seq_file *m, static
> void intel_connector_info(struct seq_file *m,
> struct drm_connector *connector)
> {
> - struct intel_connector *intel_connector =
> to_intel_connector(connector);
> + struct intel_connector *intel_connector;
> const struct drm_connector_state *conn_state = connector->state;
> struct intel_encoder *encoder =
> to_intel_encoder(conn_state->best_encoder);
> @@ -570,6 +570,8 @@ static void intel_connector_info(struct seq_file *m,
> if (!encoder)
> return;
>
> + intel_connector = to_intel_connector(connector);
> +
> switch (connector->connector_type) {
> case DRM_MODE_CONNECTOR_DisplayPort:
> case DRM_MODE_CONNECTOR_eDP:
> @@ -587,12 +589,15 @@ static void intel_connector_info(struct seq_file *m,
> break;
> }
>
> - seq_puts(m, "\tHDCP version: ");
> - intel_hdcp_info(m, intel_connector);
> + if (intel_connector) {
> + seq_puts(m, "\tHDCP version: ");
> + intel_hdcp_info(m, intel_connector);
> + }
>
> seq_printf(m, "\tmax bpc: %u\n", connector->display_info.bpc);
>
> - intel_panel_info(m, intel_connector);
> + if (intel_connector)
> + intel_panel_info(m, intel_connector);
>
> seq_printf(m, "\tmodes:\n");
> list_for_each_entry(mode, &connector->modes, head) diff --git
> a/drivers/gpu/drm/i915/display/intel_display_types.h
> b/drivers/gpu/drm/i915/display/intel_display_types.h
> index 7a82b7acbaf2..7b550c532dfb 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -44,6 +44,7 @@
> #include <drm/drm_vblank.h>
> #include <drm/drm_vblank_work.h>
> #include <drm/i915_mei_hdcp_interface.h>
> +#include <drm/drm_writeback.h>
> #include <media/cec-notifier.h>
>
> #include "i915_vma.h"
> @@ -1370,6 +1371,11 @@ struct intel_crtc {
> bool cpu_fifo_underrun_disabled;
> bool pch_fifo_underrun_disabled;
>
> + struct {
> + struct drm_pending_vblank_event *e;
> + atomic_t work_busy;
> + wait_queue_head_t wd_wait;
> + } wd;
> /* per-pipe watermark state */
> struct {
> /* watermarks currently being used */ diff --git
> a/drivers/gpu/drm/i915/display/intel_dpll.c
> b/drivers/gpu/drm/i915/display/intel_dpll.c
> index 5262f16b45ac..82bb8e170197 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll.c
> @@ -939,6 +939,9 @@ static int hsw_crtc_compute_clock(struct
> intel_atomic_state *state,
> struct intel_encoder *encoder =
> intel_get_crtc_new_encoder(state, crtc_state);
>
> + if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_WD))
> + return 0;
> +
> if (DISPLAY_VER(dev_priv) < 11 &&
> intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI))
> return 0;
> @@ -955,6 +958,9 @@ static int hsw_crtc_get_shared_dpll(struct
> intel_atomic_state *state,
> struct intel_encoder *encoder =
> intel_get_crtc_new_encoder(state, crtc_state);
>
> + if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_WD))
> + return 0;
> +
> if (DISPLAY_VER(dev_priv) < 11 &&
> intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI))
> return 0;
> diff --git a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> index 985dfa5f7aa1..0e48c1a31024 100644
> --- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> +++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> @@ -23,6 +23,7 @@
> #include "intel_modeset_setup.h"
> #include "intel_pch_display.h"
> #include "intel_pm.h"
> +#include "intel_wd.h"
>
> static void intel_crtc_disable_noatomic(struct intel_crtc *crtc,
> struct drm_modeset_acquire_ctx
> *ctx) @@ -110,17 +111,17 @@ static void intel_crtc_disable_noatomic(struct
> intel_crtc *crtc,
>
> static void intel_modeset_update_connector_atomic_state(struct
> drm_i915_private *i915) {
> - struct intel_connector *connector;
> + struct drm_connector *connector;
> struct drm_connector_list_iter conn_iter;
>
> drm_connector_list_iter_begin(&i915->drm, &conn_iter);
> - for_each_intel_connector_iter(connector, &conn_iter) {
> - struct drm_connector_state *conn_state = connector-
> >base.state;
> + drm_for_each_connector_iter(connector, &conn_iter) {
> + struct drm_connector_state *conn_state = connector->state;
> struct intel_encoder *encoder =
> - to_intel_encoder(connector->base.encoder);
> + to_intel_encoder(connector->encoder);
>
> if (conn_state->crtc)
> - drm_connector_put(&connector->base);
> + drm_connector_put(connector);
>
> if (encoder) {
> struct intel_crtc *crtc =
> @@ -132,7 +133,7 @@ static void
> intel_modeset_update_connector_atomic_state(struct drm_i915_private
> conn_state->crtc = &crtc->base;
> conn_state->max_bpc = (crtc_state->pipe_bpp ?: 24)
> / 3;
>
> - drm_connector_get(&connector->base);
> + drm_connector_get(connector);
> } else {
> conn_state->best_encoder = NULL;
> conn_state->crtc = NULL;
> @@ -432,6 +433,8 @@ static void intel_modeset_readout_hw_state(struct
> drm_i915_private *i915)
> struct intel_crtc *crtc;
> struct intel_encoder *encoder;
> struct intel_connector *connector;
> + struct drm_connector *_connector;
> + struct drm_encoder *_encoder;
> struct drm_connector_list_iter conn_iter;
> u8 active_pipes = 0;
>
> @@ -508,38 +511,70 @@ static void
> intel_modeset_readout_hw_state(struct drm_i915_private *i915)
> intel_dpll_readout_hw_state(i915);
>
> drm_connector_list_iter_begin(&i915->drm, &conn_iter);
> - for_each_intel_connector_iter(connector, &conn_iter) {
> - if (connector->get_hw_state(connector)) {
> - struct intel_crtc_state *crtc_state;
> - struct intel_crtc *crtc;
> -
> - connector->base.dpms = DRM_MODE_DPMS_ON;
> -
> - encoder = intel_attached_encoder(connector);
> - connector->base.encoder = &encoder->base;
> -
> - crtc = to_intel_crtc(encoder->base.crtc);
> - crtc_state = crtc ? to_intel_crtc_state(crtc-
> >base.state) : NULL;
> -
> - if (crtc_state && crtc_state->hw.active) {
> - /*
> - * This has to be done during hardware
> readout
> - * because anything calling .crtc_disable may
> - * rely on the connector_mask being
> accurate.
> - */
> - crtc_state->uapi.connector_mask |=
> - drm_connector_mask(&connector-
> >base);
> - crtc_state->uapi.encoder_mask |=
> - drm_encoder_mask(&encoder-
> >base);
> + drm_for_each_connector_iter(_connector, &conn_iter) {
> + struct intel_crtc_state *crtc_state;
> + struct intel_crtc *crtc;
> + struct drm_writeback_connector *wb_conn;
> + struct intel_wd *intel_wd;
> +
> + connector = to_intel_connector(_connector);
> + if (!connector) {
> + wb_conn =
> drm_connector_to_writeback(_connector);
> + intel_wd = wb_conn_to_intel_wd(wb_conn);
> + _encoder = &intel_wd->base.base;
> + _connector->encoder = _encoder;
> + encoder = to_intel_encoder(_encoder);
> + pipe = 0;
> + if (encoder->get_hw_state(encoder, &pipe)) {
> + _connector->dpms =
> DRM_MODE_DPMS_ON;
> + crtc = to_intel_crtc(_encoder->crtc);
> + crtc_state = crtc ? to_intel_crtc_state(crtc-
> >base.state) : NULL;
> +
> + if (crtc_state && crtc_state->hw.active) {
> + /*
> + * This has to be done during
> hardware readout
> + * because anything calling
> .crtc_disable may
> + * rely on the connector_mask being
> accurate.
> + */
> + crtc_state->uapi.connector_mask |=
> +
> drm_connector_mask(&connector->base);
> + crtc_state->uapi.encoder_mask |=
> +
> drm_encoder_mask(&encoder->base);
> + }
> + } else {
> + _connector->dpms =
> DRM_MODE_DPMS_OFF;
> + _connector->encoder = NULL;
> }
> } else {
> - connector->base.dpms = DRM_MODE_DPMS_OFF;
> - connector->base.encoder = NULL;
> + if (connector->get_hw_state(connector)) {
> + connector->base.dpms =
> DRM_MODE_DPMS_OFF;
> + encoder =
> intel_attached_encoder(connector);
> + connector->base.encoder = &encoder->base;
> +
> + crtc = to_intel_crtc(encoder->base.crtc);
> + crtc_state = crtc ? to_intel_crtc_state(crtc-
> >base.state) : NULL;
> +
> + if (crtc_state && crtc_state->hw.active) {
> + /*
> + * This has to be done during
> hardware readout
> + * because anything calling
> .crtc_disable may
> + * rely on the connector_mask being
> accurate.
> + */
> + crtc_state->uapi.connector_mask |=
> +
> drm_connector_mask(&connector->base);
> + crtc_state->uapi.encoder_mask |=
> +
> drm_encoder_mask(&encoder->base);
> + }
> + } else {
> + connector->base.dpms =
> DRM_MODE_DPMS_OFF;
> + connector->base.encoder = NULL;
> + }
> }
> drm_dbg_kms(&i915->drm,
> - "[CONNECTOR:%d:%s] hw state readout: %s\n",
> - connector->base.base.id, connector->base.name,
> - str_enabled_disabled(connector->base.encoder));
> + "[CONNECTOR:%d:%s] hw state readout:
> %s\n",
> + _connector->base.id, _connector->name,
> + str_enabled_disabled(_connector-
> >encoder));
> +
It becomes too huge, with if else for WD.
Can we retain the existing as is for non-WD and add a new for loop to find out WD and readout hw state separately for WD.
> }
> drm_connector_list_iter_end(&conn_iter);
>
> diff --git a/drivers/gpu/drm/i915/display/intel_modeset_verify.c
> b/drivers/gpu/drm/i915/display/intel_modeset_verify.c
> index a91586d77cb6..0e06daac74c1 100644
> --- a/drivers/gpu/drm/i915/display/intel_modeset_verify.c
> +++ b/drivers/gpu/drm/i915/display/intel_modeset_verify.c
> @@ -25,11 +25,16 @@
> static void intel_connector_verify_state(struct intel_crtc_state *crtc_state,
> struct drm_connector_state
> *conn_state) {
> - struct intel_connector *connector = to_intel_connector(conn_state-
> >connector);
> - struct drm_i915_private *i915 = to_i915(connector->base.dev);
> + struct drm_connector *_connector = conn_state->connector;
> + struct intel_connector *connector;
> + struct drm_i915_private *i915 = to_i915(_connector->dev);
>
> drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s]\n",
> - connector->base.base.id, connector->base.name);
> + _connector->base.id, _connector->name);
> +
> + connector = to_intel_connector(_connector);
> + if (!connector)
> + return;
>
> if (connector->get_hw_state(connector)) {
> struct intel_encoder *encoder =
> intel_attached_encoder(connector);
> @@ -119,6 +124,9 @@ verify_encoder_state(struct drm_i915_private
> *dev_priv, struct intel_atomic_stat
> encoder->base.base.id,
> encoder->base.name);
>
> + if (encoder->type == INTEL_OUTPUT_WD)
> + continue;
> +
> for_each_oldnew_connector_in_state(&state->base,
> connector, old_conn_state,
> new_conn_state, i) {
> if (old_conn_state->best_encoder == &encoder-
> >base) @@ -177,6 +185,9 @@ verify_crtc_state(struct intel_crtc *crtc,
>
> intel_crtc_get_pipe_config(pipe_config);
>
> + if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
> + return;
> +
> /* we keep both pipes enabled on 830 */
> if (IS_I830(dev_priv) && pipe_config->hw.active)
> pipe_config->hw.active = new_crtc_state->hw.active; diff --git
> a/drivers/gpu/drm/i915/display/intel_opregion.c
> b/drivers/gpu/drm/i915/display/intel_opregion.c
> index 1c0c745c142d..73a5a12e2c48 100644
> --- a/drivers/gpu/drm/i915/display/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/display/intel_opregion.c
> @@ -374,6 +374,9 @@ int intel_opregion_notify_encoder(struct
> intel_encoder *intel_encoder,
> if (ret)
> return ret;
>
> + if (intel_encoder->type == INTEL_OUTPUT_WD)
> + return 0;
> +
> if (intel_encoder->type == INTEL_OUTPUT_DSI)
> port = 0;
> else
> diff --git a/drivers/gpu/drm/i915/display/intel_wb_connector.h
> b/drivers/gpu/drm/i915/display/intel_wb_connector.h
> new file mode 100644
> index 000000000000..39dceddc7b4d
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/display/intel_wb_connector.h
Should this be intel_wb.h?
> @@ -0,0 +1,20 @@
> +/* SPDX-License-Identifier: MIT*/
> +/*
> + * Copyright © 2022 Intel Corporation
> + */
> +
> +#ifndef __INTEL_WB_CONNECTOR_H__
> +#define __INTEL_WB_CONNECTOR_H__
> +
> +#include "intel_display.h"
> +
> +struct intel_wb_connector *intel_wb_connector_alloc(void); void
> +intel_wb_connector_free(struct intel_wb_connector *connector); void
> +intel_wb_connector_destroy(struct drm_connector *connector); bool
> +intel_wb_connector_get_hw_state(struct intel_wb_connector *connector);
> +enum pipe intel_wb_connector_get_pipe(struct intel_wb_connector
> +*connector); void intel_wb_connector_attach_encoder(struct
> intel_wb_connector *connector,
> + struct intel_encoder *encoder);
> +
> +#endif /* __INTEL_WB_CONNECTOR_H__ */
> +
> diff --git a/drivers/gpu/drm/i915/display/intel_wd.c
> b/drivers/gpu/drm/i915/display/intel_wd.c
> new file mode 100644
> index 000000000000..a30cf1055db4
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/display/intel_wd.c
> @@ -0,0 +1,699 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2022 Intel Corporation
> + */
> +
> +#include <drm/drm_atomic_helper.h>
> +#include <drm/drm_fourcc.h>
> +
> +#include "intel_atomic.h"
> +#include "intel_connector.h"
> +#include "intel_wd.h"
> +#include "intel_fb_pin.h"
> +#include "intel_de.h"
> +
> +enum {
> + WD_CAPTURE_4_PIX,
> + WD_CAPTURE_2_PIX,
> +} wd_capture_format;
> +
> +struct drm_writeback_job
> +*intel_get_writeback_job_from_queue(struct intel_wd *intel_wd) {
> + struct drm_writeback_job *job;
> + struct drm_i915_private *i915 = to_i915(intel_wd->base.base.dev);
> + struct drm_writeback_connector *wb_conn =
> + &intel_wd->wb_conn;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&wb_conn->job_lock, flags);
> + job = list_first_entry_or_null(&wb_conn->job_queue,
> + struct drm_writeback_job,
> + list_entry);
> + spin_unlock_irqrestore(&wb_conn->job_lock, flags);
> + if (job == NULL) {
> + drm_dbg_kms(&i915->drm, "job queue is empty\n");
> + return NULL;
> + }
> +
> + return job;
> +}
> +
> +/*Check with Spec*/
Remove this and if you need to double check add a TODO:
> +static const u32 wb_fmts[] = {
> + DRM_FORMAT_YUV444,
> + DRM_FORMAT_XYUV8888,
> + DRM_FORMAT_XBGR8888,
> + DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_Y410,
> + DRM_FORMAT_YUV422,
> + DRM_FORMAT_XBGR2101010,
> + DRM_FORMAT_RGB565,
> +};
> +
> +static int intel_wd_get_format(int pixel_format) {
> + int wd_format = -EINVAL;
> +
> + switch (pixel_format) {
> + case DRM_FORMAT_XBGR8888:
> + case DRM_FORMAT_XRGB8888:
> + case DRM_FORMAT_XBGR2101010:
> + case DRM_FORMAT_XYUV8888:
> + case DRM_FORMAT_YUV444:
> + wd_format = WD_CAPTURE_4_PIX;
> + break;
> + case DRM_FORMAT_YUV422:
> + case DRM_FORMAT_RGB565:
> + wd_format = WD_CAPTURE_2_PIX;
> + break;
> + default:
> + DRM_ERROR("unsupported pixel format %x!\n",
> + pixel_format);
> + }
> +
> + return wd_format;
> +}
> +
> +static int intel_wd_verify_pix_format(int format) {
> + const struct drm_format_info *info = drm_format_info(format);
> + int pix_format = info->format;
> + int i = 0;
> +
> + for (i = 0; i < ARRAY_SIZE(wb_fmts); i++)
> + if (pix_format == wb_fmts[i])
> + return 0;
> +
> + return 1;
return TRUE;
> +}
> +
> +static u32 intel_wd_get_stride(const struct intel_crtc_state *crtc_state,
> + int format)
> +{
> + const struct drm_format_info *info = drm_format_info(format);
> + int wd_format;
> + int hactive, pixel_size;
> +
> + wd_format = intel_wd_get_format(info->format);
> +
> + switch (wd_format) {
> + case WD_CAPTURE_4_PIX:
> + pixel_size = 4;
> + break;
> + case WD_CAPTURE_2_PIX:
> + pixel_size = 2;
> + break;
> + default:
> + pixel_size = 1;
> + break;
> + }
> +
> + hactive = crtc_state->hw.adjusted_mode.crtc_hdisplay;
> +
> + return DIV_ROUND_UP(hactive * pixel_size, 64); }
> +
> +static int intel_wd_pin_fb(struct intel_wd *intel_wd,
> + struct drm_framebuffer *fb)
> +{
> + const struct i915_ggtt_view view = {
> + .type = I915_GGTT_VIEW_NORMAL,
> + };
> + struct i915_vma *vma;
> +
> + vma = intel_pin_and_fence_fb_obj(fb, false, &view, false,
> + &intel_wd->flags);
> +
> + if (IS_ERR(vma))
> + return PTR_ERR(vma);
> +
> + intel_wd->vma = vma;
> + return 0;
> +}
> +
> +static void intel_configure_slicing_strategy(struct drm_i915_private
> *dev_priv,
> + struct intel_wd *intel_wd, u32 *tmp)
Change dev_priv to i915
> +{
> + *tmp &= ~WD_STRAT_MASK;
> + if (intel_wd->slicing_strategy == 1)
> + *tmp |= WD_SLICING_STRAT_1_1;
> + else if (intel_wd->slicing_strategy == 2)
> + *tmp |= WD_SLICING_STRAT_2_1;
> + else if (intel_wd->slicing_strategy == 3)
> + *tmp |= WD_SLICING_STRAT_4_1;
> + else if (intel_wd->slicing_strategy == 4)
> + *tmp |= WD_SLICING_STRAT_8_1;
> +
> + intel_de_write(dev_priv, WD_STREAMCAP_CTL(intel_wd->trans),
> + *tmp);
> +}
> +
> +static enum drm_mode_status
> +intel_wd_mode_valid(struct drm_connector *connector,
> + struct drm_display_mode *mode)
> +{
> + drm_dbg_kms(connector->dev, ":");
> + return MODE_OK;
> +}
Are you planning to add any logic over here? If so add a TODO/FIXME.
If not then remove this.
> +
> +static int intel_wd_get_modes(struct drm_connector *connector) {
> + return 0;
> +}
Same as above.
> +
> +static void intel_wd_get_config(struct intel_encoder *encoder,
> + struct intel_crtc_state *pipe_config) {
> + struct intel_crtc *intel_crtc =
> + to_intel_crtc(pipe_config->uapi.crtc);
> +
> + if (intel_crtc) {
> + memcpy(pipe_config, intel_crtc->config,
> + sizeof(*pipe_config));
> + pipe_config->output_types |= BIT(INTEL_OUTPUT_WD);
> + }
> +}
> +
> +static int intel_wd_compute_config(struct intel_encoder *encoder,
> + struct intel_crtc_state *pipe_config,
> + struct drm_connector_state *conn_state) {
> + struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
> + struct drm_writeback_job *job;
> +
> + job = intel_get_writeback_job_from_queue(intel_wd);
> + if (job || conn_state->writeback_job) {
> + intel_wd->wd_crtc = to_intel_crtc(pipe_config->uapi.crtc);
> + return 0;
> + }
> +
> + return 0;
> +}
Just assigning pipe/crtc to wd. Can this be commented?
> +
> +static void intel_wd_get_power_domains(struct intel_encoder *encoder,
> + struct intel_crtc_state *crtc_state) {
> + struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> + struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
> + intel_wakeref_t wakeref;
> +
> + wakeref = intel_display_power_get(i915,
> + encoder->power_domain);
> +
> + intel_wd->io_wakeref[0] = wakeref;
> +}
> +
> +static bool intel_wd_get_hw_state(struct intel_encoder *encoder,
> + enum pipe *pipe)
> +{
> + bool ret = false;
> + struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> + struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
> + struct intel_crtc *wd_crtc = intel_wd->wd_crtc;
> + intel_wakeref_t wakeref;
> + u32 tmp;
> +
> + if (wd_crtc)
> + return false;
> +
> + wakeref = intel_display_power_get_if_enabled(dev_priv,
> + encoder->power_domain);
> +
> + if (!wakeref)
> + goto out;
> +
> + tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
> + ret = tmp & WD_TRANS_ACTIVE;
> + if (ret) {
> + *pipe = wd_crtc->pipe;
> + return true;
> + }
> +
> +out:
> + intel_display_power_put(dev_priv, encoder->power_domain,
> wakeref);
> + return false;
> +}
> +
> +static int intel_wd_encoder_atomic_check(struct drm_encoder *encoder,
> + struct drm_crtc_state *crtc_st,
> + struct drm_connector_state *conn_st) {
> + /* Check for the format and buffers and property validity */
> + struct drm_framebuffer *fb;
> + struct drm_writeback_job *job = conn_st->writeback_job;
> + struct drm_i915_private *i915 = to_i915(encoder->dev);
> + const struct drm_display_mode *mode = &crtc_st->mode;
> + int ret;
> +
> + if (!job) {
> + drm_dbg_kms(&i915->drm, "No writeback job created
> returning\n");
> + return -EINVAL;
> + }
> +
> + fb = job->fb;
> + if (!fb) {
> + drm_dbg_kms(&i915->drm, "Invalid framebuffer\n");
> + return -EINVAL;
> + }
> +
> + if (fb->width != mode->hdisplay || fb->height != mode->vdisplay) {
> + drm_dbg_kms(&i915->drm, "Invalid framebuffer size
> %ux%u\n",
> + fb->width, fb->height);
> + return -EINVAL;
> + }
> +
> + ret = intel_wd_verify_pix_format(fb->format->format);
> + if (ret) {
> + drm_dbg_kms(&i915->drm, "Unsupported framebuffer
> format %08x\n",
> + fb->format->format);
> + return -EINVAL;
> + }
> +
> + return 0;
> +}
> +
> +
> +static const struct drm_encoder_helper_funcs wd_encoder_helper_funcs =
> {
> + .atomic_check = intel_wd_encoder_atomic_check, };
> +
> +static void intel_wd_connector_destroy(struct drm_connector *connector)
> +{
Do you want to flush your queue before removing connector!
> + drm_connector_cleanup(connector);
> + kfree(connector);
> +}
> +
> +static enum drm_connector_status
> +intel_wb_connector_detect(struct drm_connector *connector, bool force)
> +{
> + return connector_status_connected;
> +}
> +
> +static const struct drm_connector_funcs wd_connector_funcs = {
> + .detect = intel_wb_connector_detect,
> + .reset = drm_atomic_helper_connector_reset,
> + .destroy = intel_wd_connector_destroy,
> + .fill_modes = drm_helper_probe_single_connector_modes,
> + .atomic_destroy_state =
> drm_atomic_helper_connector_destroy_state,
> + .atomic_duplicate_state =
> drm_atomic_helper_connector_duplicate_state,
> +};
> +
> +static const struct drm_connector_helper_funcs
> wd_connector_helper_funcs = {
> + .get_modes = intel_wd_get_modes,
> + .mode_valid = intel_wd_mode_valid,
> +};
> +
> +static const struct drm_encoder_funcs drm_writeback_encoder_funcs = {
> + .destroy = drm_encoder_cleanup,
> +};
> +
> +static bool intel_fastset_dis(struct intel_encoder *encoder,
> + struct intel_crtc_state *pipe_config) {
> + return false;
> +}
> +
> +static void intel_wd_connector_init(struct intel_wd *intel_wd) {
> + drm_atomic_helper_connector_reset(&intel_wd->wb_conn.base);
> +}
> +
> +static void intel_wd_disable_capture(struct intel_wd *intel_wd) {
> + struct drm_i915_private *dev_priv = to_i915(intel_wd-
> >base.base.dev);
> + u32 tmp;
> +
> + intel_de_write_fw(dev_priv, WD_IMR(intel_wd->trans), 0xFF);
> + tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
> + tmp &= WD_TRANS_DISABLE;
> + intel_de_write(dev_priv, PIPECONF(intel_wd->trans), tmp);
> + tmp = intel_de_read(dev_priv, WD_TRANS_FUNC_CTL(intel_wd-
> >trans));
> + tmp |= ~TRANS_WD_FUNC_ENABLE;
Not writing this value back to the CTL reg.
> +}
> +
> +void intel_wd_init(struct drm_i915_private *i915, enum transcoder
> +trans) {
> + struct intel_wd *intel_wd;
> + struct intel_encoder *encoder;
> + struct drm_writeback_connector *wb_conn;
> + int n_formats = ARRAY_SIZE(wb_fmts);
> + struct drm_encoder *drm_enc;
> + int err, ret;
> +
> + intel_wd = kzalloc(sizeof(*intel_wd), GFP_KERNEL);
> +
Blank line not needed.
> + if (!intel_wd)
> + return;
> +
> + intel_wd_connector_init(intel_wd);
> + encoder = &intel_wd->base;
> + drm_enc = &encoder->base;
> + wb_conn = &intel_wd->wb_conn;
> + intel_wd->trans = trans;
> + intel_wd->triggered_cap_mode = 1;
> + intel_wd->frame_num = 1;
> + intel_wd->slicing_strategy = 1;
> + encoder->get_config = intel_wd_get_config;
> + encoder->compute_config = intel_wd_compute_config;
> + encoder->get_hw_state = intel_wd_get_hw_state;
> + encoder->type = INTEL_OUTPUT_WD;
> + encoder->cloneable = 0;
> + encoder->pipe_mask = ~0;
> + encoder->power_domain = POWER_DOMAIN_TRANSCODER_B;
> + encoder->get_power_domains = intel_wd_get_power_domains;
> + encoder->initial_fastset_check = intel_fastset_dis;
> +
> + drm_encoder_helper_add(drm_enc,
> + &wd_encoder_helper_funcs);
> +
> + drm_enc->possible_crtcs = ~0;
> + ret = drm_encoder_init(&i915->drm, drm_enc,
> + &drm_writeback_encoder_funcs,
> + DRM_MODE_ENCODER_VIRTUAL, NULL);
> +
> + if (ret) {
> + drm_dbg_kms(&i915->drm,
> + "Writeback drm_encoder init Failed: %d\n",
> + ret);
> + goto cleanup;
> + }
> +
> + err = drm_writeback_connector_init_with_encoder(&i915->drm,
> + wb_conn, drm_enc, &wd_connector_funcs,
> + wb_fmts, n_formats);
> +
> + if (err != 0) {
> + drm_dbg_kms(&i915->drm,
> + "drm_writeback_connector_init: Failed: %d\n",
> + err);
Can you correct the alignment?
> + goto cleanup;
> + }
> +
> + wb_conn->base.encoder = drm_enc;
> + drm_connector_helper_add(&wb_conn->base,
> &wd_connector_helper_funcs);
> + wb_conn->base.status = connector_status_connected;
> + return;
> +
> +cleanup:
> + kfree(intel_wd);
> + return;
> +}
> +
> +static void intel_wd_writeback_complete(struct intel_wd *intel_wd,
> + struct drm_writeback_job *job, int status) {
> + struct drm_writeback_connector *wb_conn =
> + &intel_wd->wb_conn;
> + drm_writeback_signal_completion(wb_conn, status); }
Closing bracket should come on next line.
> +
> +static int intel_wd_setup_transcoder(struct intel_wd *intel_wd,
> + struct intel_crtc_state *pipe_config,
> + struct drm_connector_state *conn_state,
> + struct drm_writeback_job *job)
> +{
> + struct intel_crtc *intel_crtc = to_intel_crtc(pipe_config->uapi.crtc);
> + enum pipe pipe = intel_crtc->pipe;
> + struct drm_framebuffer *fb;
> + struct drm_i915_private *dev_priv = to_i915(intel_crtc->base.dev);
> + struct drm_gem_object *wd_fb_obj;
> + int ret;
> + u32 stride, tmp;
> + u16 hactive, vactive;
> +
> + fb = job->fb;
> + wd_fb_obj = fb->obj[0];
> + if (!wd_fb_obj) {
> + drm_dbg_kms(&dev_priv->drm, "No framebuffer gem object
> created\n");
> + return -1;
EINVAL;
> + }
> +
> + ret = intel_wd_pin_fb(intel_wd, fb);
> + drm_WARN_ON(&dev_priv->drm, ret != 0);
> + /*Write stride and surface registers in that particular order*/
Please use proper commenting style
/* space followed by text and again space */
> + stride = intel_wd_get_stride(pipe_config, fb->format->format);
> +
> + tmp = intel_de_read(dev_priv, WD_STRIDE(intel_wd->trans));
> + tmp &= ~WD_STRIDE_MASK;
> + tmp |= (stride << WD_STRIDE_SHIFT);
> +
> + intel_de_write(dev_priv, WD_STRIDE(intel_wd->trans), tmp);
> +
> + tmp = intel_de_read(dev_priv, WD_SURF(intel_wd->trans));
> +
> + intel_de_write(dev_priv, WD_SURF(intel_wd->trans),
> + i915_ggtt_offset(intel_wd->vma));
> +
> + tmp = intel_de_read_fw(dev_priv, WD_IIR(intel_wd->trans));
> + intel_de_write_fw(dev_priv, WD_IIR(intel_wd->trans), tmp);
> +
> + tmp = ~(WD_GTT_FAULT_INT | WD_WRITE_COMPLETE_INT |
> WD_FRAME_COMPLETE_INT |
> + WD_VBLANK_INT | WD_OVERRUN_INT |
> WD_CAPTURING_INT);
> + intel_de_write_fw(dev_priv, WD_IMR(intel_wd->trans), tmp);
> +
> + if (intel_wd->stream_cap) {
> + tmp = intel_de_read(dev_priv,
> + WD_STREAMCAP_CTL(intel_wd->trans));
> + tmp |= WD_STREAM_CAP_MODE_EN;
> + intel_configure_slicing_strategy(dev_priv, intel_wd, &tmp);
> + }
> +
> + hactive = pipe_config->uapi.mode.hdisplay;
> + vactive = pipe_config->uapi.mode.vdisplay;
> + tmp = intel_de_read(dev_priv, HTOTAL(intel_wd->trans));
> + tmp = intel_de_read(dev_priv, VTOTAL(intel_wd->trans));
> +
> + /* minimum hactive as per bspec: 64 pixels*/
Recheck on the commenting style
> + if (hactive < 64)
> + drm_err(&dev_priv->drm, "hactive is less then 64 pixels\n");
> +
> + intel_de_write(dev_priv, HTOTAL(intel_wd->trans), hactive - 1);
> + intel_de_write(dev_priv, VTOTAL(intel_wd->trans), vactive - 1);
> +
> + tmp = intel_de_read(dev_priv, WD_TRANS_FUNC_CTL(intel_wd-
> >trans));
> + /* select pixel format */
> + tmp &= ~WD_PIX_FMT_MASK;
> +
> + switch (fb->format->format) {
> + default:
> + fallthrough;
> + case DRM_FORMAT_YUYV:
> + tmp |= WD_PIX_FMT_YUYV;
> + break;
> + case DRM_FORMAT_XYUV8888:
> + tmp |= WD_PIX_FMT_XYUV8888;
> + break;
> + case DRM_FORMAT_XBGR8888:
> + case DRM_FORMAT_XRGB8888:
> + tmp |= WD_PIX_FMT_XBGR8888;
> + break;
> + case DRM_FORMAT_Y410:
> + tmp |= WD_PIX_FMT_Y410;
> + break;
> + case DRM_FORMAT_YUV422:
> + tmp |= WD_PIX_FMT_YUV422;
> + break;
> + case DRM_FORMAT_XBGR2101010:
> + tmp |= WD_PIX_FMT_XBGR2101010;
> + break;
> + case DRM_FORMAT_RGB565:
> + tmp |= WD_PIX_FMT_RGB565;
> + break;
> + }
> +
> + if (intel_wd->triggered_cap_mode)
> + tmp |= WD_TRIGGERED_CAP_MODE_ENABLE;
> +
> + if (intel_wd->stream_cap)
> + tmp |= WD_CTL_POINTER_DTDH;
> +
> + /*select input pipe*/
> + tmp &= ~WD_INPUT_SELECT_MASK;
> + switch (pipe) {
> + default:
> + fallthrough;
> + case PIPE_A:
> + tmp |= WD_INPUT_PIPE_A;
> + break;
> + case PIPE_B:
> + tmp |= WD_INPUT_PIPE_B;
> + break;
> + case PIPE_C:
> + tmp |= WD_INPUT_PIPE_C;
> + break;
> + case PIPE_D:
> + tmp |= WD_INPUT_PIPE_D;
> + break;
> + }
> +
> + /* enable DDI buffer */
> + if (!(tmp & TRANS_WD_FUNC_ENABLE))
> + tmp |= TRANS_WD_FUNC_ENABLE;
> +
> + intel_de_write(dev_priv, WD_TRANS_FUNC_CTL(intel_wd->trans),
> tmp);
> +
> + tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
> + ret = tmp & WD_TRANS_ACTIVE;
> + if (!ret) {
> + /*enable the transcoder */
> + tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
> + tmp |= WD_TRANS_ENABLE;
> + intel_de_write(dev_priv, PIPECONF(intel_wd->trans), tmp);
> +
> + /* wait for transcoder to be enabled */
> + if (intel_de_wait_for_set(dev_priv, PIPECONF(intel_wd-
> >trans),
> + WD_TRANS_ACTIVE, 10))
> + drm_err(&dev_priv->drm, "WD transcoder could not
> be enabled\n");
> + }
> +
> + return 0;
> +}
> +
> +static int intel_wd_capture(struct intel_wd *intel_wd,
> + struct intel_crtc_state *pipe_config,
> + struct drm_connector_state *conn_state,
> + struct drm_writeback_job *job)
> +{
> + u32 tmp;
> + struct drm_i915_private *i915 = to_i915(intel_wd->base.base.dev);
> + int ret = 0, status = 0;
> + struct intel_crtc *wd_crtc = intel_wd->wd_crtc;
> + unsigned long flags;
> +
> + if (!job->out_fence)
> + drm_dbg_kms(&i915->drm, "Not able to get out_fence for
> job\n");
> +
> + ret = intel_wd_setup_transcoder(intel_wd, pipe_config,
> + conn_state, job);
> +
> + if (ret < 0) {
> + drm_dbg_kms(&i915->drm,
> + "WD transcoder setup not completed aborting capture\n");
> + return -1;
> + }
> +
> + if (!wd_crtc) {
> + drm_err(&i915->drm, "CRTC not attached\n");
> + return -1;
> + }
> +
> + tmp = intel_de_read_fw(i915,
> + WD_TRANS_FUNC_CTL(intel_wd->trans));
> + tmp |= START_TRIGGER_FRAME;
> + tmp &= ~WD_FRAME_NUMBER_MASK;
> + tmp |= intel_wd->frame_num;
> + intel_de_write_fw(i915,
> + WD_TRANS_FUNC_CTL(intel_wd->trans), tmp);
> +
> + if (!intel_de_wait_for_set(i915, WD_IIR(intel_wd->trans),
> + WD_FRAME_COMPLETE_INT, 100)){
> + drm_dbg_kms(&i915->drm, "frame captured\n");
> + status = 0;
> + } else {
> + drm_dbg_kms(&i915->drm, "frame not captured triggering
> stop frame\n");
> + tmp = intel_de_read(i915,
> + WD_TRANS_FUNC_CTL(intel_wd->trans));
> + tmp |= STOP_TRIGGER_FRAME;
> + intel_de_write(i915,
> + WD_TRANS_FUNC_CTL(intel_wd->trans),
> tmp);
> + status = -1;
> + }
> +
> + intel_wd_writeback_complete(intel_wd, job, status);
> + if (wd_crtc->wd.e) {
> + spin_lock_irqsave(&i915->drm.event_lock, flags);
> + drm_dbg_kms(&i915->drm, "send %p\n", wd_crtc->wd.e);
> + drm_crtc_send_vblank_event(&wd_crtc->base,
> + wd_crtc->wd.e);
> + spin_unlock_irqrestore(&i915->drm.event_lock, flags);
> + wd_crtc->wd.e = NULL;
> + } else {
> + drm_err(&i915->drm, "Event NULL! %p, %p\n", &i915->drm,
> + wd_crtc);
> + }
> + if (!intel_get_writeback_job_from_queue(intel_wd))
> + intel_wd_disable_capture(intel_wd);
> + return 0;
> +}
> +
> +void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
> + struct drm_connector_state *conn_state) {
> + struct drm_i915_private *i915 =
> + to_i915(conn_state->connector->dev);
> + struct drm_writeback_connector *wb_conn =
> + drm_connector_to_writeback(conn_state->connector);
> + struct intel_wd *intel_wd = wb_conn_to_intel_wd(wb_conn);
> + struct drm_writeback_job *job;
> +
> + job = intel_get_writeback_job_from_queue(intel_wd);
> + if (!job) {
> + drm_dbg_kms(&i915->drm,
> + "job queue is empty not capturing any frame\n");
> + return;
> + }
> +
> + intel_wd_capture(intel_wd, pipe_config,
> + conn_state, job);
> + intel_wd->frame_num += 1;
> +}
> +
> +void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct
> intel_crtc *intel_crtc,
> + struct intel_crtc_state *intel_crtc_state) {
> + struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
> + struct drm_crtc_state *crtc_state = &intel_crtc_state->uapi;
> + struct intel_encoder *encoder;
> + struct intel_wd *intel_wd;
> + struct drm_connector_state *conn_state;
> + struct drm_connector *connector;
> + int i;
> +
> + for_each_intel_encoder(&i915->drm, encoder) {
> + if (encoder->type != INTEL_OUTPUT_WD)
> + continue;
> +
> + intel_wd = enc_to_intel_wd(encoder);
> + if (!intel_wd->wd_crtc)
> + return;
> + }
> +
> + if (intel_wd && intel_crtc == intel_wd->wd_crtc) {
> + for_each_new_connector_in_state(&state->base, connector,
> conn_state,
> + i) {
> + if (!conn_state->writeback_job)
> + continue;
> +
> + intel_crtc->wd.e = crtc_state->event;
> + crtc_state->event = NULL;
> + }
> + }
> +}
> +
> +void intel_wd_handle_isr(struct drm_i915_private *i915) {
> + u32 iir_value = 0;
> + struct intel_encoder *encoder;
> + struct intel_wd *intel_wd;
> +
> + iir_value = intel_de_read(i915, WD_IIR(TRANSCODER_WD_0));
> +
> + for_each_intel_encoder(&i915->drm, encoder) {
> +
> + if (encoder->type != INTEL_OUTPUT_WD)
> + continue;
> +
> + intel_wd = enc_to_intel_wd(encoder);
> + if (!intel_wd->wd_crtc) {
> + drm_err(&i915->drm, "NO CRTC attached with
> WD\n");
> + goto clear_iir;
> + }
> + }
> +
> + if (iir_value & WD_FRAME_COMPLETE_INT)
> + return;
> +
> +clear_iir:
> + intel_de_write(i915, WD_IIR(TRANSCODER_WD_0), iir_value); }
> diff --git a/drivers/gpu/drm/i915/display/intel_wd.h
> b/drivers/gpu/drm/i915/display/intel_wd.h
> new file mode 100644
> index 000000000000..0fcd1a746593
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/display/intel_wd.h
> @@ -0,0 +1,48 @@
> +/* SPDX-License-Identifier: MIT*/
> +/*
> + * Copyright © 2022 Intel Corporation
> + */
> +
> +#ifndef _INTEL_WD_H
> +#define _INTEL_WD_H
> +
> +#include <drm/drm_crtc.h>
> +
> +#include "intel_display_types.h"
> +
> +#define I915_MAX_WD_TANSCODERS 2
> +
> +struct intel_wd {
> + struct intel_encoder base;
> + struct drm_writeback_connector wb_conn;
> + struct intel_crtc *wd_crtc;
> + intel_wakeref_t io_wakeref[I915_MAX_WD_TANSCODERS];
> + enum transcoder trans;
> + struct i915_vma *vma;
> + unsigned long flags;
> + struct drm_writeback_job *job;
> + int triggered_cap_mode;
> + int frame_num;
> + bool stream_cap;
> + bool start_capture;
> + int slicing_strategy;
> +};
> +
> +static inline struct intel_wd *enc_to_intel_wd(struct intel_encoder
> +*encoder) {
> + return container_of(&encoder->base, struct intel_wd, base.base); }
> +
> +static inline struct intel_wd *wb_conn_to_intel_wd(struct
> +drm_writeback_connector *wb_conn) {
> + return container_of(wb_conn, struct intel_wd, wb_conn); }
> +
> +void intel_wd_init(struct drm_i915_private *dev_priv, enum transcoder
> +trans); void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
> + struct drm_connector_state *conn_state); void
> +intel_wd_handle_isr(struct drm_i915_private *dev_priv); void
> +intel_wd_set_vblank_event(struct intel_atomic_state *state, struct
> intel_crtc *crtc,
> + struct intel_crtc_state *crtc_state); struct
> drm_writeback_job
> +*intel_get_writeback_job_from_queue(struct intel_wd *intel_wd);
> +#endif/* _INTEL_WD_H */
> diff --git a/drivers/gpu/drm/i915/i915_drv.h
> b/drivers/gpu/drm/i915/i915_drv.h index 086bbe8945d6..73ef94757fc8
> 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -35,6 +35,7 @@
> #include <linux/pm_qos.h>
>
> #include <drm/drm_connector.h>
> +#include <drm/drm_writeback.h>
> #include <drm/ttm/ttm_device.h>
>
> #include "display/intel_cdclk.h"
> diff --git a/drivers/gpu/drm/i915/i915_irq.c
> b/drivers/gpu/drm/i915/i915_irq.c index 0389f532d926..6504ef528d90
> 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -42,6 +42,7 @@
> #include "display/intel_hotplug.h"
> #include "display/intel_lpe_audio.h"
> #include "display/intel_psr.h"
> +#include "display/intel_wd.h"
>
> #include "gt/intel_breadcrumbs.h"
> #include "gt/intel_gt.h"
> @@ -2342,6 +2343,11 @@ gen8_de_misc_irq_handler(struct
> drm_i915_private *dev_priv, u32 iir)
> found = true;
> }
>
> + if (iir & GEN8_DE_MISC_WD0) {
> + intel_wd_handle_isr(dev_priv);
> + found = true;
> + }
> +
> if (iir & GEN8_DE_EDP_PSR) {
> struct intel_encoder *encoder;
> u32 psr_iir;
> @@ -3767,7 +3773,7 @@ static void gen8_de_irq_postinstall(struct
> drm_i915_private *dev_priv)
> u32 de_pipe_enables;
> u32 de_port_masked = gen8_de_port_aux_mask(dev_priv);
> u32 de_port_enables;
> - u32 de_misc_masked = GEN8_DE_EDP_PSR;
> + u32 de_misc_masked = GEN8_DE_EDP_PSR | GEN8_DE_MISC_WD0;
> u32 trans_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
> BIT(TRANSCODER_C) | BIT(TRANSCODER_D);
> enum pipe pipe;
> diff --git a/drivers/gpu/drm/i915/i915_pci.c
> b/drivers/gpu/drm/i915/i915_pci.c index aacc10f2e73f..636ce7819021
> 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -864,7 +864,8 @@ static const struct intel_device_info jsl_info = {
> .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) |
> BIT(PIPE_D), \
> .display.cpu_transcoder_mask = BIT(TRANSCODER_A) |
> BIT(TRANSCODER_B) | \
> BIT(TRANSCODER_C) | BIT(TRANSCODER_D) | \
> - BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1), \
> + BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1) | \
> + BIT(TRANSCODER_WD_0), \
> .display.pipe_offsets = { \
> [TRANSCODER_A] = PIPE_A_OFFSET, \
> [TRANSCODER_B] = PIPE_B_OFFSET, \
> @@ -872,6 +873,8 @@ static const struct intel_device_info jsl_info = {
> [TRANSCODER_D] = PIPE_D_OFFSET, \
> [TRANSCODER_DSI_0] = PIPE_DSI0_OFFSET, \
> [TRANSCODER_DSI_1] = PIPE_DSI1_OFFSET, \
> + [TRANSCODER_WD_0] = PIPE_WD0_OFFSET, \
> + [TRANSCODER_WD_1] = PIPE_WD1_OFFSET, \
> }, \
> .display.trans_offsets = { \
> [TRANSCODER_A] = TRANSCODER_A_OFFSET, \ @@ -880,6
> +883,8 @@ static const struct intel_device_info jsl_info = {
> [TRANSCODER_D] = TRANSCODER_D_OFFSET, \
> [TRANSCODER_DSI_0] = TRANSCODER_DSI0_OFFSET, \
> [TRANSCODER_DSI_1] = TRANSCODER_DSI1_OFFSET, \
> + [TRANSCODER_WD_0] = TRANSCODER_WD0_OFFSET, \
> + [TRANSCODER_WD_1] = TRANSCODER_WD1_OFFSET, \
> }, \
> TGL_CURSOR_OFFSETS, \
> .has_global_mocs = 1, \
> --
> 2.25.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: Enabling WD Transcoder
2022-09-12 8:07 ` Murthy, Arun R
@ 2022-09-12 9:28 ` Kandpal, Suraj
0 siblings, 0 replies; 13+ messages in thread
From: Kandpal, Suraj @ 2022-09-12 9:28 UTC (permalink / raw)
To: Murthy, Arun R, intel-gfx; +Cc: Nikula, Jani
Hi Arun,
> General: I think 'wd' has to be replaced with 'wb' which mean writeback
>
Okay ill replace wd with wb .
> > From: Suraj Kandpal <suraj.kandpal@intel.com>
> >
> > Adding support for writeback transcoder to start capturing frames
> > using interrupt mechanism
> >
> > Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> > ---
> > drivers/gpu/drm/i915/Makefile | 1 +
> > drivers/gpu/drm/i915/display/intel_acpi.c | 1 +
> > drivers/gpu/drm/i915/display/intel_crtc.c | 6 +
> > .../drm/i915/display/intel_crtc_state_dump.c | 1 +
> > drivers/gpu/drm/i915/display/intel_ddi.c | 6 +
> > drivers/gpu/drm/i915/display/intel_display.c | 65 +-
> > drivers/gpu/drm/i915/display/intel_display.h | 5 +
> > .../drm/i915/display/intel_display_debugfs.c | 13 +-
> > .../drm/i915/display/intel_display_types.h | 6 +
> > drivers/gpu/drm/i915/display/intel_dpll.c | 6 +
> > .../drm/i915/display/intel_modeset_setup.c | 103 ++-
> > .../drm/i915/display/intel_modeset_verify.c | 17 +-
> > drivers/gpu/drm/i915/display/intel_opregion.c | 3 +
> > .../gpu/drm/i915/display/intel_wb_connector.h | 20 +
> > drivers/gpu/drm/i915/display/intel_wd.c | 699 ++++++++++++++++++
> > drivers/gpu/drm/i915/display/intel_wd.h | 48 ++
> > drivers/gpu/drm/i915/i915_drv.h | 1 +
> > drivers/gpu/drm/i915/i915_irq.c | 8 +-
> > drivers/gpu/drm/i915/i915_pci.c | 7 +-
> > 19 files changed, 970 insertions(+), 46 deletions(-) create mode
> > 100644 drivers/gpu/drm/i915/display/intel_wb_connector.h
> > create mode 100644 drivers/gpu/drm/i915/display/intel_wd.c
> > create mode 100644 drivers/gpu/drm/i915/display/intel_wd.h
> >
> > diff --git a/drivers/gpu/drm/i915/Makefile
> > b/drivers/gpu/drm/i915/Makefile index 522ef9b4aff3..ec63ed16c250
> > 100644
> > --- a/drivers/gpu/drm/i915/Makefile
> > +++ b/drivers/gpu/drm/i915/Makefile
> > @@ -302,6 +302,7 @@ i915-y += \
> > display/intel_tv.o \
> > display/intel_vdsc.o \
> > display/intel_vrr.o \
> > + display/intel_wd.o \
> > display/vlv_dsi.o \
> > display/vlv_dsi_pll.o
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c
> > b/drivers/gpu/drm/i915/display/intel_acpi.c
> > index e78430001f07..ae08db164f73 100644
> > --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> > +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> > @@ -247,6 +247,7 @@ static u32 acpi_display_type(struct
> > intel_connector
> > *connector)
> > case DRM_MODE_CONNECTOR_LVDS:
> > case DRM_MODE_CONNECTOR_eDP:
> > case DRM_MODE_CONNECTOR_DSI:
> > + case DRM_MODE_CONNECTOR_WRITEBACK:
> > display_type = ACPI_DISPLAY_TYPE_INTERNAL_DIGITAL;
> > break;
> > case DRM_MODE_CONNECTOR_Unknown:
> > diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c
> > b/drivers/gpu/drm/i915/display/intel_crtc.c
> > index 6792a9056f46..66d552758720 100644
> > --- a/drivers/gpu/drm/i915/display/intel_crtc.c
> > +++ b/drivers/gpu/drm/i915/display/intel_crtc.c
> > @@ -491,6 +491,9 @@ void intel_pipe_update_start(struct
> > intel_crtc_state
> > *new_crtc_state)
> > if (new_crtc_state->do_async_flip)
> > return;
> >
> > + if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
> > + return;
> > +
> > if (intel_crtc_needs_vblank_work(new_crtc_state))
> > intel_crtc_vblank_work_init(new_crtc_state);
> >
> > @@ -638,6 +641,9 @@ void intel_pipe_update_end(struct intel_crtc_state
> > *new_crtc_state)
> > if (new_crtc_state->do_async_flip)
> > return;
> >
> > + if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
> > + return;
> > +
> > trace_intel_pipe_update_end(crtc, end_vbl_count, scanline_end);
> >
> > /*
> > diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> > b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> > index e9212f69c360..8435065f3b7d 100644
> > --- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> > +++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> > @@ -71,6 +71,7 @@ static const char * const output_type_str[] = {
> > OUTPUT_TYPE(DSI),
> > OUTPUT_TYPE(DDI),
> > OUTPUT_TYPE(DP_MST),
> > + OUTPUT_TYPE(WD),
> > };
> >
> > #undef OUTPUT_TYPE
> > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
> > b/drivers/gpu/drm/i915/display/intel_ddi.c
> > index a4c8493f3ce7..1360406ca531 100644
> > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > @@ -1974,6 +1974,12 @@ void
> > intel_ddi_sanitize_encoder_pll_mapping(struct intel_encoder *encoder)
> > */
> > if (encoder->type == INTEL_OUTPUT_DP_MST)
> > return;
> > + /*
> > + * WD transcoder is a virtual encoder hence sanization
> > + * is not required for it
> > + */
>
>
> WD transcoder doesn’t have any encoder, hence assigning a virtual encoder.
>
But this is not the place we assign it virtual encoder here we just avoid the sanitization as
a virtual encoder is assigned to WD transcoder
so wouldn’t the current comment be more appropriate
> > + if (encoder->type == INTEL_OUTPUT_WD)
> > + return;
> >
> > if (!encoder->base.crtc && intel_encoder_is_dp(encoder)) {
> > u8 pipe_mask;
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> > b/drivers/gpu/drm/i915/display/intel_display.c
> > index f143adefdf38..52fb23846856 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -115,6 +115,7 @@
> > #include "intel_sprite.h"
> > #include "intel_tc.h"
> > #include "intel_vga.h"
> > +#include "intel_wd.h"
> > #include "i9xx_plane.h"
> > #include "skl_scaler.h"
> > #include "skl_universal_plane.h"
> > @@ -1510,6 +1511,9 @@ static void
> intel_encoders_update_prepare(struct
> > intel_atomic_state *state)
> > continue;
> >
> > intel_connector = to_intel_connector(connector);
> Can you add a comment here saying for WD intel_connector is not created!
>
Would it be needed because to_intel_connector will be used at many places
going forward to which may set an expectation to add the intel_connector not
created comment
also the next line of code implies there is a chance the intel_connector may comeback null
> > + if (!intel_connector)
> > + continue;
> > +
> > encoder =
> > intel_connector_primary_encoder(intel_connector);
> > if (!encoder->update_prepare)
> > continue;
> > @@ -1539,6 +1543,9 @@ static void
> > intel_encoders_update_complete(struct
> > intel_atomic_state *state)
> > continue;
> >
> > intel_connector = to_intel_connector(connector);
>
>
> Same here a comment!
>
> > + if (!intel_connector)
> > + continue;
> > +
> > encoder =
> > intel_connector_primary_encoder(intel_connector);
> > if (!encoder->update_complete)
> > continue;
> > @@ -1549,6 +1556,39 @@ static void
> > intel_encoders_update_complete(struct intel_atomic_state *state)
> > }
> > }
> >
> > +static void intel_queue_writeback_job(struct intel_atomic_state *state,
> > + struct intel_crtc *intel_crtc, struct intel_crtc_state
> *crtc_state)
>
> Can this intel_crtc_state be eliminated, anyway later it the function it can be
> obtained from intel_atomic_state!
> Moreover crtc_state and intel_crtc is not being used at all.
Sure will remove the unused structures
>
> > {
> > + struct drm_connector_state *new_conn_state;
> > + struct drm_connector *connector;
> > + struct drm_writeback_connector *wb_conn;
> > + int i;
> > +
> > + for_each_new_connector_in_state(&state->base, connector,
> > new_conn_state,
> > + i) {
> > + if (!new_conn_state->writeback_job)
> > + continue;
> > +
> > + wb_conn = drm_connector_to_writeback(connector);
> > + drm_writeback_queue_job(wb_conn, new_conn_state);
> > + }
> > +}
> > +
> > +static void intel_enable_writeback_capture(struct intel_atomic_state
> *state,
> > + struct intel_crtc *intel_crtc, struct intel_crtc_state
> *crtc_state)
>
> Same here, can crtc_state can be eliminated and later obtain it from
> intel_atomic_state.
To derive it from intel_atomic_state ill have to run a loop to get this crtc_state
Which seems inefficient as it is already being called inside a for_each_intel_crtc loop
> Intel_crtc is not being used.
This variable I can get rid off.
>
> > {
> > + struct drm_connector_state *new_conn_state;
> > + struct drm_connector *connector;
> > + int i;
> > +
> > + for_each_new_connector_in_state(&state->base, connector,
> > new_conn_state,
> > + i) {
> > + if (connector->connector_type !=
> > DRM_MODE_CONNECTOR_WRITEBACK)
> > + continue;
> > + intel_wd_enable_capture(crtc_state, new_conn_state);
> > + }
> > +}
> > +
> > static void intel_encoders_pre_pll_enable(struct intel_atomic_state
> *state,
> > struct intel_crtc *crtc)
> > {
> > @@ -1649,8 +1689,12 @@ static void intel_encoders_post_disable(struct
> > intel_atomic_state *state,
> > int i;
> >
> > for_each_old_connector_in_state(&state->base, conn,
> old_conn_state,
> > i) {
> > - struct intel_encoder *encoder =
> > - to_intel_encoder(old_conn_state->best_encoder);
> > + struct intel_encoder *encoder;
> > +
> > + if (conn->connector_type ==
> > DRM_MODE_CONNECTOR_WRITEBACK)
> > + continue;
> > +
> > + encoder = to_intel_encoder(old_conn_state-
> >best_encoder);
> >
> > if (old_conn_state->crtc != &crtc->base)
> > continue;
> > @@ -1927,7 +1971,8 @@ static void hsw_crtc_enable(struct
> > intel_atomic_state *state,
> > bdw_set_pipemisc(new_crtc_state);
> >
> > if (!intel_crtc_is_bigjoiner_slave(new_crtc_state) &&
> > - !transcoder_is_dsi(cpu_transcoder))
> > + !transcoder_is_dsi(cpu_transcoder) &&
> > + !transcoder_is_wd(cpu_transcoder))
> > hsw_configure_cpu_transcoder(new_crtc_state);
> >
> > crtc->active = true;
> > @@ -7575,6 +7620,12 @@ static void intel_atomic_commit_tail(struct
> > intel_atomic_state *state)
> > }
> > }
> >
> > + for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
> > + if (!(new_crtc_state->output_types &
> > BIT(INTEL_OUTPUT_WD)))
> > + continue;
> > + intel_wd_set_vblank_event(state, crtc, new_crtc_state);
>
> For compiler optimization purpose can this be changed to if
> ((new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD)))
> intel_wd_set_vblank_event(state, crtc, new_crtc_state);
>
Sure will get this done
> > + }
> > +
> > intel_encoders_update_prepare(state);
> >
> > intel_dbuf_pre_plane_update(state);
> > @@ -7585,6 +7636,13 @@ static void intel_atomic_commit_tail(struct
> > intel_atomic_state *state)
> > intel_crtc_enable_flip_done(state, crtc);
> > }
> >
> > + for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
> > + if (!(new_crtc_state->output_types &
> > BIT(INTEL_OUTPUT_WD)))
> > + continue;
> > + intel_queue_writeback_job(state, crtc, new_crtc_state);
> > + intel_enable_writeback_capture(state, crtc,
> new_crtc_state);
> > + }
>
> Same here, since we are focusing on WD over here, so lets have a check for
> WD and avoid continue.
> Other way would be to add kernel optimization unlikely for the if condition.
>
Okay will go ahead and make that change
> > +
> > /* Now enable the clocks, plane, pipe, and connectors that we set
> > up. */
> > dev_priv->display->commit_modeset_enables(state);
> >
> > @@ -7965,6 +8023,7 @@ static void intel_setup_outputs(struct
> > drm_i915_private *dev_priv)
> > intel_ddi_init(dev_priv, PORT_TC1);
> > intel_ddi_init(dev_priv, PORT_TC2);
> > } else if (DISPLAY_VER(dev_priv) >= 12) {
> > + intel_wd_init(dev_priv, TRANSCODER_WD_0);
>
> Can this be moved outside of the if else condition. Since this is whole lot does
> the port initialization and the newly added does the WD transcoder
> initialization.
The ddi init also initializes the the connectors for the respective ports so this
seemed like a appropriate place to init our wd transcoder we want to additionally
we want it initialized on for tgl gen.
>
> > intel_ddi_init(dev_priv, PORT_A);
> > intel_ddi_init(dev_priv, PORT_B);
> > intel_ddi_init(dev_priv, PORT_TC1); diff --git
> > a/drivers/gpu/drm/i915/display/intel_display.h
> > b/drivers/gpu/drm/i915/display/intel_display.h
> > index 3b9987b5f304..4879ca2e96f7 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display.h
> > @@ -158,6 +158,11 @@ static inline bool transcoder_is_dsi(enum
> > transcoder transcoder)
> > return transcoder == TRANSCODER_DSI_A || transcoder ==
> > TRANSCODER_DSI_C; }
> >
> > +static inline bool transcoder_is_wd(enum transcoder transcoder) {
> > + return transcoder == TRANSCODER_WD_0 || transcoder ==
> > TRANSCODER_WD_1;
> > +}
> > +
> > /*
> > * Global legacy plane identifier. Valid only for primary/sprite
> > * planes on pre-g4x, and only for primary planes on g4x-bdw.
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > index 225b6bfc783c..0dad54058762 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> > @@ -547,7 +547,7 @@ static void intel_hdmi_info(struct seq_file *m,
> > static void intel_connector_info(struct seq_file *m,
> > struct drm_connector *connector) {
> > - struct intel_connector *intel_connector =
> > to_intel_connector(connector);
> > + struct intel_connector *intel_connector;
> > const struct drm_connector_state *conn_state = connector->state;
> > struct intel_encoder *encoder =
> > to_intel_encoder(conn_state->best_encoder);
> > @@ -570,6 +570,8 @@ static void intel_connector_info(struct seq_file *m,
> > if (!encoder)
> > return;
> >
> > + intel_connector = to_intel_connector(connector);
> > +
> > switch (connector->connector_type) {
> > case DRM_MODE_CONNECTOR_DisplayPort:
> > case DRM_MODE_CONNECTOR_eDP:
> > @@ -587,12 +589,15 @@ static void intel_connector_info(struct seq_file
> *m,
> > break;
> > }
> >
> > - seq_puts(m, "\tHDCP version: ");
> > - intel_hdcp_info(m, intel_connector);
> > + if (intel_connector) {
> > + seq_puts(m, "\tHDCP version: ");
> > + intel_hdcp_info(m, intel_connector);
> > + }
> >
> > seq_printf(m, "\tmax bpc: %u\n", connector->display_info.bpc);
> >
> > - intel_panel_info(m, intel_connector);
> > + if (intel_connector)
> > + intel_panel_info(m, intel_connector);
> >
> > seq_printf(m, "\tmodes:\n");
> > list_for_each_entry(mode, &connector->modes, head) diff --git
> > a/drivers/gpu/drm/i915/display/intel_display_types.h
> > b/drivers/gpu/drm/i915/display/intel_display_types.h
> > index 7a82b7acbaf2..7b550c532dfb 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> > @@ -44,6 +44,7 @@
> > #include <drm/drm_vblank.h>
> > #include <drm/drm_vblank_work.h>
> > #include <drm/i915_mei_hdcp_interface.h>
> > +#include <drm/drm_writeback.h>
> > #include <media/cec-notifier.h>
> >
> > #include "i915_vma.h"
> > @@ -1370,6 +1371,11 @@ struct intel_crtc {
> > bool cpu_fifo_underrun_disabled;
> > bool pch_fifo_underrun_disabled;
> >
> > + struct {
> > + struct drm_pending_vblank_event *e;
> > + atomic_t work_busy;
> > + wait_queue_head_t wd_wait;
> > + } wd;
> > /* per-pipe watermark state */
> > struct {
> > /* watermarks currently being used */ diff --git
> > a/drivers/gpu/drm/i915/display/intel_dpll.c
> > b/drivers/gpu/drm/i915/display/intel_dpll.c
> > index 5262f16b45ac..82bb8e170197 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dpll.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dpll.c
> > @@ -939,6 +939,9 @@ static int hsw_crtc_compute_clock(struct
> > intel_atomic_state *state,
> > struct intel_encoder *encoder =
> > intel_get_crtc_new_encoder(state, crtc_state);
> >
> > + if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_WD))
> > + return 0;
> > +
> > if (DISPLAY_VER(dev_priv) < 11 &&
> > intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI))
> > return 0;
> > @@ -955,6 +958,9 @@ static int hsw_crtc_get_shared_dpll(struct
> > intel_atomic_state *state,
> > struct intel_encoder *encoder =
> > intel_get_crtc_new_encoder(state, crtc_state);
> >
> > + if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_WD))
> > + return 0;
> > +
> > if (DISPLAY_VER(dev_priv) < 11 &&
> > intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI))
> > return 0;
> > diff --git a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > index 985dfa5f7aa1..0e48c1a31024 100644
> > --- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > +++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > @@ -23,6 +23,7 @@
> > #include "intel_modeset_setup.h"
> > #include "intel_pch_display.h"
> > #include "intel_pm.h"
> > +#include "intel_wd.h"
> >
> > static void intel_crtc_disable_noatomic(struct intel_crtc *crtc,
> > struct drm_modeset_acquire_ctx
> > *ctx) @@ -110,17 +111,17 @@ static void
> > intel_crtc_disable_noatomic(struct
> > intel_crtc *crtc,
> >
> > static void intel_modeset_update_connector_atomic_state(struct
> > drm_i915_private *i915) {
> > - struct intel_connector *connector;
> > + struct drm_connector *connector;
> > struct drm_connector_list_iter conn_iter;
> >
> > drm_connector_list_iter_begin(&i915->drm, &conn_iter);
> > - for_each_intel_connector_iter(connector, &conn_iter) {
> > - struct drm_connector_state *conn_state = connector-
> > >base.state;
> > + drm_for_each_connector_iter(connector, &conn_iter) {
> > + struct drm_connector_state *conn_state = connector-
> >state;
> > struct intel_encoder *encoder =
> > - to_intel_encoder(connector->base.encoder);
> > + to_intel_encoder(connector->encoder);
> >
> > if (conn_state->crtc)
> > - drm_connector_put(&connector->base);
> > + drm_connector_put(connector);
> >
> > if (encoder) {
> > struct intel_crtc *crtc =
> > @@ -132,7 +133,7 @@ static void
> > intel_modeset_update_connector_atomic_state(struct drm_i915_private
> > conn_state->crtc = &crtc->base;
> > conn_state->max_bpc = (crtc_state->pipe_bpp ?: 24)
> / 3;
> >
> > - drm_connector_get(&connector->base);
> > + drm_connector_get(connector);
> > } else {
> > conn_state->best_encoder = NULL;
> > conn_state->crtc = NULL;
> > @@ -432,6 +433,8 @@ static void intel_modeset_readout_hw_state(struct
> > drm_i915_private *i915)
> > struct intel_crtc *crtc;
> > struct intel_encoder *encoder;
> > struct intel_connector *connector;
> > + struct drm_connector *_connector;
> > + struct drm_encoder *_encoder;
> > struct drm_connector_list_iter conn_iter;
> > u8 active_pipes = 0;
> >
> > @@ -508,38 +511,70 @@ static void
> > intel_modeset_readout_hw_state(struct drm_i915_private *i915)
> > intel_dpll_readout_hw_state(i915);
> >
> > drm_connector_list_iter_begin(&i915->drm, &conn_iter);
> > - for_each_intel_connector_iter(connector, &conn_iter) {
> > - if (connector->get_hw_state(connector)) {
> > - struct intel_crtc_state *crtc_state;
> > - struct intel_crtc *crtc;
> > -
> > - connector->base.dpms = DRM_MODE_DPMS_ON;
> > -
> > - encoder = intel_attached_encoder(connector);
> > - connector->base.encoder = &encoder->base;
> > -
> > - crtc = to_intel_crtc(encoder->base.crtc);
> > - crtc_state = crtc ? to_intel_crtc_state(crtc-
> > >base.state) : NULL;
> > -
> > - if (crtc_state && crtc_state->hw.active) {
> > - /*
> > - * This has to be done during hardware
> > readout
> > - * because anything calling .crtc_disable may
> > - * rely on the connector_mask being
> > accurate.
> > - */
> > - crtc_state->uapi.connector_mask |=
> > - drm_connector_mask(&connector-
> > >base);
> > - crtc_state->uapi.encoder_mask |=
> > - drm_encoder_mask(&encoder-
> > >base);
> > + drm_for_each_connector_iter(_connector, &conn_iter) {
> > + struct intel_crtc_state *crtc_state;
> > + struct intel_crtc *crtc;
> > + struct drm_writeback_connector *wb_conn;
> > + struct intel_wd *intel_wd;
> > +
> > + connector = to_intel_connector(_connector);
> > + if (!connector) {
> > + wb_conn =
> > drm_connector_to_writeback(_connector);
> > + intel_wd = wb_conn_to_intel_wd(wb_conn);
> > + _encoder = &intel_wd->base.base;
> > + _connector->encoder = _encoder;
> > + encoder = to_intel_encoder(_encoder);
> > + pipe = 0;
> > + if (encoder->get_hw_state(encoder, &pipe)) {
> > + _connector->dpms =
> > DRM_MODE_DPMS_ON;
> > + crtc = to_intel_crtc(_encoder->crtc);
> > + crtc_state = crtc ? to_intel_crtc_state(crtc-
> > >base.state) : NULL;
> > +
> > + if (crtc_state && crtc_state->hw.active) {
> > + /*
> > + * This has to be done during
> > hardware readout
> > + * because anything calling
> > .crtc_disable may
> > + * rely on the connector_mask being
> > accurate.
> > + */
> > + crtc_state->uapi.connector_mask |=
> > +
> > drm_connector_mask(&connector->base);
> > + crtc_state->uapi.encoder_mask |=
> > +
> > drm_encoder_mask(&encoder->base);
> > + }
> > + } else {
> > + _connector->dpms =
> > DRM_MODE_DPMS_OFF;
> > + _connector->encoder = NULL;
> > }
> > } else {
> > - connector->base.dpms = DRM_MODE_DPMS_OFF;
> > - connector->base.encoder = NULL;
> > + if (connector->get_hw_state(connector)) {
> > + connector->base.dpms =
> > DRM_MODE_DPMS_OFF;
> > + encoder =
> > intel_attached_encoder(connector);
> > + connector->base.encoder = &encoder-
> >base;
> > +
> > + crtc = to_intel_crtc(encoder->base.crtc);
> > + crtc_state = crtc ? to_intel_crtc_state(crtc-
> > >base.state) : NULL;
> > +
> > + if (crtc_state && crtc_state->hw.active) {
> > + /*
> > + * This has to be done during
> > hardware readout
> > + * because anything calling
> > .crtc_disable may
> > + * rely on the connector_mask being
> > accurate.
> > + */
> > + crtc_state->uapi.connector_mask |=
> > +
> > drm_connector_mask(&connector->base);
> > + crtc_state->uapi.encoder_mask |=
> > +
> > drm_encoder_mask(&encoder->base);
> > + }
> > + } else {
> > + connector->base.dpms =
> > DRM_MODE_DPMS_OFF;
> > + connector->base.encoder = NULL;
> > + }
> > }
> > drm_dbg_kms(&i915->drm,
> > - "[CONNECTOR:%d:%s] hw state readout: %s\n",
> > - connector->base.base.id, connector->base.name,
> > - str_enabled_disabled(connector->base.encoder));
> > + "[CONNECTOR:%d:%s] hw state readout:
> > %s\n",
> > + _connector->base.id, _connector->name,
> > + str_enabled_disabled(_connector-
> > >encoder));
> > +
>
>
> It becomes too huge, with if else for WD.
> Can we retain the existing as is for non-WD and add a new for loop to find
> out WD and readout hw state separately for WD.
In one of my previous versions I had it this way but Jani's concern was why we have a separate loop just
For WD
>
> > }
> > drm_connector_list_iter_end(&conn_iter);
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_modeset_verify.c
> > b/drivers/gpu/drm/i915/display/intel_modeset_verify.c
> > index a91586d77cb6..0e06daac74c1 100644
> > --- a/drivers/gpu/drm/i915/display/intel_modeset_verify.c
> > +++ b/drivers/gpu/drm/i915/display/intel_modeset_verify.c
> > @@ -25,11 +25,16 @@
> > static void intel_connector_verify_state(struct intel_crtc_state
> *crtc_state,
> > struct drm_connector_state
> > *conn_state) {
> > - struct intel_connector *connector = to_intel_connector(conn_state-
> > >connector);
> > - struct drm_i915_private *i915 = to_i915(connector->base.dev);
> > + struct drm_connector *_connector = conn_state->connector;
> > + struct intel_connector *connector;
> > + struct drm_i915_private *i915 = to_i915(_connector->dev);
> >
> > drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s]\n",
> > - connector->base.base.id, connector->base.name);
> > + _connector->base.id, _connector->name);
> > +
> > + connector = to_intel_connector(_connector);
> > + if (!connector)
> > + return;
> >
> > if (connector->get_hw_state(connector)) {
> > struct intel_encoder *encoder =
> > intel_attached_encoder(connector);
> > @@ -119,6 +124,9 @@ verify_encoder_state(struct drm_i915_private
> > *dev_priv, struct intel_atomic_stat
> > encoder->base.base.id,
> > encoder->base.name);
> >
> > + if (encoder->type == INTEL_OUTPUT_WD)
> > + continue;
> > +
> > for_each_oldnew_connector_in_state(&state->base,
> > connector, old_conn_state,
> > new_conn_state, i) {
> > if (old_conn_state->best_encoder == &encoder-
> > >base) @@ -177,6 +185,9 @@ verify_crtc_state(struct intel_crtc *crtc,
> >
> > intel_crtc_get_pipe_config(pipe_config);
> >
> > + if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
> > + return;
> > +
> > /* we keep both pipes enabled on 830 */
> > if (IS_I830(dev_priv) && pipe_config->hw.active)
> > pipe_config->hw.active = new_crtc_state->hw.active; diff --
> git
> > a/drivers/gpu/drm/i915/display/intel_opregion.c
> > b/drivers/gpu/drm/i915/display/intel_opregion.c
> > index 1c0c745c142d..73a5a12e2c48 100644
> > --- a/drivers/gpu/drm/i915/display/intel_opregion.c
> > +++ b/drivers/gpu/drm/i915/display/intel_opregion.c
> > @@ -374,6 +374,9 @@ int intel_opregion_notify_encoder(struct
> > intel_encoder *intel_encoder,
> > if (ret)
> > return ret;
> >
> > + if (intel_encoder->type == INTEL_OUTPUT_WD)
> > + return 0;
> > +
> > if (intel_encoder->type == INTEL_OUTPUT_DSI)
> > port = 0;
> > else
> > diff --git a/drivers/gpu/drm/i915/display/intel_wb_connector.h
> > b/drivers/gpu/drm/i915/display/intel_wb_connector.h
> > new file mode 100644
> > index 000000000000..39dceddc7b4d
> > --- /dev/null
> > +++ b/drivers/gpu/drm/i915/display/intel_wb_connector.h
>
> Should this be intel_wb.h?
I think this is not needed will remove this.
>
> > @@ -0,0 +1,20 @@
> > +/* SPDX-License-Identifier: MIT*/
> > +/*
> > + * Copyright © 2022 Intel Corporation */
> > +
> > +#ifndef __INTEL_WB_CONNECTOR_H__
> > +#define __INTEL_WB_CONNECTOR_H__
> > +
> > +#include "intel_display.h"
> > +
> > +struct intel_wb_connector *intel_wb_connector_alloc(void); void
> > +intel_wb_connector_free(struct intel_wb_connector *connector); void
> > +intel_wb_connector_destroy(struct drm_connector *connector); bool
> > +intel_wb_connector_get_hw_state(struct intel_wb_connector
> > +*connector); enum pipe intel_wb_connector_get_pipe(struct
> > +intel_wb_connector *connector); void
> > +intel_wb_connector_attach_encoder(struct
> > intel_wb_connector *connector,
> > + struct intel_encoder *encoder);
> > +
> > +#endif /* __INTEL_WB_CONNECTOR_H__ */
> > +
> > diff --git a/drivers/gpu/drm/i915/display/intel_wd.c
> > b/drivers/gpu/drm/i915/display/intel_wd.c
> > new file mode 100644
> > index 000000000000..a30cf1055db4
> > --- /dev/null
> > +++ b/drivers/gpu/drm/i915/display/intel_wd.c
> > @@ -0,0 +1,699 @@
> > +// SPDX-License-Identifier: MIT
> > +/*
> > + * Copyright © 2022 Intel Corporation */
> > +
> > +#include <drm/drm_atomic_helper.h>
> > +#include <drm/drm_fourcc.h>
> > +
> > +#include "intel_atomic.h"
> > +#include "intel_connector.h"
> > +#include "intel_wd.h"
> > +#include "intel_fb_pin.h"
> > +#include "intel_de.h"
> > +
> > +enum {
> > + WD_CAPTURE_4_PIX,
> > + WD_CAPTURE_2_PIX,
> > +} wd_capture_format;
> > +
> > +struct drm_writeback_job
> > +*intel_get_writeback_job_from_queue(struct intel_wd *intel_wd) {
> > + struct drm_writeback_job *job;
> > + struct drm_i915_private *i915 = to_i915(intel_wd->base.base.dev);
> > + struct drm_writeback_connector *wb_conn =
> > + &intel_wd->wb_conn;
> > + unsigned long flags;
> > +
> > + spin_lock_irqsave(&wb_conn->job_lock, flags);
> > + job = list_first_entry_or_null(&wb_conn->job_queue,
> > + struct drm_writeback_job,
> > + list_entry);
> > + spin_unlock_irqrestore(&wb_conn->job_lock, flags);
> > + if (job == NULL) {
> > + drm_dbg_kms(&i915->drm, "job queue is empty\n");
> > + return NULL;
> > + }
> > +
> > + return job;
> > +}
> > +
> > +/*Check with Spec*/
>
> Remove this and if you need to double check add a TODO:
>
sure
> > +static const u32 wb_fmts[] = {
> > + DRM_FORMAT_YUV444,
> > + DRM_FORMAT_XYUV8888,
> > + DRM_FORMAT_XBGR8888,
> > + DRM_FORMAT_XRGB8888,
> > + DRM_FORMAT_Y410,
> > + DRM_FORMAT_YUV422,
> > + DRM_FORMAT_XBGR2101010,
> > + DRM_FORMAT_RGB565,
> > +};
> > +
> > +static int intel_wd_get_format(int pixel_format) {
> > + int wd_format = -EINVAL;
> > +
> > + switch (pixel_format) {
> > + case DRM_FORMAT_XBGR8888:
> > + case DRM_FORMAT_XRGB8888:
> > + case DRM_FORMAT_XBGR2101010:
> > + case DRM_FORMAT_XYUV8888:
> > + case DRM_FORMAT_YUV444:
> > + wd_format = WD_CAPTURE_4_PIX;
> > + break;
> > + case DRM_FORMAT_YUV422:
> > + case DRM_FORMAT_RGB565:
> > + wd_format = WD_CAPTURE_2_PIX;
> > + break;
> > + default:
> > + DRM_ERROR("unsupported pixel format %x!\n",
> > + pixel_format);
> > + }
> > +
> > + return wd_format;
> > +}
> > +
> > +static int intel_wd_verify_pix_format(int format) {
> > + const struct drm_format_info *info = drm_format_info(format);
> > + int pix_format = info->format;
> > + int i = 0;
> > +
> > + for (i = 0; i < ARRAY_SIZE(wb_fmts); i++)
> > + if (pix_format == wb_fmts[i])
> > + return 0;
> > +
> > + return 1;
>
>
> return TRUE;
>
> > +}
> > +
> > +static u32 intel_wd_get_stride(const struct intel_crtc_state *crtc_state,
> > + int format)
> > +{
> > + const struct drm_format_info *info = drm_format_info(format);
> > + int wd_format;
> > + int hactive, pixel_size;
> > +
> > + wd_format = intel_wd_get_format(info->format);
> > +
> > + switch (wd_format) {
> > + case WD_CAPTURE_4_PIX:
> > + pixel_size = 4;
> > + break;
> > + case WD_CAPTURE_2_PIX:
> > + pixel_size = 2;
> > + break;
> > + default:
> > + pixel_size = 1;
> > + break;
> > + }
> > +
> > + hactive = crtc_state->hw.adjusted_mode.crtc_hdisplay;
> > +
> > + return DIV_ROUND_UP(hactive * pixel_size, 64); }
> > +
> > +static int intel_wd_pin_fb(struct intel_wd *intel_wd,
> > + struct drm_framebuffer *fb)
> > +{
> > + const struct i915_ggtt_view view = {
> > + .type = I915_GGTT_VIEW_NORMAL,
> > + };
> > + struct i915_vma *vma;
> > +
> > + vma = intel_pin_and_fence_fb_obj(fb, false, &view, false,
> > + &intel_wd->flags);
> > +
> > + if (IS_ERR(vma))
> > + return PTR_ERR(vma);
> > +
> > + intel_wd->vma = vma;
> > + return 0;
> > +}
> > +
> > +static void intel_configure_slicing_strategy(struct drm_i915_private
> > *dev_priv,
> > + struct intel_wd *intel_wd, u32 *tmp)
>
> Change dev_priv to i915
>
> > +{
> > + *tmp &= ~WD_STRAT_MASK;
> > + if (intel_wd->slicing_strategy == 1)
> > + *tmp |= WD_SLICING_STRAT_1_1;
> > + else if (intel_wd->slicing_strategy == 2)
> > + *tmp |= WD_SLICING_STRAT_2_1;
> > + else if (intel_wd->slicing_strategy == 3)
> > + *tmp |= WD_SLICING_STRAT_4_1;
> > + else if (intel_wd->slicing_strategy == 4)
> > + *tmp |= WD_SLICING_STRAT_8_1;
> > +
> > + intel_de_write(dev_priv, WD_STREAMCAP_CTL(intel_wd->trans),
> > + *tmp);
> > +}
> > +
> > +static enum drm_mode_status
> > +intel_wd_mode_valid(struct drm_connector *connector,
> > + struct drm_display_mode *mode)
> > +{
> > + drm_dbg_kms(connector->dev, ":");
> > + return MODE_OK;
> > +}
>
> Are you planning to add any logic over here? If so add a TODO/FIXME.
> If not then remove this.
No logic but this functions does not seems to be optional so need to
Send a mode_ok for whatever mode is sent to my by the userspace.
>
> > +
> > +static int intel_wd_get_modes(struct drm_connector *connector) {
> > + return 0;
> > +}
>
> Same as above.
>
Same isn't an optional hook hence this is needed
> > +
> > +static void intel_wd_get_config(struct intel_encoder *encoder,
> > + struct intel_crtc_state *pipe_config) {
> > + struct intel_crtc *intel_crtc =
> > + to_intel_crtc(pipe_config->uapi.crtc);
> > +
> > + if (intel_crtc) {
> > + memcpy(pipe_config, intel_crtc->config,
> > + sizeof(*pipe_config));
> > + pipe_config->output_types |= BIT(INTEL_OUTPUT_WD);
> > + }
> > +}
> > +
> > +static int intel_wd_compute_config(struct intel_encoder *encoder,
> > + struct intel_crtc_state *pipe_config,
> > + struct drm_connector_state *conn_state) {
> > + struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
> > + struct drm_writeback_job *job;
> > +
> > + job = intel_get_writeback_job_from_queue(intel_wd);
> > + if (job || conn_state->writeback_job) {
> > + intel_wd->wd_crtc = to_intel_crtc(pipe_config->uapi.crtc);
> > + return 0;
> > + }
> > +
> > + return 0;
> > +}
>
> Just assigning pipe/crtc to wd. Can this be commented?
Do you need me to add a comment saying "Just assigning pipe/crtc to wd"
>
> > +
> > +static void intel_wd_get_power_domains(struct intel_encoder *encoder,
> > + struct intel_crtc_state *crtc_state) {
> > + struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> > + struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
> > + intel_wakeref_t wakeref;
> > +
> > + wakeref = intel_display_power_get(i915,
> > + encoder->power_domain);
> > +
> > + intel_wd->io_wakeref[0] = wakeref;
> > +}
> > +
> > +static bool intel_wd_get_hw_state(struct intel_encoder *encoder,
> > + enum pipe *pipe)
> > +{
> > + bool ret = false;
> > + struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> > + struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
> > + struct intel_crtc *wd_crtc = intel_wd->wd_crtc;
> > + intel_wakeref_t wakeref;
> > + u32 tmp;
> > +
> > + if (wd_crtc)
> > + return false;
> > +
> > + wakeref = intel_display_power_get_if_enabled(dev_priv,
> > + encoder->power_domain);
> > +
> > + if (!wakeref)
> > + goto out;
> > +
> > + tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
> > + ret = tmp & WD_TRANS_ACTIVE;
> > + if (ret) {
> > + *pipe = wd_crtc->pipe;
> > + return true;
> > + }
> > +
> > +out:
> > + intel_display_power_put(dev_priv, encoder->power_domain,
> > wakeref);
> > + return false;
> > +}
> > +
> > +static int intel_wd_encoder_atomic_check(struct drm_encoder
> *encoder,
> > + struct drm_crtc_state *crtc_st,
> > + struct drm_connector_state *conn_st) {
> > + /* Check for the format and buffers and property validity */
> > + struct drm_framebuffer *fb;
> > + struct drm_writeback_job *job = conn_st->writeback_job;
> > + struct drm_i915_private *i915 = to_i915(encoder->dev);
> > + const struct drm_display_mode *mode = &crtc_st->mode;
> > + int ret;
> > +
> > + if (!job) {
> > + drm_dbg_kms(&i915->drm, "No writeback job created
> > returning\n");
> > + return -EINVAL;
> > + }
> > +
> > + fb = job->fb;
> > + if (!fb) {
> > + drm_dbg_kms(&i915->drm, "Invalid framebuffer\n");
> > + return -EINVAL;
> > + }
> > +
> > + if (fb->width != mode->hdisplay || fb->height != mode->vdisplay) {
> > + drm_dbg_kms(&i915->drm, "Invalid framebuffer size
> > %ux%u\n",
> > + fb->width, fb->height);
> > + return -EINVAL;
> > + }
> > +
> > + ret = intel_wd_verify_pix_format(fb->format->format);
> > + if (ret) {
> > + drm_dbg_kms(&i915->drm, "Unsupported framebuffer
> > format %08x\n",
> > + fb->format->format);
> > + return -EINVAL;
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +
> > +static const struct drm_encoder_helper_funcs
> wd_encoder_helper_funcs
> > +=
> > {
> > + .atomic_check = intel_wd_encoder_atomic_check, };
> > +
> > +static void intel_wd_connector_destroy(struct drm_connector
> > +*connector) {
>
> Do you want to flush your queue before removing connector!
will remove the kfree(connector)
> > + drm_connector_cleanup(connector);
> > + kfree(connector);
> > +}
> > +
> > +static enum drm_connector_status
> > +intel_wb_connector_detect(struct drm_connector *connector, bool
> > +force) {
> > + return connector_status_connected;
> > +}
> > +
> > +static const struct drm_connector_funcs wd_connector_funcs = {
> > + .detect = intel_wb_connector_detect,
> > + .reset = drm_atomic_helper_connector_reset,
> > + .destroy = intel_wd_connector_destroy,
> > + .fill_modes = drm_helper_probe_single_connector_modes,
> > + .atomic_destroy_state =
> > drm_atomic_helper_connector_destroy_state,
> > + .atomic_duplicate_state =
> > drm_atomic_helper_connector_duplicate_state,
> > +};
> > +
> > +static const struct drm_connector_helper_funcs
> > wd_connector_helper_funcs = {
> > + .get_modes = intel_wd_get_modes,
> > + .mode_valid = intel_wd_mode_valid,
> > +};
> > +
> > +static const struct drm_encoder_funcs drm_writeback_encoder_funcs = {
> > + .destroy = drm_encoder_cleanup,
> > +};
> > +
> > +static bool intel_fastset_dis(struct intel_encoder *encoder,
> > + struct intel_crtc_state *pipe_config) {
> > + return false;
> > +}
> > +
> > +static void intel_wd_connector_init(struct intel_wd *intel_wd) {
> > + drm_atomic_helper_connector_reset(&intel_wd->wb_conn.base);
> > +}
> > +
> > +static void intel_wd_disable_capture(struct intel_wd *intel_wd) {
> > + struct drm_i915_private *dev_priv = to_i915(intel_wd-
> > >base.base.dev);
> > + u32 tmp;
> > +
> > + intel_de_write_fw(dev_priv, WD_IMR(intel_wd->trans), 0xFF);
> > + tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
> > + tmp &= WD_TRANS_DISABLE;
> > + intel_de_write(dev_priv, PIPECONF(intel_wd->trans), tmp);
> > + tmp = intel_de_read(dev_priv, WD_TRANS_FUNC_CTL(intel_wd-
> > >trans));
> > + tmp |= ~TRANS_WD_FUNC_ENABLE;
>
> Not writing this value back to the CTL reg.
>
Ohh didn’t notice that thanks will do
> > +}
> > +
> > +void intel_wd_init(struct drm_i915_private *i915, enum transcoder
> > +trans) {
> > + struct intel_wd *intel_wd;
> > + struct intel_encoder *encoder;
> > + struct drm_writeback_connector *wb_conn;
> > + int n_formats = ARRAY_SIZE(wb_fmts);
> > + struct drm_encoder *drm_enc;
> > + int err, ret;
> > +
> > + intel_wd = kzalloc(sizeof(*intel_wd), GFP_KERNEL);
> > +
> Blank line not needed.
>
> > + if (!intel_wd)
> > + return;
> > +
> > + intel_wd_connector_init(intel_wd);
> > + encoder = &intel_wd->base;
> > + drm_enc = &encoder->base;
> > + wb_conn = &intel_wd->wb_conn;
> > + intel_wd->trans = trans;
> > + intel_wd->triggered_cap_mode = 1;
> > + intel_wd->frame_num = 1;
> > + intel_wd->slicing_strategy = 1;
> > + encoder->get_config = intel_wd_get_config;
> > + encoder->compute_config = intel_wd_compute_config;
> > + encoder->get_hw_state = intel_wd_get_hw_state;
> > + encoder->type = INTEL_OUTPUT_WD;
> > + encoder->cloneable = 0;
> > + encoder->pipe_mask = ~0;
> > + encoder->power_domain = POWER_DOMAIN_TRANSCODER_B;
> > + encoder->get_power_domains = intel_wd_get_power_domains;
> > + encoder->initial_fastset_check = intel_fastset_dis;
> > +
> > + drm_encoder_helper_add(drm_enc,
> > + &wd_encoder_helper_funcs);
> > +
> > + drm_enc->possible_crtcs = ~0;
> > + ret = drm_encoder_init(&i915->drm, drm_enc,
> > + &drm_writeback_encoder_funcs,
> > + DRM_MODE_ENCODER_VIRTUAL, NULL);
> > +
> > + if (ret) {
> > + drm_dbg_kms(&i915->drm,
> > + "Writeback drm_encoder init Failed: %d\n",
> > + ret);
> > + goto cleanup;
> > + }
> > +
> > + err = drm_writeback_connector_init_with_encoder(&i915->drm,
> > + wb_conn, drm_enc, &wd_connector_funcs,
> > + wb_fmts, n_formats);
> > +
> > + if (err != 0) {
> > + drm_dbg_kms(&i915->drm,
> > + "drm_writeback_connector_init: Failed: %d\n",
> > + err);
> Can you correct the alignment?
>
> > + goto cleanup;
> > + }
> > +
> > + wb_conn->base.encoder = drm_enc;
> > + drm_connector_helper_add(&wb_conn->base,
> > &wd_connector_helper_funcs);
> > + wb_conn->base.status = connector_status_connected;
> > + return;
> > +
> > +cleanup:
> > + kfree(intel_wd);
> > + return;
> > +}
> > +
> > +static void intel_wd_writeback_complete(struct intel_wd *intel_wd,
> > + struct drm_writeback_job *job, int status) {
> > + struct drm_writeback_connector *wb_conn =
> > + &intel_wd->wb_conn;
> > + drm_writeback_signal_completion(wb_conn, status); }
> Closing bracket should come on next line.
>
> > +
> > +static int intel_wd_setup_transcoder(struct intel_wd *intel_wd,
> > + struct intel_crtc_state *pipe_config,
> > + struct drm_connector_state *conn_state,
> > + struct drm_writeback_job *job)
> > +{
> > + struct intel_crtc *intel_crtc = to_intel_crtc(pipe_config->uapi.crtc);
> > + enum pipe pipe = intel_crtc->pipe;
> > + struct drm_framebuffer *fb;
> > + struct drm_i915_private *dev_priv = to_i915(intel_crtc->base.dev);
> > + struct drm_gem_object *wd_fb_obj;
> > + int ret;
> > + u32 stride, tmp;
> > + u16 hactive, vactive;
> > +
> > + fb = job->fb;
> > + wd_fb_obj = fb->obj[0];
> > + if (!wd_fb_obj) {
> > + drm_dbg_kms(&dev_priv->drm, "No framebuffer gem
> object
> > created\n");
> > + return -1;
>
> EINVAL;
>
> > + }
> > +
> > + ret = intel_wd_pin_fb(intel_wd, fb);
> > + drm_WARN_ON(&dev_priv->drm, ret != 0);
> > + /*Write stride and surface registers in that particular order*/
> Please use proper commenting style
> /* space followed by text and again space */
>
> > + stride = intel_wd_get_stride(pipe_config, fb->format->format);
> > +
> > + tmp = intel_de_read(dev_priv, WD_STRIDE(intel_wd->trans));
> > + tmp &= ~WD_STRIDE_MASK;
> > + tmp |= (stride << WD_STRIDE_SHIFT);
> > +
> > + intel_de_write(dev_priv, WD_STRIDE(intel_wd->trans), tmp);
> > +
> > + tmp = intel_de_read(dev_priv, WD_SURF(intel_wd->trans));
> > +
> > + intel_de_write(dev_priv, WD_SURF(intel_wd->trans),
> > + i915_ggtt_offset(intel_wd->vma));
> > +
> > + tmp = intel_de_read_fw(dev_priv, WD_IIR(intel_wd->trans));
> > + intel_de_write_fw(dev_priv, WD_IIR(intel_wd->trans), tmp);
> > +
> > + tmp = ~(WD_GTT_FAULT_INT | WD_WRITE_COMPLETE_INT |
> > WD_FRAME_COMPLETE_INT |
> > + WD_VBLANK_INT | WD_OVERRUN_INT |
> > WD_CAPTURING_INT);
> > + intel_de_write_fw(dev_priv, WD_IMR(intel_wd->trans), tmp);
> > +
> > + if (intel_wd->stream_cap) {
> > + tmp = intel_de_read(dev_priv,
> > + WD_STREAMCAP_CTL(intel_wd->trans));
> > + tmp |= WD_STREAM_CAP_MODE_EN;
> > + intel_configure_slicing_strategy(dev_priv, intel_wd, &tmp);
> > + }
> > +
> > + hactive = pipe_config->uapi.mode.hdisplay;
> > + vactive = pipe_config->uapi.mode.vdisplay;
> > + tmp = intel_de_read(dev_priv, HTOTAL(intel_wd->trans));
> > + tmp = intel_de_read(dev_priv, VTOTAL(intel_wd->trans));
> > +
> > + /* minimum hactive as per bspec: 64 pixels*/
> Recheck on the commenting style
>
Sure
Thanks for the comments will work on them
Regards,
Suraj Kandpal
> > + if (hactive < 64)
> > + drm_err(&dev_priv->drm, "hactive is less then 64 pixels\n");
> > +
> > + intel_de_write(dev_priv, HTOTAL(intel_wd->trans), hactive - 1);
> > + intel_de_write(dev_priv, VTOTAL(intel_wd->trans), vactive - 1);
> > +
> > + tmp = intel_de_read(dev_priv, WD_TRANS_FUNC_CTL(intel_wd-
> > >trans));
> > + /* select pixel format */
> > + tmp &= ~WD_PIX_FMT_MASK;
> > +
> > + switch (fb->format->format) {
> > + default:
> > + fallthrough;
> > + case DRM_FORMAT_YUYV:
> > + tmp |= WD_PIX_FMT_YUYV;
> > + break;
> > + case DRM_FORMAT_XYUV8888:
> > + tmp |= WD_PIX_FMT_XYUV8888;
> > + break;
> > + case DRM_FORMAT_XBGR8888:
> > + case DRM_FORMAT_XRGB8888:
> > + tmp |= WD_PIX_FMT_XBGR8888;
> > + break;
> > + case DRM_FORMAT_Y410:
> > + tmp |= WD_PIX_FMT_Y410;
> > + break;
> > + case DRM_FORMAT_YUV422:
> > + tmp |= WD_PIX_FMT_YUV422;
> > + break;
> > + case DRM_FORMAT_XBGR2101010:
> > + tmp |= WD_PIX_FMT_XBGR2101010;
> > + break;
> > + case DRM_FORMAT_RGB565:
> > + tmp |= WD_PIX_FMT_RGB565;
> > + break;
> > + }
> > +
> > + if (intel_wd->triggered_cap_mode)
> > + tmp |= WD_TRIGGERED_CAP_MODE_ENABLE;
> > +
> > + if (intel_wd->stream_cap)
> > + tmp |= WD_CTL_POINTER_DTDH;
> > +
> > + /*select input pipe*/
> > + tmp &= ~WD_INPUT_SELECT_MASK;
> > + switch (pipe) {
> > + default:
> > + fallthrough;
> > + case PIPE_A:
> > + tmp |= WD_INPUT_PIPE_A;
> > + break;
> > + case PIPE_B:
> > + tmp |= WD_INPUT_PIPE_B;
> > + break;
> > + case PIPE_C:
> > + tmp |= WD_INPUT_PIPE_C;
> > + break;
> > + case PIPE_D:
> > + tmp |= WD_INPUT_PIPE_D;
> > + break;
> > + }
> > +
> > + /* enable DDI buffer */
> > + if (!(tmp & TRANS_WD_FUNC_ENABLE))
> > + tmp |= TRANS_WD_FUNC_ENABLE;
> > +
> > + intel_de_write(dev_priv, WD_TRANS_FUNC_CTL(intel_wd->trans),
> > tmp);
> > +
> > + tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
> > + ret = tmp & WD_TRANS_ACTIVE;
> > + if (!ret) {
> > + /*enable the transcoder */
> > + tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
> > + tmp |= WD_TRANS_ENABLE;
> > + intel_de_write(dev_priv, PIPECONF(intel_wd->trans), tmp);
> > +
> > + /* wait for transcoder to be enabled */
> > + if (intel_de_wait_for_set(dev_priv, PIPECONF(intel_wd-
> > >trans),
> > + WD_TRANS_ACTIVE, 10))
> > + drm_err(&dev_priv->drm, "WD transcoder could not
> > be enabled\n");
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static int intel_wd_capture(struct intel_wd *intel_wd,
> > + struct intel_crtc_state *pipe_config,
> > + struct drm_connector_state *conn_state,
> > + struct drm_writeback_job *job)
> > +{
> > + u32 tmp;
> > + struct drm_i915_private *i915 = to_i915(intel_wd->base.base.dev);
> > + int ret = 0, status = 0;
> > + struct intel_crtc *wd_crtc = intel_wd->wd_crtc;
> > + unsigned long flags;
> > +
> > + if (!job->out_fence)
> > + drm_dbg_kms(&i915->drm, "Not able to get out_fence for
> > job\n");
> > +
> > + ret = intel_wd_setup_transcoder(intel_wd, pipe_config,
> > + conn_state, job);
> > +
> > + if (ret < 0) {
> > + drm_dbg_kms(&i915->drm,
> > + "WD transcoder setup not completed aborting capture\n");
> > + return -1;
> > + }
> > +
> > + if (!wd_crtc) {
> > + drm_err(&i915->drm, "CRTC not attached\n");
> > + return -1;
> > + }
> > +
> > + tmp = intel_de_read_fw(i915,
> > + WD_TRANS_FUNC_CTL(intel_wd->trans));
> > + tmp |= START_TRIGGER_FRAME;
> > + tmp &= ~WD_FRAME_NUMBER_MASK;
> > + tmp |= intel_wd->frame_num;
> > + intel_de_write_fw(i915,
> > + WD_TRANS_FUNC_CTL(intel_wd->trans), tmp);
> > +
> > + if (!intel_de_wait_for_set(i915, WD_IIR(intel_wd->trans),
> > + WD_FRAME_COMPLETE_INT, 100)){
> > + drm_dbg_kms(&i915->drm, "frame captured\n");
> > + status = 0;
> > + } else {
> > + drm_dbg_kms(&i915->drm, "frame not captured triggering
> > stop frame\n");
> > + tmp = intel_de_read(i915,
> > + WD_TRANS_FUNC_CTL(intel_wd->trans));
> > + tmp |= STOP_TRIGGER_FRAME;
> > + intel_de_write(i915,
> > + WD_TRANS_FUNC_CTL(intel_wd->trans),
> > tmp);
> > + status = -1;
> > + }
> > +
> > + intel_wd_writeback_complete(intel_wd, job, status);
> > + if (wd_crtc->wd.e) {
> > + spin_lock_irqsave(&i915->drm.event_lock, flags);
> > + drm_dbg_kms(&i915->drm, "send %p\n", wd_crtc->wd.e);
> > + drm_crtc_send_vblank_event(&wd_crtc->base,
> > + wd_crtc->wd.e);
> > + spin_unlock_irqrestore(&i915->drm.event_lock, flags);
> > + wd_crtc->wd.e = NULL;
> > + } else {
> > + drm_err(&i915->drm, "Event NULL! %p, %p\n", &i915->drm,
> > + wd_crtc);
> > + }
> > + if (!intel_get_writeback_job_from_queue(intel_wd))
> > + intel_wd_disable_capture(intel_wd);
> > + return 0;
> > +}
> > +
> > +void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
> > + struct drm_connector_state *conn_state) {
> > + struct drm_i915_private *i915 =
> > + to_i915(conn_state->connector->dev);
> > + struct drm_writeback_connector *wb_conn =
> > + drm_connector_to_writeback(conn_state->connector);
> > + struct intel_wd *intel_wd = wb_conn_to_intel_wd(wb_conn);
> > + struct drm_writeback_job *job;
> > +
> > + job = intel_get_writeback_job_from_queue(intel_wd);
> > + if (!job) {
> > + drm_dbg_kms(&i915->drm,
> > + "job queue is empty not capturing any frame\n");
> > + return;
> > + }
> > +
> > + intel_wd_capture(intel_wd, pipe_config,
> > + conn_state, job);
> > + intel_wd->frame_num += 1;
> > +}
> > +
> > +void intel_wd_set_vblank_event(struct intel_atomic_state *state,
> > +struct
> > intel_crtc *intel_crtc,
> > + struct intel_crtc_state *intel_crtc_state) {
> > + struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
> > + struct drm_crtc_state *crtc_state = &intel_crtc_state->uapi;
> > + struct intel_encoder *encoder;
> > + struct intel_wd *intel_wd;
> > + struct drm_connector_state *conn_state;
> > + struct drm_connector *connector;
> > + int i;
> > +
> > + for_each_intel_encoder(&i915->drm, encoder) {
> > + if (encoder->type != INTEL_OUTPUT_WD)
> > + continue;
> > +
> > + intel_wd = enc_to_intel_wd(encoder);
> > + if (!intel_wd->wd_crtc)
> > + return;
> > + }
> > +
> > + if (intel_wd && intel_crtc == intel_wd->wd_crtc) {
> > + for_each_new_connector_in_state(&state->base,
> connector,
> > conn_state,
> > + i) {
> > + if (!conn_state->writeback_job)
> > + continue;
> > +
> > + intel_crtc->wd.e = crtc_state->event;
> > + crtc_state->event = NULL;
> > + }
> > + }
> > +}
> > +
> > +void intel_wd_handle_isr(struct drm_i915_private *i915) {
> > + u32 iir_value = 0;
> > + struct intel_encoder *encoder;
> > + struct intel_wd *intel_wd;
> > +
> > + iir_value = intel_de_read(i915, WD_IIR(TRANSCODER_WD_0));
> > +
> > + for_each_intel_encoder(&i915->drm, encoder) {
> > +
> > + if (encoder->type != INTEL_OUTPUT_WD)
> > + continue;
> > +
> > + intel_wd = enc_to_intel_wd(encoder);
> > + if (!intel_wd->wd_crtc) {
> > + drm_err(&i915->drm, "NO CRTC attached with
> > WD\n");
> > + goto clear_iir;
> > + }
> > + }
> > +
> > + if (iir_value & WD_FRAME_COMPLETE_INT)
> > + return;
> > +
> > +clear_iir:
> > + intel_de_write(i915, WD_IIR(TRANSCODER_WD_0), iir_value); }
> > diff --git a/drivers/gpu/drm/i915/display/intel_wd.h
> > b/drivers/gpu/drm/i915/display/intel_wd.h
> > new file mode 100644
> > index 000000000000..0fcd1a746593
> > --- /dev/null
> > +++ b/drivers/gpu/drm/i915/display/intel_wd.h
> > @@ -0,0 +1,48 @@
> > +/* SPDX-License-Identifier: MIT*/
> > +/*
> > + * Copyright © 2022 Intel Corporation */
> > +
> > +#ifndef _INTEL_WD_H
> > +#define _INTEL_WD_H
> > +
> > +#include <drm/drm_crtc.h>
> > +
> > +#include "intel_display_types.h"
> > +
> > +#define I915_MAX_WD_TANSCODERS 2
> > +
> > +struct intel_wd {
> > + struct intel_encoder base;
> > + struct drm_writeback_connector wb_conn;
> > + struct intel_crtc *wd_crtc;
> > + intel_wakeref_t io_wakeref[I915_MAX_WD_TANSCODERS];
> > + enum transcoder trans;
> > + struct i915_vma *vma;
> > + unsigned long flags;
> > + struct drm_writeback_job *job;
> > + int triggered_cap_mode;
> > + int frame_num;
> > + bool stream_cap;
> > + bool start_capture;
> > + int slicing_strategy;
> > +};
> > +
> > +static inline struct intel_wd *enc_to_intel_wd(struct intel_encoder
> > +*encoder) {
> > + return container_of(&encoder->base, struct intel_wd, base.base); }
> > +
> > +static inline struct intel_wd *wb_conn_to_intel_wd(struct
> > +drm_writeback_connector *wb_conn) {
> > + return container_of(wb_conn, struct intel_wd, wb_conn); }
> > +
> > +void intel_wd_init(struct drm_i915_private *dev_priv, enum transcoder
> > +trans); void intel_wd_enable_capture(struct intel_crtc_state
> *pipe_config,
> > + struct drm_connector_state *conn_state); void
> > +intel_wd_handle_isr(struct drm_i915_private *dev_priv); void
> > +intel_wd_set_vblank_event(struct intel_atomic_state *state, struct
> > intel_crtc *crtc,
> > + struct intel_crtc_state *crtc_state); struct
> > drm_writeback_job
> > +*intel_get_writeback_job_from_queue(struct intel_wd *intel_wd);
> > +#endif/* _INTEL_WD_H */
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > b/drivers/gpu/drm/i915/i915_drv.h index 086bbe8945d6..73ef94757fc8
> > 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -35,6 +35,7 @@
> > #include <linux/pm_qos.h>
> >
> > #include <drm/drm_connector.h>
> > +#include <drm/drm_writeback.h>
> > #include <drm/ttm/ttm_device.h>
> >
> > #include "display/intel_cdclk.h"
> > diff --git a/drivers/gpu/drm/i915/i915_irq.c
> > b/drivers/gpu/drm/i915/i915_irq.c index 0389f532d926..6504ef528d90
> > 100644
> > --- a/drivers/gpu/drm/i915/i915_irq.c
> > +++ b/drivers/gpu/drm/i915/i915_irq.c
> > @@ -42,6 +42,7 @@
> > #include "display/intel_hotplug.h"
> > #include "display/intel_lpe_audio.h"
> > #include "display/intel_psr.h"
> > +#include "display/intel_wd.h"
> >
> > #include "gt/intel_breadcrumbs.h"
> > #include "gt/intel_gt.h"
> > @@ -2342,6 +2343,11 @@ gen8_de_misc_irq_handler(struct
> > drm_i915_private *dev_priv, u32 iir)
> > found = true;
> > }
> >
> > + if (iir & GEN8_DE_MISC_WD0) {
> > + intel_wd_handle_isr(dev_priv);
> > + found = true;
> > + }
> > +
> > if (iir & GEN8_DE_EDP_PSR) {
> > struct intel_encoder *encoder;
> > u32 psr_iir;
> > @@ -3767,7 +3773,7 @@ static void gen8_de_irq_postinstall(struct
> > drm_i915_private *dev_priv)
> > u32 de_pipe_enables;
> > u32 de_port_masked = gen8_de_port_aux_mask(dev_priv);
> > u32 de_port_enables;
> > - u32 de_misc_masked = GEN8_DE_EDP_PSR;
> > + u32 de_misc_masked = GEN8_DE_EDP_PSR | GEN8_DE_MISC_WD0;
> > u32 trans_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
> > BIT(TRANSCODER_C) | BIT(TRANSCODER_D);
> > enum pipe pipe;
> > diff --git a/drivers/gpu/drm/i915/i915_pci.c
> > b/drivers/gpu/drm/i915/i915_pci.c index aacc10f2e73f..636ce7819021
> > 100644
> > --- a/drivers/gpu/drm/i915/i915_pci.c
> > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > @@ -864,7 +864,8 @@ static const struct intel_device_info jsl_info = {
> > .display.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) |
> > BIT(PIPE_D), \
> > .display.cpu_transcoder_mask = BIT(TRANSCODER_A) |
> > BIT(TRANSCODER_B) | \
> > BIT(TRANSCODER_C) | BIT(TRANSCODER_D) | \
> > - BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1), \
> > + BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1) | \
> > + BIT(TRANSCODER_WD_0), \
> > .display.pipe_offsets = { \
> > [TRANSCODER_A] = PIPE_A_OFFSET, \
> > [TRANSCODER_B] = PIPE_B_OFFSET, \
> > @@ -872,6 +873,8 @@ static const struct intel_device_info jsl_info = {
> > [TRANSCODER_D] = PIPE_D_OFFSET, \
> > [TRANSCODER_DSI_0] = PIPE_DSI0_OFFSET, \
> > [TRANSCODER_DSI_1] = PIPE_DSI1_OFFSET, \
> > + [TRANSCODER_WD_0] = PIPE_WD0_OFFSET, \
> > + [TRANSCODER_WD_1] = PIPE_WD1_OFFSET, \
> > }, \
> > .display.trans_offsets = { \
> > [TRANSCODER_A] = TRANSCODER_A_OFFSET, \ @@ -880,6
> > +883,8 @@ static const struct intel_device_info jsl_info = {
> > [TRANSCODER_D] = TRANSCODER_D_OFFSET, \
> > [TRANSCODER_DSI_0] = TRANSCODER_DSI0_OFFSET, \
> > [TRANSCODER_DSI_1] = TRANSCODER_DSI1_OFFSET, \
> > + [TRANSCODER_WD_0] = TRANSCODER_WD0_OFFSET, \
> > + [TRANSCODER_WD_1] = TRANSCODER_WD1_OFFSET, \
> > }, \
> > TGL_CURSOR_OFFSETS, \
> > .has_global_mocs = 1, \
> > --
> > 2.25.1
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-09-12 9:28 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-22 8:16 [Intel-gfx] [PATCH v2 0/3] Enable Pipewriteback Kandpal, Suraj
2022-08-22 8:16 ` [Intel-gfx] [PATCH v2 1/3] drm/i915: Define WD trancoder for i915 Kandpal, Suraj
2022-09-09 8:57 ` Murthy, Arun R
2022-09-09 9:01 ` Jani Nikula
2022-09-09 9:03 ` Murthy, Arun R
2022-08-22 8:16 ` [Intel-gfx] [PATCH v2 2/3] drm/i915 : Changing intel_connector iterators Kandpal, Suraj
2022-09-09 8:58 ` Murthy, Arun R
2022-08-22 8:16 ` [Intel-gfx] [PATCH v2 3/3] drm/i915: Enabling WD Transcoder Kandpal, Suraj
2022-09-12 8:07 ` Murthy, Arun R
2022-09-12 9:28 ` Kandpal, Suraj
2022-08-24 22:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev2) Patchwork
2022-08-24 22:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-26 17:51 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.