* [LTP] [PATCH] README: Add missing configure in openposix step
@ 2022-09-01 4:57 Yang Xu
2022-09-01 11:05 ` Petr Vorel
0 siblings, 1 reply; 6+ messages in thread
From: Yang Xu @ 2022-09-01 4:57 UTC (permalink / raw)
To: ltp
Since 8071ba7("openposix: Setup autoconf and fix installation layout")
, we need to use configure firstly.
Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
README.md | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/README.md b/README.md
index d45d1ee44..d0ca5f4d4 100644
--- a/README.md
+++ b/README.md
@@ -79,11 +79,13 @@ $ cd ../commands/foo
$ PATH=$PATH:$PWD:$PWD/../../lib/ ./foo01.sh
```
-Open Posix Testsuite has it's own build system which needs Makefiles to be
-generated first, then compilation should work in subdirectories as well.
+Open Posix Testsuite has it's own configure and build system which needs
+Makefiles to be generated first, then compilation should work in subdirectories
+as well.
```
$ cd testcases/open_posix_testsuite/
+$ ./configure
$ make generate-makefiles
$ cd conformance/interfaces/foo
$ make
--
2.23.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] README: Add missing configure in openposix step
2022-09-01 4:57 [LTP] [PATCH] README: Add missing configure in openposix step Yang Xu
@ 2022-09-01 11:05 ` Petr Vorel
2022-09-02 7:31 ` xuyang2018.jy
0 siblings, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2022-09-01 11:05 UTC (permalink / raw)
To: Yang Xu; +Cc: Joerg Vehlow, ltp
Hi Xu,
[ Cc Joerg ]
> Since 8071ba7("openposix: Setup autoconf and fix installation layout")
> , we need to use configure firstly.
nit: there should be Fixes: below:
Fixes: 8071ba7 ("openposix: Setup autoconf and fix installation layout")
Then you can use just 8071ba7 in the text.
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
> README.md | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> diff --git a/README.md b/README.md
> index d45d1ee44..d0ca5f4d4 100644
> --- a/README.md
> +++ b/README.md
> @@ -79,11 +79,13 @@ $ cd ../commands/foo
> $ PATH=$PATH:$PWD:$PWD/../../lib/ ./foo01.sh
> ```
> -Open Posix Testsuite has it's own build system which needs Makefiles to be
> -generated first, then compilation should work in subdirectories as well.
> +Open Posix Testsuite has it's own configure and build system which needs
> +Makefiles to be generated first, then compilation should work in subdirectories
> +as well.
> ```
> $ cd testcases/open_posix_testsuite/
You miss:
$ make autotools
as this creates configure
> +$ ./configure
But if you run make autotools && ./configure in the top level, none of these two
is needed to be run in open posix directory. Maybe document it (not sure about
the comments)?
$ [ -f ./configure ] || make autotools # not needed if run in the top level
$ [ -f include/mk/config.mk ] || ./configure # not needed if the top level configure is run
Kind regards,
Petr
> $ make generate-makefiles
> $ cd conformance/interfaces/foo
> $ make
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] README: Add missing configure in openposix step
2022-09-01 11:05 ` Petr Vorel
@ 2022-09-02 7:31 ` xuyang2018.jy
2022-09-19 5:17 ` Joerg Vehlow
0 siblings, 1 reply; 6+ messages in thread
From: xuyang2018.jy @ 2022-09-02 7:31 UTC (permalink / raw)
To: Petr Vorel; +Cc: Joerg Vehlow, ltp
Hi Petr
> Hi Xu,
>
> [ Cc Joerg ]
>
>> Since 8071ba7("openposix: Setup autoconf and fix installation layout")
>> , we need to use configure firstly.
>
> nit: there should be Fixes: below:
> Fixes: 8071ba7 ("openposix: Setup autoconf and fix installation layout")
>
> Then you can use just 8071ba7 in the text.
>
>> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
>> ---
>> README.md | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>> diff --git a/README.md b/README.md
>> index d45d1ee44..d0ca5f4d4 100644
>> --- a/README.md
>> +++ b/README.md
>> @@ -79,11 +79,13 @@ $ cd ../commands/foo
>> $ PATH=$PATH:$PWD:$PWD/../../lib/ ./foo01.sh
>> ```
>
>> -Open Posix Testsuite has it's own build system which needs Makefiles to be
>> -generated first, then compilation should work in subdirectories as well.
>> +Open Posix Testsuite has it's own configure and build system which needs
>> +Makefiles to be generated first, then compilation should work in subdirectories
>> +as well.
>
>> ```
>> $ cd testcases/open_posix_testsuite/
>
> You miss:
> $ make autotools
> as this creates configure
>
>> +$ ./configure
> But if you run make autotools && ./configure in the top level, none of these two
> is needed to be run in open posix directory.
I have called them on top directory, but configure still be needed in
open posix directory.
Best Regards
Yang Xu
Maybe document it (not sure about
> the comments)?
>
> $ [ -f ./configure ] || make autotools # not needed if run in the top level
> $ [ -f include/mk/config.mk ] || ./configure # not needed if the top level configure is run
>
> Kind regards,
> Petr
>
>> $ make generate-makefiles
>> $ cd conformance/interfaces/foo
>> $ make
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] README: Add missing configure in openposix step
2022-09-02 7:31 ` xuyang2018.jy
@ 2022-09-19 5:17 ` Joerg Vehlow
2022-09-19 6:06 ` xuyang2018.jy
0 siblings, 1 reply; 6+ messages in thread
From: Joerg Vehlow @ 2022-09-19 5:17 UTC (permalink / raw)
To: xuyang2018.jy, Petr Vorel; +Cc: Joerg Vehlow, ltp
Hi,
sorry for the late reply, I was on vacation.
Am 9/2/2022 um 9:31 AM schrieb xuyang2018.jy@fujitsu.com:
> Hi Petr
>
>> Hi Xu,
>>
>> [ Cc Joerg ]
>>
>>> Since 8071ba7("openposix: Setup autoconf and fix installation layout")
>>> , we need to use configure firstly.
>>
>> nit: there should be Fixes: below:
>> Fixes: 8071ba7 ("openposix: Setup autoconf and fix installation layout")
>>
>> Then you can use just 8071ba7 in the text.
>>
>>> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
>>> ---
>>> README.md | 6 ++++--
>>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>>> diff --git a/README.md b/README.md
>>> index d45d1ee44..d0ca5f4d4 100644
>>> --- a/README.md
>>> +++ b/README.md
>>> @@ -79,11 +79,13 @@ $ cd ../commands/foo
>>> $ PATH=$PATH:$PWD:$PWD/../../lib/ ./foo01.sh
>>> ```
>>
>>> -Open Posix Testsuite has it's own build system which needs Makefiles to be
>>> -generated first, then compilation should work in subdirectories as well.
>>> +Open Posix Testsuite has it's own configure and build system which needs
>>> +Makefiles to be generated first, then compilation should work in subdirectories
>>> +as well.
>>
>>> ```
>>> $ cd testcases/open_posix_testsuite/
>>
>> You miss:
>> $ make autotools
>> as this creates configure
>>
>>> +$ ./configure
>> But if you run make autotools && ./configure in the top level, none of these two
>> is needed to be run in open posix directory.
>
> I have called them on top directory, but configure still be needed in
> open posix directory.
Did you run configure with --with-open-posix-testsuite? Otherwise
configure is not executed in the open posix directory.
Joerg
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] README: Add missing configure in openposix step
2022-09-19 5:17 ` Joerg Vehlow
@ 2022-09-19 6:06 ` xuyang2018.jy
2022-09-21 11:26 ` Petr Vorel
0 siblings, 1 reply; 6+ messages in thread
From: xuyang2018.jy @ 2022-09-19 6:06 UTC (permalink / raw)
To: Joerg.Vehlow, Petr Vorel; +Cc: ltp
Hi Joerg
> Hi,
>
> sorry for the late reply, I was on vacation.
>
> Am 9/2/2022 um 9:31 AM schrieb xuyang2018.jy@fujitsu.com:
>> Hi Petr
>>
>>> Hi Xu,
>>>
>>> [ Cc Joerg ]
>>>
>>>> Since 8071ba7("openposix: Setup autoconf and fix installation layout")
>>>> , we need to use configure firstly.
>>>
>>> nit: there should be Fixes: below:
>>> Fixes: 8071ba7 ("openposix: Setup autoconf and fix installation layout")
>>>
>>> Then you can use just 8071ba7 in the text.
>>>
>>>> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
>>>> ---
>>>> README.md | 6 ++++--
>>>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>>> diff --git a/README.md b/README.md
>>>> index d45d1ee44..d0ca5f4d4 100644
>>>> --- a/README.md
>>>> +++ b/README.md
>>>> @@ -79,11 +79,13 @@ $ cd ../commands/foo
>>>> $ PATH=$PATH:$PWD:$PWD/../../lib/ ./foo01.sh
>>>> ```
>>>
>>>> -Open Posix Testsuite has it's own build system which needs Makefiles to be
>>>> -generated first, then compilation should work in subdirectories as well.
>>>> +Open Posix Testsuite has it's own configure and build system which needs
>>>> +Makefiles to be generated first, then compilation should work in subdirectories
>>>> +as well.
>>>
>>>> ```
>>>> $ cd testcases/open_posix_testsuite/
>>>
>>> You miss:
>>> $ make autotools
>>> as this creates configure
>>>
>>>> +$ ./configure
>>> But if you run make autotools && ./configure in the top level, none of these two
>>> is needed to be run in open posix directory.
>>
>> I have called them on top directory, but configure still be needed in
>> open posix directory.
> Did you run configure with --with-open-posix-testsuite? Otherwise
> configure is not executed in the open posix directory.
Oh, yes, I don't use this option. I only see the documentation said we
can use ./configure and make instead of make all in the openposix
direcotry. But miss this --with-open-posix-testsuite option .
I think we should mention this option in README ie
./configure --with-open-posix-testsuite --with-realtime-testsuite
diff --git a/README.md b/README.md
index d45d1ee44..7da393e37 100644
--- a/README.md
+++ b/README.md
@@ -51,6 +51,13 @@ $ make autotools
$ ./configure
```
+If you want to include open posix testsuite or realtime testsuite, the
chances are
+the following will work:
+
+```
+$ ./configure --with-open-posix-testsuite --with-realtime-testsuite
+```
+
Now you can continue either with compiling and r
Best Regards
Yang Xu
>
> Joerg
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH] README: Add missing configure in openposix step
2022-09-19 6:06 ` xuyang2018.jy
@ 2022-09-21 11:26 ` Petr Vorel
0 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2022-09-21 11:26 UTC (permalink / raw)
To: xuyang2018.jy; +Cc: ltp, Joerg.Vehlow
> Hi Joerg
> > Hi,
> > sorry for the late reply, I was on vacation.
> > Am 9/2/2022 um 9:31 AM schrieb xuyang2018.jy@fujitsu.com:
> >> Hi Petr
> >>> Hi Xu,
> >>> [ Cc Joerg ]
> >>>> Since 8071ba7("openposix: Setup autoconf and fix installation layout")
> >>>> , we need to use configure firstly.
> >>> nit: there should be Fixes: below:
> >>> Fixes: 8071ba7 ("openposix: Setup autoconf and fix installation layout")
> >>> Then you can use just 8071ba7 in the text.
> >>>> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> >>>> ---
> >>>> README.md | 6 ++++--
> >>>> 1 file changed, 4 insertions(+), 2 deletions(-)
> >>>> diff --git a/README.md b/README.md
> >>>> index d45d1ee44..d0ca5f4d4 100644
> >>>> --- a/README.md
> >>>> +++ b/README.md
> >>>> @@ -79,11 +79,13 @@ $ cd ../commands/foo
> >>>> $ PATH=$PATH:$PWD:$PWD/../../lib/ ./foo01.sh
> >>>> ```
> >>>> -Open Posix Testsuite has it's own build system which needs Makefiles to be
> >>>> -generated first, then compilation should work in subdirectories as well.
> >>>> +Open Posix Testsuite has it's own configure and build system which needs
> >>>> +Makefiles to be generated first, then compilation should work in subdirectories
> >>>> +as well.
> >>>> ```
> >>>> $ cd testcases/open_posix_testsuite/
> >>> You miss:
> >>> $ make autotools
> >>> as this creates configure
> >>>> +$ ./configure
> >>> But if you run make autotools && ./configure in the top level, none of these two
> >>> is needed to be run in open posix directory.
> >> I have called them on top directory, but configure still be needed in
> >> open posix directory.
> > Did you run configure with --with-open-posix-testsuite? Otherwise
> > configure is not executed in the open posix directory.
> Oh, yes, I don't use this option. I only see the documentation said we
> can use ./configure and make instead of make all in the openposix
> direcotry. But miss this --with-open-posix-testsuite option .
> I think we should mention this option in README ie
> ./configure --with-open-posix-testsuite --with-realtime-testsuite
> diff --git a/README.md b/README.md
> index d45d1ee44..7da393e37 100644
> --- a/README.md
> +++ b/README.md
> @@ -51,6 +51,13 @@ $ make autotools
> $ ./configure
> ```
> +If you want to include open posix testsuite or realtime testsuite, the
> chances are
> +the following will work:
> +
> +```
> +$ ./configure --with-open-posix-testsuite --with-realtime-testsuite
> +```
> +
> Now you can continue either with compiling and r
I guess all people who has been using open posix by now knows
--with-open-posix-testsuite is needed. I mean, it does not harm to document it,
but there are other options. I suppose people run ./configure --help on project
they don't know.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-21 11:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01 4:57 [LTP] [PATCH] README: Add missing configure in openposix step Yang Xu
2022-09-01 11:05 ` Petr Vorel
2022-09-02 7:31 ` xuyang2018.jy
2022-09-19 5:17 ` Joerg Vehlow
2022-09-19 6:06 ` xuyang2018.jy
2022-09-21 11:26 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.