* [PATCH net-next] net: sched: etf: remove true check in etf_enable_offload()
@ 2022-08-31 9:29 Zhengchao Shao
2022-09-01 0:06 ` Vinicius Costa Gomes
2022-09-02 3:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Zhengchao Shao @ 2022-08-31 9:29 UTC (permalink / raw)
To: netdev, linux-kernel, vinicius.gomes, davem, edumazet, kuba,
pabeni, jhs, xiyou.wangcong, jiri
Cc: weiyongjun1, yuehaibing, shaozhengchao
etf_enable_offload() is only called when q->offload is false in
etf_init(). So remove true check in etf_enable_offload().
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
net/sched/sch_etf.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/sched/sch_etf.c b/net/sched/sch_etf.c
index d96103b0e2bf..61d1f0e32cf3 100644
--- a/net/sched/sch_etf.c
+++ b/net/sched/sch_etf.c
@@ -323,9 +323,6 @@ static int etf_enable_offload(struct net_device *dev, struct etf_sched_data *q,
struct tc_etf_qopt_offload etf = { };
int err;
- if (q->offload)
- return 0;
-
if (!ops->ndo_setup_tc) {
NL_SET_ERR_MSG(extack, "Specified device does not support ETF offload");
return -EOPNOTSUPP;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: sched: etf: remove true check in etf_enable_offload()
2022-08-31 9:29 [PATCH net-next] net: sched: etf: remove true check in etf_enable_offload() Zhengchao Shao
@ 2022-09-01 0:06 ` Vinicius Costa Gomes
2022-09-02 3:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Vinicius Costa Gomes @ 2022-09-01 0:06 UTC (permalink / raw)
To: Zhengchao Shao, netdev, linux-kernel, davem, edumazet, kuba,
pabeni, jhs, xiyou.wangcong, jiri
Cc: weiyongjun1, yuehaibing, shaozhengchao
Zhengchao Shao <shaozhengchao@huawei.com> writes:
> etf_enable_offload() is only called when q->offload is false in
> etf_init(). So remove true check in etf_enable_offload().
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
--
Vinicius
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: sched: etf: remove true check in etf_enable_offload()
2022-08-31 9:29 [PATCH net-next] net: sched: etf: remove true check in etf_enable_offload() Zhengchao Shao
2022-09-01 0:06 ` Vinicius Costa Gomes
@ 2022-09-02 3:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-02 3:30 UTC (permalink / raw)
To: Zhengchao Shao
Cc: netdev, linux-kernel, vinicius.gomes, davem, edumazet, kuba,
pabeni, jhs, xiyou.wangcong, jiri, weiyongjun1, yuehaibing
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 31 Aug 2022 17:29:19 +0800 you wrote:
> etf_enable_offload() is only called when q->offload is false in
> etf_init(). So remove true check in etf_enable_offload().
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
> net/sched/sch_etf.c | 3 ---
> 1 file changed, 3 deletions(-)
Here is the summary with links:
- [net-next] net: sched: etf: remove true check in etf_enable_offload()
https://git.kernel.org/netdev/net-next/c/75aad41ac3cf
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-02 3:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-31 9:29 [PATCH net-next] net: sched: etf: remove true check in etf_enable_offload() Zhengchao Shao
2022-09-01 0:06 ` Vinicius Costa Gomes
2022-09-02 3:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.