All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 linux-next] wifi: wilc1000: remove redundant ret variable
@ 2022-08-30 10:55 cgel.zte
  2022-09-02  8:46 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-08-30 10:55 UTC (permalink / raw)
  To: ajay.kathat, claudiu.beznea, kvalo, davem, edumazet
  Cc: kuba, pabeni, linux-wireless, netdev, linux-kernel, Jinpeng Cui,
	Zeal Robot

From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>

Return value from cfg80211_rx_mgmt() directly instead of
taking this in another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
---
 drivers/net/wireless/microchip/wilc1000/cfg80211.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/microchip/wilc1000/cfg80211.c b/drivers/net/wireless/microchip/wilc1000/cfg80211.c
index f810a56a7ff0..b89047965e78 100644
--- a/drivers/net/wireless/microchip/wilc1000/cfg80211.c
+++ b/drivers/net/wireless/microchip/wilc1000/cfg80211.c
@@ -997,12 +997,11 @@ bool wilc_wfi_mgmt_frame_rx(struct wilc_vif *vif, u8 *buff, u32 size)
 {
 	struct wilc *wl = vif->wilc;
 	struct wilc_priv *priv = &vif->priv;
-	int freq, ret;
+	int freq;
 
 	freq = ieee80211_channel_to_frequency(wl->op_ch, NL80211_BAND_2GHZ);
-	ret = cfg80211_rx_mgmt(&priv->wdev, freq, 0, buff, size, 0);
 
-	return ret;
+	return cfg80211_rx_mgmt(&priv->wdev, freq, 0, buff, size, 0);
 }
 
 void wilc_wfi_p2p_rx(struct wilc_vif *vif, u8 *buff, u32 size)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 linux-next] wifi: wilc1000: remove redundant ret variable
  2022-08-30 10:55 [PATCH v2 linux-next] wifi: wilc1000: remove redundant ret variable cgel.zte
@ 2022-09-02  8:46 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-09-02  8:46 UTC (permalink / raw)
  To: cgel.zte
  Cc: ajay.kathat, claudiu.beznea, davem, edumazet, kuba, pabeni,
	linux-wireless, netdev, linux-kernel, Jinpeng Cui, Zeal Robot

cgel.zte@gmail.com wrote:

> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
> 
> Return value from cfg80211_rx_mgmt() directly instead of
> taking this in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>

Patch applied to wireless-next.git, thanks.

1dc13236ef91 wifi: wilc1000: remove redundant ret variable

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220830105505.287564-1-cui.jinpeng2@zte.com.cn/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-02  8:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-30 10:55 [PATCH v2 linux-next] wifi: wilc1000: remove redundant ret variable cgel.zte
2022-09-02  8:46 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.