All of lore.kernel.org
 help / color / mirror / Atom feed
* [kernel PATCH v1 0/1] Bluetooth: hci_sync: allow advertising during active scan without privacy
@ 2022-09-13 22:04 Zhengping Jiang
  2022-09-13 22:04 ` [kernel PATCH v1 1/1] " Zhengping Jiang
  2022-09-14 20:10 ` [kernel PATCH v1 0/1] " patchwork-bot+bluetooth
  0 siblings, 2 replies; 4+ messages in thread
From: Zhengping Jiang @ 2022-09-13 22:04 UTC (permalink / raw)
  To: linux-bluetooth, marcel
  Cc: Zhengping Jiang, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Johan Hedberg, Luiz Augusto von Dentz, Paolo Abeni, linux-kernel,
	netdev


This patch allows the device to keep advertising during active scan when
ll privacy is enabled, if the device is not using privacy mode.

Changes in v1:
- Check privacy flag when disable advertising

Zhengping Jiang (1):
  Bluetooth: hci_sync: allow advertising during active scan without
    privacy

 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.37.2.789.g6183377224-goog


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [kernel PATCH v1 1/1] Bluetooth: hci_sync: allow advertising during active scan without privacy
  2022-09-13 22:04 [kernel PATCH v1 0/1] Bluetooth: hci_sync: allow advertising during active scan without privacy Zhengping Jiang
@ 2022-09-13 22:04 ` Zhengping Jiang
  2022-09-13 23:11   ` bluez.test.bot
  2022-09-14 20:10 ` [kernel PATCH v1 0/1] " patchwork-bot+bluetooth
  1 sibling, 1 reply; 4+ messages in thread
From: Zhengping Jiang @ 2022-09-13 22:04 UTC (permalink / raw)
  To: linux-bluetooth, marcel
  Cc: Zhengping Jiang, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Johan Hedberg, Luiz Augusto von Dentz, Paolo Abeni, linux-kernel,
	netdev

Address resolution will be paused during active scan to allow any
advertising reports reach the host. If LL privacy is enabled,
advertising will rely on the controller to generate new RPA.

If host is not using RPA, there is no need to stop advertising during
active scan because there is no need to generate RPA in the controller.

Signed-off-by: Zhengping Jiang <jiangzp@google.com>
---

Changes in v1:
- Check privacy flag when disable advertising

 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 41b6d19c70b06..422f7c6911d9f 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -5351,7 +5351,7 @@ static int hci_active_scan_sync(struct hci_dev *hdev, uint16_t interval)
 	/* Pause advertising since active scanning disables address resolution
 	 * which advertising depend on in order to generate its RPAs.
 	 */
-	if (use_ll_privacy(hdev)) {
+	if (use_ll_privacy(hdev) && hci_dev_test_flag(hdev, HCI_PRIVACY)) {
 		err = hci_pause_advertising_sync(hdev);
 		if (err) {
 			bt_dev_err(hdev, "pause advertising failed: %d", err);
-- 
2.37.2.789.g6183377224-goog


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: Bluetooth: hci_sync: allow advertising during active scan without privacy
  2022-09-13 22:04 ` [kernel PATCH v1 1/1] " Zhengping Jiang
@ 2022-09-13 23:11   ` bluez.test.bot
  0 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2022-09-13 23:11 UTC (permalink / raw)
  To: linux-bluetooth, jiangzp

[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=676705

---Test result---

Test Summary:
CheckPatch                    PASS      0.94 seconds
GitLint                       FAIL      0.47 seconds
SubjectPrefix                 PASS      0.31 seconds
BuildKernel                   PASS      40.55 seconds
BuildKernel32                 PASS      35.44 seconds
Incremental Build with patchesPASS      52.30 seconds
TestRunner: Setup             PASS      604.47 seconds
TestRunner: l2cap-tester      PASS      19.00 seconds
TestRunner: iso-tester        PASS      18.39 seconds
TestRunner: bnep-tester       PASS      7.23 seconds
TestRunner: mgmt-tester       PASS      115.07 seconds
TestRunner: rfcomm-tester     PASS      11.59 seconds
TestRunner: sco-tester        PASS      10.92 seconds
TestRunner: smp-tester        PASS      10.75 seconds
TestRunner: userchan-tester   PASS      7.73 seconds

Details
##############################
Test: GitLint - FAIL - 0.47 seconds
Run gitlint with rule in .gitlint
[kernel,v1,1/1] Bluetooth: hci_sync: allow advertising during active scan without privacy
1: T1 Title exceeds max length (89>80): "[kernel,v1,1/1] Bluetooth: hci_sync: allow advertising during active scan without privacy"




---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [kernel PATCH v1 0/1] Bluetooth: hci_sync: allow advertising during active scan without privacy
  2022-09-13 22:04 [kernel PATCH v1 0/1] Bluetooth: hci_sync: allow advertising during active scan without privacy Zhengping Jiang
  2022-09-13 22:04 ` [kernel PATCH v1 1/1] " Zhengping Jiang
@ 2022-09-14 20:10 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+bluetooth @ 2022-09-14 20:10 UTC (permalink / raw)
  To: Zhengping Jiang
  Cc: linux-bluetooth, marcel, davem, edumazet, kuba, johan.hedberg,
	luiz.dentz, pabeni, linux-kernel, netdev

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 13 Sep 2022 15:04:32 -0700 you wrote:
> This patch allows the device to keep advertising during active scan when
> ll privacy is enabled, if the device is not using privacy mode.
> 
> Changes in v1:
> - Check privacy flag when disable advertising
> 
> Zhengping Jiang (1):
>   Bluetooth: hci_sync: allow advertising during active scan without
>     privacy
> 
> [...]

Here is the summary with links:
  - [kernel,v1,1/1] Bluetooth: hci_sync: allow advertising during active scan without privacy
    https://git.kernel.org/bluetooth/bluetooth-next/c/9afc675edeeb

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-09-14 20:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-13 22:04 [kernel PATCH v1 0/1] Bluetooth: hci_sync: allow advertising during active scan without privacy Zhengping Jiang
2022-09-13 22:04 ` [kernel PATCH v1 1/1] " Zhengping Jiang
2022-09-13 23:11   ` bluez.test.bot
2022-09-14 20:10 ` [kernel PATCH v1 0/1] " patchwork-bot+bluetooth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.