* [PATCH] scsi: qla2xxx: Fix memory leak in __qlt_24xx_handle_abts()
@ 2022-09-14 2:49 Rafael Mendonca
2022-09-14 16:23 ` Himanshu Madhani
2022-09-16 3:01 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Rafael Mendonca @ 2022-09-14 2:49 UTC (permalink / raw)
To: Nilesh Javali, GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, Mike Christie, Himanshu Madhani
Cc: Rafael Mendonca, linux-scsi, linux-kernel
Commit 8f394da36a36 ("scsi: qla2xxx: Drop TARGET_SCF_LOOKUP_LUN_FROM_TAG")
made the __qlt_24xx_handle_abts() function return early if
tcm_qla2xxx_find_cmd_by_tag() doesn't find a command, but it missed to
clean up the allocated memory for the management command in such a case.
Fixes: 8f394da36a36 ("scsi: qla2xxx: Drop TARGET_SCF_LOOKUP_LUN_FROM_TAG")
Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
---
drivers/scsi/qla2xxx/qla_target.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 62666df1a59e..4acff4e84b90 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -2151,8 +2151,10 @@ static int __qlt_24xx_handle_abts(struct scsi_qla_host *vha,
abort_cmd = ha->tgt.tgt_ops->find_cmd_by_tag(sess,
le32_to_cpu(abts->exchange_addr_to_abort));
- if (!abort_cmd)
+ if (!abort_cmd) {
+ mempool_free(mcmd, qla_tgt_mgmt_cmd_mempool);
return -EIO;
+ }
mcmd->unpacked_lun = abort_cmd->se_cmd.orig_fe_lun;
if (abort_cmd->qpair) {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Fix memory leak in __qlt_24xx_handle_abts()
2022-09-14 2:49 [PATCH] scsi: qla2xxx: Fix memory leak in __qlt_24xx_handle_abts() Rafael Mendonca
@ 2022-09-14 16:23 ` Himanshu Madhani
2022-09-16 3:01 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Himanshu Madhani @ 2022-09-14 16:23 UTC (permalink / raw)
To: Rafael Mendonca
Cc: Nilesh Javali, GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin Petersen, Michael Christie, linux-scsi, linux-kernel
> On Sep 13, 2022, at 7:49 PM, Rafael Mendonca <rafaelmendsr@gmail.com> wrote:
>
> Commit 8f394da36a36 ("scsi: qla2xxx: Drop TARGET_SCF_LOOKUP_LUN_FROM_TAG")
> made the __qlt_24xx_handle_abts() function return early if
> tcm_qla2xxx_find_cmd_by_tag() doesn't find a command, but it missed to
> clean up the allocated memory for the management command in such a case.
>
> Fixes: 8f394da36a36 ("scsi: qla2xxx: Drop TARGET_SCF_LOOKUP_LUN_FROM_TAG")
> Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 62666df1a59e..4acff4e84b90 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -2151,8 +2151,10 @@ static int __qlt_24xx_handle_abts(struct scsi_qla_host *vha,
>
> abort_cmd = ha->tgt.tgt_ops->find_cmd_by_tag(sess,
> le32_to_cpu(abts->exchange_addr_to_abort));
> - if (!abort_cmd)
> + if (!abort_cmd) {
> + mempool_free(mcmd, qla_tgt_mgmt_cmd_mempool);
> return -EIO;
> + }
> mcmd->unpacked_lun = abort_cmd->se_cmd.orig_fe_lun;
>
> if (abort_cmd->qpair) {
> --
> 2.34.1
>
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Fix memory leak in __qlt_24xx_handle_abts()
2022-09-14 2:49 [PATCH] scsi: qla2xxx: Fix memory leak in __qlt_24xx_handle_abts() Rafael Mendonca
2022-09-14 16:23 ` Himanshu Madhani
@ 2022-09-16 3:01 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-09-16 3:01 UTC (permalink / raw)
To: Himanshu Madhani, James E.J. Bottomley, Rafael Mendonca,
Nilesh Javali, Mike Christie, GR-QLogic-Storage-Upstream
Cc: Martin K . Petersen, linux-scsi, linux-kernel
On Tue, 13 Sep 2022 23:49:24 -0300, Rafael Mendonca wrote:
> Commit 8f394da36a36 ("scsi: qla2xxx: Drop TARGET_SCF_LOOKUP_LUN_FROM_TAG")
> made the __qlt_24xx_handle_abts() function return early if
> tcm_qla2xxx_find_cmd_by_tag() doesn't find a command, but it missed to
> clean up the allocated memory for the management command in such a case.
>
>
Applied to 6.0/scsi-fixes, thanks!
[1/1] scsi: qla2xxx: Fix memory leak in __qlt_24xx_handle_abts()
https://git.kernel.org/mkp/scsi/c/601be20fc6a1
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-16 3:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-14 2:49 [PATCH] scsi: qla2xxx: Fix memory leak in __qlt_24xx_handle_abts() Rafael Mendonca
2022-09-14 16:23 ` Himanshu Madhani
2022-09-16 3:01 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.