* [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback
@ 2022-09-19 13:05 Kandpal, Suraj
2022-09-19 13:05 ` [Intel-gfx] [PATCH v6 1/3] drm/i915: Define WD trancoder for i915 Kandpal, Suraj
` (21 more replies)
0 siblings, 22 replies; 30+ messages in thread
From: Kandpal, Suraj @ 2022-09-19 13:05 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
A patch series was floated in the drm mailing list which aimed to change
the drm_connector and drm_encoder fields to pointer in the
drm_connector_writeback structure, this received a huge pushback from
the community but since i915 expects each connector present in the
drm_device list to be a intel_connector but drm_writeback framework
makes us have a connector which cannot be embedded in an intel_connector
structure.
[1]
https://patchwork.kernel.org/project/dri-devel/patch/20220202081702.22119-1-suraj.kandpal@intel.com/
[2]
https://patchwork.kernel.org/project/dri-devel/patch/20220202085429.22261-6-suraj.kandpal@intel.com/
Since no one had an issue with encoder field being changed into a
pointer it was decided to break the connector and encoder pointer
changes into two different series.The encoder field changes is
currently being worked upon by Abhinav Kumar and the changes have been
merged.
[3]https://patchwork.kernel.org/project/dri-devel/list/?series=633565
Going forward we use a drm_connector which is not embedded in
intel_connector.
We also create a intel_encoder to avoid changes to many
iterators but no intel_connector. We also changed all iterators that
---v2
solving BAT issues
---v3
-removing unecessary comments from i915_reg.h [Arun]
-moving wd_init into its own if condition [Arun]
-fixing comment styling and alignment in intel_wd.c [Arun]
-removing continue from loop and calling function if condition is met
[Arun]
-removing useless arguments from intel_queue_writeback_job and
intel_enabling_capture [Arun]
--v4
Adding Reviewed-by to patches which were previously reviewd
--v5
Adding Reviewed-by for patch 3
--v6
Solving BAT issue
changes for checkpatch to pass
Suraj Kandpal (3):
drm/i915: Define WD trancoder for i915
drm/i915 : Changing intel_connector iterators
drm/i915: Enabling WD Transcoder
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/intel_acpi.c | 8 +-
drivers/gpu/drm/i915/display/intel_crtc.c | 6 +
.../drm/i915/display/intel_crtc_state_dump.c | 1 +
drivers/gpu/drm/i915/display/intel_ddi.c | 6 +
drivers/gpu/drm/i915/display/intel_display.c | 68 +-
drivers/gpu/drm/i915/display/intel_display.h | 18 +-
.../drm/i915/display/intel_display_debugfs.c | 13 +-
.../drm/i915/display/intel_display_types.h | 32 +-
drivers/gpu/drm/i915/display/intel_dpll.c | 6 +
.../drm/i915/display/intel_modeset_setup.c | 119 ++-
.../drm/i915/display/intel_modeset_verify.c | 17 +-
drivers/gpu/drm/i915/display/intel_opregion.c | 3 +
drivers/gpu/drm/i915/display/intel_wd.c | 694 ++++++++++++++++++
drivers/gpu/drm/i915/display/intel_wd.h | 48 ++
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 8 +-
drivers/gpu/drm/i915/i915_pci.c | 7 +-
drivers/gpu/drm/i915/i915_reg.h | 137 ++++
19 files changed, 1137 insertions(+), 56 deletions(-)
create mode 100644 drivers/gpu/drm/i915/display/intel_wd.c
create mode 100644 drivers/gpu/drm/i915/display/intel_wd.h
--
2.25.1
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] [PATCH v6 1/3] drm/i915: Define WD trancoder for i915
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
@ 2022-09-19 13:05 ` Kandpal, Suraj
2022-10-05 9:07 ` Jani Nikula
2022-09-19 13:05 ` [Intel-gfx] [PATCH v6 2/3] drm/i915 : Changing intel_connector iterators Kandpal, Suraj
` (20 subsequent siblings)
21 siblings, 1 reply; 30+ messages in thread
From: Kandpal, Suraj @ 2022-09-19 13:05 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
From: Suraj Kandpal <suraj.kandpal@intel.com>
Adding WD Types, WD transcoder to enum list and WD Transcoder offsets.
Adding i915 register definitions related to WD transcoder
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.h | 6 +
.../drm/i915/display/intel_display_types.h | 1 +
drivers/gpu/drm/i915/i915_reg.h | 137 ++++++++++++++++++
3 files changed, 144 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
index 884e8e67b17c..a1ed9c82e2ed 100644
--- a/drivers/gpu/drm/i915/display/intel_display.h
+++ b/drivers/gpu/drm/i915/display/intel_display.h
@@ -120,6 +120,8 @@ enum transcoder {
TRANSCODER_DSI_1,
TRANSCODER_DSI_A = TRANSCODER_DSI_0, /* legacy DSI */
TRANSCODER_DSI_C = TRANSCODER_DSI_1, /* legacy DSI */
+ TRANSCODER_WD_0,
+ TRANSCODER_WD_1,
I915_MAX_TRANSCODERS
};
@@ -141,6 +143,10 @@ static inline const char *transcoder_name(enum transcoder transcoder)
return "DSI A";
case TRANSCODER_DSI_C:
return "DSI C";
+ case TRANSCODER_WD_0:
+ return "WD 0";
+ case TRANSCODER_WD_1:
+ return "WD 1";
default:
return "<invalid>";
}
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 298d00a11f47..633cacd79074 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -79,6 +79,7 @@ enum intel_output_type {
INTEL_OUTPUT_DSI = 9,
INTEL_OUTPUT_DDI = 10,
INTEL_OUTPUT_DP_MST = 11,
+ INTEL_OUTPUT_WD = 12,
};
enum hdmi_force_audio {
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 78038f48ddf2..e8d5ee131838 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -2011,6 +2011,8 @@
#define TRANSCODER_EDP_OFFSET 0x6f000
#define TRANSCODER_DSI0_OFFSET 0x6b000
#define TRANSCODER_DSI1_OFFSET 0x6b800
+#define TRANSCODER_WD0_OFFSET 0x6e000
+#define TRANSCODER_WD1_OFFSET 0x6e800
#define HTOTAL(trans) _MMIO_TRANS2(trans, _HTOTAL_A)
#define HBLANK(trans) _MMIO_TRANS2(trans, _HBLANK_A)
@@ -3701,6 +3703,9 @@
#define PIPE_DSI0_OFFSET 0x7b000
#define PIPE_DSI1_OFFSET 0x7b800
+#define PIPE_WD0_OFFSET 0x7e000
+#define PIPE_WD1_OFFSET 0x7d000
+
#define PIPECONF(pipe) _MMIO_PIPE2(pipe, _PIPEACONF)
#define PIPEDSL(pipe) _MMIO_PIPE2(pipe, _PIPEADSL)
#define PIPEFRAME(pipe) _MMIO_PIPE2(pipe, _PIPEAFRAMEHIGH)
@@ -4365,6 +4370,10 @@
#define _PIPEDSI0CONF 0x7b008
#define _PIPEDSI1CONF 0x7b808
+/* WD 0 and 1 */
+#define _PIPEWD0CONF 0x7e008
+#define _PIPEWD1CONF 0x7d008
+
/* Sprite A control */
#define _DVSACNTR 0x72180
#define DVS_ENABLE REG_BIT(31)
@@ -5590,6 +5599,7 @@
#define GEN8_DE_MISC_IER _MMIO(0x4446c)
#define GEN8_DE_MISC_GSE (1 << 27)
#define GEN8_DE_EDP_PSR (1 << 19)
+#define GEN8_DE_MISC_WD0 (1 << 23)
#define GEN8_PCU_ISR _MMIO(0x444e0)
#define GEN8_PCU_IMR _MMIO(0x444e4)
@@ -8334,6 +8344,133 @@ enum skl_power_gate {
#define DSB_ENABLE (1 << 31)
#define DSB_STATUS (1 << 0)
+#define TGL_ROOT_DEVICE_ID 0x9A00
+#define TGL_ROOT_DEVICE_MASK 0xFF00
+#define TGL_ROOT_DEVICE_SKU_MASK 0xF
+#define TGL_ROOT_DEVICE_SKU_ULX 0x2
+#define TGL_ROOT_DEVICE_SKU_ULT 0x4
+
+/* Gen12 WD */
+#define _MMIO_WD(tc, wd0, wd1) _MMIO_TRANS((tc) - TRANSCODER_WD_0, \
+ wd0, wd1)
+
+#define WD_TRANS_ENABLE (1 << 31)
+#define WD_TRANS_DISABLE 0
+#define WD_TRANS_ACTIVE (1 << 30)
+
+/* WD transcoder control */
+#define _WD_TRANS_FUNC_CTL_0 0x6e400
+#define _WD_TRANS_FUNC_CTL_1 0x6ec00
+#define WD_TRANS_FUNC_CTL(tc) _MMIO_WD(tc,\
+ _WD_TRANS_FUNC_CTL_0,\
+ _WD_TRANS_FUNC_CTL_1)
+
+#define TRANS_WD_FUNC_ENABLE (1 << 31)
+#define WD_TRIGGERED_CAP_MODE_ENABLE (1 << 30)
+#define START_TRIGGER_FRAME (1 << 29)
+#define STOP_TRIGGER_FRAME (1 << 28)
+#define WD_CTL_POINTER_ETEH (0 << 18)
+#define WD_CTL_POINTER_ETDH (1 << 18)
+#define WD_CTL_POINTER_DTDH (2 << 18)
+#define WD_INPUT_SELECT_MASK (7 << 12)
+#define WD_INPUT_PIPE_A (0 << 12)
+#define WD_INPUT_PIPE_B (5 << 12)
+#define WD_INPUT_PIPE_C (6 << 12)
+#define WD_INPUT_PIPE_D (7 << 12)
+
+#define WD_PIX_FMT_MASK (0x3 << 20)
+#define WD_PIX_FMT_YUYV (0x1 << 20)
+#define WD_PIX_FMT_XYUV8888 (0x2 << 20)
+#define WD_PIX_FMT_XBGR8888 (0x3 << 20)
+#define WD_PIX_FMT_Y410 (0x4 << 20)
+#define WD_PIX_FMT_YUV422 (0x5 << 20)
+#define WD_PIX_FMT_XBGR2101010 (0x6 << 20)
+#define WD_PIX_FMT_RGB565 (0x7 << 20)
+
+#define WD_FRAME_NUMBER_MASK 15
+
+#define _WD_STRIDE_0 0x6e510
+#define _WD_STRIDE_1 0x6ed10
+#define WD_STRIDE(tc) _MMIO_WD(tc,\
+ _WD_STRIDE_0,\
+ _WD_STRIDE_1)
+#define WD_STRIDE_SHIFT 6
+#define WD_STRIDE_MASK (0x3ff << WD_STRIDE_SHIFT)
+
+#define _WD_STREAMCAP_CTL0 0x6e590
+#define _WD_STREAMCAP_CTL1 0x6ed90
+#define WD_STREAMCAP_CTL(tc) _MMIO_WD(tc,\
+ _WD_STREAMCAP_CTL0,\
+ _WD_STREAMCAP_CTL1)
+
+#define WD_STREAM_CAP_MODE_EN (1 << 31)
+#define WD_STRAT_MASK (3 << 24)
+#define WD_SLICING_STRAT_1_1 (0 << 24)
+#define WD_SLICING_STRAT_2_1 (1 << 24)
+#define WD_SLICING_STRAT_4_1 (2 << 24)
+#define WD_SLICING_STRAT_8_1 (3 << 24)
+#define WD_STREAM_OVERRUN_STATUS 1
+
+#define _WD_SURF_0 0x6e514
+#define _WD_SURF_1 0x6ed14
+#define WD_SURF(tc) _MMIO_WD(tc,\
+ _WD_SURF_0,\
+ _WD_SURF_1)
+
+#define _WD_IMR_0 0x6e560
+#define _WD_IMR_1 0x6ed60
+#define WD_IMR(tc) _MMIO_WD(tc,\
+ _WD_IMR_0,\
+ _WD_IMR_1)
+#define WD_FRAME_COMPLETE_INT (1 << 7)
+#define WD_GTT_FAULT_INT (1 << 6)
+#define WD_VBLANK_INT (1 << 5)
+#define WD_OVERRUN_INT (1 << 4)
+#define WD_CAPTURING_INT (1 << 3)
+#define WD_WRITE_COMPLETE_INT (1 << 2)
+
+#define _WD_IIR_0 0x6e564
+#define _WD_IIR_1 0x6ed64
+#define WD_IIR(tc) _MMIO_WD(tc,\
+ _WD_IIR_0,\
+ _WD_IIR_1)
+
+#define _WD_FRAME_STATUS_0 0x6e56b
+#define _WD_FRAME_STATUS_1 0x6ed6b
+#define WD_FRAME_STATUS(tc) _MMIO_WD(tc,\
+ _WD_FRAME_STATUS_0,\
+ _WD_FRAME_STATUS_1)
+
+#define WD_FRAME_COMPLETE (1 << 31)
+#define WD_STATE_IDLE (0 << 24)
+#define WD_STATE_CAPSTART (1 << 24)
+#define WD_STATE_FRAME_START (2 << 24)
+#define WD_STATE_CAPACITIVE (3 << 24)
+#define WD_STATE_TG_DONE (4 << 24)
+#define WD_STATE_WDX_DONE (5 << 24)
+#define WD_STATE_QUICK_CAP (6 << 24)
+
+#define _WD_27_M_0 0x6e524
+#define _WD_27_M_1 0x6ed24
+#define WD_27_M(tc) _MMIO_WD(tc,\
+ _WD_27_M_0,\
+ _WD_27_M_1)
+
+#define _WD_27_N_0 0x6e528
+
+//Address looks wrong in bspec:
+#define _WD_27_N_1 0x6ec28
+#define WD_27_N(tc) _MMIO_WD(tc,\
+ _WD_27_N_0,\
+ _WD_27_N_1)
+
+#define _WD_TAIL_CFG_0 0x6e520
+#define _WD_TAIL_CFG_1 0x6ed20
+
+#define WD_TAIL_CFG(tc) _MMIO_WD(tc,\
+ _WD_TAIL_CFG_0,\
+ _WD_TAIL_CFG_1)
+
#define CLKREQ_POLICY _MMIO(0x101038)
#define CLKREQ_POLICY_MEM_UP_OVRD REG_BIT(1)
--
2.25.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [Intel-gfx] [PATCH v6 2/3] drm/i915 : Changing intel_connector iterators
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
2022-09-19 13:05 ` [Intel-gfx] [PATCH v6 1/3] drm/i915: Define WD trancoder for i915 Kandpal, Suraj
@ 2022-09-19 13:05 ` Kandpal, Suraj
2022-10-05 10:30 ` Jani Nikula
2022-09-19 13:05 ` [Intel-gfx] [PATCH v6 3/3] drm/i915: Enabling WD Transcoder Kandpal, Suraj
` (19 subsequent siblings)
21 siblings, 1 reply; 30+ messages in thread
From: Kandpal, Suraj @ 2022-09-19 13:05 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
From: Suraj Kandpal <suraj.kandpal@intel.com>
Changing intel_connector iterators as with writeback introduction
not all drm_connector will be embedded within intel_connector.
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_acpi.c | 7 ++++-
drivers/gpu/drm/i915/display/intel_display.h | 7 ++---
.../drm/i915/display/intel_display_types.h | 26 ++++++++++++++++++-
.../drm/i915/display/intel_modeset_setup.c | 16 +++++++++---
4 files changed, 46 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
index 9df78e7caa2b..912fe5c2ffe5 100644
--- a/drivers/gpu/drm/i915/display/intel_acpi.c
+++ b/drivers/gpu/drm/i915/display/intel_acpi.c
@@ -349,8 +349,13 @@ void intel_acpi_video_register(struct drm_i915_private *i915)
*/
drm_connector_list_iter_begin(&i915->drm, &conn_iter);
drm_for_each_connector_iter(connector, &conn_iter) {
- struct intel_panel *panel = &to_intel_connector(connector)->panel;
+ struct intel_panel *panel;
+ struct intel_connector *intel_connector =
+ to_intel_connector(connector);
+ if (!intel_connector)
+ continue;
+ panel = &intel_connector->panel;
if (panel->backlight.funcs && !panel->backlight.device) {
acpi_video_register_backlight();
break;
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
index a1ed9c82e2ed..102bf7d47ccc 100644
--- a/drivers/gpu/drm/i915/display/intel_display.h
+++ b/drivers/gpu/drm/i915/display/intel_display.h
@@ -52,6 +52,7 @@ struct intel_crtc_state;
struct intel_digital_port;
struct intel_dp;
struct intel_encoder;
+struct intel_connector;
struct intel_initial_plane_config;
struct intel_load_detect_pipe;
struct intel_plane;
@@ -469,16 +470,12 @@ enum hpd_pin {
for_each_if(intel_encoder_can_psr(intel_encoder))
#define for_each_intel_connector_iter(intel_connector, iter) \
- while ((intel_connector = to_intel_connector(drm_connector_list_iter_next(iter))))
+ while ((intel_connector = intel_connector_list_iter_next(iter)))
#define for_each_encoder_on_crtc(dev, __crtc, intel_encoder) \
list_for_each_entry((intel_encoder), &(dev)->mode_config.encoder_list, base.head) \
for_each_if((intel_encoder)->base.crtc == (__crtc))
-#define for_each_connector_on_encoder(dev, __encoder, intel_connector) \
- list_for_each_entry((intel_connector), &(dev)->mode_config.connector_list, base.head) \
- for_each_if((intel_connector)->base.encoder == (__encoder))
-
#define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \
for ((__i) = 0; \
(__i) < (__state)->base.dev->mode_config.num_total_plane && \
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 633cacd79074..a2d294929a64 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1498,12 +1498,14 @@ struct cxsr_latency {
#define to_intel_atomic_state(x) container_of(x, struct intel_atomic_state, base)
#define to_intel_crtc(x) container_of(x, struct intel_crtc, base)
#define to_intel_crtc_state(x) container_of(x, struct intel_crtc_state, uapi)
-#define to_intel_connector(x) container_of(x, struct intel_connector, base)
+#define to_intel_wb_connector(x) container_of(x, struct intel_wb_connector, base)
#define to_intel_encoder(x) container_of(x, struct intel_encoder, base)
#define to_intel_framebuffer(x) container_of(x, struct intel_framebuffer, base)
#define to_intel_plane(x) container_of(x, struct intel_plane, base)
#define to_intel_plane_state(x) container_of(x, struct intel_plane_state, uapi)
#define intel_fb_obj(x) ((x) ? to_intel_bo((x)->obj[0]) : NULL)
+#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \
+ NULL : container_of(x, struct intel_connector, base))
struct intel_hdmi {
i915_reg_t hdmi_reg;
@@ -2069,4 +2071,26 @@ to_intel_frontbuffer(struct drm_framebuffer *fb)
return fb ? to_intel_framebuffer(fb)->frontbuffer : NULL;
}
+static inline struct intel_connector *
+intel_connector_list_iter_next(struct drm_connector_list_iter *iter)
+{
+ struct drm_connector *connector;
+ bool flag = true;
+ /*
+ * Skipping connector that are Writeback connector as they will
+ * not be embedded in intel connector
+ */
+ while (flag) {
+ connector = drm_connector_list_iter_next(iter);
+ if (connector && !to_intel_connector(connector))
+ continue;
+
+ flag = false;
+
+ if (connector)
+ return to_intel_connector(connector);
+
+ }
+ return NULL;
+}
#endif /* __INTEL_DISPLAY_TYPES_H__ */
diff --git a/drivers/gpu/drm/i915/display/intel_modeset_setup.c b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
index cbfabd58b75a..e1a90331c230 100644
--- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
+++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
@@ -205,12 +205,22 @@ static bool intel_crtc_has_encoders(struct intel_crtc *crtc)
static struct intel_connector *intel_encoder_find_connector(struct intel_encoder *encoder)
{
- struct drm_device *dev = encoder->base.dev;
+ struct drm_i915_private *i915 = to_i915(encoder->base.dev);
struct intel_connector *connector;
+ struct drm_connector_list_iter conn_iter;
+ bool found_connector = false;
- for_each_connector_on_encoder(dev, &encoder->base, connector)
- return connector;
+ drm_connector_list_iter_begin(&i915->drm, &conn_iter);
+ for_each_intel_connector_iter(connector, &conn_iter) {
+ if (&encoder->base == connector->base.encoder) {
+ found_connector = true;
+ break;
+ }
+ }
+ drm_connector_list_iter_end(&conn_iter);
+ if (found_connector)
+ return connector;
return NULL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [Intel-gfx] [PATCH v6 3/3] drm/i915: Enabling WD Transcoder
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
2022-09-19 13:05 ` [Intel-gfx] [PATCH v6 1/3] drm/i915: Define WD trancoder for i915 Kandpal, Suraj
2022-09-19 13:05 ` [Intel-gfx] [PATCH v6 2/3] drm/i915 : Changing intel_connector iterators Kandpal, Suraj
@ 2022-09-19 13:05 ` Kandpal, Suraj
2022-09-28 15:23 ` Swati Sharma
2022-09-19 14:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev6) Patchwork
` (18 subsequent siblings)
21 siblings, 1 reply; 30+ messages in thread
From: Kandpal, Suraj @ 2022-09-19 13:05 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
From: Suraj Kandpal <suraj.kandpal@intel.com>
Adding support for writeback transcoder to start capturing frames using
interrupt mechanism
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/display/intel_acpi.c | 1 +
drivers/gpu/drm/i915/display/intel_crtc.c | 6 +
.../drm/i915/display/intel_crtc_state_dump.c | 1 +
drivers/gpu/drm/i915/display/intel_ddi.c | 6 +
drivers/gpu/drm/i915/display/intel_display.c | 68 +-
drivers/gpu/drm/i915/display/intel_display.h | 5 +
.../drm/i915/display/intel_display_debugfs.c | 13 +-
.../drm/i915/display/intel_display_types.h | 11 +-
drivers/gpu/drm/i915/display/intel_dpll.c | 6 +
.../drm/i915/display/intel_modeset_setup.c | 103 ++-
.../drm/i915/display/intel_modeset_verify.c | 17 +-
drivers/gpu/drm/i915/display/intel_opregion.c | 3 +
drivers/gpu/drm/i915/display/intel_wd.c | 694 ++++++++++++++++++
drivers/gpu/drm/i915/display/intel_wd.h | 48 ++
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 8 +-
drivers/gpu/drm/i915/i915_pci.c | 7 +-
18 files changed, 950 insertions(+), 49 deletions(-)
create mode 100644 drivers/gpu/drm/i915/display/intel_wd.c
create mode 100644 drivers/gpu/drm/i915/display/intel_wd.h
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index a26edcdadc21..f34db43cf58d 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -304,6 +304,7 @@ i915-y += \
display/intel_tv.o \
display/intel_vdsc.o \
display/intel_vrr.o \
+ display/intel_wd.o \
display/vlv_dsi.o \
display/vlv_dsi_pll.o
diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
index 912fe5c2ffe5..3321ef62fdbd 100644
--- a/drivers/gpu/drm/i915/display/intel_acpi.c
+++ b/drivers/gpu/drm/i915/display/intel_acpi.c
@@ -248,6 +248,7 @@ static u32 acpi_display_type(struct intel_connector *connector)
case DRM_MODE_CONNECTOR_LVDS:
case DRM_MODE_CONNECTOR_eDP:
case DRM_MODE_CONNECTOR_DSI:
+ case DRM_MODE_CONNECTOR_WRITEBACK:
display_type = ACPI_DISPLAY_TYPE_INTERNAL_DIGITAL;
break;
case DRM_MODE_CONNECTOR_Unknown:
diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c
index 6792a9056f46..66d552758720 100644
--- a/drivers/gpu/drm/i915/display/intel_crtc.c
+++ b/drivers/gpu/drm/i915/display/intel_crtc.c
@@ -491,6 +491,9 @@ void intel_pipe_update_start(struct intel_crtc_state *new_crtc_state)
if (new_crtc_state->do_async_flip)
return;
+ if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
+ return;
+
if (intel_crtc_needs_vblank_work(new_crtc_state))
intel_crtc_vblank_work_init(new_crtc_state);
@@ -638,6 +641,9 @@ void intel_pipe_update_end(struct intel_crtc_state *new_crtc_state)
if (new_crtc_state->do_async_flip)
return;
+ if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
+ return;
+
trace_intel_pipe_update_end(crtc, end_vbl_count, scanline_end);
/*
diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
index e9212f69c360..8435065f3b7d 100644
--- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
+++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
@@ -71,6 +71,7 @@ static const char * const output_type_str[] = {
OUTPUT_TYPE(DSI),
OUTPUT_TYPE(DDI),
OUTPUT_TYPE(DP_MST),
+ OUTPUT_TYPE(WD),
};
#undef OUTPUT_TYPE
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 643832d55c28..ea8e07a957ab 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -1953,6 +1953,12 @@ void intel_ddi_sanitize_encoder_pll_mapping(struct intel_encoder *encoder)
*/
if (encoder->type == INTEL_OUTPUT_DP_MST)
return;
+ /*
+ * WD transcoder is a virtual encoder hence sanization
+ * is not required for it
+ */
+ if (encoder->type == INTEL_OUTPUT_WD)
+ return;
if (!encoder->base.crtc && intel_encoder_is_dp(encoder)) {
u8 pipe_mask;
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index dd008ba8afe3..f34880799ce7 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -115,6 +115,7 @@
#include "intel_sprite.h"
#include "intel_tc.h"
#include "intel_vga.h"
+#include "intel_wd.h"
#include "i9xx_plane.h"
#include "skl_scaler.h"
#include "skl_universal_plane.h"
@@ -1514,6 +1515,10 @@ static void intel_encoders_update_prepare(struct intel_atomic_state *state)
continue;
intel_connector = to_intel_connector(connector);
+ /* intel_connector instance is not created for WD transcoder */
+ if (!intel_connector)
+ continue;
+
encoder = intel_connector_primary_encoder(intel_connector);
if (!encoder->update_prepare)
continue;
@@ -1543,6 +1548,10 @@ static void intel_encoders_update_complete(struct intel_atomic_state *state)
continue;
intel_connector = to_intel_connector(connector);
+ /* intel_connector instance is not created for WD transcoder */
+ if (!intel_connector)
+ continue;
+
encoder = intel_connector_primary_encoder(intel_connector);
if (!encoder->update_complete)
continue;
@@ -1553,6 +1562,38 @@ static void intel_encoders_update_complete(struct intel_atomic_state *state)
}
}
+static void intel_queue_writeback_job(struct intel_atomic_state *state)
+{
+ struct drm_connector_state *new_conn_state;
+ struct drm_connector *connector;
+ struct drm_writeback_connector *wb_conn;
+ int i;
+
+ for_each_new_connector_in_state(&state->base, connector, new_conn_state,
+ i) {
+ if (!new_conn_state->writeback_job)
+ continue;
+
+ wb_conn = drm_connector_to_writeback(connector);
+ drm_writeback_queue_job(wb_conn, new_conn_state);
+ }
+}
+
+static void intel_enable_writeback_capture(struct intel_atomic_state *state,
+ struct intel_crtc_state *crtc_state)
+{
+ struct drm_connector_state *new_conn_state;
+ struct drm_connector *connector;
+ int i;
+
+ for_each_new_connector_in_state(&state->base, connector, new_conn_state,
+ i) {
+ if (connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK)
+ continue;
+ intel_wd_enable_capture(crtc_state, new_conn_state);
+ }
+}
+
static void intel_encoders_pre_pll_enable(struct intel_atomic_state *state,
struct intel_crtc *crtc)
{
@@ -1653,8 +1694,12 @@ static void intel_encoders_post_disable(struct intel_atomic_state *state,
int i;
for_each_old_connector_in_state(&state->base, conn, old_conn_state, i) {
- struct intel_encoder *encoder =
- to_intel_encoder(old_conn_state->best_encoder);
+ struct intel_encoder *encoder;
+
+ if (conn->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)
+ continue;
+
+ encoder = to_intel_encoder(old_conn_state->best_encoder);
if (old_conn_state->crtc != &crtc->base)
continue;
@@ -1933,7 +1978,8 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
bdw_set_pipemisc(new_crtc_state);
if (!intel_crtc_is_bigjoiner_slave(new_crtc_state) &&
- !transcoder_is_dsi(cpu_transcoder))
+ !transcoder_is_dsi(cpu_transcoder) &&
+ !transcoder_is_wd(cpu_transcoder))
hsw_configure_cpu_transcoder(new_crtc_state);
crtc->active = true;
@@ -7535,6 +7581,11 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
}
}
+ for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
+ if ((new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD)))
+ intel_wd_set_vblank_event(state, crtc, new_crtc_state);
+ }
+
intel_encoders_update_prepare(state);
intel_dbuf_pre_plane_update(state);
@@ -7545,6 +7596,13 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
intel_crtc_enable_flip_done(state, crtc);
}
+ for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
+ if ((new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))) {
+ intel_queue_writeback_job(state);
+ intel_enable_writeback_capture(state, new_crtc_state);
+ }
+ }
+
/* Now enable the clocks, plane, pipe, and connectors that we set up. */
dev_priv->display.funcs.display->commit_modeset_enables(state);
@@ -7899,6 +7957,10 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
if (!HAS_DISPLAY(dev_priv))
return;
+ /* Initializing WD transcoder */
+ if (DISPLAY_VER(dev_priv) >= 12)
+ intel_wd_init(dev_priv, TRANSCODER_WD_0);
+
if (IS_DG2(dev_priv)) {
intel_ddi_init(dev_priv, PORT_A);
intel_ddi_init(dev_priv, PORT_B);
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
index 102bf7d47ccc..1ee5e8600809 100644
--- a/drivers/gpu/drm/i915/display/intel_display.h
+++ b/drivers/gpu/drm/i915/display/intel_display.h
@@ -158,6 +158,11 @@ static inline bool transcoder_is_dsi(enum transcoder transcoder)
return transcoder == TRANSCODER_DSI_A || transcoder == TRANSCODER_DSI_C;
}
+static inline bool transcoder_is_wd(enum transcoder transcoder)
+{
+ return transcoder == TRANSCODER_WD_0 || transcoder == TRANSCODER_WD_1;
+}
+
/*
* Global legacy plane identifier. Valid only for primary/sprite
* planes on pre-g4x, and only for primary planes on g4x-bdw.
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index 7c7253a2541c..b7a0be89302e 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -550,7 +550,7 @@ static void intel_hdmi_info(struct seq_file *m,
static void intel_connector_info(struct seq_file *m,
struct drm_connector *connector)
{
- struct intel_connector *intel_connector = to_intel_connector(connector);
+ struct intel_connector *intel_connector;
const struct drm_connector_state *conn_state = connector->state;
struct intel_encoder *encoder =
to_intel_encoder(conn_state->best_encoder);
@@ -573,6 +573,8 @@ static void intel_connector_info(struct seq_file *m,
if (!encoder)
return;
+ intel_connector = to_intel_connector(connector);
+
switch (connector->connector_type) {
case DRM_MODE_CONNECTOR_DisplayPort:
case DRM_MODE_CONNECTOR_eDP:
@@ -590,12 +592,15 @@ static void intel_connector_info(struct seq_file *m,
break;
}
- seq_puts(m, "\tHDCP version: ");
- intel_hdcp_info(m, intel_connector);
+ if (intel_connector) {
+ seq_puts(m, "\tHDCP version: ");
+ intel_hdcp_info(m, intel_connector);
+ }
seq_printf(m, "\tmax bpc: %u\n", connector->display_info.bpc);
- intel_panel_info(m, intel_connector);
+ if (intel_connector)
+ intel_panel_info(m, intel_connector);
seq_printf(m, "\tmodes:\n");
list_for_each_entry(mode, &connector->modes, head)
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index a2d294929a64..aef4427c0bd9 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -44,6 +44,7 @@
#include <drm/drm_vblank.h>
#include <drm/drm_vblank_work.h>
#include <drm/i915_mei_hdcp_interface.h>
+#include <drm/drm_writeback.h>
#include <media/cec-notifier.h>
#include "i915_vma.h"
@@ -1371,6 +1372,11 @@ struct intel_crtc {
bool cpu_fifo_underrun_disabled;
bool pch_fifo_underrun_disabled;
+ struct {
+ struct drm_pending_vblank_event *e;
+ atomic_t work_busy;
+ wait_queue_head_t wd_wait;
+ } wd;
/* per-pipe watermark state */
struct {
/* watermarks currently being used */
@@ -1498,7 +1504,6 @@ struct cxsr_latency {
#define to_intel_atomic_state(x) container_of(x, struct intel_atomic_state, base)
#define to_intel_crtc(x) container_of(x, struct intel_crtc, base)
#define to_intel_crtc_state(x) container_of(x, struct intel_crtc_state, uapi)
-#define to_intel_wb_connector(x) container_of(x, struct intel_wb_connector, base)
#define to_intel_encoder(x) container_of(x, struct intel_encoder, base)
#define to_intel_framebuffer(x) container_of(x, struct intel_framebuffer, base)
#define to_intel_plane(x) container_of(x, struct intel_plane, base)
@@ -2077,8 +2082,8 @@ intel_connector_list_iter_next(struct drm_connector_list_iter *iter)
struct drm_connector *connector;
bool flag = true;
/*
- * Skipping connector that are Writeback connector as they will
- * not be embedded in intel connector
+ * An intel_connector entity is not created for a writeback
+ * connector hence decoupling.
*/
while (flag) {
connector = drm_connector_list_iter_next(iter);
diff --git a/drivers/gpu/drm/i915/display/intel_dpll.c b/drivers/gpu/drm/i915/display/intel_dpll.c
index b15ba78d64d6..283b403c1ff9 100644
--- a/drivers/gpu/drm/i915/display/intel_dpll.c
+++ b/drivers/gpu/drm/i915/display/intel_dpll.c
@@ -940,6 +940,9 @@ static int hsw_crtc_compute_clock(struct intel_atomic_state *state,
intel_get_crtc_new_encoder(state, crtc_state);
int ret;
+ if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_WD))
+ return 0;
+
if (DISPLAY_VER(dev_priv) < 11 &&
intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI))
return 0;
@@ -968,6 +971,9 @@ static int hsw_crtc_get_shared_dpll(struct intel_atomic_state *state,
struct intel_encoder *encoder =
intel_get_crtc_new_encoder(state, crtc_state);
+ if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_WD))
+ return 0;
+
if (DISPLAY_VER(dev_priv) < 11 &&
intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI))
return 0;
diff --git a/drivers/gpu/drm/i915/display/intel_modeset_setup.c b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
index e1a90331c230..15792a5dd04c 100644
--- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
+++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
@@ -24,6 +24,7 @@
#include "intel_pch_display.h"
#include "intel_pm.h"
#include "skl_watermark.h"
+#include "intel_wd.h"
static void intel_crtc_disable_noatomic(struct intel_crtc *crtc,
struct drm_modeset_acquire_ctx *ctx)
@@ -111,17 +112,17 @@ static void intel_crtc_disable_noatomic(struct intel_crtc *crtc,
static void intel_modeset_update_connector_atomic_state(struct drm_i915_private *i915)
{
- struct intel_connector *connector;
+ struct drm_connector *connector;
struct drm_connector_list_iter conn_iter;
drm_connector_list_iter_begin(&i915->drm, &conn_iter);
- for_each_intel_connector_iter(connector, &conn_iter) {
- struct drm_connector_state *conn_state = connector->base.state;
+ drm_for_each_connector_iter(connector, &conn_iter) {
+ struct drm_connector_state *conn_state = connector->state;
struct intel_encoder *encoder =
- to_intel_encoder(connector->base.encoder);
+ to_intel_encoder(connector->encoder);
if (conn_state->crtc)
- drm_connector_put(&connector->base);
+ drm_connector_put(connector);
if (encoder) {
struct intel_crtc *crtc =
@@ -133,7 +134,7 @@ static void intel_modeset_update_connector_atomic_state(struct drm_i915_private
conn_state->crtc = &crtc->base;
conn_state->max_bpc = (crtc_state->pipe_bpp ?: 24) / 3;
- drm_connector_get(&connector->base);
+ drm_connector_get(connector);
} else {
conn_state->best_encoder = NULL;
conn_state->crtc = NULL;
@@ -433,6 +434,8 @@ static void intel_modeset_readout_hw_state(struct drm_i915_private *i915)
struct intel_crtc *crtc;
struct intel_encoder *encoder;
struct intel_connector *connector;
+ struct drm_connector *_connector;
+ struct drm_encoder *_encoder;
struct drm_connector_list_iter conn_iter;
u8 active_pipes = 0;
@@ -509,38 +512,70 @@ static void intel_modeset_readout_hw_state(struct drm_i915_private *i915)
intel_dpll_readout_hw_state(i915);
drm_connector_list_iter_begin(&i915->drm, &conn_iter);
- for_each_intel_connector_iter(connector, &conn_iter) {
- if (connector->get_hw_state(connector)) {
- struct intel_crtc_state *crtc_state;
- struct intel_crtc *crtc;
-
- connector->base.dpms = DRM_MODE_DPMS_ON;
-
- encoder = intel_attached_encoder(connector);
- connector->base.encoder = &encoder->base;
-
- crtc = to_intel_crtc(encoder->base.crtc);
- crtc_state = crtc ? to_intel_crtc_state(crtc->base.state) : NULL;
-
- if (crtc_state && crtc_state->hw.active) {
- /*
- * This has to be done during hardware readout
- * because anything calling .crtc_disable may
- * rely on the connector_mask being accurate.
- */
- crtc_state->uapi.connector_mask |=
- drm_connector_mask(&connector->base);
- crtc_state->uapi.encoder_mask |=
- drm_encoder_mask(&encoder->base);
+ drm_for_each_connector_iter(_connector, &conn_iter) {
+ struct intel_crtc_state *crtc_state;
+ struct intel_crtc *crtc;
+ struct drm_writeback_connector *wb_conn;
+ struct intel_wd *intel_wd;
+
+ connector = to_intel_connector(_connector);
+ if (!connector) {
+ wb_conn = drm_connector_to_writeback(_connector);
+ intel_wd = wb_conn_to_intel_wd(wb_conn);
+ _encoder = &intel_wd->base.base;
+ _connector->encoder = _encoder;
+ encoder = to_intel_encoder(_encoder);
+ pipe = 0;
+ if (encoder->get_hw_state(encoder, &pipe)) {
+ _connector->dpms = DRM_MODE_DPMS_ON;
+ crtc = to_intel_crtc(_encoder->crtc);
+ crtc_state = crtc ? to_intel_crtc_state(crtc->base.state) : NULL;
+
+ if (crtc_state && crtc_state->hw.active) {
+ /*
+ * This has to be done during hardware readout
+ * because anything calling .crtc_disable may
+ * rely on the connector_mask being accurate.
+ */
+ crtc_state->uapi.connector_mask |=
+ drm_connector_mask(&connector->base);
+ crtc_state->uapi.encoder_mask |=
+ drm_encoder_mask(&encoder->base);
+ }
+ } else {
+ _connector->dpms = DRM_MODE_DPMS_OFF;
+ _connector->encoder = NULL;
}
} else {
- connector->base.dpms = DRM_MODE_DPMS_OFF;
- connector->base.encoder = NULL;
+ if (connector->get_hw_state(connector)) {
+ connector->base.dpms = DRM_MODE_DPMS_OFF;
+ encoder = intel_attached_encoder(connector);
+ connector->base.encoder = &encoder->base;
+
+ crtc = to_intel_crtc(encoder->base.crtc);
+ crtc_state = crtc ? to_intel_crtc_state(crtc->base.state) : NULL;
+
+ if (crtc_state && crtc_state->hw.active) {
+ /*
+ * This has to be done during hardware readout
+ * because anything calling .crtc_disable may
+ * rely on the connector_mask being accurate.
+ */
+ crtc_state->uapi.connector_mask |=
+ drm_connector_mask(&connector->base);
+ crtc_state->uapi.encoder_mask |=
+ drm_encoder_mask(&encoder->base);
+ }
+ } else {
+ connector->base.dpms = DRM_MODE_DPMS_OFF;
+ connector->base.encoder = NULL;
+ }
}
drm_dbg_kms(&i915->drm,
- "[CONNECTOR:%d:%s] hw state readout: %s\n",
- connector->base.base.id, connector->base.name,
- str_enabled_disabled(connector->base.encoder));
+ "[CONNECTOR:%d:%s] hw state readout: %s\n",
+ _connector->base.id, _connector->name,
+ str_enabled_disabled(_connector->encoder));
+
}
drm_connector_list_iter_end(&conn_iter);
diff --git a/drivers/gpu/drm/i915/display/intel_modeset_verify.c b/drivers/gpu/drm/i915/display/intel_modeset_verify.c
index 0fdcf2e6d57f..80e9840e2e5f 100644
--- a/drivers/gpu/drm/i915/display/intel_modeset_verify.c
+++ b/drivers/gpu/drm/i915/display/intel_modeset_verify.c
@@ -25,11 +25,16 @@
static void intel_connector_verify_state(struct intel_crtc_state *crtc_state,
struct drm_connector_state *conn_state)
{
- struct intel_connector *connector = to_intel_connector(conn_state->connector);
- struct drm_i915_private *i915 = to_i915(connector->base.dev);
+ struct drm_connector *_connector = conn_state->connector;
+ struct intel_connector *connector;
+ struct drm_i915_private *i915 = to_i915(_connector->dev);
drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s]\n",
- connector->base.base.id, connector->base.name);
+ _connector->base.id, _connector->name);
+
+ connector = to_intel_connector(_connector);
+ if (!connector)
+ return;
if (connector->get_hw_state(connector)) {
struct intel_encoder *encoder = intel_attached_encoder(connector);
@@ -119,6 +124,9 @@ verify_encoder_state(struct drm_i915_private *dev_priv, struct intel_atomic_stat
encoder->base.base.id,
encoder->base.name);
+ if (encoder->type == INTEL_OUTPUT_WD)
+ continue;
+
for_each_oldnew_connector_in_state(&state->base, connector, old_conn_state,
new_conn_state, i) {
if (old_conn_state->best_encoder == &encoder->base)
@@ -177,6 +185,9 @@ verify_crtc_state(struct intel_crtc *crtc,
intel_crtc_get_pipe_config(pipe_config);
+ if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
+ return;
+
/* we keep both pipes enabled on 830 */
if (IS_I830(dev_priv) && pipe_config->hw.active)
pipe_config->hw.active = new_crtc_state->hw.active;
diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c
index caa07ef34f21..1bcb4b58d992 100644
--- a/drivers/gpu/drm/i915/display/intel_opregion.c
+++ b/drivers/gpu/drm/i915/display/intel_opregion.c
@@ -374,6 +374,9 @@ int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder,
if (ret)
return ret;
+ if (intel_encoder->type == INTEL_OUTPUT_WD)
+ return 0;
+
if (intel_encoder->type == INTEL_OUTPUT_DSI)
port = 0;
else
diff --git a/drivers/gpu/drm/i915/display/intel_wd.c b/drivers/gpu/drm/i915/display/intel_wd.c
new file mode 100644
index 000000000000..b904ce5e1dae
--- /dev/null
+++ b/drivers/gpu/drm/i915/display/intel_wd.c
@@ -0,0 +1,694 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2022 Intel Corporation
+ */
+
+#include <drm/drm_atomic_helper.h>
+#include <drm/drm_fourcc.h>
+
+#include "intel_atomic.h"
+#include "intel_connector.h"
+#include "intel_wd.h"
+#include "intel_fb_pin.h"
+#include "intel_de.h"
+
+enum {
+ WD_CAPTURE_4_PIX,
+ WD_CAPTURE_2_PIX,
+} wd_capture_format;
+
+struct drm_writeback_job
+*intel_get_writeback_job_from_queue(struct intel_wd *intel_wd)
+{
+ struct drm_writeback_job *job;
+ struct drm_i915_private *i915 = to_i915(intel_wd->base.base.dev);
+ struct drm_writeback_connector *wb_conn =
+ &intel_wd->wb_conn;
+ unsigned long flags;
+
+ spin_lock_irqsave(&wb_conn->job_lock, flags);
+ job = list_first_entry_or_null(&wb_conn->job_queue,
+ struct drm_writeback_job,
+ list_entry);
+ spin_unlock_irqrestore(&wb_conn->job_lock, flags);
+ if (job == NULL) {
+ drm_dbg_kms(&i915->drm, "job queue is empty\n");
+ return NULL;
+ }
+
+ return job;
+}
+
+static const u32 wd_fmts[] = {
+ DRM_FORMAT_YUV444,
+ DRM_FORMAT_XYUV8888,
+ DRM_FORMAT_XBGR8888,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_Y410,
+ DRM_FORMAT_YUV422,
+ DRM_FORMAT_XBGR2101010,
+ DRM_FORMAT_RGB565,
+};
+
+static int intel_wd_get_format(int pixel_format)
+{
+ int wd_format = -EINVAL;
+
+ switch (pixel_format) {
+ case DRM_FORMAT_XBGR8888:
+ case DRM_FORMAT_XRGB8888:
+ case DRM_FORMAT_XBGR2101010:
+ case DRM_FORMAT_XYUV8888:
+ case DRM_FORMAT_YUV444:
+ wd_format = WD_CAPTURE_4_PIX;
+ break;
+ case DRM_FORMAT_YUV422:
+ case DRM_FORMAT_RGB565:
+ wd_format = WD_CAPTURE_2_PIX;
+ break;
+ default:
+ DRM_ERROR("unsupported pixel format %x!\n",
+ pixel_format);
+ }
+
+ return wd_format;
+}
+
+static int intel_wd_verify_pix_format(int format)
+{
+ const struct drm_format_info *info = drm_format_info(format);
+ int pix_format = info->format;
+ int i = 0;
+
+ for (i = 0; i < ARRAY_SIZE(wd_fmts); i++)
+ if (pix_format == wd_fmts[i])
+ return 0;
+
+ return true;
+}
+
+static u32 intel_wd_get_stride(const struct intel_crtc_state *crtc_state,
+ int format)
+{
+ const struct drm_format_info *info = drm_format_info(format);
+ int wd_format;
+ int hactive, pixel_size;
+
+ wd_format = intel_wd_get_format(info->format);
+
+ switch (wd_format) {
+ case WD_CAPTURE_4_PIX:
+ pixel_size = 4;
+ break;
+ case WD_CAPTURE_2_PIX:
+ pixel_size = 2;
+ break;
+ default:
+ pixel_size = 1;
+ break;
+ }
+
+ hactive = crtc_state->hw.adjusted_mode.crtc_hdisplay;
+
+ return DIV_ROUND_UP(hactive * pixel_size, 64);
+}
+
+static int intel_wd_pin_fb(struct intel_wd *intel_wd,
+ struct drm_framebuffer *fb)
+{
+ const struct i915_gtt_view view = {
+ .type = I915_GTT_VIEW_NORMAL,
+ };
+ struct i915_vma *vma;
+
+ vma = intel_pin_and_fence_fb_obj(fb, false, &view, false,
+ &intel_wd->flags);
+
+ if (IS_ERR(vma))
+ return PTR_ERR(vma);
+
+ intel_wd->vma = vma;
+ return 0;
+}
+
+static void intel_configure_slicing_strategy(struct drm_i915_private *i915,
+ struct intel_wd *intel_wd,
+ u32 *tmp)
+{
+ *tmp &= ~WD_STRAT_MASK;
+ if (intel_wd->slicing_strategy == 1)
+ *tmp |= WD_SLICING_STRAT_1_1;
+ else if (intel_wd->slicing_strategy == 2)
+ *tmp |= WD_SLICING_STRAT_2_1;
+ else if (intel_wd->slicing_strategy == 3)
+ *tmp |= WD_SLICING_STRAT_4_1;
+ else if (intel_wd->slicing_strategy == 4)
+ *tmp |= WD_SLICING_STRAT_8_1;
+
+ intel_de_write(i915, WD_STREAMCAP_CTL(intel_wd->trans),
+ *tmp);
+}
+
+static enum drm_mode_status
+intel_wd_mode_valid(struct drm_connector *connector,
+ struct drm_display_mode *mode)
+{
+ return MODE_OK;
+}
+
+static int intel_wd_get_modes(struct drm_connector *connector)
+{
+ return 0;
+}
+
+static void intel_wd_get_config(struct intel_encoder *encoder,
+ struct intel_crtc_state *pipe_config)
+{
+ struct intel_crtc *intel_crtc =
+ to_intel_crtc(pipe_config->uapi.crtc);
+
+ if (intel_crtc) {
+ memcpy(pipe_config, intel_crtc->config,
+ sizeof(*pipe_config));
+ pipe_config->output_types |= BIT(INTEL_OUTPUT_WD);
+ }
+}
+
+static int intel_wd_compute_config(struct intel_encoder *encoder,
+ struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state)
+{
+ struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
+ struct drm_writeback_job *job;
+
+ job = intel_get_writeback_job_from_queue(intel_wd);
+ if (job || conn_state->writeback_job) {
+ /*
+ * Saving reference of pipe/crtc for later use if
+ * writeback job is present
+ */
+ intel_wd->wd_crtc = to_intel_crtc(pipe_config->uapi.crtc);
+ return 0;
+ }
+
+ return 0;
+}
+
+static void intel_wd_get_power_domains(struct intel_encoder *encoder,
+ struct intel_crtc_state *crtc_state)
+{
+ struct drm_i915_private *i915 = to_i915(encoder->base.dev);
+ struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
+ intel_wakeref_t wakeref;
+
+ wakeref = intel_display_power_get(i915, encoder->power_domain);
+
+ intel_wd->io_wakeref[0] = wakeref;
+}
+
+static bool intel_wd_get_hw_state(struct intel_encoder *encoder,
+ enum pipe *pipe)
+{
+ bool ret = false;
+ struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
+ struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
+ struct intel_crtc *wd_crtc = intel_wd->wd_crtc;
+ intel_wakeref_t wakeref;
+ u32 tmp;
+
+ if (wd_crtc)
+ return false;
+
+ wakeref = intel_display_power_get_if_enabled(dev_priv,
+ encoder->power_domain);
+
+ if (!wakeref)
+ goto out;
+
+ tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
+ ret = tmp & WD_TRANS_ACTIVE;
+ if (ret) {
+ *pipe = wd_crtc->pipe;
+ return true;
+ }
+
+out:
+ intel_display_power_put(dev_priv, encoder->power_domain, wakeref);
+ return false;
+}
+
+static int intel_wd_encoder_atomic_check(struct drm_encoder *encoder,
+ struct drm_crtc_state *crtc_st,
+ struct drm_connector_state *conn_st)
+{
+ /* Check for the format and buffers and property validity */
+ struct drm_framebuffer *fb;
+ struct drm_writeback_job *job = conn_st->writeback_job;
+ struct drm_i915_private *i915 = to_i915(encoder->dev);
+ const struct drm_display_mode *mode = &crtc_st->mode;
+ int ret;
+
+ if (!job) {
+ drm_dbg_kms(&i915->drm, "No writeback job created returning\n");
+ return -EINVAL;
+ }
+
+ fb = job->fb;
+ if (!fb) {
+ drm_dbg_kms(&i915->drm, "Invalid framebuffer\n");
+ return -EINVAL;
+ }
+
+ if (fb->width != mode->hdisplay || fb->height != mode->vdisplay) {
+ drm_dbg_kms(&i915->drm, "Invalid framebuffer size %ux%u\n",
+ fb->width, fb->height);
+ return -EINVAL;
+ }
+
+ ret = intel_wd_verify_pix_format(fb->format->format);
+ if (ret) {
+ drm_dbg_kms(&i915->drm, "Unsupported framebuffer format %08x\n",
+ fb->format->format);
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
+static const struct drm_encoder_helper_funcs wd_encoder_helper_funcs = {
+ .atomic_check = intel_wd_encoder_atomic_check,
+};
+
+static void intel_wd_connector_destroy(struct drm_connector *connector)
+{
+ drm_connector_cleanup(connector);
+}
+
+static enum drm_connector_status
+intel_wd_connector_detect(struct drm_connector *connector, bool force)
+{
+ return connector_status_connected;
+}
+
+static const struct drm_connector_funcs wb_connector_funcs = {
+ .detect = intel_wd_connector_detect,
+ .reset = drm_atomic_helper_connector_reset,
+ .destroy = intel_wd_connector_destroy,
+ .fill_modes = drm_helper_probe_single_connector_modes,
+ .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
+ .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
+};
+
+static const struct drm_connector_helper_funcs wb_connector_helper_funcs = {
+ .get_modes = intel_wd_get_modes,
+ .mode_valid = intel_wd_mode_valid,
+};
+
+static const struct drm_encoder_funcs drm_writeback_encoder_funcs = {
+ .destroy = drm_encoder_cleanup,
+};
+
+static bool intel_fastset_dis(struct intel_encoder *encoder,
+ struct intel_crtc_state *pipe_config)
+{
+ return false;
+}
+
+static void intel_wd_connector_init(struct intel_wd *intel_wd)
+{
+ drm_atomic_helper_connector_reset(&intel_wd->wb_conn.base);
+}
+
+static void intel_wd_disable_capture(struct intel_wd *intel_wd)
+{
+ struct drm_i915_private *dev_priv = to_i915(intel_wd->base.base.dev);
+ u32 tmp;
+
+ intel_de_write_fw(dev_priv, WD_IMR(intel_wd->trans), 0xFF);
+ tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
+ tmp &= WD_TRANS_DISABLE;
+ intel_de_write(dev_priv, PIPECONF(intel_wd->trans), tmp);
+ tmp = intel_de_read(dev_priv, WD_TRANS_FUNC_CTL(intel_wd->trans));
+}
+
+void intel_wd_init(struct drm_i915_private *i915, enum transcoder trans)
+{
+ struct intel_wd *intel_wd;
+ struct intel_encoder *encoder;
+ struct drm_writeback_connector *wb_conn;
+ int n_formats = ARRAY_SIZE(wd_fmts);
+ struct drm_encoder *drm_enc;
+ int err, ret;
+
+ intel_wd = kzalloc(sizeof(*intel_wd), GFP_KERNEL);
+ if (!intel_wd)
+ return;
+
+ intel_wd_connector_init(intel_wd);
+ encoder = &intel_wd->base;
+ drm_enc = &encoder->base;
+ wb_conn = &intel_wd->wb_conn;
+ intel_wd->trans = trans;
+ intel_wd->triggered_cap_mode = 1;
+ intel_wd->frame_num = 1;
+ intel_wd->slicing_strategy = 1;
+ encoder->get_config = intel_wd_get_config;
+ encoder->compute_config = intel_wd_compute_config;
+ encoder->get_hw_state = intel_wd_get_hw_state;
+ encoder->type = INTEL_OUTPUT_WD;
+ encoder->cloneable = 0;
+ encoder->pipe_mask = ~0;
+ encoder->power_domain = POWER_DOMAIN_TRANSCODER_B;
+ encoder->get_power_domains = intel_wd_get_power_domains;
+ encoder->initial_fastset_check = intel_fastset_dis;
+
+ drm_encoder_helper_add(drm_enc,
+ &wd_encoder_helper_funcs);
+
+ drm_enc->possible_crtcs = ~0;
+ ret = drm_encoder_init(&i915->drm, drm_enc,
+ &drm_writeback_encoder_funcs,
+ DRM_MODE_ENCODER_VIRTUAL, NULL);
+
+ if (ret) {
+ drm_dbg_kms(&i915->drm,
+ "Writeback drm_encoder init Failed: %d\n",
+ ret);
+ goto cleanup;
+ }
+
+ err = drm_writeback_connector_init_with_encoder(&i915->drm,
+ wb_conn, drm_enc, &wb_connector_funcs,
+ wd_fmts, n_formats);
+
+ if (err != 0) {
+ drm_dbg_kms(&i915->drm,
+ "drm_writeback_connector_init: Failed: %d\n",
+ err);
+ goto cleanup;
+ }
+
+ wb_conn->base.encoder = drm_enc;
+ drm_connector_helper_add(&wb_conn->base, &wb_connector_helper_funcs);
+ wb_conn->base.status = connector_status_connected;
+ return;
+
+cleanup:
+ kfree(intel_wd);
+ return;
+}
+
+static void intel_wd_writeback_complete(struct intel_wd *intel_wd,
+ struct drm_writeback_job *job,
+ int status)
+{
+ struct drm_writeback_connector *wb_conn =
+ &intel_wd->wb_conn;
+ drm_writeback_signal_completion(wb_conn, status);
+}
+
+static int intel_wd_setup_transcoder(struct intel_wd *intel_wd,
+ struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state,
+ struct drm_writeback_job *job)
+{
+ struct intel_crtc *intel_crtc = to_intel_crtc(pipe_config->uapi.crtc);
+ enum pipe pipe = intel_crtc->pipe;
+ struct drm_framebuffer *fb;
+ struct drm_i915_private *dev_priv = to_i915(intel_crtc->base.dev);
+ struct drm_gem_object *wd_fb_obj;
+ int ret;
+ u32 stride, tmp;
+ u16 hactive, vactive;
+
+ fb = job->fb;
+ wd_fb_obj = fb->obj[0];
+ if (!wd_fb_obj) {
+ drm_dbg_kms(&dev_priv->drm, "No framebuffer gem object created\n");
+ return -EINVAL;
+ }
+
+ ret = intel_wd_pin_fb(intel_wd, fb);
+ drm_WARN_ON(&dev_priv->drm, ret != 0);
+ /* Write stride and surface registers in that particular order */
+ stride = intel_wd_get_stride(pipe_config, fb->format->format);
+
+ tmp = intel_de_read(dev_priv, WD_STRIDE(intel_wd->trans));
+ tmp &= ~WD_STRIDE_MASK;
+ tmp |= (stride << WD_STRIDE_SHIFT);
+
+ intel_de_write(dev_priv, WD_STRIDE(intel_wd->trans), tmp);
+
+ tmp = intel_de_read(dev_priv, WD_SURF(intel_wd->trans));
+
+ intel_de_write(dev_priv, WD_SURF(intel_wd->trans),
+ i915_ggtt_offset(intel_wd->vma));
+
+ tmp = intel_de_read_fw(dev_priv, WD_IIR(intel_wd->trans));
+ intel_de_write_fw(dev_priv, WD_IIR(intel_wd->trans), tmp);
+
+ tmp = ~(WD_GTT_FAULT_INT | WD_WRITE_COMPLETE_INT | WD_FRAME_COMPLETE_INT |
+ WD_VBLANK_INT | WD_OVERRUN_INT | WD_CAPTURING_INT);
+ intel_de_write_fw(dev_priv, WD_IMR(intel_wd->trans), tmp);
+
+ if (intel_wd->stream_cap) {
+ tmp = intel_de_read(dev_priv,
+ WD_STREAMCAP_CTL(intel_wd->trans));
+ tmp |= WD_STREAM_CAP_MODE_EN;
+ intel_configure_slicing_strategy(dev_priv, intel_wd, &tmp);
+ }
+
+ hactive = pipe_config->uapi.mode.hdisplay;
+ vactive = pipe_config->uapi.mode.vdisplay;
+ tmp = intel_de_read(dev_priv, HTOTAL(intel_wd->trans));
+ tmp = intel_de_read(dev_priv, VTOTAL(intel_wd->trans));
+
+ /* minimum hactive as per bspec: 64 pixels */
+ if (hactive < 64)
+ drm_err(&dev_priv->drm, "hactive is less then 64 pixels\n");
+
+ intel_de_write(dev_priv, HTOTAL(intel_wd->trans), hactive - 1);
+ intel_de_write(dev_priv, VTOTAL(intel_wd->trans), vactive - 1);
+
+ tmp = intel_de_read(dev_priv, WD_TRANS_FUNC_CTL(intel_wd->trans));
+ /* select pixel format */
+ tmp &= ~WD_PIX_FMT_MASK;
+
+ switch (fb->format->format) {
+ default:
+ fallthrough;
+ case DRM_FORMAT_YUYV:
+ tmp |= WD_PIX_FMT_YUYV;
+ break;
+ case DRM_FORMAT_XYUV8888:
+ tmp |= WD_PIX_FMT_XYUV8888;
+ break;
+ case DRM_FORMAT_XBGR8888:
+ case DRM_FORMAT_XRGB8888:
+ tmp |= WD_PIX_FMT_XBGR8888;
+ break;
+ case DRM_FORMAT_Y410:
+ tmp |= WD_PIX_FMT_Y410;
+ break;
+ case DRM_FORMAT_YUV422:
+ tmp |= WD_PIX_FMT_YUV422;
+ break;
+ case DRM_FORMAT_XBGR2101010:
+ tmp |= WD_PIX_FMT_XBGR2101010;
+ break;
+ case DRM_FORMAT_RGB565:
+ tmp |= WD_PIX_FMT_RGB565;
+ break;
+ }
+
+ if (intel_wd->triggered_cap_mode)
+ tmp |= WD_TRIGGERED_CAP_MODE_ENABLE;
+
+ if (intel_wd->stream_cap)
+ tmp |= WD_CTL_POINTER_DTDH;
+
+ /* select input pipe */
+ tmp &= ~WD_INPUT_SELECT_MASK;
+ switch (pipe) {
+ default:
+ fallthrough;
+ case PIPE_A:
+ tmp |= WD_INPUT_PIPE_A;
+ break;
+ case PIPE_B:
+ tmp |= WD_INPUT_PIPE_B;
+ break;
+ case PIPE_C:
+ tmp |= WD_INPUT_PIPE_C;
+ break;
+ case PIPE_D:
+ tmp |= WD_INPUT_PIPE_D;
+ break;
+ }
+
+ /* enable DDI buffer */
+ if (!(tmp & TRANS_WD_FUNC_ENABLE))
+ tmp |= TRANS_WD_FUNC_ENABLE;
+
+ intel_de_write(dev_priv, WD_TRANS_FUNC_CTL(intel_wd->trans), tmp);
+
+ tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
+ ret = tmp & WD_TRANS_ACTIVE;
+ if (!ret) {
+ /* enable the transcoder */
+ tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
+ tmp |= WD_TRANS_ENABLE;
+ intel_de_write(dev_priv, PIPECONF(intel_wd->trans), tmp);
+
+ /* wait for transcoder to be enabled */
+ if (intel_de_wait_for_set(dev_priv, PIPECONF(intel_wd->trans),
+ WD_TRANS_ACTIVE, 10))
+ drm_err(&dev_priv->drm, "WD transcoder could not be enabled\n");
+ }
+
+ return 0;
+}
+
+static int intel_wd_capture(struct intel_wd *intel_wd,
+ struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state,
+ struct drm_writeback_job *job)
+{
+ u32 tmp;
+ struct drm_i915_private *i915 = to_i915(intel_wd->base.base.dev);
+ int ret = 0, status = 0;
+ struct intel_crtc *wd_crtc = intel_wd->wd_crtc;
+ unsigned long flags;
+
+ if (!job->out_fence)
+ drm_dbg_kms(&i915->drm, "Not able to get out_fence for job\n");
+
+ ret = intel_wd_setup_transcoder(intel_wd, pipe_config,
+ conn_state, job);
+
+ if (ret < 0) {
+ drm_dbg_kms(&i915->drm,
+ "WD transcoder setup not completed aborting capture\n");
+ return -1;
+ }
+
+ if (!wd_crtc) {
+ drm_err(&i915->drm, "CRTC not attached\n");
+ return -1;
+ }
+
+ tmp = intel_de_read_fw(i915, WD_TRANS_FUNC_CTL(intel_wd->trans));
+ tmp |= START_TRIGGER_FRAME;
+ tmp &= ~WD_FRAME_NUMBER_MASK;
+ tmp |= intel_wd->frame_num;
+ intel_de_write_fw(i915, WD_TRANS_FUNC_CTL(intel_wd->trans), tmp);
+
+ if (!intel_de_wait_for_set(i915, WD_IIR(intel_wd->trans),
+ WD_FRAME_COMPLETE_INT, 100)){
+ drm_dbg_kms(&i915->drm, "frame captured\n");
+ status = 0;
+ } else {
+ drm_dbg_kms(&i915->drm, "frame not captured triggering stop frame\n");
+ tmp = intel_de_read(i915, WD_TRANS_FUNC_CTL(intel_wd->trans));
+ tmp |= STOP_TRIGGER_FRAME;
+ intel_de_write(i915, WD_TRANS_FUNC_CTL(intel_wd->trans), tmp);
+ status = -1;
+ }
+
+ intel_wd_writeback_complete(intel_wd, job, status);
+ if (wd_crtc->wd.e) {
+ spin_lock_irqsave(&i915->drm.event_lock, flags);
+ drm_dbg_kms(&i915->drm, "send %p\n", wd_crtc->wd.e);
+ drm_crtc_send_vblank_event(&wd_crtc->base,
+ wd_crtc->wd.e);
+ spin_unlock_irqrestore(&i915->drm.event_lock, flags);
+ wd_crtc->wd.e = NULL;
+ } else {
+ drm_err(&i915->drm, "Event NULL! %p, %p\n", &i915->drm,
+ wd_crtc);
+ }
+ if (!intel_get_writeback_job_from_queue(intel_wd))
+ intel_wd_disable_capture(intel_wd);
+ return 0;
+}
+
+void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state)
+{
+ struct drm_i915_private *i915 =
+ to_i915(conn_state->connector->dev);
+ struct drm_writeback_connector *wb_conn =
+ drm_connector_to_writeback(conn_state->connector);
+ struct intel_wd *intel_wd = wb_conn_to_intel_wd(wb_conn);
+ struct drm_writeback_job *job;
+
+ job = intel_get_writeback_job_from_queue(intel_wd);
+ if (!job) {
+ drm_dbg_kms(&i915->drm,
+ "job queue is empty not capturing any frame\n");
+ return;
+ }
+
+ intel_wd_capture(intel_wd, pipe_config,
+ conn_state, job);
+ intel_wd->frame_num += 1;
+}
+
+void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *intel_crtc,
+ struct intel_crtc_state *intel_crtc_state)
+{
+ struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
+ struct drm_crtc_state *crtc_state = &intel_crtc_state->uapi;
+ struct intel_encoder *encoder;
+ struct intel_wd *intel_wd;
+ struct drm_connector_state *conn_state;
+ struct drm_connector *connector;
+ int i;
+
+ for_each_intel_encoder(&i915->drm, encoder) {
+ if (encoder->type != INTEL_OUTPUT_WD)
+ continue;
+
+ intel_wd = enc_to_intel_wd(encoder);
+ if (!intel_wd->wd_crtc)
+ return;
+ }
+
+ if (intel_wd && intel_crtc == intel_wd->wd_crtc) {
+ for_each_new_connector_in_state(&state->base, connector, conn_state,
+ i) {
+ if (!conn_state->writeback_job)
+ continue;
+
+ intel_crtc->wd.e = crtc_state->event;
+ crtc_state->event = NULL;
+ }
+ }
+}
+
+void intel_wd_handle_isr(struct drm_i915_private *i915)
+{
+ u32 iir_value = 0;
+ struct intel_encoder *encoder;
+ struct intel_wd *intel_wd;
+
+ iir_value = intel_de_read(i915, WD_IIR(TRANSCODER_WD_0));
+
+ for_each_intel_encoder(&i915->drm, encoder) {
+
+ if (encoder->type != INTEL_OUTPUT_WD)
+ continue;
+
+ intel_wd = enc_to_intel_wd(encoder);
+ if (!intel_wd->wd_crtc) {
+ drm_err(&i915->drm, "NO CRTC attached with WD\n");
+ goto clear_iir;
+ }
+ }
+
+ if (iir_value & WD_FRAME_COMPLETE_INT)
+ return;
+
+clear_iir:
+ intel_de_write(i915, WD_IIR(TRANSCODER_WD_0), iir_value);
+}
diff --git a/drivers/gpu/drm/i915/display/intel_wd.h b/drivers/gpu/drm/i915/display/intel_wd.h
new file mode 100644
index 000000000000..0fcd1a746593
--- /dev/null
+++ b/drivers/gpu/drm/i915/display/intel_wd.h
@@ -0,0 +1,48 @@
+/* SPDX-License-Identifier: MIT*/
+/*
+ * Copyright © 2022 Intel Corporation
+ */
+
+#ifndef _INTEL_WD_H
+#define _INTEL_WD_H
+
+#include <drm/drm_crtc.h>
+
+#include "intel_display_types.h"
+
+#define I915_MAX_WD_TANSCODERS 2
+
+struct intel_wd {
+ struct intel_encoder base;
+ struct drm_writeback_connector wb_conn;
+ struct intel_crtc *wd_crtc;
+ intel_wakeref_t io_wakeref[I915_MAX_WD_TANSCODERS];
+ enum transcoder trans;
+ struct i915_vma *vma;
+ unsigned long flags;
+ struct drm_writeback_job *job;
+ int triggered_cap_mode;
+ int frame_num;
+ bool stream_cap;
+ bool start_capture;
+ int slicing_strategy;
+};
+
+static inline struct intel_wd *enc_to_intel_wd(struct intel_encoder *encoder)
+{
+ return container_of(&encoder->base, struct intel_wd, base.base);
+}
+
+static inline struct intel_wd *wb_conn_to_intel_wd(struct drm_writeback_connector *wb_conn)
+{
+ return container_of(wb_conn, struct intel_wd, wb_conn);
+}
+
+void intel_wd_init(struct drm_i915_private *dev_priv, enum transcoder trans);
+void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state);
+void intel_wd_handle_isr(struct drm_i915_private *dev_priv);
+void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *crtc,
+ struct intel_crtc_state *crtc_state);
+struct drm_writeback_job *intel_get_writeback_job_from_queue(struct intel_wd *intel_wd);
+#endif/* _INTEL_WD_H */
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 9f9372931fd2..2b977bd4d9d9 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -34,6 +34,7 @@
#include <linux/pm_qos.h>
+#include <drm/drm_writeback.h>
#include <drm/ttm/ttm_device.h>
#include "display/intel_display.h"
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 86a42d9e8041..ee0255d9eb64 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -42,6 +42,7 @@
#include "display/intel_hotplug.h"
#include "display/intel_lpe_audio.h"
#include "display/intel_psr.h"
+#include "display/intel_wd.h"
#include "gt/intel_breadcrumbs.h"
#include "gt/intel_gt.h"
@@ -2342,6 +2343,11 @@ gen8_de_misc_irq_handler(struct drm_i915_private *dev_priv, u32 iir)
found = true;
}
+ if (iir & GEN8_DE_MISC_WD0) {
+ intel_wd_handle_isr(dev_priv);
+ found = true;
+ }
+
if (iir & GEN8_DE_EDP_PSR) {
struct intel_encoder *encoder;
u32 psr_iir;
@@ -3767,7 +3773,7 @@ static void gen8_de_irq_postinstall(struct drm_i915_private *dev_priv)
u32 de_pipe_enables;
u32 de_port_masked = gen8_de_port_aux_mask(dev_priv);
u32 de_port_enables;
- u32 de_misc_masked = GEN8_DE_EDP_PSR;
+ u32 de_misc_masked = GEN8_DE_EDP_PSR | GEN8_DE_MISC_WD0;
u32 trans_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
BIT(TRANSCODER_C) | BIT(TRANSCODER_D);
enum pipe pipe;
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 77e7df21f539..66bb5f53584b 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -868,7 +868,8 @@ static const struct intel_device_info jsl_info = {
.__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), \
.__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | \
BIT(TRANSCODER_C) | BIT(TRANSCODER_D) | \
- BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1), \
+ BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1) | \
+ BIT(TRANSCODER_WD_0), \
.display.pipe_offsets = { \
[TRANSCODER_A] = PIPE_A_OFFSET, \
[TRANSCODER_B] = PIPE_B_OFFSET, \
@@ -876,6 +877,8 @@ static const struct intel_device_info jsl_info = {
[TRANSCODER_D] = PIPE_D_OFFSET, \
[TRANSCODER_DSI_0] = PIPE_DSI0_OFFSET, \
[TRANSCODER_DSI_1] = PIPE_DSI1_OFFSET, \
+ [TRANSCODER_WD_0] = PIPE_WD0_OFFSET, \
+ [TRANSCODER_WD_1] = PIPE_WD1_OFFSET, \
}, \
.display.trans_offsets = { \
[TRANSCODER_A] = TRANSCODER_A_OFFSET, \
@@ -884,6 +887,8 @@ static const struct intel_device_info jsl_info = {
[TRANSCODER_D] = TRANSCODER_D_OFFSET, \
[TRANSCODER_DSI_0] = TRANSCODER_DSI0_OFFSET, \
[TRANSCODER_DSI_1] = TRANSCODER_DSI1_OFFSET, \
+ [TRANSCODER_WD_0] = TRANSCODER_WD0_OFFSET, \
+ [TRANSCODER_WD_1] = TRANSCODER_WD1_OFFSET, \
}, \
TGL_CURSOR_OFFSETS, \
.has_global_mocs = 1, \
--
2.25.1
^ permalink raw reply related [flat|nested] 30+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev6)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (2 preceding siblings ...)
2022-09-19 13:05 ` [Intel-gfx] [PATCH v6 3/3] drm/i915: Enabling WD Transcoder Kandpal, Suraj
@ 2022-09-19 14:14 ` Patchwork
2022-09-19 14:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (17 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-19 14:14 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
== Series Details ==
Series: Enable Pipewriteback (rev6)
URL : https://patchwork.freedesktop.org/series/107440/
State : warning
== Summary ==
Error: dim checkpatch failed
e8e2789aae64 drm/i915: Define WD trancoder for i915
f0b7332cab29 drm/i915 : Changing intel_connector iterators
-:76: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#76: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1507:
+#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \
+ NULL : container_of(x, struct intel_connector, base))
-:76: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues
#76: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1507:
+#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \
+ NULL : container_of(x, struct intel_connector, base))
-:104: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#104: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2093:
+
+ }
total: 0 errors, 0 warnings, 3 checks, 104 lines checked
e05701dddd18 drm/i915: Enabling WD Transcoder
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 11, in <module>
import git
ModuleNotFoundError: No module named 'git'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 11, in <module>
import git
ModuleNotFoundError: No module named 'git'
-:559: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#559:
new file mode 100644
-:597: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!job"
#597: FILE: drivers/gpu/drm/i915/display/intel_wd.c:34:
+ if (job == NULL) {
-:634: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#634: FILE: drivers/gpu/drm/i915/display/intel_wd.c:71:
+ DRM_ERROR("unsupported pixel format %x!\n",
+ pixel_format);
-:712: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#712: FILE: drivers/gpu/drm/i915/display/intel_wd.c:149:
+ intel_de_write(i915, WD_STREAMCAP_CTL(intel_wd->trans),
+ *tmp);
-:735: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#735: FILE: drivers/gpu/drm/i915/display/intel_wd.c:172:
+ memcpy(pipe_config, intel_crtc->config,
+ sizeof(*pipe_config));
-:786: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#786: FILE: drivers/gpu/drm/i915/display/intel_wd.c:223:
+ wakeref = intel_display_power_get_if_enabled(dev_priv,
+ encoder->power_domain);
-:827: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#827: FILE: drivers/gpu/drm/i915/display/intel_wd.c:264:
+ drm_dbg_kms(&i915->drm, "Invalid framebuffer size %ux%u\n",
+ fb->width, fb->height);
-:834: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#834: FILE: drivers/gpu/drm/i915/display/intel_wd.c:271:
+ drm_dbg_kms(&i915->drm, "Unsupported framebuffer format %08x\n",
+ fb->format->format);
-:875: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#875: FILE: drivers/gpu/drm/i915/display/intel_wd.c:312:
+static bool intel_fastset_dis(struct intel_encoder *encoder,
+ struct intel_crtc_state *pipe_config)
-:929: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#929: FILE: drivers/gpu/drm/i915/display/intel_wd.c:366:
+ drm_encoder_helper_add(drm_enc,
+ &wd_encoder_helper_funcs);
-:944: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#944: FILE: drivers/gpu/drm/i915/display/intel_wd.c:381:
+ err = drm_writeback_connector_init_with_encoder(&i915->drm,
+ wb_conn, drm_enc, &wb_connector_funcs,
-:962: WARNING:RETURN_VOID: void function return statements are not generally useful
#962: FILE: drivers/gpu/drm/i915/display/intel_wd.c:399:
+ return;
+}
-:1008: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1008: FILE: drivers/gpu/drm/i915/display/intel_wd.c:445:
+ intel_de_write(dev_priv, WD_SURF(intel_wd->trans),
+ i915_ggtt_offset(intel_wd->vma));
-:1019: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1019: FILE: drivers/gpu/drm/i915/display/intel_wd.c:456:
+ tmp = intel_de_read(dev_priv,
+ WD_STREAMCAP_CTL(intel_wd->trans));
-:1108: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1108: FILE: drivers/gpu/drm/i915/display/intel_wd.c:545:
+ if (intel_de_wait_for_set(dev_priv, PIPECONF(intel_wd->trans),
+ WD_TRANS_ACTIVE, 10))
-:1130: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1130: FILE: drivers/gpu/drm/i915/display/intel_wd.c:567:
+ ret = intel_wd_setup_transcoder(intel_wd, pipe_config,
+ conn_state, job);
-:1179: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1179: FILE: drivers/gpu/drm/i915/display/intel_wd.c:616:
+void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state)
-:1196: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1196: FILE: drivers/gpu/drm/i915/display/intel_wd.c:633:
+ intel_wd_capture(intel_wd, pipe_config,
+ conn_state, job);
-:1201: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1201: FILE: drivers/gpu/drm/i915/display/intel_wd.c:638:
+void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *intel_crtc,
+ struct intel_crtc_state *intel_crtc_state)
-:1241: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#1241: FILE: drivers/gpu/drm/i915/display/intel_wd.c:678:
+ for_each_intel_encoder(&i915->drm, encoder) {
+
-:1306: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1306: FILE: drivers/gpu/drm/i915/display/intel_wd.h:43:
+void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state);
-:1309: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1309: FILE: drivers/gpu/drm/i915/display/intel_wd.h:46:
+void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *crtc,
+ struct intel_crtc_state *crtc_state);
total: 0 errors, 2 warnings, 20 checks, 1260 lines checked
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable Pipewriteback (rev6)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (3 preceding siblings ...)
2022-09-19 14:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev6) Patchwork
@ 2022-09-19 14:14 ` Patchwork
2022-09-19 14:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (16 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-19 14:14 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
== Series Details ==
Series: Enable Pipewriteback (rev6)
URL : https://patchwork.freedesktop.org/series/107440/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for Enable Pipewriteback (rev6)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (4 preceding siblings ...)
2022-09-19 14:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2022-09-19 14:38 ` Patchwork
2022-09-19 23:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev7) Patchwork
` (15 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-19 14:38 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6771 bytes --]
== Series Details ==
Series: Enable Pipewriteback (rev6)
URL : https://patchwork.freedesktop.org/series/107440/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12155 -> Patchwork_107440v6
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_107440v6 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_107440v6, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v6/index.html
Participating hosts (43 -> 42)
------------------------------
Additional (1): bat-jsl-3
Missing (2): fi-ctg-p8600 fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107440v6:
### CI changes ###
#### Possible regressions ####
* boot:
- fi-ilk-650: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12155/fi-ilk-650/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v6/fi-ilk-650/boot.html
### IGT changes ###
#### Possible regressions ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@varying-size:
- fi-bsw-kefka: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12155/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@varying-size.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v6/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@varying-size.html
Known issues
------------
Here are the changes found in Patchwork_107440v6 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gem:
- fi-blb-e6850: NOTRUN -> [DMESG-FAIL][5] ([i915#4528])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v6/fi-blb-e6850/igt@i915_selftest@live@gem.html
- fi-pnv-d510: NOTRUN -> [DMESG-FAIL][6] ([i915#4528])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v6/fi-pnv-d510/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][7] -> [INCOMPLETE][8] ([i915#4785])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12155/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v6/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-rkl-11600: NOTRUN -> [SKIP][9] ([fdo#111827])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v6/fi-rkl-11600/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][10] ([fdo#109271] / [i915#4312] / [i915#5594] / [i915#6246])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v6/fi-hsw-4770/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-adlm-1}: [DMESG-WARN][11] ([i915#2867]) -> [PASS][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12155/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v6/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][13] ([i915#4528]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12155/fi-pnv-d510/igt@i915_selftest@live@requests.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v6/fi-pnv-d510/igt@i915_selftest@live@requests.html
- fi-blb-e6850: [DMESG-FAIL][15] ([i915#4528]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12155/fi-blb-e6850/igt@i915_selftest@live@requests.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v6/fi-blb-e6850/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [INCOMPLETE][17] ([i915#5982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12155/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v6/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6246]: https://gitlab.freedesktop.org/drm/intel/issues/6246
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6380]: https://gitlab.freedesktop.org/drm/intel/issues/6380
Build changes
-------------
* Linux: CI_DRM_12155 -> Patchwork_107440v6
CI-20190529: 20190529
CI_DRM_12155: 0d736be302169de71514f53e9d0b8133b666888c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6656: 24100c4e181c50e3678aeca9c641b8a43555ad73 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107440v6: 0d736be302169de71514f53e9d0b8133b666888c @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
3d8431d88519 drm/i915: Enabling WD Transcoder
4ac291913fb2 drm/i915 : Changing intel_connector iterators
301a7df7241e drm/i915: Define WD trancoder for i915
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v6/index.html
[-- Attachment #2: Type: text/html, Size: 7053 bytes --]
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev7)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (5 preceding siblings ...)
2022-09-19 14:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2022-09-19 23:41 ` Patchwork
2022-09-19 23:41 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (14 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-19 23:41 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
== Series Details ==
Series: Enable Pipewriteback (rev7)
URL : https://patchwork.freedesktop.org/series/107440/
State : warning
== Summary ==
Error: dim checkpatch failed
c994ba9a29ce drm/i915: Define WD trancoder for i915
5e7abcf91502 drm/i915 : Changing intel_connector iterators
-:76: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#76: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1507:
+#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \
+ NULL : container_of(x, struct intel_connector, base))
-:76: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues
#76: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1507:
+#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \
+ NULL : container_of(x, struct intel_connector, base))
-:104: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#104: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2093:
+
+ }
total: 0 errors, 0 warnings, 3 checks, 104 lines checked
056ada13d2e5 drm/i915: Enabling WD Transcoder
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 11, in <module>
import git
ModuleNotFoundError: No module named 'git'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 11, in <module>
import git
ModuleNotFoundError: No module named 'git'
-:559: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#559:
new file mode 100644
-:597: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!job"
#597: FILE: drivers/gpu/drm/i915/display/intel_wd.c:34:
+ if (job == NULL) {
-:634: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#634: FILE: drivers/gpu/drm/i915/display/intel_wd.c:71:
+ DRM_ERROR("unsupported pixel format %x!\n",
+ pixel_format);
-:712: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#712: FILE: drivers/gpu/drm/i915/display/intel_wd.c:149:
+ intel_de_write(i915, WD_STREAMCAP_CTL(intel_wd->trans),
+ *tmp);
-:735: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#735: FILE: drivers/gpu/drm/i915/display/intel_wd.c:172:
+ memcpy(pipe_config, intel_crtc->config,
+ sizeof(*pipe_config));
-:786: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#786: FILE: drivers/gpu/drm/i915/display/intel_wd.c:223:
+ wakeref = intel_display_power_get_if_enabled(dev_priv,
+ encoder->power_domain);
-:827: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#827: FILE: drivers/gpu/drm/i915/display/intel_wd.c:264:
+ drm_dbg_kms(&i915->drm, "Invalid framebuffer size %ux%u\n",
+ fb->width, fb->height);
-:834: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#834: FILE: drivers/gpu/drm/i915/display/intel_wd.c:271:
+ drm_dbg_kms(&i915->drm, "Unsupported framebuffer format %08x\n",
+ fb->format->format);
-:875: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#875: FILE: drivers/gpu/drm/i915/display/intel_wd.c:312:
+static bool intel_fastset_dis(struct intel_encoder *encoder,
+ struct intel_crtc_state *pipe_config)
-:929: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#929: FILE: drivers/gpu/drm/i915/display/intel_wd.c:366:
+ drm_encoder_helper_add(drm_enc,
+ &wd_encoder_helper_funcs);
-:944: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#944: FILE: drivers/gpu/drm/i915/display/intel_wd.c:381:
+ err = drm_writeback_connector_init_with_encoder(&i915->drm,
+ wb_conn, drm_enc, &wb_connector_funcs,
-:962: WARNING:RETURN_VOID: void function return statements are not generally useful
#962: FILE: drivers/gpu/drm/i915/display/intel_wd.c:399:
+ return;
+}
-:1008: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1008: FILE: drivers/gpu/drm/i915/display/intel_wd.c:445:
+ intel_de_write(dev_priv, WD_SURF(intel_wd->trans),
+ i915_ggtt_offset(intel_wd->vma));
-:1019: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1019: FILE: drivers/gpu/drm/i915/display/intel_wd.c:456:
+ tmp = intel_de_read(dev_priv,
+ WD_STREAMCAP_CTL(intel_wd->trans));
-:1108: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1108: FILE: drivers/gpu/drm/i915/display/intel_wd.c:545:
+ if (intel_de_wait_for_set(dev_priv, PIPECONF(intel_wd->trans),
+ WD_TRANS_ACTIVE, 10))
-:1130: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1130: FILE: drivers/gpu/drm/i915/display/intel_wd.c:567:
+ ret = intel_wd_setup_transcoder(intel_wd, pipe_config,
+ conn_state, job);
-:1179: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1179: FILE: drivers/gpu/drm/i915/display/intel_wd.c:616:
+void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state)
-:1196: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1196: FILE: drivers/gpu/drm/i915/display/intel_wd.c:633:
+ intel_wd_capture(intel_wd, pipe_config,
+ conn_state, job);
-:1201: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1201: FILE: drivers/gpu/drm/i915/display/intel_wd.c:638:
+void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *intel_crtc,
+ struct intel_crtc_state *intel_crtc_state)
-:1241: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#1241: FILE: drivers/gpu/drm/i915/display/intel_wd.c:678:
+ for_each_intel_encoder(&i915->drm, encoder) {
+
-:1306: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1306: FILE: drivers/gpu/drm/i915/display/intel_wd.h:43:
+void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state);
-:1309: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1309: FILE: drivers/gpu/drm/i915/display/intel_wd.h:46:
+void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *crtc,
+ struct intel_crtc_state *crtc_state);
total: 0 errors, 2 warnings, 20 checks, 1260 lines checked
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable Pipewriteback (rev7)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (6 preceding siblings ...)
2022-09-19 23:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev7) Patchwork
@ 2022-09-19 23:41 ` Patchwork
2022-09-20 0:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (13 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-19 23:41 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
== Series Details ==
Series: Enable Pipewriteback (rev7)
URL : https://patchwork.freedesktop.org/series/107440/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Enable Pipewriteback (rev7)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (7 preceding siblings ...)
2022-09-19 23:41 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2022-09-20 0:02 ` Patchwork
2022-09-20 8:36 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (12 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-20 0:02 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4790 bytes --]
== Series Details ==
Series: Enable Pipewriteback (rev7)
URL : https://patchwork.freedesktop.org/series/107440/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12158 -> Patchwork_107440v7
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/index.html
Participating hosts (42 -> 39)
------------------------------
Missing (3): fi-ctg-p8600 fi-rkl-11600 bat-dg1-5
Known issues
------------
Here are the changes found in Patchwork_107440v7 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][1] ([fdo#109271] / [fdo#111827])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@prime_vgem@basic-userptr:
- fi-tgl-u2: NOTRUN -> [SKIP][2] ([fdo#109295] / [i915#3301])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/fi-tgl-u2/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@fbdev@read:
- {fi-tgl-mst}: [SKIP][3] ([i915#2582]) -> [PASS][4] +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/fi-tgl-mst/igt@fbdev@read.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/fi-tgl-mst/igt@fbdev@read.html
* igt@gem_ctx_create@basic-files:
- {fi-tgl-mst}: [DMESG-WARN][5] -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/fi-tgl-mst/igt@gem_ctx_create@basic-files.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/fi-tgl-mst/igt@gem_ctx_create@basic-files.html
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-adlm-1}: [DMESG-WARN][7] ([i915#2867]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][9] ([i915#4785]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [FAIL][11] ([i915#6298]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
Build changes
-------------
* Linux: CI_DRM_12158 -> Patchwork_107440v7
CI-20190529: 20190529
CI_DRM_12158: 3bde74f15d452bf788ecab8933ee802b2ee9e673 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6656: 24100c4e181c50e3678aeca9c641b8a43555ad73 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107440v7: 3bde74f15d452bf788ecab8933ee802b2ee9e673 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
1d2d67abdee0 drm/i915: Enabling WD Transcoder
abcbd5adf488 drm/i915 : Changing intel_connector iterators
9cb4c16582dd drm/i915: Define WD trancoder for i915
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/index.html
[-- Attachment #2: Type: text/html, Size: 5174 bytes --]
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for Enable Pipewriteback (rev7)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (8 preceding siblings ...)
2022-09-20 0:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-09-20 8:36 ` Patchwork
2022-09-20 14:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev8) Patchwork
` (11 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-20 8:36 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 36294 bytes --]
== Series Details ==
Series: Enable Pipewriteback (rev7)
URL : https://patchwork.freedesktop.org/series/107440/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12158_full -> Patchwork_107440v7_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_107440v7_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_107440v7_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 11)
------------------------------
Additional (1): shard-rkl
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107440v7_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_suspend@basic-s3-without-i915:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-iclb6/igt@i915_suspend@basic-s3-without-i915.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-iclb3/igt@i915_suspend@basic-s3-without-i915.html
#### Warnings ####
* igt@kms_writeback@writeback-check-output:
- shard-tglb: [SKIP][3] ([i915#2437]) -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-tglb3/igt@kms_writeback@writeback-check-output.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-tglb1/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-fb-id:
- shard-tglb: [SKIP][5] ([i915#2437]) -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-tglb2/igt@kms_writeback@writeback-fb-id.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-tglb8/igt@kms_writeback@writeback-fb-id.html
* igt@runner@aborted:
- shard-skl: ([FAIL][7], [FAIL][8], [FAIL][9], [FAIL][10], [FAIL][11], [FAIL][12], [FAIL][13], [FAIL][14], [FAIL][15], [FAIL][16], [FAIL][17], [FAIL][18], [FAIL][19], [FAIL][20], [FAIL][21], [FAIL][22], [FAIL][23], [FAIL][24], [FAIL][25], [FAIL][26], [FAIL][27], [FAIL][28], [FAIL][29], [FAIL][30], [FAIL][31]) ([i915#6599]) -> ([FAIL][32], [FAIL][33], [FAIL][34], [FAIL][35], [FAIL][36], [FAIL][37], [FAIL][38], [FAIL][39], [FAIL][40], [FAIL][41], [FAIL][42], [FAIL][43], [FAIL][44], [FAIL][45], [FAIL][46], [FAIL][47], [FAIL][48], [FAIL][49], [FAIL][50], [FAIL][51], [FAIL][52], [FAIL][53], [FAIL][54], [FAIL][55], [FAIL][56])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl1/igt@runner@aborted.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl4/igt@runner@aborted.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl1/igt@runner@aborted.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl10/igt@runner@aborted.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl1/igt@runner@aborted.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl10/igt@runner@aborted.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl10/igt@runner@aborted.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl10/igt@runner@aborted.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl1/igt@runner@aborted.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl10/igt@runner@aborted.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl7/igt@runner@aborted.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl4/igt@runner@aborted.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl6/igt@runner@aborted.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl6/igt@runner@aborted.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl4/igt@runner@aborted.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl6/igt@runner@aborted.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl9/igt@runner@aborted.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl6/igt@runner@aborted.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl7/igt@runner@aborted.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl4/igt@runner@aborted.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl9/igt@runner@aborted.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl7/igt@runner@aborted.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl7/igt@runner@aborted.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl9/igt@runner@aborted.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-skl9/igt@runner@aborted.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl9/igt@runner@aborted.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl6/igt@runner@aborted.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl7/igt@runner@aborted.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl9/igt@runner@aborted.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl6/igt@runner@aborted.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl10/igt@runner@aborted.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl10/igt@runner@aborted.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl4/igt@runner@aborted.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl9/igt@runner@aborted.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl6/igt@runner@aborted.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl1/igt@runner@aborted.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl7/igt@runner@aborted.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl9/igt@runner@aborted.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl7/igt@runner@aborted.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl10/igt@runner@aborted.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl1/igt@runner@aborted.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl4/igt@runner@aborted.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl4/igt@runner@aborted.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl6/igt@runner@aborted.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl7/igt@runner@aborted.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl10/igt@runner@aborted.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl1/igt@runner@aborted.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl10/igt@runner@aborted.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl4/igt@runner@aborted.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-skl1/igt@runner@aborted.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_writeback@writeback-fb-id:
- {shard-tglu}: [SKIP][57] ([i915#2437]) -> [FAIL][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-tglu-3/igt@kms_writeback@writeback-fb-id.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-tglu-2/igt@kms_writeback@writeback-fb-id.html
Known issues
------------
Here are the changes found in Patchwork_107440v7_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-apl: ([PASS][59], [PASS][60], [PASS][61], [PASS][62], [PASS][63], [PASS][64], [PASS][65], [PASS][66], [PASS][67], [PASS][68], [PASS][69], [PASS][70], [PASS][71], [PASS][72], [PASS][73], [PASS][74], [PASS][75], [PASS][76], [PASS][77], [PASS][78], [PASS][79], [PASS][80], [PASS][81], [PASS][82], [PASS][83]) -> ([PASS][84], [PASS][85], [PASS][86], [PASS][87], [PASS][88], [PASS][89], [PASS][90], [PASS][91], [PASS][92], [PASS][93], [PASS][94], [PASS][95], [PASS][96], [PASS][97], [PASS][98], [PASS][99], [PASS][100], [PASS][101], [FAIL][102], [PASS][103], [PASS][104], [PASS][105], [PASS][106], [PASS][107], [PASS][108]) ([i915#4386])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl1/boot.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl1/boot.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl1/boot.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl1/boot.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl2/boot.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl2/boot.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl2/boot.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl2/boot.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl3/boot.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl3/boot.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl3/boot.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl3/boot.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl3/boot.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl6/boot.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl6/boot.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl6/boot.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl6/boot.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl6/boot.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl7/boot.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl7/boot.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl7/boot.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl8/boot.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl8/boot.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl8/boot.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl8/boot.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl8/boot.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl8/boot.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl8/boot.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl8/boot.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl8/boot.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl7/boot.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl7/boot.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl7/boot.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl7/boot.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl6/boot.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl6/boot.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl6/boot.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl6/boot.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl3/boot.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl3/boot.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl3/boot.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl3/boot.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl2/boot.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl2/boot.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl2/boot.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl2/boot.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl1/boot.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl1/boot.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl1/boot.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl1/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel:
- shard-iclb: [PASS][109] -> [SKIP][110] ([i915#4525]) +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-iclb1/igt@gem_exec_balancer@parallel.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-iclb3/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][111] -> [FAIL][112] ([i915#2842])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][113] -> [FAIL][114] ([i915#2842])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-iclb1/igt@gem_exec_fair@basic-throttle@rcs0.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_flush@basic-uc-set-default:
- shard-apl: [PASS][115] -> [DMESG-FAIL][116] ([i915#6864])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl8/igt@gem_exec_flush@basic-uc-set-default.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl3/igt@gem_exec_flush@basic-uc-set-default.html
* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][117] ([i915#4991])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl8/igt@gem_userptr_blits@input-checking.html
* igt@gen7_exec_parse@oacontrol-tracking:
- shard-apl: NOTRUN -> [SKIP][118] ([fdo#109271]) +62 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl8/igt@gen7_exec_parse@oacontrol-tracking.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][119] -> [DMESG-WARN][120] ([i915#5566] / [i915#716])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-glk5/igt@gen9_exec_parse@allowed-single.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-glk5/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][121] -> [FAIL][122] ([i915#3989] / [i915#454])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-iclb1/igt@i915_pm_dc@dc6-psr.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-glk: [PASS][123] -> [FAIL][124] ([i915#3743])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-glk1/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-glk6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][125] ([fdo#109271] / [i915#3886]) +1 similar issue
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl8/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_color_chamelium@ctm-red-to-blue:
- shard-apl: NOTRUN -> [SKIP][126] ([fdo#109271] / [fdo#111827]) +2 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl3/igt@kms_color_chamelium@ctm-red-to-blue.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][127] -> [FAIL][128] ([i915#2346])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][129] ([fdo#109271])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-glk5/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html
* igt@kms_flip@flip-vs-suspend@c-edp1:
- shard-iclb: [PASS][130] -> [DMESG-WARN][131] ([i915#2867])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-iclb4/igt@kms_flip@flip-vs-suspend@c-edp1.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-iclb6/igt@kms_flip@flip-vs-suspend@c-edp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][132] ([i915#2672]) +1 similar issue
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][133] ([i915#2587] / [i915#2672])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-apl: [PASS][134] -> [DMESG-WARN][135] ([i915#180]) +2 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl6/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl3/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
* igt@kms_plane_lowres@tiling-y@pipe-b-hdmi-a-1:
- shard-glk: [PASS][136] -> [FAIL][137] ([i915#1888])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-glk6/igt@kms_plane_lowres@tiling-y@pipe-b-hdmi-a-1.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-glk6/igt@kms_plane_lowres@tiling-y@pipe-b-hdmi-a-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-apl: NOTRUN -> [SKIP][138] ([fdo#109271] / [i915#658])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl8/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-tglb: [PASS][139] -> [SKIP][140] ([i915#5519])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-tglb3/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-tglb3/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][141] ([fdo#109271] / [i915#533])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl3/igt@kms_vblank@pipe-d-wait-idle.html
#### Possible fixes ####
* igt@drm_import_export@prime:
- shard-apl: [DMESG-WARN][142] ([i915#6864]) -> [PASS][143]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl8/igt@drm_import_export@prime.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl1/igt@drm_import_export@prime.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][144] ([i915#4525]) -> [PASS][145] +1 similar issue
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-iclb7/igt@gem_exec_balancer@parallel-keep-in-fence.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-iclb1/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][146] ([i915#2846]) -> [PASS][147]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-glk3/igt@gem_exec_fair@basic-deadline.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-glk9/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [FAIL][148] ([i915#2842]) -> [PASS][149]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-tglb1/igt@gem_exec_fair@basic-none-share@rcs0.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-tglb2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][150] ([i915#2842]) -> [PASS][151]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl8/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][152] ([i915#2842]) -> [PASS][153]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-glk9/igt@gem_exec_fair@basic-none@vcs0.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-glk1/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_workarounds@suspend-resume:
- shard-apl: [DMESG-WARN][154] ([i915#180]) -> [PASS][155] +1 similar issue
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl3/igt@gem_workarounds@suspend-resume.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl3/igt@gem_workarounds@suspend-resume.html
* igt@i915_pm_dc@dc5-psr:
- shard-iclb: [FAIL][156] ([i915#3989]) -> [PASS][157]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-iclb8/igt@i915_pm_dc@dc5-psr.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-iclb5/igt@i915_pm_dc@dc5-psr.html
* igt@i915_selftest@live@hangcheck:
- shard-tglb: [DMESG-WARN][158] ([i915#5591]) -> [PASS][159]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-tglb5/igt@i915_selftest@live@hangcheck.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-tglb1/igt@i915_selftest@live@hangcheck.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-snb: [SKIP][160] ([fdo#109271]) -> [PASS][161]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-snb4/igt@kms_frontbuffer_tracking@fbc-badstride.html
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-snb6/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_vblank@pipe-b-accuracy-idle:
- shard-glk: [FAIL][162] ([i915#43]) -> [PASS][163]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-glk6/igt@kms_vblank@pipe-b-accuracy-idle.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-glk3/igt@kms_vblank@pipe-b-accuracy-idle.html
* igt@kms_writeback@writeback-invalid-parameters:
- {shard-tglu}: [SKIP][164] ([i915#2437]) -> [PASS][165]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-tglu-6/igt@kms_writeback@writeback-invalid-parameters.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-tglu-3/igt@kms_writeback@writeback-invalid-parameters.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-tglb: [SKIP][166] ([i915#2437]) -> [PASS][167] +1 similar issue
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-tglb1/igt@kms_writeback@writeback-pixel-formats.html
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-tglb7/igt@kms_writeback@writeback-pixel-formats.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-iclb: [FAIL][168] ([i915#2684]) -> [WARN][169] ([i915#2684])
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@runner@aborted:
- shard-apl: ([FAIL][170], [FAIL][171], [FAIL][172], [FAIL][173]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][174], [FAIL][175], [FAIL][176], [FAIL][177], [FAIL][178], [FAIL][179]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257])
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl8/igt@runner@aborted.html
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl1/igt@runner@aborted.html
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl3/igt@runner@aborted.html
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-apl6/igt@runner@aborted.html
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl1/igt@runner@aborted.html
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl6/igt@runner@aborted.html
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl8/igt@runner@aborted.html
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl3/igt@runner@aborted.html
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl7/igt@runner@aborted.html
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-apl3/igt@runner@aborted.html
- shard-tglb: ([FAIL][180], [FAIL][181]) ([i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][182], [FAIL][183]) ([i915#3002] / [i915#4312] / [i915#5257])
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-tglb8/igt@runner@aborted.html
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-tglb1/igt@runner@aborted.html
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-tglb7/igt@runner@aborted.html
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-tglb7/igt@runner@aborted.html
- shard-glk: ([FAIL][184], [FAIL][185], [FAIL][186], [FAIL][187]) ([i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][188], [FAIL][189], [FAIL][190], [FAIL][191], [FAIL][192]) ([i915#3002] / [i915#4312] / [i915#5257])
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-glk6/igt@runner@aborted.html
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-glk2/igt@runner@aborted.html
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-glk2/igt@runner@aborted.html
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-glk1/igt@runner@aborted.html
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-glk3/igt@runner@aborted.html
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-glk7/igt@runner@aborted.html
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-glk5/igt@runner@aborted.html
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-glk7/igt@runner@aborted.html
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-glk6/igt@runner@aborted.html
- shard-iclb: ([FAIL][193], [FAIL][194]) ([i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][195], [FAIL][196]) ([i915#3002] / [i915#4312] / [i915#5257])
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-iclb7/igt@runner@aborted.html
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12158/shard-iclb5/igt@runner@aborted.html
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-iclb1/igt@runner@aborted.html
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/shard-iclb8/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4386]: https://gitlab.freedesktop.org/drm/intel/issues/4386
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5030]: https://gitlab.freedesktop.org/drm/intel/issues/5030
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#6864]: https://gitlab.freedesktop.org/drm/intel/issues/6864
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
Build changes
-------------
* Linux: CI_DRM_12158 -> Patchwork_107440v7
CI-20190529: 20190529
CI_DRM_12158: 3bde74f15d452bf788ecab8933ee802b2ee9e673 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6656: 24100c4e181c50e3678aeca9c641b8a43555ad73 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107440v7: 3bde74f15d452bf788ecab8933ee802b2ee9e673 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v7/index.html
[-- Attachment #2: Type: text/html, Size: 36987 bytes --]
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev8)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (9 preceding siblings ...)
2022-09-20 8:36 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-09-20 14:27 ` Patchwork
2022-09-20 14:27 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (10 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-20 14:27 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
== Series Details ==
Series: Enable Pipewriteback (rev8)
URL : https://patchwork.freedesktop.org/series/107440/
State : warning
== Summary ==
Error: dim checkpatch failed
ad3709400df3 drm/i915: Define WD trancoder for i915
eace4fd2c2e8 drm/i915 : Changing intel_connector iterators
-:76: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#76: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1507:
+#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \
+ NULL : container_of(x, struct intel_connector, base))
-:76: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues
#76: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1507:
+#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \
+ NULL : container_of(x, struct intel_connector, base))
-:104: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#104: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2093:
+
+ }
total: 0 errors, 0 warnings, 3 checks, 104 lines checked
323af4b42ef5 drm/i915: Enabling WD Transcoder
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:559: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#559:
new file mode 100644
-:597: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!job"
#597: FILE: drivers/gpu/drm/i915/display/intel_wd.c:34:
+ if (job == NULL) {
-:634: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#634: FILE: drivers/gpu/drm/i915/display/intel_wd.c:71:
+ DRM_ERROR("unsupported pixel format %x!\n",
+ pixel_format);
-:712: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#712: FILE: drivers/gpu/drm/i915/display/intel_wd.c:149:
+ intel_de_write(i915, WD_STREAMCAP_CTL(intel_wd->trans),
+ *tmp);
-:735: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#735: FILE: drivers/gpu/drm/i915/display/intel_wd.c:172:
+ memcpy(pipe_config, intel_crtc->config,
+ sizeof(*pipe_config));
-:786: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#786: FILE: drivers/gpu/drm/i915/display/intel_wd.c:223:
+ wakeref = intel_display_power_get_if_enabled(dev_priv,
+ encoder->power_domain);
-:827: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#827: FILE: drivers/gpu/drm/i915/display/intel_wd.c:264:
+ drm_dbg_kms(&i915->drm, "Invalid framebuffer size %ux%u\n",
+ fb->width, fb->height);
-:834: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#834: FILE: drivers/gpu/drm/i915/display/intel_wd.c:271:
+ drm_dbg_kms(&i915->drm, "Unsupported framebuffer format %08x\n",
+ fb->format->format);
-:875: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#875: FILE: drivers/gpu/drm/i915/display/intel_wd.c:312:
+static bool intel_fastset_dis(struct intel_encoder *encoder,
+ struct intel_crtc_state *pipe_config)
-:929: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#929: FILE: drivers/gpu/drm/i915/display/intel_wd.c:366:
+ drm_encoder_helper_add(drm_enc,
+ &wd_encoder_helper_funcs);
-:944: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#944: FILE: drivers/gpu/drm/i915/display/intel_wd.c:381:
+ err = drm_writeback_connector_init_with_encoder(&i915->drm,
+ wb_conn, drm_enc, &wb_connector_funcs,
-:962: WARNING:RETURN_VOID: void function return statements are not generally useful
#962: FILE: drivers/gpu/drm/i915/display/intel_wd.c:399:
+ return;
+}
-:1008: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1008: FILE: drivers/gpu/drm/i915/display/intel_wd.c:445:
+ intel_de_write(dev_priv, WD_SURF(intel_wd->trans),
+ i915_ggtt_offset(intel_wd->vma));
-:1019: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1019: FILE: drivers/gpu/drm/i915/display/intel_wd.c:456:
+ tmp = intel_de_read(dev_priv,
+ WD_STREAMCAP_CTL(intel_wd->trans));
-:1108: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1108: FILE: drivers/gpu/drm/i915/display/intel_wd.c:545:
+ if (intel_de_wait_for_set(dev_priv, PIPECONF(intel_wd->trans),
+ WD_TRANS_ACTIVE, 10))
-:1130: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1130: FILE: drivers/gpu/drm/i915/display/intel_wd.c:567:
+ ret = intel_wd_setup_transcoder(intel_wd, pipe_config,
+ conn_state, job);
-:1179: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1179: FILE: drivers/gpu/drm/i915/display/intel_wd.c:616:
+void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state)
-:1196: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1196: FILE: drivers/gpu/drm/i915/display/intel_wd.c:633:
+ intel_wd_capture(intel_wd, pipe_config,
+ conn_state, job);
-:1201: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1201: FILE: drivers/gpu/drm/i915/display/intel_wd.c:638:
+void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *intel_crtc,
+ struct intel_crtc_state *intel_crtc_state)
-:1241: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#1241: FILE: drivers/gpu/drm/i915/display/intel_wd.c:678:
+ for_each_intel_encoder(&i915->drm, encoder) {
+
-:1306: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1306: FILE: drivers/gpu/drm/i915/display/intel_wd.h:43:
+void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state);
-:1309: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1309: FILE: drivers/gpu/drm/i915/display/intel_wd.h:46:
+void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *crtc,
+ struct intel_crtc_state *crtc_state);
total: 0 errors, 2 warnings, 20 checks, 1260 lines checked
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable Pipewriteback (rev8)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (10 preceding siblings ...)
2022-09-20 14:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev8) Patchwork
@ 2022-09-20 14:27 ` Patchwork
2022-09-20 14:51 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (9 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-20 14:27 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
== Series Details ==
Series: Enable Pipewriteback (rev8)
URL : https://patchwork.freedesktop.org/series/107440/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for Enable Pipewriteback (rev8)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (11 preceding siblings ...)
2022-09-20 14:27 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2022-09-20 14:51 ` Patchwork
2022-09-20 15:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (8 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-20 14:51 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5889 bytes --]
== Series Details ==
Series: Enable Pipewriteback (rev8)
URL : https://patchwork.freedesktop.org/series/107440/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12160 -> Patchwork_107440v8
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_107440v8 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_107440v8, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/index.html
Participating hosts (48 -> 35)
------------------------------
Missing (13): fi-cml-u2 bat-dg1-5 fi-hsw-4200u bat-dg2-8 bat-adlm-1 bat-dg2-9 bat-adlp-6 fi-ctg-p8600 bat-adln-1 fi-kbl-x1275 bat-rpls-1 fi-bdw-samus bat-jsl-1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107440v8:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@late_gt_pm:
- fi-glk-j4005: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/fi-glk-j4005/igt@i915_selftest@live@late_gt_pm.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-glk-j4005/igt@i915_selftest@live@late_gt_pm.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_module_load@load:
- {fi-tgl-mst}: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/fi-tgl-mst/igt@i915_module_load@load.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-tgl-mst/igt@i915_module_load@load.html
Known issues
------------
Here are the changes found in Patchwork_107440v8 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-pnv-d510: [PASS][5] -> [INCOMPLETE][6] ([i915#6863])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/fi-pnv-d510/igt@debugfs_test@read_all_entries.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-pnv-d510/igt@debugfs_test@read_all_entries.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@runner@aborted:
- fi-pnv-d510: NOTRUN -> [FAIL][8] ([i915#2403] / [i915#4312])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-pnv-d510/igt@runner@aborted.html
- fi-glk-j4005: NOTRUN -> [FAIL][9] ([i915#4312] / [i915#5257] / [i915#6884])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-glk-j4005/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][10] ([i915#4785]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
#### Warnings ####
* igt@runner@aborted:
- fi-kbl-guc: [FAIL][12] ([i915#6219]) -> [FAIL][13] ([i915#6219] / [i915#6884])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/fi-kbl-guc/igt@runner@aborted.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-kbl-guc/igt@runner@aborted.html
- fi-kbl-8809g: [FAIL][14] ([i915#6219]) -> [FAIL][15] ([i915#6219] / [i915#6884])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/fi-kbl-8809g/igt@runner@aborted.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-kbl-8809g/igt@runner@aborted.html
- fi-kbl-soraka: [FAIL][16] ([i915#6219]) -> [FAIL][17] ([i915#6219] / [i915#6884])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/fi-kbl-soraka/igt@runner@aborted.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-kbl-soraka/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#6219]: https://gitlab.freedesktop.org/drm/intel/issues/6219
[i915#6863]: https://gitlab.freedesktop.org/drm/intel/issues/6863
[i915#6884]: https://gitlab.freedesktop.org/drm/intel/issues/6884
Build changes
-------------
* Linux: CI_DRM_12160 -> Patchwork_107440v8
CI-20190529: 20190529
CI_DRM_12160: 33a5599358a6f7bc7bff21369c758303639b5bab @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6658: c27dcb9e0baca05abce8527c245b513f7a8f1059 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107440v8: 33a5599358a6f7bc7bff21369c758303639b5bab @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
5b8505f71d82 drm/i915: Enabling WD Transcoder
65873bc1d616 drm/i915 : Changing intel_connector iterators
a43d1e0e0e7d drm/i915: Define WD trancoder for i915
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/index.html
[-- Attachment #2: Type: text/html, Size: 7267 bytes --]
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Enable Pipewriteback (rev8)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (12 preceding siblings ...)
2022-09-20 14:51 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2022-09-20 15:43 ` Patchwork
2022-09-20 20:09 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (7 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-20 15:43 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5104 bytes --]
== Series Details ==
Series: Enable Pipewriteback (rev8)
URL : https://patchwork.freedesktop.org/series/107440/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12160 -> Patchwork_107440v8
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/index.html
Participating hosts (48 -> 35)
------------------------------
Missing (13): fi-cml-u2 bat-dg1-5 fi-hsw-4200u bat-dg2-8 bat-adlm-1 bat-dg2-9 bat-adlp-6 fi-ctg-p8600 bat-adln-1 fi-kbl-x1275 bat-rpls-1 fi-bdw-samus bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_107440v8 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-pnv-d510: [PASS][1] -> [INCOMPLETE][2] ([i915#6863])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/fi-pnv-d510/igt@debugfs_test@read_all_entries.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-pnv-d510/igt@debugfs_test@read_all_entries.html
* igt@i915_selftest@live@late_gt_pm:
- fi-glk-j4005: [PASS][3] -> [DMESG-FAIL][4] ([i915#6217])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/fi-glk-j4005/igt@i915_selftest@live@late_gt_pm.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-glk-j4005/igt@i915_selftest@live@late_gt_pm.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@runner@aborted:
- fi-pnv-d510: NOTRUN -> [FAIL][6] ([i915#2403] / [i915#4312])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-pnv-d510/igt@runner@aborted.html
- fi-glk-j4005: NOTRUN -> [FAIL][7] ([i915#4312] / [i915#5257] / [i915#6884])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-glk-j4005/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][8] ([i915#4785]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
#### Warnings ####
* igt@runner@aborted:
- fi-kbl-guc: [FAIL][10] ([i915#6219]) -> [FAIL][11] ([i915#6219] / [i915#6884])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/fi-kbl-guc/igt@runner@aborted.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-kbl-guc/igt@runner@aborted.html
- fi-kbl-8809g: [FAIL][12] ([i915#6219]) -> [FAIL][13] ([i915#6219] / [i915#6884])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/fi-kbl-8809g/igt@runner@aborted.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-kbl-8809g/igt@runner@aborted.html
- fi-kbl-soraka: [FAIL][14] ([i915#6219]) -> [FAIL][15] ([i915#6219] / [i915#6884])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/fi-kbl-soraka/igt@runner@aborted.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/fi-kbl-soraka/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#6217]: https://gitlab.freedesktop.org/drm/intel/issues/6217
[i915#6219]: https://gitlab.freedesktop.org/drm/intel/issues/6219
[i915#6863]: https://gitlab.freedesktop.org/drm/intel/issues/6863
[i915#6884]: https://gitlab.freedesktop.org/drm/intel/issues/6884
[i915#6886]: https://gitlab.freedesktop.org/drm/intel/issues/6886
Build changes
-------------
* Linux: CI_DRM_12160 -> Patchwork_107440v8
CI-20190529: 20190529
CI_DRM_12160: 33a5599358a6f7bc7bff21369c758303639b5bab @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6658: c27dcb9e0baca05abce8527c245b513f7a8f1059 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107440v8: 33a5599358a6f7bc7bff21369c758303639b5bab @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
5b8505f71d82 drm/i915: Enabling WD Transcoder
65873bc1d616 drm/i915 : Changing intel_connector iterators
a43d1e0e0e7d drm/i915: Define WD trancoder for i915
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/index.html
[-- Attachment #2: Type: text/html, Size: 6367 bytes --]
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for Enable Pipewriteback (rev8)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (13 preceding siblings ...)
2022-09-20 15:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-09-20 20:09 ` Patchwork
2022-09-21 2:07 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev9) Patchwork
` (6 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-20 20:09 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 25786 bytes --]
== Series Details ==
Series: Enable Pipewriteback (rev8)
URL : https://patchwork.freedesktop.org/series/107440/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12160_full -> Patchwork_107440v8_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_107440v8_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_107440v8_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 9)
------------------------------
Missing (1): shard-tglu
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107440v8_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_plane_scaling@plane-scaler-with-modifiers-unity-scaling@pipe-c-edp-1:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-tglb3/igt@kms_plane_scaling@plane-scaler-with-modifiers-unity-scaling@pipe-c-edp-1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-tglb8/igt@kms_plane_scaling@plane-scaler-with-modifiers-unity-scaling@pipe-c-edp-1.html
#### Warnings ####
* igt@kms_writeback@writeback-check-output:
- shard-tglb: [SKIP][3] ([i915#2437]) -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-tglb2/igt@kms_writeback@writeback-check-output.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-tglb5/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-fb-id:
- shard-tglb: [SKIP][5] ([i915#2437]) -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-tglb5/igt@kms_writeback@writeback-fb-id.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-tglb3/igt@kms_writeback@writeback-fb-id.html
Known issues
------------
Here are the changes found in Patchwork_107440v8_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-skl: ([PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30]) -> ([PASS][31], [PASS][32], [PASS][33], [PASS][34], [FAIL][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55]) ([i915#5032])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl10/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl10/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl10/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl10/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl1/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl1/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl1/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl2/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl2/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl2/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl4/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl4/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl5/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl5/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl5/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl6/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl6/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl7/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl7/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl7/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl9/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl9/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-skl9/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl9/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl9/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl9/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl7/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl7/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl6/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl6/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl6/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl5/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl5/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl4/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl4/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl4/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl2/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl2/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl2/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl1/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl1/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl1/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl1/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl10/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl10/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl10/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-skl10/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-snb: [PASS][56] -> [DMESG-WARN][57] ([i915#5090])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-snb2/igt@gem_ctx_isolation@preservation-s3@rcs0.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-snb6/igt@gem_ctx_isolation@preservation-s3@rcs0.html
* igt@gem_exec_balancer@parallel:
- shard-iclb: [PASS][58] -> [SKIP][59] ([i915#4525])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-iclb2/igt@gem_exec_balancer@parallel.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb8/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][60] -> [FAIL][61] ([i915#2846])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-glk2/igt@gem_exec_fair@basic-deadline.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-glk7/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [PASS][62] -> [FAIL][63] ([i915#2842]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-glk5/igt@gem_exec_fair@basic-pace@vcs0.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-glk2/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-glk: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#4613])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-glk5/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-glk: NOTRUN -> [SKIP][65] ([fdo#109271] / [fdo#111827]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-glk5/igt@kms_chamelium@hdmi-aspect-ratio.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][66] -> [FAIL][67] ([i915#4767])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-apl7/igt@kms_fbcon_fbt@fbc-suspend.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][68] -> [FAIL][69] ([i915#79])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@plain-flip-ts-check@a-hdmi-a1:
- shard-glk: [PASS][70] -> [FAIL][71] ([i915#2122])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-glk2/igt@kms_flip@plain-flip-ts-check@a-hdmi-a1.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-glk7/igt@kms_flip@plain-flip-ts-check@a-hdmi-a1.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][72] ([i915#2672])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][73] ([i915#3555])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][74] ([i915#2587] / [i915#2672]) +3 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling@pipe-a-valid-mode:
- shard-glk: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#1888])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-glk5/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][76] ([i915#2672] / [i915#3555]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1:
- shard-iclb: [PASS][77] -> [SKIP][78] ([i915#5235]) +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-iclb3/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-c-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][79] ([fdo#109271]) +38 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-glk5/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-c-hdmi-a-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf:
- shard-glk: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#658])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-glk5/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [PASS][81] -> [SKIP][82] ([fdo#109441])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb8/igt@kms_psr@psr2_primary_blt.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][83] -> [DMESG-WARN][84] ([i915#180])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-apl8/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-apl8/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-glk: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#2437])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-glk5/igt@kms_writeback@writeback-invalid-parameters.html
* igt@sysfs_clients@busy:
- shard-glk: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#2994])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-glk5/igt@sysfs_clients@busy.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [FAIL][87] ([i915#6268]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-tglb1/igt@gem_ctx_exec@basic-nohangcheck.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-tglb2/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-apl: [TIMEOUT][89] ([i915#3063]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-apl1/igt@gem_eio@in-flight-contexts-1us.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-apl3/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][91] ([i915#4525]) -> [PASS][92] +3 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-iclb7/igt@gem_exec_balancer@parallel-keep-in-fence.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb2/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][93] ([i915#2842]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [FAIL][95] ([i915#2842]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-glk5/igt@gem_exec_fair@basic-pace@rcs0.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-glk2/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][97] ([i915#2842]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb1/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_reloc@basic-wc-cpu-active:
- shard-apl: [DMESG-WARN][99] ([i915#165] / [i915#62]) -> [PASS][100] +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-apl3/igt@gem_exec_reloc@basic-wc-cpu-active.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-apl8/igt@gem_exec_reloc@basic-wc-cpu-active.html
* igt@gem_exec_suspend@basic-s3-devices@smem:
- shard-apl: [DMESG-WARN][101] ([i915#165] / [i915#180] / [i915#62]) -> [PASS][102] +5 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-apl3/igt@gem_exec_suspend@basic-s3-devices@smem.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-apl8/igt@gem_exec_suspend@basic-s3-devices@smem.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][103] ([i915#4281]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb7/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [FAIL][105] ([i915#6537]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-apl1/igt@i915_pm_rps@engine-order.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-apl3/igt@i915_pm_rps@engine-order.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
- shard-apl: [DMESG-WARN][107] ([i915#62]) -> [PASS][108] +26 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-apl3/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-apl8/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][109] ([i915#2122]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-glk6/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-glk5/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [FAIL][111] ([i915#79]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-glk5/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
* igt@kms_flip@flip-vs-fences-interruptible@a-dp1:
- shard-apl: [DMESG-WARN][113] ([i915#165] / [i915#1982] / [i915#62]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-apl3/igt@kms_flip@flip-vs-fences-interruptible@a-dp1.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-apl8/igt@kms_flip@flip-vs-fences-interruptible@a-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode:
- shard-iclb: [SKIP][115] ([i915#3555]) -> [PASS][116] +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1:
- shard-iclb: [SKIP][117] ([i915#5176]) -> [PASS][118] +2 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-iclb2/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb8/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][119] ([fdo#109441]) -> [PASS][120] +2 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-tglb: [SKIP][121] ([i915#2437]) -> [PASS][122] +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-tglb3/igt@kms_writeback@writeback-pixel-formats.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-tglb5/igt@kms_writeback@writeback-pixel-formats.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][123] ([i915#658]) -> [SKIP][124] ([i915#588])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-iclb7/igt@i915_pm_dc@dc3co-vpb-simulation.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][125] ([i915#2920]) -> [SKIP][126] ([i915#658])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb8/igt@kms_psr2_sf@overlay-plane-move-continuous-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][127] ([i915#2920]) -> [SKIP][128] ([fdo#111068] / [i915#658]) +1 similar issue
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: [SKIP][129] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][130] ([i915#5939])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12160/shard-iclb3/igt@kms_psr2_su@page_flip-nv12.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#5032]: https://gitlab.freedesktop.org/drm/intel/issues/5032
[i915#5090]: https://gitlab.freedesktop.org/drm/intel/issues/5090
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12160 -> Patchwork_107440v8
CI-20190529: 20190529
CI_DRM_12160: 33a5599358a6f7bc7bff21369c758303639b5bab @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6658: c27dcb9e0baca05abce8527c245b513f7a8f1059 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107440v8: 33a5599358a6f7bc7bff21369c758303639b5bab @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v8/index.html
[-- Attachment #2: Type: text/html, Size: 29916 bytes --]
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev9)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (14 preceding siblings ...)
2022-09-20 20:09 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-09-21 2:07 ` Patchwork
2022-09-21 2:07 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
` (5 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-21 2:07 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
== Series Details ==
Series: Enable Pipewriteback (rev9)
URL : https://patchwork.freedesktop.org/series/107440/
State : warning
== Summary ==
Error: dim checkpatch failed
aaa52a3b740d drm/i915: Define WD trancoder for i915
f81ac46ac2d3 drm/i915 : Changing intel_connector iterators
-:76: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#76: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1507:
+#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \
+ NULL : container_of(x, struct intel_connector, base))
-:76: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues
#76: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1507:
+#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \
+ NULL : container_of(x, struct intel_connector, base))
-:104: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#104: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2093:
+
+ }
total: 0 errors, 0 warnings, 3 checks, 104 lines checked
42c5bd3fff8c drm/i915: Enabling WD Transcoder
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 11, in <module>
import git
ModuleNotFoundError: No module named 'git'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 11, in <module>
import git
ModuleNotFoundError: No module named 'git'
-:559: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#559:
new file mode 100644
-:597: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!job"
#597: FILE: drivers/gpu/drm/i915/display/intel_wd.c:34:
+ if (job == NULL) {
-:634: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#634: FILE: drivers/gpu/drm/i915/display/intel_wd.c:71:
+ DRM_ERROR("unsupported pixel format %x!\n",
+ pixel_format);
-:712: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#712: FILE: drivers/gpu/drm/i915/display/intel_wd.c:149:
+ intel_de_write(i915, WD_STREAMCAP_CTL(intel_wd->trans),
+ *tmp);
-:735: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#735: FILE: drivers/gpu/drm/i915/display/intel_wd.c:172:
+ memcpy(pipe_config, intel_crtc->config,
+ sizeof(*pipe_config));
-:786: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#786: FILE: drivers/gpu/drm/i915/display/intel_wd.c:223:
+ wakeref = intel_display_power_get_if_enabled(dev_priv,
+ encoder->power_domain);
-:827: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#827: FILE: drivers/gpu/drm/i915/display/intel_wd.c:264:
+ drm_dbg_kms(&i915->drm, "Invalid framebuffer size %ux%u\n",
+ fb->width, fb->height);
-:834: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#834: FILE: drivers/gpu/drm/i915/display/intel_wd.c:271:
+ drm_dbg_kms(&i915->drm, "Unsupported framebuffer format %08x\n",
+ fb->format->format);
-:875: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#875: FILE: drivers/gpu/drm/i915/display/intel_wd.c:312:
+static bool intel_fastset_dis(struct intel_encoder *encoder,
+ struct intel_crtc_state *pipe_config)
-:929: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#929: FILE: drivers/gpu/drm/i915/display/intel_wd.c:366:
+ drm_encoder_helper_add(drm_enc,
+ &wd_encoder_helper_funcs);
-:944: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#944: FILE: drivers/gpu/drm/i915/display/intel_wd.c:381:
+ err = drm_writeback_connector_init_with_encoder(&i915->drm,
+ wb_conn, drm_enc, &wb_connector_funcs,
-:962: WARNING:RETURN_VOID: void function return statements are not generally useful
#962: FILE: drivers/gpu/drm/i915/display/intel_wd.c:399:
+ return;
+}
-:1008: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1008: FILE: drivers/gpu/drm/i915/display/intel_wd.c:445:
+ intel_de_write(dev_priv, WD_SURF(intel_wd->trans),
+ i915_ggtt_offset(intel_wd->vma));
-:1019: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1019: FILE: drivers/gpu/drm/i915/display/intel_wd.c:456:
+ tmp = intel_de_read(dev_priv,
+ WD_STREAMCAP_CTL(intel_wd->trans));
-:1108: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1108: FILE: drivers/gpu/drm/i915/display/intel_wd.c:545:
+ if (intel_de_wait_for_set(dev_priv, PIPECONF(intel_wd->trans),
+ WD_TRANS_ACTIVE, 10))
-:1130: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1130: FILE: drivers/gpu/drm/i915/display/intel_wd.c:567:
+ ret = intel_wd_setup_transcoder(intel_wd, pipe_config,
+ conn_state, job);
-:1179: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1179: FILE: drivers/gpu/drm/i915/display/intel_wd.c:616:
+void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state)
-:1196: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1196: FILE: drivers/gpu/drm/i915/display/intel_wd.c:633:
+ intel_wd_capture(intel_wd, pipe_config,
+ conn_state, job);
-:1201: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1201: FILE: drivers/gpu/drm/i915/display/intel_wd.c:638:
+void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *intel_crtc,
+ struct intel_crtc_state *intel_crtc_state)
-:1241: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#1241: FILE: drivers/gpu/drm/i915/display/intel_wd.c:678:
+ for_each_intel_encoder(&i915->drm, encoder) {
+
-:1306: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1306: FILE: drivers/gpu/drm/i915/display/intel_wd.h:43:
+void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
+ struct drm_connector_state *conn_state);
-:1309: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1309: FILE: drivers/gpu/drm/i915/display/intel_wd.h:46:
+void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *crtc,
+ struct intel_crtc_state *crtc_state);
total: 0 errors, 2 warnings, 20 checks, 1260 lines checked
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable Pipewriteback (rev9)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (15 preceding siblings ...)
2022-09-21 2:07 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev9) Patchwork
@ 2022-09-21 2:07 ` Patchwork
2022-09-21 2:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (4 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-21 2:07 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
== Series Details ==
Series: Enable Pipewriteback (rev9)
URL : https://patchwork.freedesktop.org/series/107440/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Enable Pipewriteback (rev9)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (16 preceding siblings ...)
2022-09-21 2:07 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
@ 2022-09-21 2:26 ` Patchwork
2022-09-21 3:35 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
` (3 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-21 2:26 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4706 bytes --]
== Series Details ==
Series: Enable Pipewriteback (rev9)
URL : https://patchwork.freedesktop.org/series/107440/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12162 -> Patchwork_107440v9
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/index.html
Participating hosts (44 -> 42)
------------------------------
Additional (1): fi-tgl-dsi
Missing (3): fi-icl-u2 fi-bdw-samus fi-tgl-u2
Known issues
------------
Here are the changes found in Patchwork_107440v9 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][1] -> [INCOMPLETE][2] ([i915#4785])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-5557u: [PASS][3] -> [INCOMPLETE][4] ([i915#146] / [i915#6712])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][5] ([fdo#109271] / [i915#4312] / [i915#5594] / [i915#6246])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/fi-hsw-4770/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-adlm-1}: [DMESG-WARN][6] ([i915#2867]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_selftest@live@reset:
- {bat-rpls-1}: [DMESG-FAIL][8] ([i915#4983]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/bat-rpls-1/igt@i915_selftest@live@reset.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [FAIL][10] ([i915#6298]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#6246]: https://gitlab.freedesktop.org/drm/intel/issues/6246
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6712]: https://gitlab.freedesktop.org/drm/intel/issues/6712
Build changes
-------------
* Linux: CI_DRM_12162 -> Patchwork_107440v9
CI-20190529: 20190529
CI_DRM_12162: 1d049fe35537d9239f350ab1b728b5c0dda5907c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6659: 1becf700a737a7a98555a0cfbe8566355377afb2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107440v9: 1d049fe35537d9239f350ab1b728b5c0dda5907c @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
21eae8e7e462 drm/i915: Enabling WD Transcoder
e9d0f9eda842 drm/i915 : Changing intel_connector iterators
0ca8f93389fb drm/i915: Define WD trancoder for i915
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/index.html
[-- Attachment #2: Type: text/html, Size: 5132 bytes --]
^ permalink raw reply [flat|nested] 30+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for Enable Pipewriteback (rev9)
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (17 preceding siblings ...)
2022-09-21 2:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-09-21 3:35 ` Patchwork
2022-09-21 5:14 ` [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (2 subsequent siblings)
21 siblings, 0 replies; 30+ messages in thread
From: Patchwork @ 2022-09-21 3:35 UTC (permalink / raw)
To: Kandpal, Suraj; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 34090 bytes --]
== Series Details ==
Series: Enable Pipewriteback (rev9)
URL : https://patchwork.freedesktop.org/series/107440/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12162_full -> Patchwork_107440v9_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_107440v9_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_107440v9_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_107440v9_full:
### IGT changes ###
#### Warnings ####
* igt@kms_writeback@writeback-check-output:
- shard-tglb: [SKIP][1] ([i915#2437]) -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-tglb3/igt@kms_writeback@writeback-check-output.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-tglb1/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-fb-id:
- shard-tglb: [SKIP][3] ([i915#2437]) -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-tglb2/igt@kms_writeback@writeback-fb-id.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-tglb8/igt@kms_writeback@writeback-fb-id.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_prime@basic-crc-vgem@second-to-first:
- {shard-tglu}: [PASS][5] -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-tglu-6/igt@kms_prime@basic-crc-vgem@second-to-first.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-tglu-6/igt@kms_prime@basic-crc-vgem@second-to-first.html
* igt@kms_writeback@writeback-check-output:
- {shard-tglu}: [SKIP][7] ([i915#2437]) -> [DMESG-FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-tglu-4/igt@kms_writeback@writeback-check-output.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-tglu-4/igt@kms_writeback@writeback-check-output.html
* igt@kms_writeback@writeback-fb-id:
- {shard-tglu}: [SKIP][9] ([i915#2437]) -> [FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-tglu-6/igt@kms_writeback@writeback-fb-id.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-tglu-3/igt@kms_writeback@writeback-fb-id.html
Known issues
------------
Here are the changes found in Patchwork_107440v9_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@reset-stress:
- shard-tglb: [PASS][11] -> [FAIL][12] ([i915#5784])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-tglb7/igt@gem_eio@reset-stress.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-tglb5/igt@gem_eio@reset-stress.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][13] -> [SKIP][14] ([i915#4525]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb2/igt@gem_exec_balancer@parallel-keep-in-fence.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb5/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: NOTRUN -> [FAIL][15] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-glk7/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_lmem_swapping@massive-random:
- shard-glk: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#4613]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-glk7/igt@gem_lmem_swapping@massive-random.html
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#4613])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl1/igt@gem_lmem_swapping@massive-random.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [PASS][18] -> [DMESG-WARN][19] ([i915#5566] / [i915#716])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-apl7/igt@gen9_exec_parse@allowed-single.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl8/igt@gen9_exec_parse@allowed-single.html
* igt@i915_selftest@live@hangcheck:
- shard-tglb: [PASS][20] -> [DMESG-WARN][21] ([i915#5591])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-tglb7/igt@i915_selftest@live@hangcheck.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-tglb2/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@basic-s3-without-i915:
- shard-snb: [PASS][22] -> [SKIP][23] ([fdo#109271])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-snb2/igt@i915_suspend@basic-s3-without-i915.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-snb6/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3886]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-glk7/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3886]) +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl7/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@dp-crc-multiple:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl7/igt@kms_chamelium@dp-crc-multiple.html
* igt@kms_cursor_crc@cursor-sliding-32x32:
- shard-apl: NOTRUN -> [SKIP][27] ([fdo#109271]) +44 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl7/igt@kms_cursor_crc@cursor-sliding-32x32.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][28] -> [INCOMPLETE][29] ([i915#180] / [i915#1982] / [i915#4939])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][30] ([i915#2587] / [i915#2672]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb6/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#2672]) +6 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][32] -> [SKIP][33] ([i915#3555]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][34] ([i915#3555])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][35] ([i915#2672] / [i915#3555])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-default-mode.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1:
- shard-iclb: [PASS][36] -> [SKIP][37] ([i915#5176]) +4 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb6/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb2/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][38] -> [SKIP][39] ([i915#5235]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb3/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-apl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#658])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl1/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html
- shard-glk: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#658])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-glk7/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][42] -> [SKIP][43] ([fdo#109441]) +3 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb8/igt@kms_psr@psr2_sprite_blt.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#533])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl1/igt@kms_vblank@pipe-d-wait-idle.html
- shard-glk: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#533])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-glk7/igt@kms_vblank@pipe-d-wait-idle.html
* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-glk: NOTRUN -> [SKIP][46] ([fdo#109271]) +39 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-glk7/igt@nouveau_crc@pipe-d-ctx-flip-detection.html
* igt@perf@polling-parameterized:
- shard-glk: [PASS][47] -> [FAIL][48] ([i915#5639])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-glk2/igt@perf@polling-parameterized.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-glk1/igt@perf@polling-parameterized.html
* igt@perf_pmu@rc6-suspend:
- shard-apl: [PASS][49] -> [DMESG-WARN][50] ([i915#180])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-apl7/igt@perf_pmu@rc6-suspend.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl8/igt@perf_pmu@rc6-suspend.html
#### Possible fixes ####
* igt@fbdev@unaligned-write:
- {shard-rkl}: [SKIP][51] ([i915#2582]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-1/igt@fbdev@unaligned-write.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-6/igt@fbdev@unaligned-write.html
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][53] ([i915#658]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb6/igt@feature_discovery@psr2.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][55] ([i915#4525]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb6/igt@gem_exec_balancer@parallel-bb-first.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb2/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][57] ([i915#2842]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb5/igt@gem_exec_fair@basic-none-share@rcs0.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][59] ([i915#2842]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl8/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-glk: [FAIL][61] ([i915#2842]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-glk1/igt@gem_exec_fair@basic-pace@vecs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-glk3/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_fence@basic-busy@bcs0:
- {shard-rkl}: [SKIP][63] ([i915#6251]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-5/igt@gem_exec_fence@basic-busy@bcs0.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-2/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_exec_reloc@basic-wc-read-noreloc:
- {shard-rkl}: [SKIP][65] ([i915#3281]) -> [PASS][66] +17 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-2/igt@gem_exec_reloc@basic-wc-read-noreloc.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-5/igt@gem_exec_reloc@basic-wc-read-noreloc.html
* igt@gem_partial_pwrite_pread@writes-after-reads:
- {shard-rkl}: [SKIP][67] ([i915#3282]) -> [PASS][68] +5 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-6/igt@gem_partial_pwrite_pread@writes-after-reads.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads.html
* igt@gen9_exec_parse@bb-start-out:
- {shard-rkl}: [SKIP][69] ([i915#2527]) -> [PASS][70] +3 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-6/igt@gen9_exec_parse@bb-start-out.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-5/igt@gen9_exec_parse@bb-start-out.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][71] ([i915#3989] / [i915#454]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@i2c:
- {shard-rkl}: [SKIP][73] ([fdo#109308]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-1/igt@i915_pm_rpm@i2c.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-6/igt@i915_pm_rpm@i2c.html
* igt@i915_pm_sseu@full-enable:
- {shard-rkl}: [SKIP][75] ([i915#4387]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-6/igt@i915_pm_sseu@full-enable.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-5/igt@i915_pm_sseu@full-enable.html
* igt@i915_selftest@live@gem_contexts:
- shard-iclb: [DMESG-WARN][77] ([i915#2867]) -> [PASS][78] +5 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb2/igt@i915_selftest@live@gem_contexts.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb5/igt@i915_selftest@live@gem_contexts.html
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs:
- {shard-rkl}: [SKIP][79] ([i915#1845] / [i915#4098]) -> [PASS][80] +27 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-1/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-6/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs.html
* igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1:
- shard-apl: [DMESG-WARN][81] ([i915#180]) -> [PASS][82] +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-apl2/igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl3/igt@kms_cursor_crc@cursor-suspend@pipe-c-dp-1.html
* igt@kms_fbcon_fbt@psr-suspend:
- {shard-rkl}: [SKIP][83] ([fdo#110189] / [i915#3955]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-1/igt@kms_fbcon_fbt@psr-suspend.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-6/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [SKIP][85] ([i915#3555]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- {shard-rkl}: [SKIP][87] ([i915#1849] / [i915#4098]) -> [PASS][88] +23 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-badstride.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- {shard-rkl}: [SKIP][89] ([i915#1849] / [i915#3546] / [i915#4070] / [i915#4098]) -> [PASS][90] +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_properties@plane-properties-legacy:
- {shard-rkl}: [SKIP][91] ([i915#1849]) -> [PASS][92] +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-1/igt@kms_properties@plane-properties-legacy.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-6/igt@kms_properties@plane-properties-legacy.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [SKIP][93] ([fdo#109441]) -> [PASS][94] +2 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_cpu.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_psr@sprite_plane_onoff:
- {shard-rkl}: [SKIP][95] ([i915#1072]) -> [PASS][96] +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-1/igt@kms_psr@sprite_plane_onoff.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-6/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_universal_plane@universal-plane-pipe-b-functional:
- {shard-rkl}: [SKIP][97] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][98] +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-2/igt@kms_universal_plane@universal-plane-pipe-b-functional.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-6/igt@kms_universal_plane@universal-plane-pipe-b-functional.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-tglb: [SKIP][99] ([i915#2437]) -> [PASS][100] +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-tglb7/igt@kms_writeback@writeback-pixel-formats.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-tglb1/igt@kms_writeback@writeback-pixel-formats.html
- {shard-tglu}: [SKIP][101] ([i915#2437]) -> [PASS][102] +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-tglu-3/igt@kms_writeback@writeback-pixel-formats.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-tglu-1/igt@kms_writeback@writeback-pixel-formats.html
- {shard-rkl}: [SKIP][103] ([i915#2437]) -> [PASS][104] +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-1/igt@kms_writeback@writeback-pixel-formats.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-6/igt@kms_writeback@writeback-pixel-formats.html
* igt@perf@gen8-unprivileged-single-ctx-counters:
- {shard-rkl}: [SKIP][105] ([i915#2436]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-2/igt@perf@gen8-unprivileged-single-ctx-counters.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-5/igt@perf@gen8-unprivileged-single-ctx-counters.html
* igt@perf@polling-parameterized:
- {shard-rkl}: [FAIL][107] ([i915#5639]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-1/igt@perf@polling-parameterized.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-2/igt@perf@polling-parameterized.html
* igt@perf@polling-small-buf:
- {shard-rkl}: [FAIL][109] ([i915#1722]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-2/igt@perf@polling-small-buf.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-5/igt@perf@polling-small-buf.html
* igt@perf@stress-open-close:
- shard-glk: [INCOMPLETE][111] ([i915#5213]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-glk8/igt@perf@stress-open-close.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-glk7/igt@perf@stress-open-close.html
* igt@prime_vgem@coherency-gtt:
- {shard-rkl}: [SKIP][113] ([fdo#109295] / [fdo#111656] / [i915#3708]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-rkl-2/igt@prime_vgem@coherency-gtt.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-rkl-5/igt@prime_vgem@coherency-gtt.html
#### Warnings ####
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][115] ([i915#2920]) -> [SKIP][116] ([i915#658]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb3/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][117] ([fdo#111068] / [i915#658]) -> [SKIP][118] ([i915#2920])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb3/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-iclb: [SKIP][119] ([i915#658]) -> [SKIP][120] ([i915#2920]) +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: [SKIP][121] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][122] ([i915#5939])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-iclb6/igt@kms_psr2_su@page_flip-nv12.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html
* igt@runner@aborted:
- shard-apl: ([FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6884]) -> ([FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6884])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-apl3/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-apl2/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-apl8/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-apl1/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-apl3/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12162/shard-apl6/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl8/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl7/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl3/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl8/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl1/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-apl3/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6403]: https://gitlab.freedesktop.org/drm/intel/issues/6403
[i915#6474]: https://gitlab.freedesktop.org/drm/intel/issues/6474
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6884]: https://gitlab.freedesktop.org/drm/intel/issues/6884
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
Build changes
-------------
* Linux: CI_DRM_12162 -> Patchwork_107440v9
CI-20190529: 20190529
CI_DRM_12162: 1d049fe35537d9239f350ab1b728b5c0dda5907c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6659: 1becf700a737a7a98555a0cfbe8566355377afb2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107440v9: 1d049fe35537d9239f350ab1b728b5c0dda5907c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/index.html
[-- Attachment #2: Type: text/html, Size: 37865 bytes --]
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (18 preceding siblings ...)
2022-09-21 3:35 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2022-09-21 5:14 ` Kandpal, Suraj
2022-09-28 12:46 ` Swati Sharma
2022-09-28 15:15 ` Swati Sharma
21 siblings, 0 replies; 30+ messages in thread
From: Kandpal, Suraj @ 2022-09-21 5:14 UTC (permalink / raw)
To: intel-gfx; +Cc: Nikula, Jani
Hi Jani,
All patches have been reviewed by Arun it would be great if you could have a
Look and give an ACK.
Regards,
Suraj Kandpal
> Subject: [PATCH v6 0/3] Enable Pipewriteback
>
> A patch series was floated in the drm mailing list which aimed to change the
> drm_connector and drm_encoder fields to pointer in the
> drm_connector_writeback structure, this received a huge pushback from the
> community but since i915 expects each connector present in the drm_device
> list to be a intel_connector but drm_writeback framework makes us have a
> connector which cannot be embedded in an intel_connector structure.
> [1]
> https://patchwork.kernel.org/project/dri-
> devel/patch/20220202081702.22119-1-suraj.kandpal@intel.com/
> [2]
> https://patchwork.kernel.org/project/dri-
> devel/patch/20220202085429.22261-6-suraj.kandpal@intel.com/
> Since no one had an issue with encoder field being changed into a pointer it
> was decided to break the connector and encoder pointer changes into two
> different series.The encoder field changes is currently being worked upon by
> Abhinav Kumar and the changes have been merged.
> [3]https://patchwork.kernel.org/project/dri-devel/list/?series=633565
> Going forward we use a drm_connector which is not embedded in
> intel_connector.
> We also create a intel_encoder to avoid changes to many iterators but no
> intel_connector. We also changed all iterators that
>
> ---v2
> solving BAT issues
>
> ---v3
> -removing unecessary comments from i915_reg.h [Arun] -moving wd_init into
> its own if condition [Arun] -fixing comment styling and alignment in intel_wd.c
> [Arun] -removing continue from loop and calling function if condition is met
> [Arun] -removing useless arguments from intel_queue_writeback_job and
> intel_enabling_capture [Arun]
>
> --v4
> Adding Reviewed-by to patches which were previously reviewd
>
> --v5
> Adding Reviewed-by for patch 3
>
> --v6
> Solving BAT issue
> changes for checkpatch to pass
>
> Suraj Kandpal (3):
> drm/i915: Define WD trancoder for i915
> drm/i915 : Changing intel_connector iterators
> drm/i915: Enabling WD Transcoder
>
> drivers/gpu/drm/i915/Makefile | 1 +
> drivers/gpu/drm/i915/display/intel_acpi.c | 8 +-
> drivers/gpu/drm/i915/display/intel_crtc.c | 6 +
> .../drm/i915/display/intel_crtc_state_dump.c | 1 +
> drivers/gpu/drm/i915/display/intel_ddi.c | 6 +
> drivers/gpu/drm/i915/display/intel_display.c | 68 +-
> drivers/gpu/drm/i915/display/intel_display.h | 18 +-
> .../drm/i915/display/intel_display_debugfs.c | 13 +-
> .../drm/i915/display/intel_display_types.h | 32 +-
> drivers/gpu/drm/i915/display/intel_dpll.c | 6 +
> .../drm/i915/display/intel_modeset_setup.c | 119 ++-
> .../drm/i915/display/intel_modeset_verify.c | 17 +-
> drivers/gpu/drm/i915/display/intel_opregion.c | 3 +
> drivers/gpu/drm/i915/display/intel_wd.c | 694 ++++++++++++++++++
> drivers/gpu/drm/i915/display/intel_wd.h | 48 ++
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/i915_irq.c | 8 +-
> drivers/gpu/drm/i915/i915_pci.c | 7 +-
> drivers/gpu/drm/i915/i915_reg.h | 137 ++++
> 19 files changed, 1137 insertions(+), 56 deletions(-) create mode 100644
> drivers/gpu/drm/i915/display/intel_wd.c
> create mode 100644 drivers/gpu/drm/i915/display/intel_wd.h
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (19 preceding siblings ...)
2022-09-21 5:14 ` [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
@ 2022-09-28 12:46 ` Swati Sharma
2022-09-28 13:55 ` Kandpal, Suraj
2022-09-28 15:15 ` Swati Sharma
21 siblings, 1 reply; 30+ messages in thread
From: Swati Sharma @ 2022-09-28 12:46 UTC (permalink / raw)
To: Kandpal, Suraj, intel-gfx; +Cc: jani.nikula
Hi Suraj,
CI is not green
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shards-all.html?testfilter=kms_writeback
2/4 subtests are passing
writeback-fb-id subtest can be fixed by asserting EINVAL for i915
we need to fix writeback-check-output first
On local validation, we were getting CRC mismatch however CI results
show different issue
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-tglu-4/igt@kms_writeback@writeback-check-output.html#dmesg-warnings575
Please check the same if its relevant.
On 19-Sep-22 6:35 PM, Kandpal, Suraj wrote:
> A patch series was floated in the drm mailing list which aimed to change
> the drm_connector and drm_encoder fields to pointer in the
> drm_connector_writeback structure, this received a huge pushback from
> the community but since i915 expects each connector present in the
> drm_device list to be a intel_connector but drm_writeback framework
> makes us have a connector which cannot be embedded in an intel_connector
> structure.
> [1]
> https://patchwork.kernel.org/project/dri-devel/patch/20220202081702.22119-1-suraj.kandpal@intel.com/
> [2]
> https://patchwork.kernel.org/project/dri-devel/patch/20220202085429.22261-6-suraj.kandpal@intel.com/
> Since no one had an issue with encoder field being changed into a
> pointer it was decided to break the connector and encoder pointer
> changes into two different series.The encoder field changes is
> currently being worked upon by Abhinav Kumar and the changes have been
> merged.
> [3]https://patchwork.kernel.org/project/dri-devel/list/?series=633565
> Going forward we use a drm_connector which is not embedded in
> intel_connector.
> We also create a intel_encoder to avoid changes to many
> iterators but no intel_connector. We also changed all iterators that
>
> ---v2
> solving BAT issues
>
> ---v3
> -removing unecessary comments from i915_reg.h [Arun]
> -moving wd_init into its own if condition [Arun]
> -fixing comment styling and alignment in intel_wd.c [Arun]
> -removing continue from loop and calling function if condition is met
> [Arun]
> -removing useless arguments from intel_queue_writeback_job and
> intel_enabling_capture [Arun]
>
> --v4
> Adding Reviewed-by to patches which were previously reviewd
>
> --v5
> Adding Reviewed-by for patch 3
>
> --v6
> Solving BAT issue
> changes for checkpatch to pass
>
> Suraj Kandpal (3):
> drm/i915: Define WD trancoder for i915
> drm/i915 : Changing intel_connector iterators
> drm/i915: Enabling WD Transcoder
>
> drivers/gpu/drm/i915/Makefile | 1 +
> drivers/gpu/drm/i915/display/intel_acpi.c | 8 +-
> drivers/gpu/drm/i915/display/intel_crtc.c | 6 +
> .../drm/i915/display/intel_crtc_state_dump.c | 1 +
> drivers/gpu/drm/i915/display/intel_ddi.c | 6 +
> drivers/gpu/drm/i915/display/intel_display.c | 68 +-
> drivers/gpu/drm/i915/display/intel_display.h | 18 +-
> .../drm/i915/display/intel_display_debugfs.c | 13 +-
> .../drm/i915/display/intel_display_types.h | 32 +-
> drivers/gpu/drm/i915/display/intel_dpll.c | 6 +
> .../drm/i915/display/intel_modeset_setup.c | 119 ++-
> .../drm/i915/display/intel_modeset_verify.c | 17 +-
> drivers/gpu/drm/i915/display/intel_opregion.c | 3 +
> drivers/gpu/drm/i915/display/intel_wd.c | 694 ++++++++++++++++++
> drivers/gpu/drm/i915/display/intel_wd.h | 48 ++
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/i915_irq.c | 8 +-
> drivers/gpu/drm/i915/i915_pci.c | 7 +-
> drivers/gpu/drm/i915/i915_reg.h | 137 ++++
> 19 files changed, 1137 insertions(+), 56 deletions(-)
> create mode 100644 drivers/gpu/drm/i915/display/intel_wd.c
> create mode 100644 drivers/gpu/drm/i915/display/intel_wd.h
>
--
~Swati Sharma
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback
2022-09-28 12:46 ` Swati Sharma
@ 2022-09-28 13:55 ` Kandpal, Suraj
0 siblings, 0 replies; 30+ messages in thread
From: Kandpal, Suraj @ 2022-09-28 13:55 UTC (permalink / raw)
To: Sharma, Swati2, intel-gfx; +Cc: Nikula, Jani
Hi Swati,
> Hi Suraj,
>
> CI is not green
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shards-
> all.html?testfilter=kms_writeback
>
> 2/4 subtests are passing
> writeback-fb-id subtest can be fixed by asserting EINVAL for i915 we need to
Also we will be sending new patches following this series that sends a fake vblank when
a writeback job on the pipe with wb connector attached instead of failing it atomic check.
So no change in this test will be required
> fix writeback-check-output first On local validation, we were getting CRC
> mismatch however CI results show different issue
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107440v9/shard-tglu-
> 4/igt@kms_writeback@writeback-check-output.html#dmesg-warnings575
> Please check the same if its relevant.
This is still a CRC mismatch which is happening
kms_writeback:1432) igt_kms-DEBUG: display: }
(kms_writeback:1432) igt_debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/0'
(kms_writeback:1432) igt_debugfs-DEBUG: CRC mismatch at index 0: 0xcccb1dc5 != 0x34ab9dc5
(kms_writeback:1432) igt_debugfs-CRITICAL: Test assertion failure function igt_assert_crc_equal, file ../lib/igt_debugfs.c:491:
(kms_writeback:1432) igt_debugfs-CRITICAL: Failed assertion: !mismatch || igt_skip_crc_compare
(kms_writeback:1432) igt_core-INFO: Stack trace:
(kms_writeback:1432) igt_core-INFO: #0 ../lib/igt_core.c:1819 __igt_fail_assert()
(kms_writeback:1432) igt_core-INFO: #1 ../lib/igt_debugfs.c:492 igt_assert_crc_equal()
(kms_writeback:1432) igt_core-INFO: #2 ../tests/kms_writeback.c:343 writeback_sequence()
(kms_writeback:1432) igt_core-INFO: #3 ../tests/kms_writeback.c:360 __igt_unique____real_main480()
(kms_writeback:1432) igt_core-INFO: #4 ../tests/kms_writeback.c:480 main()
(kms_writeback:1432) igt_core-INFO: #5 ../csu/libc-start.c:344 __libc_start_main()
(kms_writeback:1432) igt_core-INFO: #6 [_start+0x2a]
**** END ****
Subtest writeback-check-output: FAIL (0.137s)
which is due to color formats for which the changes are going to be sent in subsequent patch
The dmesg failure that is seen here is because of no vblank event being present when pipe is getting detached and should
Be fixed with the next patch series that also solves the writeback_fb_id issue
Regards,
Suraj Kandpal
>
> On 19-Sep-22 6:35 PM, Kandpal, Suraj wrote:
> > A patch series was floated in the drm mailing list which aimed to
> > change the drm_connector and drm_encoder fields to pointer in the
> > drm_connector_writeback structure, this received a huge pushback from
> > the community but since i915 expects each connector present in the
> > drm_device list to be a intel_connector but drm_writeback framework
> > makes us have a connector which cannot be embedded in an
> > intel_connector structure.
> > [1]
> > https://patchwork.kernel.org/project/dri-devel/patch/20220202081702.22
> > 119-1-suraj.kandpal@intel.com/
> > [2]
> > https://patchwork.kernel.org/project/dri-devel/patch/20220202085429.22
> > 261-6-suraj.kandpal@intel.com/ Since no one had an issue with encoder
> > field being changed into a pointer it was decided to break the
> > connector and encoder pointer changes into two different series.The
> > encoder field changes is currently being worked upon by Abhinav Kumar
> > and the changes have been merged.
> > [3]https://patchwork.kernel.org/project/dri-devel/list/?series=633565
> > Going forward we use a drm_connector which is not embedded in
> > intel_connector.
> > We also create a intel_encoder to avoid changes to many iterators but
> > no intel_connector. We also changed all iterators that
> >
> > ---v2
> > solving BAT issues
> >
> > ---v3
> > -removing unecessary comments from i915_reg.h [Arun] -moving wd_init
> > into its own if condition [Arun] -fixing comment styling and alignment
> > in intel_wd.c [Arun] -removing continue from loop and calling function
> > if condition is met [Arun] -removing useless arguments from
> > intel_queue_writeback_job and intel_enabling_capture [Arun]
> >
> > --v4
> > Adding Reviewed-by to patches which were previously reviewd
> >
> > --v5
> > Adding Reviewed-by for patch 3
> >
> > --v6
> > Solving BAT issue
> > changes for checkpatch to pass
> >
> > Suraj Kandpal (3):
> > drm/i915: Define WD trancoder for i915
> > drm/i915 : Changing intel_connector iterators
> > drm/i915: Enabling WD Transcoder
> >
> > drivers/gpu/drm/i915/Makefile | 1 +
> > drivers/gpu/drm/i915/display/intel_acpi.c | 8 +-
> > drivers/gpu/drm/i915/display/intel_crtc.c | 6 +
> > .../drm/i915/display/intel_crtc_state_dump.c | 1 +
> > drivers/gpu/drm/i915/display/intel_ddi.c | 6 +
> > drivers/gpu/drm/i915/display/intel_display.c | 68 +-
> > drivers/gpu/drm/i915/display/intel_display.h | 18 +-
> > .../drm/i915/display/intel_display_debugfs.c | 13 +-
> > .../drm/i915/display/intel_display_types.h | 32 +-
> > drivers/gpu/drm/i915/display/intel_dpll.c | 6 +
> > .../drm/i915/display/intel_modeset_setup.c | 119 ++-
> > .../drm/i915/display/intel_modeset_verify.c | 17 +-
> > drivers/gpu/drm/i915/display/intel_opregion.c | 3 +
> > drivers/gpu/drm/i915/display/intel_wd.c | 694 ++++++++++++++++++
> > drivers/gpu/drm/i915/display/intel_wd.h | 48 ++
> > drivers/gpu/drm/i915/i915_drv.h | 1 +
> > drivers/gpu/drm/i915/i915_irq.c | 8 +-
> > drivers/gpu/drm/i915/i915_pci.c | 7 +-
> > drivers/gpu/drm/i915/i915_reg.h | 137 ++++
> > 19 files changed, 1137 insertions(+), 56 deletions(-)
> > create mode 100644 drivers/gpu/drm/i915/display/intel_wd.c
> > create mode 100644 drivers/gpu/drm/i915/display/intel_wd.h
> >
>
> --
> ~Swati Sharma
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
` (20 preceding siblings ...)
2022-09-28 12:46 ` Swati Sharma
@ 2022-09-28 15:15 ` Swati Sharma
21 siblings, 0 replies; 30+ messages in thread
From: Swati Sharma @ 2022-09-28 15:15 UTC (permalink / raw)
To: Kandpal, Suraj, intel-gfx; +Cc: jani.nikula
Also, please specify in cover-letter, current
series WB support is for TGL+
since WB is supported from SKL+ as per bspec
https://gfxspecs.intel.com/Predator/Home/Index/4290
On 19-Sep-22 6:35 PM, Kandpal, Suraj wrote:
> A patch series was floated in the drm mailing list which aimed to change
> the drm_connector and drm_encoder fields to pointer in the
> drm_connector_writeback structure, this received a huge pushback from
> the community but since i915 expects each connector present in the
> drm_device list to be a intel_connector but drm_writeback framework
> makes us have a connector which cannot be embedded in an intel_connector
> structure.
> [1]
> https://patchwork.kernel.org/project/dri-devel/patch/20220202081702.22119-1-suraj.kandpal@intel.com/
> [2]
> https://patchwork.kernel.org/project/dri-devel/patch/20220202085429.22261-6-suraj.kandpal@intel.com/
> Since no one had an issue with encoder field being changed into a
> pointer it was decided to break the connector and encoder pointer
> changes into two different series.The encoder field changes is
> currently being worked upon by Abhinav Kumar and the changes have been
> merged.
> [3]https://patchwork.kernel.org/project/dri-devel/list/?series=633565
> Going forward we use a drm_connector which is not embedded in
> intel_connector.
> We also create a intel_encoder to avoid changes to many
> iterators but no intel_connector. We also changed all iterators that
>
> ---v2
> solving BAT issues
>
> ---v3
> -removing unecessary comments from i915_reg.h [Arun]
> -moving wd_init into its own if condition [Arun]
> -fixing comment styling and alignment in intel_wd.c [Arun]
> -removing continue from loop and calling function if condition is met
> [Arun]
> -removing useless arguments from intel_queue_writeback_job and
> intel_enabling_capture [Arun]
>
> --v4
> Adding Reviewed-by to patches which were previously reviewd
>
> --v5
> Adding Reviewed-by for patch 3
>
> --v6
> Solving BAT issue
> changes for checkpatch to pass
>
> Suraj Kandpal (3):
> drm/i915: Define WD trancoder for i915
> drm/i915 : Changing intel_connector iterators
> drm/i915: Enabling WD Transcoder
>
> drivers/gpu/drm/i915/Makefile | 1 +
> drivers/gpu/drm/i915/display/intel_acpi.c | 8 +-
> drivers/gpu/drm/i915/display/intel_crtc.c | 6 +
> .../drm/i915/display/intel_crtc_state_dump.c | 1 +
> drivers/gpu/drm/i915/display/intel_ddi.c | 6 +
> drivers/gpu/drm/i915/display/intel_display.c | 68 +-
> drivers/gpu/drm/i915/display/intel_display.h | 18 +-
> .../drm/i915/display/intel_display_debugfs.c | 13 +-
> .../drm/i915/display/intel_display_types.h | 32 +-
> drivers/gpu/drm/i915/display/intel_dpll.c | 6 +
> .../drm/i915/display/intel_modeset_setup.c | 119 ++-
> .../drm/i915/display/intel_modeset_verify.c | 17 +-
> drivers/gpu/drm/i915/display/intel_opregion.c | 3 +
> drivers/gpu/drm/i915/display/intel_wd.c | 694 ++++++++++++++++++
> drivers/gpu/drm/i915/display/intel_wd.h | 48 ++
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/i915_irq.c | 8 +-
> drivers/gpu/drm/i915/i915_pci.c | 7 +-
> drivers/gpu/drm/i915/i915_reg.h | 137 ++++
> 19 files changed, 1137 insertions(+), 56 deletions(-)
> create mode 100644 drivers/gpu/drm/i915/display/intel_wd.c
> create mode 100644 drivers/gpu/drm/i915/display/intel_wd.h
>
--
~Swati Sharma
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Enabling WD Transcoder
2022-09-19 13:05 ` [Intel-gfx] [PATCH v6 3/3] drm/i915: Enabling WD Transcoder Kandpal, Suraj
@ 2022-09-28 15:23 ` Swati Sharma
0 siblings, 0 replies; 30+ messages in thread
From: Swati Sharma @ 2022-09-28 15:23 UTC (permalink / raw)
To: Kandpal, Suraj, intel-gfx; +Cc: jani.nikula
This patch ideally should have been split into smaller functional
patches. Thoughts @jani nikula?
On 19-Sep-22 6:35 PM, Kandpal, Suraj wrote:
> From: Suraj Kandpal <suraj.kandpal@intel.com>
>
> Adding support for writeback transcoder to start capturing frames using
> interrupt mechanism
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/Makefile | 1 +
> drivers/gpu/drm/i915/display/intel_acpi.c | 1 +
> drivers/gpu/drm/i915/display/intel_crtc.c | 6 +
> .../drm/i915/display/intel_crtc_state_dump.c | 1 +
> drivers/gpu/drm/i915/display/intel_ddi.c | 6 +
> drivers/gpu/drm/i915/display/intel_display.c | 68 +-
> drivers/gpu/drm/i915/display/intel_display.h | 5 +
> .../drm/i915/display/intel_display_debugfs.c | 13 +-
> .../drm/i915/display/intel_display_types.h | 11 +-
> drivers/gpu/drm/i915/display/intel_dpll.c | 6 +
> .../drm/i915/display/intel_modeset_setup.c | 103 ++-
> .../drm/i915/display/intel_modeset_verify.c | 17 +-
> drivers/gpu/drm/i915/display/intel_opregion.c | 3 +
> drivers/gpu/drm/i915/display/intel_wd.c | 694 ++++++++++++++++++
> drivers/gpu/drm/i915/display/intel_wd.h | 48 ++
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/i915_irq.c | 8 +-
> drivers/gpu/drm/i915/i915_pci.c | 7 +-
> 18 files changed, 950 insertions(+), 49 deletions(-)
> create mode 100644 drivers/gpu/drm/i915/display/intel_wd.c
> create mode 100644 drivers/gpu/drm/i915/display/intel_wd.h
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index a26edcdadc21..f34db43cf58d 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -304,6 +304,7 @@ i915-y += \
> display/intel_tv.o \
> display/intel_vdsc.o \
> display/intel_vrr.o \
> + display/intel_wd.o \
> display/vlv_dsi.o \
> display/vlv_dsi_pll.o
>
> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
> index 912fe5c2ffe5..3321ef62fdbd 100644
> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> @@ -248,6 +248,7 @@ static u32 acpi_display_type(struct intel_connector *connector)
> case DRM_MODE_CONNECTOR_LVDS:
> case DRM_MODE_CONNECTOR_eDP:
> case DRM_MODE_CONNECTOR_DSI:
> + case DRM_MODE_CONNECTOR_WRITEBACK:
> display_type = ACPI_DISPLAY_TYPE_INTERNAL_DIGITAL;
> break;
> case DRM_MODE_CONNECTOR_Unknown:
> diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c
> index 6792a9056f46..66d552758720 100644
> --- a/drivers/gpu/drm/i915/display/intel_crtc.c
> +++ b/drivers/gpu/drm/i915/display/intel_crtc.c
> @@ -491,6 +491,9 @@ void intel_pipe_update_start(struct intel_crtc_state *new_crtc_state)
> if (new_crtc_state->do_async_flip)
> return;
>
> + if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
> + return;
> +
> if (intel_crtc_needs_vblank_work(new_crtc_state))
> intel_crtc_vblank_work_init(new_crtc_state);
>
> @@ -638,6 +641,9 @@ void intel_pipe_update_end(struct intel_crtc_state *new_crtc_state)
> if (new_crtc_state->do_async_flip)
> return;
>
> + if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
> + return;
> +
> trace_intel_pipe_update_end(crtc, end_vbl_count, scanline_end);
>
> /*
> diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> index e9212f69c360..8435065f3b7d 100644
> --- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> +++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> @@ -71,6 +71,7 @@ static const char * const output_type_str[] = {
> OUTPUT_TYPE(DSI),
> OUTPUT_TYPE(DDI),
> OUTPUT_TYPE(DP_MST),
> + OUTPUT_TYPE(WD),
> };
>
> #undef OUTPUT_TYPE
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 643832d55c28..ea8e07a957ab 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -1953,6 +1953,12 @@ void intel_ddi_sanitize_encoder_pll_mapping(struct intel_encoder *encoder)
> */
> if (encoder->type == INTEL_OUTPUT_DP_MST)
> return;
> + /*
> + * WD transcoder is a virtual encoder hence sanization
> + * is not required for it
> + */
> + if (encoder->type == INTEL_OUTPUT_WD)
> + return;
>
> if (!encoder->base.crtc && intel_encoder_is_dp(encoder)) {
> u8 pipe_mask;
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index dd008ba8afe3..f34880799ce7 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -115,6 +115,7 @@
> #include "intel_sprite.h"
> #include "intel_tc.h"
> #include "intel_vga.h"
> +#include "intel_wd.h"
> #include "i9xx_plane.h"
> #include "skl_scaler.h"
> #include "skl_universal_plane.h"
> @@ -1514,6 +1515,10 @@ static void intel_encoders_update_prepare(struct intel_atomic_state *state)
> continue;
>
> intel_connector = to_intel_connector(connector);
> + /* intel_connector instance is not created for WD transcoder */
> + if (!intel_connector)
> + continue;
> +
> encoder = intel_connector_primary_encoder(intel_connector);
> if (!encoder->update_prepare)
> continue;
> @@ -1543,6 +1548,10 @@ static void intel_encoders_update_complete(struct intel_atomic_state *state)
> continue;
>
> intel_connector = to_intel_connector(connector);
> + /* intel_connector instance is not created for WD transcoder */
> + if (!intel_connector)
> + continue;
> +
> encoder = intel_connector_primary_encoder(intel_connector);
> if (!encoder->update_complete)
> continue;
> @@ -1553,6 +1562,38 @@ static void intel_encoders_update_complete(struct intel_atomic_state *state)
> }
> }
>
> +static void intel_queue_writeback_job(struct intel_atomic_state *state)
> +{
> + struct drm_connector_state *new_conn_state;
> + struct drm_connector *connector;
> + struct drm_writeback_connector *wb_conn;
> + int i;
> +
> + for_each_new_connector_in_state(&state->base, connector, new_conn_state,
> + i) {
> + if (!new_conn_state->writeback_job)
> + continue;
> +
> + wb_conn = drm_connector_to_writeback(connector);
> + drm_writeback_queue_job(wb_conn, new_conn_state);
> + }
> +}
> +
> +static void intel_enable_writeback_capture(struct intel_atomic_state *state,
> + struct intel_crtc_state *crtc_state)
> +{
> + struct drm_connector_state *new_conn_state;
> + struct drm_connector *connector;
> + int i;
> +
> + for_each_new_connector_in_state(&state->base, connector, new_conn_state,
> + i) {
> + if (connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK)
> + continue;
> + intel_wd_enable_capture(crtc_state, new_conn_state);
> + }
> +}
> +
> static void intel_encoders_pre_pll_enable(struct intel_atomic_state *state,
> struct intel_crtc *crtc)
> {
> @@ -1653,8 +1694,12 @@ static void intel_encoders_post_disable(struct intel_atomic_state *state,
> int i;
>
> for_each_old_connector_in_state(&state->base, conn, old_conn_state, i) {
> - struct intel_encoder *encoder =
> - to_intel_encoder(old_conn_state->best_encoder);
> + struct intel_encoder *encoder;
> +
> + if (conn->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)
> + continue;
> +
> + encoder = to_intel_encoder(old_conn_state->best_encoder);
>
> if (old_conn_state->crtc != &crtc->base)
> continue;
> @@ -1933,7 +1978,8 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
> bdw_set_pipemisc(new_crtc_state);
>
> if (!intel_crtc_is_bigjoiner_slave(new_crtc_state) &&
> - !transcoder_is_dsi(cpu_transcoder))
> + !transcoder_is_dsi(cpu_transcoder) &&
> + !transcoder_is_wd(cpu_transcoder))
> hsw_configure_cpu_transcoder(new_crtc_state);
>
> crtc->active = true;
> @@ -7535,6 +7581,11 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
> }
> }
>
> + for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
> + if ((new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD)))
> + intel_wd_set_vblank_event(state, crtc, new_crtc_state);
> + }
> +
> intel_encoders_update_prepare(state);
>
> intel_dbuf_pre_plane_update(state);
> @@ -7545,6 +7596,13 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
> intel_crtc_enable_flip_done(state, crtc);
> }
>
> + for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
> + if ((new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))) {
> + intel_queue_writeback_job(state);
> + intel_enable_writeback_capture(state, new_crtc_state);
> + }
> + }
> +
> /* Now enable the clocks, plane, pipe, and connectors that we set up. */
> dev_priv->display.funcs.display->commit_modeset_enables(state);
>
> @@ -7899,6 +7957,10 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
> if (!HAS_DISPLAY(dev_priv))
> return;
>
> + /* Initializing WD transcoder */
> + if (DISPLAY_VER(dev_priv) >= 12)
> + intel_wd_init(dev_priv, TRANSCODER_WD_0);
> +
> if (IS_DG2(dev_priv)) {
> intel_ddi_init(dev_priv, PORT_A);
> intel_ddi_init(dev_priv, PORT_B);
> diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
> index 102bf7d47ccc..1ee5e8600809 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.h
> +++ b/drivers/gpu/drm/i915/display/intel_display.h
> @@ -158,6 +158,11 @@ static inline bool transcoder_is_dsi(enum transcoder transcoder)
> return transcoder == TRANSCODER_DSI_A || transcoder == TRANSCODER_DSI_C;
> }
>
> +static inline bool transcoder_is_wd(enum transcoder transcoder)
> +{
> + return transcoder == TRANSCODER_WD_0 || transcoder == TRANSCODER_WD_1;
> +}
> +
> /*
> * Global legacy plane identifier. Valid only for primary/sprite
> * planes on pre-g4x, and only for primary planes on g4x-bdw.
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 7c7253a2541c..b7a0be89302e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -550,7 +550,7 @@ static void intel_hdmi_info(struct seq_file *m,
> static void intel_connector_info(struct seq_file *m,
> struct drm_connector *connector)
> {
> - struct intel_connector *intel_connector = to_intel_connector(connector);
> + struct intel_connector *intel_connector;
> const struct drm_connector_state *conn_state = connector->state;
> struct intel_encoder *encoder =
> to_intel_encoder(conn_state->best_encoder);
> @@ -573,6 +573,8 @@ static void intel_connector_info(struct seq_file *m,
> if (!encoder)
> return;
>
> + intel_connector = to_intel_connector(connector);
> +
> switch (connector->connector_type) {
> case DRM_MODE_CONNECTOR_DisplayPort:
> case DRM_MODE_CONNECTOR_eDP:
> @@ -590,12 +592,15 @@ static void intel_connector_info(struct seq_file *m,
> break;
> }
>
> - seq_puts(m, "\tHDCP version: ");
> - intel_hdcp_info(m, intel_connector);
> + if (intel_connector) {
> + seq_puts(m, "\tHDCP version: ");
> + intel_hdcp_info(m, intel_connector);
> + }
>
> seq_printf(m, "\tmax bpc: %u\n", connector->display_info.bpc);
>
> - intel_panel_info(m, intel_connector);
> + if (intel_connector)
> + intel_panel_info(m, intel_connector);
>
> seq_printf(m, "\tmodes:\n");
> list_for_each_entry(mode, &connector->modes, head)
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index a2d294929a64..aef4427c0bd9 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -44,6 +44,7 @@
> #include <drm/drm_vblank.h>
> #include <drm/drm_vblank_work.h>
> #include <drm/i915_mei_hdcp_interface.h>
> +#include <drm/drm_writeback.h>
> #include <media/cec-notifier.h>
>
> #include "i915_vma.h"
> @@ -1371,6 +1372,11 @@ struct intel_crtc {
> bool cpu_fifo_underrun_disabled;
> bool pch_fifo_underrun_disabled;
>
> + struct {
> + struct drm_pending_vblank_event *e;
> + atomic_t work_busy;
> + wait_queue_head_t wd_wait;
> + } wd;
> /* per-pipe watermark state */
> struct {
> /* watermarks currently being used */
> @@ -1498,7 +1504,6 @@ struct cxsr_latency {
> #define to_intel_atomic_state(x) container_of(x, struct intel_atomic_state, base)
> #define to_intel_crtc(x) container_of(x, struct intel_crtc, base)
> #define to_intel_crtc_state(x) container_of(x, struct intel_crtc_state, uapi)
> -#define to_intel_wb_connector(x) container_of(x, struct intel_wb_connector, base)
> #define to_intel_encoder(x) container_of(x, struct intel_encoder, base)
> #define to_intel_framebuffer(x) container_of(x, struct intel_framebuffer, base)
> #define to_intel_plane(x) container_of(x, struct intel_plane, base)
> @@ -2077,8 +2082,8 @@ intel_connector_list_iter_next(struct drm_connector_list_iter *iter)
> struct drm_connector *connector;
> bool flag = true;
> /*
> - * Skipping connector that are Writeback connector as they will
> - * not be embedded in intel connector
> + * An intel_connector entity is not created for a writeback
> + * connector hence decoupling.
> */
> while (flag) {
> connector = drm_connector_list_iter_next(iter);
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll.c b/drivers/gpu/drm/i915/display/intel_dpll.c
> index b15ba78d64d6..283b403c1ff9 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll.c
> @@ -940,6 +940,9 @@ static int hsw_crtc_compute_clock(struct intel_atomic_state *state,
> intel_get_crtc_new_encoder(state, crtc_state);
> int ret;
>
> + if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_WD))
> + return 0;
> +
> if (DISPLAY_VER(dev_priv) < 11 &&
> intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI))
> return 0;
> @@ -968,6 +971,9 @@ static int hsw_crtc_get_shared_dpll(struct intel_atomic_state *state,
> struct intel_encoder *encoder =
> intel_get_crtc_new_encoder(state, crtc_state);
>
> + if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_WD))
> + return 0;
> +
> if (DISPLAY_VER(dev_priv) < 11 &&
> intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI))
> return 0;
> diff --git a/drivers/gpu/drm/i915/display/intel_modeset_setup.c b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> index e1a90331c230..15792a5dd04c 100644
> --- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> +++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> @@ -24,6 +24,7 @@
> #include "intel_pch_display.h"
> #include "intel_pm.h"
> #include "skl_watermark.h"
> +#include "intel_wd.h"
>
> static void intel_crtc_disable_noatomic(struct intel_crtc *crtc,
> struct drm_modeset_acquire_ctx *ctx)
> @@ -111,17 +112,17 @@ static void intel_crtc_disable_noatomic(struct intel_crtc *crtc,
>
> static void intel_modeset_update_connector_atomic_state(struct drm_i915_private *i915)
> {
> - struct intel_connector *connector;
> + struct drm_connector *connector;
> struct drm_connector_list_iter conn_iter;
>
> drm_connector_list_iter_begin(&i915->drm, &conn_iter);
> - for_each_intel_connector_iter(connector, &conn_iter) {
> - struct drm_connector_state *conn_state = connector->base.state;
> + drm_for_each_connector_iter(connector, &conn_iter) {
> + struct drm_connector_state *conn_state = connector->state;
> struct intel_encoder *encoder =
> - to_intel_encoder(connector->base.encoder);
> + to_intel_encoder(connector->encoder);
>
> if (conn_state->crtc)
> - drm_connector_put(&connector->base);
> + drm_connector_put(connector);
>
> if (encoder) {
> struct intel_crtc *crtc =
> @@ -133,7 +134,7 @@ static void intel_modeset_update_connector_atomic_state(struct drm_i915_private
> conn_state->crtc = &crtc->base;
> conn_state->max_bpc = (crtc_state->pipe_bpp ?: 24) / 3;
>
> - drm_connector_get(&connector->base);
> + drm_connector_get(connector);
> } else {
> conn_state->best_encoder = NULL;
> conn_state->crtc = NULL;
> @@ -433,6 +434,8 @@ static void intel_modeset_readout_hw_state(struct drm_i915_private *i915)
> struct intel_crtc *crtc;
> struct intel_encoder *encoder;
> struct intel_connector *connector;
> + struct drm_connector *_connector;
> + struct drm_encoder *_encoder;
> struct drm_connector_list_iter conn_iter;
> u8 active_pipes = 0;
>
> @@ -509,38 +512,70 @@ static void intel_modeset_readout_hw_state(struct drm_i915_private *i915)
> intel_dpll_readout_hw_state(i915);
>
> drm_connector_list_iter_begin(&i915->drm, &conn_iter);
> - for_each_intel_connector_iter(connector, &conn_iter) {
> - if (connector->get_hw_state(connector)) {
> - struct intel_crtc_state *crtc_state;
> - struct intel_crtc *crtc;
> -
> - connector->base.dpms = DRM_MODE_DPMS_ON;
> -
> - encoder = intel_attached_encoder(connector);
> - connector->base.encoder = &encoder->base;
> -
> - crtc = to_intel_crtc(encoder->base.crtc);
> - crtc_state = crtc ? to_intel_crtc_state(crtc->base.state) : NULL;
> -
> - if (crtc_state && crtc_state->hw.active) {
> - /*
> - * This has to be done during hardware readout
> - * because anything calling .crtc_disable may
> - * rely on the connector_mask being accurate.
> - */
> - crtc_state->uapi.connector_mask |=
> - drm_connector_mask(&connector->base);
> - crtc_state->uapi.encoder_mask |=
> - drm_encoder_mask(&encoder->base);
> + drm_for_each_connector_iter(_connector, &conn_iter) {
> + struct intel_crtc_state *crtc_state;
> + struct intel_crtc *crtc;
> + struct drm_writeback_connector *wb_conn;
> + struct intel_wd *intel_wd;
> +
> + connector = to_intel_connector(_connector);
> + if (!connector) {
> + wb_conn = drm_connector_to_writeback(_connector);
> + intel_wd = wb_conn_to_intel_wd(wb_conn);
> + _encoder = &intel_wd->base.base;
> + _connector->encoder = _encoder;
> + encoder = to_intel_encoder(_encoder);
> + pipe = 0;
> + if (encoder->get_hw_state(encoder, &pipe)) {
> + _connector->dpms = DRM_MODE_DPMS_ON;
> + crtc = to_intel_crtc(_encoder->crtc);
> + crtc_state = crtc ? to_intel_crtc_state(crtc->base.state) : NULL;
> +
> + if (crtc_state && crtc_state->hw.active) {
> + /*
> + * This has to be done during hardware readout
> + * because anything calling .crtc_disable may
> + * rely on the connector_mask being accurate.
> + */
> + crtc_state->uapi.connector_mask |=
> + drm_connector_mask(&connector->base);
> + crtc_state->uapi.encoder_mask |=
> + drm_encoder_mask(&encoder->base);
> + }
> + } else {
> + _connector->dpms = DRM_MODE_DPMS_OFF;
> + _connector->encoder = NULL;
> }
> } else {
> - connector->base.dpms = DRM_MODE_DPMS_OFF;
> - connector->base.encoder = NULL;
> + if (connector->get_hw_state(connector)) {
> + connector->base.dpms = DRM_MODE_DPMS_OFF;
> + encoder = intel_attached_encoder(connector);
> + connector->base.encoder = &encoder->base;
> +
> + crtc = to_intel_crtc(encoder->base.crtc);
> + crtc_state = crtc ? to_intel_crtc_state(crtc->base.state) : NULL;
> +
> + if (crtc_state && crtc_state->hw.active) {
> + /*
> + * This has to be done during hardware readout
> + * because anything calling .crtc_disable may
> + * rely on the connector_mask being accurate.
> + */
> + crtc_state->uapi.connector_mask |=
> + drm_connector_mask(&connector->base);
> + crtc_state->uapi.encoder_mask |=
> + drm_encoder_mask(&encoder->base);
> + }
> + } else {
> + connector->base.dpms = DRM_MODE_DPMS_OFF;
> + connector->base.encoder = NULL;
> + }
> }
> drm_dbg_kms(&i915->drm,
> - "[CONNECTOR:%d:%s] hw state readout: %s\n",
> - connector->base.base.id, connector->base.name,
> - str_enabled_disabled(connector->base.encoder));
> + "[CONNECTOR:%d:%s] hw state readout: %s\n",
> + _connector->base.id, _connector->name,
> + str_enabled_disabled(_connector->encoder));
> +
> }
> drm_connector_list_iter_end(&conn_iter);
>
> diff --git a/drivers/gpu/drm/i915/display/intel_modeset_verify.c b/drivers/gpu/drm/i915/display/intel_modeset_verify.c
> index 0fdcf2e6d57f..80e9840e2e5f 100644
> --- a/drivers/gpu/drm/i915/display/intel_modeset_verify.c
> +++ b/drivers/gpu/drm/i915/display/intel_modeset_verify.c
> @@ -25,11 +25,16 @@
> static void intel_connector_verify_state(struct intel_crtc_state *crtc_state,
> struct drm_connector_state *conn_state)
> {
> - struct intel_connector *connector = to_intel_connector(conn_state->connector);
> - struct drm_i915_private *i915 = to_i915(connector->base.dev);
> + struct drm_connector *_connector = conn_state->connector;
> + struct intel_connector *connector;
> + struct drm_i915_private *i915 = to_i915(_connector->dev);
>
> drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s]\n",
> - connector->base.base.id, connector->base.name);
> + _connector->base.id, _connector->name);
> +
> + connector = to_intel_connector(_connector);
> + if (!connector)
> + return;
>
> if (connector->get_hw_state(connector)) {
> struct intel_encoder *encoder = intel_attached_encoder(connector);
> @@ -119,6 +124,9 @@ verify_encoder_state(struct drm_i915_private *dev_priv, struct intel_atomic_stat
> encoder->base.base.id,
> encoder->base.name);
>
> + if (encoder->type == INTEL_OUTPUT_WD)
> + continue;
> +
> for_each_oldnew_connector_in_state(&state->base, connector, old_conn_state,
> new_conn_state, i) {
> if (old_conn_state->best_encoder == &encoder->base)
> @@ -177,6 +185,9 @@ verify_crtc_state(struct intel_crtc *crtc,
>
> intel_crtc_get_pipe_config(pipe_config);
>
> + if (new_crtc_state->output_types & BIT(INTEL_OUTPUT_WD))
> + return;
> +
> /* we keep both pipes enabled on 830 */
> if (IS_I830(dev_priv) && pipe_config->hw.active)
> pipe_config->hw.active = new_crtc_state->hw.active;
> diff --git a/drivers/gpu/drm/i915/display/intel_opregion.c b/drivers/gpu/drm/i915/display/intel_opregion.c
> index caa07ef34f21..1bcb4b58d992 100644
> --- a/drivers/gpu/drm/i915/display/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/display/intel_opregion.c
> @@ -374,6 +374,9 @@ int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder,
> if (ret)
> return ret;
>
> + if (intel_encoder->type == INTEL_OUTPUT_WD)
> + return 0;
> +
> if (intel_encoder->type == INTEL_OUTPUT_DSI)
> port = 0;
> else
> diff --git a/drivers/gpu/drm/i915/display/intel_wd.c b/drivers/gpu/drm/i915/display/intel_wd.c
> new file mode 100644
> index 000000000000..b904ce5e1dae
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/display/intel_wd.c
> @@ -0,0 +1,694 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2022 Intel Corporation
> + */
> +
> +#include <drm/drm_atomic_helper.h>
> +#include <drm/drm_fourcc.h>
> +
> +#include "intel_atomic.h"
> +#include "intel_connector.h"
> +#include "intel_wd.h"
> +#include "intel_fb_pin.h"
> +#include "intel_de.h"
> +
> +enum {
> + WD_CAPTURE_4_PIX,
> + WD_CAPTURE_2_PIX,
> +} wd_capture_format;
> +
> +struct drm_writeback_job
> +*intel_get_writeback_job_from_queue(struct intel_wd *intel_wd)
> +{
> + struct drm_writeback_job *job;
> + struct drm_i915_private *i915 = to_i915(intel_wd->base.base.dev);
> + struct drm_writeback_connector *wb_conn =
> + &intel_wd->wb_conn;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&wb_conn->job_lock, flags);
> + job = list_first_entry_or_null(&wb_conn->job_queue,
> + struct drm_writeback_job,
> + list_entry);
> + spin_unlock_irqrestore(&wb_conn->job_lock, flags);
> + if (job == NULL) {
> + drm_dbg_kms(&i915->drm, "job queue is empty\n");
> + return NULL;
> + }
> +
> + return job;
> +}
> +
> +static const u32 wd_fmts[] = {
> + DRM_FORMAT_YUV444,
> + DRM_FORMAT_XYUV8888,
> + DRM_FORMAT_XBGR8888,
> + DRM_FORMAT_XRGB8888,
As per spec, RGB is not supported on gen12+
https://gfxspecs.intel.com/Predator/Home/Index/49275
> + DRM_FORMAT_Y410,
> + DRM_FORMAT_YUV422,
> + DRM_FORMAT_XBGR2101010,
> + DRM_FORMAT_RGB565,
And RGB565 got introduced on ADL.
These fmts are not handled properly gen wise.
> +};
> +
> +static int intel_wd_get_format(int pixel_format)
> +{
> + int wd_format = -EINVAL;
> +
> + switch (pixel_format) {
> + case DRM_FORMAT_XBGR8888:
> + case DRM_FORMAT_XRGB8888:
> + case DRM_FORMAT_XBGR2101010:
> + case DRM_FORMAT_XYUV8888:
> + case DRM_FORMAT_YUV444:
> + wd_format = WD_CAPTURE_4_PIX;
> + break;
> + case DRM_FORMAT_YUV422:
> + case DRM_FORMAT_RGB565:
> + wd_format = WD_CAPTURE_2_PIX;
> + break;
> + default:
> + DRM_ERROR("unsupported pixel format %x!\n",
> + pixel_format);
> + }
> +
> + return wd_format;
> +}
> +
> +static int intel_wd_verify_pix_format(int format)
> +{
> + const struct drm_format_info *info = drm_format_info(format);
> + int pix_format = info->format;
> + int i = 0;
> +
> + for (i = 0; i < ARRAY_SIZE(wd_fmts); i++)
> + if (pix_format == wd_fmts[i])
> + return 0;
> +
> + return true;
> +}
> +
> +static u32 intel_wd_get_stride(const struct intel_crtc_state *crtc_state,
> + int format)
> +{
> + const struct drm_format_info *info = drm_format_info(format);
> + int wd_format;
> + int hactive, pixel_size;
> +
> + wd_format = intel_wd_get_format(info->format);
> +
> + switch (wd_format) {
> + case WD_CAPTURE_4_PIX:
> + pixel_size = 4;
> + break;
> + case WD_CAPTURE_2_PIX:
> + pixel_size = 2;
> + break;
> + default:
> + pixel_size = 1;
> + break;
> + }
> +
> + hactive = crtc_state->hw.adjusted_mode.crtc_hdisplay;
> +
> + return DIV_ROUND_UP(hactive * pixel_size, 64);
> +}
> +
> +static int intel_wd_pin_fb(struct intel_wd *intel_wd,
> + struct drm_framebuffer *fb)
> +{
> + const struct i915_gtt_view view = {
> + .type = I915_GTT_VIEW_NORMAL,
> + };
> + struct i915_vma *vma;
> +
> + vma = intel_pin_and_fence_fb_obj(fb, false, &view, false,
> + &intel_wd->flags);
> +
> + if (IS_ERR(vma))
> + return PTR_ERR(vma);
> +
> + intel_wd->vma = vma;
> + return 0;
> +}
> +
> +static void intel_configure_slicing_strategy(struct drm_i915_private *i915,
> + struct intel_wd *intel_wd,
> + u32 *tmp)
> +{
> + *tmp &= ~WD_STRAT_MASK;
> + if (intel_wd->slicing_strategy == 1)
> + *tmp |= WD_SLICING_STRAT_1_1;
> + else if (intel_wd->slicing_strategy == 2)
> + *tmp |= WD_SLICING_STRAT_2_1;
> + else if (intel_wd->slicing_strategy == 3)
> + *tmp |= WD_SLICING_STRAT_4_1;
> + else if (intel_wd->slicing_strategy == 4)
> + *tmp |= WD_SLICING_STRAT_8_1;
> +
> + intel_de_write(i915, WD_STREAMCAP_CTL(intel_wd->trans),
> + *tmp);
> +}
> +
> +static enum drm_mode_status
> +intel_wd_mode_valid(struct drm_connector *connector,
> + struct drm_display_mode *mode)
> +{
> + return MODE_OK;
> +}
> +
> +static int intel_wd_get_modes(struct drm_connector *connector)
> +{
> + return 0;
> +}
> +
> +static void intel_wd_get_config(struct intel_encoder *encoder,
> + struct intel_crtc_state *pipe_config)
> +{
> + struct intel_crtc *intel_crtc =
> + to_intel_crtc(pipe_config->uapi.crtc);
> +
> + if (intel_crtc) {
> + memcpy(pipe_config, intel_crtc->config,
> + sizeof(*pipe_config));
> + pipe_config->output_types |= BIT(INTEL_OUTPUT_WD);
> + }
> +}
> +
> +static int intel_wd_compute_config(struct intel_encoder *encoder,
> + struct intel_crtc_state *pipe_config,
> + struct drm_connector_state *conn_state)
> +{
> + struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
> + struct drm_writeback_job *job;
> +
> + job = intel_get_writeback_job_from_queue(intel_wd);
> + if (job || conn_state->writeback_job) {
> + /*
> + * Saving reference of pipe/crtc for later use if
> + * writeback job is present
> + */
> + intel_wd->wd_crtc = to_intel_crtc(pipe_config->uapi.crtc);
> + return 0;
> + }
> +
> + return 0;
> +}
> +
> +static void intel_wd_get_power_domains(struct intel_encoder *encoder,
> + struct intel_crtc_state *crtc_state)
> +{
> + struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> + struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
> + intel_wakeref_t wakeref;
> +
> + wakeref = intel_display_power_get(i915, encoder->power_domain);
> +
> + intel_wd->io_wakeref[0] = wakeref;
> +}
> +
> +static bool intel_wd_get_hw_state(struct intel_encoder *encoder,
> + enum pipe *pipe)
> +{
> + bool ret = false;
> + struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> + struct intel_wd *intel_wd = enc_to_intel_wd(encoder);
> + struct intel_crtc *wd_crtc = intel_wd->wd_crtc;
> + intel_wakeref_t wakeref;
> + u32 tmp;
> +
> + if (wd_crtc)
> + return false;
> +
> + wakeref = intel_display_power_get_if_enabled(dev_priv,
> + encoder->power_domain);
> +
> + if (!wakeref)
> + goto out;
> +
> + tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
> + ret = tmp & WD_TRANS_ACTIVE;
> + if (ret) {
> + *pipe = wd_crtc->pipe;
> + return true;
> + }
> +
> +out:
> + intel_display_power_put(dev_priv, encoder->power_domain, wakeref);
> + return false;
> +}
> +
> +static int intel_wd_encoder_atomic_check(struct drm_encoder *encoder,
> + struct drm_crtc_state *crtc_st,
> + struct drm_connector_state *conn_st)
> +{
> + /* Check for the format and buffers and property validity */
> + struct drm_framebuffer *fb;
> + struct drm_writeback_job *job = conn_st->writeback_job;
> + struct drm_i915_private *i915 = to_i915(encoder->dev);
> + const struct drm_display_mode *mode = &crtc_st->mode;
> + int ret;
> +
> + if (!job) {
> + drm_dbg_kms(&i915->drm, "No writeback job created returning\n");
> + return -EINVAL;
> + }
> +
> + fb = job->fb;
> + if (!fb) {
> + drm_dbg_kms(&i915->drm, "Invalid framebuffer\n");
> + return -EINVAL;
> + }
> +
> + if (fb->width != mode->hdisplay || fb->height != mode->vdisplay) {
> + drm_dbg_kms(&i915->drm, "Invalid framebuffer size %ux%u\n",
> + fb->width, fb->height);
> + return -EINVAL;
> + }
> +
> + ret = intel_wd_verify_pix_format(fb->format->format);
> + if (ret) {
> + drm_dbg_kms(&i915->drm, "Unsupported framebuffer format %08x\n",
> + fb->format->format);
> + return -EINVAL;
> + }
> +
> + return 0;
> +}
> +
> +static const struct drm_encoder_helper_funcs wd_encoder_helper_funcs = {
> + .atomic_check = intel_wd_encoder_atomic_check,
> +};
> +
> +static void intel_wd_connector_destroy(struct drm_connector *connector)
> +{
> + drm_connector_cleanup(connector);
> +}
> +
> +static enum drm_connector_status
> +intel_wd_connector_detect(struct drm_connector *connector, bool force)
> +{
> + return connector_status_connected;
> +}
> +
> +static const struct drm_connector_funcs wb_connector_funcs = {
> + .detect = intel_wd_connector_detect,
> + .reset = drm_atomic_helper_connector_reset,
> + .destroy = intel_wd_connector_destroy,
> + .fill_modes = drm_helper_probe_single_connector_modes,
> + .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
> + .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
> +};
> +
> +static const struct drm_connector_helper_funcs wb_connector_helper_funcs = {
> + .get_modes = intel_wd_get_modes,
> + .mode_valid = intel_wd_mode_valid,
> +};
> +
> +static const struct drm_encoder_funcs drm_writeback_encoder_funcs = {
> + .destroy = drm_encoder_cleanup,
> +};
> +
> +static bool intel_fastset_dis(struct intel_encoder *encoder,
> + struct intel_crtc_state *pipe_config)
> +{
> + return false;
> +}
> +
> +static void intel_wd_connector_init(struct intel_wd *intel_wd)
> +{
> + drm_atomic_helper_connector_reset(&intel_wd->wb_conn.base);
> +}
> +
> +static void intel_wd_disable_capture(struct intel_wd *intel_wd)
> +{
> + struct drm_i915_private *dev_priv = to_i915(intel_wd->base.base.dev);
> + u32 tmp;
> +
> + intel_de_write_fw(dev_priv, WD_IMR(intel_wd->trans), 0xFF);
> + tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
> + tmp &= WD_TRANS_DISABLE;
> + intel_de_write(dev_priv, PIPECONF(intel_wd->trans), tmp);
> + tmp = intel_de_read(dev_priv, WD_TRANS_FUNC_CTL(intel_wd->trans));
> +}
> +
> +void intel_wd_init(struct drm_i915_private *i915, enum transcoder trans)
> +{
> + struct intel_wd *intel_wd;
> + struct intel_encoder *encoder;
> + struct drm_writeback_connector *wb_conn;
> + int n_formats = ARRAY_SIZE(wd_fmts);
> + struct drm_encoder *drm_enc;
> + int err, ret;
> +
> + intel_wd = kzalloc(sizeof(*intel_wd), GFP_KERNEL);
> + if (!intel_wd)
> + return;
> +
> + intel_wd_connector_init(intel_wd);
> + encoder = &intel_wd->base;
> + drm_enc = &encoder->base;
> + wb_conn = &intel_wd->wb_conn;
> + intel_wd->trans = trans;
> + intel_wd->triggered_cap_mode = 1;
> + intel_wd->frame_num = 1;
> + intel_wd->slicing_strategy = 1;
> + encoder->get_config = intel_wd_get_config;
> + encoder->compute_config = intel_wd_compute_config;
> + encoder->get_hw_state = intel_wd_get_hw_state;
> + encoder->type = INTEL_OUTPUT_WD;
> + encoder->cloneable = 0;
> + encoder->pipe_mask = ~0;
> + encoder->power_domain = POWER_DOMAIN_TRANSCODER_B;
> + encoder->get_power_domains = intel_wd_get_power_domains;
> + encoder->initial_fastset_check = intel_fastset_dis;
> +
> + drm_encoder_helper_add(drm_enc,
> + &wd_encoder_helper_funcs);
> +
> + drm_enc->possible_crtcs = ~0;
> + ret = drm_encoder_init(&i915->drm, drm_enc,
> + &drm_writeback_encoder_funcs,
> + DRM_MODE_ENCODER_VIRTUAL, NULL);
> +
> + if (ret) {
> + drm_dbg_kms(&i915->drm,
> + "Writeback drm_encoder init Failed: %d\n",
> + ret);
> + goto cleanup;
> + }
> +
> + err = drm_writeback_connector_init_with_encoder(&i915->drm,
> + wb_conn, drm_enc, &wb_connector_funcs,
> + wd_fmts, n_formats);
> +
> + if (err != 0) {
> + drm_dbg_kms(&i915->drm,
> + "drm_writeback_connector_init: Failed: %d\n",
> + err);
> + goto cleanup;
> + }
> +
> + wb_conn->base.encoder = drm_enc;
> + drm_connector_helper_add(&wb_conn->base, &wb_connector_helper_funcs);
> + wb_conn->base.status = connector_status_connected;
> + return;
> +
> +cleanup:
> + kfree(intel_wd);
> + return;
> +}
> +
> +static void intel_wd_writeback_complete(struct intel_wd *intel_wd,
> + struct drm_writeback_job *job,
> + int status)
> +{
> + struct drm_writeback_connector *wb_conn =
> + &intel_wd->wb_conn;
> + drm_writeback_signal_completion(wb_conn, status);
> +}
> +
> +static int intel_wd_setup_transcoder(struct intel_wd *intel_wd,
> + struct intel_crtc_state *pipe_config,
> + struct drm_connector_state *conn_state,
> + struct drm_writeback_job *job)
> +{
> + struct intel_crtc *intel_crtc = to_intel_crtc(pipe_config->uapi.crtc);
> + enum pipe pipe = intel_crtc->pipe;
> + struct drm_framebuffer *fb;
> + struct drm_i915_private *dev_priv = to_i915(intel_crtc->base.dev);
> + struct drm_gem_object *wd_fb_obj;
> + int ret;
> + u32 stride, tmp;
> + u16 hactive, vactive;
> +
> + fb = job->fb;
> + wd_fb_obj = fb->obj[0];
> + if (!wd_fb_obj) {
> + drm_dbg_kms(&dev_priv->drm, "No framebuffer gem object created\n");
> + return -EINVAL;
> + }
> +
> + ret = intel_wd_pin_fb(intel_wd, fb);
> + drm_WARN_ON(&dev_priv->drm, ret != 0);
> + /* Write stride and surface registers in that particular order */
> + stride = intel_wd_get_stride(pipe_config, fb->format->format);
> +
> + tmp = intel_de_read(dev_priv, WD_STRIDE(intel_wd->trans));
> + tmp &= ~WD_STRIDE_MASK;
> + tmp |= (stride << WD_STRIDE_SHIFT);
> +
> + intel_de_write(dev_priv, WD_STRIDE(intel_wd->trans), tmp);
> +
> + tmp = intel_de_read(dev_priv, WD_SURF(intel_wd->trans));
> +
> + intel_de_write(dev_priv, WD_SURF(intel_wd->trans),
> + i915_ggtt_offset(intel_wd->vma));
> +
> + tmp = intel_de_read_fw(dev_priv, WD_IIR(intel_wd->trans));
> + intel_de_write_fw(dev_priv, WD_IIR(intel_wd->trans), tmp);
> +
> + tmp = ~(WD_GTT_FAULT_INT | WD_WRITE_COMPLETE_INT | WD_FRAME_COMPLETE_INT |
> + WD_VBLANK_INT | WD_OVERRUN_INT | WD_CAPTURING_INT);
> + intel_de_write_fw(dev_priv, WD_IMR(intel_wd->trans), tmp);
> +
> + if (intel_wd->stream_cap) {
> + tmp = intel_de_read(dev_priv,
> + WD_STREAMCAP_CTL(intel_wd->trans));
> + tmp |= WD_STREAM_CAP_MODE_EN;
> + intel_configure_slicing_strategy(dev_priv, intel_wd, &tmp);
> + }
> +
> + hactive = pipe_config->uapi.mode.hdisplay;
> + vactive = pipe_config->uapi.mode.vdisplay;
> + tmp = intel_de_read(dev_priv, HTOTAL(intel_wd->trans));
> + tmp = intel_de_read(dev_priv, VTOTAL(intel_wd->trans));
> +
> + /* minimum hactive as per bspec: 64 pixels */
> + if (hactive < 64)
> + drm_err(&dev_priv->drm, "hactive is less then 64 pixels\n");
> +
> + intel_de_write(dev_priv, HTOTAL(intel_wd->trans), hactive - 1);
> + intel_de_write(dev_priv, VTOTAL(intel_wd->trans), vactive - 1);
> +
> + tmp = intel_de_read(dev_priv, WD_TRANS_FUNC_CTL(intel_wd->trans));
> + /* select pixel format */
> + tmp &= ~WD_PIX_FMT_MASK;
> +
> + switch (fb->format->format) {
> + default:
> + fallthrough;
> + case DRM_FORMAT_YUYV:
> + tmp |= WD_PIX_FMT_YUYV;
> + break;
> + case DRM_FORMAT_XYUV8888:
> + tmp |= WD_PIX_FMT_XYUV8888;
> + break;
> + case DRM_FORMAT_XBGR8888:
> + case DRM_FORMAT_XRGB8888:
> + tmp |= WD_PIX_FMT_XBGR8888;
> + break;
> + case DRM_FORMAT_Y410:
> + tmp |= WD_PIX_FMT_Y410;
> + break;
> + case DRM_FORMAT_YUV422:
> + tmp |= WD_PIX_FMT_YUV422;
> + break;
> + case DRM_FORMAT_XBGR2101010:
> + tmp |= WD_PIX_FMT_XBGR2101010;
> + break;
> + case DRM_FORMAT_RGB565:
> + tmp |= WD_PIX_FMT_RGB565;
> + break;
> + }
> +
> + if (intel_wd->triggered_cap_mode)
> + tmp |= WD_TRIGGERED_CAP_MODE_ENABLE;
> +
> + if (intel_wd->stream_cap)
> + tmp |= WD_CTL_POINTER_DTDH;
> +
> + /* select input pipe */
> + tmp &= ~WD_INPUT_SELECT_MASK;
> + switch (pipe) {
> + default:
> + fallthrough;
> + case PIPE_A:
> + tmp |= WD_INPUT_PIPE_A;
> + break;
> + case PIPE_B:
> + tmp |= WD_INPUT_PIPE_B;
> + break;
> + case PIPE_C:
> + tmp |= WD_INPUT_PIPE_C;
> + break;
> + case PIPE_D:
> + tmp |= WD_INPUT_PIPE_D;
> + break;
> + }
> +
> + /* enable DDI buffer */
> + if (!(tmp & TRANS_WD_FUNC_ENABLE))
> + tmp |= TRANS_WD_FUNC_ENABLE;
> +
> + intel_de_write(dev_priv, WD_TRANS_FUNC_CTL(intel_wd->trans), tmp);
> +
> + tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
> + ret = tmp & WD_TRANS_ACTIVE;
> + if (!ret) {
> + /* enable the transcoder */
> + tmp = intel_de_read(dev_priv, PIPECONF(intel_wd->trans));
> + tmp |= WD_TRANS_ENABLE;
> + intel_de_write(dev_priv, PIPECONF(intel_wd->trans), tmp);
> +
> + /* wait for transcoder to be enabled */
> + if (intel_de_wait_for_set(dev_priv, PIPECONF(intel_wd->trans),
> + WD_TRANS_ACTIVE, 10))
> + drm_err(&dev_priv->drm, "WD transcoder could not be enabled\n");
> + }
> +
> + return 0;
> +}
> +
> +static int intel_wd_capture(struct intel_wd *intel_wd,
> + struct intel_crtc_state *pipe_config,
> + struct drm_connector_state *conn_state,
> + struct drm_writeback_job *job)
> +{
> + u32 tmp;
> + struct drm_i915_private *i915 = to_i915(intel_wd->base.base.dev);
> + int ret = 0, status = 0;
> + struct intel_crtc *wd_crtc = intel_wd->wd_crtc;
> + unsigned long flags;
> +
> + if (!job->out_fence)
> + drm_dbg_kms(&i915->drm, "Not able to get out_fence for job\n");
> +
> + ret = intel_wd_setup_transcoder(intel_wd, pipe_config,
> + conn_state, job);
> +
> + if (ret < 0) {
> + drm_dbg_kms(&i915->drm,
> + "WD transcoder setup not completed aborting capture\n");
> + return -1;
> + }
> +
> + if (!wd_crtc) {
> + drm_err(&i915->drm, "CRTC not attached\n");
> + return -1;
> + }
> +
> + tmp = intel_de_read_fw(i915, WD_TRANS_FUNC_CTL(intel_wd->trans));
> + tmp |= START_TRIGGER_FRAME;
> + tmp &= ~WD_FRAME_NUMBER_MASK;
> + tmp |= intel_wd->frame_num;
> + intel_de_write_fw(i915, WD_TRANS_FUNC_CTL(intel_wd->trans), tmp);
> +
> + if (!intel_de_wait_for_set(i915, WD_IIR(intel_wd->trans),
> + WD_FRAME_COMPLETE_INT, 100)){
> + drm_dbg_kms(&i915->drm, "frame captured\n");
> + status = 0;
> + } else {
> + drm_dbg_kms(&i915->drm, "frame not captured triggering stop frame\n");
> + tmp = intel_de_read(i915, WD_TRANS_FUNC_CTL(intel_wd->trans));
> + tmp |= STOP_TRIGGER_FRAME;
> + intel_de_write(i915, WD_TRANS_FUNC_CTL(intel_wd->trans), tmp);
> + status = -1;
> + }
> +
> + intel_wd_writeback_complete(intel_wd, job, status);
> + if (wd_crtc->wd.e) {
> + spin_lock_irqsave(&i915->drm.event_lock, flags);
> + drm_dbg_kms(&i915->drm, "send %p\n", wd_crtc->wd.e);
> + drm_crtc_send_vblank_event(&wd_crtc->base,
> + wd_crtc->wd.e);
> + spin_unlock_irqrestore(&i915->drm.event_lock, flags);
> + wd_crtc->wd.e = NULL;
> + } else {
> + drm_err(&i915->drm, "Event NULL! %p, %p\n", &i915->drm,
> + wd_crtc);
> + }
> + if (!intel_get_writeback_job_from_queue(intel_wd))
> + intel_wd_disable_capture(intel_wd);
> + return 0;
> +}
> +
> +void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
> + struct drm_connector_state *conn_state)
> +{
> + struct drm_i915_private *i915 =
> + to_i915(conn_state->connector->dev);
> + struct drm_writeback_connector *wb_conn =
> + drm_connector_to_writeback(conn_state->connector);
> + struct intel_wd *intel_wd = wb_conn_to_intel_wd(wb_conn);
> + struct drm_writeback_job *job;
> +
> + job = intel_get_writeback_job_from_queue(intel_wd);
> + if (!job) {
> + drm_dbg_kms(&i915->drm,
> + "job queue is empty not capturing any frame\n");
> + return;
> + }
> +
> + intel_wd_capture(intel_wd, pipe_config,
> + conn_state, job);
> + intel_wd->frame_num += 1;
> +}
> +
> +void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *intel_crtc,
> + struct intel_crtc_state *intel_crtc_state)
> +{
> + struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev);
> + struct drm_crtc_state *crtc_state = &intel_crtc_state->uapi;
> + struct intel_encoder *encoder;
> + struct intel_wd *intel_wd;
> + struct drm_connector_state *conn_state;
> + struct drm_connector *connector;
> + int i;
> +
> + for_each_intel_encoder(&i915->drm, encoder) {
> + if (encoder->type != INTEL_OUTPUT_WD)
> + continue;
> +
> + intel_wd = enc_to_intel_wd(encoder);
> + if (!intel_wd->wd_crtc)
> + return;
> + }
> +
> + if (intel_wd && intel_crtc == intel_wd->wd_crtc) {
> + for_each_new_connector_in_state(&state->base, connector, conn_state,
> + i) {
> + if (!conn_state->writeback_job)
> + continue;
> +
> + intel_crtc->wd.e = crtc_state->event;
> + crtc_state->event = NULL;
> + }
> + }
> +}
> +
> +void intel_wd_handle_isr(struct drm_i915_private *i915)
> +{
> + u32 iir_value = 0;
> + struct intel_encoder *encoder;
> + struct intel_wd *intel_wd;
> +
> + iir_value = intel_de_read(i915, WD_IIR(TRANSCODER_WD_0));
> +
> + for_each_intel_encoder(&i915->drm, encoder) {
> +
> + if (encoder->type != INTEL_OUTPUT_WD)
> + continue;
> +
> + intel_wd = enc_to_intel_wd(encoder);
> + if (!intel_wd->wd_crtc) {
> + drm_err(&i915->drm, "NO CRTC attached with WD\n");
> + goto clear_iir;
> + }
> + }
> +
> + if (iir_value & WD_FRAME_COMPLETE_INT)
> + return;
> +
> +clear_iir:
> + intel_de_write(i915, WD_IIR(TRANSCODER_WD_0), iir_value);
> +}
> diff --git a/drivers/gpu/drm/i915/display/intel_wd.h b/drivers/gpu/drm/i915/display/intel_wd.h
> new file mode 100644
> index 000000000000..0fcd1a746593
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/display/intel_wd.h
> @@ -0,0 +1,48 @@
> +/* SPDX-License-Identifier: MIT*/
> +/*
> + * Copyright © 2022 Intel Corporation
> + */
> +
> +#ifndef _INTEL_WD_H
> +#define _INTEL_WD_H
> +
> +#include <drm/drm_crtc.h>
> +
> +#include "intel_display_types.h"
> +
> +#define I915_MAX_WD_TANSCODERS 2
> +
> +struct intel_wd {
> + struct intel_encoder base;
> + struct drm_writeback_connector wb_conn;
> + struct intel_crtc *wd_crtc;
> + intel_wakeref_t io_wakeref[I915_MAX_WD_TANSCODERS];
> + enum transcoder trans;
> + struct i915_vma *vma;
> + unsigned long flags;
> + struct drm_writeback_job *job;
> + int triggered_cap_mode;
> + int frame_num;
> + bool stream_cap;
> + bool start_capture;
> + int slicing_strategy;
> +};
> +
> +static inline struct intel_wd *enc_to_intel_wd(struct intel_encoder *encoder)
> +{
> + return container_of(&encoder->base, struct intel_wd, base.base);
> +}
> +
> +static inline struct intel_wd *wb_conn_to_intel_wd(struct drm_writeback_connector *wb_conn)
> +{
> + return container_of(wb_conn, struct intel_wd, wb_conn);
> +}
> +
> +void intel_wd_init(struct drm_i915_private *dev_priv, enum transcoder trans);
> +void intel_wd_enable_capture(struct intel_crtc_state *pipe_config,
> + struct drm_connector_state *conn_state);
> +void intel_wd_handle_isr(struct drm_i915_private *dev_priv);
> +void intel_wd_set_vblank_event(struct intel_atomic_state *state, struct intel_crtc *crtc,
> + struct intel_crtc_state *crtc_state);
> +struct drm_writeback_job *intel_get_writeback_job_from_queue(struct intel_wd *intel_wd);
> +#endif/* _INTEL_WD_H */
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 9f9372931fd2..2b977bd4d9d9 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -34,6 +34,7 @@
>
> #include <linux/pm_qos.h>
>
> +#include <drm/drm_writeback.h>
> #include <drm/ttm/ttm_device.h>
>
> #include "display/intel_display.h"
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 86a42d9e8041..ee0255d9eb64 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -42,6 +42,7 @@
> #include "display/intel_hotplug.h"
> #include "display/intel_lpe_audio.h"
> #include "display/intel_psr.h"
> +#include "display/intel_wd.h"
>
> #include "gt/intel_breadcrumbs.h"
> #include "gt/intel_gt.h"
> @@ -2342,6 +2343,11 @@ gen8_de_misc_irq_handler(struct drm_i915_private *dev_priv, u32 iir)
> found = true;
> }
>
> + if (iir & GEN8_DE_MISC_WD0) {
> + intel_wd_handle_isr(dev_priv);
> + found = true;
> + }
> +
> if (iir & GEN8_DE_EDP_PSR) {
> struct intel_encoder *encoder;
> u32 psr_iir;
> @@ -3767,7 +3773,7 @@ static void gen8_de_irq_postinstall(struct drm_i915_private *dev_priv)
> u32 de_pipe_enables;
> u32 de_port_masked = gen8_de_port_aux_mask(dev_priv);
> u32 de_port_enables;
> - u32 de_misc_masked = GEN8_DE_EDP_PSR;
> + u32 de_misc_masked = GEN8_DE_EDP_PSR | GEN8_DE_MISC_WD0;
> u32 trans_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
> BIT(TRANSCODER_C) | BIT(TRANSCODER_D);
> enum pipe pipe;
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 77e7df21f539..66bb5f53584b 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -868,7 +868,8 @@ static const struct intel_device_info jsl_info = {
> .__runtime.pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D), \
> .__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) | \
> BIT(TRANSCODER_C) | BIT(TRANSCODER_D) | \
> - BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1), \
> + BIT(TRANSCODER_DSI_0) | BIT(TRANSCODER_DSI_1) | \
> + BIT(TRANSCODER_WD_0), \
> .display.pipe_offsets = { \
> [TRANSCODER_A] = PIPE_A_OFFSET, \
> [TRANSCODER_B] = PIPE_B_OFFSET, \
> @@ -876,6 +877,8 @@ static const struct intel_device_info jsl_info = {
> [TRANSCODER_D] = PIPE_D_OFFSET, \
> [TRANSCODER_DSI_0] = PIPE_DSI0_OFFSET, \
> [TRANSCODER_DSI_1] = PIPE_DSI1_OFFSET, \
> + [TRANSCODER_WD_0] = PIPE_WD0_OFFSET, \
> + [TRANSCODER_WD_1] = PIPE_WD1_OFFSET, \
> }, \
> .display.trans_offsets = { \
> [TRANSCODER_A] = TRANSCODER_A_OFFSET, \
> @@ -884,6 +887,8 @@ static const struct intel_device_info jsl_info = {
> [TRANSCODER_D] = TRANSCODER_D_OFFSET, \
> [TRANSCODER_DSI_0] = TRANSCODER_DSI0_OFFSET, \
> [TRANSCODER_DSI_1] = TRANSCODER_DSI1_OFFSET, \
> + [TRANSCODER_WD_0] = TRANSCODER_WD0_OFFSET, \
> + [TRANSCODER_WD_1] = TRANSCODER_WD1_OFFSET, \
> }, \
> TGL_CURSOR_OFFSETS, \
> .has_global_mocs = 1, \
--
~Swati Sharma
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [Intel-gfx] [PATCH v6 1/3] drm/i915: Define WD trancoder for i915
2022-09-19 13:05 ` [Intel-gfx] [PATCH v6 1/3] drm/i915: Define WD trancoder for i915 Kandpal, Suraj
@ 2022-10-05 9:07 ` Jani Nikula
0 siblings, 0 replies; 30+ messages in thread
From: Jani Nikula @ 2022-10-05 9:07 UTC (permalink / raw)
To: Kandpal, Suraj, intel-gfx
On Mon, 19 Sep 2022, "Kandpal, Suraj" <suraj.kandpal@intel.com> wrote:
> From: Suraj Kandpal <suraj.kandpal@intel.com>
>
> Adding WD Types, WD transcoder to enum list and WD Transcoder offsets.
> Adding i915 register definitions related to WD transcoder
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.h | 6 +
> .../drm/i915/display/intel_display_types.h | 1 +
> drivers/gpu/drm/i915/i915_reg.h | 137 ++++++++++++++++++
> 3 files changed, 144 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
> index 884e8e67b17c..a1ed9c82e2ed 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.h
> +++ b/drivers/gpu/drm/i915/display/intel_display.h
> @@ -120,6 +120,8 @@ enum transcoder {
> TRANSCODER_DSI_1,
> TRANSCODER_DSI_A = TRANSCODER_DSI_0, /* legacy DSI */
> TRANSCODER_DSI_C = TRANSCODER_DSI_1, /* legacy DSI */
> + TRANSCODER_WD_0,
> + TRANSCODER_WD_1,
>
> I915_MAX_TRANSCODERS
> };
> @@ -141,6 +143,10 @@ static inline const char *transcoder_name(enum transcoder transcoder)
> return "DSI A";
> case TRANSCODER_DSI_C:
> return "DSI C";
> + case TRANSCODER_WD_0:
> + return "WD 0";
> + case TRANSCODER_WD_1:
> + return "WD 1";
> default:
> return "<invalid>";
> }
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index 298d00a11f47..633cacd79074 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -79,6 +79,7 @@ enum intel_output_type {
> INTEL_OUTPUT_DSI = 9,
> INTEL_OUTPUT_DDI = 10,
> INTEL_OUTPUT_DP_MST = 11,
> + INTEL_OUTPUT_WD = 12,
> };
>
> enum hdmi_force_audio {
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 78038f48ddf2..e8d5ee131838 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -2011,6 +2011,8 @@
> #define TRANSCODER_EDP_OFFSET 0x6f000
> #define TRANSCODER_DSI0_OFFSET 0x6b000
> #define TRANSCODER_DSI1_OFFSET 0x6b800
> +#define TRANSCODER_WD0_OFFSET 0x6e000
> +#define TRANSCODER_WD1_OFFSET 0x6e800
>
> #define HTOTAL(trans) _MMIO_TRANS2(trans, _HTOTAL_A)
> #define HBLANK(trans) _MMIO_TRANS2(trans, _HBLANK_A)
> @@ -3701,6 +3703,9 @@
> #define PIPE_DSI0_OFFSET 0x7b000
> #define PIPE_DSI1_OFFSET 0x7b800
>
> +#define PIPE_WD0_OFFSET 0x7e000
> +#define PIPE_WD1_OFFSET 0x7d000
> +
> #define PIPECONF(pipe) _MMIO_PIPE2(pipe, _PIPEACONF)
> #define PIPEDSL(pipe) _MMIO_PIPE2(pipe, _PIPEADSL)
> #define PIPEFRAME(pipe) _MMIO_PIPE2(pipe, _PIPEAFRAMEHIGH)
> @@ -4365,6 +4370,10 @@
> #define _PIPEDSI0CONF 0x7b008
> #define _PIPEDSI1CONF 0x7b808
>
> +/* WD 0 and 1 */
> +#define _PIPEWD0CONF 0x7e008
> +#define _PIPEWD1CONF 0x7d008
> +
> /* Sprite A control */
> #define _DVSACNTR 0x72180
> #define DVS_ENABLE REG_BIT(31)
> @@ -5590,6 +5599,7 @@
> #define GEN8_DE_MISC_IER _MMIO(0x4446c)
> #define GEN8_DE_MISC_GSE (1 << 27)
> #define GEN8_DE_EDP_PSR (1 << 19)
> +#define GEN8_DE_MISC_WD0 (1 << 23)
>
> #define GEN8_PCU_ISR _MMIO(0x444e0)
> #define GEN8_PCU_IMR _MMIO(0x444e4)
> @@ -8334,6 +8344,133 @@ enum skl_power_gate {
> #define DSB_ENABLE (1 << 31)
> #define DSB_STATUS (1 << 0)
>
We're in the process of splitting i915_regs.h to smaller files, by
functionality. Most of the below should probably be in
display/intel_wd_regs.h.
(Also, the difference between writeback/wb and wd is really
confusing. Always looks like a typo. Should we go with
intel_writeback.[ch] after all, as well as intel_writeback_regs.h?)
> +#define TGL_ROOT_DEVICE_ID 0x9A00
> +#define TGL_ROOT_DEVICE_MASK 0xFF00
> +#define TGL_ROOT_DEVICE_SKU_MASK 0xF
> +#define TGL_ROOT_DEVICE_SKU_ULX 0x2
> +#define TGL_ROOT_DEVICE_SKU_ULT 0x4
> +
> +/* Gen12 WD */
> +#define _MMIO_WD(tc, wd0, wd1) _MMIO_TRANS((tc) - TRANSCODER_WD_0, \
> + wd0, wd1)
> +
> +#define WD_TRANS_ENABLE (1 << 31)
> +#define WD_TRANS_DISABLE 0
> +#define WD_TRANS_ACTIVE (1 << 30)
> +
> +/* WD transcoder control */
> +#define _WD_TRANS_FUNC_CTL_0 0x6e400
> +#define _WD_TRANS_FUNC_CTL_1 0x6ec00
> +#define WD_TRANS_FUNC_CTL(tc) _MMIO_WD(tc,\
> + _WD_TRANS_FUNC_CTL_0,\
> + _WD_TRANS_FUNC_CTL_1)
> +
> +#define TRANS_WD_FUNC_ENABLE (1 << 31)
> +#define WD_TRIGGERED_CAP_MODE_ENABLE (1 << 30)
> +#define START_TRIGGER_FRAME (1 << 29)
> +#define STOP_TRIGGER_FRAME (1 << 28)
> +#define WD_CTL_POINTER_ETEH (0 << 18)
> +#define WD_CTL_POINTER_ETDH (1 << 18)
> +#define WD_CTL_POINTER_DTDH (2 << 18)
> +#define WD_INPUT_SELECT_MASK (7 << 12)
> +#define WD_INPUT_PIPE_A (0 << 12)
> +#define WD_INPUT_PIPE_B (5 << 12)
> +#define WD_INPUT_PIPE_C (6 << 12)
> +#define WD_INPUT_PIPE_D (7 << 12)
> +
> +#define WD_PIX_FMT_MASK (0x3 << 20)
> +#define WD_PIX_FMT_YUYV (0x1 << 20)
> +#define WD_PIX_FMT_XYUV8888 (0x2 << 20)
> +#define WD_PIX_FMT_XBGR8888 (0x3 << 20)
> +#define WD_PIX_FMT_Y410 (0x4 << 20)
> +#define WD_PIX_FMT_YUV422 (0x5 << 20)
> +#define WD_PIX_FMT_XBGR2101010 (0x6 << 20)
> +#define WD_PIX_FMT_RGB565 (0x7 << 20)
> +
> +#define WD_FRAME_NUMBER_MASK 15
> +
> +#define _WD_STRIDE_0 0x6e510
> +#define _WD_STRIDE_1 0x6ed10
> +#define WD_STRIDE(tc) _MMIO_WD(tc,\
> + _WD_STRIDE_0,\
> + _WD_STRIDE_1)
> +#define WD_STRIDE_SHIFT 6
> +#define WD_STRIDE_MASK (0x3ff << WD_STRIDE_SHIFT)
> +
> +#define _WD_STREAMCAP_CTL0 0x6e590
> +#define _WD_STREAMCAP_CTL1 0x6ed90
> +#define WD_STREAMCAP_CTL(tc) _MMIO_WD(tc,\
> + _WD_STREAMCAP_CTL0,\
> + _WD_STREAMCAP_CTL1)
> +
> +#define WD_STREAM_CAP_MODE_EN (1 << 31)
> +#define WD_STRAT_MASK (3 << 24)
> +#define WD_SLICING_STRAT_1_1 (0 << 24)
> +#define WD_SLICING_STRAT_2_1 (1 << 24)
> +#define WD_SLICING_STRAT_4_1 (2 << 24)
> +#define WD_SLICING_STRAT_8_1 (3 << 24)
> +#define WD_STREAM_OVERRUN_STATUS 1
> +
> +#define _WD_SURF_0 0x6e514
> +#define _WD_SURF_1 0x6ed14
> +#define WD_SURF(tc) _MMIO_WD(tc,\
> + _WD_SURF_0,\
> + _WD_SURF_1)
> +
> +#define _WD_IMR_0 0x6e560
> +#define _WD_IMR_1 0x6ed60
> +#define WD_IMR(tc) _MMIO_WD(tc,\
> + _WD_IMR_0,\
> + _WD_IMR_1)
> +#define WD_FRAME_COMPLETE_INT (1 << 7)
> +#define WD_GTT_FAULT_INT (1 << 6)
> +#define WD_VBLANK_INT (1 << 5)
> +#define WD_OVERRUN_INT (1 << 4)
> +#define WD_CAPTURING_INT (1 << 3)
> +#define WD_WRITE_COMPLETE_INT (1 << 2)
> +
> +#define _WD_IIR_0 0x6e564
> +#define _WD_IIR_1 0x6ed64
> +#define WD_IIR(tc) _MMIO_WD(tc,\
> + _WD_IIR_0,\
> + _WD_IIR_1)
> +
> +#define _WD_FRAME_STATUS_0 0x6e56b
> +#define _WD_FRAME_STATUS_1 0x6ed6b
> +#define WD_FRAME_STATUS(tc) _MMIO_WD(tc,\
> + _WD_FRAME_STATUS_0,\
> + _WD_FRAME_STATUS_1)
> +
> +#define WD_FRAME_COMPLETE (1 << 31)
> +#define WD_STATE_IDLE (0 << 24)
> +#define WD_STATE_CAPSTART (1 << 24)
> +#define WD_STATE_FRAME_START (2 << 24)
> +#define WD_STATE_CAPACITIVE (3 << 24)
> +#define WD_STATE_TG_DONE (4 << 24)
> +#define WD_STATE_WDX_DONE (5 << 24)
> +#define WD_STATE_QUICK_CAP (6 << 24)
> +
> +#define _WD_27_M_0 0x6e524
> +#define _WD_27_M_1 0x6ed24
> +#define WD_27_M(tc) _MMIO_WD(tc,\
> + _WD_27_M_0,\
> + _WD_27_M_1)
> +
> +#define _WD_27_N_0 0x6e528
> +
> +//Address looks wrong in bspec:
Please make it a proper FIXME comment, or drop it. This looks like
accidental leftover.
> +#define _WD_27_N_1 0x6ec28
> +#define WD_27_N(tc) _MMIO_WD(tc,\
> + _WD_27_N_0,\
> + _WD_27_N_1)
> +
> +#define _WD_TAIL_CFG_0 0x6e520
> +#define _WD_TAIL_CFG_1 0x6ed20
> +
> +#define WD_TAIL_CFG(tc) _MMIO_WD(tc,\
> + _WD_TAIL_CFG_0,\
> + _WD_TAIL_CFG_1)
> +
> #define CLKREQ_POLICY _MMIO(0x101038)
> #define CLKREQ_POLICY_MEM_UP_OVRD REG_BIT(1)
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [Intel-gfx] [PATCH v6 2/3] drm/i915 : Changing intel_connector iterators
2022-09-19 13:05 ` [Intel-gfx] [PATCH v6 2/3] drm/i915 : Changing intel_connector iterators Kandpal, Suraj
@ 2022-10-05 10:30 ` Jani Nikula
2022-10-20 8:08 ` Kandpal, Suraj
0 siblings, 1 reply; 30+ messages in thread
From: Jani Nikula @ 2022-10-05 10:30 UTC (permalink / raw)
To: Kandpal, Suraj, intel-gfx
On Mon, 19 Sep 2022, "Kandpal, Suraj" <suraj.kandpal@intel.com> wrote:
> From: Suraj Kandpal <suraj.kandpal@intel.com>
>
> Changing intel_connector iterators as with writeback introduction
> not all drm_connector will be embedded within intel_connector.
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_acpi.c | 7 ++++-
> drivers/gpu/drm/i915/display/intel_display.h | 7 ++---
> .../drm/i915/display/intel_display_types.h | 26 ++++++++++++++++++-
> .../drm/i915/display/intel_modeset_setup.c | 16 +++++++++---
> 4 files changed, 46 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
> index 9df78e7caa2b..912fe5c2ffe5 100644
> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> @@ -349,8 +349,13 @@ void intel_acpi_video_register(struct drm_i915_private *i915)
> */
> drm_connector_list_iter_begin(&i915->drm, &conn_iter);
> drm_for_each_connector_iter(connector, &conn_iter) {
> - struct intel_panel *panel = &to_intel_connector(connector)->panel;
> + struct intel_panel *panel;
> + struct intel_connector *intel_connector =
> + to_intel_connector(connector);
>
> + if (!intel_connector)
> + continue;
> + panel = &intel_connector->panel;
> if (panel->backlight.funcs && !panel->backlight.device) {
> acpi_video_register_backlight();
> break;
> diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
> index a1ed9c82e2ed..102bf7d47ccc 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.h
> +++ b/drivers/gpu/drm/i915/display/intel_display.h
> @@ -52,6 +52,7 @@ struct intel_crtc_state;
> struct intel_digital_port;
> struct intel_dp;
> struct intel_encoder;
> +struct intel_connector;
> struct intel_initial_plane_config;
> struct intel_load_detect_pipe;
> struct intel_plane;
> @@ -469,16 +470,12 @@ enum hpd_pin {
> for_each_if(intel_encoder_can_psr(intel_encoder))
>
> #define for_each_intel_connector_iter(intel_connector, iter) \
> - while ((intel_connector = to_intel_connector(drm_connector_list_iter_next(iter))))
> + while ((intel_connector = intel_connector_list_iter_next(iter)))
>
> #define for_each_encoder_on_crtc(dev, __crtc, intel_encoder) \
> list_for_each_entry((intel_encoder), &(dev)->mode_config.encoder_list, base.head) \
> for_each_if((intel_encoder)->base.crtc == (__crtc))
>
> -#define for_each_connector_on_encoder(dev, __encoder, intel_connector) \
> - list_for_each_entry((intel_connector), &(dev)->mode_config.connector_list, base.head) \
> - for_each_if((intel_connector)->base.encoder == (__encoder))
> -
Getting rid of this macro should be a separate change. As the first
patch, could've been merged already.
> #define for_each_old_intel_plane_in_state(__state, plane, old_plane_state, __i) \
> for ((__i) = 0; \
> (__i) < (__state)->base.dev->mode_config.num_total_plane && \
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index 633cacd79074..a2d294929a64 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1498,12 +1498,14 @@ struct cxsr_latency {
> #define to_intel_atomic_state(x) container_of(x, struct intel_atomic_state, base)
> #define to_intel_crtc(x) container_of(x, struct intel_crtc, base)
> #define to_intel_crtc_state(x) container_of(x, struct intel_crtc_state, uapi)
> -#define to_intel_connector(x) container_of(x, struct intel_connector, base)
> +#define to_intel_wb_connector(x) container_of(x, struct intel_wb_connector, base)
Note that all of the macros here are sorted alphabetically.
The wb/wd difference is a pretty bad eyesore. Maybe we should use one or
the other, not mix them. (Except if we go with writeback, leave the
register macros WD because that's what they are.)
> #define to_intel_encoder(x) container_of(x, struct intel_encoder, base)
> #define to_intel_framebuffer(x) container_of(x, struct intel_framebuffer, base)
> #define to_intel_plane(x) container_of(x, struct intel_plane, base)
> #define to_intel_plane_state(x) container_of(x, struct intel_plane_state, uapi)
> #define intel_fb_obj(x) ((x) ? to_intel_bo((x)->obj[0]) : NULL)
> +#define to_intel_connector(x) (((x->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)) ? \
> + NULL : container_of(x, struct intel_connector, base))
Would need to have (x)->connector_type, with parenthesis.
The problem with this is that we currently have 131 uses of
to_intel_connector() and practically all of them expect to get non-NULL
result.
You're going to get 131 static analyzer reports that you don't check for
NULL. You can't check for NULL in most places, because they're in the
middle of local parameter initialization.
>
> struct intel_hdmi {
> i915_reg_t hdmi_reg;
> @@ -2069,4 +2071,26 @@ to_intel_frontbuffer(struct drm_framebuffer *fb)
> return fb ? to_intel_framebuffer(fb)->frontbuffer : NULL;
> }
>
> +static inline struct intel_connector *
> +intel_connector_list_iter_next(struct drm_connector_list_iter *iter)
> +{
> + struct drm_connector *connector;
> + bool flag = true;
> + /*
> + * Skipping connector that are Writeback connector as they will
> + * not be embedded in intel connector
> + */
> + while (flag) {
> + connector = drm_connector_list_iter_next(iter);
> + if (connector && !to_intel_connector(connector))
> + continue;
> +
> + flag = false;
> +
> + if (connector)
> + return to_intel_connector(connector);
> +
> + }
> + return NULL;
> +}
This gets pretty ugly. I've got an idea, I'll send patches later
today.
Code is worth a thousand words, it's easier to explain that way.
BR,
Jani.
> #endif /* __INTEL_DISPLAY_TYPES_H__ */
> diff --git a/drivers/gpu/drm/i915/display/intel_modeset_setup.c b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> index cbfabd58b75a..e1a90331c230 100644
> --- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> +++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> @@ -205,12 +205,22 @@ static bool intel_crtc_has_encoders(struct intel_crtc *crtc)
>
> static struct intel_connector *intel_encoder_find_connector(struct intel_encoder *encoder)
> {
> - struct drm_device *dev = encoder->base.dev;
> + struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> struct intel_connector *connector;
> + struct drm_connector_list_iter conn_iter;
> + bool found_connector = false;
>
> - for_each_connector_on_encoder(dev, &encoder->base, connector)
> - return connector;
> + drm_connector_list_iter_begin(&i915->drm, &conn_iter);
> + for_each_intel_connector_iter(connector, &conn_iter) {
> + if (&encoder->base == connector->base.encoder) {
> + found_connector = true;
> + break;
> + }
> + }
> + drm_connector_list_iter_end(&conn_iter);
>
> + if (found_connector)
> + return connector;
> return NULL;
> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [Intel-gfx] [PATCH v6 2/3] drm/i915 : Changing intel_connector iterators
2022-10-05 10:30 ` Jani Nikula
@ 2022-10-20 8:08 ` Kandpal, Suraj
2022-10-20 8:53 ` Jani Nikula
0 siblings, 1 reply; 30+ messages in thread
From: Kandpal, Suraj @ 2022-10-20 8:08 UTC (permalink / raw)
To: Nikula, Jani, intel-gfx
> > diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c
> > b/drivers/gpu/drm/i915/display/intel_acpi.c
> > index 9df78e7caa2b..912fe5c2ffe5 100644
> > --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> > +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> > @@ -349,8 +349,13 @@ void intel_acpi_video_register(struct
> drm_i915_private *i915)
> > */
> > drm_connector_list_iter_begin(&i915->drm, &conn_iter);
> > drm_for_each_connector_iter(connector, &conn_iter) {
> > - struct intel_panel *panel = &to_intel_connector(connector)-
> >panel;
> > + struct intel_panel *panel;
> > + struct intel_connector *intel_connector =
> > + to_intel_connector(connector);
> >
> > + if (!intel_connector)
> > + continue;
> > + panel = &intel_connector->panel;
> > if (panel->backlight.funcs && !panel->backlight.device) {
> > acpi_video_register_backlight();
> > break;
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.h
> > b/drivers/gpu/drm/i915/display/intel_display.h
> > index a1ed9c82e2ed..102bf7d47ccc 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display.h
> > @@ -52,6 +52,7 @@ struct intel_crtc_state; struct intel_digital_port;
> > struct intel_dp; struct intel_encoder;
> > +struct intel_connector;
> > struct intel_initial_plane_config;
> > struct intel_load_detect_pipe;
> > struct intel_plane;
> > @@ -469,16 +470,12 @@ enum hpd_pin {
> > for_each_if(intel_encoder_can_psr(intel_encoder))
> >
> > #define for_each_intel_connector_iter(intel_connector, iter) \
> > - while ((intel_connector =
> to_intel_connector(drm_connector_list_iter_next(iter))))
> > + while ((intel_connector = intel_connector_list_iter_next(iter)))
> >
> > #define for_each_encoder_on_crtc(dev, __crtc, intel_encoder) \
> > list_for_each_entry((intel_encoder), &(dev)-
> >mode_config.encoder_list, base.head) \
> > for_each_if((intel_encoder)->base.crtc == (__crtc))
> >
> > -#define for_each_connector_on_encoder(dev, __encoder,
> intel_connector) \
> > - list_for_each_entry((intel_connector), &(dev)-
> >mode_config.connector_list, base.head) \
> > - for_each_if((intel_connector)->base.encoder ==
> (__encoder))
> > -
>
> Getting rid of this macro should be a separate change. As the first patch,
> could've been merged already.
>
Hi Jani,
This change has no dependency on the last patch as the only place this is called (intel_encoder_find_connector)
Is also being fixed in this patch itself so creating a new patch for this may not be necessary
Regards,
Suraj Kandpal
> > #define for_each_old_intel_plane_in_state(__state, plane,
> old_plane_state, __i) \
> > for ((__i) = 0; \
> > (__i) < (__state)->base.dev->mode_config.num_total_plane && \
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
> > b/drivers/gpu/drm/i915/display/intel_display_types.h
> > index 633cacd79074..a2d294929a64 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> > @@ -1498,12 +1498,14 @@ struct cxsr_latency { #define
> > to_intel_atomic_state(x) container_of(x, struct intel_atomic_state,
> > base) #define to_intel_crtc(x) container_of(x, struct intel_crtc,
> > base) #define to_intel_crtc_state(x) container_of(x, struct
> > intel_crtc_state, uapi) -#define to_intel_connector(x) container_of(x,
> > struct intel_connector, base)
> > +#define to_intel_wb_connector(x) container_of(x, struct
> > +intel_wb_connector, base)
>
> Note that all of the macros here are sorted alphabetically.
>
> The wb/wd difference is a pretty bad eyesore. Maybe we should use one or
> the other, not mix them. (Except if we go with writeback, leave the register
> macros WD because that's what they are.)
>
> > #define to_intel_encoder(x) container_of(x, struct intel_encoder,
> > base) #define to_intel_framebuffer(x) container_of(x, struct
> > intel_framebuffer, base) #define to_intel_plane(x) container_of(x,
> > struct intel_plane, base) #define to_intel_plane_state(x)
> > container_of(x, struct intel_plane_state, uapi) #define
> > intel_fb_obj(x) ((x) ? to_intel_bo((x)->obj[0]) : NULL)
> > +#define to_intel_connector(x) (((x->connector_type ==
> DRM_MODE_CONNECTOR_WRITEBACK)) ? \
> > + NULL : container_of(x, struct
> intel_connector, base))
>
> Would need to have (x)->connector_type, with parenthesis.
>
> The problem with this is that we currently have 131 uses of
> to_intel_connector() and practically all of them expect to get non-NULL
> result.
>
> You're going to get 131 static analyzer reports that you don't check for
> NULL. You can't check for NULL in most places, because they're in the
> middle of local parameter initialization.
>
> >
> > struct intel_hdmi {
> > i915_reg_t hdmi_reg;
> > @@ -2069,4 +2071,26 @@ to_intel_frontbuffer(struct drm_framebuffer
> *fb)
> > return fb ? to_intel_framebuffer(fb)->frontbuffer : NULL; }
> >
> > +static inline struct intel_connector *
> > +intel_connector_list_iter_next(struct drm_connector_list_iter *iter)
> > +{
> > + struct drm_connector *connector;
> > + bool flag = true;
> > + /*
> > + * Skipping connector that are Writeback connector as they will
> > + * not be embedded in intel connector
> > + */
> > + while (flag) {
> > + connector = drm_connector_list_iter_next(iter);
> > + if (connector && !to_intel_connector(connector))
> > + continue;
> > +
> > + flag = false;
> > +
> > + if (connector)
> > + return to_intel_connector(connector);
> > +
> > + }
> > + return NULL;
> > +}
>
> This gets pretty ugly. I've got an idea, I'll send patches later today.
>
> Code is worth a thousand words, it's easier to explain that way.
>
> BR,
> Jani.
>
> > #endif /* __INTEL_DISPLAY_TYPES_H__ */ diff --git
> > a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > index cbfabd58b75a..e1a90331c230 100644
> > --- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > +++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> > @@ -205,12 +205,22 @@ static bool intel_crtc_has_encoders(struct
> > intel_crtc *crtc)
> >
> > static struct intel_connector *intel_encoder_find_connector(struct
> > intel_encoder *encoder) {
> > - struct drm_device *dev = encoder->base.dev;
> > + struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> > struct intel_connector *connector;
> > + struct drm_connector_list_iter conn_iter;
> > + bool found_connector = false;
> >
> > - for_each_connector_on_encoder(dev, &encoder->base, connector)
> > - return connector;
> > + drm_connector_list_iter_begin(&i915->drm, &conn_iter);
> > + for_each_intel_connector_iter(connector, &conn_iter) {
> > + if (&encoder->base == connector->base.encoder) {
> > + found_connector = true;
> > + break;
> > + }
> > + }
> > + drm_connector_list_iter_end(&conn_iter);
> >
> > + if (found_connector)
> > + return connector;
> > return NULL;
> > }
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [Intel-gfx] [PATCH v6 2/3] drm/i915 : Changing intel_connector iterators
2022-10-20 8:08 ` Kandpal, Suraj
@ 2022-10-20 8:53 ` Jani Nikula
2022-10-20 8:56 ` Kandpal, Suraj
0 siblings, 1 reply; 30+ messages in thread
From: Jani Nikula @ 2022-10-20 8:53 UTC (permalink / raw)
To: Kandpal, Suraj, intel-gfx
On Thu, 20 Oct 2022, "Kandpal, Suraj" <suraj.kandpal@intel.com> wrote:
>> > diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c
>> > b/drivers/gpu/drm/i915/display/intel_acpi.c
>> > index 9df78e7caa2b..912fe5c2ffe5 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_acpi.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
>> > @@ -349,8 +349,13 @@ void intel_acpi_video_register(struct
>> drm_i915_private *i915)
>> > */
>> > drm_connector_list_iter_begin(&i915->drm, &conn_iter);
>> > drm_for_each_connector_iter(connector, &conn_iter) {
>> > - struct intel_panel *panel = &to_intel_connector(connector)-
>> >panel;
>> > + struct intel_panel *panel;
>> > + struct intel_connector *intel_connector =
>> > + to_intel_connector(connector);
>> >
>> > + if (!intel_connector)
>> > + continue;
>> > + panel = &intel_connector->panel;
>> > if (panel->backlight.funcs && !panel->backlight.device) {
>> > acpi_video_register_backlight();
>> > break;
>> > diff --git a/drivers/gpu/drm/i915/display/intel_display.h
>> > b/drivers/gpu/drm/i915/display/intel_display.h
>> > index a1ed9c82e2ed..102bf7d47ccc 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_display.h
>> > +++ b/drivers/gpu/drm/i915/display/intel_display.h
>> > @@ -52,6 +52,7 @@ struct intel_crtc_state; struct intel_digital_port;
>> > struct intel_dp; struct intel_encoder;
>> > +struct intel_connector;
>> > struct intel_initial_plane_config;
>> > struct intel_load_detect_pipe;
>> > struct intel_plane;
>> > @@ -469,16 +470,12 @@ enum hpd_pin {
>> > for_each_if(intel_encoder_can_psr(intel_encoder))
>> >
>> > #define for_each_intel_connector_iter(intel_connector, iter) \
>> > - while ((intel_connector =
>> to_intel_connector(drm_connector_list_iter_next(iter))))
>> > + while ((intel_connector = intel_connector_list_iter_next(iter)))
>> >
>> > #define for_each_encoder_on_crtc(dev, __crtc, intel_encoder) \
>> > list_for_each_entry((intel_encoder), &(dev)-
>> >mode_config.encoder_list, base.head) \
>> > for_each_if((intel_encoder)->base.crtc == (__crtc))
>> >
>> > -#define for_each_connector_on_encoder(dev, __encoder,
>> intel_connector) \
>> > - list_for_each_entry((intel_connector), &(dev)-
>> >mode_config.connector_list, base.head) \
>> > - for_each_if((intel_connector)->base.encoder ==
>> (__encoder))
>> > -
>>
>> Getting rid of this macro should be a separate change. As the first patch,
>> could've been merged already.
>>
> Hi Jani,
> This change has no dependency on the last patch as the only place this is called (intel_encoder_find_connector)
> Is also being fixed in this patch itself so creating a new patch for this may not be necessary
It's a good idea no matter what to get rid of this single use macro, so
please just send a patch for it separately, and get it merged.
BR,
Jani.
>
> Regards,
> Suraj Kandpal
>> > #define for_each_old_intel_plane_in_state(__state, plane,
>> old_plane_state, __i) \
>> > for ((__i) = 0; \
>> > (__i) < (__state)->base.dev->mode_config.num_total_plane && \
>> > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
>> > b/drivers/gpu/drm/i915/display/intel_display_types.h
>> > index 633cacd79074..a2d294929a64 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_display_types.h
>> > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
>> > @@ -1498,12 +1498,14 @@ struct cxsr_latency { #define
>> > to_intel_atomic_state(x) container_of(x, struct intel_atomic_state,
>> > base) #define to_intel_crtc(x) container_of(x, struct intel_crtc,
>> > base) #define to_intel_crtc_state(x) container_of(x, struct
>> > intel_crtc_state, uapi) -#define to_intel_connector(x) container_of(x,
>> > struct intel_connector, base)
>> > +#define to_intel_wb_connector(x) container_of(x, struct
>> > +intel_wb_connector, base)
>>
>> Note that all of the macros here are sorted alphabetically.
>>
>> The wb/wd difference is a pretty bad eyesore. Maybe we should use one or
>> the other, not mix them. (Except if we go with writeback, leave the register
>> macros WD because that's what they are.)
>>
>> > #define to_intel_encoder(x) container_of(x, struct intel_encoder,
>> > base) #define to_intel_framebuffer(x) container_of(x, struct
>> > intel_framebuffer, base) #define to_intel_plane(x) container_of(x,
>> > struct intel_plane, base) #define to_intel_plane_state(x)
>> > container_of(x, struct intel_plane_state, uapi) #define
>> > intel_fb_obj(x) ((x) ? to_intel_bo((x)->obj[0]) : NULL)
>> > +#define to_intel_connector(x) (((x->connector_type ==
>> DRM_MODE_CONNECTOR_WRITEBACK)) ? \
>> > + NULL : container_of(x, struct
>> intel_connector, base))
>>
>> Would need to have (x)->connector_type, with parenthesis.
>>
>> The problem with this is that we currently have 131 uses of
>> to_intel_connector() and practically all of them expect to get non-NULL
>> result.
>>
>> You're going to get 131 static analyzer reports that you don't check for
>> NULL. You can't check for NULL in most places, because they're in the
>> middle of local parameter initialization.
>>
>> >
>> > struct intel_hdmi {
>> > i915_reg_t hdmi_reg;
>> > @@ -2069,4 +2071,26 @@ to_intel_frontbuffer(struct drm_framebuffer
>> *fb)
>> > return fb ? to_intel_framebuffer(fb)->frontbuffer : NULL; }
>> >
>> > +static inline struct intel_connector *
>> > +intel_connector_list_iter_next(struct drm_connector_list_iter *iter)
>> > +{
>> > + struct drm_connector *connector;
>> > + bool flag = true;
>> > + /*
>> > + * Skipping connector that are Writeback connector as they will
>> > + * not be embedded in intel connector
>> > + */
>> > + while (flag) {
>> > + connector = drm_connector_list_iter_next(iter);
>> > + if (connector && !to_intel_connector(connector))
>> > + continue;
>> > +
>> > + flag = false;
>> > +
>> > + if (connector)
>> > + return to_intel_connector(connector);
>> > +
>> > + }
>> > + return NULL;
>> > +}
>>
>> This gets pretty ugly. I've got an idea, I'll send patches later today.
>>
>> Code is worth a thousand words, it's easier to explain that way.
>>
>> BR,
>> Jani.
>>
>> > #endif /* __INTEL_DISPLAY_TYPES_H__ */ diff --git
>> > a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
>> > b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
>> > index cbfabd58b75a..e1a90331c230 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
>> > @@ -205,12 +205,22 @@ static bool intel_crtc_has_encoders(struct
>> > intel_crtc *crtc)
>> >
>> > static struct intel_connector *intel_encoder_find_connector(struct
>> > intel_encoder *encoder) {
>> > - struct drm_device *dev = encoder->base.dev;
>> > + struct drm_i915_private *i915 = to_i915(encoder->base.dev);
>> > struct intel_connector *connector;
>> > + struct drm_connector_list_iter conn_iter;
>> > + bool found_connector = false;
>> >
>> > - for_each_connector_on_encoder(dev, &encoder->base, connector)
>> > - return connector;
>> > + drm_connector_list_iter_begin(&i915->drm, &conn_iter);
>> > + for_each_intel_connector_iter(connector, &conn_iter) {
>> > + if (&encoder->base == connector->base.encoder) {
>> > + found_connector = true;
>> > + break;
>> > + }
>> > + }
>> > + drm_connector_list_iter_end(&conn_iter);
>> >
>> > + if (found_connector)
>> > + return connector;
>> > return NULL;
>> > }
>>
>> --
>> Jani Nikula, Intel Open Source Graphics Center
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [Intel-gfx] [PATCH v6 2/3] drm/i915 : Changing intel_connector iterators
2022-10-20 8:53 ` Jani Nikula
@ 2022-10-20 8:56 ` Kandpal, Suraj
0 siblings, 0 replies; 30+ messages in thread
From: Kandpal, Suraj @ 2022-10-20 8:56 UTC (permalink / raw)
To: Nikula, Jani, intel-gfx
> >> > drm_connector_list_iter_begin(&i915->drm, &conn_iter);
> >> > drm_for_each_connector_iter(connector, &conn_iter) {
> >> > - struct intel_panel *panel = &to_intel_connector(connector)-
> >> >panel;
> >> > + struct intel_panel *panel;
> >> > + struct intel_connector *intel_connector =
> >> > + to_intel_connector(connector);
> >> >
> >> > + if (!intel_connector)
> >> > + continue;
> >> > + panel = &intel_connector->panel;
> >> > if (panel->backlight.funcs && !panel->backlight.device) {
> >> > acpi_video_register_backlight();
> >> > break;
> >> > diff --git a/drivers/gpu/drm/i915/display/intel_display.h
> >> > b/drivers/gpu/drm/i915/display/intel_display.h
> >> > index a1ed9c82e2ed..102bf7d47ccc 100644
> >> > --- a/drivers/gpu/drm/i915/display/intel_display.h
> >> > +++ b/drivers/gpu/drm/i915/display/intel_display.h
> >> > @@ -52,6 +52,7 @@ struct intel_crtc_state; struct
> >> > intel_digital_port; struct intel_dp; struct intel_encoder;
> >> > +struct intel_connector;
> >> > struct intel_initial_plane_config; struct intel_load_detect_pipe;
> >> > struct intel_plane; @@ -469,16 +470,12 @@ enum hpd_pin {
> >> > for_each_if(intel_encoder_can_psr(intel_encoder))
> >> >
> >> > #define for_each_intel_connector_iter(intel_connector, iter) \
> >> > - while ((intel_connector =
> >> to_intel_connector(drm_connector_list_iter_next(iter))))
> >> > + while ((intel_connector =
> >> > + intel_connector_list_iter_next(iter)))
> >> >
> >> > #define for_each_encoder_on_crtc(dev, __crtc, intel_encoder) \
> >> > list_for_each_entry((intel_encoder), &(dev)-
> >> >mode_config.encoder_list, base.head) \
> >> > for_each_if((intel_encoder)->base.crtc == (__crtc))
> >> >
> >> > -#define for_each_connector_on_encoder(dev, __encoder,
> >> intel_connector) \
> >> > - list_for_each_entry((intel_connector), &(dev)-
> >> >mode_config.connector_list, base.head) \
> >> > - for_each_if((intel_connector)->base.encoder ==
> >> (__encoder))
> >> > -
> >>
> >> Getting rid of this macro should be a separate change. As the first
> >> patch, could've been merged already.
> >>
> > Hi Jani,
> > This change has no dependency on the last patch as the only place
> > this is called (intel_encoder_find_connector) Is also being fixed in
> > this patch itself so creating a new patch for this may not be
> > necessary
>
> It's a good idea no matter what to get rid of this single use macro, so please
> just send a patch for it separately, and get it merged.
>
Ohk got it will be sending out a patch to get rid of this single use macro
Regards,
Suraj Kandpal
> BR,
> Jani.
>
> >
> > Regards,
> > Suraj Kandpal
> >> > #define for_each_old_intel_plane_in_state(__state, plane,
> >> old_plane_state, __i) \
> >> > for ((__i) = 0; \
> >> > (__i) < (__state)->base.dev->mode_config.num_total_plane
> >> > && \ diff --git
> >> > a/drivers/gpu/drm/i915/display/intel_display_types.h
> >> > b/drivers/gpu/drm/i915/display/intel_display_types.h
> >> > index 633cacd79074..a2d294929a64 100644
> >> > --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> >> > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> >> > @@ -1498,12 +1498,14 @@ struct cxsr_latency { #define
> >> > to_intel_atomic_state(x) container_of(x, struct intel_atomic_state,
> >> > base) #define to_intel_crtc(x) container_of(x, struct intel_crtc,
> >> > base) #define to_intel_crtc_state(x) container_of(x, struct
> >> > intel_crtc_state, uapi) -#define to_intel_connector(x)
> >> > container_of(x, struct intel_connector, base)
> >> > +#define to_intel_wb_connector(x) container_of(x, struct
> >> > +intel_wb_connector, base)
> >>
> >> Note that all of the macros here are sorted alphabetically.
> >>
> >> The wb/wd difference is a pretty bad eyesore. Maybe we should use one
> >> or the other, not mix them. (Except if we go with writeback, leave
> >> the register macros WD because that's what they are.)
> >>
> >> > #define to_intel_encoder(x) container_of(x, struct intel_encoder,
> >> > base) #define to_intel_framebuffer(x) container_of(x, struct
> >> > intel_framebuffer, base) #define to_intel_plane(x) container_of(x,
> >> > struct intel_plane, base) #define to_intel_plane_state(x)
> >> > container_of(x, struct intel_plane_state, uapi) #define
> >> > intel_fb_obj(x) ((x) ? to_intel_bo((x)->obj[0]) : NULL)
> >> > +#define to_intel_connector(x) (((x->connector_type ==
> >> DRM_MODE_CONNECTOR_WRITEBACK)) ? \
> >> > + NULL : container_of(x, struct
> >> intel_connector, base))
> >>
> >> Would need to have (x)->connector_type, with parenthesis.
> >>
> >> The problem with this is that we currently have 131 uses of
> >> to_intel_connector() and practically all of them expect to get
> >> non-NULL result.
> >>
> >> You're going to get 131 static analyzer reports that you don't check
> >> for NULL. You can't check for NULL in most places, because they're in
> >> the middle of local parameter initialization.
> >>
> >> >
> >> > struct intel_hdmi {
> >> > i915_reg_t hdmi_reg;
> >> > @@ -2069,4 +2071,26 @@ to_intel_frontbuffer(struct
> drm_framebuffer
> >> *fb)
> >> > return fb ? to_intel_framebuffer(fb)->frontbuffer : NULL; }
> >> >
> >> > +static inline struct intel_connector *
> >> > +intel_connector_list_iter_next(struct drm_connector_list_iter
> >> > +*iter) {
> >> > + struct drm_connector *connector;
> >> > + bool flag = true;
> >> > + /*
> >> > + * Skipping connector that are Writeback connector as they will
> >> > + * not be embedded in intel connector
> >> > + */
> >> > + while (flag) {
> >> > + connector = drm_connector_list_iter_next(iter);
> >> > + if (connector && !to_intel_connector(connector))
> >> > + continue;
> >> > +
> >> > + flag = false;
> >> > +
> >> > + if (connector)
> >> > + return to_intel_connector(connector);
> >> > +
> >> > + }
> >> > + return NULL;
> >> > +}
> >>
> >> This gets pretty ugly. I've got an idea, I'll send patches later today.
> >>
> >> Code is worth a thousand words, it's easier to explain that way.
> >>
> >> BR,
> >> Jani.
> >>
> >> > #endif /* __INTEL_DISPLAY_TYPES_H__ */ diff --git
> >> > a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> >> > b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> >> > index cbfabd58b75a..e1a90331c230 100644
> >> > --- a/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> >> > +++ b/drivers/gpu/drm/i915/display/intel_modeset_setup.c
> >> > @@ -205,12 +205,22 @@ static bool intel_crtc_has_encoders(struct
> >> > intel_crtc *crtc)
> >> >
> >> > static struct intel_connector *intel_encoder_find_connector(struct
> >> > intel_encoder *encoder) {
> >> > - struct drm_device *dev = encoder->base.dev;
> >> > + struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> >> > struct intel_connector *connector;
> >> > + struct drm_connector_list_iter conn_iter;
> >> > + bool found_connector = false;
> >> >
> >> > - for_each_connector_on_encoder(dev, &encoder->base, connector)
> >> > - return connector;
> >> > + drm_connector_list_iter_begin(&i915->drm, &conn_iter);
> >> > + for_each_intel_connector_iter(connector, &conn_iter) {
> >> > + if (&encoder->base == connector->base.encoder) {
> >> > + found_connector = true;
> >> > + break;
> >> > + }
> >> > + }
> >> > + drm_connector_list_iter_end(&conn_iter);
> >> >
> >> > + if (found_connector)
> >> > + return connector;
> >> > return NULL;
> >> > }
> >>
> >> --
> >> Jani Nikula, Intel Open Source Graphics Center
>
> --
> Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 30+ messages in thread
end of thread, other threads:[~2022-10-20 8:56 UTC | newest]
Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 13:05 [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
2022-09-19 13:05 ` [Intel-gfx] [PATCH v6 1/3] drm/i915: Define WD trancoder for i915 Kandpal, Suraj
2022-10-05 9:07 ` Jani Nikula
2022-09-19 13:05 ` [Intel-gfx] [PATCH v6 2/3] drm/i915 : Changing intel_connector iterators Kandpal, Suraj
2022-10-05 10:30 ` Jani Nikula
2022-10-20 8:08 ` Kandpal, Suraj
2022-10-20 8:53 ` Jani Nikula
2022-10-20 8:56 ` Kandpal, Suraj
2022-09-19 13:05 ` [Intel-gfx] [PATCH v6 3/3] drm/i915: Enabling WD Transcoder Kandpal, Suraj
2022-09-28 15:23 ` Swati Sharma
2022-09-19 14:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev6) Patchwork
2022-09-19 14:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-09-19 14:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-09-19 23:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev7) Patchwork
2022-09-19 23:41 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-09-20 0:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-20 8:36 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-20 14:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev8) Patchwork
2022-09-20 14:27 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-09-20 14:51 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-09-20 15:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-20 20:09 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-21 2:07 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable Pipewriteback (rev9) Patchwork
2022-09-21 2:07 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-09-21 2:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-21 3:35 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-09-21 5:14 ` [Intel-gfx] [PATCH v6 0/3] Enable Pipewriteback Kandpal, Suraj
2022-09-28 12:46 ` Swati Sharma
2022-09-28 13:55 ` Kandpal, Suraj
2022-09-28 15:15 ` Swati Sharma
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.