All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH BlueZ] gatt: Fix scan-build warnings
@ 2022-09-21 21:50 Luiz Augusto von Dentz
  2022-09-21 23:11 ` [BlueZ] " bluez.test.bot
  2022-09-22  1:10 ` [PATCH BlueZ] " patchwork-bot+bluetooth
  0 siblings, 2 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2022-09-21 21:50 UTC (permalink / raw)
  To: linux-bluetooth

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fixes the following warnings:

src/gatt-database.c:3541:14: warning: Value stored to 'iface' during
its initialization is never read [deadcode.DeadStores]
        const char *iface = g_dbus_proxy_get_interface(proxy);
                    ^~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/gatt-database.c:3542:14: warning: Value stored to 'path' during
its initialization is never read [deadcode.DeadStores]
        const char *path = g_dbus_proxy_get_path(proxy);
                    ^~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---
 src/gatt-database.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gatt-database.c b/src/gatt-database.c
index a212dfc4e694..c72f4a4d5c54 100644
--- a/src/gatt-database.c
+++ b/src/gatt-database.c
@@ -3538,8 +3538,8 @@ static void register_characteristic(void *data, void *user_data)
 {
 	struct gatt_app *app = user_data;
 	GDBusProxy *proxy = data;
-	const char *iface = g_dbus_proxy_get_interface(proxy);
-	const char *path = g_dbus_proxy_get_path(proxy);
+	const char *iface;
+	const char *path;
 
 	if (app->failed)
 		return;
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* RE: [BlueZ] gatt: Fix scan-build warnings
  2022-09-21 21:50 [PATCH BlueZ] gatt: Fix scan-build warnings Luiz Augusto von Dentz
@ 2022-09-21 23:11 ` bluez.test.bot
  2022-09-22  1:10 ` [PATCH BlueZ] " patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2022-09-21 23:11 UTC (permalink / raw)
  To: linux-bluetooth, luiz.dentz

[-- Attachment #1: Type: text/plain, Size: 1718 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=679175

---Test result---

Test Summary:
CheckPatch                    PASS      0.66 seconds
GitLint                       PASS      0.45 seconds
Prep - Setup ELL              PASS      31.33 seconds
Build - Prep                  PASS      0.72 seconds
Build - Configure             PASS      10.18 seconds
Build - Make                  PASS      925.33 seconds
Make Check                    PASS      12.18 seconds
Make Check w/Valgrind         PASS      333.67 seconds
Make Distcheck                PASS      282.86 seconds
Build w/ext ELL - Configure   PASS      10.16 seconds
Build w/ext ELL - Make        PASS      98.70 seconds
Incremental Build w/ patches  PASS      0.00 seconds
Scan Build                    WARNING   584.44 seconds

Details
##############################
Test: Scan Build - WARNING
Desc: Run Scan Build with patches
Output:
*****************************************************************************
The bugs reported by the scan-build may or may not be caused by your patches.
Please check the list and fix the bugs if they are caused by your patch.
*****************************************************************************
src/gatt-database.c:1138:10: warning: Value stored to 'bits' during its initialization is never read
        uint8_t bits[] = { BT_GATT_CHRC_CLI_FEAT_ROBUST_CACHING,
                ^~~~     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.




---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH BlueZ] gatt: Fix scan-build warnings
  2022-09-21 21:50 [PATCH BlueZ] gatt: Fix scan-build warnings Luiz Augusto von Dentz
  2022-09-21 23:11 ` [BlueZ] " bluez.test.bot
@ 2022-09-22  1:10 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2022-09-22  1:10 UTC (permalink / raw)
  To: Luiz Augusto von Dentz; +Cc: linux-bluetooth

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 21 Sep 2022 14:50:41 -0700 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes the following warnings:
> 
> src/gatt-database.c:3541:14: warning: Value stored to 'iface' during
> its initialization is never read [deadcode.DeadStores]
>         const char *iface = g_dbus_proxy_get_interface(proxy);
>                     ^~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> src/gatt-database.c:3542:14: warning: Value stored to 'path' during
> its initialization is never read [deadcode.DeadStores]
>         const char *path = g_dbus_proxy_get_path(proxy);
>                     ^~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> [...]

Here is the summary with links:
  - [BlueZ] gatt: Fix scan-build warnings
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=31b32daf5292

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-22  1:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-21 21:50 [PATCH BlueZ] gatt: Fix scan-build warnings Luiz Augusto von Dentz
2022-09-21 23:11 ` [BlueZ] " bluez.test.bot
2022-09-22  1:10 ` [PATCH BlueZ] " patchwork-bot+bluetooth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.