* [Intel-gfx] [PATCH] drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support
@ 2022-09-26 8:45 Anshuman Gupta
2022-09-26 13:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Anshuman Gupta @ 2022-09-26 8:45 UTC (permalink / raw)
To: intel-gfx
Adding support in drpc show debugfs to print the GT RPM Unit RC6
residency. This GTC6_RESIDENCY_{LSB, MSB} will only increment when
GT will be RC6. Therefore these register will get reset at RC6
exit and will start incrementing on next RC6 entry.
BSpec: 64977
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 5 +++++
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 5 +++++
drivers/gpu/drm/i915/gt/intel_rc6.c | 19 +++++++++++++++++++
drivers/gpu/drm/i915/gt/intel_rc6.h | 1 +
4 files changed, 30 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
index 10f680dbd7b62..59b6cc49464e9 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
@@ -195,6 +195,11 @@ static int gen6_drpc(struct seq_file *m)
print_rc6_res(m, "RC6 \"Locked to RPn\" residency since boot:",
GEN6_GT_GFX_RC6_LOCKED);
print_rc6_res(m, "RC6 residency since boot:", GEN6_GT_GFX_RC6);
+
+ if (GRAPHICS_VER(i915) >= 12)
+ seq_printf(m, "GT RC6 RPM Unit Residency since last RC6 exit: 0x%llx\n",
+ intel_rc6_rpm_unit_residency(>->rc6));
+
print_rc6_res(m, "RC6+ residency since boot:", GEN6_GT_GFX_RC6p);
print_rc6_res(m, "RC6++ residency since boot:", GEN6_GT_GFX_RC6pp);
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
index 7f79bbf978284..7715d0aeffc9d 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
+++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
@@ -8,6 +8,11 @@
#include "i915_reg_defs.h"
+/* GT RPM RC6 counter */
+#define GEN12_GT_GFX_RC6_LSB _MMIO(0xC20)
+#define GEN12_GT_GFX_RC6_MSB _MMIO(0xC24)
+#define GEN12_GT_GFX_RC6_MSB_MASK REG_GENMASK(23, 0)
+
/* RPM unit config (Gen8+) */
#define RPM_CONFIG0 _MMIO(0xd00)
#define GEN9_RPM_CONFIG0_CRYSTAL_CLOCK_FREQ_SHIFT 3
diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
index f8d0523f4c18e..ee830c4027542 100644
--- a/drivers/gpu/drm/i915/gt/intel_rc6.c
+++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
@@ -816,6 +816,25 @@ u64 intel_rc6_residency_us(struct intel_rc6 *rc6, i915_reg_t reg)
return DIV_ROUND_UP_ULL(intel_rc6_residency_ns(rc6, reg), 1000);
}
+u64 intel_rc6_rpm_unit_residency(struct intel_rc6 *rc6)
+{
+ struct drm_i915_private *i915 = rc6_to_i915(rc6);
+ struct intel_gt *gt = rc6_to_gt(rc6);
+ intel_wakeref_t wakeref;
+ u64 lsb, msb, counter;
+
+ with_intel_runtime_pm(gt->uncore->rpm, wakeref) {
+ lsb = intel_uncore_read(gt->uncore, GEN12_GT_GFX_RC6_LSB);
+ msb = intel_uncore_read(gt->uncore, GEN12_GT_GFX_RC6_MSB);
+ }
+
+ drm_dbg(&i915->drm, "GT RC6 MSB=0x%x LSB=0x%x\n", (u32) msb, (u32) lsb);
+ msb = REG_FIELD_GET(GEN12_GT_GFX_RC6_MSB_MASK, (u32)msb);
+ counter = msb << 32 | lsb;
+
+ return counter;
+}
+
#if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
#include "selftest_rc6.c"
#endif
diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.h b/drivers/gpu/drm/i915/gt/intel_rc6.h
index b6fea71afc223..6fa0896756d47 100644
--- a/drivers/gpu/drm/i915/gt/intel_rc6.h
+++ b/drivers/gpu/drm/i915/gt/intel_rc6.h
@@ -23,5 +23,6 @@ void intel_rc6_disable(struct intel_rc6 *rc6);
u64 intel_rc6_residency_ns(struct intel_rc6 *rc6, i915_reg_t reg);
u64 intel_rc6_residency_us(struct intel_rc6 *rc6, i915_reg_t reg);
+u64 intel_rc6_rpm_unit_residency(struct intel_rc6 *rc6);
#endif /* INTEL_RC6_H */
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support
2022-09-26 8:45 [Intel-gfx] [PATCH] drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support Anshuman Gupta
@ 2022-09-26 13:41 ` Patchwork
2022-09-26 14:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2022-09-26 13:41 UTC (permalink / raw)
To: Gupta, Anshuman; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support
URL : https://patchwork.freedesktop.org/series/109041/
State : warning
== Summary ==
Error: dim checkpatch failed
464f26368366 drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support
-:67: CHECK:SPACING: No space is necessary after a cast
#67: FILE: drivers/gpu/drm/i915/gt/intel_rc6.c:831:
+ drm_dbg(&i915->drm, "GT RC6 MSB=0x%x LSB=0x%x\n", (u32) msb, (u32) lsb);
total: 0 errors, 0 warnings, 1 checks, 53 lines checked
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support
2022-09-26 8:45 [Intel-gfx] [PATCH] drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support Anshuman Gupta
2022-09-26 13:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2022-09-26 14:03 ` Patchwork
2022-09-26 16:05 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
2022-09-26 17:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2022-09-26 14:03 UTC (permalink / raw)
To: Gupta, Anshuman; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5735 bytes --]
== Series Details ==
Series: drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support
URL : https://patchwork.freedesktop.org/series/109041/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12182 -> Patchwork_109041v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/index.html
Participating hosts (48 -> 47)
------------------------------
Additional (1): fi-icl-u2
Missing (2): fi-hsw-4770 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_109041v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][1] ([i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/fi-icl-u2/igt@gem_huc_copy@huc-copy.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-g3258: NOTRUN -> [SKIP][2] ([fdo#109271] / [fdo#111827])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/fi-hsw-g3258/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-bdw-5557u: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/fi-bdw-5557u/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][4] ([fdo#111827]) +7 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-icl-u2: NOTRUN -> [SKIP][5] ([i915#4103])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_flip@basic-flip-vs-dpms@b-edp1:
- fi-icl-u2: NOTRUN -> [DMESG-WARN][6] ([i915#4890])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/fi-icl-u2/igt@kms_flip@basic-flip-vs-dpms@b-edp1.html
* igt@runner@aborted:
- fi-icl-u2: NOTRUN -> [FAIL][7] ([i915#4312])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/fi-icl-u2/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rplp-1}: [DMESG-WARN][8] ([i915#2867]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/bat-rplp-1/igt@gem_exec_suspend@basic-s0@smem.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/bat-rplp-1/igt@gem_exec_suspend@basic-s0@smem.html
- {bat-adlm-1}: [DMESG-WARN][10] ([i915#2867]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@gem_exec_suspend@basic-s3@lmem0:
- {bat-dg2-11}: [DMESG-WARN][12] ([i915#6816]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/bat-dg2-11/igt@gem_exec_suspend@basic-s3@lmem0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/bat-dg2-11/igt@gem_exec_suspend@basic-s3@lmem0.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-g3258: [INCOMPLETE][14] ([i915#3303] / [i915#4785]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2:
- {bat-dg2-11}: [FAIL][16] ([i915#6818]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/bat-dg2-11/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-2.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4890]: https://gitlab.freedesktop.org/drm/intel/issues/4890
[i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6816]: https://gitlab.freedesktop.org/drm/intel/issues/6816
[i915#6818]: https://gitlab.freedesktop.org/drm/intel/issues/6818
Build changes
-------------
* Linux: CI_DRM_12182 -> Patchwork_109041v1
CI-20190529: 20190529
CI_DRM_12182: 8ad031bd195081f699414339ac21fa46dd0b8e2d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6663: 5e232c77cd762147e0882c337a984121fabb1c75 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109041v1: 8ad031bd195081f699414339ac21fa46dd0b8e2d @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
30f4395e6765 drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/index.html
[-- Attachment #2: Type: text/html, Size: 6767 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support
2022-09-26 8:45 [Intel-gfx] [PATCH] drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support Anshuman Gupta
2022-09-26 13:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-09-26 14:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-09-26 16:05 ` Tvrtko Ursulin
2022-09-27 6:48 ` Gupta, Anshuman
2022-09-26 17:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
3 siblings, 1 reply; 7+ messages in thread
From: Tvrtko Ursulin @ 2022-09-26 16:05 UTC (permalink / raw)
To: Anshuman Gupta, intel-gfx
On 26/09/2022 09:45, Anshuman Gupta wrote:
> Adding support in drpc show debugfs to print the GT RPM Unit RC6
> residency. This GTC6_RESIDENCY_{LSB, MSB} will only increment when
> GT will be RC6. Therefore these register will get reset at RC6
> exit and will start incrementing on next RC6 entry.
>
> BSpec: 64977
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 5 +++++
> drivers/gpu/drm/i915/gt/intel_gt_regs.h | 5 +++++
> drivers/gpu/drm/i915/gt/intel_rc6.c | 19 +++++++++++++++++++
> drivers/gpu/drm/i915/gt/intel_rc6.h | 1 +
> 4 files changed, 30 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> index 10f680dbd7b62..59b6cc49464e9 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> @@ -195,6 +195,11 @@ static int gen6_drpc(struct seq_file *m)
> print_rc6_res(m, "RC6 \"Locked to RPn\" residency since boot:",
> GEN6_GT_GFX_RC6_LOCKED);
> print_rc6_res(m, "RC6 residency since boot:", GEN6_GT_GFX_RC6);
> +
> + if (GRAPHICS_VER(i915) >= 12)
> + seq_printf(m, "GT RC6 RPM Unit Residency since last RC6 exit: 0x%llx\n",
> + intel_rc6_rpm_unit_residency(>->rc6));
> +
> print_rc6_res(m, "RC6+ residency since boot:", GEN6_GT_GFX_RC6p);
> print_rc6_res(m, "RC6++ residency since boot:", GEN6_GT_GFX_RC6pp);
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> index 7f79bbf978284..7715d0aeffc9d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> @@ -8,6 +8,11 @@
>
> #include "i915_reg_defs.h"
>
> +/* GT RPM RC6 counter */
> +#define GEN12_GT_GFX_RC6_LSB _MMIO(0xC20)
> +#define GEN12_GT_GFX_RC6_MSB _MMIO(0xC24)
> +#define GEN12_GT_GFX_RC6_MSB_MASK REG_GENMASK(23, 0)
> +
> /* RPM unit config (Gen8+) */
> #define RPM_CONFIG0 _MMIO(0xd00)
> #define GEN9_RPM_CONFIG0_CRYSTAL_CLOCK_FREQ_SHIFT 3
> diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
> index f8d0523f4c18e..ee830c4027542 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
> @@ -816,6 +816,25 @@ u64 intel_rc6_residency_us(struct intel_rc6 *rc6, i915_reg_t reg)
> return DIV_ROUND_UP_ULL(intel_rc6_residency_ns(rc6, reg), 1000);
> }
>
> +u64 intel_rc6_rpm_unit_residency(struct intel_rc6 *rc6)
> +{
> + struct drm_i915_private *i915 = rc6_to_i915(rc6);
> + struct intel_gt *gt = rc6_to_gt(rc6);
> + intel_wakeref_t wakeref;
> + u64 lsb, msb, counter;
> +
> + with_intel_runtime_pm(gt->uncore->rpm, wakeref) {
> + lsb = intel_uncore_read(gt->uncore, GEN12_GT_GFX_RC6_LSB);
> + msb = intel_uncore_read(gt->uncore, GEN12_GT_GFX_RC6_MSB);
> + }
> +
> + drm_dbg(&i915->drm, "GT RC6 MSB=0x%x LSB=0x%x\n", (u32) msb, (u32) lsb);
> + msb = REG_FIELD_GET(GEN12_GT_GFX_RC6_MSB_MASK, (u32)msb);
> + counter = msb << 32 | lsb;
What about wrap?
I guess you can't use intel_uncore_read64_2x32 because there is
something present in bits 31-24?
Anyway, what is the unit here and why it is useful to put this in
debugfs (together with drm_dbg)? (Considering the value restarts on each
RC6 entry.)
Regards,
Tvrtko
> +
> + return counter;
> +}
> +
> #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
> #include "selftest_rc6.c"
> #endif
> diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.h b/drivers/gpu/drm/i915/gt/intel_rc6.h
> index b6fea71afc223..6fa0896756d47 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rc6.h
> +++ b/drivers/gpu/drm/i915/gt/intel_rc6.h
> @@ -23,5 +23,6 @@ void intel_rc6_disable(struct intel_rc6 *rc6);
>
> u64 intel_rc6_residency_ns(struct intel_rc6 *rc6, i915_reg_t reg);
> u64 intel_rc6_residency_us(struct intel_rc6 *rc6, i915_reg_t reg);
> +u64 intel_rc6_rpm_unit_residency(struct intel_rc6 *rc6);
>
> #endif /* INTEL_RC6_H */
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support
2022-09-26 8:45 [Intel-gfx] [PATCH] drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support Anshuman Gupta
` (2 preceding siblings ...)
2022-09-26 16:05 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
@ 2022-09-26 17:35 ` Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2022-09-26 17:35 UTC (permalink / raw)
To: Gupta, Anshuman; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 31662 bytes --]
== Series Details ==
Series: drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support
URL : https://patchwork.freedesktop.org/series/109041/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12182_full -> Patchwork_109041v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_109041v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_109041v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 12)
------------------------------
Additional (3): shard-rkl shard-dg1 shard-tglu
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109041v1_full:
### CI changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* boot:
- {shard-dg1}: NOTRUN -> ([FAIL][1], [FAIL][2], [FAIL][3], [FAIL][4], [FAIL][5], [FAIL][6], [FAIL][7], [FAIL][8], [FAIL][9], [FAIL][10], [FAIL][11], [FAIL][12], [FAIL][13], [FAIL][14], [FAIL][15], [FAIL][16], [FAIL][17], [FAIL][18], [FAIL][19], [FAIL][20], [FAIL][21], [FAIL][22]) ([i915#6785])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-15/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-15/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-15/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-16/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-16/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-16/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-17/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-17/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-17/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-18/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-18/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-18/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-18/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-19/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-19/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-19/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-13/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-13/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-13/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-14/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-14/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-dg1-14/boot.html
### IGT changes ###
#### Possible regressions ####
* igt@kms_atomic_transition@modeset-transition-nonblocking@1x-outputs:
- shard-tglb: [PASS][23] -> [INCOMPLETE][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-tglb1/igt@kms_atomic_transition@modeset-transition-nonblocking@1x-outputs.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb8/igt@kms_atomic_transition@modeset-transition-nonblocking@1x-outputs.html
* igt@kms_writeback@writeback-check-output:
- shard-tglb: NOTRUN -> [SKIP][25]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_writeback@writeback-check-output.html
Known issues
------------
Here are the changes found in Patchwork_109041v1_full that come from known issues:
### CI changes ###
### IGT changes ###
#### Issues hit ####
* igt@drm_read@fault-buffer:
- shard-apl: [PASS][26] -> [DMESG-WARN][27] ([i915#165] / [i915#62]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-apl8/igt@drm_read@fault-buffer.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl2/igt@drm_read@fault-buffer.html
* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [PASS][28] -> [SKIP][29] ([i915#4525]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb2/igt@gem_exec_balancer@parallel-out-fence.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb7/igt@gem_exec_balancer@parallel-out-fence.html
* igt@gem_exec_fair@basic-none@bcs0:
- shard-tglb: NOTRUN -> [FAIL][30] ([i915#2842]) +4 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@gem_exec_fair@basic-none@bcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [PASS][31] -> [FAIL][32] ([i915#2842])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-glk8/igt@gem_exec_fair@basic-pace@rcs0.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-glk9/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-iclb: [PASS][33] -> [FAIL][34] ([i915#2842])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb7/igt@gem_exec_fair@basic-pace@vecs0.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb6/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_lmem_swapping@heavy-multi:
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#4613])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@gem_lmem_swapping@heavy-multi.html
* igt@gem_render_copy@linear-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][36] ([i915#768])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb6/igt@gem_render_copy@linear-to-vebox-yf-tiled.html
* igt@gem_workarounds@suspend-resume:
- shard-apl: [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-apl7/igt@gem_workarounds@suspend-resume.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl1/igt@gem_workarounds@suspend-resume.html
* igt@gen9_exec_parse@bb-start-param:
- shard-tglb: NOTRUN -> [SKIP][39] ([i915#2527] / [i915#2856])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@gen9_exec_parse@bb-start-param.html
* igt@gen9_exec_parse@shadow-peek:
- shard-iclb: NOTRUN -> [SKIP][40] ([i915#2856])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb6/igt@gen9_exec_parse@shadow-peek.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][41] -> [FAIL][42] ([i915#3989] / [i915#454])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- shard-tglb: NOTRUN -> [WARN][43] ([i915#2681]) +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#5286])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_big_fb@4-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-iclb: NOTRUN -> [SKIP][45] ([i915#5286])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb6/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#110723])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb6/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][47] ([fdo#111615]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180.html
* igt@kms_big_joiner@invalid-modeset:
- shard-tglb: NOTRUN -> [SKIP][48] ([i915#2705])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_big_joiner@invalid-modeset.html
* igt@kms_ccs@pipe-c-bad-pixel-format-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#6095]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_ccs@pipe-c-bad-pixel-format-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#3886]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl7/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][51] ([i915#3689] / [i915#6095])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109278]) +7 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb6/igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][53] ([i915#3689]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_ccs@pipe-d-crc-primary-basic-4_tiled_dg2_mc_ccs.html
* igt@kms_chamelium@dp-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl7/igt@kms_chamelium@dp-edid-change-during-suspend.html
* igt@kms_chamelium@hdmi-crc-multiple:
- shard-iclb: NOTRUN -> [SKIP][55] ([fdo#109284] / [fdo#111827]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb6/igt@kms_chamelium@hdmi-crc-multiple.html
* igt@kms_chamelium@vga-hpd-enable-disable-mode:
- shard-tglb: NOTRUN -> [SKIP][56] ([fdo#109284] / [fdo#111827]) +2 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_chamelium@vga-hpd-enable-disable-mode.html
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-tglb: NOTRUN -> [SKIP][57] ([i915#3116] / [i915#3299])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_content_protection@dp-mst-lic-type-1.html
* igt@kms_cursor_crc@cursor-onscreen-512x512:
- shard-tglb: NOTRUN -> [SKIP][58] ([i915#3359])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_cursor_crc@cursor-onscreen-512x512.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-tglb: NOTRUN -> [SKIP][59] ([fdo#109274] / [fdo#111825])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_cursor_legacy@cursorb-vs-flipb@legacy:
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109274]) +6 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb6/igt@kms_cursor_legacy@cursorb-vs-flipb@legacy.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][61] -> [DMESG-WARN][62] ([i915#165] / [i915#180] / [i915#1982] / [i915#62])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-apl8/igt@kms_fbcon_fbt@fbc-suspend.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl2/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-fences-interruptible:
- shard-tglb: NOTRUN -> [SKIP][63] ([fdo#109274] / [fdo#111825] / [i915#3637])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_flip@2x-flip-vs-fences-interruptible.html
* igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-upscaling@pipe-a-valid-mode:
- shard-apl: [PASS][64] -> [DMESG-WARN][65] ([i915#165] / [i915#180] / [i915#62]) +3 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-apl8/igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-upscaling@pipe-a-valid-mode.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl2/igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][66] ([i915#2672] / [i915#3555])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][67] -> [SKIP][68] ([i915#3555])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][69] ([i915#2587] / [i915#2672]) +4 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb4/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#2587] / [i915#2672])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][71] ([i915#2672]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][72] ([i915#3555]) +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][73] ([i915#6497]) +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109280]) +5 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-pgflip-blt:
- shard-tglb: NOTRUN -> [SKIP][75] ([fdo#109280] / [fdo#111825]) +7 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-pgflip-blt.html
* igt@kms_invalid_mode@clock-too-high@dp-1-pipe-c:
- shard-apl: [PASS][76] -> [DMESG-WARN][77] ([i915#165] / [i915#180])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-apl8/igt@kms_invalid_mode@clock-too-high@dp-1-pipe-c.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl2/igt@kms_invalid_mode@clock-too-high@dp-1-pipe-c.html
* igt@kms_plane_lowres@tiling-none@pipe-c-edp-1:
- shard-tglb: NOTRUN -> [SKIP][78] ([i915#3536]) +3 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_plane_lowres@tiling-none@pipe-c-edp-1.html
* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-c-dp-1:
- shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271]) +46 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl7/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-c-dp-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1:
- shard-iclb: [PASS][80] -> [SKIP][81] ([i915#5235]) +5 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb5/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-c-edp-1.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#658])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl7/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-tglb: NOTRUN -> [FAIL][83] ([i915#132] / [i915#3467])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][84] -> [SKIP][85] ([fdo#109441]) +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb7/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglb: [PASS][86] -> [SKIP][87] ([i915#5519])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-tglb5/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb1/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270:
- shard-tglb: NOTRUN -> [SKIP][88] ([fdo#111615] / [i915#5289])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb2/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270.html
* igt@perf@stress-open-close:
- shard-glk: [PASS][89] -> [INCOMPLETE][90] ([i915#5213])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-glk1/igt@perf@stress-open-close.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-glk8/igt@perf@stress-open-close.html
* igt@prime_udl:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109291])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb6/igt@prime_udl.html
* igt@sysfs_clients@sema-50:
- shard-iclb: NOTRUN -> [SKIP][92] ([i915#2994])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb6/igt@sysfs_clients@sema-50.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [FAIL][93] ([i915#6268]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-tglb5/igt@gem_ctx_exec@basic-nohangcheck.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-tglb1/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [SKIP][95] ([i915#4525]) -> [PASS][96] +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb3/igt@gem_exec_balancer@parallel-bb-first.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb4/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][97] ([i915#2842]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl8/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [FAIL][99] ([i915#6537]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-apl8/igt@i915_pm_rps@engine-order.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl3/igt@i915_pm_rps@engine-order.html
* igt@i915_suspend@forcewake:
- shard-apl: [DMESG-WARN][101] ([i915#180]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-apl3/igt@i915_suspend@forcewake.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl7/igt@i915_suspend@forcewake.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [SKIP][103] ([i915#3555]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling@pipe-a-default-mode.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling@pipe-a-default-mode.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [SKIP][105] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb5/igt@kms_psr2_su@frontbuffer-xrgb8888.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb2/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][107] ([fdo#109441]) -> [PASS][108] +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb8/igt@kms_psr@psr2_cursor_plane_onoff.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [SKIP][109] ([i915#4525]) -> [FAIL][110] ([i915#6117])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb8/igt@gem_exec_balancer@parallel-ordering.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb4/igt@gem_exec_balancer@parallel-ordering.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][111] ([i915#658]) -> [SKIP][112] ([i915#588])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb3/igt@i915_pm_dc@dc3co-vpb-simulation.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_rc6_residency@rc6-idle@bcs0:
- shard-iclb: [WARN][113] ([i915#2684]) -> [FAIL][114] ([i915#2684])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb4/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][115] ([i915#658]) -> [SKIP][116] ([i915#2920]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb8/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][117] ([i915#2920]) -> [SKIP][118] ([fdo#111068] / [i915#658])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb7/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: [SKIP][119] ([fdo#111068] / [i915#658]) -> [SKIP][120] ([i915#2920])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-iclb3/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@runner@aborted:
- shard-apl: ([FAIL][121], [FAIL][122], [FAIL][123]) ([i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-apl3/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-apl6/igt@runner@aborted.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12182/shard-apl1/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl1/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl3/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl2/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl7/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/shard-apl8/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6785]: https://gitlab.freedesktop.org/drm/intel/issues/6785
[i915#6928]: https://gitlab.freedesktop.org/drm/intel/issues/6928
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
Build changes
-------------
* Linux: CI_DRM_12182 -> Patchwork_109041v1
CI-20190529: 20190529
CI_DRM_12182: 8ad031bd195081f699414339ac21fa46dd0b8e2d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6663: 5e232c77cd762147e0882c337a984121fabb1c75 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109041v1: 8ad031bd195081f699414339ac21fa46dd0b8e2d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109041v1/index.html
[-- Attachment #2: Type: text/html, Size: 37898 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support
2022-09-26 16:05 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
@ 2022-09-27 6:48 ` Gupta, Anshuman
2022-09-27 7:36 ` Tvrtko Ursulin
0 siblings, 1 reply; 7+ messages in thread
From: Gupta, Anshuman @ 2022-09-27 6:48 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx
> -----Original Message-----
> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> Sent: Monday, September 26, 2022 9:35 PM
> To: Gupta, Anshuman <anshuman.gupta@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB}
> Residency counter support
>
>
> On 26/09/2022 09:45, Anshuman Gupta wrote:
> > Adding support in drpc show debugfs to print the GT RPM Unit RC6
> > residency. This GTC6_RESIDENCY_{LSB, MSB} will only increment when GT
> > will be RC6. Therefore these register will get reset at RC6 exit and
> > will start incrementing on next RC6 entry.
> >
> > BSpec: 64977
> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 5 +++++
> > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 5 +++++
> > drivers/gpu/drm/i915/gt/intel_rc6.c | 19 +++++++++++++++++++
> > drivers/gpu/drm/i915/gt/intel_rc6.h | 1 +
> > 4 files changed, 30 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> > b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> > index 10f680dbd7b62..59b6cc49464e9 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> > @@ -195,6 +195,11 @@ static int gen6_drpc(struct seq_file *m)
> > print_rc6_res(m, "RC6 \"Locked to RPn\" residency since boot:",
> > GEN6_GT_GFX_RC6_LOCKED);
> > print_rc6_res(m, "RC6 residency since boot:", GEN6_GT_GFX_RC6);
> > +
> > + if (GRAPHICS_VER(i915) >= 12)
> > + seq_printf(m, "GT RC6 RPM Unit Residency since last RC6 exit:
> 0x%llx\n",
> > + intel_rc6_rpm_unit_residency(>->rc6));
> > +
> > print_rc6_res(m, "RC6+ residency since boot:", GEN6_GT_GFX_RC6p);
> > print_rc6_res(m, "RC6++ residency since boot:", GEN6_GT_GFX_RC6pp);
> >
> > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> > b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> > index 7f79bbf978284..7715d0aeffc9d 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> > +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
> > @@ -8,6 +8,11 @@
> >
> > #include "i915_reg_defs.h"
> >
> > +/* GT RPM RC6 counter */
> > +#define GEN12_GT_GFX_RC6_LSB _MMIO(0xC20)
> > +#define GEN12_GT_GFX_RC6_MSB _MMIO(0xC24)
> > +#define GEN12_GT_GFX_RC6_MSB_MASK REG_GENMASK(23, 0)
> > +
> > /* RPM unit config (Gen8+) */
> > #define RPM_CONFIG0 _MMIO(0xd00)
> > #define GEN9_RPM_CONFIG0_CRYSTAL_CLOCK_FREQ_SHIFT 3
> > diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c
> > b/drivers/gpu/drm/i915/gt/intel_rc6.c
> > index f8d0523f4c18e..ee830c4027542 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
> > @@ -816,6 +816,25 @@ u64 intel_rc6_residency_us(struct intel_rc6 *rc6,
> i915_reg_t reg)
> > return DIV_ROUND_UP_ULL(intel_rc6_residency_ns(rc6, reg), 1000);
> > }
> >
> > +u64 intel_rc6_rpm_unit_residency(struct intel_rc6 *rc6) {
> > + struct drm_i915_private *i915 = rc6_to_i915(rc6);
> > + struct intel_gt *gt = rc6_to_gt(rc6);
> > + intel_wakeref_t wakeref;
> > + u64 lsb, msb, counter;
> > +
> > + with_intel_runtime_pm(gt->uncore->rpm, wakeref) {
> > + lsb = intel_uncore_read(gt->uncore, GEN12_GT_GFX_RC6_LSB);
> > + msb = intel_uncore_read(gt->uncore,
> GEN12_GT_GFX_RC6_MSB);
> > + }
> > +
> > + drm_dbg(&i915->drm, "GT RC6 MSB=0x%x LSB=0x%x\n", (u32) msb,
> (u32) lsb);
> > + msb = REG_FIELD_GET(GEN12_GT_GFX_RC6_MSB_MASK, (u32)msb);
> > + counter = msb << 32 | lsb;
>
> What about wrap?
Wrap is not practically possible here, as this is 56 bit counter and this will get reset on each rc6 exit.
>
> I guess you can't use intel_uncore_read64_2x32 because there is something
> present in bits 31-24?
>
> Anyway, what is the unit here and why it is useful to put this in debugfs (together
> with drm_dbg)? (Considering the value restarts on each
> RC6 entry.)
I will remove the drm_dbg.
This can be useful to know about rc6 exit from debugfs.
Actual frequency this counter is ticking is not really known from spec.
I am still trying to figuring out that. Currently these are just raw count from reg.
Thanks,
Anshuman.
>
> Regards,
>
> Tvrtko
>
> > +
> > + return counter;
> > +}
> > +
> > #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
> > #include "selftest_rc6.c"
> > #endif
> > diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.h
> > b/drivers/gpu/drm/i915/gt/intel_rc6.h
> > index b6fea71afc223..6fa0896756d47 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_rc6.h
> > +++ b/drivers/gpu/drm/i915/gt/intel_rc6.h
> > @@ -23,5 +23,6 @@ void intel_rc6_disable(struct intel_rc6 *rc6);
> >
> > u64 intel_rc6_residency_ns(struct intel_rc6 *rc6, i915_reg_t reg);
> > u64 intel_rc6_residency_us(struct intel_rc6 *rc6, i915_reg_t reg);
> > +u64 intel_rc6_rpm_unit_residency(struct intel_rc6 *rc6);
> >
> > #endif /* INTEL_RC6_H */
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support
2022-09-27 6:48 ` Gupta, Anshuman
@ 2022-09-27 7:36 ` Tvrtko Ursulin
0 siblings, 0 replies; 7+ messages in thread
From: Tvrtko Ursulin @ 2022-09-27 7:36 UTC (permalink / raw)
To: Gupta, Anshuman, intel-gfx
On 27/09/2022 07:48, Gupta, Anshuman wrote:
>
>> -----Original Message-----
>> From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>> Sent: Monday, September 26, 2022 9:35 PM
>> To: Gupta, Anshuman <anshuman.gupta@intel.com>; intel-
>> gfx@lists.freedesktop.org
>> Subject: Re: [Intel-gfx] [PATCH] drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB}
>> Residency counter support
>>
>>
>> On 26/09/2022 09:45, Anshuman Gupta wrote:
>>> Adding support in drpc show debugfs to print the GT RPM Unit RC6
>>> residency. This GTC6_RESIDENCY_{LSB, MSB} will only increment when GT
>>> will be RC6. Therefore these register will get reset at RC6 exit and
>>> will start incrementing on next RC6 entry.
>>>
>>> BSpec: 64977
>>> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 5 +++++
>>> drivers/gpu/drm/i915/gt/intel_gt_regs.h | 5 +++++
>>> drivers/gpu/drm/i915/gt/intel_rc6.c | 19 +++++++++++++++++++
>>> drivers/gpu/drm/i915/gt/intel_rc6.h | 1 +
>>> 4 files changed, 30 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
>>> b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
>>> index 10f680dbd7b62..59b6cc49464e9 100644
>>> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
>>> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
>>> @@ -195,6 +195,11 @@ static int gen6_drpc(struct seq_file *m)
>>> print_rc6_res(m, "RC6 \"Locked to RPn\" residency since boot:",
>>> GEN6_GT_GFX_RC6_LOCKED);
>>> print_rc6_res(m, "RC6 residency since boot:", GEN6_GT_GFX_RC6);
>>> +
>>> + if (GRAPHICS_VER(i915) >= 12)
>>> + seq_printf(m, "GT RC6 RPM Unit Residency since last RC6 exit:
>> 0x%llx\n",
>>> + intel_rc6_rpm_unit_residency(>->rc6));
>>> +
>>> print_rc6_res(m, "RC6+ residency since boot:", GEN6_GT_GFX_RC6p);
>>> print_rc6_res(m, "RC6++ residency since boot:", GEN6_GT_GFX_RC6pp);
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
>>> b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
>>> index 7f79bbf978284..7715d0aeffc9d 100644
>>> --- a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
>>> +++ b/drivers/gpu/drm/i915/gt/intel_gt_regs.h
>>> @@ -8,6 +8,11 @@
>>>
>>> #include "i915_reg_defs.h"
>>>
>>> +/* GT RPM RC6 counter */
>>> +#define GEN12_GT_GFX_RC6_LSB _MMIO(0xC20)
>>> +#define GEN12_GT_GFX_RC6_MSB _MMIO(0xC24)
>>> +#define GEN12_GT_GFX_RC6_MSB_MASK REG_GENMASK(23, 0)
>>> +
>>> /* RPM unit config (Gen8+) */
>>> #define RPM_CONFIG0 _MMIO(0xd00)
>>> #define GEN9_RPM_CONFIG0_CRYSTAL_CLOCK_FREQ_SHIFT 3
>>> diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c
>>> b/drivers/gpu/drm/i915/gt/intel_rc6.c
>>> index f8d0523f4c18e..ee830c4027542 100644
>>> --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
>>> +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
>>> @@ -816,6 +816,25 @@ u64 intel_rc6_residency_us(struct intel_rc6 *rc6,
>> i915_reg_t reg)
>>> return DIV_ROUND_UP_ULL(intel_rc6_residency_ns(rc6, reg), 1000);
>>> }
>>>
>>> +u64 intel_rc6_rpm_unit_residency(struct intel_rc6 *rc6) {
>>> + struct drm_i915_private *i915 = rc6_to_i915(rc6);
>>> + struct intel_gt *gt = rc6_to_gt(rc6);
>>> + intel_wakeref_t wakeref;
>>> + u64 lsb, msb, counter;
>>> +
>>> + with_intel_runtime_pm(gt->uncore->rpm, wakeref) {
>>> + lsb = intel_uncore_read(gt->uncore, GEN12_GT_GFX_RC6_LSB);
>>> + msb = intel_uncore_read(gt->uncore,
>> GEN12_GT_GFX_RC6_MSB);
>>> + }
>>> +
>>> + drm_dbg(&i915->drm, "GT RC6 MSB=0x%x LSB=0x%x\n", (u32) msb,
>> (u32) lsb);
>>> + msb = REG_FIELD_GET(GEN12_GT_GFX_RC6_MSB_MASK, (u32)msb);
>>> + counter = msb << 32 | lsb;
>>
>> What about wrap?
> Wrap is not practically possible here, as this is 56 bit counter and this will get reset on each rc6 exit.
I primarily was thinking about LSB wrap, see the repeat of the loop
intel_uncore_read64_2x32 does to handle it. But as you say increment
period is unknown...
>> I guess you can't use intel_uncore_read64_2x32 because there is something
>> present in bits 31-24?
>>
>> Anyway, what is the unit here and why it is useful to put this in debugfs (together
>> with drm_dbg)? (Considering the value restarts on each
>> RC6 entry.)
> I will remove the drm_dbg.
> This can be useful to know about rc6 exit from debugfs.
>
> Actual frequency this counter is ticking is not really known from spec.
> I am still trying to figuring out that. Currently these are just raw count from reg.
... IMO too many unknowns to justify adding this. Yes it's only debugfs
but (rapid) polling on a debugfs register to notice some internal state
transitions feels over the top. Would intel_reg read perhaps be enough
to whatever use case you have in mind?
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-27 7:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 8:45 [Intel-gfx] [PATCH] drm/i915/rc6: GTC6_RESIDENCY_{LSB, MSB} Residency counter support Anshuman Gupta
2022-09-26 13:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-09-26 14:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-26 16:05 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
2022-09-27 6:48 ` Gupta, Anshuman
2022-09-27 7:36 ` Tvrtko Ursulin
2022-09-26 17:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.