All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v4] i915/i915_hangman: fail only after freeing spinners
@ 2022-08-30  8:48 Kamil Konieczny
  2022-08-30  9:35 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/i915_hangman: fail only after freeing spinners (rev4) Patchwork
                   ` (10 more replies)
  0 siblings, 11 replies; 20+ messages in thread
From: Kamil Konieczny @ 2022-08-30  8:48 UTC (permalink / raw)
  To: igt-dev

Failed checks may cause following tests fail, so check for
errors only after all spinners are released.

v2: be verbose about what failed (Chris)
v3: simplify declaration, add separate wait var (Zbigniew)
v4: removed bitshift (Zbigniew), added storing last not
    expected error for fence stat

Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 tests/i915/i915_hangman.c | 34 ++++++++++++++++++++++++++++------
 1 file changed, 28 insertions(+), 6 deletions(-)

diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c
index c7d69fdd..ddbe1067 100644
--- a/tests/i915/i915_hangman.c
+++ b/tests/i915/i915_hangman.c
@@ -295,6 +295,20 @@ static void context_unban(int fd, unsigned ctx)
 	gem_context_set_param(fd, &param);
 }
 
+static void chk_err(int *dst, int err, int expected)
+{
+	if (err == expected)
+		return;
+
+	*dst = err;
+}
+
+#define ERR_HANG_WAIT  0
+#define ERR_HANG_STAT  1
+#define ERR_FENCE_BUSY 2
+#define ERR_FENCE_END  3
+#define ERR_FENCE_STAT 4
+
 static void
 test_engine_hang(const intel_ctx_t *ctx,
 		 const struct intel_execution_engine2 *e, unsigned int flags)
@@ -305,6 +319,7 @@ test_engine_hang(const intel_ctx_t *ctx,
 	IGT_LIST_HEAD(list);
 	uint64_t ahnd = get_reloc_ahnd(device, ctx->id), ahndN;
 	int num_ctx;
+	int err[ERR_FENCE_STAT + 1];
 
 	igt_skip_on(flags & IGT_SPIN_INVALID_CS &&
 		    gem_engine_has_cmdparser(device, &ctx->cfg, e->flags));
@@ -340,18 +355,20 @@ test_engine_hang(const intel_ctx_t *ctx,
 				      flags));
 
 	/* Wait for the hangcheck to terminate the hanger */
-	igt_assert(sync_fence_wait(spin->out_fence, 30000) == 0); /* 30s */
-	igt_assert_eq(sync_fence_status(spin->out_fence), -EIO);
+	err[ERR_HANG_WAIT] = sync_fence_wait(spin->out_fence, 30000); /* 30s */
+	err[ERR_HANG_STAT] = sync_fence_status(spin->out_fence); /* -EIO */
 	igt_spin_free(device, spin);
 
 	/* But no other engines/clients should be affected */
+	err[ERR_FENCE_BUSY] = -ETIME;
+	err[ERR_FENCE_END] = 0;
+	err[ERR_FENCE_STAT] = 1;
 	igt_list_for_each_entry_safe(spin, next, &list, link) {
 		ahndN = spin->opts.ahnd;
-		igt_assert(sync_fence_wait(spin->out_fence, 0) == -ETIME);
+		chk_err(err+ERR_FENCE_BUSY, sync_fence_wait(spin->out_fence, 0), -ETIME);
 		igt_spin_end(spin);
-
-		igt_assert(sync_fence_wait(spin->out_fence, 500) == 0);
-		igt_assert_eq(sync_fence_status(spin->out_fence), 1);
+		chk_err(err+ERR_FENCE_END, sync_fence_wait(spin->out_fence, 500), 0);
+		chk_err(err+ERR_FENCE_STAT, sync_fence_status(spin->out_fence), 1);
 		igt_spin_free(device, spin);
 		put_ahnd(ahndN);
 	}
@@ -360,6 +377,11 @@ test_engine_hang(const intel_ctx_t *ctx,
 	while (num_ctx)
 		intel_ctx_destroy(device, local_ctx[--num_ctx]);
 
+	igt_assert_f(err[ERR_HANG_WAIT] == 0, "hanged spinner wait failed\n");
+	igt_assert_f(err[ERR_HANG_STAT] == -EIO, "hanged spinner failed\n");
+	igt_assert_f(err[ERR_FENCE_BUSY] == -ETIME, "background spinner not busy\n");
+	igt_assert_f(err[ERR_FENCE_END] == 0, "background spinner not terminated\n");
+	igt_assert_f(err[ERR_FENCE_STAT] == 1, "background fence not signalled\n");
 	check_alive();
 }
 
-- 
2.34.1

^ permalink raw reply related	[flat|nested] 20+ messages in thread
end of thread, other threads:[~2022-10-04 16:17 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-30  8:48 [igt-dev] [PATCH i-g-t v4] i915/i915_hangman: fail only after freeing spinners Kamil Konieczny
2022-08-30  9:35 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/i915_hangman: fail only after freeing spinners (rev4) Patchwork
2022-08-30 17:17 ` [igt-dev] [PATCH i-g-t v4] i915/i915_hangman: fail only after freeing spinners Zbigniew Kempczyński
2022-08-31 13:21 ` [igt-dev] ✗ Fi.CI.IGT: failure for i915/i915_hangman: fail only after freeing spinners (rev4) Patchwork
2022-09-01 11:26   ` Kamil Konieczny
2022-09-02  7:58     ` Illipilli, TejasreeX
2022-09-02  5:43 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2022-09-29  8:31 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/i915_hangman: fail only after freeing spinners (rev5) Patchwork
2022-09-30  5:47 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-30  7:11   ` Kamil Konieczny
2022-09-30 17:26     ` Vudum, Lakshminarayana
2022-09-30 16:56 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-09-30 16:59 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-10-01 13:37 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-03 11:46   ` Kamil Konieczny
2022-10-03 15:59     ` Vudum, Lakshminarayana
2022-10-04  8:18       ` Kamil Konieczny
2022-10-04 16:17         ` Vudum, Lakshminarayana
2022-10-03 15:35 ` Patchwork
2022-10-04 15:49 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.