* [PATCH] wifi: ath11k: Send PME message during wakeup from D3cold
@ 2022-10-10 3:32 ` Baochen Qiang
0 siblings, 0 replies; 6+ messages in thread
From: Baochen Qiang @ 2022-10-10 3:32 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless
We are seeing system stuck on some specific platforms due to
WLAN chip fails to wakeup from D3cold state.
With this flag, firmware will send PME message during wakeup
and this issue is gone.
Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
---
drivers/net/wireless/ath/ath11k/qmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
index 84e3abecbdac..145f20a681bd 100644
--- a/drivers/net/wireless/ath/ath11k/qmi.c
+++ b/drivers/net/wireless/ath/ath11k/qmi.c
@@ -19,6 +19,7 @@
#define SLEEP_CLOCK_SELECT_INTERNAL_BIT 0x02
#define HOST_CSTATE_BIT 0x04
#define PLATFORM_CAP_PCIE_GLOBAL_RESET 0x08
+#define PLATFORM_CAP_PCIE_PME_D3COLD 0x10
#define FW_BUILD_ID_MASK "QC_IMAGE_VERSION_STRING="
@@ -1752,6 +1753,8 @@ static int ath11k_qmi_host_cap_send(struct ath11k_base *ab)
if (ab->hw_params.global_reset)
req.nm_modem |= PLATFORM_CAP_PCIE_GLOBAL_RESET;
+ req.nm_modem |= PLATFORM_CAP_PCIE_PME_D3COLD;
+
ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi host cap request\n");
ret = qmi_txn_init(&ab->qmi.handle, &txn,
base-commit: 023baf1318ef21442fab3842bf03883bc81223e0
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] wifi: ath11k: Send PME message during wakeup from D3cold
@ 2022-10-10 3:32 ` Baochen Qiang
0 siblings, 0 replies; 6+ messages in thread
From: Baochen Qiang @ 2022-10-10 3:32 UTC (permalink / raw)
To: ath11k; +Cc: linux-wireless
We are seeing system stuck on some specific platforms due to
WLAN chip fails to wakeup from D3cold state.
With this flag, firmware will send PME message during wakeup
and this issue is gone.
Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
---
drivers/net/wireless/ath/ath11k/qmi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
index 84e3abecbdac..145f20a681bd 100644
--- a/drivers/net/wireless/ath/ath11k/qmi.c
+++ b/drivers/net/wireless/ath/ath11k/qmi.c
@@ -19,6 +19,7 @@
#define SLEEP_CLOCK_SELECT_INTERNAL_BIT 0x02
#define HOST_CSTATE_BIT 0x04
#define PLATFORM_CAP_PCIE_GLOBAL_RESET 0x08
+#define PLATFORM_CAP_PCIE_PME_D3COLD 0x10
#define FW_BUILD_ID_MASK "QC_IMAGE_VERSION_STRING="
@@ -1752,6 +1753,8 @@ static int ath11k_qmi_host_cap_send(struct ath11k_base *ab)
if (ab->hw_params.global_reset)
req.nm_modem |= PLATFORM_CAP_PCIE_GLOBAL_RESET;
+ req.nm_modem |= PLATFORM_CAP_PCIE_PME_D3COLD;
+
ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi host cap request\n");
ret = qmi_txn_init(&ab->qmi.handle, &txn,
base-commit: 023baf1318ef21442fab3842bf03883bc81223e0
--
2.25.1
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] wifi: ath11k: Send PME message during wakeup from D3cold
2022-10-10 3:32 ` Baochen Qiang
@ 2022-10-11 7:49 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2022-10-11 7:49 UTC (permalink / raw)
To: Baochen Qiang; +Cc: ath11k, linux-wireless
Baochen Qiang <quic_bqiang@quicinc.com> wrote:
> We are seeing system stuck on some specific platforms due to
> WLAN chip fails to wakeup from D3cold state.
>
> With this flag, firmware will send PME message during wakeup
> and this issue is gone.
>
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
The firmware you are using is old, please update to the latest one:
https://github.com/kvalo/ath11k-firmware/tree/master/WCN6855/hw2.0/1.1/WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.16
It's very important that the testing happens on latest components.
No need to resend because of this.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20221010033237.415478-1-quic_bqiang@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wifi: ath11k: Send PME message during wakeup from D3cold
@ 2022-10-11 7:49 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2022-10-11 7:49 UTC (permalink / raw)
To: Baochen Qiang; +Cc: ath11k, linux-wireless
Baochen Qiang <quic_bqiang@quicinc.com> wrote:
> We are seeing system stuck on some specific platforms due to
> WLAN chip fails to wakeup from D3cold state.
>
> With this flag, firmware will send PME message during wakeup
> and this issue is gone.
>
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
The firmware you are using is old, please update to the latest one:
https://github.com/kvalo/ath11k-firmware/tree/master/WCN6855/hw2.0/1.1/WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.16
It's very important that the testing happens on latest components.
No need to resend because of this.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20221010033237.415478-1-quic_bqiang@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wifi: ath11k: Send PME message during wakeup from D3cold
2022-10-10 3:32 ` Baochen Qiang
@ 2022-10-12 6:42 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2022-10-12 6:42 UTC (permalink / raw)
To: Baochen Qiang; +Cc: ath11k, linux-wireless
Baochen Qiang <quic_bqiang@quicinc.com> wrote:
> We are seeing system stuck on some specific platforms due to
> WLAN chip fails to wakeup from D3cold state.
>
> With this flag, firmware will send PME message during wakeup
> and this issue is gone.
>
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
>
> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
3f9b09ccf7d5 wifi: ath11k: Send PME message during wakeup from D3cold
--
https://patchwork.kernel.org/project/linux-wireless/patch/20221010033237.415478-1-quic_bqiang@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wifi: ath11k: Send PME message during wakeup from D3cold
@ 2022-10-12 6:42 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2022-10-12 6:42 UTC (permalink / raw)
To: Baochen Qiang; +Cc: ath11k, linux-wireless
Baochen Qiang <quic_bqiang@quicinc.com> wrote:
> We are seeing system stuck on some specific platforms due to
> WLAN chip fails to wakeup from D3cold state.
>
> With this flag, firmware will send PME message during wakeup
> and this issue is gone.
>
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
>
> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
3f9b09ccf7d5 wifi: ath11k: Send PME message during wakeup from D3cold
--
https://patchwork.kernel.org/project/linux-wireless/patch/20221010033237.415478-1-quic_bqiang@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-12 6:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-10 3:32 [PATCH] wifi: ath11k: Send PME message during wakeup from D3cold Baochen Qiang
2022-10-10 3:32 ` Baochen Qiang
2022-10-11 7:49 ` Kalle Valo
2022-10-11 7:49 ` Kalle Valo
2022-10-12 6:42 ` Kalle Valo
2022-10-12 6:42 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.