From: Rob Herring <robh@kernel.org>
To: Sasha Finkelstein <fnkl.kernel@gmail.com>
Cc: krzysztof.kozlowski+dt@linaro.org, sven@svenpeter.dev,
linux-kernel@vger.kernel.org, thierry.reding@gmail.com,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
asahi@lists.linux.dev, marcan@marcan.st, alyssa@rosenzweig.io
Subject: Re: [PATCH 1/4] dt-bindings: pwm: Add Apple PWM controller
Date: Fri, 28 Oct 2022 14:04:38 -0500 [thread overview]
Message-ID: <166698381253.2093680.6251640066817102720.robh@kernel.org> (raw)
In-Reply-To: <20221028165215.43662-2-fnkl.kernel@gmail.com>
On Fri, 28 Oct 2022 19:52:13 +0300, Sasha Finkelstein wrote:
> Apple SoCs such as the M1 contain a PWM controller used
> among other things to control the keyboard backlight.
>
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
> ---
> .../devicetree/bindings/pwm/pwm-apple.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-apple.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.example.dtb: fpwm@235044000: compatible:0: 'apple,s5l-fpwm' is not one of ['apple,t8103-fpwm', 'apple,t6000-fpwm', 'apple,t8112-fpwm']
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.example.dtb: fpwm@235044000: compatible: ['apple,s5l-fpwm'] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.example.dtb: fpwm@235044000: reg: [[2, 889470976], [0, 16384]] is too long
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Sasha Finkelstein <fnkl.kernel@gmail.com>
Cc: krzysztof.kozlowski+dt@linaro.org, sven@svenpeter.dev,
linux-kernel@vger.kernel.org, thierry.reding@gmail.com,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
asahi@lists.linux.dev, marcan@marcan.st, alyssa@rosenzweig.io
Subject: Re: [PATCH 1/4] dt-bindings: pwm: Add Apple PWM controller
Date: Fri, 28 Oct 2022 14:04:38 -0500 [thread overview]
Message-ID: <166698381253.2093680.6251640066817102720.robh@kernel.org> (raw)
In-Reply-To: <20221028165215.43662-2-fnkl.kernel@gmail.com>
On Fri, 28 Oct 2022 19:52:13 +0300, Sasha Finkelstein wrote:
> Apple SoCs such as the M1 contain a PWM controller used
> among other things to control the keyboard backlight.
>
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
> ---
> .../devicetree/bindings/pwm/pwm-apple.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-apple.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.example.dtb: fpwm@235044000: compatible:0: 'apple,s5l-fpwm' is not one of ['apple,t8103-fpwm', 'apple,t6000-fpwm', 'apple,t8112-fpwm']
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.example.dtb: fpwm@235044000: compatible: ['apple,s5l-fpwm'] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.example.dtb: fpwm@235044000: reg: [[2, 889470976], [0, 16384]] is too long
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-28 19:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 16:52 [PATCH 0/4] PWM and keyboard backlight driver for ARM Macs Sasha Finkelstein
2022-10-28 16:52 ` Sasha Finkelstein
2022-10-28 16:52 ` [PATCH 1/4] dt-bindings: pwm: Add Apple PWM controller Sasha Finkelstein
2022-10-28 16:52 ` Sasha Finkelstein
2022-10-28 17:53 ` Krzysztof Kozlowski
2022-10-28 17:53 ` Krzysztof Kozlowski
2022-10-28 18:44 ` Sasha Finkelstein
2022-10-28 18:44 ` Sasha Finkelstein
2022-10-28 19:04 ` Rob Herring [this message]
2022-10-28 19:04 ` Rob Herring
2022-10-28 19:47 ` Krzysztof Kozlowski
2022-10-28 19:47 ` Krzysztof Kozlowski
2022-10-28 16:52 ` [PATCH 2/4] " Sasha Finkelstein
2022-10-28 16:52 ` Sasha Finkelstein
2022-10-28 17:54 ` Krzysztof Kozlowski
2022-10-28 17:54 ` Krzysztof Kozlowski
2022-10-28 18:51 ` Sasha Finkelstein
2022-10-28 18:51 ` Sasha Finkelstein
2022-10-28 19:49 ` Krzysztof Kozlowski
2022-10-28 19:49 ` Krzysztof Kozlowski
2022-10-29 6:25 ` Hector Martin
2022-10-29 6:25 ` Hector Martin
2022-10-28 16:52 ` [PATCH 3/4] arm64: dts: apple: t8103: Add " Sasha Finkelstein
2022-10-28 16:52 ` Sasha Finkelstein
2022-10-28 17:56 ` Krzysztof Kozlowski
2022-10-28 17:56 ` Krzysztof Kozlowski
2022-10-28 16:52 ` [PATCH 4/4] MAINTAINERS: Add entries for Apple PWM driver Sasha Finkelstein
2022-10-28 16:52 ` Sasha Finkelstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166698381253.2093680.6251640066817102720.robh@kernel.org \
--to=robh@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=fnkl.kernel@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.