[PATCH v2 1/3] dt-bindings: mfd: qcom,spmi-pmic: support more types

[PATCH v2 1/3] dt-bindings: mfd: qcom,spmi-pmic: support more types

[Luca Weiss]

* 'adc@' is either spmi-iadc or spmi-vadc
* 'charger@' is either pm8941-charger or pm8941-coincell
* 'usb-vbus-regulator@' is usb-vbus-regulator
* 'vibrator@' is now in yaml format, so add it

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
Changes since v1:
* Change dcdc@ to usb-vbus-regulator@
* Link to pm8xxx-vib.yaml

 .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml  | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 777f2da52f1e..cf10d62ace54 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -105,7 +105,9 @@ properties:
 patternProperties:
   "^adc@[0-9a-f]+$":
     type: object
-    $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml#
+    oneOf:
+      - $ref: /schemas/iio/adc/qcom,spmi-iadc.yaml#
+      - $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml#
 
   "^adc-tm@[0-9a-f]+$":
     type: object
@@ -115,6 +117,12 @@ patternProperties:
     type: object
     additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec binding not converted yet
 
+  "^charger@[0-9a-f]+$":
+    type: object
+    oneOf:
+      - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
+      - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
+
   "extcon@[0-9a-f]+$":
     type: object
     $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
@@ -135,9 +143,13 @@ patternProperties:
     type: object
     $ref: /schemas/thermal/qcom,spmi-temp-alarm.yaml#
 
+  "^usb-vbus-regulator@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/regulator/qcom,usb-vbus-regulator.yaml#
+
   "^vibrator@[0-9a-f]+$":
     type: object
-    additionalProperties: true # FIXME qcom,pm8916-vib binding not converted yet
+    $ref: /schemas/input/qcom,pm8xxx-vib.yaml#
 
   "^mpps@[0-9a-f]+$":
     type: object
-- 
2.38.1

[PATCH v2 2/3] regulator: dt-bindings: qcom,usb-vbus-regulator: change node name

[Luca Weiss]

usb-vbus-regulator is a better generic node name than dcdc to change the
example to match.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
Changes in v2:
* New patch

 .../devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
index dbe78cd4adba..b1cff3adb21b 100644
--- a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
@@ -33,7 +33,7 @@ examples:
      pm8150b {
         #address-cells = <1>;
         #size-cells = <0>;
-        pm8150b_vbus: dcdc@1100 {
+        pm8150b_vbus: usb-vbus-regulator@1100 {
             compatible = "qcom,pm8150b-vbus-reg";
             reg = <0x1100>;
         };
-- 
2.38.1

[PATCH v2 3/3] arm64: dts: qcom: pm8150b: change vbus-regulator node name

[Luca Weiss]

Use the node name as now defined in the spmi-pmic bindings.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
Changes in v2:
* New patch

 arch/arm64/boot/dts/qcom/pm8150b.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
index cdded791d96e..66752cc063d6 100644
--- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
@@ -53,7 +53,7 @@ pon@800 {
 			status = "disabled";
 		};
 
-		pm8150b_vbus: dcdc@1100 {
+		pm8150b_vbus: usb-vbus-regulator@1100 {
 			compatible = "qcom,pm8150b-vbus-reg";
 			status = "disabled";
 			reg = <0x1100>;
-- 
2.38.1

Re: [PATCH v2 2/3] regulator: dt-bindings: qcom,usb-vbus-regulator: change node name

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

On Mon, Oct 31, 2022 at 06:39:32PM +0100, Luca Weiss wrote:
> usb-vbus-regulator is a better generic node name than dcdc to change the
> example to match.

You've not copied me on the rest of the series so I've no idea what's
going on with dependencies.  When sending a patch series it is important
to ensure that all the various maintainers understand what the
relationship between the patches as the expecation is that there will be
interdependencies.  Either copy everyone on the whole series or at least
copy them on the cover letter and explain what's going on.  If there are
no strong interdependencies then it's generally simplest to just send
the patches separately to avoid any possible confusion.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2 2/3] regulator: dt-bindings: qcom,usb-vbus-regulator: change node name

[Neil Armstrong]

Hi,

On 31/10/2022 18:39, Luca Weiss wrote:
> usb-vbus-regulator is a better generic node name than dcdc to change the
> example to match.

Subject is wrong, should be something like:
dt-bindings: regulator: qcom,usb-vbus-regulator: update example node name

> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> Changes in v2:
> * New patch
> 
>   .../devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml  | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
> index dbe78cd4adba..b1cff3adb21b 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
> @@ -33,7 +33,7 @@ examples:
>        pm8150b {
>           #address-cells = <1>;
>           #size-cells = <0>;
> -        pm8150b_vbus: dcdc@1100 {
> +        pm8150b_vbus: usb-vbus-regulator@1100 {
>               compatible = "qcom,pm8150b-vbus-reg";
>               reg = <0x1100>;
>           };

Thanks,
Neil

Re: [PATCH v2 3/3] arm64: dts: qcom: pm8150b: change vbus-regulator node name

[Neil Armstrong]

On 31/10/2022 18:39, Luca Weiss wrote:
> Use the node name as now defined in the spmi-pmic bindings.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> Changes in v2:
> * New patch
> 
>   arch/arm64/boot/dts/qcom/pm8150b.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8150b.dtsi b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> index cdded791d96e..66752cc063d6 100644
> --- a/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150b.dtsi
> @@ -53,7 +53,7 @@ pon@800 {
>   			status = "disabled";
>   		};
>   
> -		pm8150b_vbus: dcdc@1100 {
> +		pm8150b_vbus: usb-vbus-regulator@1100 {
>   			compatible = "qcom,pm8150b-vbus-reg";
>   			status = "disabled";
>   			reg = <0x1100>;


Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Re: [PATCH v2 2/3] regulator: dt-bindings: qcom,usb-vbus-regulator: change node name

[Luca Weiss]

Hi Neil,

On Mittwoch, 2. November 2022 11:38:29 CET Neil Armstrong wrote:
> Hi,
> 
> On 31/10/2022 18:39, Luca Weiss wrote:
> > usb-vbus-regulator is a better generic node name than dcdc to change the
> > example to match.
> 
> Subject is wrong, should be something like:
> dt-bindings: regulator: qcom,usb-vbus-regulator: update example node name

I've followed the prefix style of recent commits in
Documentation/devicetree/bindings/regulator/

475043fabe8c regulator: Fix qcom,spmi-regulator schema
b0de7fa70650 regulator: pca9450: Remove restrictions for regulator-name
4c7da3741804 regulator: Add missing type for 'regulator-microvolt-offset'
91de5eb17c10 regulator: pwm: Update Lee Jones' email address
044750573903 regulator: qcom,spmi-regulator: add PMP8074 PMIC
0b3bbd7646b0 regulator: qcom,spmi-regulator: Convert to dtschema
8cbb948a7cc2 regulator: dt-bindings: qcom,smd-rpm: Add PM8909
a9369fd316cf regulator: dt-bindings: Convert pwm-regulator to DT schema

Regards
Luca

Re: [PATCH v2 1/3] dt-bindings: mfd: qcom,spmi-pmic: support more types

[Rob Herring]

On Mon, 31 Oct 2022 18:39:31 +0100, Luca Weiss wrote:
> * 'adc@' is either spmi-iadc or spmi-vadc
> * 'charger@' is either pm8941-charger or pm8941-coincell
> * 'usb-vbus-regulator@' is usb-vbus-regulator
> * 'vibrator@' is now in yaml format, so add it
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> Changes since v1:
> * Change dcdc@ to usb-vbus-regulator@
> * Link to pm8xxx-vib.yaml
> 
>  .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml  | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2 2/3] regulator: dt-bindings: qcom,usb-vbus-regulator: change node name

[Rob Herring]

On Mon, 31 Oct 2022 18:39:32 +0100, Luca Weiss wrote:
> usb-vbus-regulator is a better generic node name than dcdc to change the
> example to match.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> Changes in v2:
> * New patch
> 
>  .../devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2 2/3] regulator: dt-bindings: qcom,usb-vbus-regulator: change node name

[Krzysztof Kozlowski]

On 02/11/2022 06:38, Neil Armstrong wrote:
> Hi,
> 
> On 31/10/2022 18:39, Luca Weiss wrote:
>> usb-vbus-regulator is a better generic node name than dcdc to change the
>> example to match.
> 
> Subject is wrong, should be something like:
> dt-bindings: regulator: qcom,usb-vbus-regulator: update example node name
> 

No, subject is correct.

Best regards,
Krzysztof

Re: [PATCH v2 1/3] dt-bindings: mfd: qcom,spmi-pmic: support more types

[Lee Jones]

On Mon, 31 Oct 2022, Luca Weiss wrote:

> * 'adc@' is either spmi-iadc or spmi-vadc
> * 'charger@' is either pm8941-charger or pm8941-coincell
> * 'usb-vbus-regulator@' is usb-vbus-regulator
> * 'vibrator@' is now in yaml format, so add it
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> Changes since v1:
> * Change dcdc@ to usb-vbus-regulator@
> * Link to pm8xxx-vib.yaml
> 
>  .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml  | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)

I don't see the other 2 patches.

Is this okay to take on its own?

> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index 777f2da52f1e..cf10d62ace54 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -105,7 +105,9 @@ properties:
>  patternProperties:
>    "^adc@[0-9a-f]+$":
>      type: object
> -    $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml#
> +    oneOf:
> +      - $ref: /schemas/iio/adc/qcom,spmi-iadc.yaml#
> +      - $ref: /schemas/iio/adc/qcom,spmi-vadc.yaml#
>  
>    "^adc-tm@[0-9a-f]+$":
>      type: object
> @@ -115,6 +117,12 @@ patternProperties:
>      type: object
>      additionalProperties: true # FIXME qcom,pm8916-wcd-analog-codec binding not converted yet
>  
> +  "^charger@[0-9a-f]+$":
> +    type: object
> +    oneOf:
> +      - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
> +      - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
> +
>    "extcon@[0-9a-f]+$":
>      type: object
>      $ref: /schemas/extcon/qcom,pm8941-misc.yaml#
> @@ -135,9 +143,13 @@ patternProperties:
>      type: object
>      $ref: /schemas/thermal/qcom,spmi-temp-alarm.yaml#
>  
> +  "^usb-vbus-regulator@[0-9a-f]+$":
> +    type: object
> +    $ref: /schemas/regulator/qcom,usb-vbus-regulator.yaml#
> +
>    "^vibrator@[0-9a-f]+$":
>      type: object
> -    additionalProperties: true # FIXME qcom,pm8916-vib binding not converted yet
> +    $ref: /schemas/input/qcom,pm8xxx-vib.yaml#
>  
>    "^mpps@[0-9a-f]+$":
>      type: object

-- 
Lee Jones [李琼斯]

Re: (subset) [PATCH v2 1/3] dt-bindings: mfd: qcom,spmi-pmic: support more types

[Bjorn Andersson]

On Mon, 31 Oct 2022 18:39:31 +0100, Luca Weiss wrote:
> * 'adc@' is either spmi-iadc or spmi-vadc
> * 'charger@' is either pm8941-charger or pm8941-coincell
> * 'usb-vbus-regulator@' is usb-vbus-regulator
> * 'vibrator@' is now in yaml format, so add it
> 
> 

Applied, thanks!

[3/3] arm64: dts: qcom: pm8150b: change vbus-regulator node name
      commit: 0c9a86fb9ebc576e66a2ce6a667684431a14d2f1

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH v2 1/3] dt-bindings: mfd: qcom,spmi-pmic: support more types

[Lee Jones]

On Mon, 31 Oct 2022, Luca Weiss wrote:

> * 'adc@' is either spmi-iadc or spmi-vadc
> * 'charger@' is either pm8941-charger or pm8941-coincell
> * 'usb-vbus-regulator@' is usb-vbus-regulator
> * 'vibrator@' is now in yaml format, so add it
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> Changes since v1:
> * Change dcdc@ to usb-vbus-regulator@
> * Link to pm8xxx-vib.yaml
> 
>  .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml  | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)

I fixed up the subject line for you and applied, thanks.

-- 
Lee Jones [李琼斯]

Re: [PATCH v2 2/3] regulator: dt-bindings: qcom,usb-vbus-regulator: change node name

[Luca Weiss]

On Montag, 31. Oktober 2022 18:39:32 CET Luca Weiss wrote:
> usb-vbus-regulator is a better generic node name than dcdc to change the
> example to match.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>

Bump? Can this patch be picked up please?

> ---
> Changes in v2:
> * New patch
> 
>  .../devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
> b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
> index dbe78cd4adba..b1cff3adb21b 100644
> ---
> a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
> +++
> b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
> @@ -33,7 +33,7 @@ examples:
>       pm8150b {
>          #address-cells = <1>;
>          #size-cells = <0>;
> -        pm8150b_vbus: dcdc@1100 {
> +        pm8150b_vbus: usb-vbus-regulator@1100 {
>              compatible = "qcom,pm8150b-vbus-reg";
>              reg = <0x1100>;
>          };

Re: [PATCH v2 2/3] regulator: dt-bindings: qcom,usb-vbus-regulator: change node name

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

On Wed, Dec 28, 2022 at 10:30:47PM +0100, Luca Weiss wrote:
> On Montag, 31. Oktober 2022 18:39:32 CET Luca Weiss wrote:
> > usb-vbus-regulator is a better generic node name than dcdc to change the
> > example to match.
> > 
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> 
> Bump? Can this patch be picked up please?

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2 2/3] regulator: dt-bindings: qcom,usb-vbus-regulator: change node name

[Luca Weiss]

On Donnerstag, 29. Dezember 2022 18:57:15 CET Mark Brown wrote:
> On Wed, Dec 28, 2022 at 10:30:47PM +0100, Luca Weiss wrote:
> > On Montag, 31. Oktober 2022 18:39:32 CET Luca Weiss wrote:
> > > usb-vbus-regulator is a better generic node name than dcdc to change the
> > > example to match.
> > > 
> > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > 
> > Bump? Can this patch be picked up please?
> 
> Please don't send content free pings and please allow a reasonable time
> for review.  People get busy, go on holiday, attend conferences and so
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review.  If there have been
> review comments then people may be waiting for those to be addressed.

The patch was sent end of October, that is two months ago. I don't think two 
months of waiting is an unreasonable amount of time and is also more than "a 
couple of weeks"...

And as far as I am aware there's no open review comments, which is why I did 
send the email to ask what the status is so that it can go into 6.3 and I can 
remove it from my inbox.

Regards
Luca

> 
> Sending content free pings adds to the mail volume (if they are seen at
> all) which is often the problem and since they can't be reviewed
> directly if something has gone wrong you'll have to resend the patches
> anyway, so sending again is generally a better approach though there are
> some other maintainers who like them - if in doubt look at how patches
> for the subsystem are normally handled.

Re: [PATCH v2 2/3] regulator: dt-bindings: qcom,usb-vbus-regulator: change node name

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

On Thu, Dec 29, 2022 at 07:11:10PM +0100, Luca Weiss wrote:

> The patch was sent end of October, that is two months ago. I don't think two 
> months of waiting is an unreasonable amount of time and is also more than "a 
> couple of weeks"...

> And as far as I am aware there's no open review comments, which is why I did 
> send the email to ask what the status is so that it can go into 6.3 and I can 
> remove it from my inbox.

Please read the rest of the mail:

> > directly if something has gone wrong you'll have to resend the patches
> > anyway, so sending again is generally a better approach though there are
> > some other maintainers who like them - if in doubt look at how patches
> > for the subsystem are normally handled.

I can't do anything with your content free ping on patch 2 of
some series...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2 2/3] regulator: dt-bindings: qcom,usb-vbus-regulator: change node name

[Luca Weiss]

On Donnerstag, 29. Dezember 2022 19:43:08 CET Mark Brown wrote:
> On Thu, Dec 29, 2022 at 07:11:10PM +0100, Luca Weiss wrote:
> > The patch was sent end of October, that is two months ago. I don't think
> > two months of waiting is an unreasonable amount of time and is also more
> > than "a couple of weeks"...
> > 
> > And as far as I am aware there's no open review comments, which is why I
> > did send the email to ask what the status is so that it can go into 6.3
> > and I can remove it from my inbox.
> 
> Please read the rest of the mail:
> > > directly if something has gone wrong you'll have to resend the patches
> > > anyway, so sending again is generally a better approach though there are
> > > some other maintainers who like them - if in doubt look at how patches
> > > for the subsystem are normally handled.
> 
> I can't do anything with your content free ping on patch 2 of
> some series...

I'll just resend, that should alleviate all problems.