* [GIT PULL] firmware: arm_scmi: Fixes for v6.1
@ 2022-11-02 14:01 ` Sudeep Holla
0 siblings, 0 replies; 4+ messages in thread
From: Sudeep Holla @ 2022-11-02 14:01 UTC (permalink / raw)
To: ARM SoC Team, SoC Team, ALKML
Cc: Sudeep Holla, Arnd Bergmann, Cristian Marussi, Olof Johansson
Hi ARM SoC Team,
Please pull !
Regards,
Sudeep
-->8
The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780:
Linux 6.1-rc1 (2022-10-16 15:36:24 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git tags/scmi-fixes-6.1
for you to fetch changes up to 1eff6929aff594fba3182660f7b6213ec0ceda0c:
firmware: arm_scmi: Fix deferred_tx_wq release on error paths (2022-11-01 11:36:20 +0000)
----------------------------------------------------------------
Arm SCMI fixes for v6.1
A bunch of fixes to handle:
1. A possible resource leak in scmi_remove(). The returned error
value gets ignored by the driver core and can remove the device and
free the devm-allocated resources. As a simple solution to be able to
easily backport, the bind attributes in the driver is suppressed as
there is no need to support it. Additionally the remove path is cleaned
up by adding device links between the core and the protocol devices
so that a proper and complete unbinding happens.
2. A possible spin-loop in the SCMI transmit path in case of misbehaving
platform firmware. A timeout is added to the existing loop so that
the SCMI stack can bailout aborting the transmission with warnings.
3. Optional Rx channel correctly by reporting any memory errors instead
of ignoring the same with other allowed errors.
4. The use of proper device for all the device managed allocations in the
virtio transport.
5. Incorrect deferred_tx_wq release on the error paths by using devres
API(devm_add_action_or_reset) to manage the release in the error path.
----------------------------------------------------------------
Cristian Marussi (6):
firmware: arm_scmi: Cleanup the core driver removal callback
firmware: arm_scmi: Suppress the driver's bind attributes
firmware: arm_scmi: Make tx_prepare time out eventually
firmware: arm_scmi: Make Rx chan_setup fail on memory errors
firmware: arm_scmi: Fix devres allocation device in virtio transport
firmware: arm_scmi: Fix deferred_tx_wq release on error paths
drivers/firmware/arm_scmi/bus.c | 11 ++++++++++
drivers/firmware/arm_scmi/common.h | 5 ++++-
drivers/firmware/arm_scmi/driver.c | 41 ++++++++++++++++++++++++-------------
drivers/firmware/arm_scmi/mailbox.c | 2 +-
drivers/firmware/arm_scmi/optee.c | 2 +-
drivers/firmware/arm_scmi/shmem.c | 31 ++++++++++++++++++++++++----
drivers/firmware/arm_scmi/smc.c | 2 +-
drivers/firmware/arm_scmi/virtio.c | 26 ++++++++++++++---------
8 files changed, 88 insertions(+), 32 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [GIT PULL] firmware: arm_scmi: Fixes for v6.1
@ 2022-11-02 14:01 ` Sudeep Holla
0 siblings, 0 replies; 4+ messages in thread
From: Sudeep Holla @ 2022-11-02 14:01 UTC (permalink / raw)
To: ARM SoC Team, SoC Team, ALKML
Cc: Sudeep Holla, Arnd Bergmann, Cristian Marussi, Olof Johansson
Hi ARM SoC Team,
Please pull !
Regards,
Sudeep
-->8
The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780:
Linux 6.1-rc1 (2022-10-16 15:36:24 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git tags/scmi-fixes-6.1
for you to fetch changes up to 1eff6929aff594fba3182660f7b6213ec0ceda0c:
firmware: arm_scmi: Fix deferred_tx_wq release on error paths (2022-11-01 11:36:20 +0000)
----------------------------------------------------------------
Arm SCMI fixes for v6.1
A bunch of fixes to handle:
1. A possible resource leak in scmi_remove(). The returned error
value gets ignored by the driver core and can remove the device and
free the devm-allocated resources. As a simple solution to be able to
easily backport, the bind attributes in the driver is suppressed as
there is no need to support it. Additionally the remove path is cleaned
up by adding device links between the core and the protocol devices
so that a proper and complete unbinding happens.
2. A possible spin-loop in the SCMI transmit path in case of misbehaving
platform firmware. A timeout is added to the existing loop so that
the SCMI stack can bailout aborting the transmission with warnings.
3. Optional Rx channel correctly by reporting any memory errors instead
of ignoring the same with other allowed errors.
4. The use of proper device for all the device managed allocations in the
virtio transport.
5. Incorrect deferred_tx_wq release on the error paths by using devres
API(devm_add_action_or_reset) to manage the release in the error path.
----------------------------------------------------------------
Cristian Marussi (6):
firmware: arm_scmi: Cleanup the core driver removal callback
firmware: arm_scmi: Suppress the driver's bind attributes
firmware: arm_scmi: Make tx_prepare time out eventually
firmware: arm_scmi: Make Rx chan_setup fail on memory errors
firmware: arm_scmi: Fix devres allocation device in virtio transport
firmware: arm_scmi: Fix deferred_tx_wq release on error paths
drivers/firmware/arm_scmi/bus.c | 11 ++++++++++
drivers/firmware/arm_scmi/common.h | 5 ++++-
drivers/firmware/arm_scmi/driver.c | 41 ++++++++++++++++++++++++-------------
drivers/firmware/arm_scmi/mailbox.c | 2 +-
drivers/firmware/arm_scmi/optee.c | 2 +-
drivers/firmware/arm_scmi/shmem.c | 31 ++++++++++++++++++++++++----
drivers/firmware/arm_scmi/smc.c | 2 +-
drivers/firmware/arm_scmi/virtio.c | 26 ++++++++++++++---------
8 files changed, 88 insertions(+), 32 deletions(-)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] firmware: arm_scmi: Fixes for v6.1
2022-11-02 14:01 ` Sudeep Holla
(?)
@ 2022-11-02 21:10 ` patchwork-bot+linux-soc
-1 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-soc @ 2022-11-02 21:10 UTC (permalink / raw)
To: Sudeep Holla; +Cc: soc
Hello:
This pull request was applied to soc/soc.git (arm/fixes)
by Arnd Bergmann <arnd@arndb.de>:
On Wed, 2 Nov 2022 14:01:42 +0000 you wrote:
> Hi ARM SoC Team,
>
> Please pull !
>
> Regards,
> Sudeep
>
> [...]
Here is the summary with links:
- [GIT,PULL] firmware: arm_scmi: Fixes for v6.1
https://git.kernel.org/soc/soc/c/f76c745151e0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] firmware: arm_scmi: Fixes for v6.1
2022-11-02 14:01 ` Sudeep Holla
(?)
(?)
@ 2022-11-02 21:10 ` patchwork-bot+linux-soc
-1 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-soc @ 2022-11-02 21:10 UTC (permalink / raw)
To: Sudeep Holla; +Cc: soc
Hello:
This pull request was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:
On Wed, 2 Nov 2022 14:01:42 +0000 you wrote:
> Hi ARM SoC Team,
>
> Please pull !
>
> Regards,
> Sudeep
>
> [...]
Here is the summary with links:
- [GIT,PULL] firmware: arm_scmi: Fixes for v6.1
https://git.kernel.org/soc/soc/c/f76c745151e0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-02 21:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-02 14:01 [GIT PULL] firmware: arm_scmi: Fixes for v6.1 Sudeep Holla
2022-11-02 14:01 ` Sudeep Holla
2022-11-02 21:10 ` patchwork-bot+linux-soc
2022-11-02 21:10 ` patchwork-bot+linux-soc
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.