* [PATCH v3 1/2] dt-bindings: net: constrain number of 'reg' in ethernet ports
@ 2022-11-02 16:15 Krzysztof Kozlowski
2022-11-02 16:15 ` [PATCH v3 2/2] dt-bindings: net: dsa-port: constrain number of 'reg' in ports Krzysztof Kozlowski
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-02 16:15 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Andrew Lunn, Vivien Didelot,
Florian Fainelli, Vladimir Oltean, Oleksij Rempel, netdev,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Oleksij Rempel
'reg' without any constraints allows multiple items which is not the
intention for Ethernet controller's port number.
Constrain the 'reg' on AX88178 and LAN95xx USB Ethernet Controllers.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
Changes since v2:
1. Drop changes to switches.
2. Add Rb tag.
Changes since v1:
1. Drop change to non-accepted renesas,r8a779f0-ether-switch.
---
Documentation/devicetree/bindings/net/asix,ax88178.yaml | 4 +++-
Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/asix,ax88178.yaml b/Documentation/devicetree/bindings/net/asix,ax88178.yaml
index 1af52358de4c..a81dbc4792f6 100644
--- a/Documentation/devicetree/bindings/net/asix,ax88178.yaml
+++ b/Documentation/devicetree/bindings/net/asix,ax88178.yaml
@@ -27,7 +27,9 @@ properties:
- usbb95,772b # ASIX AX88772B
- usbb95,7e2b # ASIX AX88772B
- reg: true
+ reg:
+ maxItems: 1
+
local-mac-address: true
mac-address: true
diff --git a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
index cf91fecd8909..3715c5f8f0e0 100644
--- a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
+++ b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
@@ -39,7 +39,9 @@ properties:
- usb424,9e08 # SMSC LAN89530 USB Ethernet Device
- usb424,ec00 # SMSC9512/9514 USB Hub & Ethernet Device
- reg: true
+ reg:
+ maxItems: 1
+
local-mac-address: true
mac-address: true
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v3 2/2] dt-bindings: net: dsa-port: constrain number of 'reg' in ports
2022-11-02 16:15 [PATCH v3 1/2] dt-bindings: net: constrain number of 'reg' in ethernet ports Krzysztof Kozlowski
@ 2022-11-02 16:15 ` Krzysztof Kozlowski
2022-11-04 21:52 ` Rob Herring
2022-11-04 22:39 ` Florian Fainelli
2022-11-04 21:51 ` [PATCH v3 1/2] dt-bindings: net: constrain number of 'reg' in ethernet ports Rob Herring
` (2 subsequent siblings)
3 siblings, 2 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-02 16:15 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Andrew Lunn, Vivien Didelot,
Florian Fainelli, Vladimir Oltean, Oleksij Rempel, netdev,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
'reg' without any constraints allows multiple items which is not the
intention in DSA port schema (as physical port is expected to have only
one address).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v2:
1. New patch
---
Documentation/devicetree/bindings/net/dsa/dsa-port.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml
index 10ad7e71097b..9abb8eba5fad 100644
--- a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml
@@ -19,7 +19,8 @@ allOf:
properties:
reg:
- description: Port number
+ items:
+ - description: Port number
label:
description:
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v3 2/2] dt-bindings: net: dsa-port: constrain number of 'reg' in ports
2022-11-02 16:15 ` [PATCH v3 2/2] dt-bindings: net: dsa-port: constrain number of 'reg' in ports Krzysztof Kozlowski
@ 2022-11-04 21:52 ` Rob Herring
2022-11-04 22:39 ` Florian Fainelli
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-11-04 21:52 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vladimir Oltean, Andrew Lunn, linux-kernel, Rob Herring,
Jakub Kicinski, Krzysztof Kozlowski, Paolo Abeni,
David S. Miller, Vivien Didelot, Eric Dumazet, Florian Fainelli,
devicetree, Oleksij Rempel, netdev
On Wed, 02 Nov 2022 12:15:12 -0400, Krzysztof Kozlowski wrote:
> 'reg' without any constraints allows multiple items which is not the
> intention in DSA port schema (as physical port is expected to have only
> one address).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes since v2:
> 1. New patch
> ---
> Documentation/devicetree/bindings/net/dsa/dsa-port.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings: net: dsa-port: constrain number of 'reg' in ports
2022-11-02 16:15 ` [PATCH v3 2/2] dt-bindings: net: dsa-port: constrain number of 'reg' in ports Krzysztof Kozlowski
2022-11-04 21:52 ` Rob Herring
@ 2022-11-04 22:39 ` Florian Fainelli
1 sibling, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2022-11-04 22:39 UTC (permalink / raw)
To: Krzysztof Kozlowski, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
Andrew Lunn, Vivien Didelot, Vladimir Oltean, Oleksij Rempel,
netdev, devicetree, linux-kernel
On 11/2/22 09:15, Krzysztof Kozlowski wrote:
> 'reg' without any constraints allows multiple items which is not the
> intention in DSA port schema (as physical port is expected to have only
> one address).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: net: constrain number of 'reg' in ethernet ports
2022-11-02 16:15 [PATCH v3 1/2] dt-bindings: net: constrain number of 'reg' in ethernet ports Krzysztof Kozlowski
2022-11-02 16:15 ` [PATCH v3 2/2] dt-bindings: net: dsa-port: constrain number of 'reg' in ports Krzysztof Kozlowski
@ 2022-11-04 21:51 ` Rob Herring
2022-11-04 22:39 ` Florian Fainelli
2022-11-07 8:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-11-04 21:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski,
David S. Miller, Rob Herring, Andrew Lunn, Oleksij Rempel,
devicetree, Eric Dumazet, Vladimir Oltean, Oleksij Rempel,
netdev, linux-kernel, Florian Fainelli, Vivien Didelot
On Wed, 02 Nov 2022 12:15:11 -0400, Krzysztof Kozlowski wrote:
> 'reg' without any constraints allows multiple items which is not the
> intention for Ethernet controller's port number.
>
> Constrain the 'reg' on AX88178 and LAN95xx USB Ethernet Controllers.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
>
> ---
>
> Changes since v2:
> 1. Drop changes to switches.
> 2. Add Rb tag.
>
> Changes since v1:
> 1. Drop change to non-accepted renesas,r8a779f0-ether-switch.
> ---
> Documentation/devicetree/bindings/net/asix,ax88178.yaml | 4 +++-
> Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 4 +++-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: net: constrain number of 'reg' in ethernet ports
2022-11-02 16:15 [PATCH v3 1/2] dt-bindings: net: constrain number of 'reg' in ethernet ports Krzysztof Kozlowski
2022-11-02 16:15 ` [PATCH v3 2/2] dt-bindings: net: dsa-port: constrain number of 'reg' in ports Krzysztof Kozlowski
2022-11-04 21:51 ` [PATCH v3 1/2] dt-bindings: net: constrain number of 'reg' in ethernet ports Rob Herring
@ 2022-11-04 22:39 ` Florian Fainelli
2022-11-07 8:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2022-11-04 22:39 UTC (permalink / raw)
To: Krzysztof Kozlowski, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Rob Herring, Krzysztof Kozlowski,
Andrew Lunn, Vivien Didelot, Vladimir Oltean, Oleksij Rempel,
netdev, devicetree, linux-kernel
Cc: Oleksij Rempel
On 11/2/22 09:15, Krzysztof Kozlowski wrote:
> 'reg' without any constraints allows multiple items which is not the
> intention for Ethernet controller's port number.
>
> Constrain the 'reg' on AX88178 and LAN95xx USB Ethernet Controllers.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: net: constrain number of 'reg' in ethernet ports
2022-11-02 16:15 [PATCH v3 1/2] dt-bindings: net: constrain number of 'reg' in ethernet ports Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-11-04 22:39 ` Florian Fainelli
@ 2022-11-07 8:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-07 8:50 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
andrew, vivien.didelot, f.fainelli, olteanv, linux, netdev,
devicetree, linux-kernel, o.rempel
Hello:
This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 2 Nov 2022 12:15:11 -0400 you wrote:
> 'reg' without any constraints allows multiple items which is not the
> intention for Ethernet controller's port number.
>
> Constrain the 'reg' on AX88178 and LAN95xx USB Ethernet Controllers.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
>
> [...]
Here is the summary with links:
- [v3,1/2] dt-bindings: net: constrain number of 'reg' in ethernet ports
https://git.kernel.org/netdev/net-next/c/bd881b44fdbc
- [v3,2/2] dt-bindings: net: dsa-port: constrain number of 'reg' in ports
https://git.kernel.org/netdev/net-next/c/a352a2c5d2a5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-11-07 8:50 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-02 16:15 [PATCH v3 1/2] dt-bindings: net: constrain number of 'reg' in ethernet ports Krzysztof Kozlowski
2022-11-02 16:15 ` [PATCH v3 2/2] dt-bindings: net: dsa-port: constrain number of 'reg' in ports Krzysztof Kozlowski
2022-11-04 21:52 ` Rob Herring
2022-11-04 22:39 ` Florian Fainelli
2022-11-04 21:51 ` [PATCH v3 1/2] dt-bindings: net: constrain number of 'reg' in ethernet ports Rob Herring
2022-11-04 22:39 ` Florian Fainelli
2022-11-07 8:50 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.