* [PATCH 0/4] arm64: dts: qcom: sm8450: add SDHCI
@ 2022-10-26 20:03 Krzysztof Kozlowski
2022-10-26 20:03 ` [PATCH 1/4] arm64: dts: qcom: sm8450: move SDHCI pin configuration to DTSI Krzysztof Kozlowski
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-26 20:03 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Dmitry Baryshkov
Hi,
Depends on:
https://lore.kernel.org/all/20220410205127.1670705-2-dmitry.baryshkov@linaro.org/
Best regards,
Krzysztof
Krzysztof Kozlowski (4):
arm64: dts: qcom: sm8450: move SDHCI pin configuration to DTSI
arm64: dts: qcom: sm8450: disable SDHCI SDR104/SDR50 on all boards
arm64: dts: qcom: sm8450-hdk: add SDHCI for microSD
arm64: dts: qcom: sm8450-qrd: add SDHCI for microSD
arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 19 +++++++++++++++
arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 19 +++++++++++++++
.../qcom/sm8450-sony-xperia-nagara-pdx223.dts | 22 ------------------
arch/arm64/boot/dts/qcom/sm8450.dtsi | 23 +++++++++++++++++++
4 files changed, 61 insertions(+), 22 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/4] arm64: dts: qcom: sm8450: move SDHCI pin configuration to DTSI
2022-10-26 20:03 [PATCH 0/4] arm64: dts: qcom: sm8450: add SDHCI Krzysztof Kozlowski
@ 2022-10-26 20:03 ` Krzysztof Kozlowski
2022-10-26 20:11 ` Konrad Dybcio
2022-10-26 20:03 ` [PATCH 2/4] arm64: dts: qcom: sm8450: disable SDHCI SDR104/SDR50 on all boards Krzysztof Kozlowski
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-26 20:03 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Dmitry Baryshkov
The SDHCI pin configuration/mux nodes are actually common to all
upstreamed boards, so define them in SoC DTSI to reduce code
duplication.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
In theory drive strength belongs to the board DTS, not SoC DTSI, but I
am following the advice here:
https://lore.kernel.org/lkml/CAD=FV=VUL4GmjaibAMhKNdpEso_Hg_R=XeMaqah1LSj_9-Ce4Q@mail.gmail.com/
---
.../qcom/sm8450-sony-xperia-nagara-pdx223.dts | 20 -------------------
arch/arm64/boot/dts/qcom/sm8450.dtsi | 20 +++++++++++++++++++
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
index 82918c2d956f..718c690af8ad 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
@@ -572,26 +572,6 @@ &spi10 {
&tlmm {
gpio-reserved-ranges = <28 4>;
- sdc2_default_state: sdc2-default-state {
- clk-pins {
- pins = "sdc2_clk";
- drive-strength = <16>;
- bias-disable;
- };
-
- cmd-pins {
- pins = "sdc2_cmd";
- drive-strength = <16>;
- bias-pull-up;
- };
-
- data-pins {
- pins = "sdc2_data";
- drive-strength = <16>;
- bias-pull-up;
- };
- };
-
ts_int_default: ts-int-default-state {
pins = "gpio23";
function = "gpio";
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 1d1775334575..1df5c964c6f7 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -2515,6 +2515,26 @@ tlmm: pinctrl@f100000 {
gpio-ranges = <&tlmm 0 0 211>;
wakeup-parent = <&pdc>;
+ sdc2_default_state: sdc2-default-state {
+ clk-pins {
+ pins = "sdc2_clk";
+ drive-strength = <16>;
+ bias-disable;
+ };
+
+ cmd-pins {
+ pins = "sdc2_cmd";
+ drive-strength = <16>;
+ bias-pull-up;
+ };
+
+ data-pins {
+ pins = "sdc2_data";
+ drive-strength = <16>;
+ bias-pull-up;
+ };
+ };
+
sdc2_sleep_state: sdc2-sleep-state {
clk-pins {
pins = "sdc2_clk";
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/4] arm64: dts: qcom: sm8450: disable SDHCI SDR104/SDR50 on all boards
2022-10-26 20:03 [PATCH 0/4] arm64: dts: qcom: sm8450: add SDHCI Krzysztof Kozlowski
2022-10-26 20:03 ` [PATCH 1/4] arm64: dts: qcom: sm8450: move SDHCI pin configuration to DTSI Krzysztof Kozlowski
@ 2022-10-26 20:03 ` Krzysztof Kozlowski
2022-10-26 20:12 ` Konrad Dybcio
2022-10-26 20:03 ` [PATCH 3/4] arm64: dts: qcom: sm8450-hdk: add SDHCI for microSD Krzysztof Kozlowski
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-26 20:03 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Dmitry Baryshkov
SDHCI on SM8450 HDK also has problems with SDR104/SDR50:
mmc0: card never left busy state
mmc0: error -110 whilst initialising SD card
so I think it is safe to assume this issue affects all SM8450 boards.
Move the quirk disallowing these modes to the SoC DTSI, to spare people
working on other boards the misery of debugging this issue.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts | 2 --
arch/arm64/boot/dts/qcom/sm8450.dtsi | 3 +++
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
index 718c690af8ad..ae8ba297b0b6 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
@@ -556,8 +556,6 @@ &sdhc_2 {
pinctrl-1 = <&sdc2_sleep_state &sdc2_card_det_n>;
vmmc-supply = <&pm8350c_l9>;
vqmmc-supply = <&pm8350c_l6>;
- /* Forbid SDR104/SDR50 - broken hw! */
- sdhci-caps-mask = <0x3 0x0>;
no-sdio;
no-mmc;
status = "okay";
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 1df5c964c6f7..6800e05a549d 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -3412,6 +3412,9 @@ sdhc_2: sdhci@8804000 {
bus-width = <4>;
dma-coherent;
+ /* Forbid SDR104/SDR50 - broken hw! */
+ sdhci-caps-mask = <0x3 0x0>;
+
status = "disabled";
sdhc2_opp_table: opp-table {
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/4] arm64: dts: qcom: sm8450-hdk: add SDHCI for microSD
2022-10-26 20:03 [PATCH 0/4] arm64: dts: qcom: sm8450: add SDHCI Krzysztof Kozlowski
2022-10-26 20:03 ` [PATCH 1/4] arm64: dts: qcom: sm8450: move SDHCI pin configuration to DTSI Krzysztof Kozlowski
2022-10-26 20:03 ` [PATCH 2/4] arm64: dts: qcom: sm8450: disable SDHCI SDR104/SDR50 on all boards Krzysztof Kozlowski
@ 2022-10-26 20:03 ` Krzysztof Kozlowski
2022-10-26 20:12 ` Konrad Dybcio
2022-10-26 20:03 ` [PATCH 4/4] arm64: dts: qcom: sm8450-qrd: " Krzysztof Kozlowski
2022-11-07 3:12 ` [PATCH 0/4] arm64: dts: qcom: sm8450: add SDHCI Bjorn Andersson
4 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-26 20:03 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Dmitry Baryshkov
The HDK8450 has microSD card slot.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
index 3ccbdd2ed734..f4a5f1a8e573 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
@@ -426,6 +426,18 @@ &remoteproc_slpi {
firmware-name = "qcom/sm8450/slpi.mbn";
};
+&sdhc_2 {
+ cd-gpios = <&tlmm 92 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&sdc2_default_state &sdc2_card_det_n>;
+ pinctrl-1 = <&sdc2_sleep_state &sdc2_card_det_n>;
+ vmmc-supply = <&vreg_l9c_2p96>;
+ vqmmc-supply = <&vreg_l6c_1p8>;
+ no-sdio;
+ no-mmc;
+ status = "okay";
+};
+
&tlmm {
gpio-reserved-ranges = <28 4>, <36 4>;
@@ -461,6 +473,13 @@ pinconf {
bias-pull-down;
};
};
+
+ sdc2_card_det_n: sd-card-det-n-state {
+ pins = "gpio92";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
};
&uart7 {
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/4] arm64: dts: qcom: sm8450-qrd: add SDHCI for microSD
2022-10-26 20:03 [PATCH 0/4] arm64: dts: qcom: sm8450: add SDHCI Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-10-26 20:03 ` [PATCH 3/4] arm64: dts: qcom: sm8450-hdk: add SDHCI for microSD Krzysztof Kozlowski
@ 2022-10-26 20:03 ` Krzysztof Kozlowski
2022-10-26 20:13 ` Konrad Dybcio
2022-11-07 3:12 ` [PATCH 0/4] arm64: dts: qcom: sm8450: add SDHCI Bjorn Andersson
4 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-26 20:03 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Dmitry Baryshkov
Based on downstream DTS, it seems that SM8450 QRD has microSD card slot.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Not tested.
---
arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
index 017bc48430ba..c9a08608ccf4 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
@@ -427,6 +427,18 @@ &remoteproc_slpi {
firmware-name = "qcom/sm8450/slpi.mbn";
};
+&sdhc_2 {
+ cd-gpios = <&tlmm 92 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&sdc2_default_state &sdc2_card_det_n>;
+ pinctrl-1 = <&sdc2_sleep_state &sdc2_card_det_n>;
+ vmmc-supply = <&vreg_l9c_2p96>;
+ vqmmc-supply = <&vreg_l6c_1p8>;
+ no-sdio;
+ no-mmc;
+ status = "okay";
+};
+
&spi4 {
status = "okay";
};
@@ -474,6 +486,13 @@ pinconf {
bias-pull-down;
};
};
+
+ sdc2_card_det_n: sd-card-det-n-state {
+ pins = "gpio92";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
};
&uart7 {
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] arm64: dts: qcom: sm8450: move SDHCI pin configuration to DTSI
2022-10-26 20:03 ` [PATCH 1/4] arm64: dts: qcom: sm8450: move SDHCI pin configuration to DTSI Krzysztof Kozlowski
@ 2022-10-26 20:11 ` Konrad Dybcio
0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-10-26 20:11 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Dmitry Baryshkov
On 26/10/2022 22:03, Krzysztof Kozlowski wrote:
> The SDHCI pin configuration/mux nodes are actually common to all
> upstreamed boards, so define them in SoC DTSI to reduce code
> duplication.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
>
> In theory drive strength belongs to the board DTS, not SoC DTSI, but I
> am following the advice here:
> https://lore.kernel.org/lkml/CAD=FV=VUL4GmjaibAMhKNdpEso_Hg_R=XeMaqah1LSj_9-Ce4Q@mail.gmail.com/
> ---
> .../qcom/sm8450-sony-xperia-nagara-pdx223.dts | 20 -------------------
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 20 +++++++++++++++++++
> 2 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
> index 82918c2d956f..718c690af8ad 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
> @@ -572,26 +572,6 @@ &spi10 {
> &tlmm {
> gpio-reserved-ranges = <28 4>;
>
> - sdc2_default_state: sdc2-default-state {
> - clk-pins {
> - pins = "sdc2_clk";
> - drive-strength = <16>;
> - bias-disable;
> - };
> -
> - cmd-pins {
> - pins = "sdc2_cmd";
> - drive-strength = <16>;
> - bias-pull-up;
> - };
> -
> - data-pins {
> - pins = "sdc2_data";
> - drive-strength = <16>;
> - bias-pull-up;
> - };
> - };
> -
> ts_int_default: ts-int-default-state {
> pins = "gpio23";
> function = "gpio";
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 1d1775334575..1df5c964c6f7 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -2515,6 +2515,26 @@ tlmm: pinctrl@f100000 {
> gpio-ranges = <&tlmm 0 0 211>;
> wakeup-parent = <&pdc>;
>
> + sdc2_default_state: sdc2-default-state {
> + clk-pins {
> + pins = "sdc2_clk";
> + drive-strength = <16>;
> + bias-disable;
> + };
> +
> + cmd-pins {
> + pins = "sdc2_cmd";
> + drive-strength = <16>;
> + bias-pull-up;
> + };
> +
> + data-pins {
> + pins = "sdc2_data";
> + drive-strength = <16>;
> + bias-pull-up;
> + };
> + };
> +
> sdc2_sleep_state: sdc2-sleep-state {
> clk-pins {
> pins = "sdc2_clk";
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/4] arm64: dts: qcom: sm8450: disable SDHCI SDR104/SDR50 on all boards
2022-10-26 20:03 ` [PATCH 2/4] arm64: dts: qcom: sm8450: disable SDHCI SDR104/SDR50 on all boards Krzysztof Kozlowski
@ 2022-10-26 20:12 ` Konrad Dybcio
0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-10-26 20:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Dmitry Baryshkov
On 26/10/2022 22:03, Krzysztof Kozlowski wrote:
> SDHCI on SM8450 HDK also has problems with SDR104/SDR50:
>
> mmc0: card never left busy state
> mmc0: error -110 whilst initialising SD card
>
> so I think it is safe to assume this issue affects all SM8450 boards.
> Move the quirk disallowing these modes to the SoC DTSI, to spare people
> working on other boards the misery of debugging this issue.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
While I have no way to tell whether this is a common issue, it may as
well be..
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts | 2 --
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 3 +++
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
> index 718c690af8ad..ae8ba297b0b6 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara-pdx223.dts
> @@ -556,8 +556,6 @@ &sdhc_2 {
> pinctrl-1 = <&sdc2_sleep_state &sdc2_card_det_n>;
> vmmc-supply = <&pm8350c_l9>;
> vqmmc-supply = <&pm8350c_l6>;
> - /* Forbid SDR104/SDR50 - broken hw! */
> - sdhci-caps-mask = <0x3 0x0>;
> no-sdio;
> no-mmc;
> status = "okay";
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 1df5c964c6f7..6800e05a549d 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -3412,6 +3412,9 @@ sdhc_2: sdhci@8804000 {
> bus-width = <4>;
> dma-coherent;
>
> + /* Forbid SDR104/SDR50 - broken hw! */
> + sdhci-caps-mask = <0x3 0x0>;
> +
> status = "disabled";
>
> sdhc2_opp_table: opp-table {
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/4] arm64: dts: qcom: sm8450-hdk: add SDHCI for microSD
2022-10-26 20:03 ` [PATCH 3/4] arm64: dts: qcom: sm8450-hdk: add SDHCI for microSD Krzysztof Kozlowski
@ 2022-10-26 20:12 ` Konrad Dybcio
0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-10-26 20:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Dmitry Baryshkov
On 26/10/2022 22:03, Krzysztof Kozlowski wrote:
> The HDK8450 has microSD card slot.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> index 3ccbdd2ed734..f4a5f1a8e573 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> @@ -426,6 +426,18 @@ &remoteproc_slpi {
> firmware-name = "qcom/sm8450/slpi.mbn";
> };
>
> +&sdhc_2 {
> + cd-gpios = <&tlmm 92 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&sdc2_default_state &sdc2_card_det_n>;
> + pinctrl-1 = <&sdc2_sleep_state &sdc2_card_det_n>;
> + vmmc-supply = <&vreg_l9c_2p96>;
> + vqmmc-supply = <&vreg_l6c_1p8>;
> + no-sdio;
> + no-mmc;
> + status = "okay";
> +};
> +
> &tlmm {
> gpio-reserved-ranges = <28 4>, <36 4>;
>
> @@ -461,6 +473,13 @@ pinconf {
> bias-pull-down;
> };
> };
> +
> + sdc2_card_det_n: sd-card-det-n-state {
> + pins = "gpio92";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> };
>
> &uart7 {
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4/4] arm64: dts: qcom: sm8450-qrd: add SDHCI for microSD
2022-10-26 20:03 ` [PATCH 4/4] arm64: dts: qcom: sm8450-qrd: " Krzysztof Kozlowski
@ 2022-10-26 20:13 ` Konrad Dybcio
0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-10-26 20:13 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Dmitry Baryshkov
On 26/10/2022 22:03, Krzysztof Kozlowski wrote:
> Based on downstream DTS, it seems that SM8450 QRD has microSD card slot.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Not tested.
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
> index 017bc48430ba..c9a08608ccf4 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
> @@ -427,6 +427,18 @@ &remoteproc_slpi {
> firmware-name = "qcom/sm8450/slpi.mbn";
> };
>
> +&sdhc_2 {
> + cd-gpios = <&tlmm 92 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&sdc2_default_state &sdc2_card_det_n>;
> + pinctrl-1 = <&sdc2_sleep_state &sdc2_card_det_n>;
> + vmmc-supply = <&vreg_l9c_2p96>;
> + vqmmc-supply = <&vreg_l6c_1p8>;
> + no-sdio;
> + no-mmc;
> + status = "okay";
> +};
> +
> &spi4 {
> status = "okay";
> };
> @@ -474,6 +486,13 @@ pinconf {
> bias-pull-down;
> };
> };
> +
> + sdc2_card_det_n: sd-card-det-n-state {
> + pins = "gpio92";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> };
>
> &uart7 {
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/4] arm64: dts: qcom: sm8450: add SDHCI
2022-10-26 20:03 [PATCH 0/4] arm64: dts: qcom: sm8450: add SDHCI Krzysztof Kozlowski
` (3 preceding siblings ...)
2022-10-26 20:03 ` [PATCH 4/4] arm64: dts: qcom: sm8450-qrd: " Krzysztof Kozlowski
@ 2022-11-07 3:12 ` Bjorn Andersson
4 siblings, 0 replies; 10+ messages in thread
From: Bjorn Andersson @ 2022-11-07 3:12 UTC (permalink / raw)
To: krzysztof.kozlowski+dt, devicetree, Rob Herring, linux-arm-msm,
konrad.dybcio, Krzysztof Kozlowski, linux-kernel, Andy Gross
Cc: dmitry.baryshkov
On Wed, 26 Oct 2022 16:03:53 -0400, Krzysztof Kozlowski wrote:
> Depends on:
> https://lore.kernel.org/all/20220410205127.1670705-2-dmitry.baryshkov@linaro.org/
>
> Best regards,
> Krzysztof
>
> Krzysztof Kozlowski (4):
> arm64: dts: qcom: sm8450: move SDHCI pin configuration to DTSI
> arm64: dts: qcom: sm8450: disable SDHCI SDR104/SDR50 on all boards
> arm64: dts: qcom: sm8450-hdk: add SDHCI for microSD
> arm64: dts: qcom: sm8450-qrd: add SDHCI for microSD
>
> [...]
Applied, thanks!
[1/4] arm64: dts: qcom: sm8450: move SDHCI pin configuration to DTSI
commit: a0646262ec94faaf95b3dba8f17774d9762ee9ac
[2/4] arm64: dts: qcom: sm8450: disable SDHCI SDR104/SDR50 on all boards
commit: 9d561dc4e5cc31e757f91eb7bb709d2e2a8c9ce0
[3/4] arm64: dts: qcom: sm8450-hdk: add SDHCI for microSD
commit: 1f52331285ed9f412f85e321ae6574714725d634
[4/4] arm64: dts: qcom: sm8450-qrd: add SDHCI for microSD
commit: 4a5923fe4e1df52fafa4026363a349f30c061a15
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-11-07 3:13 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-26 20:03 [PATCH 0/4] arm64: dts: qcom: sm8450: add SDHCI Krzysztof Kozlowski
2022-10-26 20:03 ` [PATCH 1/4] arm64: dts: qcom: sm8450: move SDHCI pin configuration to DTSI Krzysztof Kozlowski
2022-10-26 20:11 ` Konrad Dybcio
2022-10-26 20:03 ` [PATCH 2/4] arm64: dts: qcom: sm8450: disable SDHCI SDR104/SDR50 on all boards Krzysztof Kozlowski
2022-10-26 20:12 ` Konrad Dybcio
2022-10-26 20:03 ` [PATCH 3/4] arm64: dts: qcom: sm8450-hdk: add SDHCI for microSD Krzysztof Kozlowski
2022-10-26 20:12 ` Konrad Dybcio
2022-10-26 20:03 ` [PATCH 4/4] arm64: dts: qcom: sm8450-qrd: " Krzysztof Kozlowski
2022-10-26 20:13 ` Konrad Dybcio
2022-11-07 3:12 ` [PATCH 0/4] arm64: dts: qcom: sm8450: add SDHCI Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.