* [PATCH] net: broadcom: Fix BCMGENET Kconfig
@ 2022-11-05 9:02 YueHaibing
2022-11-07 20:43 ` Florian Fainelli
2022-11-08 2:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2022-11-05 9:02 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, richardcochran, f.fainelli
Cc: netdev, linux-kernel, YueHaibing
While BCMGENET select BROADCOM_PHY as y, but PTP_1588_CLOCK_OPTIONAL is m,
kconfig warning and build errors:
WARNING: unmet direct dependencies detected for BROADCOM_PHY
Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && PTP_1588_CLOCK_OPTIONAL [=m]
Selected by [y]:
- BCMGENET [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_BROADCOM [=y] && HAS_IOMEM [=y] && ARCH_BCM2835 [=y]
drivers/net/phy/broadcom.o: In function `bcm54xx_suspend':
broadcom.c:(.text+0x6ac): undefined reference to `bcm_ptp_stop'
drivers/net/phy/broadcom.o: In function `bcm54xx_phy_probe':
broadcom.c:(.text+0x784): undefined reference to `bcm_ptp_probe'
drivers/net/phy/broadcom.o: In function `bcm54xx_config_init':
broadcom.c:(.text+0xd4c): undefined reference to `bcm_ptp_config_init'
Fixes: 99addbe31f55 ("net: broadcom: Select BROADCOM_PHY for BCMGENET")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/broadcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index f4e1ca68d831..55dfdb34e37b 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -77,7 +77,7 @@ config BCMGENET
select BCM7XXX_PHY
select MDIO_BCM_UNIMAC
select DIMLIB
- select BROADCOM_PHY if ARCH_BCM2835
+ select BROADCOM_PHY if (ARCH_BCM2835 && PTP_1588_CLOCK_OPTIONAL)
help
This driver supports the built-in Ethernet MACs found in the
Broadcom BCM7xxx Set Top Box family chipset.
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: broadcom: Fix BCMGENET Kconfig
2022-11-05 9:02 [PATCH] net: broadcom: Fix BCMGENET Kconfig YueHaibing
@ 2022-11-07 20:43 ` Florian Fainelli
2022-11-08 2:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2022-11-07 20:43 UTC (permalink / raw)
To: YueHaibing, davem, edumazet, kuba, pabeni, richardcochran
Cc: netdev, linux-kernel
On 11/5/22 02:02, YueHaibing wrote:
> While BCMGENET select BROADCOM_PHY as y, but PTP_1588_CLOCK_OPTIONAL is m,
> kconfig warning and build errors:
>
> WARNING: unmet direct dependencies detected for BROADCOM_PHY
> Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && PTP_1588_CLOCK_OPTIONAL [=m]
> Selected by [y]:
> - BCMGENET [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_BROADCOM [=y] && HAS_IOMEM [=y] && ARCH_BCM2835 [=y]
>
> drivers/net/phy/broadcom.o: In function `bcm54xx_suspend':
> broadcom.c:(.text+0x6ac): undefined reference to `bcm_ptp_stop'
> drivers/net/phy/broadcom.o: In function `bcm54xx_phy_probe':
> broadcom.c:(.text+0x784): undefined reference to `bcm_ptp_probe'
> drivers/net/phy/broadcom.o: In function `bcm54xx_config_init':
> broadcom.c:(.text+0xd4c): undefined reference to `bcm_ptp_config_init'
>
> Fixes: 99addbe31f55 ("net: broadcom: Select BROADCOM_PHY for BCMGENET")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@broadcom.com>
Thanks
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: broadcom: Fix BCMGENET Kconfig
2022-11-05 9:02 [PATCH] net: broadcom: Fix BCMGENET Kconfig YueHaibing
2022-11-07 20:43 ` Florian Fainelli
@ 2022-11-08 2:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-08 2:30 UTC (permalink / raw)
To: YueHaibing
Cc: davem, edumazet, kuba, pabeni, richardcochran, f.fainelli,
netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 5 Nov 2022 17:02:45 +0800 you wrote:
> While BCMGENET select BROADCOM_PHY as y, but PTP_1588_CLOCK_OPTIONAL is m,
> kconfig warning and build errors:
>
> WARNING: unmet direct dependencies detected for BROADCOM_PHY
> Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && PTP_1588_CLOCK_OPTIONAL [=m]
> Selected by [y]:
> - BCMGENET [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_BROADCOM [=y] && HAS_IOMEM [=y] && ARCH_BCM2835 [=y]
>
> [...]
Here is the summary with links:
- net: broadcom: Fix BCMGENET Kconfig
https://git.kernel.org/netdev/net/c/8d820bc9d12b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-08 2:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-05 9:02 [PATCH] net: broadcom: Fix BCMGENET Kconfig YueHaibing
2022-11-07 20:43 ` Florian Fainelli
2022-11-08 2:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.